[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags|fedora-cvs- |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889
--- Comment #12 from Philip Prindeville phil...@redfish-solutions.com ---
(In reply to Paul Howarth from comment #11)
Yes, this should be:
Provides: GeoIP-update = 1.6.0
Obsoletes: GeoIP-update 1.6.0
You could arguably use %{version} in the Provides: line but I think it's
safer to stick with 1.6.0 as geoipupdate looks to have a different numbering
scheme to GeoIP.
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 --- Comment #10 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Provides is wrong. See http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages. I think that EPEL5 has noarch packages. Are you sure the conditional is needed? Otherwise looks OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889
--- Comment #11 from Paul Howarth p...@city-fan.org ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
Provides is wrong. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.
2FReplacing_Existing_Packages.
Yes, this should be:
Provides: GeoIP-update = 1.6.0
Obsoletes: GeoIP-update 1.6.0
You could arguably use %{version} in the Provides: line but I think it's safer
to stick with 1.6.0 as geoipupdate looks to have a different numbering scheme
to GeoIP.
I think that EPEL5 has noarch packages. Are you sure the conditional is
needed?
It's a noarch sub-package, not a noarch package. They were introduced for
F-10/EL-6.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
CC||zbys...@in.waw.pl
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
This in not EPEL material, you can drop the compat cruft:
# Noarch subpackages available from Fedora 10, RHEL 6
%global noarch_subpkgs 0%{?fedora} 9 || 0%{?rhel} 5
rm -rf %{buildroot}
Something strange happens with the provides:
Provides: %{name}-cron = %{version}-%{release}
Obsoletes: %{name}-cron %{version}-%{release}
This is implied, no need to add it.
There's no need to talk about non-Linux (or even non-Fedora) in the package
description. Remove Currently the program only supports Linux and
other Unix- like systems.
Also, you don't need to copy ${SOURCE1} twice. Just install it directly in
%install.
Otherwise looks OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889
--- Comment #5 from Philip Prindeville phil...@redfish-solutions.com ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
This in not EPEL material, you can drop the compat cruft:
# Noarch subpackages available from Fedora 10, RHEL 6
%global noarch_subpkgs 0%{?fedora} 9 || 0%{?rhel} 5
rm -rf %{buildroot}
I need to remove the 'rm' as well?
And why not get this into EPEL? A lot of CentOS users run mail servers with
SpamAssassin, MIMEDefang, and perl-Geo-IP...
Something strange happens with the provides:
Provides: %{name}-cron = %{version}-%{release}
Obsoletes: %{name}-cron %{version}-%{release}
This is implied, no need to add it.
Fixed.
There's no need to talk about non-Linux (or even non-Fedora) in the package
description. Remove Currently the program only supports Linux and
other Unix- like systems.
Actually, that was cut pasted verbatim from website's description of the
package. I figured it was simplest to keep the description in the authors'
words.
Also, you don't need to copy ${SOURCE1} twice. Just install it directly in
%install.
Fixed.
Otherwise looks OK.
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889
--- Comment #6 from Paul Howarth p...@city-fan.org ---
(In reply to Philip Prindeville from comment #5)
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
This in not EPEL material, you can drop the compat cruft:
# Noarch subpackages available from Fedora 10, RHEL 6
%global noarch_subpkgs 0%{?fedora} 9 || 0%{?rhel} 5
rm -rf %{buildroot}
I need to remove the 'rm' as well?
And why not get this into EPEL? A lot of CentOS users run mail servers with
SpamAssassin, MIMEDefang, and perl-Geo-IP...
If you've any intention of updating EPEL to GeoIP 1.6.x then this is a must for
those EPEL branches, as GeoIP would need to depend on it (this was split off
from GeoIP at 1.6).
There's no need to talk about non-Linux (or even non-Fedora) in the package
description. Remove Currently the program only supports Linux and
other Unix- like systems.
Actually, that was cut pasted verbatim from website's description of the
package. I figured it was simplest to keep the description in the authors'
words.
It's probably not worth keeping anything not relevant to Fedora/EPEL users.
Hopefully I'll have time to take a look at this tomorrow.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 --- Comment #7 from Philip Prindeville phil...@redfish-solutions.com --- (In reply to Paul Howarth from comment #6) (In reply to Philip Prindeville from comment #5) If you've any intention of updating EPEL to GeoIP 1.6.x then this is a must for those EPEL branches, as GeoIP would need to depend on it (this was split off from GeoIP at 1.6). That was my thinking. Actually, that was cut pasted verbatim from website's description of the package. I figured it was simplest to keep the description in the authors' words. It's probably not worth keeping anything not relevant to Fedora/EPEL users. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 --- Comment #8 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (In reply to Philip Prindeville from comment #7) (In reply to Paul Howarth from comment #6) (In reply to Philip Prindeville from comment #5) If you've any intention of updating EPEL to GeoIP 1.6.x then this is a must for those EPEL branches, as GeoIP would need to depend on it (this was split off from GeoIP at 1.6). That was my thinking. OK. Actually, that was cut pasted verbatim from website's description of the package. I figured it was simplest to keep the description in the authors' words. It's probably not worth keeping anything not relevant to Fedora/EPEL users. Fixed. It'd help if you uploaded the new version :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 --- Comment #9 from Philip Prindeville phil...@redfish-solutions.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #8) It'd help if you uploaded the new version :) Sorry, thought I had. Just double-checked and it is now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Assignee|philipp@redfish-solutions.c |nob...@fedoraproject.org |om | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|philipp@redfish-solutions.c ||om -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 --- Comment #2 from Philip Prindeville phil...@redfish-solutions.com --- New Package SCM Request === Package Name: geoipupdate Short Description: Utility to download MaxMind GeoIP databases Upstream URL: http://dev.maxmind.com/geoip/geoipupdate/ Owners: philipp pghmcfc Branches: f20 f21 f22 el6 epel7 InitialCC: pghmcfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 --- Comment #3 from Philip Prindeville phil...@redfish-solutions.com --- Subsequently fixed the Provides: and Obsoletes: to get rid of unversioned-explicit-obsoletes. Investigating why rpmlint reports invalid-url: possible lack of support by some websites for HTTP HEAD methods. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1186889 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added CC||philipp@redfish-solutions.c ||om --- Comment #1 from Philip Prindeville phil...@redfish-solutions.com --- rpmlint results: $ rpmlint geoipupdate-2.1.0-1.fc20.src.rpm geoipupdate.src: W: summary-ended-with-dot C Update GeoIP2 and GeoIP Legacy binary databases from MaxMind. geoipupdate.src:16: W: unversioned-explicit-obsoletes GeoIP-update geoipupdate.src:16: W: unversioned-explicit-obsoletes GeoIP-update6 geoipupdate.src:55: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 55) geoipupdate.src: W: invalid-url Source0: http://github.com/maxmind/geoipupdate/releases/download/v2.1.0/geoipupdate-2.1.0.tar.gz HTTP Error 403: Forbidden 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ not sure why we're seeing the last warning, since: $ wget -q -P /tmp 'http://github.com/maxmind/geoipupdate/releases/download/v2.1.0/geoipupdate-2.1.0.tar.gz' $ apparently there's no issue doing a wget of that URL. $ rpmlint geoipupdate.spec geoipupdate.spec:16: W: unversioned-explicit-obsoletes GeoIP-update geoipupdate.spec:16: W: unversioned-explicit-obsoletes GeoIP-update6 geoipupdate.spec:55: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 55) geoipupdate.spec: W: invalid-url Source0: http://github.com/maxmind/geoipupdate/releases/download/v2.1.0/geoipupdate-2.1.0.tar.gz HTTP Error 403: Forbidden 0 packages and 1 specfiles checked; 0 errors, 4 warnings. $ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
