[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2023-08-03 02:17:38 --- Comment #27 from Fedora Update System --- FEDORA-2023-7cce29f715 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c27 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #26 from Fedora Update System --- FEDORA-2023-7cce29f715 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7cce29f715` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7cce29f715 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c26 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #25 from Fedora Update System --- FEDORA-2023-7cce29f715 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7cce29f715 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c25 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #24 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/migrate -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c24 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Mikel Olasagasti Uranga changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #23 from Mikel Olasagasti Uranga --- Thanks for all the changes. This is go2rpm package/spec with some tweaks to adapt to Fedora build's requirements. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [x] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c23 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #22 from Link Dupont --- Spec URL: https://linkdupont.fedorapeople.org/reviews/migrate.spec SRPM URL: https://linkdupont.fedorapeople.org/reviews/migrate-4.16.2-1.fc39.src.rpm Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06207922-migrate/fedora-review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c22 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #21 from Fedora Review Service --- Created attachment 1976943 --> https://bugzilla.redhat.com/attachment.cgi?id=1976943&action=edit The .spec file difference from Copr build 6186417 to 6200299 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c21 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #20 from Link Dupont --- Fixed up the gitlab build issue by including a patch that updates go-gitlab to 0.81.0. I also submitted the patch upstream. Spec URL: https://linkdupont.fedorapeople.org/reviews/migrate.spec SRPM URL: https://linkdupont.fedorapeople.org/reviews/migrate-4.16.2-1.fc39.src.rpm Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06199583-migrate/fedora-review/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c20 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #19 from Link Dupont --- (In reply to Mikel Olasagasti Uranga from comment #18) > For `golang(github.com/google/go-github/v39/github)` you can try to replace > to latest as done at golang-cloud-google.spec or gopass.spec. If it doesn't > work you can either remove that backend, create package > `golang-github-google-go-github-39` or patch the app. Fixed. This was nicer too. It allowed me to include the github source driver. > For golang(github.com/dhui/dktest) removing the files, test files, should be > the easiet. Fixed. > > golang-github-migrate-4-devel.noarch: E: zero-length > > /usr/share/gocode/src/github.com/golang-migrate/migrate/v4/database/crate/README.md > > golang-github-migrate-4-devel.noarch: E: zero-length > > /usr/share/gocode/src/github.com/golang-migrate/migrate/v4/database/shell/README.md > > Do not include those files Fixed. I also noticed a couple issues with the way the 'migrate' program was built. It requires buildtags explicitly; otherwise the driver is not included in the resulting binary. I also added an LDFLAG to set the internal version string to %version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c19 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #18 from Mikel Olasagasti Uranga --- It still fails with: # dnf install https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06186335-migrate/golang-github-migrate-4-devel-4.16.2-1.fc38.noarch.rpm Waiting for process with pid 1373971 to finish. Last metadata expiration check: 0:00:04 ago on 23-07-19 17:41:25. golang-github-migrate-4-devel-4.16.2-1.fc38.noarch.rpm 183 kB/s | 115 kB 00:00 Error: Problem: conflicting requests - nothing provides golang(github.com/dhui/dktest) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/google/go-github/v39/github) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline (try to add '--skip-broken' to skip uninstallable packages) For `golang(github.com/google/go-github/v39/github)` you can try to replace to latest as done at golang-cloud-google.spec or gopass.spec. If it doesn't work you can either remove that backend, create package `golang-github-google-go-github-39` or patch the app. For golang(github.com/dhui/dktest) removing the files, test files, should be the easiet. > golang-github-migrate-4-devel.noarch: E: zero-length > /usr/share/gocode/src/github.com/golang-migrate/migrate/v4/database/crate/README.md > golang-github-migrate-4-devel.noarch: E: zero-length > /usr/share/gocode/src/github.com/golang-migrate/migrate/v4/database/shell/README.md Do not include those files -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c18 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #17 from Fedora Review Service --- Created attachment 1976549 --> https://bugzilla.redhat.com/attachment.cgi?id=1976549&action=edit The .spec file difference from Copr build 6182694 to 6186417 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c17 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #16 from Link Dupont --- You're correct. Using build tags just alters the state of the `migrate` binary, but doesn't change the resulting "gocode" package. I assumed that having source files in the -devel package would be harmless enough, but it appears that they're still used to generate dependencies. I reworked the spec file significantly again. This time I took the "removal approach" as you suggest. I also took the time to include any driver that has dependencies already packaged in Fedora. So the drivers that are removed are the ones that are missing a dependency. It's not as daunting a list as I first assumed, but it's still large enough that I don't want to complicate this review unnecessarily. The good news is many common database and source drivers are now included. Spec URL: https://linkdupont.fedorapeople.org/reviews/migrate.spec SRPM URL: https://linkdupont.fedorapeople.org/reviews/migrate-4.16.2-1.fc39.src.rpm Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06186335-migrate/fedora-review -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c16 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #15 from Mikel Olasagasti Uranga --- It seems `_gobuildtags` is not enough: # dnf install https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06182707-migrate/golang-github-migrate-4-devel-4.16.2-1.fc38.noarch.rpm Last metadata expiration check: 1:47:16 ago on 23-07-19 09:27:29. golang-github-migrate-4-devel-4.16.2-1.fc38.noarch.rpm 176 kB/s | 137 kB 00:00 Error: Problem: conflicting requests - nothing provides golang(cloud.google.com/go/spanner/admin/database/apiv1/databasepb) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/dhui/dktest) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/google/go-github/v39/github) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/jackc/pgerrcode) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/jackc/pgx/v5/pgconn) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/jackc/pgx/v5/stdlib) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/ktrysmt/go-bitbucket) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/microsoft/go-mssqldb) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/mutecomm/go-sqlcipher/v4) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/nakagami/firebirdsql) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(github.com/neo4j/neo4j-go-driver/neo4j) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(modernc.org/ql/driver) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline - nothing provides golang(modernc.org/sqlite) needed by golang-github-migrate-4-devel-4.16.2-1.fc38.noarch from @commandline (try to add '--skip-broken' to skip uninstallable packages) Checking the review file you can see in the "Requires" and "Provides" sections that all the DBs are taking into consideration, not only those built with _gobuildtags. https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06182707-migrate/fedora-review/review.txt I think the simplest solution is to `rm` the non built databases in %prep. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c15 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #14 from Link Dupont --- Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06182707-migrate/fedora-review -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c14 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #13 from Link Dupont --- Renamed, and updated the %goipath. Spec URL: https://linkdupont.fedorapeople.org/reviews/migrate.spec SRPM URL: https://linkdupont.fedorapeople.org/reviews/migrate-4.16.2-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c13 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #12 from Mikel Olasagasti Uranga --- * I dind't realize that you did not change the name of the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c12 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #11 from Mikel Olasagasti Uranga --- Yes, didn't realize about that. Spec and and dist-git must match `migrate` name. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c11 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #10 from Link Dupont --- (In reply to Mikel Olasagasti Uranga from comment #9) > Sorry, I just realized a minor issue: > > > %global goipath github.com/golang-migrate/migrate > > The correct path is github.com/golang-migrate/migrate/v4 > > https://github.com/golang-migrate/migrate/blob/master/go.mod#L1 Good catch. Corrected. I noticed since setting the %goname to 'migrate', the resulting SRPM is named 'migrate'. Would it make sense to follow that convention and name the dist-git repo and spec file 'migrate' as well? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c10 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Mikel Olasagasti Uranga changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Mikel Olasagasti Uranga changed: What|Removed |Added Flags||fedora-review+ --- Comment #9 from Mikel Olasagasti Uranga --- Sorry, I just realized a minor issue: > %global goipath github.com/golang-migrate/migrate The correct path is github.com/golang-migrate/migrate/v4 https://github.com/golang-migrate/migrate/blob/master/go.mod#L1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c9 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 --- Comment #8 from Link Dupont --- (In reply to Mikel Olasagasti Uranga from comment #7) > Another thing, there are some packages requires by other backends that are > available like golang-github-sql-driver-mysql. Do you plan to add them later? That's my plan, yea. I'm certain there are some other easy backends like that. But I didn't want this initial review to be burdened by a big pile of dependencies. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c8 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218606] Review Request: migrate - Go database migrations library and program
https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Link Dupont changed: What|Removed |Added Summary|Review Request: |Review Request: migrate - |golang-github-migrate - Go |Go database migrations |database migrations library |library and program |and program | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
