[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=651227 David Hannequin david.hanneq...@gmail.com changed: What|Removed |Added CC||david.hanneq...@gmail.com --- Comment #18 from David Hannequin david.hanneq...@gmail.com --- Package Change Request == Package Name: python-sleekxmpp New Branches: el6 epel7 Owners: jamielinux louizatakk -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-sleekxmpp-1.0-0.7.be |python-sleekxmpp-1.0-0.7.be |ta2.fc14|ta2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-01-17 15:58:15 EST --- python-sleekxmpp-1.0-0.7.beta2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-sleekxmpp-1.0-0.7.be ||ta2.fc14 Resolution||ERRATA Last Closed||2011-01-17 15:58:20 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-01-08 11:06:34 EST --- python-sleekxmpp-1.0-0.7.beta2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-sleekxmpp-1.0-0.7.beta2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-01-08 11:09:55 EST --- python-sleekxmpp-1.0-0.7.beta2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/python-sleekxmpp-1.0-0.7.beta2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-01-08 16:25:04 EST --- python-sleekxmpp-1.0-0.7.beta2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-sleekxmpp'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-sleekxmpp-1.0-0.7.beta2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Silas Sewell si...@sewell.ch changed: What|Removed |Added CC||si...@sewell.ch --- Comment #12 from Silas Sewell si...@sewell.ch 2011-01-07 13:35:19 EST --- Any update on a Fedora build? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651227
--- Comment #8 from Florent Le Coz lo...@louiz.org 2010-11-15 06:00:46 EST ---
(In reply to comment #7)
There is a regular script running, which checks, if all packages build with
the
upstream sources. In this case your prackage would pass, because you publish
it
manually on fedorapeople. Please delete that link, so the package would fail
in
the sources test.
- Source0: sleekxmpp-%{version}-Beta2-0.tar.gz
Ok, done. Now rpmlint complains (two warnings), but I suppose it's the expected
behaviour.
- Please add acomment, that you didn't add python3-dns yet to Requires
Done
not done ;)
Well, yes, it's done in the %package -n python3-sleekxmpp section.
- License is ok
- R: seem ok
When you fix the source-problem from above, this package is approved.
_
APPROVED
_
Thanks
So here is the fixed version:
Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.5.beta2.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Florent Le Coz lo...@louiz.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Florent Le Coz lo...@louiz.org 2010-11-15 06:07:24 EST --- New Package SCM Request === Package Name: python-sleekxmpp Short Description: Flexible XMPP client/component/server library for Python Owners: louizatakk Branches: f13 f14 InitialCC: louizatakk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #10 from Thomas Spura toms...@fedoraproject.org 2010-11-15 09:11:54 EST --- (In reply to comment #8) - Please add acomment, that you didn't add python3-dns yet to Requires Done not done ;) Well, yes, it's done in the %package -n python3-sleekxmpp section. Right, sorry. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2010-11-15 09:40:29 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651227
Thomas Spura toms...@fedoraproject.org changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Thomas Spura toms...@fedoraproject.org 2010-11-12
09:34:07 EST ---
(In reply to comment #6)
(In reply to comment #5)
- Where do you have the sources from?
You need to write the commands down, how you generated that tar ball, when
using git or somthing (don't find the guideline link atm...)
It's just a temporary thing. SleekXMPP will be hosted on pypi after the final
release. The current problem is that github generates a temporary URL only
when
browsing the download page. So I hosted it myself, but in the futur it should
be OK directly from upstream.
Anyway, fixed in the spec.
There is a regular script running, which checks, if all packages build with the
upstream sources. In this case your prackage would pass, because you publish it
manually on fedorapeople. Please delete that link, so the package would fail in
the sources test.
- Source0: sleekxmpp-%{version}-Beta2-0.tar.gz
- Please add acomment, that you didn't add python3-dns yet to Requires
Done
not done ;)
- License is ok
- R: seem ok
When you fix the source-problem from above, this package is approved.
_
APPROVED
_
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python = 2.6
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651227
Thomas Spura toms...@fedoraproject.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #5 from Thomas Spura toms...@fedoraproject.org 2010-11-11
07:07:07 EST ---
Issues:
- Where do you have the sources from?
You need to write the commands down, how you generated that tar ball, when
using git or somthing (don't find the guideline link atm...)
- Please don't menition python 2.6 or versions like that, it's a XMPP library
and that's it :)
A user doesn't need to know something about the python version, only that it
works with the python version currently in fedora ;-)
Please delete that from summary and description
- Please add acomment, that you didn't add python3-dns yet to Requires
- %files section:
When you are more explicit with %files, you know when builing an egg failed:
e.g.:
%{python3_sitelib}/sleekxmpp/
%{python3_sitelib}/sleekxmpp-*.egg-info
- INSTALL is not a doc. It helps you to install it, but it's not a documentary
for the user later on.
Rest looks ok so far:
- no *.la
- no libs
- name ok
Didn't look for the license yet, will do that, when the issues are gone.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651227
Florent Le Coz lo...@louiz.org changed:
What|Removed |Added
Summary|Review Request: |Review Request:
|python-sleekxmpp - Flexible |python-sleekxmpp - Flexible
|XMPP|XMPP
|client/component/server |client/component/server
|library for Python = 2.6 |library for Python
--- Comment #6 from Florent Le Coz lo...@louiz.org 2010-11-11 10:15:18 EST ---
(In reply to comment #5)
Issues:
- Where do you have the sources from?
You need to write the commands down, how you generated that tar ball, when
using git or somthing (don't find the guideline link atm...)
It's just a temporary thing. SleekXMPP will be hosted on pypi after the final
release. The current problem is that github generates a temporary URL only when
browsing the download page. So I hosted it myself, but in the futur it should
be OK directly from upstream.
Anyway, fixed in the spec.
- Please don't menition python 2.6 or versions like that, it's a XMPP library
and that's it :)
A user doesn't need to know something about the python version, only that it
works with the python version currently in fedora ;-)
Please delete that from summary and description
Ok, done
- Please add acomment, that you didn't add python3-dns yet to Requires
Done
- %files section:
When you are more explicit with %files, you know when builing an egg failed:
e.g.:
%{python3_sitelib}/sleekxmpp/
%{python3_sitelib}/sleekxmpp-*.egg-info
Done
- INSTALL is not a doc. It helps you to install it, but it's not a documentary
for the user later on.
Done
Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.4.beta2.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python = 2.6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python = 2.6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #1 from Thomas Spura toms...@fedoraproject.org 2010-11-09 18:02:40 EST --- Please take a look, how to build the python3 subpackage at: https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once That way, building also happens in %build. I don't think you need the big %if with_python3 macro everywhere, if you only want to build for F13 and up. Or to which release will this be targeted? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python = 2.6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #2 from Thomas Spura toms...@fedoraproject.org 2010-11-09 18:04:16 EST --- (In reply to comment #1) Please take a look, how to build the python3 subpackage at: https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once That way, building also happens in %build. I don't think you need the big %if with_python3 macro everywhere, if you only want to build for F13 and up. Or to which release will this be targeted? I mean with that, please use %py3dir to do the building in another directory, etc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python = 2.6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #3 from Florent Le Coz lo...@louiz.org 2010-11-09 18:30:19 EST --- Ok, I'll do that, thank you very much. And that's targeted for F13 and above only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python = 2.6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651227 --- Comment #4 from Florent Le Coz lo...@louiz.org 2010-11-09 18:52:32 EST --- Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec SRPM URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.3.beta2.fc13.src.rpm I fixed that, accordingly with the documentation you pointed. And I also added the execution of tests in %check -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
