[Bug 756443] Review Request: cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756443 --- Comment #5 from Juan Orti Alcaine j.orti.alca...@gmail.com 2011-12-22 04:10:25 EST --- I have improved the SPEC file by removing the python shebang from the libraries, the new files are here: Spec URL: https://raw.github.com/jorti/cagraph-fedora-package/v1.2-9/SPECS/python-cagraph.spec SRPM URL: https://github.com/jorti/cagraph-fedora-package/raw/v1.2-9/SRPMS/python-cagraph-1.2-9.fc16.src.rpm Now the rpmlint output is: $ rpmlint SPECS/python-cagraph.spec RPMS/noarch/python-cagraph-1.2-9.fc16.noarch.rpm SRPMS/python-cagraph-1.2-9.fc16.src.rpm SPECS/python-cagraph.spec: W: invalid-url Source0: http://cagraph.googlecode.com/files/cagraph-1.2.tar.gz HTTP Error 404: Not Found python-cagraph.src: W: invalid-url Source0: http://cagraph.googlecode.com/files/cagraph-1.2.tar.gz HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 0 errors, 2 warnings. The invalid-url error is a known problem with googlecode.com already reported in bug 767739 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756443] Review Request: cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756443 --- Comment #2 from Volker Fröhlich volke...@gmx.at 2011-12-13 14:39:06 EST --- Did you look for a sponsor yet? Please find further information below: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756443] Review Request: cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756443
--- Comment #3 from Juan Orti Alcaine j.orti.alca...@gmail.com 2011-12-13
16:45:20 EST ---
(In reply to comment #1)
Hello, I have updated the package, the new files are here:
Spec URL:
https://raw.github.com/jorti/cagraph-fedora-package/v1.2-8/SPECS/python-cagraph.spec
SRPM URL:
https://github.com/jorti/cagraph-fedora-package/raw/v1.2-8/SRPMS/python-cagraph-1.2-8.fc16.src.rpm
According to the files, license is GPLv3+, not GPLv3
Fixed.
rm -rf %{buildroot}/*, clean section and buildroot definition are not
necessary, if you're not aiming for EPEL 5:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag
I would like to be able to compile it for EPEL, because this library is used by
tor-arm, a monitor for Tor routers which I also submited to review in bug
#756445
The if clause for Suse is no use in Fedora. I guess you're trying to keep a
single spec for Suse and Fedora. I don't know Suse's guidelines, but that
might
not work.
All references to Suse removed.
Don't install the documentation on your own. Only use %doc in the files
section: http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
Fixed.
FSF postal address is wrong:
Fixed. I include a patch and also submitted it upstream
I think this package should have python in the name:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
Renamed.
I suppose you can use a single chmod to change all the py file's permissions.
Done.
Now the output of rpmlint is clean:
$ rpmlint SPECS/python-cagraph.spec
RPMS/noarch/python-cagraph-1.2-8.fc16.noarch.rpm
SRPMS/python-cagraph-1.2-8.fc16.src.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756443] Review Request: cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756443 --- Comment #4 from Juan Orti Alcaine j.orti.alca...@gmail.com 2011-12-13 16:48:15 EST --- (In reply to comment #2) Did you look for a sponsor yet? Please find further information below: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group I announced myself in the devel list, but I haven't find anyone. All sponsors are welcome! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756443] Review Request: cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756443
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich volke...@gmx.at 2011-12-09 08:27:11 EST
---
According to the files, license is GPLv3+, not GPLv3
rm -rf %{buildroot}/*, clean section and buildroot definition are not
necessary, if you're not aiming for EPEL 5:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag
Defining sitearch or sitelib is only necessary for EPEL 5 as well, see
http://fedoraproject.org/wiki/Packaging:Python
The if clause for Suse is no use in Fedora. I guess you're trying to keep a
single spec for Suse and Fedora. I don't know Suse's guidelines, but that might
not work.
Don't install the documentation on your own. Only use %doc in the files
section: http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
FSF postal address is wrong:
[makerpm@desktop SPECS]$ rpmlint
/home/makerpm/rpmbuild/RPMS/noarch/cagraph-1.2-7.fc16.noarch.rpm
cagraph.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/cagraph/axis/taxis.py
cagraph.noarch: E: incorrect-fsf-address
/usr/share/doc/cagraph-1.2/examples/example99.py
cagraph.noarch: E: incorrect-fsf-address
/usr/share/doc/cagraph-1.2/examples/example6.py
cagraph.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/cagraph/axis/xaxis.py
...
Please contact the developers on that and feel free to correct it.
I think this package should have python in the name:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
I suppose you can use a single chmod to change all the py file's permissions.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756443] Review Request: cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756443 Juan Orti Alcaine j.orti.alca...@gmail.com changed: What|Removed |Added CC||j.orti.alca...@gmail.com Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
