[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740 Raphael Groner projects...@smart.ms changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2015-01-26 11:39:57 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740 Raphael Groner projects...@smart.ms changed: What|Removed |Added Flags||needinfo?(spencerandrewjack ||s...@yahoo.com) --- Comment #13 from Raphael Groner projects...@smart.ms --- ping? Are you still interested in maintaining this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740
Raphael Groner projects...@smart.ms changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|projects...@smart.ms
--- Comment #11 from Raphael Groner projects...@smart.ms ---
Your spec file is not ready for a formal review. Please fix following listed
points. After done that, I could have a deeper look.
# Tarballs can be obtained from GitHub at
https://github.com/laas/morse/tarball/0.4.1
Source0: laas-morse-0.4.1-0-g15dc857.tar.gz
%global namemorse
%global commit g15dc857
%global version 0.4.1
Source0:
https://github.com/laas/%{name}/tarball/%{version}#/laas-name-%{version}-0-%{commit}.tar.gz
Analogously, you should give the individual URL directly into PatchX.
%{?with_pocolibs:
What's that? I would not suggest conditional packaging. What is the purpose?
Requires: %{name}%{?_isa} = %{version}-%{release}
Remove %{?_isa} completely from Requires. Otherwise, you won't be able to build
cross-arch.
BuildRequires:swig
BuildRequires:pocolibs-devel
Move those on top to the BR for the main package. There's only one %build
allowed for all sub-packages.
%build:
You should use %cmake macro instead of direct cmake call with tons of standard
parameters.
https://fedoraproject.org/wiki/Packaging:Cmake?rd=Packaging/cmake
pushd doc
make
popd
cd doc ; make
%install
desktop-file-install --vendor=fedora \
The Vendor tag should not be used. It is set automatically by the build system.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Tags
# Move …
Use install -d instead of mkdir -p to preserve timestamps etc.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #12 from Raphael Groner projects...@smart.ms --- https://fedoraproject.org/wiki/Packaging/SourceURL https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740 Raphael Groner projects...@smart.ms changed: What|Removed |Added CC||spencerandrewjackson@yahoo. ||com Flags||needinfo?(spencerandrewjack ||s...@yahoo.com) --- Comment #10 from Raphael Groner projects...@smart.ms --- Any news here? I could take the review process if you may like. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: morse - Simulates robots using the Blender Game Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=770740 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Summary|Review Request: Morse - |Review Request: morse - |Simulates robots using the |Simulates robots using the |Blender Game Engine |Blender Game Engine Flags||needinfo?(spencerandrewjack ||s...@yahoo.com) --- Comment #9 from Jason Tibbitts ti...@math.uh.edu --- I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. This fails to build for me; here's a koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5322961 In addition, we do have guidelines for dealing with github which you might want to look over: http://fedoraproject.org/wiki/Packaging:SourceURL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RirZfrkChMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #8 from Pierre-YvesChibon pin...@pingoured.fr --- @Adrien, now that you are an official packager, what about finishing this review ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #7 from Spencer Jackson spencerandrewjack...@yahoo.com 2012-01-17 16:13:38 EST --- New spec Spec URL: http://dl.dropbox.com/u/4517312/morse.spec SRPM URL: http://dl.dropbox.com/u/4517312/morse-0.4.1-4.fc16.src.rpm [makerpm@khezef rpmbuild]$ rpmlint /var/lib/mock/fedora-16-x86_64/result/morse-* morse morse-doc morse-debuginfo SPECS/morse.spec morse.src: W: spelling-error %description -l en_US middleware - middle ware, middle-ware, middleweight morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz SPECS/morse.spec: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz 7 packages and 1 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #6 from Spencer Jackson spencerandrewjack...@yahoo.com 2012-01-12 15:35:43 EST --- Just uploaded a new spec Spec URL: http://dl.dropbox.com/u/4517312/morse.spec SRPM URL: http://dl.dropbox.com/u/4517312/morse-0.4.1-3.fc16.src.rpm I've added the missing man pages, as well as properly generate documentation which is placed into a doc subpackage. Further, I've added optional build time dependencies on features which have unpackaged dependencies. [makerpm@khezef rpmbuild]$ rpmlint morse morse-debuginfo morse-doc SPECS/morse.spec /var/lib/mock/fedora-16-x86_64/result/morse-0.4.1-3.fc16.src.rpm morse.x86_64: W: spelling-error %description -l en_US ros - rps, rod, rs morse.x86_64: W: spelling-error %description -l en_US Middleware - Middle ware, Middle-ware, Middleweight morse.x86_64: W: spelling-error %description -l en_US subpackages - sub packages, sub-packages, prepackages SPECS/morse.spec: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz morse.src: W: spelling-error %description -l en_US middleware - middle ware, middle-ware, middleweight morse.src: W: spelling-error %description -l en_US ros - rps, rod, rs morse.src: W: spelling-error %description -l en_US Middleware - Middle ware, Middle-ware, Middleweight morse.src: W: spelling-error %description -l en_US subpackages - sub packages, sub-packages, prepackages morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz 4 packages and 1 specfiles checked; 0 errors, 9 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770740
adev ade...@gmail.com changed:
What|Removed |Added
CC||pin...@pingoured.fr
--- Comment #5 from adev ade...@gmail.com 2012-01-09 05:49:39 EST ---
Hi, This is an informal review, I am not a sponsor.
[PASS] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
morse.src: I: enchant-dictionary-not-found en_US
morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz
morse.x86_64: W: no-manual-page-for-binary morseexec
morse.x86_64: W: no-manual-page-for-binary morse
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
- no man pages
[PASS] MUST: The package must be named according to the Package Naming
Guidelines .
[PASS] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[PASS] MUST: The package must meet the Packaging Guidelines.
[PASS] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[PASS] MUST: The License field in the package spec file must match the actual
license.
[PASS] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[PASS] MUST: The spec file must be written in American English.
[PASS] MUST: The spec file for the package MUST be legible.
[PASS] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
rpmdev-md5 morse-0.4.1-2.fc16.src.rpm
293849e6e24b0b3adf2dbd9ae0064300 morse-0.4.1-2.fc16.src.rpm
0e9c30808c82062d284a528c052e16f2 morse.desktop
794f77239d535d61861426d450b66850 morse-0.4.1-lsbpathfix.patch
a2b9c70415653665ad5d90504ffebc5e morse-0.4.1.usepythonsitearch.patch
b57e3f3dd1eed67ce201ddfa14b920ad laas-morse-0.4.1-0-g15dc857.tar.gz
5ced6d1eec3f7a66e6f0e41bc64de92d morse.spec
md5sum 0.4.1
b57e3f3dd1eed67ce201ddfa14b920ad 0.4.1
[PASS] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
- see koji
[PASS] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[PASS] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[PASS] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[PASS] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[PASS] MUST: Packages must NOT bundle copies of system libraries.
[PASS] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[PASS] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[PASS] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[PASS] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
[PASS] MUST: Each package must consistently use macros.
[PASS] MUST: The package must contain code, or permissable content.
[PASS] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[PASS] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[PASS] MUST: Header files must be in a -devel package.
[PASS] MUST: Static
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #4 from Spencer Jackson spencerandrewjack...@yahoo.com 2012-01-08 17:32:16 EST --- Thanks, adev! I've applied your recommendations to the spec. New spec URL: http://dl.dropbox.com/u/4517312/morse.spec New SRPM URL: http://dl.dropbox.com/u/4517312/morse-0.4.1-2.fc16.src.rpm rpmlint morse morse-debuginfo RPMS/x86_64/morse-0.4.1-2.fc16.x86_64.rpm RPMS/x86_64/morse-debuginfo-0.4.1-2.fc16.x86_64.rpm SRPMS/morse-0.4.1-2.fc16.src.rpm SPECS/morse.spec morse.x86_64: W: no-manual-page-for-binary morseexec morse.x86_64: W: no-manual-page-for-binary morse morse.x86_64: W: no-manual-page-for-binary morseexec morse.x86_64: W: no-manual-page-for-binary morse morse.src: W: spelling-error %description -l en_US middleware - middle ware, middle-ware, middleweight morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz SPECS/morse.spec: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz 5 packages and 1 specfiles checked; 0 errors, 7 warnings. I just sent an email to the packaging list, ( http://lists.fedoraproject.org/pipermail/packaging/2012-January/008067.html ) basically asking what to do about the middleware protocols which are supported by Morse, but not packaged in Fedora. Some of these, like ROS, might take a while to be supported. Any thoughts on how to handle that would be appreciated. Upstream also recommended that I create subpackages for each middleware. That makes a lot of sense, but I should probably figure out what's the best way to handle the unsupported middlewares before I do that... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770740
adev ade...@gmail.com changed:
What|Removed |Added
CC||ade...@gmail.com
--- Comment #3 from adev ade...@gmail.com 2012-01-06 11:25:57 EST ---
Hi,
Quick comments about your spec file :
- use the %{_isa} macro for your Requires dependencies on binary packages.
- -DCMAKE_INSTALL_PREFIX=/usr is useless, it is already included in the
%cmake macro
- %{_libdir} could be used instead of /usr/lib64/ with your cmake command
- same with %{_includedir} instead of /usr/include
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #2 from Spencer Jackson spencerandrewjack...@yahoo.com 2011-12-30 15:26:23 EST --- New spec file. Spec URL: http://dl.dropbox.com/u/4517312/morse.spec SRPM URL: http://dl.dropbox.com/u/4517312/morse-0.4.1-1.fc16.src.rpm Builds and installs documentation, correctly forces the use of python3 while bytecode compiling, as well as miscellaneous other cleanups. rpmlint output: [makerpm@khezef rpmbuild]$ rpmlint SPECS/morse.spec /var/lib/mock/fedora-16-x86_64/result/morse-* morse morse-debuginfo SPECS/morse.spec: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz morse.src: W: spelling-error %description -l en_US middleware - middle ware, middle-ware, middleweight morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz morse.x86_64: W: no-manual-page-for-binary morseexec morse.x86_64: W: no-manual-page-for-binary morse morse.x86_64: W: no-manual-page-for-binary morseexec morse.x86_64: W: no-manual-page-for-binary morse 5 packages and 1 specfiles checked; 0 errors, 7 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 Spencer Jackson spencerandrewjack...@yahoo.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #1 from Spencer Jackson spencerandrewjack...@yahoo.com 2011-12-28 15:06:29 EST --- I forgot to mention, this is my first package, and I believe I need a sponsor... Any help in that regard would be much appreciated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
