[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Lubomir Rintel changed: What|Removed |Added CC||lkund...@v3.sk Flags||fedora-cvs? --- Comment #7 from Lubomir Rintel --- Package Change Request == Package Name: perl-Devel-StringInfo New Branches: epel7 Owners: lkundrak The Fedora maintainer is unfortunately not maintaining EPEL packages: http://fedoraproject.org/wiki/EPEL/ContributorStatusNo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Flags|fedora-cvs+ |fedora-cvs? Last Closed||2012-06-22 10:42:02 --- Comment #6 from Jitka Plesnikova --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Jitka Plesnikova changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jitka Plesnikova --- New Package SCM Request === Package Name: perl-Devel-StringInfo Short Description: Gather information about strings Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ---
Spec file changes:
--- perl-Devel-StringInfo.spec.old 2012-06-22 10:00:53.0 +0200
+++ perl-Devel-StringInfo.spec 2012-06-22 15:41:42.0 +0200
@@ -2,7 +2,7 @@
Version:0.04
Release:1%{?dist}
Summary:Gather information about strings
-License:GPL+ or Artistic
+License:GPL+ or Artistic or MIT
Group: Development/Libraries
URL:http://search.cpan.org/dist/Devel-StringInfo/
Source0:
http://www.cpan.org/authors/id/N/NU/NUFFIN/Devel-StringInfo-%{version}.tar.gz
@@ -20,6 +20,8 @@
BuildRequires: perl(Tie::IxHash)
BuildRequires: perl(YAML)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(Data::HexDump::XXD)
+Requires: perl(YAML)
%description
This module is a debugging aid that helps figure out more information
@@ -33,8 +35,6 @@
make %{?_smp_mflags}
%install
-rm -rf $RPM_BUILD_ROOT
-
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
> FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm).
-License:GPL+ or Artistic
+License:GPL+ or Artistic or MIT
Ok.
> FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77).
+Requires: perl(YAML)
Ok.
> FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91).
+Requires: perl(Data::HexDump::XXD)
Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
1 perl(Data::HexDump::XXD)
1 perl(Encode)
1 perl(Encode::Guess)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(Moose)
1 perl(namespace::clean)
1 perl(Scalar::Util)
1 perl(Sub::Exporter)
1 perl(Tie::IxHash)
1 perl(utf8)
1 perl(YAML)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Package builds in F18
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4188268). Ok.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #2 from Jitka Plesnikova --- Updated. http://koji.fedoraproject.org/koji/taskinfo?taskID=4188205 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #1 from Petr Pisar --- Source file is original. Ok. Summary verified from lib/Devel/StringInfo.pm. FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm). Description verified from lib/Devel/StringInfo.pm. Ok. No XS code, noarch BuildArch is Ok. URL and Source0 are usable. Ok. Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-Devel-StringInfo.spec ../SRPMS/perl-Devel-StringInfo-0.04-1.fc18.src.rpm ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm drwxr-xr-x2 rootroot0 Jun 22 15:04 /usr/share/doc/perl-Devel-StringInfo-0.04 -rw-r--r--1 rootroot 160 May 14 2009 /usr/share/doc/perl-Devel-StringInfo-0.04/Changes -rw-r--r--1 rootroot 3365 Jun 22 15:04 /usr/share/man/man3/Devel::StringInfo.3pm.gz drwxr-xr-x2 rootroot0 Jun 22 15:04 /usr/share/perl5/vendor_perl/Devel -rw-r--r--1 rootroot 7976 May 14 2009 /usr/share/perl5/vendor_perl/Devel/StringInfo.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Encode) 1 perl(Encode::Guess) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Moose) 1 perl(namespace::clean) 1 perl(Scalar::Util) 1 perl(Sub::Exporter) 1 perl(Tie::IxHash) 1 perl(utf8) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77). FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91). $ rpm -q --provides -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Devel::StringInfo) = 0.04 1 perl-Devel-StringInfo = 0.04-1.fc18 Binary provides are Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4188014). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefix issues and provides new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Bug 834516 depends on bug 834512, which changed state. Bug 834512 Summary: Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd https://bugzilla.redhat.com/show_bug.cgi?id=834512 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
