[COMMITTERS] pgsql: Fix typo in PostgreSQL 10.0 release note.
Fix typo in PostgreSQL 10.0 release note. Patch by Yugo Nagata. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e800656d9a9b40b2f55afabe76354ab6d93353b3 Modified Files -- doc/src/sgml/release-10.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix document bug regarding read only transactions.
> Right, but what I think it is comparing is a read-only transaction > on the master and a transaction on the standby. The former can do > nextval() on temp sequences, the latter can't. But we cannot create temp sequences on stanbys in the first place. Still do you think there's value to refer to nextval() on temp sequences here? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Tatsuo Ishiiwrites: >> I think the correct fix would have been to change "update sequences" >> to "update temporary sequences", not to remove it. > Not sure. The paragraph tries to explain the difference between read > only transactions and standby. Right, but what I think it is comparing is a read-only transaction on the master and a transaction on the standby. The former can do nextval() on temp sequences, the latter can't. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix document bug regarding read only transactions.
> I think the correct fix would have been to change "update sequences" > to "update temporary sequences", not to remove it. Not sure. The paragraph tries to explain the difference between read only transactions and standby. --- In normal operation, “read-only” transactions are allowed to update sequences and to use LISTEN, UNLISTEN, and NOTIFY, so Hot Standby sessions operate under slightly tighter restrictions than ordinary read-only sessions. It is possible that some of these restrictions might be loosened in a future release. --- Regarding sequences, the paragraph supposes the use case on standby in that a normal sequence was created on primary then it gets updated on standby (that was used be possible). For temporary sequences, this scenario is totally meaningless since temporary sequences are not replicated, nor cannot be created on standby either. So I think referring to temporary sequences here is pointless. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Tatsuo Ishiiwrites: > Fix document bug regarding read only transactions. > It was explained that read only transactions (not in standby) allow to > update sequences. This had been wrong since the commit: > 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 This new text is not any more accurate than the old, it's just wrong in the other direction. The actual behavior is still what's stated in the commit message for that commit: read-only transactions on the master are allowed to do nextval() on temp sequences but not permanent ones. regression=# create temp sequence s1; CREATE SEQUENCE regression=# create sequence s2; CREATE SEQUENCE regression=# begin transaction read only; BEGIN regression=# select nextval('s1'); nextval - 1 (1 row) regression=# select nextval('s2'); ERROR: cannot execute nextval() in a read-only transaction I think the correct fix would have been to change "update sequences" to "update temporary sequences", not to remove it. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Fix document bug regarding read only transactions. It was explained that read only transactions (not in standby) allow to update sequences. This had been wrong since the commit: 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6d3a0fc33750b1eee0c63220075b058a8e0d675e Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Fix document bug regarding read only transactions. It was explained that read only transactions (not in standby) allow to update sequences. This had been wrong since the commit: 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5eaee9b4c4af3c3cc7f52f921e03512699dcd887 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Fix document bug regarding read only transactions. It was explained that read only transactions (not in standby) allow to update sequences. This had been wrong since the commit: 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e3f87aae9316d42ece1912d1cae34ec0ba8142c8 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Fix document bug regarding read only transactions. It was explained that read only transactions (not in standby) allow to update sequences. This had been wrong since the commit: 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6108348c09df33773bed6e0ac762fe47bdcbb9e6 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Fix document bug regarding read only transactions. It was explained that read only transactions (not in standby) allow to update sequences. This had been wrong since the commit: 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1fe10463d9bd38d20b5c3c9356fc07ae9c3b6828 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix document bug regarding read only transactions.
Fix document bug regarding read only transactions. It was explained that read only transactions (not in standby) allow to update sequences. This had been wrong since the commit: 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7 Discussion: https://www.postgresql.org/message-id/20170614.110826.425627939780392324.t-ishii%40sraoss.co.jp Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7efc08dec9c737e92388fe2665f2bc1d4e3c1970 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup
Robert Haaswrites: > Fix problems related to RangeTblEntry members enrname and enrtuples. > Commit 18ce3a4ab22d2984f8540ab480979c851dae5338 failed to update > the comments in parsenodes.h for the new members, and made only > incomplete updates to src/backend/nodes This really should have involved a catversion bump. But we just had one earlier today, so in practice it might not matter. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup
Fix problems related to RangeTblEntry members enrname and enrtuples. Commit 18ce3a4ab22d2984f8540ab480979c851dae5338 failed to update the comments in parsenodes.h for the new members, and made only incomplete updates to src/backend/nodes Thomas Munro, per a report from Noah Misch. Discussion: http://postgr.es/m/20170611062525.ga1628...@rfd.leadboat.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f32d57fd7088a558dadbe21b9859b09d2f877c19 Modified Files -- src/backend/nodes/copyfuncs.c | 3 ++- src/backend/nodes/equalfuncs.c | 2 ++ src/backend/nodes/outfuncs.c | 1 + src/backend/nodes/readfuncs.c | 1 + src/include/nodes/parsenodes.h | 14 +- 5 files changed, 19 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot.
Don't force-assign transaction id when exporting a snapshot. Previously we required every exported transaction to have an xid assigned. That was used to check that the exporting transaction is still running, which in turn is needed to guarantee that that necessary rows haven't been removed in between exporting and importing the snapshot. The exported xid caused unnecessary problems with logical decoding, because slot creation has to wait for all concurrent xid to finish, which in turn serializes concurrent slot creation. It also prohibited snapshots to be exported on hot-standby replicas. Instead export the virtual transactionid, which avoids the unnecessary serialization and the inability to export snapshots on standbys. This changes the file name of the exported snapshot, but since we never documented what that one means, that seems ok. Author: Petr Jelinek, slightly editorialized by me Reviewed-By: Andres Freund Discussion: https://postgr.es/m/f598b4b8-8cd7-0d54-0939-adda763d8...@2ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6c2003f8a1bbc7c192a2e83ec51581c018aa162f Modified Files -- doc/src/sgml/ref/set_transaction.sgml | 6 +- src/backend/replication/logical/snapbuild.c | 14 ++-- src/backend/storage/ipc/procarray.c | 11 ++- src/backend/storage/lmgr/predicate.c| 26 +++--- src/backend/utils/time/snapmgr.c| 119 ++-- src/include/storage/predicate.h | 4 +- src/include/storage/procarray.h | 2 +- 7 files changed, 115 insertions(+), 67 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use DEFACLOBJ_ macros in error message instead of hardcoding
Use DEFACLOBJ_ macros in error message instead of hardcoding Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b6966d4627c0297ad42fe2592c66ac2f76e9962e Modified Files -- src/backend/catalog/objectaddress.c | 9 +++-- src/test/regress/expected/object_address.out | 6 +++--- 2 files changed, 10 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing serial comma
Add missing serial comma Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4e88fe8f8f148a45feacb50c2eaed9ca9ddea8bb Modified Files -- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: doc: Whitespace fixes in man pages
doc: Whitespace fixes in man pages Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f0cfff9da2c577a19dd6a15ffc7b404693b700bc Modified Files -- doc/src/sgml/ref/alter_aggregate.sgml | 3 +-- doc/src/sgml/ref/alter_publication.sgml | 3 +-- doc/src/sgml/ref/alter_subscription.sgml| 3 +-- doc/src/sgml/ref/alter_system.sgml | 3 +-- doc/src/sgml/ref/alter_type.sgml| 3 +-- doc/src/sgml/ref/create_access_method.sgml | 3 +-- doc/src/sgml/ref/create_publication.sgml| 3 +-- doc/src/sgml/ref/create_subscription.sgml | 3 +-- doc/src/sgml/ref/drop_aggregate.sgml| 3 +-- doc/src/sgml/ref/drop_policy.sgml | 3 +-- doc/src/sgml/ref/drop_publication.sgml | 4 +--- doc/src/sgml/ref/drop_statistics.sgml | 4 +--- doc/src/sgml/ref/drop_subscription.sgml | 4 +--- doc/src/sgml/ref/import_foreign_schema.sgml | 4 +--- doc/src/sgml/ref/insert.sgml| 3 +-- 15 files changed, 15 insertions(+), 34 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Teach predtest.c about CHECK clauses to fix partitioning bugs.
Teach predtest.c about CHECK clauses to fix partitioning bugs. In a CHECK clause, a null result means true, whereas in a WHERE clause it means false. predtest.c provided different functions depending on which set of semantics applied to the predicate being proved, but had no option to control what a null meant in the clauses provided as axioms. Add one. Use that in the partitioning code when figuring out whether the validation scan on a new partition can be skipped. Rip out the old logic that attempted (not very successfully) to compensate for the absence of the necessary support in predtest.c. Ashutosh Bapat and Robert Haas, reviewed by Amit Langote and incorporating feedback from Tom Lane. Discussion: http://postgr.es/m/CAFjFpReT_kq_uwU_B8aWDxR7jNGE=P0iELycdq5oupi=xsq...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b08df9cab777427fdafe633ca7b8abf29817aa55 Modified Files -- src/backend/commands/tablecmds.c | 60 +--- src/backend/optimizer/path/indxpath.c | 11 ++- src/backend/optimizer/plan/createplan.c | 7 +- src/backend/optimizer/util/plancat.c | 6 +- src/backend/optimizer/util/predtest.c | 152 +++--- src/backend/utils/adt/selfuncs.c | 4 +- src/include/optimizer/predtest.h | 8 +- src/test/regress/expected/alter_table.out | 6 ++ src/test/regress/sql/alter_table.sql | 7 +- 9 files changed, 129 insertions(+), 132 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve release note text about set-returning-function changes.
Improve release note text about set-returning-function changes. Paul Ramsey griped about this awhile ago, but I'd been holding fire on changing it until we settled what to do about the CASE/COALESCE issue. Discussion: https://postgr.es/m/CACowWR0AMyUt5fwtvuDqWyYNdp-hQJj9XqSxJR6YM9sKWov=_...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a12c09ad86e60a8acb269744b8ee86429dda2cd8 Modified Files -- doc/src/sgml/release-10.sgml | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Avoid bogus TwoPhaseState locking sequences
Avoid bogus TwoPhaseState locking sequences The optimized code in 728bd991c3c4 contains a few invalid locking sequences. To wit, the original code would try to acquire an lwlock that it already holds. Avoid this by moving lock acquisitions to higher-level code, and install appropriate assertions in low-level that the correct mode is held. Authors: Michael Paquier, Álvaro Herrera Reported-By: chuanting wang Bug: #14680 Discussion: https://postgr.es/m/20170531033228.1487.10...@wrigleys.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e90ceeaa495f5f40f224bcf84d2b0700eae8d7a3 Modified Files -- src/backend/access/transam/twophase.c | 87 +++ src/backend/access/transam/xact.c | 68 ++- 2 files changed, 83 insertions(+), 72 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Put documentation of options and commands in more alphabetical o
Put documentation of options and commands in more alphabetical order Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0d9bdbcaae00dac89a82c25e66e4a859130e2fe8 Modified Files -- doc/src/sgml/ref/initdb.sgml | 4 +- doc/src/sgml/ref/pg_dump.sgml | 28 ++--- doc/src/sgml/ref/psql-ref.sgml | 89 +- src/bin/psql/help.c| 14 +++ 4 files changed, 68 insertions(+), 67 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix no-longer-valid shortcuts in expression_returns_set().
Fix no-longer-valid shortcuts in expression_returns_set(). expression_returns_set() used to short-circuit its recursion upon seeing certain node types, such as DistinctExpr, that it knew the executor did not support set-valued arguments for. That was never inherent, though, just a reflection of laziness in execQual.c. With the new implementation of SRFs there is no reason to think that any scalar-valued expression node could not have a set-valued subexpression, except for AggRefs and WindowFuncs where we know there is a parser check rejecting it. And indeed, the shortcut causes unexpected failures for cases such as a SRF underneath DistinctExpr, because the planner stops looking for SRFs too soon. Discussion: https://postgr.es/m/5259.1497044...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8e72239e9d961c27f02b242e33fa832c364c7a4b Modified Files -- src/backend/nodes/nodeFuncs.c | 30 +- src/test/regress/expected/tsrf.out | 8 src/test/regress/sql/tsrf.sql | 1 + 3 files changed, 10 insertions(+), 29 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix violations of CatalogTupleInsert/Update/Delete abstraction.
Fix violations of CatalogTupleInsert/Update/Delete abstraction. In commits 2f5c9d9c9 and ab0289651 we invented an abstraction layer to insulate catalog manipulations from direct heap update calls. But evidently some patches that hadn't landed in-tree at that point didn't get the memo completely. Fix a couple of direct calls to simple_heap_delete to use CatalogTupleDelete instead; these appear to have been added in commits 7c4f52409 and 7b504eb28. This change is purely cosmetic ATM, but there's no point in having an abstraction layer if we allow random code to break it. Masahiko Sawada and Tom Lane Discussion: https://postgr.es/m/CAD21AoDOPRSVcwbnCN3Y1n_68ATyTspsU6=ygthz_uy0vcd...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a571c7f661a7b601aafcb12196d004cdb8b8cb23 Modified Files -- src/backend/catalog/pg_subscription.c | 2 +- src/backend/commands/statscmds.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Teach PL/pgSQL about partitioned tables.
Teach PL/pgSQL about partitioned tables. Table partitioning, introduced in commit f0e44751d7, added a new relkind - RELKIND_PARTITIONED_TABLE. Update a couple of places in PL/pgSQL to handle it. Specifically plpgsql_parse_cwordtype() and build_row_from_class() needed updating in order to make table%ROWTYPE and table.col%TYPE work for partitioned tables. Dean Rasheed, reviewed by Amit Langote. Discussion: https://postgr.es/m/CAEZATCUnNOKN8sLML9jUzxecALWpEXK3a3W7y0PgFR4%2Buhgc%3Dg%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d3c3f2b1e25cc96d3078bf4d47a2f58fefb70560 Modified Files -- src/pl/plpgsql/src/pl_comp.c | 6 +++-- src/test/regress/expected/plpgsql.out | 45 +++ src/test/regress/sql/plpgsql.sql | 39 ++ 3 files changed, 88 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers