Re: [PATCHES] Regression test for stats collector
Neil Conway wrote: > On Thu, 2003-09-11 at 11:58, Bruce Momjian wrote: > > Uh, how do you force the stats collector to 'on' before the test is > > run? > > The stats collector is on by default (of course, that doesn't apply to > "make installcheck"...) Oh I see now, nice. I didn't realize you could turn it on per backend. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] WIN32_CONSOLE usage
Christoph Dalitz wrote: > @Bruce: > --- > > Could you please already remove the WIN32_CONSOLE and OemToChar/CharToOem stuff > from psql? Sorry for the inconvenience generated by my ignorance. Removed. Thanks. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
[PATCHES] tsearch pfree error
I haven't seen a notice that Bruce noticed this patch I sent across general as part of a rambling thread of mine. There again, I'm not exactly up to date with all my email so could easily have missed it. However, in light of the beta3 notice I'm sending it to the correct list now. Fixes simple bug that was causing me problems using tsearch2. -- Nigel Andrews *** /tmp/postgresql-7.3.4/contrib/tsearch2/query.c Thu Aug 28 13:29:12 2003 --- query.c Sun Sep 7 18:53:17 2003 *** *** 837,843 PG_GETARG_DATUM(1) ); ! PG_FREE_IF_COPY(name,1); PG_RETURN_DATUM(res); } --- 837,843 PG_GETARG_DATUM(1) ); ! PG_FREE_IF_COPY(name,0); PG_RETURN_DATUM(res); } ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] tsearch pfree error
"Nigel J. Andrews" <[EMAIL PROTECTED]> writes: > I haven't seen a notice that Bruce noticed this patch I sent across > general as part of a rambling thread of mine. Not sure why he missed it, but I've applied it to CVS tip. Thanks. regards, tom lane ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] Reorganization of spinlock defines
Bruce Momjian writes: > o adds a configure option --without-spinlocks to allow > non-spinlock compiles --disable-spinlocks please. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] tsearch pfree error
On Fri, 12 Sep 2003, Bruce Momjian wrote: > > I hadn't seen this --- not sure why. Probably because it was in a rambling thread consisting mostly of posts by myself. Thanks for applying it chaps. Nigel (Sheesh, all this fuss for a one character change :) ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] tsearch pfree error
Nigel J. Andrews wrote: > On Fri, 12 Sep 2003, Bruce Momjian wrote: > > > > > I hadn't seen this --- not sure why. > > Probably because it was in a rambling thread consisting mostly of posts by > myself. > > Thanks for applying it chaps. I might have assumed the tsearch guys had it handled now that they have CVS access. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] Reorganization of spinlock defines
Bruce Momjian wrote:
> Prompted by confusion over Itanium/Opterion, I have written a patch to
> improve the way we define spinlocks for platforms and cpu's. It
> basically decouples the OS from the CPU spinlock code. In almost all
> cases, the spinlock code cares only about the compiler and CPU, not the
> OS.
>
> The patch:
>
> o defines HAS_TEST_AND_SET inside each spinlock routine, not in
> platform-specific files
> o moves slock_t defines into the spinlock routines
> o remove NEED_{CPU}_TAS_ASM define because it is no longer needed
> o reports a compile error if spinlocks are not defined
> o adds a configure option --without-spinlocks to allow
> non-spinlock compiles
OK, this applied patch implements the last two items. The earlier items
will have to wait for 7.5.
--
Bruce Momjian| http://candle.pha.pa.us
[EMAIL PROTECTED] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
Index: configure
===
RCS file: /cvsroot/pgsql-server/configure,v
retrieving revision 1.295
diff -c -c -r1.295 configure
*** configure 7 Sep 2003 16:49:41 - 1.295
--- configure 12 Sep 2003 16:05:13 -
***
*** 869,874
--- 869,875
--with-rendezvous build with Rendezvous support
--with-openssl[=DIR]build with OpenSSL support [/usr/local/ssl]
--without-readline do not use Readline
+ --without-spinlocks do not use Spinlocks
--without-zlib do not use Zlib
--with-gnu-ld assume the C compiler uses GNU ld default=no
***
*** 3494,3499
--- 3495,3530
#
+ # Spinlocks
+ #
+
+
+
+ # Check whether --with-spinlocks or --without-spinlocks was given.
+ if test "${with_spinlocks+set}" = set; then
+ withval="$with_spinlocks"
+
+ case $withval in
+ yes)
+ :
+ ;;
+ no)
+ :
+ ;;
+ *)
+ { { echo "$as_me:$LINENO: error: no argument expected for --with-spinlocks
option" >&5
+ echo "$as_me: error: no argument expected for --with-spinlocks option" >&2;}
+{ (exit 1); exit 1; }; }
+ ;;
+ esac
+
+ else
+ with_spinlocks=yes
+
+ fi;
+
+
+ #
# Zlib
#
***
*** 3523,3529
fi;
-
#
# Elf
#
--- 3554,3559
***
*** 6060,6065
--- 6090,6108
{ (exit 1); exit 1; }; }
fi
+ fi
+
+ if test "$with_spinlocks" = yes; then
+
+ cat >>confdefs.h <<\_ACEOF
+ #define HAVE_SPINLOCKS 1
+ _ACEOF
+
+ else
+ { echo "$as_me:$LINENO: WARNING:
+ *** Not using spinlocks will cause poor performance." >&5
+ echo "$as_me: WARNING:
+ *** Not using spinlocks will cause poor performance." >&2;}
fi
if test "$with_krb4" = yes ; then
Index: configure.in
===
RCS file: /cvsroot/pgsql-server/configure.in,v
retrieving revision 1.286
diff -c -c -r1.286 configure.in
*** configure.in7 Sep 2003 16:38:05 - 1.286
--- configure.in12 Sep 2003 16:05:15 -
***
*** 522,533
[ --without-readline do not use Readline])
#
# Zlib
#
PGAC_ARG_BOOL(with, zlib, yes,
[ --without-zlib do not use Zlib])
-
#
# Elf
#
--- 522,538
[ --without-readline do not use Readline])
#
+ # Spinlocks
+ #
+ PGAC_ARG_BOOL(with, spinlocks, yes,
+ [ --without-spinlocks do not use Spinlocks])
+
+ #
# Zlib
#
PGAC_ARG_BOOL(with, zlib, yes,
[ --without-zlib do not use Zlib])
#
# Elf
#
***
*** 676,681
--- 681,693
If you have zlib already installed, see config.log for details on the
failure. It is possible the compiler isn't looking in the proper directory.
Use --without-zlib to disable zlib support.])])
+ fi
+
+ if test "$with_spinlocks" = yes; then
+ AC_DEFINE(HAVE_SPINLOCKS, 1, [Define to 1 if you have spinlocks.])
+ else
+ AC_MSG_WARN([
+ *** Not using spinlocks will cause poor performance.])
fi
if test "$with_krb4" = yes ; then
Index: doc/src/sgml/installation.sgml
===
RCS file: /cvsroot/pgsql-server/doc/src/sgml/installation.sgml,v
retrieving revision 1.141
diff -c -c -r1.141 installation.sgml
*** doc/src/sgml/installation.sgml 11 Sep 2003 21:42:20 - 1.141
--- doc/src/sgml/installation.sgml 12 Sep 2003 16:05:17 -
***
*** 900,905
--- 900,917
+--without-spinlocks
+
+
+ Allows source builds to succeed without CPU spinlock support.
+ Lack of spinlock support will produce poor performance.
+ This option is to be used only by platforms wi
Re: [PATCHES] tsearch pfree error
I hadn't seen this --- not sure why. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- --- Nigel J. Andrews wrote: > > I haven't seen a notice that Bruce noticed this patch I sent across general as > part of a rambling thread of mine. There again, I'm not exactly up to date with > all my email so could easily have missed it. However, in light of the beta3 > notice I'm sending it to the correct list now. > > Fixes simple bug that was causing me problems using tsearch2. > > -- > Nigel Andrews Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 7: don't forget to increase your free space map settings -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Reorganization of spinlock defines
Bruce Momjian writes: > I can make the change, but --without seemed to more closely match > because it was like readline where you didn't have it, and had to say so > specifically. I don't see how we can say --disable because this is case > were we clearly don't have spinlocks to enable, no? ./configure --help | grep --relevant-stuff Optional Features: --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no) --enable-FEATURE[=ARG] include FEATURE [ARG=yes] Optional Packages: --with-PACKAGE[=ARG]use PACKAGE [ARG=yes] --without-PACKAGE do not use PACKAGE (same as --with-PACKAGE=no) Readline is a package, spinlocks are a feature. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] Reorganization of spinlock defines
Peter Eisentraut wrote: > Bruce Momjian writes: > > > o adds a configure option --without-spinlocks to allow > > non-spinlock compiles > > --disable-spinlocks please. I can make the change, but --without seemed to more closely match because it was like readline where you didn't have it, and had to say so specifically. I don't see how we can say --disable because this is case were we clearly don't have spinlocks to enable, no? -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [PATCHES] tsearch pfree error
Applied by Tom. --- Nigel J. Andrews wrote: > > I haven't seen a notice that Bruce noticed this patch I sent across general as > part of a rambling thread of mine. There again, I'm not exactly up to date with > all my email so could easily have missed it. However, in light of the beta3 > notice I'm sending it to the correct list now. > > Fixes simple bug that was causing me problems using tsearch2. > > -- > Nigel Andrews Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 7: don't forget to increase your free space map settings -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] tsearch pfree error
On Fri, 12 Sep 2003, Bruce Momjian wrote: > > ... > > I might have assumed the tsearch guys had it handled now that they have > CVS access. Good point. I'd completely forgotten I was also expecting them to pick it up, principally because it needs to be applied to the version for running with a 7.3 server and no one else seems to know how that is being maintained. Maybe Theodor is on holiday. Nigel ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Reorganization of spinlock defines
OK. You'da boss. :-) --- Peter Eisentraut wrote: > Bruce Momjian writes: > > > I can make the change, but --without seemed to more closely match > > because it was like readline where you didn't have it, and had to say so > > specifically. I don't see how we can say --disable because this is case > > were we clearly don't have spinlocks to enable, no? > > ./configure --help | grep --relevant-stuff > > Optional Features: > --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no) > --enable-FEATURE[=ARG] include FEATURE [ARG=yes] > > Optional Packages: > --with-PACKAGE[=ARG]use PACKAGE [ARG=yes] > --without-PACKAGE do not use PACKAGE (same as --with-PACKAGE=no) > > Readline is a package, spinlocks are a feature. > > -- > Peter Eisentraut [EMAIL PROTECTED] > -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
On Thu, 11 Sep 2003, Bruce Momjian wrote: > I just learned from Larry that Unixware defines intel as i386, not > __i386 or __i386__, at least of the native SCO compiler that he uses. could we put something in the various port files to standardize this? ie. in unixware.h, add somethinglike: #ifdef i386 #define __i386__ #endif just so that 'special cases' are centralized in the ports file, and the mainstream code doesn't have: #if defined(i386) || defined(__i386) || defined(__i386__) ? ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Reorganization of spinlock defines
Bruce Momjian <[EMAIL PROTECTED]> writes: > I guess we could splatter a test for Itanium and Opterion in every port > that could possibly use it, but then again, if we fall back to not > finding it for some reason, we don't get a report because we silently > fall back to semaphores. That's what has me worried, that if we don't > do it, we will not know what platforms really aren't working properly. Agreed, the silent fallback to semaphores isn't such a hot idea in hindsight. But the part of the patch that requires a configure option to use that code path could be applied without touching anything else. regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Reorganization of spinlock defines
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The problem with waiting for 7.5 is that we will have no error reporting > > when our non-spinlock code is being executed, and with Opteron/Itanium, > > it seems like a good time to get it working. > > Well, as long as you're prepared to reduce the list of known supported > platforms to zero as of 7.4beta3, and issue a fresh call for port reports. I haven't collected any known reports yet. That happens later, I thought, nearer to RC1. > But it seems to me that this is mostly a cosmetic cleanup and therefore > not the kind of thing to be doing late in beta. Couldn't we do > something that affects only Opteron/Itanium and doesn't take a chance > on breaking everything else? Yes, but to throw an error if spinlocks aren't found, we need this patch. We would have to test for Opteron in all the platforms that test for specific CPU's but don't test for opteron, and might support opterion/itanium, but even then, we don't have any way of getting a report of a failure. Yea, I should have thought of this before beta1, but now that I see the bug reports, seems we have to go this way. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
--On Friday, September 12, 2003 00:06:49 -0400 Tom Lane <[EMAIL PROTECTED]> wrote: Larry Rosenman <[EMAIL PROTECTED]> writes: I've already sent a whine-a-gram to the compiler guys at SCO. Prolly you thought of this already, but: getting them to *add* an implicit #define of __i386__ should be plenty easy compared to getting them to *remove* the one for i386. And while I think they should remove the latter, the immediate problem would be solved as soon as they add the former. sure, and I expect that's what they may do. We'll see what they say. LER regards, tom lane -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 pgp0.pgp Description: PGP signature
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
--On Friday, September 12, 2003 00:00:43 -0400 Tom Lane <[EMAIL PROTECTED]> wrote: Larry Rosenman <[EMAIL PROTECTED]> writes: Please, only the first two. Make the Unixware template add __i386__. Don't add assumptions about valid user-namespace symbols. that's reasonable. At least until 64-bit UnixWare. :-) Even then, I'd prefer to put the necessary kluge into template/unixware or Makefile.unixware or port/unixware.h, rather than add a risky assumption globally. Sure, and 64-bit UnixWare is 2 years out any way. Hopefully we can get reasonableness by then. I've already sent a whine-a-gram to the compiler guys at SCO. LER regards, tom lane -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 pgp0.pgp Description: PGP signature
Re: [PATCHES] Reorganization of spinlock defines
Bruce Momjian <[EMAIL PROTECTED]> writes: > The problem with waiting for 7.5 is that we will have no error reporting > when our non-spinlock code is being executed, and with Opteron/Itanium, > it seems like a good time to get it working. Well, as long as you're prepared to reduce the list of known supported platforms to zero as of 7.4beta3, and issue a fresh call for port reports. But it seems to me that this is mostly a cosmetic cleanup and therefore not the kind of thing to be doing late in beta. Couldn't we do something that affects only Opteron/Itanium and doesn't take a chance on breaking everything else? regards, tom lane ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
Marc G. Fournier wrote: > > On Thu, 11 Sep 2003, Bruce Momjian wrote: > > > I just learned from Larry that Unixware defines intel as i386, not > > __i386 or __i386__, at least of the native SCO compiler that he uses. > > could we put something in the various port files to standardize this? ie. > in unixware.h, add somethinglike: > > #ifdef i386 > #define __i386__ > #endif > > just so that 'special cases' are centralized in the ports file, and the > mainstream code doesn't have: > > #if defined(i386) || defined(__i386) || defined(__i386__) Yep, that's what Tom wants and I am doing that now. I sent a patch to Larry for testing. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
Tom Lane wrote: > Larry Rosenman <[EMAIL PROTECTED]> writes: > > Bruce sent me a copy of the patch, and it BREAKS UnixWare (If y'all= > > =20 > > care). > > Unfixably? Or just a small oversight? Updated patch now works on Unixware. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
Tom Lane wrote: > Larry Rosenman <[EMAIL PROTECTED]> writes: > > Bruce sent me a copy of the patch, and it BREAKS UnixWare (If y'all= > > =20 > > care). > > Unfixably? Or just a small oversight? > > I'm actually not worried about platforms that are actively being tested. > It's the stuff that hasn't been confirmed recently that is going to be > at risk. I sent him a new patch just now. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [HACKERS] [PATCHES] Reorganization of spinlock defines
--On Thursday, September 11, 2003 23:13:54 -0400 Tom Lane <[EMAIL PROTECTED]> wrote: Larry Rosenman <[EMAIL PROTECTED]> writes: Bruce sent me a copy of the patch, and it BREAKS UnixWare (If y'all= =20 care). Unfixably? Or just a small oversight? I'm actually not worried about platforms that are actively being tested. It's the stuff that hasn't been confirmed recently that is going to be at risk. I'm seeing failures with the 2nd patch as well. Seems like it's not liking UnixWare's cc defines. the documentation is at: http://www.lerctr.org:8458/ the cc man page is at: http://www.lerctr.org:8458/en/man/html.1/cc.1.html Tom, You still have an account here. Bruce, if you'd like an account, that is easily arranged. LER regards, tom lane -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 pgp0.pgp Description: PGP signature
Re: [PATCHES] tsearch pfree error
"Nigel J. Andrews" <[EMAIL PROTECTED]> writes: > On Fri, 12 Sep 2003, Bruce Momjian wrote: >> I might have assumed the tsearch guys had it handled now that they have >> CVS access. > Good point. I'd completely forgotten I was also expecting them to pick it up, Yes, I'd also passed it over because I assumed Oleg and Teodor would take care of it. But they haven't yet, so I applied what I could. regards, tom lane ---(end of broadcast)--- TIP 8: explain analyze is your friend
