Re: [Pharo-dev] Catching Exceptions without any notice

[Nicolai Hess]

2016-03-30 19:54 GMT+02:00 Aliaksei Syrel :

> Do anyone really use GLM-Morphic-Brick?
>
We all "use" it, our tools are build with this.
(inspector/debugger/playground/spotter).


> Because it is there just for spotter and will be deleted ASAP.
>

Not only for spotter. And if our tools are build with this, people may try
to use this
for their own tools. This is the core image, and the core tools. What
should we
say?
Please don't use it, but our core tools are built on this?



> We know that it is bad. Normal fix requires too many changes...
>

No excuse.



> On Mar 30, 2016 1:34 PM, "Nicolai Hess"  wrote:
>
>> Please don't do this:
>>
>> updateHeight
>> "no need to care about height, when it's logic is not customized"
>> self layout isHeightCustom ifFalse: [ ^ self ].
>> [ self bounds: (self brickBounds withHeight: self customHeight) ]
>> on: Exception
>> do: [ "just skip and do nothing" ]
>>
>> This makes debugging GLM/Brick ui/layout code with "self haltOnce"
>> impossible.
>> see
>> GLMBrickGeometryTrait>>#updateHeight
>> GLMBrickGeometryTrait>>#updateWidth
>>
>> And if you log out the raised exception, you see some calls to
>> not initialized fonts and a ZeroDevide and some more errors.
>> The above catch, catches and hides wrong / to late initialized objects.
>>
>

Re: [Pharo-dev] 'Bad argument for external function' with UFFI... no clue

[Esteban Lorenzano]

how does your function call looks like?

> On 31 Mar 2016, at 04:55, Mariano Martinez Peck  wrote:
> 
> Hi guys,
> 
> Could someone help me understand what could be the exact reason of a 'Bad 
> argument for external function' in an FFI call? Of course, I double checked 
> all the arguments definitions in the #ffiCall: and the real objects I receive 
> as arguments at the moment of the callout. And they all seem correct. 
> 
> And even better...how can I get more info about it?
> 
> Thanks in advance,
> 
> -- 
> Mariano
> http://marianopeck.wordpress.com 

[Pharo-dev] 'Bad argument for external function' with UFFI... no clue

[Mariano Martinez Peck]

Hi guys,

Could someone help me understand what could be the exact reason of a 'Bad
argument for external function' in an FFI call? Of course, I double checked
all the arguments definitions in the #ffiCall: and the real objects I
receive as arguments at the moment of the callout. And they all seem
correct.

And even better...how can I get more info about it?

Thanks in advance,

-- 
Mariano
http://marianopeck.wordpress.com

Re: [Pharo-dev] Catching Exceptions without any notice

[Aliaksei Syrel]

Do anyone really use GLM-Morphic-Brick?

Because it is there just for spotter and will be deleted ASAP.

We know that it is bad. Normal fix requires too many changes...
On Mar 30, 2016 1:34 PM, "Nicolai Hess"  wrote:

> Please don't do this:
>
> updateHeight
> "no need to care about height, when it's logic is not customized"
> self layout isHeightCustom ifFalse: [ ^ self ].
> [ self bounds: (self brickBounds withHeight: self customHeight) ]
> on: Exception
> do: [ "just skip and do nothing" ]
>
> This makes debugging GLM/Brick ui/layout code with "self haltOnce"
> impossible.
> see
> GLMBrickGeometryTrait>>#updateHeight
> GLMBrickGeometryTrait>>#updateWidth
>
> And if you log out the raised exception, you see some calls to
> not initialized fonts and a ZeroDevide and some more errors.
> The above catch, catches and hides wrong / to late initialized objects.
>

Re: [Pharo-dev] validation error related to Fuel

[Martin Dias]

Hi,

Christophe, did you check locally if some system test fails (or there is
some loading error)?

I debugged something similar a while ago, and discovered that the source of
the problem is usually a test that fails (or errors) and the monkey/fuel is
unable to serialize/materialize the associated stack trace. I tell you why.

The monkey uses Fuel to serialize and materialize the stack trace of the
tests failures. The problem is that sometimes Fuel fails to
serialize/materialize such stack trace and then the monkey's output is a
Fuel error instead of the original error.

The default way of Fuel to serialize a method is: store it's class name,
the selector, and the bytecode's hash. To materialize such method (in a
potentially different image), Fuel uses the class name and selector to
fetch the method (which might be different from the method serialized), and
checks that bytecodes' hash are equal. The FLMethodChanged is signaled
here, since it's important that bytecodes match.

Going back to this particular error, I imagine this reason for the Fuel
error during monkey's validation: the original test failure has a a context
in its stack trace that points to the changed method, which "changed
bytecodes". What I find strange is that (AFAIK) the monkey configures Fuel
to serialize the changed entities in a special way where the original
bytecodes are stored and then FLMethodChanged shouldn't happen.

I could take a look on monkey (more precisely, on ImageWorker) if this
error is reproducible...

Cheers,
Martin


On Wed, Mar 30, 2016 at 4:41 AM, Christophe Demarey <
christophe.dema...@inria.fr> wrote:

>
> Le 30 mars 2016 à 09:31, Max Leske  a écrit :
>
>
> On 30 Mar 2016, at 09:10, Christophe Demarey 
> wrote:
>
> Hi,
>
> With case #17889, I get the following validation error:
> Exception: FLMethodChanged: Materialization error. Method
> SystemSettingsPersistence class>>#initialize changed its bytecodes.
> I have no idea what to do with that. Yes, I changed this method and …
> Does anyone have an idea?
>
> Thanks,
> Christophe
>
>
> The validation is materializing the method in the parent image, which
> means the byte code of that method is being installed. It is often safe to
> ignore that error, so you could override the #defaultAction of
> FLMethodChanged in the preload, for instance (e.g. with “self
> resumeUnchecked: nil).
>
>
> ok, thanks for the workaround.
>
>
> What I can’t tell you by heart is why the method is being serialized in
> the fist place.
>
>
> If you remember the reason, please share it.
>
> Thanks for your quick answer.
> Christophe
>

Re: [Pharo-dev] Catching Exceptions without any notice

[Richard Sargent]

Nicolas Cellier wrote
> Isn't catching too wide an anti-pattern?

Yes!
Just think of all the Exception subclasses which are *not* errors. This kind
of thing effectively disables them.



> 2016-03-30 13:33 GMT+02:00 Nicolai Hess <

> nicolaihess@

> >:
> 
>> Please don't do this:
>>
>> updateHeight
>> "no need to care about height, when it's logic is not customized"
>> self layout isHeightCustom ifFalse: [ ^ self ].
>> [ self bounds: (self brickBounds withHeight: self customHeight) ]
>> on: Exception
>> do: [ "just skip and do nothing" ]
>>
>> This makes debugging GLM/Brick ui/layout code with "self haltOnce"
>> impossible.
>> see
>> GLMBrickGeometryTrait>>#updateHeight
>> GLMBrickGeometryTrait>>#updateWidth
>>
>> And if you log out the raised exception, you see some calls to
>> not initialized fonts and a ZeroDevide and some more errors.
>> The above catch, catches and hides wrong / to late initialized objects.
>>





--
View this message in context: 
http://forum.world.st/Catching-Exceptions-without-any-notice-tp4887402p4887460.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Re: [Pharo-dev] Catching Exceptions without any notice

[Nicolas Cellier]

Isn't catching too wide an anti-pattern?

2016-03-30 13:33 GMT+02:00 Nicolai Hess :

> Please don't do this:
>
> updateHeight
> "no need to care about height, when it's logic is not customized"
> self layout isHeightCustom ifFalse: [ ^ self ].
> [ self bounds: (self brickBounds withHeight: self customHeight) ]
> on: Exception
> do: [ "just skip and do nothing" ]
>
> This makes debugging GLM/Brick ui/layout code with "self haltOnce"
> impossible.
> see
> GLMBrickGeometryTrait>>#updateHeight
> GLMBrickGeometryTrait>>#updateWidth
>
> And if you log out the raised exception, you see some calls to
> not initialized fonts and a ZeroDevide and some more errors.
> The above catch, catches and hides wrong / to late initialized objects.
>

[Pharo-dev] Catching Exceptions without any notice

[Nicolai Hess]

Please don't do this:

updateHeight
"no need to care about height, when it's logic is not customized"
self layout isHeightCustom ifFalse: [ ^ self ].
[ self bounds: (self brickBounds withHeight: self customHeight) ]
on: Exception
do: [ "just skip and do nothing" ]

This makes debugging GLM/Brick ui/layout code with "self haltOnce"
impossible.
see
GLMBrickGeometryTrait>>#updateHeight
GLMBrickGeometryTrait>>#updateWidth

And if you log out the raised exception, you see some calls to
not initialized fonts and a ZeroDevide and some more errors.
The above catch, catches and hides wrong / to late initialized objects.

[Pharo-dev] [pharo-project/pharo-core]

[GitHub]

  Branch: refs/tags/50670
  Home:   https://github.com/pharo-project/pharo-core

[Pharo-dev] [pharo-project/pharo-core] e62014: 50670

[GitHub]

  Branch: refs/heads/5.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: e6201426356538085bce73dd55c249cbb59e010d
  
https://github.com/pharo-project/pharo-core/commit/e6201426356538085bce73dd55c249cbb59e010d
  Author: Jenkins Build Server 
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
M 
ConfigurationOfDependencyAnalyser.package/ConfigurationOfDependencyAnalyser.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfDependencyAnalyser.package/ConfigurationOfDependencyAnalyser.class/instance/versions/version116_.st
R ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
scripts/script50669.st
A ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
scripts/script50670.st
R ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
updates/update50669.st
A ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
updates/update50670.st
M 
ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
A 
Tool-DependencyAnalyser-UI.package/DAReverseDependentPackageNode.class/instance/accessing/rPackage.st
A 
Tool-DependencyAnalyser-UI.package/DAReversePackageNode.class/instance/accessing/rPackage.st
M 
Tool-DependencyAnalyser.package/DAMessageSendAnalyzer.class/instance/accessing/packageStaticDependencies.st
M 
Tool-DependencyAnalyser.package/DAMessageSendAnalyzer.class/instance/computing/implementedMessages.st

  Log Message:
  ---
  50670
17886 dependency analyzer throws DNU on reverse analysis
https://pharo.fogbugz.com/f/cases/17886

http://files.pharo.org/image/50/50670.zip

[Pharo-dev] [pharo-project/pharo-core] 10a766: 50669

[GitHub]

  Branch: refs/heads/5.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: 10a766404faec99e7ff627ab14c326d29de419df
  
https://github.com/pharo-project/pharo-core/commit/10a766404faec99e7ff627ab14c326d29de419df
  Author: Jenkins Build Server 
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
M 
ConfigurationOfGTDebugger.package/ConfigurationOfGTDebugger.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGTDebugger.package/ConfigurationOfGTDebugger.class/instance/versions/version25_.st
M 
ConfigurationOfGTEventRecorder.package/ConfigurationOfGTEventRecorder.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGTEventRecorder.package/ConfigurationOfGTEventRecorder.class/instance/versions/version014_.st
M 
ConfigurationOfGTInspectorCore.package/ConfigurationOfGTInspectorCore.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGTInspectorCore.package/ConfigurationOfGTInspectorCore.class/instance/versions/version36_.st
M 
ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/versions/version36_.st
M 
ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/versions/version26_.st
M 
ConfigurationOfGToolkitCore.package/ConfigurationOfGToolkitCore.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGToolkitCore.package/ConfigurationOfGToolkitCore.class/instance/versions/version317_.st
M 
ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/symbolic
 versions/stable_.st
A 
ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/versions/version49_.st
M GT-Debugger.package/GTChangeDebuggerAction.class/definition.st
A 
GT-Debugger.package/GTChangeDebuggerAction.class/instance/accessing/newDebugger.st
M 
GT-Debugger.package/GTChangeDebuggerAction.class/instance/actions/executeAction.st
A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/README.md
A 
GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/class/instance-creation/from_.st
A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/definition.st
A 
GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/instance/accessing/debugActionExecutedAnnouncement.st
A 
GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/instance/initialization/from_.st
R 
GT-Debugger.package/GTGenericStackDebugger.class/instance/accessing/window.st
M 
GT-Debugger.package/GTGenericStackDebugger.class/instance/updating/selectionChanged_.st
A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/README.md
A 
GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/class/instance 
creation/forDebugger_.st
A 
GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/definition.st
A 
GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/instance/accessing/debugger.st
A 
GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/instance/accessing/newContext.st
A 
GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/instance/initialization/forDebugger_.st
A 
GT-Debugger.package/GTGlamourWrapperDebuggingAction.class/instance/initialization/initialize.st
M 
GT-Debugger.package/GTGlamourWrapperDebuggingAction.class/instance/transformation/asGlamourAction.st
M 
GT-Debugger.package/GTMoldableDebugger.class/class/accessing/defaultTitle.st
M 
GT-Debugger.package/GTMoldableDebugger.class/class/accessing/sessionClass.st
M 
GT-Debugger.package/GTMoldableDebugger.class/instance/actions/debug_using_.st
M 
GT-Debugger.package/GTMoldableDebugger.class/instance/building/debuggerStructureIn_.st
M 
GT-Debugger.package/GTMoldableDebugger.class/instance/callbacks/windowIsClosing.st
A GT-Debugger.package/GTMoldableDebugger.class/instance/scripting 
opening/open.st
M GT-Debugger.package/GTMoldableDebugger.class/instance/scripting 
opening/openOn_.st
M 
GT-Debugger.package/GTMoldableDebugger.class/instance/updating/updateBrowserFrom_.st
M GT-EventRecorder-Tests.package/GTDummyEvent.class/definition.st
M GT-EventRecorder-Tests.package/GTEventBundleTest.class/definition.st
M GT-EventRecorder-Tests.package/GTEventCollectorsTest.class/definition.st
M GT-EventRecorder-Tests.package/GTEventConsolidateTest.class/definition.st
M GT-EventRecorder-Tests.package/GTEventDeliveryTest.class/definition.st
M 
GT-EventRecorder-Tests.package/GTEventMultiBundleFactoryTest.class/definition.st
M GT-EventRecorder-Tests.package/GTEventMultiBundleTest.class/definition.st
M GT-EventRecorder-Tests.package/GTEventPackingTest.class/definition.st
A GT-EventRecorder-Tests.package/GTEventRecorderTe

[Pharo-dev] [pharo-project/pharo-core]

[GitHub]

  Branch: refs/tags/50669
  Home:   https://github.com/pharo-project/pharo-core

[Pharo-dev] [pharo-project/pharo-core] e7fa5c: 50668

[GitHub]

  Branch: refs/heads/5.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: e7fa5ccfe9cd72b3aea14a8012549c8cda35f85d
  
https://github.com/pharo-project/pharo-core/commit/e7fa5ccfe9cd72b3aea14a8012549c8cda35f85d
  Author: Jenkins Build Server 
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
M 
ConfigurationOfRubric.package/ConfigurationOfRubric.class/instance/symbolic 
versions/stable_.st
A 
ConfigurationOfRubric.package/ConfigurationOfRubric.class/instance/versions/version216_.st
R Rubric.package/RubFindReplaceService.class/instance/as yet 
unclassified/hasActiveDialog.st
M Rubric.package/RubFindReplaceService.class/instance/events 
handling/whenTextAreaGotFocus_.st
M Rubric.package/RubFindReplaceService.class/instance/events 
handling/whenTextAreaLostFocus_.st
M Rubric.package/RubFindReplaceService.class/instance/events 
handling/whenTextAreaSelectionChanged_.st
R ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
scripts/script50667.st
A ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
scripts/script50668.st
R ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
updates/update50667.st
A ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
updates/update50668.st
M 
ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st

  Log Message:
  ---
  50668
17909 Update Rubric to 2.16
https://pharo.fogbugz.com/f/cases/17909

http://files.pharo.org/image/50/50668.zip

[Pharo-dev] [pharo-project/pharo-core]

[GitHub]

  Branch: refs/tags/50668
  Home:   https://github.com/pharo-project/pharo-core

[Pharo-dev] [pharo-project/pharo-core]

[GitHub]

  Branch: refs/tags/50667
  Home:   https://github.com/pharo-project/pharo-core

[Pharo-dev] [pharo-project/pharo-core] 482293: 50667

[GitHub]

  Branch: refs/heads/5.0
  Home:   https://github.com/pharo-project/pharo-core
  Commit: 4822936ea954ae84914d5eaf5cfd1bbec20acfa4
  
https://github.com/pharo-project/pharo-core/commit/4822936ea954ae84914d5eaf5cfd1bbec20acfa4
  Author: Jenkins Build Server 
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
M 
Announcements-Core.package/AnnouncementSubscription.class/instance/converting/makeWeak.st
M 
Announcements-Core.package/WeakSubscriptionBuilder.class/instance/private/subscribe_do_.st
A Announcements-Tests-Core.package/WeakAnnouncerTest.class/instance/as yet 
unclassified/testNoDeadWeakSubscriptions.st
A Announcements-Tests-Core.package/WeakAnnouncerTest.class/instance/as yet 
unclassified/testWeakDoubleAnnouncer.st
A 
Announcements-Tests-Core.package/WeakAnnouncerTest.class/instance/testing/testWeakSubscriptionRelease.st
M Kernel.package/WeakMessageSend.class/instance/evaluating/value.st
M 
Kernel.package/WeakMessageSend.class/instance/evaluating/valueWithArguments_.st
M 
Kernel.package/WeakMessageSend.class/instance/evaluating/valueWithEnoughArguments_.st
M Kernel.package/WeakMessageSend.class/instance/evaluating/value_.st
M Kernel.package/WeakMessageSend.class/instance/evaluating/value_value_.st
M 
Kernel.package/WeakMessageSend.class/instance/evaluating/value_value_value_.st
A 
Kernel.package/WeakMessageSend.class/instance/private/ensureReceiverAndArguments_.st
A Kernel.package/WeakMessageSend.class/instance/private/ensureReceiver_.st
R ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
scripts/script50666.st
A ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
scripts/script50667.st
R ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
updates/update50666.st
A ScriptLoader50.package/ScriptLoader.class/instance/pharo - 
updates/update50667.st
M 
ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
M Slot.package/IndexedSlot.class/instance/meta-object-protocol/read_.st
M Slot.package/IndexedSlot.class/instance/meta-object-protocol/write_to_.st
A Tests.package/SystemAnnouncerLiveTest.class/README.md
A Tests.package/SystemAnnouncerLiveTest.class/definition.st
A 
Tests.package/SystemAnnouncerLiveTest.class/instance/tests/testNoDeadSubscriptions.st
A 
Tests.package/SystemAnnouncerLiveTest.class/instance/tests/testOnlyWeakSubscriptions.st
A 
Tests.package/SystemAnnouncerLiveTest.class/instance/tests/testSaneSubscriptionSize.st

  Log Message:
  ---
  50667
17537 SystemAnnouncer has far too many subscriptions
https://pharo.fogbugz.com/f/cases/17537

17899 Slots should not send messages to the parent objects
https://pharo.fogbugz.com/f/cases/17899

17906 WeakMessageSend is broken
https://pharo.fogbugz.com/f/cases/17906

http://files.pharo.org/image/50/50667.zip

Re: [Pharo-dev] validation error related to Fuel

[Christophe Demarey]

> Le 30 mars 2016 à 09:31, Max Leske  a écrit :
> 
> 
>> On 30 Mar 2016, at 09:10, Christophe Demarey > > wrote:
>> 
>> Hi,
>> 
>> With case #17889, I get the following validation error:
>> Exception: FLMethodChanged: Materialization error. Method 
>> SystemSettingsPersistence class>>#initialize changed its bytecodes.
>> 
>> I have no idea what to do with that. Yes, I changed this method and …
>> Does anyone have an idea?
>> 
>> Thanks,
>> Christophe
> 
> The validation is materializing the method in the parent image, which means 
> the byte code of that method is being installed. It is often safe to ignore 
> that error, so you could override the #defaultAction of FLMethodChanged in 
> the preload, for instance (e.g. with “self resumeUnchecked: nil).

ok, thanks for the workaround.

> 
> What I can’t tell you by heart is why the method is being serialized in the 
> fist place.

If you remember the reason, please share it.

Thanks for your quick answer.
Christophe

Re: [Pharo-dev] validation error related to Fuel

[Max Leske]

> On 30 Mar 2016, at 09:10, Christophe Demarey  
> wrote:
> 
> Hi,
> 
> With case #17889, I get the following validation error:
> Exception: FLMethodChanged: Materialization error. Method 
> SystemSettingsPersistence class>>#initialize changed its bytecodes.
> 
> I have no idea what to do with that. Yes, I changed this method and …
> Does anyone have an idea?
> 
> Thanks,
> Christophe

The validation is materializing the method in the parent image, which means the 
byte code of that method is being installed. It is often safe to ignore that 
error, so you could override the #defaultAction of FLMethodChanged in the 
preload, for instance (e.g. with “self resumeUnchecked: nil).

What I can’t tell you by heart is why the method is being serialized in the 
fist place.

Cheers,
Max

[Pharo-dev] validation error related to Fuel

[Christophe Demarey]

Hi,

With case #17889, I get the following validation error:
Exception: FLMethodChanged: Materialization error. Method 
SystemSettingsPersistence class>>#initialize changed its bytecodes.

I have no idea what to do with that. Yes, I changed this method and …
Does anyone have an idea?

Thanks,
Christophe