Re: [PHP-DEV] Fixes/suggestions for PHP 4.2.2
Hello Troels, I merged all suggested patches to the branch, and applied most of your patches, except for the pcre thing, as I don't know how this is supposed to work. Thank you for submitting this, and if you may find anything else, feel free to write this list. regards, Derick On Sun, 23 Jun 2002, Troels Arvin wrote: Hello, If PHP 4.2.2 is going to be released, then I have some suggestions: I believe that the following changes to HEAD should be MFH'ed: http://cvs.php.net/diff.php/php4/ext/gmp/config.m4?r1=1.6r2=1.7 http://cvs.php.net/diff.php/php4/ext/standard/link.c?r1=1.37r2=1.38 http://cvs.php.net/diff.php/php4/ext/standard/math.c?sbt=2r1=1.83r2=1.85 http://cvs.php.net/diff.php/php4/ext/mcrypt/mcrypt.c?r1=1.75r2=1.76 http://cvs.php.net/diff.php/php4/ext/standard/basic_functions.c?r1=1.478r2=1.479 http://cvs.php.net/diff.php/php4/ext/standard/string.c?r1=1.274r2=1.275 http://cvs.php.net/diff.php/php4/ext/standard/versioning.c?sbt=2r1=1.8r2=1.9 I also _seems_ that the May 17 changes in HEAD's sysvsem extension should be MFH'ed. I need the following patch for the mcal extension to build properly as a shared module on my Linuxes: http://rpms.arvin.dk/php/source/patches/php-4.2.1-mcal-shared.patch It reverts a change made by sniper on April 3. Without the patch, then the main PHP binary links to libmcal.so.0, but the PHP extension (mcal.so) doesn't. If I don't use the following patch, then the pcre extension will not build with the system pcre library: http://rpms.arvin.dk/php/source/patches/php-4.2.1-pcre.h.patch The correct fix would probably be to add checks in pcre's config.m4 (see if pcre.h is in /usr/local/include/pcre, /usr/local/include, /usr/include/pcre, or /usr/include). If I don't use the following patch, then make install will fail to respect a prefix= argument when doing make install: http://rpms.arvin.dk/php/source/patches/php-4.2.1-regression-tools.patch -- Greetings from Troels Arvin, Copenhagen, Denmark -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php --- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Fixes/suggestions for PHP 4.2.2
Hello Derick, On Mon, 24 Jun 2002 10:48:56 +0200, derick wrote: I merged all suggested patches to the branch, and applied most of your patches Thanks! - That will make my RPM-building process a bit easier. except for the pcre thing, as I don't know how this is supposed to work. I'll try creating a proper patch for pcre's config.m4; hopefully in the PHP 4.2.2 time frame. Thank you for submitting this, and if you may find anything else, feel free to write this list. Actually, I have one more suggestion. See this patch: http://rpms.arvin.dk/php/source/patches/php-4.2-info.c.patch It clears up some potential misunderstandings in phpinfo()'s output. Example: phpinfo()'s Apache Version output prints the apache version present at build-time. If PHP is built on a system with Apache 1.3.26, and then installed on a system with an Apach 1.3.20, then phpinfo() will currently write: Apache Version: 1.3.26. This is confusing, at best. And it could make some not-so-experienced system administrators think that their Apache doesn't have the nasty chunked encoding bug while, in fact, it has. -- Greetings from Troels Arvin, Copenhagen, Denmark -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Fixes/suggestions for PHP 4.2.2
Hi, On Mon, Jun 24, 2002 at 11:38:04AM +0200, Troels Arvin wrote : http://rpms.arvin.dk/php/source/patches/php-4.2-info.c.patch That's a good idea. Though it's necessary for 4.2.x I don't know. However, I like to rephrase this info a bit, the sentence is just way to long imho. Something like Compiled against Apache Version or similiar should do it as well. - Markus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Fixes/suggestions for PHP 4.2.2
On Mon, 24 Jun 2002, Markus Fischer wrote: Hi, On Mon, Jun 24, 2002 at 11:38:04AM +0200, Troels Arvin wrote : http://rpms.arvin.dk/php/source/patches/php-4.2-info.c.patch That's a good idea. Though it's necessary for 4.2.x I don't know. However, I like to rephrase this info a bit, the sentence is just way to long imho. Something like Compiled against Apache Version or similiar should do it as well. That's still too long to put into the first column Derick --- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Fixes/suggestions for PHP 4.2.2
How about this: Apache Headers: version --Wez. On 24/06/02, [EMAIL PROTECTED] wrote: On Mon, 24 Jun 2002, Markus Fischer wrote: On Mon, Jun 24, 2002 at 11:38:04AM +0200, Troels Arvin wrote : http://rpms.arvin.dk/php/source/patches/php-4.2-info.c.patch That's a good idea. Though it's necessary for 4.2.x I don't know. However, I like to rephrase this info a bit, the sentence is just way to long imho. Something like Compiled against Apache Version or similiar should do it as well. That's still too long to put into the first column -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Fixes/suggestions for PHP 4.2.2
Hello, If PHP 4.2.2 is going to be released, then I have some suggestions: I believe that the following changes to HEAD should be MFH'ed: http://cvs.php.net/diff.php/php4/ext/gmp/config.m4?r1=1.6r2=1.7 http://cvs.php.net/diff.php/php4/ext/standard/link.c?r1=1.37r2=1.38 http://cvs.php.net/diff.php/php4/ext/standard/math.c?sbt=2r1=1.83r2=1.85 http://cvs.php.net/diff.php/php4/ext/mcrypt/mcrypt.c?r1=1.75r2=1.76 http://cvs.php.net/diff.php/php4/ext/standard/basic_functions.c?r1=1.478r2=1.479 http://cvs.php.net/diff.php/php4/ext/standard/string.c?r1=1.274r2=1.275 http://cvs.php.net/diff.php/php4/ext/standard/versioning.c?sbt=2r1=1.8r2=1.9 I also _seems_ that the May 17 changes in HEAD's sysvsem extension should be MFH'ed. I need the following patch for the mcal extension to build properly as a shared module on my Linuxes: http://rpms.arvin.dk/php/source/patches/php-4.2.1-mcal-shared.patch It reverts a change made by sniper on April 3. Without the patch, then the main PHP binary links to libmcal.so.0, but the PHP extension (mcal.so) doesn't. If I don't use the following patch, then the pcre extension will not build with the system pcre library: http://rpms.arvin.dk/php/source/patches/php-4.2.1-pcre.h.patch The correct fix would probably be to add checks in pcre's config.m4 (see if pcre.h is in /usr/local/include/pcre, /usr/local/include, /usr/include/pcre, or /usr/include). If I don't use the following patch, then make install will fail to respect a prefix= argument when doing make install: http://rpms.arvin.dk/php/source/patches/php-4.2.1-regression-tools.patch -- Greetings from Troels Arvin, Copenhagen, Denmark -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
