Re: [PHP-DEV] Redirect patch URL
On Tue, 26 Nov 2002, John Coggeshall wrote: http://coogle.homeip.net:81/php/patches/error_redirect.html Please check out this URL and let me know what you guys think of the second version of this patch. It basically is pretty solid at this point. Your diff is in the wrong order, the whitespace is totally screwed, and putting it in HTML makes it not readable at all. Can you please put up a patch in a plain text file and with the correct +/- things? Derick -- - Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ - -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Redirect patch URL
http://coogle.homeip.net:81/php/patches/error_redirect.txt John -Original Message- From: Derick Rethans [mailto:[EMAIL PROTECTED]] Sent: Tuesday, November 26, 2002 4:22 PM To: John Coggeshall Cc: 'PHP Developers Mailing List' Subject: Re: [PHP-DEV] Redirect patch URL On Tue, 26 Nov 2002, John Coggeshall wrote: http://coogle.homeip.net:81/php/patches/error_redirect.html Please check out this URL and let me know what you guys think of the second version of this patch. It basically is pretty solid at this point. Your diff is in the wrong order, the whitespace is totally screwed, and putting it in HTML makes it not readable at all. Can you please put up a patch in a plain text file and with the correct +/- things? Derick -- --- -- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- -- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Redirect patch URL
Regarding this proposal, what happens if the url being redirected to has an error? Or if it's down for some reason, how can I still see my errors without bugging the sysadmin? Also, will CLI and CGI be affected too? Regards, Philip On Tue, 26 Nov 2002, John Coggeshall wrote: http://coogle.homeip.net:81/php/patches/error_redirect.txt John -Original Message- From: Derick Rethans [mailto:[EMAIL PROTECTED]] Sent: Tuesday, November 26, 2002 4:22 PM To: John Coggeshall Cc: 'PHP Developers Mailing List' Subject: Re: [PHP-DEV] Redirect patch URL On Tue, 26 Nov 2002, John Coggeshall wrote: http://coogle.homeip.net:81/php/patches/error_redirect.html Please check out this URL and let me know what you guys think of the second version of this patch. It basically is pretty solid at this point. Your diff is in the wrong order, the whitespace is totally screwed, and putting it in HTML makes it not readable at all. Can you please put up a patch in a plain text file and with the correct +/- things? Derick -- --- -- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- -- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Redirect patch URL
Regarding this proposal, what happens if the url being redirected to has an error? Or if it's down for some reason, how can I still see my errors without bugging the sysadmin? Also, will CLI and CGI be affected too? This is still an issue (infinite loops regarding errors On the error page)... I am trying to figure out a clean Way of flagging that errors occuring on the error page Should not be redirected but rather dumped as normal errors. Input is most welcome for that issue... One thought that is to Limit redirections to the same server and then compare PHP_SELF To the relevant portion of the redirect URL: Error_redirect_url = http://www.somewhere.com/error.php Basically Before redirecting, make sure /error.php != $PHP_SELF Other thoughts are most welcome on that. As for CGI, the behavior for the redirection will work just As with the module version of PHP. As for CLI, the assumption Here is that error_redirect would be set to OFF (hence, standard Error reporting would apply). That can be confirmed by adding An additional check to disable error-redirects if it is a CLI PHP within the code... Cheers, John Regards, Philip On Tue, 26 Nov 2002, John Coggeshall wrote: http://coogle.homeip.net:81/php/patches/error_redirect.txt John -Original Message- From: Derick Rethans [mailto:[EMAIL PROTECTED]] Sent: Tuesday, November 26, 2002 4:22 PM To: John Coggeshall Cc: 'PHP Developers Mailing List' Subject: Re: [PHP-DEV] Redirect patch URL On Tue, 26 Nov 2002, John Coggeshall wrote: http://coogle.homeip.net:81/php/patches/error_redirect.html Please check out this URL and let me know what you guys think of the second version of this patch. It basically is pretty solid at this point. Your diff is in the wrong order, the whitespace is totally screwed, and putting it in HTML makes it not readable at all. Can you please put up a patch in a plain text file and with the correct +/- things? Derick -- --- -- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- -- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Redirect patch URL
At 00:51 27-11-2002, John Coggeshall wrote: Regarding this proposal, what happens if the url being redirected to has an error? Or if it's down for some reason, how can I still see my errors without bugging the sysadmin? Also, will CLI and CGI be affected too? This is still an issue (infinite loops regarding errors On the error page)... I am trying to figure out a clean Way of flagging that errors occuring on the error page Should not be redirected but rather dumped as normal errors. I really don't see, why you pursue redirection. First of all, last time I looked, redirects do not have a referer. So your statement about being able to track the cause of the error, assumes that whatever error occurs, the stack which contains PHP_SELF must still be available and you must append that to the URI. Secondly - you cannot get any information about the state of the error, even if it IS available. We should really look more closely at what ARE fatal errors and why it should stop execution. Redirection is just a hack, which forces behavior on webservers i.s.o. providing end-users with the methods to handle problems any way they like. IMO that is what PHP is about: enabling end-users to accomplish tasks, not doing it for them and taking away control. With kind regards, Melvyn Sopacua ?php include(not_reflecting_employers_views.txt); ? -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
