Review Request: plasmapkg wallpaper
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/ --- Review request for Plasma. Summary --- * install wallpaper plasma packages * auto detect (plasmoids,) dataengines, runners and wallpapers (install them without --type) * Remove previous package also with --install Diffs - /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1042090 Diff: http://reviewboard.kde.org/r/2006/diff Testing --- Thanks, Petri ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Activities service in KDEreview
On Wednesday 21 October 2009 21:46:39 Ivan Čukić wrote: After some time I spent on the ice due to problems with compiling Qt 4.6, I've finally been able to polish the activities service. It is now in kdereview/nepomuk-activities-service As I understand the code, current activity is globally modal? Will ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Activities service in KDEreview
As I understand the code, current activity is globally modal? Yes. Although plasma will be the main manager of activities, other applications can be as well. I'm currently preparing a bit of nepomukification of the storage (as per Sebastian's instructions) - will be committed very soon. Cheerio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Activities service in KDEreview
On Thursday 29 October 2009 10:41:01 Ivan Čukić wrote: As I understand the code, current activity is globally modal? Yes. Although plasma will be the main manager of activities, other applications can be as well. That's interesting, but I am interested in the UI implications of having a single modal current activity. That implies that exactly one activity is visible at one time - including in such exotic setups as second monitors. How does your model handle that? I have reviewed all the old activity, overview and nepomuk threads on panel-devel@ but I couldn't find an answer - please point me if it was discussed already elsewhere. Will ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmapkg wallpaper
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2852 --- /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp http://reviewboard.kde.org/r/2006/#comment2218 hm; either wallpaperplugin needs to be added to the command line information above or, imho even better, it should autodetect whether it has a bunch of images or a scripted wallpaperplugin package and just do the right thing based on that. a bit more code, but would be a nicer UI. /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp http://reviewboard.kde.org/r/2006/#comment2217 with this there really is no point in having upgrade. the idea is that install should always be safe and not silently obliterate something that already exists there just because of a naming collision. - Aaron On 2009-10-29 07:00:48, Petri Damstén wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/ --- (Updated 2009-10-29 07:00:48) Review request for Plasma. Summary --- * install wallpaper plasma packages * auto detect (plasmoids,) dataengines, runners and wallpapers (install them without --type) * Remove previous package also with --install Diffs - /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1042090 Diff: http://reviewboard.kde.org/r/2006/diff Testing --- Thanks, Petri ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmapkg wallpaper
On 29/10-2009 17:09 Aaron Seigo ase...@kde.org wrote: /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp http://reviewboard.kde.org/r/2006/#comment2217 with this there really is no point in having upgrade. the idea is that install should always be safe and not silently obliterate something that already exists there just because of a naming collision. It was also mentioned in http://mail.kde.org/pipermail/plasma-devel/2009- October/008738.html but at that time I hadn't thought of name collision. Maybe the better solution would be to let plasmapkg be more verbose and maybe add a --force-overwrite option or something like that. I don't know if Plasma::PackageStructure-uninstallPackage() has any error checking (couldn't find it on websvn) but it has failed for me at some occasions where it removed the content and not the directory therefore letting plasmapkg fail on both -i and -r. -- Best Regards / Med venlig hilsen Thomas Olsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmapkg wallpaper
On October 29, 2009, Thomas Olsen wrote: maybe add a --force-overwrite option or something like that. it already has one: --upgrade. I don't know if Plasma::PackageStructure-uninstallPackage() has any error checking some but not enough, really. (couldn't find it on websvn) but it has failed for me at some occasions where it removed the content and not the directory therefore letting plasmapkg fail on both -i and -r. the content? you mean the service file? or? personally, i'd also like to see it fixed so that it can remove an entry by the same name it was installed with in all cases (e.g. by recording the original file name somewhere). -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Plasma Netbook animated Version 1
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), and Adenilson Cavalcanti. Summary --- Add animated layouts to plasma-netbook. Animate add/remove widgets in layouts(grid and linear). Diffs - trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmapkg wallpaper
On 29/10-2009 18:49 Aaron J. Seigo ase...@kde.org wrote: On October 29, 2009, Thomas Olsen wrote: maybe add a --force-overwrite option or something like that. it already has one: --upgrade. Which isn't enough at it's current state. See below. I don't know if Plasma::PackageStructure-uninstallPackage() has any error checking some but not enough, really. (couldn't find it on websvn) but it has failed for me at some occasions where it removed the content and not the directory therefore letting plasmapkg fail on both -i and -r. the content? you mean the service file? or? I should have checked it more thoroughly but at that time I just wanted it to work. I had removed with plasmapkg -r. then I tried to reinstall with plasmapkg -i with no success. Tried to remove it again but got the error message that the package wasn't installed. Scratched my head for ½ minute and checked it ~/.kde/share/apps/plasmoids/package was still there. It was and when I deleted it the re-installation succeeded. Next time (if any such) I will check which files are actually removed. personally, i'd also like to see it fixed so that it can remove an entry by the same name it was installed with in all cases (e.g. by recording the original file name somewhere). Do you mean the package name like somewidget-0.3.1.plasmoid? -- Best Regards / Med venlig hilsen Thomas Olsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2853 --- The commit itself seems nice. Just worried if we want to start using this all around. *Maybe* we have animated layouts in Qt *4.7* that would be more generic than this. But if we just want something specific it seems fine for me, just take a look at the details below. trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp http://reviewboard.kde.org/r/2008/#comment2219 Why setting up the animation when setting the widget ? It would be nice to have a way to tell the layout which animation I want it to make, or give a group of animations. The way it is now all the animations are of the same kind (geometry) and using the same specs (easing curve and duration). Not sure it's a problem here as this is very specific. In our case (Animated Layouts in Qt) we had to be much more generic. Not sure what would be the desired result of this commit. Maybe Marco/Aaron can give more details about it. trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h http://reviewboard.kde.org/r/2008/#comment2220 extra space in the end of line trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp http://reviewboard.kde.org/r/2008/#comment2221 maybe better to implement in the proxy to delete the first (and only) item ? so here you can just delete the layout. You can also setOwnedByLayout(item) in the proxy so you just delete the layout here. it seems that the fact that the item is at position 0 is an implementation detail of the proxy that should not go outside. - Artur On 2009-10-29 18:26:10, igorto wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-29 18:26:10) Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), and Adenilson Cavalcanti. Summary --- Add animated layouts to plasma-netbook. Animate add/remove widgets in layouts(grid and linear). Diffs - trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-29 18:45:58.421256) Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), and Adenilson Cavalcanti. Changes --- Fix remove item Summary --- Add animated layouts to plasma-netbook. Animate add/remove widgets in layouts(grid and linear). Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmapkg wallpaper
On October 29, 2009, Thomas Olsen wrote: On 29/10-2009 18:49 Aaron J. Seigo ase...@kde.org wrote: On October 29, 2009, Thomas Olsen wrote: maybe add a --force-overwrite option or something like that. it already has one: --upgrade. Which isn't enough at it's current state. See below. i see something about -i, not -u below? I don't know if Plasma::PackageStructure-uninstallPackage() has any error checking some but not enough, really. (couldn't find it on websvn) but it has failed for me at some occasions where it removed the content and not the directory therefore letting plasmapkg fail on both -i and -r. the content? you mean the service file? or? I should have checked it more thoroughly but at that time I just wanted it to work. I had removed with plasmapkg -r. then I tried to reinstall with plasmapkg -i with no success. Tried to remove it again but got the error message that the package wasn't installed. Scratched my head for ½ minute and checked it ~/.kde/share/apps/plasmoids/package was still there. It was and when I deleted it the re-installation succeeded. Next time (if any such) I will check which files are actually removed. better, i suppose, would be to locate the code path that leads to the directory not being removed and fix that. perhaps -i on error could suggest using -u in such cases as well? personally, i'd also like to see it fixed so that it can remove an entry by the same name it was installed with in all cases (e.g. by recording the original file name somewhere). Do you mean the package name like somewidget-0.3.1.plasmoid? right. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Add a tooltip to battery monitor applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/ --- Review request for Plasma. Summary --- This path adds a tool-tip for the battery-monitor applet. The tool-tip contains charge percentage and estimated time left. The patch also changes the CMakeLists.txt to make it possible to compile the applet standalone. Diffs - trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt 1041319 trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1041319 trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1041319 Diff: http://reviewboard.kde.org/r/2010/diff Testing --- I'm not running trunk, so I had to comment out the setStatus() functions (not done in the patch). Thanks, Kåre ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmapkg wallpaper
On October 29, 2009, Thomas Olsen wrote: On 29/10-2009 19:56 Aaron J. Seigo ase...@kde.org wrote: On October 29, 2009, Thomas Olsen wrote: On 29/10-2009 18:49 Aaron J. Seigo ase...@kde.org wrote: On October 29, 2009, Thomas Olsen wrote: maybe add a --force-overwrite option or something like that. it already has one: --upgrade. Which isn't enough at it's current state. See below. i see something about -i, not -u below? Ah - forgot to mention that it failed with the same error: Plugin package is not installed. I don't know if Plasma::PackageStructure-uninstallPackage() has any error checking some but not enough, really. (couldn't find it on websvn) but it has failed for me at some occasions where it removed the content and not the directory therefore letting plasmapkg fail on both -i and -r. the content? you mean the service file? or? I should have checked it more thoroughly but at that time I just wanted it to work. I had removed with plasmapkg -r. then I tried to reinstall with plasmapkg -i with no success. Tried to remove it again but got the error message that the package wasn't installed. Scratched my head for ½ minute and checked it ~/.kde/share/apps/plasmoids/package was still there. It was and when I deleted it the re-installation succeeded. Next time (if any such) I will check which files are actually removed. better, i suppose, would be to locate the code path that leads to the directory not being removed and fix that. perhaps -i on error could suggest using -u in such cases as well? You're right. Where is Plasma::PackageStructure found? I may be blind but I couldn't find it. kdelibs/plasma/packagestructure.* the individual implementations for applet, wallpaper, etc. are in: kdelibase/plasma/private/packages.cpp plasmapkg (just in case, because it's in an odd place too) is in: kdebase/runtime/plasma/tools/plasmapkg -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add a tooltip to battery monitor applet
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2010/#review2854
---
a few bits of clean up, but a tooltip is a good idea here.
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt
http://reviewboard.kde.org/r/2010/#comment
this shouldn't be committed to svn (though i see why you added it for your
own needs :)
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp
http://reviewboard.kde.org/r/2010/#comment2223
interestingly, you don't need to include this one as ToolTipManager drags
it in for us. not a big deal at all, just a perhaps-interesting note :)
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp
http://reviewboard.kde.org/r/2010/#comment2224
i believe for translation purposes, this should be all on the same line and
shouldn't be using arg() either, e.g.:
if (status == Discharging) {
content += i18n(Discharging: %1 charged, battery_charge);
} else {
content += i18n(Charging: %1 charged, battery_charge);
}
content.append(br); // keep that out of the i18n
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp
http://reviewboard.kde.org/r/2010/#comment2225
we don't show time remaining; it's a bogus number.
- Aaron
On 2009-10-29 20:26:00, Kåre Särs wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2010/
---
(Updated 2009-10-29 20:26:00)
Review request for Plasma.
Summary
---
This path adds a tool-tip for the battery-monitor applet. The tool-tip
contains charge percentage and estimated time left. The patch also changes
the CMakeLists.txt to make it possible to compile the applet standalone.
Diffs
-
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt
1041319
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h
1041319
trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp
1041319
Diff: http://reviewboard.kde.org/r/2010/diff
Testing
---
I'm not running trunk, so I had to comment out the setStatus() functions (not
done in the patch).
Thanks,
Kåre
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: The commit itself seems nice. Just worried if we want to start using this all around. *Maybe* we have animated layouts in Qt *4.7* that would be more generic than this. But if we just want something specific it seems fine for me, just take a look at the details below. i'm also for keeping it internal, even if the temptation to use it elsewere is big, hopefully we will be able to replace it for qt 4.7 time On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp, line 26 http://reviewboard.kde.org/r/2008/diff/1/?file=13486#file13486line26 Why setting up the animation when setting the widget ? It would be nice to have a way to tell the layout which animation I want it to make, or give a group of animations. The way it is now all the animations are of the same kind (geometry) and using the same specs (easing curve and duration). Not sure it's a problem here as this is very specific. In our case (Animated Layouts in Qt) we had to be much more generic. Not sure what would be the desired result of this commit. Maybe Marco/Aaron can give more details about it. i do think that the duration should be the same for everybody, not controllable :) the setwidget could be somewhat inferred from the parentLayoutItem in the ctor On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp, line 34 http://reviewboard.kde.org/r/2008/diff/1/?file=13489#file13489line34 maybe better to implement in the proxy to delete the first (and only) item ? so here you can just delete the layout. You can also setOwnedByLayout(item) in the proxy so you just delete the layout here. it seems that the fact that the item is at position 0 is an implementation detail of the proxy that should not go outside. agree - Marco --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2853 --- On 2009-10-29 18:45:58, igorto wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-29 18:45:58) Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), and Adenilson Cavalcanti. Summary --- Add animated layouts to plasma-netbook. Animate add/remove widgets in layouts(grid and linear). Diffs - trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2008/#review2856
---
i generally like it, apart of the couple of code issues below i think the
animation of the grid should be a bit lighter, like all the items scrolling
in the same direction like a single block, appearing from left (scrollwidget
would have to always clip, but that's sensible)
there seems to be some issues with size hints, since the only way to have a
proper hint is to have the final size the widget will have seems hard to fix,
how do you guys did with the real qt ones?
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h
http://reviewboard.kde.org/r/2008/#comment2228
QGraphicsLayoutItem should be more than enough
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h
http://reviewboard.kde.org/r/2008/#comment2229
just generic code style stuff: all this block should be indented a level
less, so public: at the level of {
- Marco
On 2009-10-29 18:45:58, igorto wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2008/
---
(Updated 2009-10-29 18:45:58)
Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza
(MoRpHeUz), and Adenilson Cavalcanti.
Summary
---
Add animated layouts to plasma-netbook.
Animate add/remove widgets in layouts(grid and linear).
Diffs
-
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp
1042281
Diff: http://reviewboard.kde.org/r/2008/diff
Testing
---
Thanks,
igorto
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
On Thursday 29 October 2009, 18:23 Marco Martin wrote: there seems to be some issues with size hints, since the only way to have a proper hint is to have the final size the widget will have seems hard to fix, how do you guys did with the real qt ones? I need to take a look at our branch. But from what we remember we didn't support the change of size hints in an animated way (if this was your question :) Cheers, --- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia --- http://claimid.com/morpheuz Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net --- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
On Thursday 29 October 2009, Artur Souza (MoRpHeUz) wrote: On Thursday 29 October 2009, 18:23 Marco Martin wrote: there seems to be some issues with size hints, since the only way to have a proper hint is to have the final size the widget will have seems hard to fix, how do you guys did with the real qt ones? I need to take a look at our branch. But from what we remember we didn't support the change of size hints in an animated way (if this was your question i think the key is just to have a meaningful sizehint that will be ok when the animation fill be over. sounds a bit reading into the future... :) Cheers, --- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia --- http://claimid.com/morpheuz Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net --- -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-30 03:40:42.598111) Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), and Adenilson Cavalcanti. Summary --- Add animated layouts to plasma-netbook. Animate add/remove widgets in layouts(grid and linear). Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp PRE-CREATION trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h 1042281 trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Netbook animated Version 1
On 2009-10-29 21:23:59, Marco Martin wrote:
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h,
line 9
http://reviewboard.kde.org/r/2008/diff/2/?file=13499#file13499line9
QGraphicsLayoutItem should be more than enough
done
On 2009-10-29 21:23:59, Marco Martin wrote:
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h,
line 9
http://reviewboard.kde.org/r/2008/diff/2/?file=13509#file13509line9
just generic code style stuff: all this block should be indented a
level less, so public: at the level of {
done
- igorto
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2008/#review2856
---
On 2009-10-30 03:40:42, igorto wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2008/
---
(Updated 2009-10-30 03:40:42)
Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza
(MoRpHeUz), and Adenilson Cavalcanti.
Summary
---
Add animated layouts to plasma-netbook.
Animate add/remove widgets in layouts(grid and linear).
Diffs
-
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp
PRE-CREATION
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h
1042281
trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp
1042281
Diff: http://reviewboard.kde.org/r/2008/diff
Testing
---
Thanks,
igorto
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
