Re: where to download plasma-mobile solution for MeeGo?

2011-01-20 Thread Marco Martin 
On Wednesday 19 January 2011, Rohan Garg wrote:
> Do meego repos even have those? Im not sure, but theres Kubuntu Mobile that

yes, there is a personal repository made by kde ppl, that's quite ineresting 
since it uses the kdelibs mobile profile and includes koffice/calligra mobile 
as well.

> you can use on a N900, theres also a ubuntu lucid chroot that you can boot
> on a Android device and then you can install plasma mobile on it :-)

yes, Kubuntu is an option as well, they have an experimental ppa with plasma 
mobile, kdepim trunk with the mobile version as well, built against the kde 
4.6 rc2 packages.
last time I checked the plasma mobile packages were quite old, hope they have 
been updated.

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6375/
---

(Updated Jan. 20, 2011, 5:44 p.m.)


Review request for Plasma.


Summary
---

According to suggestion given by Aaron (refer to mailing list thread 
http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have 
done changes in trunk/KDE/kdelibs/plasma/. I have added functions setUrls(const 
KUrl::List &urls) as public function and addUrls(const KUrl::List &urls) as 
protected Q_SLOTS in it so that setUrls() can be invoked from frame applet. 
There are more patches to come, after this one gets approved.


Diffs
-

  trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 
  trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 

Diff: http://svn.reviewboard.kde.org/r/6375/diff


Testing
---

Tested in trunk and everything is working fine.


Thanks,

Sinny

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6375/#review9658
---

Ship it!


just needs apidox.


trunk/KDE/kdelibs/plasma/wallpaper.h


will need API documentation before committing.



trunk/KDE/kdelibs/plasma/wallpaper.h


needs apidox; should include a bit about how in libplasma2/KDE5 this will 
be merged with setUrls and be made a virtual method.

will need an @since 4.7 in there too :)


- Aaron


On Jan. 20, 2011, 5:44 p.m., Sinny Kumari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6375/
> ---
> 
> (Updated Jan. 20, 2011, 5:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> According to suggestion given by Aaron (refer to mailing list thread 
> http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have 
> done changes in trunk/KDE/kdelibs/plasma/. I have added functions 
> setUrls(const KUrl::List &urls) as public function and addUrls(const 
> KUrl::List &urls) as protected Q_SLOTS in it so that setUrls() can be invoked 
> from frame applet. There are more patches to come, after this one gets 
> approved.
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 
>   trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 
> 
> Diff: http://svn.reviewboard.kde.org/r/6375/diff
> 
> 
> Testing
> ---
> 
> Tested in trunk and everything is working fine.
> 
> 
> Thanks,
> 
> Sinny
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: where to download plasma-mobile solution for MeeGo?

2011-01-20 Thread Rodrigo Belém 
On Thu, Jan 20, 2011 at 10:46 AM, Marco Martin  wrote:
> On Wednesday 19 January 2011, Rohan Garg wrote:
>> Do meego repos even have those? Im not sure, but theres Kubuntu Mobile that
>
> yes, there is a personal repository made by kde ppl, that's quite ineresting
> since it uses the kdelibs mobile profile and includes koffice/calligra mobile
> as well.
>
>> you can use on a N900, theres also a ubuntu lucid chroot that you can boot
>> on a Android device and then you can install plasma mobile on it :-)
>
> yes, Kubuntu is an option as well, they have an experimental ppa with plasma
> mobile, kdepim trunk with the mobile version as well, built against the kde
> 4.6 rc2 packages.
> last time I checked the plasma mobile packages were quite old, hope they have
> been updated.
>

plasma-mobile packages on Natty, 11.04, is using the latest trunk :-)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: where to download plasma-mobile solution for MeeGo?

2011-01-20 Thread Marco Martin 
On Thursday 20 January 2011, Rodrigo Belém wrote:

> > yes, Kubuntu is an option as well, they have an experimental ppa with
> > plasma mobile, kdepim trunk with the mobile version as well, built
> > against the kde 4.6 rc2 packages.
> > last time I checked the plasma mobile packages were quite old, hope they
> > have been updated.
> 
> plasma-mobile packages on Natty, 11.04, is using the latest trunk :-)

awesome ;)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

QML code style

2011-01-20 Thread Ivan Čukić 
Hi all,

I think this would be essential to decide before we dive into QML deeper.

We're all used to kdelibs style when C++ is concerned, so our code is
generally unified all across different parts of KDE Code. QML is a new
area which nobody (with the exception of Marco and a few other ppl)
has had an experience with, so without some style guidelines, we'll
end up with totally unreadable code.

I've seen some of the pim qml code, and it fails to impress me with
the organisation, not to mention that it is fully undocumented. (I
hope nobody will get offended since this is not meant as a 'slap on
the wrists', but as an example of what is going to happen if we don't
plan ahead).

The things that concern me the most at the moment are names for
properties, for 'items' (id: ) and similar.

The other thing that should be discussed is how the files should be layoutted.

-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML code style

2011-01-20 Thread Marco Martin 
On Thursday 20 January 2011, Ivan Čukić wrote:
> Hi all,
> 
> I think this would be essential to decide before we dive into QML deeper.
> 
> We're all used to kdelibs style when C++ is concerned, so our code is
> generally unified all across different parts of KDE Code. QML is a new
> area which nobody (with the exception of Marco and a few other ppl)
> has had an experience with, so without some style guidelines, we'll
> end up with totally unreadable code.

yup. that's really important indeed, thanks for bringing it up.

qt has a (quite scarce) conventions document
http://doc.qt.nokia.com/4.7/qml-coding-conventions.html
what it says here is generally good, but doesn't say that much.

iirc this was discussed in the QtComponents ml as well some time ago, i don't 
know what the results were, the thread died rather quickly.

Artur, do you know something more about coding conventions used internally for 
QML/QtComponents? if sensible we could just steal, ehm, i mean adopt them ;)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6375/
---

(Updated Jan. 20, 2011, 7:36 p.m.)


Review request for Plasma.


Changes
---

Added API documentation in file trunk/KDE/kdelibs/plasma/wallpaper.h


Summary
---

According to suggestion given by Aaron (refer to mailing list thread 
http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have 
done changes in trunk/KDE/kdelibs/plasma/. I have added functions setUrls(const 
KUrl::List &urls) as public function and addUrls(const KUrl::List &urls) as 
protected Q_SLOTS in it so that setUrls() can be invoked from frame applet. 
There are more patches to come, after this one gets approved.


Diffs (updated)
-

  trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 
  trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 

Diff: http://svn.reviewboard.kde.org/r/6375/diff


Testing
---

Tested in trunk and everything is working fine.


Thanks,

Sinny

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make wallpaper capable of setting particular Image

2011-01-20 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6375/#review9659
---

Ship it!


after last revision is perfect, go for it.

- Marco


On Jan. 20, 2011, 7:36 p.m., Sinny Kumari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6375/
> ---
> 
> (Updated Jan. 20, 2011, 7:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> According to suggestion given by Aaron (refer to mailing list thread 
> http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have 
> done changes in trunk/KDE/kdelibs/plasma/. I have added functions 
> setUrls(const KUrl::List &urls) as public function and addUrls(const 
> KUrl::List &urls) as protected Q_SLOTS in it so that setUrls() can be invoked 
> from frame applet. There are more patches to come, after this one gets 
> approved.
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 
>   trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 
> 
> Diff: http://svn.reviewboard.kde.org/r/6375/diff
> 
> 
> Testing
> ---
> 
> Tested in trunk and everything is working fine.
> 
> 
> Thanks,
> 
> Sinny
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML code style

2011-01-20 Thread Ivan Čukić 
> qt has a (quite scarce) conventions document

Yes, it covers a bit specific stuff where the more important things
are not present.

The thing currently on my mind is the following - if the Qt examples
and the mentioned page are to be followed - we'd end up with something
like this:

property string title

Text {
id: title
}

Which sucks :)

(for the time being, I started naming things like I used to name
widgets in normal UIs - id:textTitle - for Text type, imageIcon for
Image type etc.)

Cheerio.

-- 
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML code style

2011-01-20 Thread Marco Martin 
On Thursday 20 January 2011, Ivan Čukić wrote:
> > qt has a (quite scarce) conventions document
> 
> Yes, it covers a bit specific stuff where the more important things
> are not present.
> 
> The thing currently on my mind is the following - if the Qt examples
> and the mentioned page are to be followed - we'd end up with something
> like this:
> 
> property string title
> 
> Text {
> id: title
> }
> 
> Which sucks :)

agree

> (for the time being, I started naming things like I used to name
> widgets in normal UIs - id:textTitle - for Text type, imageIcon for
> Image type etc.)

I always do the opposite, like iconImage and titleText, otherwise remembers me 
too much of the hungarian form that i never liked (just gut feeling)  ;)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML code style

2011-01-20 Thread Marco Martin 
On Thursday 20 January 2011, Ivan Čukić wrote:
> > qt has a (quite scarce) conventions document
> 
> Yes, it covers a bit specific stuff where the more important things
> are not present.
> 
> The thing currently on my mind is the following - if the Qt examples
> and the mentioned page are to be followed - we'd end up with something
> like this:
> 
> property string title
> 
> Text {
> id: title
> }
> 
> Which sucks :)
> 
> (for the time being, I started naming things like I used to name
> widgets in normal UIs - id:textTitle - for Text type, imageIcon for
> Image type etc.)
> 
> Cheerio.

also, i always wanted to write a style guide for that stuff, from code to UI, 
i guess i should move my lazy ass and do it;)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML code style

2011-01-20 Thread Ivan Čukić 
> I always do the opposite, like iconImage

yes, I've noticed :)

The main reason I do it this way is that I easier remember the field
type than name, so it narrows the completion options :)

-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML code style

2011-01-20 Thread Artur de Souza 

Quoting Marco Martin :
> Artur, do you know something more about coding conventions used  
> internally for
> QML/QtComponents? if sensible we could just steal, ehm, i mean adopt them ;)

In QtComponents we use the links below as a reference:

http://doc.qt.nokia.com/4.7-snapshot/codingconventions.html
https://developer.mozilla.org/En/Developer_Guide/Coding_Style

and I could also find the guidelines below one e-mail:

1. avoid using ';', unless strictly needed (just use it if you are writing
multiple commands on the same line and even in this case avoid the last
semicolon).
target: statusbar; property: "y"

2. avoid writing more than one command on the same line :-), but this is not
strict.
The example below is good, IMO these cases, PropertyChanges and Animation,
can have their properties on one line.
states: State {
  name: 'hidden'
  when:  window.statusbarVisible == false
  PropertyChanges { target: statusbar; y: -statusbar.height }
  }

  transitions: Transition {
  NumberAnimation { target: statusbar; property: "y"; duration: 300;
easing.type: Easing.InOutQuad }
  }

3. use a blank space after and before curly braces (when in the same line)
'{', '}'
MouseArea {
  id: mouseArea
  anchors.fill: parent
  onClicked: { button.clicked() }
  }

4. use 4 spaces for indentation (no tabs)

5. use double quotes for strings: "string" instead of 'string'



I kind of dislike more than one command in the same line and for JS  
stuff I put ";" in every end of line/command (while in QML code we  
avoid them). I can find a link explaining the reason behind ending  
with ";" every JS line if you want.

You are also right that it's going to be very good to setup some  
"naming" guidelines for id's. It can be really a mess if we don't  
follow some guideline.

Ah, something I almost forgot: following some scripting languages,  
properties that we would like to make "private/protected" are declared  
with "__" preprending their names, for example:

property int __protected: 0


Cheers,

Artur

---

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Questions about dataengines and apologizes

2011-01-20 Thread Matthieu Gallien 
Hello dear Plasma folks,

first, I would like to apologize having totally disappeared after having
been the cause of memory leaks in the systray. Real life was plenty full for
me at that time.

I am trying to find something that is sustainable with 1h and half of time
in commuter trains.

This is where I need some advice. I would like to develop a dataengine that
can present group of data sources from some server where you connect through
a custom tcp protocol.
I do not know how to transfer to the dataengine the address and port of a
server that would then be translated into multiple data sources in the
engine.

I believe that some of the current solutions rely on encoding the address in
the name of a requested source.
I am not sure if a service could be used and how.

What are your recommendations ?

PS : by the way, I noticed that there is no techbase tutorial on writing
services in a data engine. If the way it is done in the task engine is
correct, I can try in the following month to make some text, but I will need
a review from somebody.

Best regards and an happy new year to you very lively plasma folks
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Questions about dataengines and apologizes

2011-01-20 Thread Aaron J. Seigo 
On Thursday, January 20, 2011, Matthieu Gallien wrote:
> I believe that some of the current solutions rely on encoding the address
> in the name of a requested source.

it often is, yes.

> I am not sure if a service could be used and how.

you could, yes, by implement serviceForSource and returning a Service object 
from there that is (internally) associated with that source. it could offer 
operations like "connect" with a string for the hostname and an optional int 
for the port. when called, that operation would then set some internal 
properties.

the way i usual recommend doing this is by subclassing DataContainer to do all 
the network stuff and when serviceForSource is called, passing the  
DataContainer subclass object to the Service subclass :) keeps everything 
nicely separated and clear in the code.

you could, of course, do the entire thing as a Service and not use a 
DataEngine at all. it probably quite depends on what sort of communication 
happens with the server; if it's a stateless "make a request, the server 
returns an answer" like http then a plan Service might be more 
straightforward. if there is ongoing communication with the server and/or the 
data ought to be shared between multiple widgets, then a DataEngine probably 
makes more sense.

> PS : by the way, I noticed that there is no techbase tutorial on writing
> services in a data engine. If the way it is done in the task engine is
> correct, I can try in the following month to make some text, but I will
> need a review from somebody.

yes, the task engine is a reasonable example :)

a simple example in kdeexamples/plasma/c++/dataengines/ would be nice, too, if 
you felt like it.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Overrides Plasma::wallpaer method addUrls() to set Image

2011-01-20 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/
---

Review request for Plasma.


Summary
---

 Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will 
override the method defined ( changes that have been made in 
http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to 
set Image. After reviewing it I will implement both changes in Frame Applet :)


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1215563 
  trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1215563 

Diff: http://svn.reviewboard.kde.org/r/6391/diff


Testing
---

Tested in trunk and it works perfectly.


Thanks,

Sinny

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel