Re: Review Request 116633: Change default font settings to Oxygen font

[Aleix Pol Gonzalez]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 
> 
> Martin Gräßlin wrote:
> @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.
> 
> Aleix Pol Gonzalez wrote:
> @Mark: Nobody assures Chrome will be using "Sans Serif" either, this 
> patch doesn't make a difference in this regard...
> 
> Mark Gaiser wrote:
> @Martin, @Aleix; To be clear, I'm not against this change at all. I'm 
> only against the result it will have. Sure, you need to start somewhere. In 
> this case that would be assuring that all applications follow the font 
> settings that are in kde's font settings. How one should tackle that, i don't 
> know. I guess it's possible with a local fonts.conf file.
> 
> @Aleix not a strong argument. GUI interfaces almost always use the 
> default font settings. My exact point is that those defaults _won't_ change 
> for GTK apps with this patch.
> 
> Àlex Fiestas wrote:
> Well supporting gtk app's is as simple as writing the configuration file 
> like or kcm-gtk-style does. If chromium is not reading that and rather using 
> their own config file (which I doubt) then it would be their bug, not ours.
> 
> Also, imho we should ask KDE/PLasma distributions to set this settings by 
> default distro-wise.
> 
> Àlex Fiestas wrote:
> Just to make my point clear, I'm not against this review but I think it 
> should be followed by another one configuring other toolkits fonts :)
> 
> Sebastian Kügler wrote:
> Yes, it makes sense to enforce the font setting also in other places. Our 
> GTK KCM hasn't been ported yet, it seems, but once it is ported, we should 
> definitely make sure it uses the Oxygen font as well (if the Oxygen GTK style 
> doesn't already do so).
> 
> You're listed as maintainer for the frameworksintegration repo, so if you 
> think the code in this review is OK, please hit ship it. :)

The GTK kcm will suggest as a default whatever the QPA suggests, but then you 
have to go in the kcm at least once.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 4:36 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 4:36 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 
> 
> Martin Gräßlin wrote:
> @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.
> 
> Aleix Pol Gonzalez wrote:
> @Mark: Nobody assures Chrome will be using "Sans Serif" either, this 
> patch doesn't make a difference in this regard...
> 
> Mark Gaiser wrote:
> @Martin, @Aleix; To be clear, I'm not against this change at all. I'm 
> only against the result it will have. Sure, you need to start somewhere. In 
> this case that would be assuring that all applications follow the font 
> settings that are in kde's font settings. How one should tackle that, i don't 
> know. I guess it's possible with a local fonts.conf file.
> 
> @Aleix not a strong argument. GUI interfaces almost always use the 
> default font settings. My exact point is that those defaults _won't_ change 
> for GTK apps with this patch.
> 
> Àlex Fiestas wrote:
> Well supporting gtk app's is as simple as writing the configuration file 
> like or kcm-gtk-style does. If chromium is not reading that and rather using 
> their own config file (which I doubt) then it would be their bug, not ours.
> 
> Also, imho we should ask KDE/PLasma distributions to set this settings by 
> default distro-wise.
> 
> Àlex Fiestas wrote:
> Just to make my point clear, I'm not against this review but I think it 
> should be followed by another one configuring other toolkits fonts :)

Yes, it makes sense to enforce the font setting also in other places. Our GTK 
KCM hasn't been ported yet, it seems, but once it is ported, we should 
definitely make sure it uses the Oxygen font as well (if the Oxygen GTK style 
doesn't already do so).

You're listed as maintainer for the frameworksintegration repo, so if you think 
the code in this review is OK, please hit ship it. :)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 4:36 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 4:36 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116640: Fix for "Bug 331798 - Wrong media shown as current media in playlist after reordering"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116640/
---

Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Bugs: 331798
http://bugs.kde.org/show_bug.cgi?id=331798


Repository: plasma-mediacenter


Description
---

Patch for Bug 331798 : Playlist shows the wrong song as "now playing" (in red 
color) in some cases of reordering the playlist.


Diffs
-

  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
  mediaelements/playlist/PlaylistDelegateLogic.js e69de29 

Diff: https://git.reviewboard.kde.org/r/116640/diff/


Testing
---

1.Moved a song with index less than the currently playing media to some place 
below the currently playing media.
2.Moved a song with index greater than the currently playing media to some 
place above the currently playing media.
3.Moved the currently playing media to various places in the playlist.

In all the cases correct song is now showed as Now Playing i.e in "red" color.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52286
---


This review has been submitted with commit 
67032817d71905261d94a2c9775f033eb62863b1 by Shantanu Tushar to branch master.

- Commit Hook


On March 6, 2014, 4:17 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 4:17 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

(Updated March 6, 2014, 5:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52285
---

Ship it!


Ship It!

- Shantanu Tushar


On March 6, 2014, 4:17 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 4:17 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Àlex Fiestas]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 
> 
> Martin Gräßlin wrote:
> @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.
> 
> Aleix Pol Gonzalez wrote:
> @Mark: Nobody assures Chrome will be using "Sans Serif" either, this 
> patch doesn't make a difference in this regard...
> 
> Mark Gaiser wrote:
> @Martin, @Aleix; To be clear, I'm not against this change at all. I'm 
> only against the result it will have. Sure, you need to start somewhere. In 
> this case that would be assuring that all applications follow the font 
> settings that are in kde's font settings. How one should tackle that, i don't 
> know. I guess it's possible with a local fonts.conf file.
> 
> @Aleix not a strong argument. GUI interfaces almost always use the 
> default font settings. My exact point is that those defaults _won't_ change 
> for GTK apps with this patch.
> 
> Àlex Fiestas wrote:
> Well supporting gtk app's is as simple as writing the configuration file 
> like or kcm-gtk-style does. If chromium is not reading that and rather using 
> their own config file (which I doubt) then it would be their bug, not ours.
> 
> Also, imho we should ask KDE/PLasma distributions to set this settings by 
> default distro-wise.

Just to make my point clear, I'm not against this review but I think it should 
be followed by another one configuring other toolkits fonts :)


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 4:36 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 4:36 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Àlex Fiestas]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 
> 
> Martin Gräßlin wrote:
> @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.
> 
> Aleix Pol Gonzalez wrote:
> @Mark: Nobody assures Chrome will be using "Sans Serif" either, this 
> patch doesn't make a difference in this regard...
> 
> Mark Gaiser wrote:
> @Martin, @Aleix; To be clear, I'm not against this change at all. I'm 
> only against the result it will have. Sure, you need to start somewhere. In 
> this case that would be assuring that all applications follow the font 
> settings that are in kde's font settings. How one should tackle that, i don't 
> know. I guess it's possible with a local fonts.conf file.
> 
> @Aleix not a strong argument. GUI interfaces almost always use the 
> default font settings. My exact point is that those defaults _won't_ change 
> for GTK apps with this patch.

Well supporting gtk app's is as simple as writing the configuration file like 
or kcm-gtk-style does. If chromium is not reading that and rather using their 
own config file (which I doubt) then it would be their bug, not ours.

Also, imho we should ask KDE/PLasma distributions to set this settings by 
default distro-wise.


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 4:36 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 4:36 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

On Thursday, March 06, 2014 15:45:23 Mark Gaiser wrote:
> @Aleix not a strong argument. GUI interfaces almost always use the default
> font settings. My exact point is that those defaults _won't_ change for GTK
> apps with this patch.

It does for GTK Apps using the Oxygen style, and it also can be picked up this 
way by the GTK integration module, so your assessment is only partly true.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/
---

(Updated March 6, 2014, 4:36 p.m.)


Review request for Plasma and Àlex Fiestas.


Changes
---

Additional metadata has moved to OxygenFontConfig.cmake.


Repository: frameworkintegration


Description
---

Change default font settings to Oxygen font


Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called 
OxygenFontConfig.cmake, which is used for checking the dependency is available.


Diffs (updated)
-

  CMakeLists.txt e249554 
  src/platformtheme/kfontsettingsdata.cpp 62990ce 

Diff: https://git.reviewboard.kde.org/r/116633/diff/


Testing
---

Started kate without a kdeglobals file being present, fonts are picked up 
correctly.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

> On March 6, 2014, 4:22 p.m., Martin Gräßlin wrote:
> > > will push that once this patch is through review
> > 
> > shouldn't it be the other way around? How would anyone be able to compile 
> > test your review without those files in the oxygen fonts repo?

Right. I've pushed it to oxygen-fonts.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52276
---


On March 6, 2014, 3:49 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 3:49 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52278
---


modulo the small issue below +1 from my side


CMakeLists.txt


DESCRIPTION and URL should go into the set_package_properties in the 
Config.cmake - at least I have been told so in other reviews ;-)


- Martin Gräßlin


On March 6, 2014, 4:49 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 4:49 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52276
---


> will push that once this patch is through review

shouldn't it be the other way around? How would anyone be able to compile test 
your review without those files in the oxygen fonts repo?

- Martin Gräßlin


On March 6, 2014, 4:49 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 4:49 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

(Updated March 6, 2014, 4:17 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Changes
---

Made the code compact (1 line) as Shantanu suggested.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs (updated)
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/
---

(Updated March 6, 2014, 3:49 p.m.)


Review request for Plasma and Àlex Fiestas.


Changes
---

Now with CMake magic to make it a RUNTIME dependency.

I've added the necessary OxygenFontConfig.cmake and 
OxygenFontConfigVersion.cmake in the oxygen-fonts repository, will push that 
once this patch is through review.


Repository: frameworkintegration


Description
---

Change default font settings to Oxygen font


Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called 
OxygenFontConfig.cmake, which is used for checking the dependency is available.


Diffs (updated)
-

  CMakeLists.txt e249554 
  src/platformtheme/kfontsettingsdata.cpp 62990ce 

Diff: https://git.reviewboard.kde.org/r/116633/diff/


Testing
---

Started kate without a kdeglobals file being present, fonts are picked up 
correctly.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Mark Gaiser]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 
> 
> Martin Gräßlin wrote:
> @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.
> 
> Aleix Pol Gonzalez wrote:
> @Mark: Nobody assures Chrome will be using "Sans Serif" either, this 
> patch doesn't make a difference in this regard...

@Martin, @Aleix; To be clear, I'm not against this change at all. I'm only 
against the result it will have. Sure, you need to start somewhere. In this 
case that would be assuring that all applications follow the font settings that 
are in kde's font settings. How one should tackle that, i don't know. I guess 
it's possible with a local fonts.conf file.

@Aleix not a strong argument. GUI interfaces almost always use the default font 
settings. My exact point is that those defaults _won't_ change for GTK apps 
with this patch.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 3:40 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 3:40 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/
---

(Updated March 6, 2014, 3:40 p.m.)


Review request for Plasma and Àlex Fiestas.


Changes
---

Also take Monospace into account.


Repository: frameworkintegration


Description
---

Change default font settings to Oxygen font


Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called 
OxygenFontConfig.cmake, which is used for checking the dependency is available.


Diffs (updated)
-

  CMakeLists.txt e249554 
  src/platformtheme/kfontsettingsdata.cpp 62990ce 

Diff: https://git.reviewboard.kde.org/r/116633/diff/


Testing
---

Started kate without a kdeglobals file being present, fonts are picked up 
correctly.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Aleix Pol Gonzalez]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 
> 
> Martin Gräßlin wrote:
> @Mark: well it's orthogonal to this change. We need to start somewhere 
> the transition. If we block the first patch because it introduces 
> inconsistancies, we will never be able to adress it. Thus I think it's the 
> right approach to start with the what we have control over.

@Mark: Nobody assures Chrome will be using "Sans Serif" either, this patch 
doesn't make a difference in this regard...


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 1:28 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Martin Gräßlin]

> On March 6, 2014, 2:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.
> 
> Mark Gaiser wrote:
> Well, if this patch gives the user a broken consistency (Chrome is being 
> used by lots of people, including KDE folks) then i think it might be best to 
> keep the defaults consistent and keep it at sans-serif.
> 
> That would at least keep the default consistent.
> Another approach might be (don't know if that's done already) to generate 
> a local user font.conf which changes the default sans-serif font to whatever 
> font is set in KDE's font settings.
> 
> Note: Chrome is just a sane example here. Others would be gparted, 
> firefox, 

@Mark: well it's orthogonal to this change. We need to start somewhere the 
transition. If we block the first patch because it introduces inconsistancies, 
we will never be able to adress it. Thus I think it's the right approach to 
start with the what we have control over.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 2:28 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 2:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Shantanu Tushar]

> On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote:
> > After going to playlist like this, if you press back you get a blank screen 
> > with Loading spinner. Expected is the homescreen to come back.
> 
> Ashish Madeti wrote:
> 1.Start PMC
> 2.Click on empty area (playlist shows)
> 3.Click back.
> I am getting homescreen only after step 3.
> Am I missing something here ?
> 
> Shantanu Tushar wrote:
> Hmm I tried your patch again and I still get the empty screen. It might 
> be local to me, you should wait for someone else to confirm this works.

Ok this was not due to your patch, it was an unrelated bug that I have now 
fixed. So your patch works fine now.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52266
---



shells/newshell/package/contents/ui/mediacenter.qml


You can do it like this-
pmcPageStack.pushAndFocus(mediaPlayerInstance ? getMediaPlayer() : 
getPlaylist())

and then you won't even need braces in onEmptyAreaClicked


- Shantanu Tushar


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Ashish Madeti]

> On March 6, 2014, 2:23 p.m., Shantanu Tushar wrote:
> > I have merged this to master. Please note, please fill the bug field in 
> > reviewboard from the next time when you're fixing a bug.

I will definitely keep that in mind from next time. Thank you very much for 
helping me in fixing the bug.


- Ashish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/#review52261
---


On March 6, 2014, 2:22 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116596/
> ---
> 
> (Updated March 6, 2014, 2:22 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Before this patch it was not possible to delete media (only using mouse) from 
> a playlist without playing the media, as reported in Bug 329168 : 
> https://bugs.kde.org/show_bug.cgi?id=329168
> 
> Now not only can you delete the media without playing it, it is easier to 
> navigate the playlist then before.
> 
> 
> Diffs
> -
> 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
>   mediaelements/playlist/Playlist.qml fd83c21 
> 
> Diff: https://git.reviewboard.kde.org/r/116596/diff/
> 
> 
> Testing
> ---
> 
> 1.Deleted a song from a playlist without playing it.
> 2.Traversed the playlist without using keyboard or mouse scroll button.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52265
---



CMakeLists.txt


you can just mark it as a runtime dependancy (so the build doesn't fail w/o 
oxygen font.



src/platformtheme/kfontsettingsdata.cpp


r116625 got also monospace variant changed, right?


- Hrvoje Senjan


On March 6, 2014, 1:28 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Mark Gaiser]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)
> 
> Sebastian Kügler wrote:
> They won't pick up the font. Nothing we can do about that in Plasma. 
> Needs the distro or the Chrome developers to do it. The Oxygen Widget style 
> for GTK could probably pick it up, though.
> 
> This is unrelated to this patch, however.

Well, if this patch gives the user a broken consistency (Chrome is being used 
by lots of people, including KDE folks) then i think it might be best to keep 
the defaults consistent and keep it at sans-serif.

That would at least keep the default consistent.
Another approach might be (don't know if that's done already) to generate a 
local user font.conf which changes the default sans-serif font to whatever font 
is set in KDE's font settings.

Note: Chrome is just a sane example here. Others would be gparted, firefox, 



- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 1:28 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/#review52261
---

Ship it!


I have merged this to master. Please note, please fill the bug field in 
reviewboard from the next time when you're fixing a bug.

- Shantanu Tushar


On March 6, 2014, 2:22 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116596/
> ---
> 
> (Updated March 6, 2014, 2:22 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Before this patch it was not possible to delete media (only using mouse) from 
> a playlist without playing the media, as reported in Bug 329168 : 
> https://bugs.kde.org/show_bug.cgi?id=329168
> 
> Now not only can you delete the media without playing it, it is easier to 
> navigate the playlist then before.
> 
> 
> Diffs
> -
> 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
>   mediaelements/playlist/Playlist.qml fd83c21 
> 
> Diff: https://git.reviewboard.kde.org/r/116596/diff/
> 
> 
> Testing
> ---
> 
> 1.Deleted a song from a playlist without playing it.
> 2.Traversed the playlist without using keyboard or mouse scroll button.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/
---

(Updated March 6, 2014, 2:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Before this patch it was not possible to delete media (only using mouse) from a 
playlist without playing the media, as reported in Bug 329168 : 
https://bugs.kde.org/show_bug.cgi?id=329168

Now not only can you delete the media without playing it, it is easier to 
navigate the playlist then before.


Diffs
-

  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
  mediaelements/playlist/Playlist.qml fd83c21 

Diff: https://git.reviewboard.kde.org/r/116596/diff/


Testing
---

1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/#review52260
---


This review has been submitted with commit 
946cea2996ca42f7bad5693f3d07e0aef274670e by Shantanu Tushar to branch master.

- Commit Hook


On March 5, 2014, 6:15 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116596/
> ---
> 
> (Updated March 5, 2014, 6:15 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Before this patch it was not possible to delete media (only using mouse) from 
> a playlist without playing the media, as reported in Bug 329168 : 
> https://bugs.kde.org/show_bug.cgi?id=329168
> 
> Now not only can you delete the media without playing it, it is easier to 
> navigate the playlist then before.
> 
> 
> Diffs
> -
> 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
>   mediaelements/playlist/Playlist.qml fd83c21 
> 
> Diff: https://git.reviewboard.kde.org/r/116596/diff/
> 
> 
> Testing
> ---
> 
> 1.Deleted a song from a playlist without playing it.
> 2.Traversed the playlist without using keyboard or mouse scroll button.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116626/
---

(Updated March 6, 2014, 2:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Repository: plasma-mediacenter


Description
---

Playlist reordering used to work only in one direction i.e you could only drag 
a media to somewhere below it's current index. After this patch it will work 
both ways.


Diffs
-

  libs/mediacenter/playlistmodel.cpp 9c1dea9 

Diff: https://git.reviewboard.kde.org/r/116626/diff/


Testing
---

Reordered a playlist both ways.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116626/#review52258
---


This review has been submitted with commit 
86f20ec9a746efb0add1de56e44bc5064de45a53 by Shantanu Tushar to branch master.

- Commit Hook


On March 6, 2014, 6:26 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116626/
> ---
> 
> (Updated March 6, 2014, 6:26 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist reordering used to work only in one direction i.e you could only 
> drag a media to somewhere below it's current index. After this patch it will 
> work both ways.
> 
> 
> Diffs
> -
> 
>   libs/mediacenter/playlistmodel.cpp 9c1dea9 
> 
> Diff: https://git.reviewboard.kde.org/r/116626/diff/
> 
> 
> Testing
> ---
> 
> Reordered a playlist both ways.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Oxygen as default font

[Sebastian Kügler]

On Thursday, March 06, 2014 06:23:59 Rex Dieter wrote:
> > On Wednesday, March 05, 2014 13:34:36 Jonathan Riddell wrote:
> >> it may be easiest to just release oxygen font separately and have it
> >> as a build depends of kde-runtime, that way people who install
> >> kde-runtime into something other than /usr can just install the
> >> package.
> >
> > 
> >
> > It doesn't solve the problem, though. People will still need to install
> > the oxygen font, either from package or from "source" using cmake. How
> > it's split at packaging level doesn't change this. (I've actually
> > considered your suggestion already, but found that it doesn't actually
> > solve the problem for me.)
> 
> As a packager, I support the suggestion to release oxygen-fonts
> separately.   Some distros (like mine) will require the packaging of the
> font to be done separately anyway, and releasing it like that will lend
> convenience.

I'm doing that just now. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Next alpha release engineering bits

[Sebastian Kügler]

On Thursday, March 06, 2014 15:12:32 Jos Poortvliet wrote:
> On Thursday 06 March 2014 11:32:03 Sebastian Kügler wrote:
> > On Thursday, March 06, 2014 10:49:21 Jos Poortvliet wrote:
> > > On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote:
> > > 
> > >
> > > You want the same as for the Frameworks alpha's? As in, very plain and
> > > simple  as we did the 'noise' in the earlier Tech Preview article:
> > > http://dot.kde.org/2014/03/04/kde-frameworks-5-alpha-two-out
> > >
> > > 
> > >
> > > If so, I'd be happy to take care of it.
> >
> > 
> >
> > That would totally rock. I can help with nice material to go along with
> > it,
> > and the text of course.
> 
> If you braindump to me the major changes since the tech preview and have a 
> picture or two, I'll do the rest.
> 
> What's the date?

Tagging next Thursday, hopefully pretty quickly then the Alpha release (as 
packages pass smoke testing). I'll be travelling starting on Thursday, so how 
about we chat about it on, say, Monday, if that fits  yourschedule?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116626/#review52257
---

Ship it!


Ship It!

- Shantanu Tushar


On March 6, 2014, 6:26 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116626/
> ---
> 
> (Updated March 6, 2014, 6:26 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist reordering used to work only in one direction i.e you could only 
> drag a media to somewhere below it's current index. After this patch it will 
> work both ways.
> 
> 
> Diffs
> -
> 
>   libs/mediacenter/playlistmodel.cpp 9c1dea9 
> 
> Diff: https://git.reviewboard.kde.org/r/116626/diff/
> 
> 
> Testing
> ---
> 
> Reordered a playlist both ways.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote:
> > How will this work with other non KDE apps (like Chrome), will they simply 
> > pickup the Oxygen font?
> > 
> > I'm asking because fonts are working just fine now. If i open a GTK app in 
> > KDE it shows the fonts in the same manner as a KDE app would show them. 
> > That is consistent and quite likable :)

They won't pick up the font. Nothing we can do about that in Plasma. Needs the 
distro or the Chrome developers to do it. The Oxygen Widget style for GTK could 
probably pick it up, though.

This is unrelated to this patch, however.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


On March 6, 2014, 1:28 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Next alpha release engineering bits

[Jos Poortvliet]

On Thursday 06 March 2014 11:32:03 Sebastian Kügler wrote:
> On Thursday, March 06, 2014 10:49:21 Jos Poortvliet wrote:
> > On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote:
> > > As we're planning to release the first alpha of Plasma Next next week,
> > > I'd
> > > like to go over some details that need discussing.
> > > 
> > > - promo preparations
> > 
> > You want the same as for the Frameworks alpha's? As in, very plain and
> > simple  as we did the 'noise' in the earlier Tech Preview article:
> > http://dot.kde.org/2014/03/04/kde-frameworks-5-alpha-two-out
> > 
> > If so, I'd be happy to take care of it.
> 
> That would totally rock. I can help with nice material to go along with it,
> and the text of course.

If you braindump to me the major changes since the tech preview and have a 
picture or two, I'll do the rest.

What's the date?

> Cheers,


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52255
---


How will this work with other non KDE apps (like Chrome), will they simply 
pickup the Oxygen font?

I'm asking because fonts are working just fine now. If i open a GTK app in KDE 
it shows the fonts in the same manner as a KDE app would show them. That is 
consistent and quite likable :)

- Mark Gaiser


On March 6, 2014, 1:28 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> ---
> 
> (Updated March 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
>   src/platformtheme/kfontsettingsdata.cpp 
> 62990ce45c1a175c3b57710c8a38268d08908733 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> ---
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Oxygen as default font

[Rex Dieter]

Sebastian Kügler wrote:

> On Wednesday, March 05, 2014 13:34:36 Jonathan Riddell wrote:

>> it may be easiest to just release oxygen font separately and have it
>> as a build depends of kde-runtime, that way people who install
>> kde-runtime into something other than /usr can just install the
>> package.
> 
> It doesn't solve the problem, though. People will still need to install
> the oxygen font, either from package or from "source" using cmake. How
> it's split at packaging level doesn't change this. (I've actually
> considered your suggestion already, but found that it doesn't actually
> solve the problem for me.)

As a packager, I support the suggestion to release oxygen-fonts separately.  
Some distros (like mine) will require the packaging of the font to be done 
separately anyway, and releasing it like that will lend convenience.

-- Rex

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116633: Change default font settings to Oxygen font

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/
---

Review request for Plasma and Àlex Fiestas.


Repository: frameworkintegration


Description
---

Change default font settings to Oxygen font


Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file called 
OxygenFontConfig.cmake, which is used for checking the dependency is available.


Diffs
-

  CMakeLists.txt e24955420515ff980f9a0a07ff84ab71ec0f032c 
  src/platformtheme/kfontsettingsdata.cpp 
62990ce45c1a175c3b57710c8a38268d08908733 

Diff: https://git.reviewboard.kde.org/r/116633/diff/


Testing
---

Started kate without a kdeglobals file being present, fonts are picked up 
correctly.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116625: Oxygen as default font

[Aleix Pol Gonzalez]

> On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote:
> > Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no?
> > 
> > OTOH, I would say it's fine installing the font from frameworks 
> > integration, although it makes little difference since frameworks 
> > integration will be offering whatever has been put in the configs.
> 
> Sebastian Kügler wrote:
> There are sources for the font (in the oxygen-fonts package), but to my 
> knowledge, the preferred format for fonts is actually ttf.
> 
> This would also be hardcoded as default in the config reading.
> 
> Martin Gräßlin wrote:
> > There are sources for the font (in the oxygen-fonts package), but to my 
> knowledge, the preferred format for fonts is actually ttf.
> 
> That's why I suggested to fix the oxygen-font package and runtime depend 
> through CMake. I really don't want us to include binaries in kde-workspace.

+1 to what martin said. We need to figure out how we're going to specify the 
workspaces' dependencies anyway.

You can add it to the kde-workspaces wiki [1] so we don't forget.

[1] http://community.kde.org/Plasma/Tokamak7/split_proposal


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review52240
---


On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> ---
> 
> (Updated March 6, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Make Oxygen the default font
> 
> This has three portions: the fonts itself, installation of them including 
> fontconfig bits, and setting font defaults in kdeglobals.
> 
> Oxygen Font 0.4 Imported from oxygen-font repository.
> 
> The startkde portion contains the bits to write out a kdeglobals default 
> file if it doesn't exist with font settings applied. Usually, with install 
> prefix set to /usr, the installed oxygen font is found automatically by 
> fontconfig. If we're installed to a different prefix, we need to point 
> fontconfig at the font. We do that by linking it from either 
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
>   fonts/CMakeLists.txt PRE-CREATION 
>   fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
>   fonts/oxygen/GPL.txt PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
>   fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
>   fonts/oxygen/README PRE-CREATION 
>   startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 
> 
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
> 
> 
> Testing
> ---
> 
> Logged into session with clean config. Font settings are applied correctly 
> throughout.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116625: Oxygen as default font

[Martin Gräßlin]

> On March 6, 2014, 12:34 p.m., Aleix Pol Gonzalez wrote:
> > Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no?
> > 
> > OTOH, I would say it's fine installing the font from frameworks 
> > integration, although it makes little difference since frameworks 
> > integration will be offering whatever has been put in the configs.
> 
> Sebastian Kügler wrote:
> There are sources for the font (in the oxygen-fonts package), but to my 
> knowledge, the preferred format for fonts is actually ttf.
> 
> This would also be hardcoded as default in the config reading.

> There are sources for the font (in the oxygen-fonts package), but to my 
> knowledge, the preferred format for fonts is actually ttf.

That's why I suggested to fix the oxygen-font package and runtime depend 
through CMake. I really don't want us to include binaries in kde-workspace.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review52240
---


On March 6, 2014, 11:29 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> ---
> 
> (Updated March 6, 2014, 11:29 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Make Oxygen the default font
> 
> This has three portions: the fonts itself, installation of them including 
> fontconfig bits, and setting font defaults in kdeglobals.
> 
> Oxygen Font 0.4 Imported from oxygen-font repository.
> 
> The startkde portion contains the bits to write out a kdeglobals default 
> file if it doesn't exist with font settings applied. Usually, with install 
> prefix set to /usr, the installed oxygen font is found automatically by 
> fontconfig. If we're installed to a different prefix, we need to point 
> fontconfig at the font. We do that by linking it from either 
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
>   fonts/CMakeLists.txt PRE-CREATION 
>   fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
>   fonts/oxygen/GPL.txt PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
>   fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
>   fonts/oxygen/README PRE-CREATION 
>   startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 
> 
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
> 
> 
> Testing
> ---
> 
> Logged into session with clean config. Font settings are applied correctly 
> throughout.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116625: Oxygen as default font

[Sebastian Kügler]

> On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote:
> > Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no?
> > 
> > OTOH, I would say it's fine installing the font from frameworks 
> > integration, although it makes little difference since frameworks 
> > integration will be offering whatever has been put in the configs.

There are sources for the font (in the oxygen-fonts package), but to my 
knowledge, the preferred format for fonts is actually ttf.

This would also be hardcoded as default in the config reading.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review52240
---


On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> ---
> 
> (Updated March 6, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Make Oxygen the default font
> 
> This has three portions: the fonts itself, installation of them including 
> fontconfig bits, and setting font defaults in kdeglobals.
> 
> Oxygen Font 0.4 Imported from oxygen-font repository.
> 
> The startkde portion contains the bits to write out a kdeglobals default 
> file if it doesn't exist with font settings applied. Usually, with install 
> prefix set to /usr, the installed oxygen font is found automatically by 
> fontconfig. If we're installed to a different prefix, we need to point 
> fontconfig at the font. We do that by linking it from either 
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
>   fonts/CMakeLists.txt PRE-CREATION 
>   fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
>   fonts/oxygen/GPL.txt PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
>   fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
>   fonts/oxygen/README PRE-CREATION 
>   startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 
> 
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
> 
> 
> Testing
> ---
> 
> Logged into session with clean config. Font settings are applied correctly 
> throughout.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116625: Oxygen as default font

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review52240
---


Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no?

OTOH, I would say it's fine installing the font from frameworks integration, 
although it makes little difference since frameworks integration will be 
offering whatever has been put in the configs.

- Aleix Pol Gonzalez


On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> ---
> 
> (Updated March 6, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Make Oxygen the default font
> 
> This has three portions: the fonts itself, installation of them including 
> fontconfig bits, and setting font defaults in kdeglobals.
> 
> Oxygen Font 0.4 Imported from oxygen-font repository.
> 
> The startkde portion contains the bits to write out a kdeglobals default 
> file if it doesn't exist with font settings applied. Usually, with install 
> prefix set to /usr, the installed oxygen font is found automatically by 
> fontconfig. If we're installed to a different prefix, we need to point 
> fontconfig at the font. We do that by linking it from either 
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
>   fonts/CMakeLists.txt PRE-CREATION 
>   fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
>   fonts/oxygen/GPL.txt PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
>   fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
>   fonts/oxygen/README PRE-CREATION 
>   startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 
> 
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
> 
> 
> Testing
> ---
> 
> Logged into session with clean config. Font settings are applied correctly 
> throughout.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Shantanu Tushar]

> On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote:
> > After going to playlist like this, if you press back you get a blank screen 
> > with Loading spinner. Expected is the homescreen to come back.
> 
> Ashish Madeti wrote:
> 1.Start PMC
> 2.Click on empty area (playlist shows)
> 3.Click back.
> I am getting homescreen only after step 3.
> Am I missing something here ?

Hmm I tried your patch again and I still get the empty screen. It might be 
local to me, you should wait for someone else to confirm this works.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Next alpha release engineering bits

[Sebastian Kügler]

On Thursday, March 06, 2014 10:49:21 Jos Poortvliet wrote:
> On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote:

> > As we're planning to release the first alpha of Plasma Next next week, I'd
> > like to go over some details that need discussing.
> >
> > - promo preparations
> 
> You want the same as for the Frameworks alpha's? As in, very plain and
> simple  as we did the 'noise' in the earlier Tech Preview article:
> http://dot.kde.org/2014/03/04/kde-frameworks-5-alpha-two-out
> 
> If so, I'd be happy to take care of it.

That would totally rock. I can help with nice material to go along with it, 
and the text of course.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116625: Oxygen as default font

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/
---

(Updated March 6, 2014, 10:29 a.m.)


Review request for Plasma and Àlex Fiestas.


Repository: kde-workspace


Description
---

Make Oxygen the default font

This has three portions: the fonts itself, installation of them including 
fontconfig bits, and setting font defaults in kdeglobals.

Oxygen Font 0.4 Imported from oxygen-font repository.

The startkde portion contains the bits to write out a kdeglobals default 
file if it doesn't exist with font settings applied. Usually, with install 
prefix set to /usr, the installed oxygen font is found automatically by 
fontconfig. If we're installed to a different prefix, we need to point 
fontconfig at the font. We do that by linking it from either 
XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
irrelevant for systems that install into /usr.


Diffs
-

  CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
  fonts/CMakeLists.txt PRE-CREATION 
  fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
  fonts/oxygen/GPL.txt PRE-CREATION 
  fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
  fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
  fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
  fonts/oxygen/README PRE-CREATION 
  startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 

Diff: https://git.reviewboard.kde.org/r/116625/diff/


Testing
---

Logged into session with clean config. Font settings are applied correctly 
throughout.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116625: Oxygen as default font

[Sebastian Kügler]

> On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote:
> > startkde.cmake, line 76
> > 
> >
> > Why not just change the defaults in frameworkintegration instead of 
> > writing directly into users settings?
> 
> Martin Gräßlin wrote:
> I also don't like that this seems to be at least parsed with every 
> startup. If it needs to go through our startup and cannot be done in 
> frameworkintegration I think it should be a kconf update script.

You mean the parsing of kdeglobals on startup of apps?

That would mean frameworkintegration depends on oxygen-font. I'm not sure 
that's an acceptable dependency, and I'd like to know for sure that that 
approach is acceptable before implementing it. CC:ing Alex Fiestas as the 
maintainer of that.

Alex would you be OK with a runtime dependency on Oxygen font in 
frameworkintegration?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review52219
---


On March 6, 2014, 1:08 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> ---
> 
> (Updated March 6, 2014, 1:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Make Oxygen the default font
> 
> This has three portions: the fonts itself, installation of them including 
> fontconfig bits, and setting font defaults in kdeglobals.
> 
> Oxygen Font 0.4 Imported from oxygen-font repository.
> 
> The startkde portion contains the bits to write out a kdeglobals default 
> file if it doesn't exist with font settings applied. Usually, with install 
> prefix set to /usr, the installed oxygen font is found automatically by 
> fontconfig. If we're installed to a different prefix, we need to point 
> fontconfig at the font. We do that by linking it from either 
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
>   fonts/CMakeLists.txt PRE-CREATION 
>   fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
>   fonts/oxygen/GPL.txt PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
>   fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
>   fonts/oxygen/README PRE-CREATION 
>   startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 
> 
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
> 
> 
> Testing
> ---
> 
> Logged into session with clean config. Font settings are applied correctly 
> throughout.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52234
---


Sorry but I don't think this is better solution. Not every time I want to go at 
playlist, sometimes we can click in empty area by mistake. So IMHO good 
solution will be button which says Go to Playlist or something like that. May 
be something like toolbox in Plasma at corner which points to the Playlist?

- Bhushan Shah


On March 6, 2014, 10:50 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 10:50 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Next alpha release engineering bits

[Jos Poortvliet]

On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote:
> Hi,
> 
> As we're planning to release the first alpha of Plasma Next next week, I'd
> like to go over some details that need discussing.
> 
> - promo preparations

You want the same as for the Frameworks alpha's? As in, very plain and simple 
as we did the 'noise' in the earlier Tech Preview article:
http://dot.kde.org/2014/03/04/kde-frameworks-5-alpha-two-out

If so, I'd be happy to take care of it.

/J

> - tagging / tarballing: can happen anytime on Thursday next week
> - smoke-testing of packages
> - rolling out packages on Monday, or sooner depending on testing?
> 
> We'll need someone to roll the tarballs and put them on the download site.
> Who is willing to help here?
> 
> Affected repositories:
> 
> - plasma-framework
> - kde-workspace
> - kde-runtime
> - kwin-compositing-kcm
> 
> Am I missing something, perhaps the wallpapers? We have some bits in kde-
> baseapps that could be useful, should we include that as well (as sort of
> limited tarball)?
> 
> This means: don't make changes to frameworks other than plasma-framework
> that are required, we'll not be able to include them in the Alpha.
> 
> It also means that if you have invasive changes, get them in NOW, we need
> some time to stabilize them.
> 
> Cheers,


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-community] KDE Books

[Mirko Boehm]

Hello, 

I am still figuring out whether or not I can attend. If I can, I am very happy 
to take part in a book sprint. It is a great idea. 

Cheers, 

Mirko.

On 05 Mar 2014, at 06:57, Valorie Zimmerman  wrote:

> Hi folks, some months ago Mario Fux spoke to me about heading up a
> book sprint at the Randa meeting this summer [1]. Some of you might be
> aware of the KDE Developer book which we wrote a couple of years ago
> at a book sprint hosted by Google.
> 
> You can read it or download it as a PDF or ebook here:
> http://flossmanuals.net/kde-guide/
> 
> We'll be updating that book, but we'd like to produce a new book if
> any teams in KDE feel that would be useful. Of course, if your team
> wants a book, you will be writing it! With our help, of course.
> 
> I've addressed some lists which might be interested in writing and
> using such a book; feel free to forward it to others who might be
> interested.
> 
> Please speak up soon, so we can begin to make sure that all necessary
> resources will be available that week.

-- 
Mirko Boehm | mi...@kde.org | KDE e.V.
FSFE Fellow, FSFE Team Germany
Qt Certified Specialist

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116627: EGL/X11 backend for WindowThumbnail QQuickItem

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116627/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

EGL/X11 backend for WindowThumbnail QQuickItem

Introduces a new optional dependency to EGL. If EGL is found the
WindowThumbnail gets compiled with EGL support. The EGL support is
unlike Qt's XCB plugin not mutual exclusive to the GLX backend, thus
it's possible to compile with EGL and GLX at the same time.
By that this implementation is prepared for the case that Qt supports
EGL or GLX through runtime selection.

In practice EGL support is only useful if Qt is compiled with GLESv2.
In that case the corebindingsplugin gets linked against Qt5::Gui_GLESv2
to get the dependency to GLES.

The implementation makes use of the EGL_KHR_image extension
(or EGL_KHR_image_base and EGL_KHR_Image_pixmap) and
the GL_OES_EGL_image extension to bind the X pixmap to an EGLImageKHR.


Diffs
-

  CMakeLists.txt 357aaa9bc2faa88b9d0a61cf0cc9ac9e71ededbe 
  src/declarativeimports/core/CMakeLists.txt 
97e9283030e3b3771433381422fcfd809a53239a 
  src/declarativeimports/core/windowthumbnail.h 
1d45953938326e9cba5c1365d8c4b3df7a840e71 
  src/declarativeimports/core/windowthumbnail.cpp 
b96d939b2384ea245e190a401c427f0c21112994 
  src/plasma/config-plasma.h.cmake c1aa75db71892ff6e5043129cdef27740e562f0e 

Diff: https://git.reviewboard.kde.org/r/116627/diff/


Testing
---

plasmoidviewer -a org.kde.example.windowthumbnails in a GLES build.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Ashish Madeti]

> On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote:
> > After going to playlist like this, if you press back you get a blank screen 
> > with Loading spinner. Expected is the homescreen to come back.

1.Start PMC
2.Click on empty area (playlist shows)
3.Click back.
I am getting homescreen only after step 3.
Am I missing something here ?


- Ashish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


After going to playlist like this, if you press back you get a blank screen 
with Loading spinner. Expected is the homescreen to come back.

- Shantanu Tushar


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel