Re: Review Request 122745: Monitor baloo for new media files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/#review76752 --- Ship it! Ship It! - Shantanu Tushar On Feb. 27, 2015, 4:47 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/ --- (Updated Feb. 27, 2015, 4:47 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Vishesh Handa. Repository: plasma-mediacenter Description --- This is uses the dbus signal provided by baloo, checks them mimetype of that file and passes that to related searchresulthandler Bonus point of this is in case properties of any files changes we also get updates. Diffs - mediasources/baloosearch/CMakeLists.txt 9bec5fd6c5af585b8faa53d5440878bf0dcf6566 mediasources/baloosearch/audiosearchresulthandler.h 3efb4bf1efc337a0a293bc1c391707302a76172c mediasources/baloosearch/audiosearchresulthandler.cpp 0c9d93b1988af62836f9c547707395810da311a2 mediasources/baloosearch/baloosearchmediasource.h e0289026e2cbf9c7e145f66b057b7ae6287b8e48 mediasources/baloosearch/baloosearchmediasource.cpp b90e9c03e352d1fd6962fbb28de9b8714e866fde mediasources/baloosearch/imagesearchresulthandler.h 72a2cb30617b91b92e9176688e21d63504876eb1 mediasources/baloosearch/imagesearchresulthandler.cpp 6df3a2c11092422a18b00bb668498dc1b5fcbc2e mediasources/baloosearch/searchresulthandler.h 176327409fa9acd92d21a69e2a91f035d9140f51 mediasources/baloosearch/videosearchresulthandler.h 00d048cc0bfa44ae323afd531c7b41a3bcbcd528 mediasources/baloosearch/videosearchresulthandler.cpp f1439e735be43be68d0b4625019493f9249ae1e5 Diff: https://git.reviewboard.kde.org/r/122745/diff/ Testing --- Moved some files from External drive to $HOME, they got added to medialibrary, verified by debug messages for images and manually for music files Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122745: Monitor baloo for new media files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/ --- (Updated Feb. 28, 2015, 6:46 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Vishesh Handa. Repository: plasma-mediacenter Description --- This is uses the dbus signal provided by baloo, checks them mimetype of that file and passes that to related searchresulthandler Bonus point of this is in case properties of any files changes we also get updates. Diffs - mediasources/baloosearch/CMakeLists.txt 9bec5fd6c5af585b8faa53d5440878bf0dcf6566 mediasources/baloosearch/audiosearchresulthandler.h 3efb4bf1efc337a0a293bc1c391707302a76172c mediasources/baloosearch/audiosearchresulthandler.cpp 0c9d93b1988af62836f9c547707395810da311a2 mediasources/baloosearch/baloosearchmediasource.h e0289026e2cbf9c7e145f66b057b7ae6287b8e48 mediasources/baloosearch/baloosearchmediasource.cpp b90e9c03e352d1fd6962fbb28de9b8714e866fde mediasources/baloosearch/imagesearchresulthandler.h 72a2cb30617b91b92e9176688e21d63504876eb1 mediasources/baloosearch/imagesearchresulthandler.cpp 6df3a2c11092422a18b00bb668498dc1b5fcbc2e mediasources/baloosearch/searchresulthandler.h 176327409fa9acd92d21a69e2a91f035d9140f51 mediasources/baloosearch/videosearchresulthandler.h 00d048cc0bfa44ae323afd531c7b41a3bcbcd528 mediasources/baloosearch/videosearchresulthandler.cpp f1439e735be43be68d0b4625019493f9249ae1e5 Diff: https://git.reviewboard.kde.org/r/122745/diff/ Testing --- Moved some files from External drive to $HOME, they got added to medialibrary, verified by debug messages for images and manually for music files Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122717: Improve tooltip layouting
On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: I'm now getting most of my headlines elided or wrapped: K-\n Menü 99%. Wird\n geladen (battery) Aktualisierung... (updater) KM... (rather than KMail) Volume at\n 45% (kmix) Donnerst... (rather than Donnerstag, digitalclock) Lukáš Tinkl wrote: Yup, seeing the same here: http://developer.kde.org/~lukas/screenshots/tooltip.png Thanks for the feedback! This patch indeed shortens the max width a bit, so it's likely the culprit. Could you guys try changing property int preferredTextWidth: units.gridUnit * 20 to 25 or 30 and see if that fixes the problems? I'd like to not make it too wide, so we'll need some testing here, I think. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76692 --- On Feb. 26, 2015, 3:46 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 26, 2015, 3:46 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Improve tooltip layouting This patch ports the default tooltip away from custom spacing, positioning and Row/Column to QtQuick.Layouts. It makes the sizing more predictable, and the code more modern and readable. Tooltips feel to behave a bit smoother with this patch. In the process, this... - fixes spacing when no icon or image is set - limits the maximum height of the subtext to 8 lines (this prevents the klipper tooltip for example from growing super-high) - Makes the icon on the LHS proportional to the text - Limits the width a bit more to prevent super-wide tooltips - makes it use units.gridUnit throughout Changelog: Improve tooltip layout This is the more radical approach to https://git.reviewboard.kde.org/r/122715/ Diffs - src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae Diff: https://git.reviewboard.kde.org/r/122717/diff/ Testing --- Tested all applets' tooltips in the default panel File Attachments launcher (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/a6c636ce-3aef-4d5a-82f0-d78f9dab19a1__old-kickoff.png pager (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fae793bb-2965-4a81-be27-08efce5b3838__old-pager.png kdeconnect (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fc079c52-be17-47cf-bd11-976aed566155__old-kdeconnect.png clock (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/8214146b-cdd4-41d7-b406-f6fc404585cc__old-clock.png new-kickoff.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/9a96304f-1deb-4f57-9417-121a95b7ed03__new-kickoff.png new-pager.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/e2c5738f-e701-4a5e-a179-cedc6bb55181__new-pager.png new-kdeconnect.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/0c73a854-de8a-4dc2-bd57-c22e0700dbb5__new-kdeconnect.png new-clock.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/7311d304-cdf3-4bf2-8fdc-519d1a4c020d__new-clock.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
On Feb. 27, 2015, 1:13 p.m., Myriam Schweingruber wrote: I didn't give a ship it yet as I want to get Amarok 2.9 beta out first. I don't get this argument. It would be very important if we get this change into the beta and best also in stable releases. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76713 --- On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 9:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_stable_qt5 #7
See http://build.kde.org/job/kde-gtk-config_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_master_qt5 #9
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_master_qt5 #7
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On Thursday, February 26, 2015 16:16:59 Martin Gräßlin wrote: On Thursday 26 February 2015 16:01:57 Sebastian Kügler wrote: On Thursday, February 26, 2015 08:30:46 Martin Gräßlin wrote: On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: To explain how this works: the question mark is shown in the window decoration when the window signals that it supports the provides context help mode. The window decoration cannot know whether there is something actually providing it. So if it's wrongly shown this means fixing in the application. But the complete feature is questionably as it's a non-standard protocol between Qt and KWin. To my knowledge no other window manager supports it and no other toolkit supports it. Which means that it's a dangerous feature to put help into in a cross-desktop application. So we'd have to gauge its usefulness overall, and see if it makes sense. Are there any apps which really use it, i.e. also provide whatsthis hints consistently? There are many KCMs setting them. E.g. lots of KWin KCMs have such a hint (which might not be surprising as AFAIK the API was implemented by Matthias). Otherwise, perhaps we should review those apps that request the ?, and in case it's nonsensical (such as in systemsettings), remove it. In systemsettings it's only nonsensical for the kcms which do not have it. For the ones from KWin it makes sense. We were looking at the overview. So the ? only makes sense for some module. I guess that's OK then. Do you know how to find this provides context help API? For example in ui files: property name=whatsThis stringHere you can set that windows will be only snapped if you try to overlap them, i.e. they will not be snapped if the windows comes only near another window or border./string /property And QWidget::setWhatsThis Ah, okay, that. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: ISO for 2015-02-27
On Fri, Feb 27, 2015 at 6:57 PM, Harald Sitter sit...@kde.org wrote: - plasma wallpaper thumbnailing is broken; cause unknown https://bugs.kde.org/show_bug.cgi?id=344355 -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122745: Monitor baloo for new media files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Vishesh Handa. Repository: plasma-mediacenter Description --- This is uses the dbus signal provided by baloo, checks them mimetype of that file and passes that to related searchresulthandler Bonus point of this is in case properties of any files changes we also get updates. Diffs - mediasources/baloosearch/CMakeLists.txt 9bec5fd6c5af585b8faa53d5440878bf0dcf6566 mediasources/baloosearch/audiosearchresulthandler.h 3efb4bf1efc337a0a293bc1c391707302a76172c mediasources/baloosearch/audiosearchresulthandler.cpp 0c9d93b1988af62836f9c547707395810da311a2 mediasources/baloosearch/baloosearchmediasource.h e0289026e2cbf9c7e145f66b057b7ae6287b8e48 mediasources/baloosearch/baloosearchmediasource.cpp b90e9c03e352d1fd6962fbb28de9b8714e866fde mediasources/baloosearch/imagesearchresulthandler.h 72a2cb30617b91b92e9176688e21d63504876eb1 mediasources/baloosearch/imagesearchresulthandler.cpp 6df3a2c11092422a18b00bb668498dc1b5fcbc2e mediasources/baloosearch/searchresulthandler.h 176327409fa9acd92d21a69e2a91f035d9140f51 mediasources/baloosearch/videosearchresulthandler.h 00d048cc0bfa44ae323afd531c7b41a3bcbcd528 mediasources/baloosearch/videosearchresulthandler.cpp f1439e735be43be68d0b4625019493f9249ae1e5 Diff: https://git.reviewboard.kde.org/r/122745/diff/ Testing --- Moved some files from External drive to $HOME, they got added to medialibrary, verified by debug messages for images and manually for music files Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation
https://bugs.kde.org/show_bug.cgi?id=344355 Christoph Feck cf...@kde.org changed: What|Removed |Added CC||cf...@kde.org, ||david.narv...@computer.org --- Comment #3 from Christoph Feck cf...@kde.org --- Adding the other David. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76732 --- a general suggestion: use KConfigXT for wrapping the config value. - Martin Gräßlin On Feb. 27, 2015, 5:13 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated Feb. 27, 2015, 5:13 p.m.) Review request for Plasma. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
On Feb. 27, 2015, 10:42 a.m., Jan Grulich wrote: dataengines/geolocation/location_ip.cpp, line 149 https://git.reviewboard.kde.org/r/122736/diff/1/?file=351954#file351954line149 SSID is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be listed between networks, but I think that newer NM versions make hidden APs visible anyway. so how can I check for a hidden AP? They are not supposed to be sent to the service. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76704 --- On Feb. 27, 2015, 10:13 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated Feb. 27, 2015, 10:13 a.m.) Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository: plasma-workspace Description --- Adds a dependency to NetworkManager and queries the available wifi access points to include in the request to the location service. Diffs - CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc Diff: https://git.reviewboard.kde.org/r/122736/diff/ Testing --- Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
On Feb. 27, 2015, 11:40 a.m., Vishesh Handa wrote: src/ActionClasses.cpp, line 174 https://git.reviewboard.kde.org/r/122450/diff/1/?file=347185#file347185line174 Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? Martin Klapetek wrote: This way it clears the existing shortcut, I think, no? I followed the code which is used in the other places in Amarok. Given that I don't care whether it's needed to be that, but the consistency with the other code is a clear plus ;-) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76709 --- On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 9:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
On Feb. 27, 2015, 11:48 a.m., Martin Klapetek wrote: Can this be configured? I for sure don't want to be sending all my surroundings somewhere Yes it probably even has to be configured. I think we need to present the privacy contract of the service and have the user acknowledge it. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76711 --- On Feb. 27, 2015, 10:13 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated Feb. 27, 2015, 10:13 a.m.) Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository: plasma-workspace Description --- Adds a dependency to NetworkManager and queries the available wifi access points to include in the request to the location service. Diffs - CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc Diff: https://git.reviewboard.kde.org/r/122736/diff/ Testing --- Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- (Updated Feb. 27, 2015, 2:11 p.m.) Review request for Plasma. Changes --- Use Math.min Repository: plasma-workspace Description --- So that it does not cover your whole screen on smaller displays with higher DPIs Diffs (updated) - lookandfeel/contents/osd/OsdItem.qml f4a5580 Diff: https://git.reviewboard.kde.org/r/122738/diff/ Testing --- Works but I'm unsure on how this behaves on multiscreen, if someone could test that'd be great. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 27, 2015, 12:50 p.m.) Status -- This change has been marked as submitted. Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
ISO for 2015-02-27
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - kdenlive is now correctly installable - kate plasmoid being broken and showing up by default issue resolved - clipboard should be working as expected [1] - adding default widgets shouldn't crash the shell anymore # errata - all issues affecting Kubuntu 15.04 also affect the ISO (which among other things includes a slightly bugged out installer, best only install using en_US) - the ISO is rolled using the CI landing PPA due to stabilization blockage from missing bluez5. this in turn means that upgrades potentially won't work or break half way through as the underlying PPA breaks ever so often. - plasma wallpaper thumbnailing is broken; cause unknown # virtual machines virtual machines have a bit of trouble with the graphics. At least with virtualbox you can workaround the problem by temporarily switching to a different TTY (right-ctrl+f2 - right-ctrl+f1) [1] https://launchpad.net/ubuntu/+source/qtbase-opensource-src/5.4.0+dfsg-4ubuntu3 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_master_qt5 #8
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : kde-gtk-config_master_qt5 #10
See http://build.kde.org/job/kde-gtk-config_master_qt5/10/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids David Edmundson wrote: Generic is always better. KDeclarative is used from places outside Plasma. Applications in future will need to open KCMs too. If we put it in Plasma in one year we'll end up with this anyway and we end up maintaining a weird system used only by us. Also from a discussion on IRC you'll end up guessing the name to put in the UI. This will lead to blocking developers from being able to do the right thing by trying to be too clever. Bhushan Shah wrote: My suggestion is to have both this can be used by applets if they don't like solution provided by plasma-framework OR optionally turn this into simple processrunner, there are use cases for both methods Marco Martin wrote: apart that reading an always makes me cringe :p what I really don't like is the ui inconsistencies that this will cause (an encourages). They will happen anyways true, but at least a timid attempt at fighting that could be done (this was always been a problem in KDE, wasn't it..), creating a path of least resistence and trying to enforce it is an approach. in the end is mostly a technical problem, since the actual proper solution (putting them in the configure dialog) is not possible anymore. if some day this will be possible again (for instance kcms in qml) that should be the preferred way again, so both approaches are in the end just workarounds, so... whatever (/me shrugs) Bhushan Shah wrote: Or another option is something like https://paste.kde.org/pirqonxvl so that you can just do plasmoid.openConfigurationModules() Sebastian Kügler wrote: It would be possible if we made the applet's config dialog a QWidget (the KCM container) and put a QML container into that to load the actual config modules for the applet. The problem with this approach is that it's the exact opposite direction we have been going to, but at least it's not hidden from the API. I'm not proposing this, just bringing it up since it came up in my head: food for thought. Kai Uwe Broulik wrote: That could also give us back the widget sidebar looking consistent with the KCMs if we used a traditional window with a sidebar and then have pages for each of the qml config pages and add additional KCMs there as needed. For other formfactors the old all-QML view could be used again, given that widget-based apps don't really fit into a touch environment anyway. On the other hand, isn't systemsettings destined to become QtQuick-based eventually? Marco Martin wrote: yeah, *can* be done, but i consider it really a step back at this point. it's problem was mostly a too soon but still think was the right direction Sebastian Kügler wrote: I lean towards not going this step back as well. Not that I have an alternative solution to offer, though. :/ Kai Uwe Broulik wrote: So, what do we do then? :) For this particular patch, Ship it from my side. I'll let someone else check the checkbox to make sure we agree. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74750 --- On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated Jan. 24, 2015, 11:54 p.m.) Review request for Plasma. Repository: kdeclarative Description --- Since there are already like 10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a KCMShell.open(foo) and KCMShell.open([foo, bar, baz]) singleton. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed Diff: https://git.reviewboard.kde.org/r/122239/diff/ Testing --- Works. Dunno if the name causes clashes or this is the right place to put it. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/#review76722 --- lookandfeel/contents/osd/OsdItem.qml https://git.reviewboard.kde.org/r/122738/#comment52830 Math.min()? - Sebastian Kügler On Feb. 27, 2015, 11:45 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- (Updated Feb. 27, 2015, 11:45 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- So that it does not cover your whole screen on smaller displays with higher DPIs Diffs - lookandfeel/contents/osd/OsdItem.qml f4a5580 Diff: https://git.reviewboard.kde.org/r/122738/diff/ Testing --- Works but I'm unsure on how this behaves on multiscreen, if someone could test that'd be great. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- (Updated Feb. 27, 2015, 1:16 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- So that it does not cover your whole screen on smaller displays with higher DPIs Diffs - lookandfeel/contents/osd/OsdItem.qml f4a5580 Diff: https://git.reviewboard.kde.org/r/122738/diff/ Testing --- Works but I'm unsure on how this behaves on multiscreen, if someone could test that'd be great. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_stable_qt5 #9
See http://build.kde.org/job/kde-gtk-config_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76721 --- Ship it! because a) I can't review the code and b) I need to get beta out this weekend, string freeze is in effect since several weeks. Of course, if there are no string changes and you tested and built it without problems, you can go on, I trust you for the code part :) - Myriam Schweingruber On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 9:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/#review76724 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015, 1:11 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- (Updated Feb. 27, 2015, 1:11 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- So that it does not cover your whole screen on smaller displays with higher DPIs Diffs - lookandfeel/contents/osd/OsdItem.qml f4a5580 Diff: https://git.reviewboard.kde.org/r/122738/diff/ Testing --- Works but I'm unsure on how this behaves on multiscreen, if someone could test that'd be great. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_stable_qt5 #8
See http://build.kde.org/job/kde-gtk-config_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : kde-gtk-config_stable_qt5 #10
See http://build.kde.org/job/kde-gtk-config_stable_qt5/10/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122740: set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122740/ --- Review request for Plasma. Repository: plasma-workspace Description --- set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file Diffs - startkde/startkde.cmake 046543e Diff: https://git.reviewboard.kde.org/r/122740/diff/ Testing --- set it to 2. logged out, logged in everything was /huuuge/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76726 --- I'm a little late to the party, but this seems like it would cause a regression for anyone not using plasma workspace... right? Isn't it a kded bug that the shortcuts don't get forwarded to the active window? - Dan Meltzer On Feb. 27, 2015, 12:50 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 27, 2015, 12:50 p.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review76740 --- Ship it! +1 from me - Lukáš Tinkl On Úno. 11, 2015, 3:51 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Úno. 11, 2015, 3:51 odp.) Review request for Plasma. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs - kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/timedated1.xml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 27, 2015, 7:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs - kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/timedated1.xml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review76738 --- bump, or I'm going to push it anyway. - David Edmundson On Feb. 11, 2015, 2:51 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 11, 2015, 2:51 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs - kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/timedated1.xml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- Review request for Plasma. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
On Feb. 27, 2015, 3:51 p.m., Dan Meltzer wrote: I'm a little late to the party, but this seems like it would cause a regression for anyone not using plasma workspace... right? Isn't it a kded bug that the shortcuts don't get forwarded to the active window? I'm a little late to the party, but this seems like it would cause a regression for anyone not using plasma workspace... right? no, for upgrades it shouldn't matter (though haven't tested), a configured shortcut would stay (we will probably do something in plasma about that to more agressively steal the shortcut from amarok). For new setups it can still be configured. So it's just a change in the default. And even then I would say that this fixes a very severe bug in the inter-application play. As kglobalaccel maintainer I think it was a pretty severe application abuse to take the shortcut away from any other media application. Isn't it a kded bug that the shortcuts don't get forwarded to the active window? eh no. That would be pretty bad if the shortcut would be passed to the active window. Just imagine the shortcut Ctrl+F1. Whenever you press that to get to desktop 1 it would also open the help in the active application. Global shortcuts need to be filtered out. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76726 --- On Feb. 27, 2015, 1:50 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 27, 2015, 1:50 p.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122741: Prefer exposing lists to QML with QJsonArray
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- QVariantList are treated as objects with integer indexes for some reasons and leads to weird scenarios. Diffs - src/qmlcontrols/draganddrop/DeclarativeMimeData.h 4a0723b src/qmlcontrols/draganddrop/DeclarativeMimeData.cpp 0db74f9 Diff: https://git.reviewboard.kde.org/r/122741/diff/ Testing --- QuickShare plasmoid can use now DeclarativeMimeData. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1043
See http://build.kde.org/job/plasma-desktop_master_qt5/1043/changes Changes: [kde] Abstract dateandtime saving [kde] Add systemd support into the clock KCM as an optional dependency -- [...truncated 1651 lines...] ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/input/ui_themepage.h:37:18: warning: ‘KPushButton’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kpushbutton.h:47) [-Wdeprecated-declarations] KPushButton *installButton; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/input/ui_themepage.h:38:18: warning: ‘KPushButton’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kpushbutton.h:47) [-Wdeprecated-declarations] KPushButton *removeButton; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/input/ui_themepage.h: In member function ‘void Ui_ThemePage::setupUi(QWidget*)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/input/ui_themepage.h:77:32: warning: ‘KPushButton’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kpushbutton.h:47) [-Wdeprecated-declarations] installKnsButton = new KPushButton(ThemePage); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/input/ui_themepage.h:82:29: warning: ‘KPushButton’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kpushbutton.h:47) [-Wdeprecated-declarations] installButton = new KPushButton(ThemePage); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/input/ui_themepage.h:87:28: warning: ‘KPushButton’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kpushbutton.h:47) [-Wdeprecated-declarations] removeButton = new KPushButton(ThemePage); ^ Linking CXX shared module kcm_cursortheme.so http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/dateandtime/helper.cpp: In member function ‘KAuth::ActionReply ClockHelper::save(const QVariantMap)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/dateandtime/helper.cpp:243:24: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData data( kcmdatetimehelper ); ^ [ 56%] In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/recentlyusedmodel.h:24:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/applets/kickoff/recentadaptor.h:17, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/applets/kickoff/recentadaptor.cpp:11: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ Building CXX object kcms/launch/CMakeFiles/kcm_launch.dir/kwin_interface.cpp.o Linking CXX executable kcmdatetimehelper [ 56%] Built target kcm_cursortheme [ 57%] Building CXX object kcms/launch/CMakeFiles/kcm_launch.dir/kcm_launch_automoc.cpp.o [ 57%] Built target kcmdatetimehelper [ 57%] Building CXX object kcms/ksplash/CMakeFiles/kcm_splashscreen.dir/kcm_splashscreen_automoc.cpp.o [ 57%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/screensaver_interface.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/ksplash/kcm.cpp: In constructor ‘KCMSplashScreen::KCMSplashScreen(QWidget*, const QVariantList)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/ksplash/kcm.cpp:46:46: warning: ‘Plasma::Package::Package(Plasma::PackageStructure*)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:91) [-Wdeprecated-declarations] , m_configGroup(m_config.group(KSplash)) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/ksplash/kcm.cpp:66:48: warning: ‘void Plasma::Package::setDefaultPackageRoot(const QString)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:294) [-Wdeprecated-declarations]
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #11 from manciul...@yahoo.com --- Hi Lukas, I'm trying to help Eric sort out this issue on our Slackware systems. polkit-kde-authentication-agent-1 is indeed running, but according to my .xsession-errors (attached) it is started by klauncher *after* powerdevil is started by kded. Is this expectect behavior? Otherwise is there a way to change start-up order or inhibit kded to start the services until after klauncher is done? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 manciul...@yahoo.com changed: What|Removed |Added CC||manciul...@yahoo.com --- Comment #10 from manciul...@yahoo.com --- Created attachment 91331 -- https://bugs.kde.org/attachment.cgi?id=91331action=edit .xsessions-errors: powedevil starts before polkit-kde-authentication-agent-1 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #12 from Lukáš Tinkl lu...@kde.org --- Hmm, that could indeed be the problem. polkit-kde-authentication-agent-1 is started by the session which is always after kded modules (powerdevil being one)... I wonder what happens when you restart kded (and hence powerdevil's kded module) after the session has been up and running (just killall -9 kded5 kded5) and then restart plasmashell (kquitapp5 plasmashell plasmashell) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122736: [dataengines/geolocation] Use wifi data if available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository: plasma-workspace Description --- Adds a dependency to NetworkManager and queries the available wifi access points to include in the request to the location service. Diffs - CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc Diff: https://git.reviewboard.kde.org/r/122736/diff/ Testing --- Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #3 from Pulfer pul...@list.ru --- (In reply to Martin Gräßlin from comment #2) I do not really see the need. We communicated for at least a year now that Plasma 4 and 5 are not co-installable And there's nothing good in it. It's a bug, not a feature. Unless it's a political decision, not technical. and no applications should use the libraries used by ksysguard. I can add Conflicts to RPM packages to avoid co-installing 4 and 5. But adding Requires/Provides filters to avoid devel(libprocessui) (= /usr/lib/libprocessui.so file) etc Requires/Provides is too much hacks already. On the other hand, if no applications should use these libraries, I can do the job downstream. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76703 --- ping, anyone? - Martin Gräßlin On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 9:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #4 from David Edmundson k...@davidedmundson.co.uk --- What app is using it? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76704 --- dataengines/geolocation/location_ip.cpp https://git.reviewboard.kde.org/r/122736/#comment52823 SSID is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be listed between networks, but I think that newer NM versions make hidden APs visible anyway. - Jan Grulich On Úno. 27, 2015, 9:13 dop., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated Úno. 27, 2015, 9:13 dop.) Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository: plasma-workspace Description --- Adds a dependency to NetworkManager and queries the available wifi access points to include in the request to the location service. Diffs - CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc Diff: https://git.reviewboard.kde.org/r/122736/diff/ Testing --- Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #5 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #3) On the other hand, if no applications should use these libraries, I can do the job downstream. well it was a workspace library which means that we never gave ABI guarantees for it. This IMHO implies that it also doesn't give guarantees for co-installability. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
On Feb. 27, 2015, 11:40 a.m., Vishesh Handa wrote: src/ActionClasses.cpp, line 174 https://git.reviewboard.kde.org/r/122450/diff/1/?file=347185#file347185line174 Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? This way it clears the existing shortcut, I think, no? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76709 --- On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 9:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76711 --- Can this be configured? I for sure don't want to be sending all my surroundings somewhere - Martin Klapetek On Feb. 27, 2015, 10:13 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated Feb. 27, 2015, 10:13 a.m.) Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository: plasma-workspace Description --- Adds a dependency to NetworkManager and queries the available wifi access points to include in the request to the location service. Diffs - CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc Diff: https://git.reviewboard.kde.org/r/122736/diff/ Testing --- Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #12 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #11) Can be libksgrd5.so with /usr/include/ksysguard5 then. Anything but file conflicts with kde-frameworks. I really do not understand the need. From what Luca wrote the library can be co-installed on openSUSE. Also the so-version changed. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #7 from Luca Beltrame lbeltr...@kde.org --- In data venerdì 27 febbraio 2015 09:49:54, Pulfer ha scritto: kdebase4-workspace FWIW: in openSUSE we have split the libraries from the workspace, so that installing a 5.x workspace will not cause conflicts and possibly removals of packages like kdevelop. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122736/#review76707
---
dataengines/geolocation/location_ip.cpp
https://git.reviewboard.kde.org/r/122736/#comment52825
wifiAccessPoints.append(QJsonObject{
{QStringLiteral(macAddress), accessPoint-hardwareAddress()}
});
dataengines/geolocation/location_ip.cpp
https://git.reviewboard.kde.org/r/122736/#comment52824
You might want to use toJson(QJsonDocument::Compact) to save a little bit
of bandwidth
- Kai Uwe Broulik
On Feb. 27, 2015, 9:13 vorm., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122736/
---
(Updated Feb. 27, 2015, 9:13 vorm.)
Review request for Plasma, Jan Grulich and Lukáš Tinkl.
Repository: plasma-workspace
Description
---
Adds a dependency to NetworkManager and queries the available wifi
access points to include in the request to the location service.
Diffs
-
CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489
dataengines/geolocation/CMakeLists.txt
efdcd14940b47a64b4e70dce69bdeeffdc6873f5
dataengines/geolocation/geolocation.h
fcc95086b97b6c96c0ab9bce3cac703d96d0b43e
dataengines/geolocation/geolocation.cpp
e02060e157a29902e594310102555096bd619e2e
dataengines/geolocation/location_ip.cpp
3a13dc3018bff482c48098e1827f31c5fa3184cc
Diff: https://git.reviewboard.kde.org/r/122736/diff/
Testing
---
Tested with my available networks and checked position on openstreetmaps.
Basically it even put me in the right room of the building I'm in.
Thanks,
Martin Gräßlin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #8 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #6) At least these apps used KDE4 version of ksysguard libraries: kdebase4-workspace kdevelop4 knemo plasma-applet-fancytasks sentinella The only non-workspace application of those is kdevelop4. All other should not/cannot be used in a Plasma 5 session. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #9 from Pulfer pul...@list.ru --- Created attachment 91314 -- https://bugs.kde.org/attachment.cgi?id=91314action=edit Quick patch to rename libksgrd to libKF5ksgrd I'll likely go this way with my downstream Plasma 5 packaging. Because I really see now reason to have any file conflicts between KDE4 and Plasma 5 packages. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #6 from Pulfer pul...@list.ru --- (In reply to David Edmundson from comment #4) What app is using it? At least these apps used KDE4 version of ksysguard libraries: kdebase4-workspace kdevelop4 knemo plasma-applet-fancytasks sentinella Not many. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #10 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #9) Created attachment 91314 [details] Quick patch to rename libksgrd to libKF5ksgrd this renaming is wrong as it's not a frameworks library and also not planned to become one. Thus it should use the KF5 prefix. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #11 from Pulfer pul...@list.ru --- (In reply to Martin Gräßlin from comment #10) (In reply to Pulfer from comment #9) Created attachment 91314 [details] Quick patch to rename libksgrd to libKF5ksgrd this renaming is wrong as it's not a frameworks library and also not planned to become one. Thus it should use the KF5 prefix. Can be libksgrd5.so with /usr/include/ksysguard5 then. Anything but file conflicts with kde-frameworks. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76709 --- src/ActionClasses.cpp https://git.reviewboard.kde.org/r/122450/#comment52826 Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? - Vishesh Handa On Feb. 6, 2015, 8:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 8:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343659] crash when open a new sheet when using Breeze Qt 4
https://bugs.kde.org/show_bug.cgi?id=343659 Tomas Mecir mec...@gmail.com changed: What|Removed |Added Component|general |general Assignee|calligra-sheets-bugs-null@k |plasma-devel@kde.org |de.org | Version|2.8.6 |unspecified Product|calligrasheets |Breeze CC||mec...@gmail.com --- Comment #5 from Tomas Mecir mec...@gmail.com --- This looks like a breeze issue, re-assigning. From investigating, it looks like breeze's eventFilterScrollArea attempts to access scrollbars on QAbstractScrollArea-derived widgets, even if these scrollbars do not exist (sheets calls setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);). -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #13 from manciul...@yahoo.com --- (In reply to Lukáš Tinkl from comment #12) Hmm, that could indeed be the problem. polkit-kde-authentication-agent-1 is started by the session which is always after kded modules (powerdevil being one)... I wonder what happens when you restart kded (and hence powerdevil's kded module) after the session has been up and running (just killall -9 kded5 kded5) and then restart plasmashell (kquitapp5 plasmashell plasmashell) Thank you for your quick reply. I issued the commands you suggested and that did the trick (partially). Suspend Hibernate show up in the Leave Menu, Shutdown Reboot are still missing. Now, when powerdevil starts it CAN contact ConsoleKit, whereas in the 'normal' start-up sequence there's an error message about not contacting CK. Can the start-up sequence be changed from startkde? kf5.kiconthemes: Theme tree: (Breeze) powerdevil: Loading UPower backend... powerdevil: Success! powerdevil: Backend loaded, loading core powerdevil: Core loaded, initializing backend powerdevil: Using XRandR powerdevil: Screen brightness value: 3 powerdevil: current screen brightness value: 3 powerdevil: Can suspend powerdevil: Can hibernate powerdevil: Backend is ready, KDE Power Management system initialized powerdevil: A new battery was detected XSync seems available and ready XSync Inited Supported, init completed powerdevil: Current session is now active powerdevil: ConsoleKit support initialized powerdevil: Got a valid offer for DPMSControl powerdevil: Core is ready, registering various services on the bus... powerdevil: Can't contact systemd powerdevil: We are now into activity default powerdevil: () () powerdevil: () () powerdevil: Loading profile for plugged AC powerdevil: Activity is not forcing a profile powerdevil: Profiles: AC powerdevil: set screen brightness percentage: 30 powerdevil: Screen brightness value max: 10 powerdevil: set screen brightness value: 3 powerdevil: powerdevil: Loading timeouts with 30 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 Hrvoje Senjan hrvoje.sen...@gmail.com changed: What|Removed |Added CC||hrvoje.sen...@gmail.com --- Comment #13 from Hrvoje Senjan hrvoje.sen...@gmail.com --- yeah, we have the helper splited as a package on openSUSE, so lib can be coinstalled (ftr. the patch you pasted is not 'an openSUSE' patch) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- Review request for Plasma. Repository: plasma-workspace Description --- So that it does not cover your whole screen on smaller displays with higher DPIs Diffs - lookandfeel/contents/osd/OsdItem.qml f4a5580 Diff: https://git.reviewboard.kde.org/r/122738/diff/ Testing --- Works but I'm unsure on how this behaves on multiscreen, if someone could test that'd be great. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #14 from Pulfer pul...@list.ru --- (In reply to Martin Gräßlin from comment #12) I really do not understand the need. From what Luca wrote the library can be co-installed on openSUSE. Also the so-version changed. The need is to avoid any file conflicts. What's the need to have them if it's easy to avoid? Why should translations from libksysguard force users to remove kde-l10n package (.po conflicts), development files from libksysguard should force to remove kde-workspace-devel package (.so conflicts) etc. There's nothing hard in avoiding this, I really don't understand the need to keep conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #15 from Pulfer pul...@list.ru --- RPM package (spec and patches) that doesn't conflict with KDE4 stuff: https://abf.io/import/libksysguard ksysguard from Plasma 5.2.1 build fine with this package installed. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122450: Do not set global shortcuts for the Media keys
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76713 --- I didn't give a ship it yet as I want to get Amarok 2.9 beta out first. - Myriam Schweingruber On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 6, 2015, 9:06 a.m.) Review request for Amarok and Plasma. Repository: amarok Description --- Amarok used to grab the keys for: * Qt::Key_MediaPlay * Qt::Key_MediaStop * Qt::Key_MediaNext * Qt::Key_MediaPrevious As those are global shortcuts they are taken away from any other application when Amarok is running. E.g. if I watch a movie in VLC and press the media play button (which VLC handles) Amarok will start playback if it's running. If Amarok is not running, VLC will pause the playback. This shows that a multi-media application should not globally grab these keys. In addition we just introduced a change [1] in plasma-workspace for the Plasma/5.3 release to grab these shortcuts and bind them to the mpris2 dataengine. Now the mpris2 engine handles those shortcuts and delegates to the currently active application. [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b Diffs - src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 Diff: https://git.reviewboard.kde.org/r/122450/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
