Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) Thomas Lübking wrote: When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) Martin Gräßlin wrote: Maybe something like showingdesktophelper? Thomas Lübking wrote: I'll read that as a joke? =) Window Aperture? Everybody else: feel free to suggest a nice, striking or stupid name. Ok, final threat :-) I'll push this tonight to underrun the 5.3 freeze. The name *will* be Bad, Bad, Windows =) If you want another name (decide! helper is no option), removal of one of the effects or point out remaining wishes, glitches, etc.: please SHOUT! - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On April 4, 2015, 3:28 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 4, 2015, 3:28 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100
Re: PIM Sprint this Weekend
On Tuesday 07 April 2015 10:48:07 Vishesh Handa wrote: Hey guys I'm travelling to Toulouse for the PIM Sprint this weekend. If there is anything specific anyone would like to me to discuss w.r.t Plasma, please let me know. please push in a direction that we get events in the calendar back. I don't care how shiny the new Akonadi is going to be, I want my feature back (boud's blog post is a nice reminder that libraries should think about their users). Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
On Monday 06 April 2015 21:07:17 Eike Hein wrote: Hiyo, we're freezing this week, so it's time to gather the changes for the promo folks again. I'll start with the noteworthy stuff in my components: ScreenLocker: * XInput2 devices are grabbed: increases security for setups with multiple independent devices * Support for some global shortcuts (like multimedia keys) * Support for on-screen-display messages (e.g. volume/brightness changes) * Inhibition when media (e.g. video) is played Plasma-Desktop: * Clipboard applet gains support for showing barcodes * Media control global shortcuts are configured to control mpris2 applications KWin: * support starting a nested kwin_wayland under X11 * support starting kwin_wayland on /dev/fb0 * support starting an Xwayland server * see https://community.kde.org/KWin/Wayland#Starting_a_nested_KWin If I remember more things I'll fill it in (KWin has about 200 commits). Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/#review78598 --- wallpapers/image/imagepackage/contents/ui/config.qml (line 296) https://git.reviewboard.kde.org/r/123275/#comment53770 hmm, not understanding exactly why the index has to be decremented by count. shouldn't be just deceremented by 1 iff the removed index is than currentindex? - Marco Martin On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 6, 2015, 1:15 p.m.) Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
PIM Sprint this Weekend
Hey guys I'm travelling to Toulouse for the PIM Sprint this weekend. If there is anything specific anyone would like to me to discuss w.r.t Plasma, please let me know. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/#review78597 --- Ship it! Ship It! - Marco Martin On April 6, 2015, 2:07 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/ --- (Updated April 6, 2015, 2:07 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick/appletquickitem.cpp 1abedf0 Diff: https://git.reviewboard.kde.org/r/123276/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
On Monday 06 April 2015, Eike Hein wrote: Hiyo, we're freezing this week, so it's time to gather the changes for the promo folks again. I'll start with the noteworthy stuff in my components: stuff i touched announcement-worty: kdeplasma-addons: * comic applet ported to plasma 5 plasma-workspace: * systemmonitor plasmoids ported to plasma 5 frameworks side (technically not in workspace release, so not sure can be fitted there, but usable and usable since this release): * new api and runtime for QML apps * new api for QML systemsettings modules * better high dpi support in various places (could be worth screenshots about that in the announcement or better waiting applications like dolphin are finally released?) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345940] New: plasmoid looks a bit unorganised
https://bugs.kde.org/show_bug.cgi?id=345940 Bug ID: 345940 Summary: plasmoid looks a bit unorganised Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: wosk...@yahoo.de I'm actually talking about the Enable Power Management and PM Settings that are in the midst of a few sliders for other things. I would recommend using the approach from the plama-nm plasmoid where similar elements are located at the top. Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345940] plasmoid looks a bit unorganised
https://bugs.kde.org/show_bug.cgi?id=345940 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||k...@davidedmundson.co.uk Resolution|--- |INVALID --- Comment #1 from David Edmundson k...@davidedmundson.co.uk --- That's not a specific bug report. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123271/#review78604
---
What when I place it on the desktop? I'd like it to fill the entire room there.
If I want a massive Kickoff button on my desktop, that's up to me :)
applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 25)
https://git.reviewboard.kde.org/r/123271/#comment53776
You might as well just make the MouseArea the root item
applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 28)
https://git.reviewboard.kde.org/r/123271/#comment53774
readonly property
applets/kickoff/package/contents/ui/CompactRepresentation.qml (lines 47 - 48)
https://git.reviewboard.kde.org/r/123271/#comment53775
Coding style: MouseArea {
applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 50)
https://git.reviewboard.kde.org/r/123271/#comment53777
No semicolon at the end
- Kai Uwe Broulik
On April 6, 2015, 11:40 vorm., Mathias Kraus wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123271/
---
(Updated April 6, 2015, 11:40 vorm.)
Review request for Plasma.
Repository: plasma-desktop
Description
---
In vertical panels, the kickoff button is huge. This patch limits the size of
the kickoff button.
Diffs
-
applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION
applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb
Diff: https://git.reviewboard.kde.org/r/123271/diff/
Testing
---
see screenshots
File Attachments
kickoff-horizontal-before
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png
kickoff-horizontal-after
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png
kickoff-vertical-before
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png
kickoff-vertical-after
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png
Thanks,
Mathias Kraus
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
On Tue, Apr 7, 2015 at 10:51 AM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 07 April 2015 10:48:07 Vishesh Handa wrote: Hey guys I'm travelling to Toulouse for the PIM Sprint this weekend. If there is anything specific anyone would like to me to discuss w.r.t Plasma, please let me know. please push in a direction that we get events in the calendar back. I don't care how shiny the new Akonadi is going to be, I want my feature back (boud's blog post is a nice reminder that libraries should think about their users). From a technical point of view the events can all be fetched in the QML Calendar Components (which i made together with some pim folks). That part is there (read only events that is) and is just waiting till pimlibs are working in a Qt5 environment. It isn't ported to Qt5 yet, but is quite easy to do. I will if the requirements for that are met. I guess the requirement for calendar events to return in plasma are: - Akanodi compiling and running in Qt5/frameworks (done iirc) - Pimlibs (KCalCore specifically) including everything that's needed for the ETM to work to run under Qt5/frameworks That's all that's required to get it working again. I don't know where PIM stands right now in that last step. I haven't been following the PIM progress for a while. Cheers Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
On Tue, Apr 7, 2015 at 12:35 PM, Mark Gaiser mark...@gmail.com wrote: From a technical point of view the events can all be fetched in the QML Calendar Components (which i made together with some pim folks). That part is there (read only events that is) and is just waiting till pimlibs are working in a Qt5 environment. It isn't ported to Qt5 yet, but is quite easy to do. I will if the requirements for that are met. I guess the requirement for calendar events to return in plasma are: - Akanodi compiling and running in Qt5/frameworks (done iirc) - Pimlibs (KCalCore specifically) including everything that's needed for the ETM to work to run under Qt5/frameworks That's all that's required to get it working again. I don't know where PIM stands right now in that last step. I haven't been following the PIM progress for a while. Technically yes, but the akonadi-qt5 is already deprecated as akonadi2 is being worked on. Therefore investing anything into making things work with akonadi-qt5 is just a waste of time as it's never going to be released. And no release means no features for users. (Also KCalCore is a beast nobody has managed to port properly to frameworks yet iirc) Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123281: Avoid triggering bug 340691
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/ --- Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Repository: plasma-desktop Description --- With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug. As similar fix was applied for bug 343583. Diffs - kcms/icons/icons.cpp 16a3141 kcms/migrationlib/kdelibs4config.h 0c1b7fe Diff: https://git.reviewboard.kde.org/r/123281/diff/ Testing --- Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
On Tue, Apr 7, 2015 at 10:51 AM, Martin Gräßlin mgraess...@kde.org wrote: (boud's blog post is a nice reminder that libraries should think about their users) His blog is one big rant. I love it. He's completely right. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Hangout of 7 April 2015 Antonis: * undo feature for wallpaper removal * bugfixing wallpaper configuration * release of plasmate repo (will be plasma-sdk) * will tag master and make a branch out of it, then merge frameworks into master David: * fixing a bug in xddm (problem in gnome-keyring) * working on the energy kinfocenter module Kai Uwe: * solid backend for kdeconnect * monitor brightness calibration via dcccontrol software Martin G: * work on wayland * documentation on how run kwin on framebuffer (https://community.kde.org/KWin/Wayland#Running_on_the_framebuffer_device) * more wayland work next week Vishesh: * work on new baloo engine * investigate on a multithread-related lmdb bug * krunner bugfixes Marco * bugfixes on plasma-framework, plasma-workspace related issues * next week more on that -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
Am Dienstag, 7. April 2015, 12:15:05 schrieb Vishesh Handa: On Tue, Apr 7, 2015 at 10:51 AM, Martin Gräßlin mgraess...@kde.org wrote: (boud's blog post is a nice reminder that libraries should think about their users) His blog is one big rant. I love it. He's completely right. I wonder about the mail indexing and search. Its still not available in Plasma 5, isn´t it? (Still on 4.14.6/7 and Akonadi 1.13). Ciao, -- Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345940] Move Enable Power Management checkbox to the top as other applets
https://bugs.kde.org/show_bug.cgi?id=345940 Martin Klapetek mklape...@kde.org changed: What|Removed |Added Resolution|INVALID |--- Ever confirmed|0 |1 CC||mklape...@kde.org Summary|plasmoid looks a bit|Move Enable Power |unorganised |Management checkbox to the ||top as other applets Status|RESOLVED|REOPENED --- Comment #2 from Martin Klapetek mklape...@kde.org --- I for one actually think this is a good report. Currently you enable/disable networks and bluetooth on the top while enabling/disabling PM is in the middle of the sliders and stuff. I do agree that it would make more sense on the top, even if just for consistency. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 7, 2015, 11:43 a.m., Kai Uwe Broulik wrote: What when I place it on the desktop? I'd like it to fill the entire room there. If I want a massive Kickoff button on my desktop, that's up to me :) +1; it should really be iff vertical == true - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78604 --- On April 6, 2015, 1:40 p.m., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 1:40 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123281: Avoid triggering bug 340691
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/#review78614 --- Ship it! Ship It! - Marco Martin On April 7, 2015, 11:13 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/ --- (Updated April 7, 2015, 11:13 a.m.) Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Repository: plasma-desktop Description --- With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug. As similar fix was applied for bug 343583. Diffs - kcms/icons/icons.cpp 16a3141 kcms/migrationlib/kdelibs4config.h 0c1b7fe Diff: https://git.reviewboard.kde.org/r/123281/diff/ Testing --- Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
* better high dpi support in various places (could be worth screenshots about that in the announcement or better waiting applications like dolphin are finally released?) I think we should save the high DPI stuff till 5.4 when it's user facing. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
On Tue, Apr 7, 2015 at 10:48 AM, Vishesh Handa m...@vhanda.in wrote: Hey guys I'm travelling to Toulouse for the PIM Sprint this weekend. If there is anything specific anyone would like to me to discuss w.r.t Plasma, please let me know. Supporting libaccounts (so kaccounts, former webaccounts) is crucial for integrating any different services from plasma side. We need to make sure we're all on the same page! Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345940] Move Enable Power Management checkbox to the top as other applets
https://bugs.kde.org/show_bug.cgi?id=345940 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #3 from Kai Uwe Broulik k...@privat.broulik.de --- I do agree that the layout isn't optimal but it has only been ported to Plasma 5 verbatim before Plasma-NM had its current layout. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123281: Avoid triggering bug 340691
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/ --- (Updated April 7, 2015, 11:46 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Changes --- Submitted with commit b2fc8174d5733fe3b051f839944870b4f51b8c52 by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug. As similar fix was applied for bug 343583. Diffs - kcms/icons/icons.cpp 16a3141 kcms/migrationlib/kdelibs4config.h 0c1b7fe Diff: https://git.reviewboard.kde.org/r/123281/diff/ Testing --- Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
On Tue, Apr 7, 2015 at 12:37 AM, Eike Hein h...@kde.org wrote: Hiyo, we're freezing this week, so it's time to gather the changes for the promo folks again. I'll start with the noteworthy stuff in my components: Plasma 5.3 will have technology preview of plasma-mediacenter, Promo people may include technology preview word or not.. But I'd say its pretty much preview as this is not feature complete with kdelibs4 based versions. Features of plasma-mediacenter - Fetches available media (audio, video, pictures) and its metadata from baloo - Have experimental dashboard mode which allows you to add plasmoids. - MPRIS2 enabled media player plasmashell - Plasma shell gained ability to load shell based upon current session. This allows to use same startkde script to launch different shells. (I'd say it's not much user focused but still) -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 7, 2015, 12:59 p.m., Sebastian Kügler wrote: So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent. I agree that a huge button may not be what the user wants, but then what's huge? Your patch seems to work incidentally, since you have a typo in the code which essentially invalidates the preferred size. I'd like to see a better thought-through solution for this, as such, I don't find this patch acceptable. also, it shouldn't have a behavior inconsistent with every other popupapplet icon - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78617 --- On April 6, 2015, 11:40 a.m., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 11:40 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123283: Remove interesting ksmserver easter egg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/ --- Review request for Plasma and Lukáš Tinkl. Repository: plasma-workspace Description --- KSMSERVER_STARTUP_DEBUGl is not defined, meaning this code currently exists in all our ksmservers. if you have 2 instances of gedit, konqueror and kspaceduel open in the right order on session restore you get an error message saying drat. I'm not sure what benefit this is to society, but I'm sure it was important. This feature is now obsolete as kspaceduel doesn't exist any more and would require more effort to trigger Diffs - ksmserver/startup.cpp 6010eff Diff: https://git.reviewboard.kde.org/r/123283/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123283: Remove interesting ksmserver easter egg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/#review78626 --- :D That's an awesome feature. I guess there's an interesting story behind this, when it was implemented (for debugging?). - Matthias Klumpp On April 7, 2015, 2:25 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/ --- (Updated April 7, 2015, 2:25 nachm.) Review request for Plasma and Lukáš Tinkl. Repository: plasma-workspace Description --- KSMSERVER_STARTUP_DEBUGl is not defined, meaning this code currently exists in all our ksmservers. if you have 2 instances of gedit, konqueror and kspaceduel open in the right order on session restore you get an error message saying drat. I'm not sure what benefit this is to society, but I'm sure it was important. This feature is now obsolete as kspaceduel doesn't exist any more and would require more effort to trigger Diffs - ksmserver/startup.cpp 6010eff Diff: https://git.reviewboard.kde.org/r/123283/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123283: Remove interesting ksmserver easter egg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/#review78625 --- Ship it! Ship It! - Martin Gräßlin On April 7, 2015, 4:25 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/ --- (Updated April 7, 2015, 4:25 p.m.) Review request for Plasma and Lukáš Tinkl. Repository: plasma-workspace Description --- KSMSERVER_STARTUP_DEBUGl is not defined, meaning this code currently exists in all our ksmservers. if you have 2 instances of gedit, konqueror and kspaceduel open in the right order on session restore you get an error message saying drat. I'm not sure what benefit this is to society, but I'm sure it was important. This feature is now obsolete as kspaceduel doesn't exist any more and would require more effort to trigger Diffs - ksmserver/startup.cpp 6010eff Diff: https://git.reviewboard.kde.org/r/123283/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123282: The energy info KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123283: Remove interesting ksmserver easter egg
On April 7, 2015, 2:31 nachm., Matthias Klumpp wrote: :D That's an awesome feature. I guess there's an interesting story behind this, when it was implemented (for debugging?). Just to be clear, that's no objection to the patch - please kill this thing ;-) - Matthias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/#review78626 --- On April 7, 2015, 2:25 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/ --- (Updated April 7, 2015, 2:25 nachm.) Review request for Plasma and Lukáš Tinkl. Repository: plasma-workspace Description --- KSMSERVER_STARTUP_DEBUGl is not defined, meaning this code currently exists in all our ksmservers. if you have 2 instances of gedit, konqueror and kspaceduel open in the right order on session restore you get an error message saying drat. I'm not sure what benefit this is to society, but I'm sure it was important. This feature is now obsolete as kspaceduel doesn't exist any more and would require more effort to trigger Diffs - ksmserver/startup.cpp 6010eff Diff: https://git.reviewboard.kde.org/r/123283/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123283: Remove interesting ksmserver easter egg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/#review78627 --- Ship it! Remember to report it in the changelog. ;) - Aleix Pol Gonzalez On April 7, 2015, 4:25 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/ --- (Updated April 7, 2015, 4:25 p.m.) Review request for Plasma and Lukáš Tinkl. Repository: plasma-workspace Description --- KSMSERVER_STARTUP_DEBUGl is not defined, meaning this code currently exists in all our ksmservers. if you have 2 instances of gedit, konqueror and kspaceduel open in the right order on session restore you get an error message saying drat. I'm not sure what benefit this is to society, but I'm sure it was important. This feature is now obsolete as kspaceduel doesn't exist any more and would require more effort to trigger Diffs - ksmserver/startup.cpp 6010eff Diff: https://git.reviewboard.kde.org/r/123283/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78620 --- Ship it! cool, modulo just few small issues CMakeLists.txt (line 15) https://git.reviewboard.kde.org/r/123282/#comment53784 QuickWidgets shouldn't be needed CMakeLists.txt (line 35) https://git.reviewboard.kde.org/r/123282/#comment53792 Plasma/PlasmaQuick shouldn't be needed anymore Modules/energy/kcm.cpp (line 41) https://git.reviewboard.kde.org/r/123282/#comment53790 shouldn't be needed anymore Modules/energy/package/contents/ui/main.qml (line 297) https://git.reviewboard.kde.org/r/123282/#comment53787 I'm fine it stays as is for now, if just the color is taken from a Palette Modules/energy/package/metadata.desktop (line 15) https://git.reviewboard.kde.org/r/123282/#comment53785 KPackage/GenericQml - Marco Martin On April 7, 2015, 1:37 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated April 7, 2015, 1:37 p.m.) Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78621 --- CMakeLists.txt (line 34) https://git.reviewboard.kde.org/r/123282/#comment53789 Make them optional? Modules/energy/CMakeLists.txt (line 21) https://git.reviewboard.kde.org/r/123282/#comment53788 Why is it commented out? Modules/energy/package/contents/ui/Graph.qml (line 94) https://git.reviewboard.kde.org/r/123282/#comment53794 Is it fine to hardcode the colors? Modules/energy/package/contents/ui/main.qml (line 384) https://git.reviewboard.kde.org/r/123282/#comment53793 What do we need to have there? Modules/energy/statisticsprovider.cpp (line 183) https://git.reviewboard.kde.org/r/123282/#comment53797 Looks quite big for a lambda, make it a method? Modules/energy/wakeupmodel.cpp (line 129) https://git.reviewboard.kde.org/r/123282/#comment53795 Nitpicking but: (*it).something is clearer as it-something kcmcontainer.cpp (line 62) https://git.reviewboard.kde.org/r/123282/#comment53786 unrelated? - Aleix Pol Gonzalez On April 7, 2015, 3:37 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated April 7, 2015, 3:37 p.m.) Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
On Tue, Apr 7, 2015 at 12:44 PM, Martin Steigerwald mar...@lichtvoll.de wrote: I wonder about the mail indexing and search. Its still not available in Plasma 5, isn´t it? (Still on 4.14.6/7 and Akonadi 1.13). I'm assuming you're talking about KRunner? We can search through the email index from Qt5. We do not need any Akonadi specific apis. I just haven't bothered writing the runner and doing it. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
On April 7, 2015, 8:31 a.m., Marco Martin wrote: wallpapers/image/imagepackage/contents/ui/config.qml, line 296 https://git.reviewboard.kde.org/r/123275/diff/1/?file=360286#file360286line296 hmm, not understanding exactly why the index has to be decremented by count. shouldn't be just deceremented by 1 iff the removed index is than currentindex? No, because if we remove 5 wallpapers instead of 1, then we are still going to point into the wrong wallpaper. Right? - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/#review78598 --- On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 6, 2015, 1:15 p.m.) Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/ --- (Updated April 7, 2015, 2:49 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 684e456f8433a3234345d6f8f5ccee230ee8 by Antonis Tsiapaliokas to branch master. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick/appletquickitem.cpp 1abedf0 Diff: https://git.reviewboard.kde.org/r/123276/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78622 --- Modules/energy/kcm.cpp (line 65) https://git.reviewboard.kde.org/r/123282/#comment53791 No need to make your name translatable :p Modules/energy/package/contents/ui/main.qml (line 97) https://git.reviewboard.kde.org/r/123282/#comment53798 What about multiple batteries? Modules/energy/package/contents/ui/main.qml (line 451) https://git.reviewboard.kde.org/r/123282/#comment53799 Thi could really use some QLocale formatting of the number Modules/energy/wakeupmodel.h (line 64) https://git.reviewboard.kde.org/r/123282/#comment53796 override? (also below) - Lukáš Tinkl On Dub. 7, 2015, 3:37 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated Dub. 7, 2015, 3:37 odp.) Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
On Mon, Apr 6, 2015 at 9:07 PM, Eike Hein h...@kde.org wrote: Hiyo, we're freezing this week, so it's time to gather the changes for the promo folks again. I'll start with the noteworthy stuff in my components: User-visible changes in Bluedevil: * Bluedevil was ported to BluezQt. This comes with minor fixes everywhere and also a new Bluetooth applet. Due to https://bugs.kde.org/show_bug.cgi?id=345872 it may be needed to manually enable the applet in system tray settings. * Added support for rfkill, allowing to block Bluetooth (so that the Bluetooth led lights off on some laptops) and also to unblock it. This requires a read/write access to /dev/rfkill device and should be provided by distributions. * There is no longer a Bluetooth shortcut in Places (eg. in Dolphin sidebar). The shortcut was moved into Network view (remote:/). * Connected devices with ObexFTP (Browse Files) support are now displayed in Places. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123284: Create breeze shadows unconditionally
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- Breeze checks if shadows are supported by checking for a property on the root window. This is set by kwin at some point after startup. This leaves a gap for apps/plasmashell to start, determine shadows are not supported and then never render them for the lifespan of that app. It also can't handle window managers being replaced. I spoke to Martin Grasslin who suggested just enabling shadows regardless, it's not a lot of overhead to load one set of pixmaps even if we don't end up using it. The alternative is waking up every app every time the root windows prop changes, which is arguably worse longterm. Diffs - kstyle/breezeshadowhelper.h d1be0dc kstyle/breezeshadowhelper.cpp 2475076 Diff: https://git.reviewboard.kde.org/r/123284/diff/ Testing --- Logged out and logged back in a lot, plasma always got shadows. Same for session restored apps. started dolphin under openbox, switched to kwin, shadows \o/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123284: Create breeze shadows unconditionally
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/ --- (Updated April 7, 2015, 3:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Hugo Pereira Da Costa. Changes --- Submitted with commit 9f752a50102d0a310496ff7dc2f04111fb09a519 by David Edmundson to branch master. Repository: breeze Description --- Breeze checks if shadows are supported by checking for a property on the root window. This is set by kwin at some point after startup. This leaves a gap for apps/plasmashell to start, determine shadows are not supported and then never render them for the lifespan of that app. It also can't handle window managers being replaced. I spoke to Martin Grasslin who suggested just enabling shadows regardless, it's not a lot of overhead to load one set of pixmaps even if we don't end up using it. The alternative is waking up every app every time the root windows prop changes, which is arguably worse longterm. Diffs - kstyle/breezeshadowhelper.h d1be0dc kstyle/breezeshadowhelper.cpp 2475076 Diff: https://git.reviewboard.kde.org/r/123284/diff/ Testing --- Logged out and logged back in a lot, plasma always got shadows. Same for session restored apps. started dolphin under openbox, switched to kwin, shadows \o/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 p.m., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? set the default to true in the xml file? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 3:19 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123283: Remove interesting ksmserver easter egg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123283/ --- (Updated April 7, 2015, 4:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Lukáš Tinkl. Changes --- Submitted with commit ea56983315378a431324b0ca6baeff1890b7a3d2 by David Edmundson to branch master. Repository: plasma-workspace Description --- KSMSERVER_STARTUP_DEBUGl is not defined, meaning this code currently exists in all our ksmservers. if you have 2 instances of gedit, konqueror and kspaceduel open in the right order on session restore you get an error message saying drat. I'm not sure what benefit this is to society, but I'm sure it was important. This feature is now obsolete as kspaceduel doesn't exist any more and would require more effort to trigger Diffs - ksmserver/startup.cpp 6010eff Diff: https://git.reviewboard.kde.org/r/123283/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 29 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line29 What is that invisible (flat and no title) GroupBox for? copycat is to be blamed (took it like that from another plasmoid iirc) :) On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 3:19 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? David Edmundson wrote: set the default to true in the xml file? I ment if some users had already used the property hideSeconds and we are changing the config-key to showSeconds then they will have to configure it again. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 3:19 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123284: Create breeze shadows unconditionally
On April 7, 2015, 3:38 p.m., Hugo Pereira Da Costa wrote: Sounds good. Bye bye fancy Xcb code. Same goes for oxygen I guess :) well, you still have xcb code just below to actaully upload the shadows. Now you have that awkward situation where you say goodbye to someone and then have to spend longer with them... Yes, I'll copy into oxygen too. It's just a 1-1 patch. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/#review78634 --- On April 7, 2015, 3:31 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/ --- (Updated April 7, 2015, 3:31 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- Breeze checks if shadows are supported by checking for a property on the root window. This is set by kwin at some point after startup. This leaves a gap for apps/plasmashell to start, determine shadows are not supported and then never render them for the lifespan of that app. It also can't handle window managers being replaced. I spoke to Martin Grasslin who suggested just enabling shadows regardless, it's not a lot of overhead to load one set of pixmaps even if we don't end up using it. The alternative is waking up every app every time the root windows prop changes, which is arguably worse longterm. Diffs - kstyle/breezeshadowhelper.h d1be0dc kstyle/breezeshadowhelper.cpp 2475076 Diff: https://git.reviewboard.kde.org/r/123284/diff/ Testing --- Logged out and logged back in a lot, plasma always got shadows. Same for session restored apps. started dolphin under openbox, switched to kwin, shadows \o/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:16 nachm.) Review request for Plasma. Changes --- Implemented suggestions from David Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs (updated) - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments (updated) Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78631 --- applets/timer/package/contents/ui/configAppearance.qml (line 25) https://git.reviewboard.kde.org/r/123274/#comment53803 removed already locally - Bernhard Friedreich On April 7, 2015, 3:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:16 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
On April 7, 2015, 1:50 nachm., Lukáš Tinkl wrote: Modules/energy/package/contents/ui/main.qml, line 97 https://git.reviewboard.kde.org/r/123282/diff/1/?file=360362#file360362line97 What about multiple batteries? That's just so it initially shows the first battery. When you have multiple the currentBattery value is set in the tab bar - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78622 --- On April 7, 2015, 1:37 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated April 7, 2015, 1:37 nachm.) Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated April 7, 2015, 7:08 p.m.) Review request for Plasma. Repository: plasmate Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments (updated) kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png kconfig_xt_editor_document.png https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/fb1f6bb9-7af5-4ec5-980a-b6ee75588fc7__kconfig_xt_editor_document.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
On March 25, 2015, 1:59 a.m., Aleix Pol Gonzalez wrote: Is it all in now? Maybe an updated screenshot would help? Anyway, I trust your judgement if you want to ship this. The KConfigXt doesn't exist anymore in the toolviews. I have added an image in which I do 1. Click in the Configuration XML file 2. the KconfigXt document opens. - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/#review78034 --- On March 24, 2015, 9:38 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated March 24, 2015, 9:38 p.m.) Review request for Plasma. Repository: plasmate Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
On April 7, 2015, 1:45 nachm., Aleix Pol Gonzalez wrote: kcmcontainer.cpp, line 62 https://git.reviewboard.kde.org/r/123282/diff/1/?file=360371#file360371line62 unrelated? Ah yeah, that is to make the headings in KInfoCenter match the new KTitleWidget style, should go in separately On April 7, 2015, 1:45 nachm., Aleix Pol Gonzalez wrote: Modules/energy/package/contents/ui/main.qml, line 384 https://git.reviewboard.kde.org/r/123282/diff/1/?file=360362#file360362line384 What do we need to have there? That's a separator line. However with Qt high dpi stuff we could probably hardcode 1px then, or use Screen.something magic On April 7, 2015, 1:45 nachm., Aleix Pol Gonzalez wrote: Modules/energy/statisticsprovider.cpp, line 183 https://git.reviewboard.kde.org/r/123282/diff/1/?file=360365#file360365line183 Looks quite big for a lambda, make it a method? I prefer having async DBus stuff in one place as if it were sync. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78621 --- On April 7, 2015, 1:37 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated April 7, 2015, 1:37 nachm.) Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123274/#review78632
---
A bunch of pedantic comments below
applets/timer/package/contents/config/config.qml (line 32)
https://git.reviewboard.kde.org/r/123274/#comment53804
Rather use preferences-other
applets/timer/package/contents/ui/configAdvanced.qml (line 42)
https://git.reviewboard.kde.org/r/123274/#comment53805
Execute command (the checkbox already determins 'enabled'), or Execute
the following command: and then you can save the next label (dunno about HIG
here)
applets/timer/package/contents/ui/configAdvanced.qml (line 51)
https://git.reviewboard.kde.org/r/123274/#comment53806
Put the id property first
applets/timer/package/contents/ui/configAppearance.qml (line 29)
https://git.reviewboard.kde.org/r/123274/#comment53807
What is that invisible (flat and no title) GroupBox for?
applets/timer/package/contents/ui/configAppearance.qml (line 43)
https://git.reviewboard.kde.org/r/123274/#comment53808
HIG says Checkboxes should always be positive, ie. Show seconds and then
enable it by default instead; also makes it consistent with the other one
applets/timer/package/contents/ui/timer.qml (lines 51 - 53)
https://git.reviewboard.kde.org/r/123274/#comment53816
You could just make that a singleton type
applets/timer/plugin/timer.h (line 25)
https://git.reviewboard.kde.org/r/123274/#comment53810
{ goes on the next line:
class Foo
{
applets/timer/plugin/timer.h (line 28)
https://git.reviewboard.kde.org/r/123274/#comment53809
Don't indent public:
applets/timer/plugin/timer.h (line 29)
https://git.reviewboard.kde.org/r/123274/#comment53812
Prefer nullptr over 0
applets/timer/plugin/timer.h (line 31)
https://git.reviewboard.kde.org/r/123274/#comment53811
command instead of exe?
applets/timer/plugin/timer.cpp (lines 24 - 25)
https://git.reviewboard.kde.org/r/123274/#comment53813
Braces go on the next line
applets/timer/plugin/timer.cpp (line 27)
https://git.reviewboard.kde.org/r/123274/#comment53814
Braces go on the next line
applets/timer/plugin/timerplugin.h (line 22)
https://git.reviewboard.kde.org/r/123274/#comment53815
That one seems unused
- Kai Uwe Broulik
On April 7, 2015, 3:19 nachm., Bernhard Friedreich wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123274/
---
(Updated April 7, 2015, 3:19 nachm.)
Review request for Plasma.
Repository: kdeplasma-addons
Description
---
Added tab General and Appearance in the config ui
General contains the bits about command execution after the timer has
completed
Appearance contains the ability to hide seconds and showing the title
The configuration option for showing the title is a bit buggy (again)
This bugreport explains the wrong scaling of the title: 304923
I've converted this plasmoid from being qml only to c++ and qml because it
looks like KProcess has no qml interface yet (and I didn't find any place
where to start)
[Edit 1]: updated to use QProcess
[Edit 2]: renamed General to Advanced and moved it down to make Appearance
the default tab on opening
[Edit 3]: updated layers in the config ui and make the command textfield
depend upon the checkbox
Diffs
-
applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f
applets/timer/package/contents/config/config.qml PRE-CREATION
applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION
applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION
applets/timer/package/contents/ui/timer.qml
f675b93bda59eb161fe10b5f575eaa2082b822e0
applets/timer/plugin/qmldir PRE-CREATION
applets/timer/plugin/timer.h PRE-CREATION
applets/timer/plugin/timer.cpp PRE-CREATION
applets/timer/plugin/timerplugin.h PRE-CREATION
applets/timer/plugin/timerplugin.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123274/diff/
Testing
---
Tested using plasmashell directly and using plasmoidviewer
File Attachments
Appearance Tab
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png
Advanced Tab
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png
Thanks,
Bernhard Friedreich
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123284: Create breeze shadows unconditionally
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/#review78634 --- Ship it! Sounds good. Bye bye fancy Xcb code. Same goes for oxygen I guess :) - Hugo Pereira Da Costa On April 7, 2015, 3:31 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/ --- (Updated April 7, 2015, 3:31 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- Breeze checks if shadows are supported by checking for a property on the root window. This is set by kwin at some point after startup. This leaves a gap for apps/plasmashell to start, determine shadows are not supported and then never render them for the lifespan of that app. It also can't handle window managers being replaced. I spoke to Martin Grasslin who suggested just enabling shadows regardless, it's not a lot of overhead to load one set of pixmaps even if we don't end up using it. The alternative is waking up every app every time the root windows prop changes, which is arguably worse longterm. Diffs - kstyle/breezeshadowhelper.h d1be0dc kstyle/breezeshadowhelper.cpp 2475076 Diff: https://git.reviewboard.kde.org/r/123284/diff/ Testing --- Logged out and logged back in a lot, plasma always got shadows. Same for session restored apps. started dolphin under openbox, switched to kwin, shadows \o/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123289/#review78645 --- Ship it! Ship It! - David Edmundson On April 7, 2015, 6:42 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123289/ --- (Updated April 7, 2015, 6:42 p.m.) Review request for Plasma, David Edmundson and Marco Martin. Bugs: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description --- We're interested only in local/users kdeglobals in this case. Diffs - misc/kde4breeze/src/main.cpp 361f965 Diff: https://git.reviewboard.kde.org/r/123289/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 p.m., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? David Edmundson wrote: set the default to true in the xml file? Bernhard Friedreich wrote: I ment if some users had already used the property hideSeconds and we are changing the config-key to showSeconds then they will have to configure it again. ah, if it's not been released then we don't care. In a hypothetical example where it was released, you would use kconf_update: https://techbase.kde.org/Development/Tools/Using_kconf_update - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 5:20 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 5:20 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? David Edmundson wrote: set the default to true in the xml file? Bernhard Friedreich wrote: I ment if some users had already used the property hideSeconds and we are changing the config-key to showSeconds then they will have to configure it again. David Edmundson wrote: ah, if it's not been released then we don't care. In a hypothetical example where it was released, you would use kconf_update: https://techbase.kde.org/Development/Tools/Using_kconf_update afaik it hasn't been released yet. I've already updated the last diff to reflect this change. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 5:20 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 5:20 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/ --- (Updated April 7, 2015, 6:50 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Changes --- Submitted with commit 1c56fb2195511f4a2e5ff6e94d70dafedb11657e by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- We only need to sync the changes to kde4 kdeglobals once users changes the defaults, hence only users KF5 kdeglobals need to be evaluated. This workarounds (though the change is IMO correct anyway) the kconfig bug, as we can otherwise pass both local and systemwide kdeglobals into copyTo method. Diffs - kcms/componentchooser/componentchooserbrowser.cpp f2b81ef kcms/componentchooser/componentchooserterminal.cpp be52334 kcms/input/mouse.cpp 69759bd Diff: https://git.reviewboard.kde.org/r/123288/diff/ Testing --- W/o the patch i had both BrowserApplication[$e]=chromium-browser.desktop (local adjustement) BrowserApplication=firefox.desktop (distro branding) in ~/.kde4/share/config/kdeglobals now i have only locally adjusted value Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 5:20 nachm.) Review request for Plasma. Changes --- Implemented suggestions by Kai Uwe Broulik. Thanks for the review :) Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs (updated) - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78643 --- Ship it! Ship It! - David Edmundson On April 7, 2015, 5:20 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 5:20 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123289/ --- Review request for Plasma, David Edmundson and Marco Martin. Bugs: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description --- We're interested only in local/users kdeglobals in this case. Diffs - misc/kde4breeze/src/main.cpp 361f965 Diff: https://git.reviewboard.kde.org/r/123289/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
Hi, a lot of fancy new stuff in the power management department, most notably: - Activity config returned, allowing to configure power management settings differently for certain activities - Laptop will not suspend when closing the lid while an external monitor is connected (cinema mode, by default, can be turned off) - PM inhibitions now block lock screen too (Lukas implemented) - Screen brightness changes are now animated on certain hardware (those supporting it via XRandR, the sysfs helper is too fragile) - No longer suspends when eg. closing the lid while shutting down - Support for keyboard brightness (as well as screen but that I didn't do ;) controls on lock screen - Energy kcm (thanks to David for help and Marco for the underlying QML KCM infrastructure) providing statistics about energy consumption etc Plasma: - Minor UI changes in battery monitor (now has config button in the plasmoid, will also link to energy kcm in the future I suppose; no longer shows percentage for brightness; now explains unchecking enable PM means; no longer lets you completely turn off backlight on certain hardware) - Battery monitor now shows which applications are currently holding a PM inhibition (Chrome is currently suppressing PM: Playing video) and also shows when the laptop won't suspend because external screen (s.a.) - Various usability (keyboard navigation) and performance (Animators) improvements all over the place (toolbox, widget explorer, kickoff, klipper, ..) - Various fixes for notes applet (is now proper textarea with context menu, formatting buttons no longer leak outside etc) Cheers, Kai Uwe ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/#review78644 --- Ship it! Ship It! - David Edmundson On April 7, 2015, 6:39 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/ --- (Updated April 7, 2015, 6:39 p.m.) Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Repository: plasma-desktop Description --- We only need to sync the changes to kde4 kdeglobals once users changes the defaults, hence only users KF5 kdeglobals need to be evaluated. This workarounds (though the change is IMO correct anyway) the kconfig bug, as we can otherwise pass both local and systemwide kdeglobals into copyTo method. Diffs - kcms/componentchooser/componentchooserbrowser.cpp f2b81ef kcms/componentchooser/componentchooserterminal.cpp be52334 kcms/input/mouse.cpp 69759bd Diff: https://git.reviewboard.kde.org/r/123288/diff/ Testing --- W/o the patch i had both BrowserApplication[$e]=chromium-browser.desktop (local adjustement) BrowserApplication=firefox.desktop (distro branding) in ~/.kde4/share/config/kdeglobals now i have only locally adjusted value Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasmashell] [Bug 345940] Move Enable Power Management checkbox to the top as other applets
https://bugs.kde.org/show_bug.cgi?id=345940 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added Product|Powerdevil |plasmashell Assignee|plasma-devel@kde.org|k...@privat.broulik.de Version|unspecified |master Target Milestone|--- |1.0 CC||plasma-b...@kde.org Component|general |Battery Monitor -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123289/ --- (Updated April 7, 2015, 7:16 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson and Marco Martin. Changes --- Submitted with commit 7272e6914ef9b756bbbeb132b63a4e39a79f11e9 by Hrvoje Senjan to branch master. Bugs: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description --- We're interested only in local/users kdeglobals in this case. Diffs - misc/kde4breeze/src/main.cpp 361f965 Diff: https://git.reviewboard.kde.org/r/123289/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: applets/kickoff/package/contents/ui/CompactRepresentation.qml, line 28 https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line28 readonly property The user could change the edge and then the property would also change. - Mathias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78604 --- On April 6, 2015, 11:40 vorm., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 11:40 vorm.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) Thomas Lübking wrote: When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) Martin Gräßlin wrote: Maybe something like showingdesktophelper? Thomas Lübking wrote: I'll read that as a joke? =) Window Aperture? Everybody else: feel free to suggest a nice, striking or stupid name. Thomas Lübking wrote: Ok, final threat :-) I'll push this tonight to underrun the 5.3 freeze. The name *will* be Bad, Bad, Windows =) If you want another name (decide! helper is no option), removal of one of the effects or point out remaining wishes, glitches, etc.: please SHOUT! Marco Martin wrote: +1 for merging +I would be ok with Window Aperture, Desktop Dashboard, Show Desktop.. a bit less with bad bad windows ;) Went for Window Aperture Personally I strongly object generic names (eg. Window Adding [Helper] could be fade or scale or a dozen other animations ;-) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On April 7, 2015, 10:30 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 7, 2015, 10:30 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: What when I place it on the desktop? I'd like it to fill the entire room there. If I want a massive Kickoff button on my desktop, that's up to me :) Martin Klapetek wrote: +1; it should really be iff vertical == true This patch adds a compact representation, so it only affects the panel. On the desktop, you can still make it as big as you want :) - Mathias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78604 --- On April 6, 2015, 11:40 vorm., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 11:40 vorm.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 9:08 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 57aeac6278d8085b481850d62eb2f2ad8109a316 by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 7, 2015, 9:56 nachm.) Review request for Plasma. Changes --- fixed issues Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs (updated) - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
On Wed, Apr 8, 2015 at 12:15 AM, Martin Steigerwald mar...@lichtvoll.de wrote: Wow, okay. I thought you removed mail indexing from Baloo as Akonadi developers wanted to integrate it with Akonadi directly and I thought that work wasn´t yet completed. I mean mail search over Alt-F2, but also quick search bar in KMail which works really nice in KDE SC 4.14 with Baloo as mail index. Slightly long answer - Baloo in Qt4 contained a separate file index, email index, contact index and calendar index. Baloo in Qt5 only does file searching. The email, contact, and calender searching parts were put in a repo called akonadi-search. Some parts of akonadi-search require Akonadi-Qt5 (namely the indexer), the actual searching parts do not require it as they are just light wrappers over xapian. So one can theoretically write a runner for Plasma 5 without requiring Akonadi-Qt5. In Akonad-Next, search will be properly integrated, and Baloo will play no role. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 7, 2015, 12:59 nachm., Sebastian Kügler wrote: So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent. I agree that a huge button may not be what the user wants, but then what's huge? Your patch seems to work incidentally, since you have a typo in the code which essentially invalidates the preferred size. I'd like to see a better thought-through solution for this, as such, I don't find this patch acceptable. Marco Martin wrote: also, it shouldn't have a behavior inconsistent with every other popupapplet icon The size is also limited in the horizontal panel and centered. I don't know if this was also the case in plasma 1, but at least on the vertical panel the size was limited. Like I said in a previous commit, this restores the behaviour from plasma 1 on a vertical panel. I just noticed, that the icons from e.g. the task list and the system tray change with the selected font size. Would this also be an option for the kickoff icon? If yes, how can I access this size? What do you mean with popupapplet? Keep in mind, I'm not a plasma developer, so it might not be obvious for me. - Mathias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78617 --- On April 6, 2015, 11:40 vorm., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 11:40 vorm.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint this Weekend
Am Dienstag, 7. April 2015, 16:37:45 schrieb Vishesh Handa: On Tue, Apr 7, 2015 at 12:44 PM, Martin Steigerwald mar...@lichtvoll.de wrote: I wonder about the mail indexing and search. Its still not available in Plasma 5, isn´t it? (Still on 4.14.6/7 and Akonadi 1.13). I'm assuming you're talking about KRunner? We can search through the email index from Qt5. We do not need any Akonadi specific apis. I just haven't bothered writing the runner and doing it. Wow, okay. I thought you removed mail indexing from Baloo as Akonadi developers wanted to integrate it with Akonadi directly and I thought that work wasn´t yet completed. I mean mail search over Alt-F2, but also quick search bar in KMail which works really nice in KDE SC 4.14 with Baloo as mail index. -- Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 7, 2015, 10:30 p.m.) Status -- This change has been marked as submitted. Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Changes --- Submitted with commit d94f3c85775eced122820960d6516dc6ddd7a048 by Thomas Lübking to branch master. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial,
Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/#review78653 --- Please make sure to use the bug field in reviewboard and CCBUG when committing changes related to bugs. It makes things much simpler to track afterwards. - Aleix Pol Gonzalez On April 7, 2015, 8:50 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/ --- (Updated April 7, 2015, 8:50 p.m.) Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Repository: plasma-desktop Description --- We only need to sync the changes to kde4 kdeglobals once users changes the defaults, hence only users KF5 kdeglobals need to be evaluated. This workarounds (though the change is IMO correct anyway) the kconfig bug, as we can otherwise pass both local and systemwide kdeglobals into copyTo method. Diffs - kcms/componentchooser/componentchooserbrowser.cpp f2b81ef kcms/componentchooser/componentchooserterminal.cpp be52334 kcms/input/mouse.cpp 69759bd Diff: https://git.reviewboard.kde.org/r/123288/diff/ Testing --- W/o the patch i had both BrowserApplication[$e]=chromium-browser.desktop (local adjustement) BrowserApplication=firefox.desktop (distro branding) in ~/.kde4/share/config/kdeglobals now i have only locally adjusted value Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123290: Port task manager away from mouse event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123290/#review78654 --- Bug 339482 - Kai Uwe Broulik On April 8, 2015, 4:04 vorm., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123290/ --- (Updated April 8, 2015, 4:04 vorm.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- For some reason, MouseEventListener exists because mousearea in qml 1.0 doesn't handle wheel event. Now seems it's fine to use Qt5's MouseArea. And it will handle my touch screen event properly. MouseEventListener doesn't call onReleased on my touch screen. Diffs - applets/taskmanager/package/contents/ui/MouseHandler.qml bbe573e applets/taskmanager/package/contents/ui/Task.qml 49afaae Diff: https://git.reviewboard.kde.org/r/123290/diff/ Testing --- Works like old one. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: What when I place it on the desktop? I'd like it to fill the entire room there. If I want a massive Kickoff button on my desktop, that's up to me :) Martin Klapetek wrote: +1; it should really be iff vertical == true Mathias Kraus wrote: This patch adds a compact representation, so it only affects the panel. On the desktop, you can still make it as big as you want :) Compact representation is shown whenever the applet's size goes below the switch size, be it because it's in a panel, or because you placed it on the desktop in a small size; also an applet may choose to always collapse On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: applets/kickoff/package/contents/ui/CompactRepresentation.qml, line 28 https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line28 readonly property Mathias Kraus wrote: The user could change the edge and then the property would also change. Read-only just means that you cannot manually assign a new value to the property potentially allowing some micro-optimization by the engine, when one the values referenced by it change it would still update - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78604 --- On April 7, 2015, 9:56 nachm., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 7, 2015, 9:56 nachm.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123290: Port task manager away from mouse event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123290/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- For some reason, MouseEventListener exists because mousearea in qml 1.0 doesn't handle wheel event. Now seems it's fine to use Qt5's MouseArea. And it will handle my touch screen event properly. MouseEventListener doesn't call onReleased on my touch screen. Diffs - applets/taskmanager/package/contents/ui/MouseHandler.qml bbe573e applets/taskmanager/package/contents/ui/Task.qml 49afaae Diff: https://git.reviewboard.kde.org/r/123290/diff/ Testing --- Works like old one. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123290: Port task manager away from mouse event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123290/ --- (Updated April 8, 2015, 5:57 a.m.) Review request for Plasma and Eike Hein. Bugs: 339482 https://bugs.kde.org/show_bug.cgi?id=339482 Repository: plasma-desktop Description --- For some reason, MouseEventListener exists because mousearea in qml 1.0 doesn't handle wheel event. Now seems it's fine to use Qt5's MouseArea. And it will handle my touch screen event properly. MouseEventListener doesn't call onReleased on my touch screen. Diffs - applets/taskmanager/package/contents/ui/MouseHandler.qml bbe573e applets/taskmanager/package/contents/ui/Task.qml 49afaae Diff: https://git.reviewboard.kde.org/r/123290/diff/ Testing --- Works like old one. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
