Re: Review Request 125114: Add dedicated destructor requests to blur and contrast interface

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125114/#review85041
---

Ship it!


Ship It!

- Marco Martin


On Sept. 9, 2015, 7:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125114/
> ---
> 
> (Updated Sept. 9, 2015, 7:42 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> Better resource management.
> 
> 
> Diffs
> -
> 
>   src/client/protocols/blur.xml 2a1c004bf1b219be642f675b834f67becaf22cfa 
>   src/client/contrast.cpp 90afac0a29f28000e52ba0b7531f5d48e0351fe0 
>   src/client/blur.cpp bfccc85b1936d0b67e316bc2f4e71d113fe44ad5 
>   src/server/blur_interface.cpp cdca04e6fe64e96e8f7e3c550b0adc41da358b1f 
>   src/client/protocols/contrast.xml a9105175debd01a4b3e6acf190e1c557ae8f22ad 
>   src/server/contrast_interface.cpp b38290e56739439b4cd8ebbdcb43e31ae37721e4 
> 
> Diff: https://git.reviewboard.kde.org/r/125114/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125111: Change system settings toolbar

[Marco Martin]

> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote:
> > +1 for the icon change, but I dunno, "Help" not being the last thing looks 
> > strange...?
> 
> andreas kainz wrote:
> Hi the help icon was changed yesterday in master (by me without 
> reviewboard) so help use the right icon.
> 
> Martin Klapetek wrote:
> I have no problem with the Help icon, I just think that Help button being 
> before Configure is strange.
> 
> Fwiw, in Dolphin, the Configure is a menu which also has the Help inside, 
> here it is a dialog. So I'm not entirely sure that this change makes sense. 
> ...add usability?

in Dolphin in "Control": in that case would make sense to stuff also the help 
button in it, while Configure->help would make no sense


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125111/#review85030
---


On Sept. 8, 2015, 10:59 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125111/
> ---
> 
> (Updated Sept. 8, 2015, 10:59 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> Move configure to right to match dolphin, remove somewhat non-standard quit 
> button.
> 
> As requested by Andreas Kainz from VDG
> 
> 
> Diffs
> -
> 
>   app/SettingsBase.cpp 16018e45efe603b2f24f15017d1872838cc9f31e 
>   app/systemsettingsui.rc e5ba899bf19bad5c3f8b92263a13015c7bd85f32 
> 
> Diff: https://git.reviewboard.kde.org/r/125111/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot_TJ1820.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/08/1b07d64d-799f-4a2d-88ff-b006bbc3dd49__snapshot_TJ1820.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 352462] New: PowerDevilUPowerBackend makes unconditional call to xrandr extension

[Thomas Lübking]

https://bugs.kde.org/show_bug.cgi?id=352462

Bug ID: 352462
   Summary: PowerDevilUPowerBackend makes unconditional call to
xrandr extension
   Product: Powerdevil
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: thomas.luebk...@gmail.com

xcb_randr_query_version isn't legal either.
This causes kded to crash if the randr extensio isn't available (usually
xinerama setups)
See bug #343844

generic test:

xcb_prefetch_extension_data(connection, _randr_id);
xcb_query_extension_reply_t *extension = xcb_get_extension_data(connection,
_randr_id);
m_randr_available = extension && extension->present;

---

Backtrace:

> Breakpoint 9, 0x7f1d239b82d0 in xcb_randr_query_version@plt () from
> /usr/lib/qt/plugins/kded_powerdevil.so
> (gdb) thread apply all bt 100
> 
> Thread 2 (Thread 0x7f1d2a1c7700 (LWP 18058)):
> #0  0x7f1d3fdf618d in poll () from /usr/lib/libc.so.6
> #1  0x7f1d3f2e99f2 in ?? () from /usr/lib/libxcb.so.1
> #2  0x7f1d3f2eb56f in xcb_wait_for_event () from /usr/lib/libxcb.so.1
> #3  0x7f1d2c52fca9 in ?? () from /usr/lib/libQt5XcbQpa.so.5
> #4  0x7f1d40174a9e in ?? () from /usr/lib/libQt5Core.so.5
> #5  0x7f1d3d7344a4 in start_thread () from /usr/lib/libpthread.so.0
> #6  0x7f1d3fdff13d in clone () from /usr/lib/libc.so.6
> 
> Thread 1 (Thread 0x7f1d41a3b800 (LWP 18052)):
> #0  0x7f1d239b82d0 in xcb_randr_query_version@plt () from
> /usr/lib/qt/plugins/kded_powerdevil.so
> #1  0x7f1d239cd15f in ?? () from /usr/lib/qt/plugins/kded_powerdevil.so
> #2  0x7f1d239c4553 in PowerDevilUPowerBackend::init() () from
> /usr/lib/qt/plugins/kded_powerdevil.so
> #3  0x7f1d2377b747 in
> PowerDevil::Core::loadCore(PowerDevil::BackendInterface*) () from
> /usr/lib/libpowerdevilcore.so.2
> #4  0x7f1d239b994f in ?? () from /usr/lib/qt/plugins/kded_powerdevil.so
> #5  0x7f1d40384eb1 in QObject::event(QEvent*) () from
> /usr/lib/libQt5Core.so.5
> #6  0x7f1d3e9a300c in QApplicationPrivate::notify_helper(QObject*,
> QEvent*) () from /usr/lib/libQt5Widgets.so.5
> #7  0x7f1d3e9a84e6 in QApplication::notify(QObject*, QEvent*) () from
> /usr/lib/libQt5Widgets.so.5
> #8  0x7f1d4035589b in QCoreApplication::notifyInternal(QObject*,
> QEvent*) () from /usr/lib/libQt5Core.so.5
> #9  0x7f1d40357c96 in
> QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) ()
> from /usr/lib/libQt5Core.so.5
> #10 0x7f1d403abe33 in ?? () from /usr/lib/libQt5Core.so.5
> #11 0x7f1d3ca099fd in g_main_context_dispatch () from
> /usr/lib/libglib-2.0.so.0
> #12 0x7f1d3ca09ce0 in ?? () from /usr/lib/libglib-2.0.so.0
> #13 0x7f1d3ca09d8c in g_main_context_iteration () from
> /usr/lib/libglib-2.0.so.0
> #14 0x7f1d403ac23f in
> QEventDispatcherGlib::processEvents(QFlags)
> () from /usr/lib/libQt5Core.so.5
> #15 0x7f1d4035326a in
> QEventLoop::exec(QFlags) () from
> /usr/lib/libQt5Core.so.5
> #16 0x7f1d4035b20c in QCoreApplication::exec() () from
> /usr/lib/libQt5Core.so.5
> #17 0x7f1d2c9efb64 in kdemain () from /usr/lib/libkdeinit5_kded5.so
> #18 0x0040856a in ?? ()
> #19 0x0040585f in main ()
> (gdb) continue
> 
> Breakpoint 19, 0x7f1d239b8d40 in xcb_randr_query_version_reply@plt ()
> from /usr/lib/qt/plugins/kded_powerdevil.so
> (gdb) continue
> Continuing.
> [Thread 0x7f1d2a1c7700 (LWP 18058) exited]
> [New Thread 0x7f1d2a1c7700 (LWP 18229)]
> warning: Temporarily disabling breakpoints for unloaded shared library
> "/usr/lib/libQt5XcbQpa.so.5"
> [Thread 0x7f1d41a3b800 (LWP 18052) exited]
> [Inferior 1 (process 18052) exited with code 01]
> (gdb) 
> 

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125113: [startkde] Generate absolute path to ksmserver

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125113/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

On my system I faced the problem that instead of my prefix installed
ksmserver, the system installed ksmserver was started by kwrapper5.


Diffs
-

  startkde/startkde.cmake cfbe227177d56d26acaa81b51d79ec63d1c9ffa6 
  startkde/startplasma.cmake 2db87bb6ecbda85fc040c00a9e0bfc0229950abd 

Diff: https://git.reviewboard.kde.org/r/125113/diff/


Testing
---

Screenlocker was broken before, now it works.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

[Martin Gräßlin]

> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote:
> > Hold it.
> > 
> > Implementationwise, this looks wonky - if it's possible to get unbalanced 
> > input events (ie. releases w/o ever a press or vv.) from the system since 
> > the counter will run out of sync.
> > 
> > => Are such unbalanced events prevented by libinput for sure or can one eg. 
> > create synthetic release events (w/o a synthetic press event)?
> 
> Martin Gräßlin wrote:
> libinput does not (to my knowledge) allow synthetic release events. 
> Though there might be a danger with vt switching (that probably needs more 
> testing)
> 
> Thomas Lübking wrote:
> i'd also worry about event compression, eg. when releasing key & modifier 
> "simultanously" one might get only one release event?
> 
> better safe than sorry and go for a midifier comparism and kill flag?
> 
> Martin Gräßlin wrote:
> No libinput doesn't do that, but I agree on the better safe than sorry 
> aspect. Will update.
> 
> Martin Gräßlin wrote:
> Actually it doesn't matter. If we get unbalanced input events we have a 
> bigger problem with xkb_state_update_key which is documented with a warning 
> that missed input events can result in stuck modifiers. As that call is just 
> above, we either have a huge issue anyway or it works.

Just did some testing with vt switching and it looks like this doesn't get xkb 
into an inconsistent state -> all fine I assume


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124954/#review84959
---


On Aug. 27, 2015, 6:04 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124954/
> ---
> 
> (Updated Aug. 27, 2015, 6:04 p.m.)
> 
> 
> Review request for kwin, Plasma and Hans Chen.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> On popular demand!
> 
> This change tracks how modifiers are used and detects a modifier only
> key press/release. That is:
> * no other key is pressed when the modifier gets pressed
> * no other key gets pressed before the modifier gets released
> 
> If such a press/release is detected, we call a configurable dbus call.
> The possible shortcuts can be configured in kwinrc, group
> "ModifierOnlyShortcuts". The following keys are supported:
> * Shift
> * Control
> * Alt
> * Meta
> 
> As value it takes a QStringList (comma seperated string) with
> service,path,interface,method,additionalargs
> 
> E.g. to invoke Desktop Grid effect on Meta key:
> 
> [ModifierOnlyShortcuts]
> Meta=org.kde.kglobalaccel,/component/kwin/,org.kde.kglobalaccel.Component,invokeShortcut,ShowDesktopGrid
> 
> I do not intend to add a config interface for it. Let's keep it a hidden
> way.
> 
> 
> Diffs
> -
> 
>   input.h cfb693dc06a18ea9ca7cffb99b9a1318ee443e3a 
>   input.cpp 92724d7b7559dd460a8f5fbe17deb3c72024eed6 
>   options.h 07c5193e3bd205c5c8c22a305f4c1d87e16d175f 
>   options.cpp 64269d64bc49640bf2e4e925ce1969f2a5d6b96b 
> 
> Diff: https://git.reviewboard.kde.org/r/124954/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125113: [startkde] Generate absolute path to ksmserver

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125113/#review85042
---

Ship it!


Ship It!

- Marco Martin


On Sept. 9, 2015, 6:57 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125113/
> ---
> 
> (Updated Sept. 9, 2015, 6:57 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> On my system I faced the problem that instead of my prefix installed
> ksmserver, the system installed ksmserver was started by kwrapper5.
> 
> 
> Diffs
> -
> 
>   startkde/startkde.cmake cfbe227177d56d26acaa81b51d79ec63d1c9ffa6 
>   startkde/startplasma.cmake 2db87bb6ecbda85fc040c00a9e0bfc0229950abd 
> 
> Diff: https://git.reviewboard.kde.org/r/125113/diff/
> 
> 
> Testing
> ---
> 
> Screenlocker was broken before, now it works.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

[Thomas Lübking]

> On Sept. 7, 2015, 2:59 nachm., Thomas Lübking wrote:
> > Hold it.
> > 
> > Implementationwise, this looks wonky - if it's possible to get unbalanced 
> > input events (ie. releases w/o ever a press or vv.) from the system since 
> > the counter will run out of sync.
> > 
> > => Are such unbalanced events prevented by libinput for sure or can one eg. 
> > create synthetic release events (w/o a synthetic press event)?
> 
> Martin Gräßlin wrote:
> libinput does not (to my knowledge) allow synthetic release events. 
> Though there might be a danger with vt switching (that probably needs more 
> testing)
> 
> Thomas Lübking wrote:
> i'd also worry about event compression, eg. when releasing key & modifier 
> "simultanously" one might get only one release event?
> 
> better safe than sorry and go for a midifier comparism and kill flag?
> 
> Martin Gräßlin wrote:
> No libinput doesn't do that, but I agree on the better safe than sorry 
> aspect. Will update.
> 
> Martin Gräßlin wrote:
> Actually it doesn't matter. If we get unbalanced input events we have a 
> bigger problem with xkb_state_update_key which is documented with a warning 
> that missed input events can result in stuck modifiers. As that call is just 
> above, we either have a huge issue anyway or it works.
> 
> Martin Gräßlin wrote:
> Just did some testing with vt switching and it looks like this doesn't 
> get xkb into an inconsistent state -> all fine I assume

I assume states are globally cleared on VT changes.

Well, I'll remind you when we end up with stuck keys everywhere :-P


Eventually, one might require an IPC access to clear states, ie. count called 
ups and downs for every xkb_keycode_t and rewind them (to a certain level, ie. 
ensure shift is considered pressed #1) - if we get trouble here, we can hardly 
suggest to restart kwin to clear this.
And at least on the hardware level, things can fail easily (ie. a hanging key 
which generated no release event - you need to press-release it to get rid of 
that, ie. have -likely- seen one press too much. Thanks to wireless keyboards)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124954/#review84959
---


On Aug. 27, 2015, 4:04 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124954/
> ---
> 
> (Updated Aug. 27, 2015, 4:04 nachm.)
> 
> 
> Review request for kwin, Plasma and Hans Chen.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> On popular demand!
> 
> This change tracks how modifiers are used and detects a modifier only
> key press/release. That is:
> * no other key is pressed when the modifier gets pressed
> * no other key gets pressed before the modifier gets released
> 
> If such a press/release is detected, we call a configurable dbus call.
> The possible shortcuts can be configured in kwinrc, group
> "ModifierOnlyShortcuts". The following keys are supported:
> * Shift
> * Control
> * Alt
> * Meta
> 
> As value it takes a QStringList (comma seperated string) with
> service,path,interface,method,additionalargs
> 
> E.g. to invoke Desktop Grid effect on Meta key:
> 
> [ModifierOnlyShortcuts]
> Meta=org.kde.kglobalaccel,/component/kwin/,org.kde.kglobalaccel.Component,invokeShortcut,ShowDesktopGrid
> 
> I do not intend to add a config interface for it. Let's keep it a hidden
> way.
> 
> 
> Diffs
> -
> 
>   input.h cfb693dc06a18ea9ca7cffb99b9a1318ee443e3a 
>   input.cpp 92724d7b7559dd460a8f5fbe17deb3c72024eed6 
>   options.h 07c5193e3bd205c5c8c22a305f4c1d87e16d175f 
>   options.cpp 64269d64bc49640bf2e4e925ce1969f2a5d6b96b 
> 
> Diff: https://git.reviewboard.kde.org/r/124954/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125114: Add dedicated destructor requests to blur and contrast interface

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125114/
---

(Updated Sept. 9, 2015, 8:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Changes
---

Submitted with commit c0d7aeacbfdd636ba1af9fcb8bf2cb4a33030ab7 by Martin 
Gräßlin to branch master.


Repository: kwayland


Description
---

Better resource management.


Diffs
-

  src/client/protocols/blur.xml 2a1c004bf1b219be642f675b834f67becaf22cfa 
  src/client/contrast.cpp 90afac0a29f28000e52ba0b7531f5d48e0351fe0 
  src/client/blur.cpp bfccc85b1936d0b67e316bc2f4e71d113fe44ad5 
  src/server/blur_interface.cpp cdca04e6fe64e96e8f7e3c550b0adc41da358b1f 
  src/client/protocols/contrast.xml a9105175debd01a4b3e6acf190e1c557ae8f22ad 
  src/server/contrast_interface.cpp b38290e56739439b4cd8ebbdcb43e31ae37721e4 

Diff: https://git.reviewboard.kde.org/r/125114/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125113: [startkde] Generate absolute path to ksmserver

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125113/
---

(Updated Sept. 9, 2015, 8:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 13e8e8b85de5216bc87c1a274ae4e0dc69e7767e by Martin 
Gräßlin to branch master.


Repository: plasma-workspace


Description
---

On my system I faced the problem that instead of my prefix installed
ksmserver, the system installed ksmserver was started by kwrapper5.


Diffs
-

  startkde/startkde.cmake cfbe227177d56d26acaa81b51d79ec63d1c9ffa6 
  startkde/startplasma.cmake 2db87bb6ecbda85fc040c00a9e0bfc0229950abd 

Diff: https://git.reviewboard.kde.org/r/125113/diff/


Testing
---

Screenlocker was broken before, now it works.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125111: Change system settings toolbar

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125111/#review85039
---


+1 from here as well

- Marco Martin


On Sept. 8, 2015, 10:59 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125111/
> ---
> 
> (Updated Sept. 8, 2015, 10:59 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> Move configure to right to match dolphin, remove somewhat non-standard quit 
> button.
> 
> As requested by Andreas Kainz from VDG
> 
> 
> Diffs
> -
> 
>   app/SettingsBase.cpp 16018e45efe603b2f24f15017d1872838cc9f31e 
>   app/systemsettingsui.rc e5ba899bf19bad5c3f8b92263a13015c7bd85f32 
> 
> Diff: https://git.reviewboard.kde.org/r/125111/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot_TJ1820.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/08/1b07d64d-799f-4a2d-88ff-b006bbc3dd49__snapshot_TJ1820.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 352462] PowerDevilUPowerBackend makes unconditional call to xrandr extension

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=352462

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||k...@privat.broulik.de
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

[Martin Gräßlin]

> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote:
> > Hold it.
> > 
> > Implementationwise, this looks wonky - if it's possible to get unbalanced 
> > input events (ie. releases w/o ever a press or vv.) from the system since 
> > the counter will run out of sync.
> > 
> > => Are such unbalanced events prevented by libinput for sure or can one eg. 
> > create synthetic release events (w/o a synthetic press event)?
> 
> Martin Gräßlin wrote:
> libinput does not (to my knowledge) allow synthetic release events. 
> Though there might be a danger with vt switching (that probably needs more 
> testing)
> 
> Thomas Lübking wrote:
> i'd also worry about event compression, eg. when releasing key & modifier 
> "simultanously" one might get only one release event?
> 
> better safe than sorry and go for a midifier comparism and kill flag?
> 
> Martin Gräßlin wrote:
> No libinput doesn't do that, but I agree on the better safe than sorry 
> aspect. Will update.
> 
> Martin Gräßlin wrote:
> Actually it doesn't matter. If we get unbalanced input events we have a 
> bigger problem with xkb_state_update_key which is documented with a warning 
> that missed input events can result in stuck modifiers. As that call is just 
> above, we either have a huge issue anyway or it works.
> 
> Martin Gräßlin wrote:
> Just did some testing with vt switching and it looks like this doesn't 
> get xkb into an inconsistent state -> all fine I assume
> 
> Thomas Lübking wrote:
> I assume states are globally cleared on VT changes.
> 
> Well, I'll remind you when we end up with stuck keys everywhere :-P
> 
> 
> Eventually, one might require an IPC access to clear states, ie. count 
> called ups and downs for every xkb_keycode_t and rewind them (to a certain 
> level, ie. ensure shift is considered pressed #1) - if we get trouble here, 
> we can hardly suggest to restart kwin to clear this.
> And at least on the hardware level, things can fail easily (ie. a hanging 
> key which generated no release event - you need to press-release it to get 
> rid of that, ie. have -likely- seen one press too much. Thanks to wireless 
> keyboards)

> Well, I'll remind you when we end up with stuck keys everywhere

Please do ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124954/#review84959
---


On Aug. 27, 2015, 6:04 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124954/
> ---
> 
> (Updated Aug. 27, 2015, 6:04 p.m.)
> 
> 
> Review request for kwin, Plasma and Hans Chen.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> On popular demand!
> 
> This change tracks how modifiers are used and detects a modifier only
> key press/release. That is:
> * no other key is pressed when the modifier gets pressed
> * no other key gets pressed before the modifier gets released
> 
> If such a press/release is detected, we call a configurable dbus call.
> The possible shortcuts can be configured in kwinrc, group
> "ModifierOnlyShortcuts". The following keys are supported:
> * Shift
> * Control
> * Alt
> * Meta
> 
> As value it takes a QStringList (comma seperated string) with
> service,path,interface,method,additionalargs
> 
> E.g. to invoke Desktop Grid effect on Meta key:
> 
> [ModifierOnlyShortcuts]
> Meta=org.kde.kglobalaccel,/component/kwin/,org.kde.kglobalaccel.Component,invokeShortcut,ShowDesktopGrid
> 
> I do not intend to add a config interface for it. Let's keep it a hidden
> way.
> 
> 
> Diffs
> -
> 
>   input.h cfb693dc06a18ea9ca7cffb99b9a1318ee443e3a 
>   input.cpp 92724d7b7559dd460a8f5fbe17deb3c72024eed6 
>   options.h 07c5193e3bd205c5c8c22a305f4c1d87e16d175f 
>   options.cpp 64269d64bc49640bf2e4e925ce1969f2a5d6b96b 
> 
> Diff: https://git.reviewboard.kde.org/r/124954/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

[Martin Gräßlin]

> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote:
> > Hold it.
> > 
> > Implementationwise, this looks wonky - if it's possible to get unbalanced 
> > input events (ie. releases w/o ever a press or vv.) from the system since 
> > the counter will run out of sync.
> > 
> > => Are such unbalanced events prevented by libinput for sure or can one eg. 
> > create synthetic release events (w/o a synthetic press event)?
> 
> Martin Gräßlin wrote:
> libinput does not (to my knowledge) allow synthetic release events. 
> Though there might be a danger with vt switching (that probably needs more 
> testing)
> 
> Thomas Lübking wrote:
> i'd also worry about event compression, eg. when releasing key & modifier 
> "simultanously" one might get only one release event?
> 
> better safe than sorry and go for a midifier comparism and kill flag?
> 
> Martin Gräßlin wrote:
> No libinput doesn't do that, but I agree on the better safe than sorry 
> aspect. Will update.

Actually it doesn't matter. If we get unbalanced input events we have a bigger 
problem with xkb_state_update_key which is documented with a warning that 
missed input events can result in stuck modifiers. As that call is just above, 
we either have a huge issue anyway or it works.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124954/#review84959
---


On Aug. 27, 2015, 6:04 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124954/
> ---
> 
> (Updated Aug. 27, 2015, 6:04 p.m.)
> 
> 
> Review request for kwin, Plasma and Hans Chen.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> On popular demand!
> 
> This change tracks how modifiers are used and detects a modifier only
> key press/release. That is:
> * no other key is pressed when the modifier gets pressed
> * no other key gets pressed before the modifier gets released
> 
> If such a press/release is detected, we call a configurable dbus call.
> The possible shortcuts can be configured in kwinrc, group
> "ModifierOnlyShortcuts". The following keys are supported:
> * Shift
> * Control
> * Alt
> * Meta
> 
> As value it takes a QStringList (comma seperated string) with
> service,path,interface,method,additionalargs
> 
> E.g. to invoke Desktop Grid effect on Meta key:
> 
> [ModifierOnlyShortcuts]
> Meta=org.kde.kglobalaccel,/component/kwin/,org.kde.kglobalaccel.Component,invokeShortcut,ShowDesktopGrid
> 
> I do not intend to add a config interface for it. Let's keep it a hidden
> way.
> 
> 
> Diffs
> -
> 
>   input.h cfb693dc06a18ea9ca7cffb99b9a1318ee443e3a 
>   input.cpp 92724d7b7559dd460a8f5fbe17deb3c72024eed6 
>   options.h 07c5193e3bd205c5c8c22a305f4c1d87e16d175f 
>   options.cpp 64269d64bc49640bf2e4e925ce1969f2a5d6b96b 
> 
> Diff: https://git.reviewboard.kde.org/r/124954/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125114: Add dedicated destructor requests to blur and contrast interface

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125114/
---

Review request for Plasma and Marco Martin.


Repository: kwayland


Description
---

Better resource management.


Diffs
-

  src/client/protocols/blur.xml 2a1c004bf1b219be642f675b834f67becaf22cfa 
  src/client/contrast.cpp 90afac0a29f28000e52ba0b7531f5d48e0351fe0 
  src/client/blur.cpp bfccc85b1936d0b67e316bc2f4e71d113fe44ad5 
  src/server/blur_interface.cpp cdca04e6fe64e96e8f7e3c550b0adc41da358b1f 
  src/client/protocols/contrast.xml a9105175debd01a4b3e6acf190e1c557ae8f22ad 
  src/server/contrast_interface.cpp b38290e56739439b4cd8ebbdcb43e31ae37721e4 

Diff: https://git.reviewboard.kde.org/r/125114/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124954/
---

(Updated Sept. 9, 2015, 8:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for kwin, Plasma and Hans Chen.


Changes
---

Submitted with commit 07414e88a5dca8abe00e555b9ea94189b429a5c6 by Martin 
Gräßlin to branch master.


Repository: kwin


Description
---

On popular demand!

This change tracks how modifiers are used and detects a modifier only
key press/release. That is:
* no other key is pressed when the modifier gets pressed
* no other key gets pressed before the modifier gets released

If such a press/release is detected, we call a configurable dbus call.
The possible shortcuts can be configured in kwinrc, group
"ModifierOnlyShortcuts". The following keys are supported:
* Shift
* Control
* Alt
* Meta

As value it takes a QStringList (comma seperated string) with
service,path,interface,method,additionalargs

E.g. to invoke Desktop Grid effect on Meta key:

[ModifierOnlyShortcuts]
Meta=org.kde.kglobalaccel,/component/kwin/,org.kde.kglobalaccel.Component,invokeShortcut,ShowDesktopGrid

I do not intend to add a config interface for it. Let's keep it a hidden
way.


Diffs
-

  input.h cfb693dc06a18ea9ca7cffb99b9a1318ee443e3a 
  input.cpp 92724d7b7559dd460a8f5fbe17deb3c72024eed6 
  options.h 07c5193e3bd205c5c8c22a305f4c1d87e16d175f 
  options.cpp 64269d64bc49640bf2e4e925ce1969f2a5d6b96b 

Diff: https://git.reviewboard.kde.org/r/124954/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 352462] PowerDevilUPowerBackend makes unconditional call to xrandr extension

[Thomas Lübking]

https://bugs.kde.org/show_bug.cgi?id=352462

Thomas Lübking  changed:

   What|Removed |Added

 CC||ba...@grussling.com,
   ||berndamend+...@gmail.com
   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=343844

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124981: RFC: Move context menu out of panel

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124981/
---

(Updated Sept. 9, 2015, 8:36 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 3eccd9c8a4dd99f3ec36ea44a2d4331ae6ad6922 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

This is one thing that got lost in the transition from 4 to 5 is that context 
menus don't overlap the panel. The only place that still does that is the SNI 
but everything else just shows the context menu right at the cursor.


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 104581d 

Diff: https://git.reviewboard.kde.org/r/124981/diff/


Testing
---

Applet context menus in panels no longer overlap the panel, covering the applet 
I just clicked. I'm not sure about this approach; 4.x had a 
applet->popupPosition() which apparently did magic like Dialog does nowadays. 
Did not test with multiple monitors.

Also it needs adjustment in at least the panel context menu and task manager to 
provide a consistent feel.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125041: Move kaccess into separate source directory

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125041/
---

(Updated Sept. 9, 2015, 10:10 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 3631b2482a1bd279350becee081bcdd506ce8660 by Alexander 
Potashev to branch master.


Repository: plasma-desktop


Description
---

* kaccess does not belong to KCMs.
* This move also streamlines setting of separate translation domains for
kaccess and kcmaccess.


Diffs
-

  CMakeLists.txt e95b2926732ab0701aca7e75becb9a5652cd0283 
  kaccess/CMakeLists.txt PRE-CREATION 
  kaccess/Messages.sh PRE-CREATION 
  kcms/access/CMakeLists.txt e2f7c0d233111266584582ae60b39e21a80a45aa 
  kcms/access/Messages.sh b0167223aa30d8ea560a99a9d1c707ed03523677 
  kcms/access/kaccess.cpp  
  kcms/access/kaccess.desktop  
  kcms/access/kaccess.h  
  kcms/access/kaccess.notifyrc  
  kcms/access/main.cpp  

Diff: https://git.reviewboard.kde.org/r/125041/diff/


Testing
---


Thanks,

Alexander Potashev

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 171 - Aborted!

[no-reply]

GENERAL INFO

BUILD ABORTED
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/171/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 09 Sep 2015 10:10:54 +
Build duration: 5.5 sec

CHANGE SET
Revision 3631b2482a1bd279350becee081bcdd506ce8660 by Alexander Potashev: (Move 
kaccess into separate source directory)
  change: add kaccess/CMakeLists.txt
  change: edit CMakeLists.txt
  change: delete kcms/access/main.cpp
  change: add kaccess/main.cpp
  change: delete kcms/access/kaccess.notifyrc
  change: add kaccess/Messages.sh
  change: delete kcms/access/kaccess.cpp
  change: add kaccess/kaccess.desktop
  change: add kaccess/kaccess.cpp
  change: edit kcms/access/Messages.sh
  change: delete kcms/access/kaccess.desktop
  change: add kaccess/kaccess.notifyrc
  change: edit kcms/access/CMakeLists.txt
  change: delete kcms/access/kaccess.h
  change: add kaccess/kaccess.h
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 172 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/172/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 09 Sep 2015 11:40:47 +
Build duration: 7 min 43 sec

CHANGE SET
Revision f3b2ecfe0d287084fc1f5b2b74dc358ad4f60b25 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/keyboard/keyboard.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 
(70%)CONDITIONAL 1783/3079 (58%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 
(52%)CONDITIONAL 770/1268 (61%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
511/994 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125018: Support for Dpms

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125018/
---

(Updated Sept. 9, 2015, 3:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler.


Changes
---

Submitted with commit 1a463cd779ecc35afabf2a149d30d31da615ef43 by Martin 
Gräßlin to branch master.


Repository: kwayland


Description
---

Allows to retrieve the OutputInterface* for a given native wl_resource.
To support this we need to track the resources bound for each Output.

[server] Add a DpmsManagerInterface

Adding support for a org_kde_kwin_dpms interface. On server side
Dpms is mostly bound to the OutputInterface exposing just a very
small manager. Whether Dpms is supported and which mode is used is
tracked directly on the OutputInterface.

[client] Dpms protocol


[tests] Add an example for the Dpms interface

Uses QWidgets to render a very small UI.
* lists each Output
* for each output shows whether dpms is supported
* and which dpms mode it's in
* and provides a button to change the mode

[autotests] Extend tests for Dpms


Diffs
-

  autotests/client/test_wayland_output.cpp 
cb2892a18c58eb1ebb2482fc76243876b7ea26a7 
  autotests/client/test_wayland_registry.cpp 
53885d5907419cd541d08b79d65ba4a2f5d4aa2b 
  src/client/CMakeLists.txt 6c7a9c035e6e9c6ba7fc46aa90078bfc5e1401d6 
  src/client/dpms.h PRE-CREATION 
  src/client/dpms.cpp PRE-CREATION 
  src/client/protocols/dpms.xml PRE-CREATION 
  src/client/registry.h 30c9bcbcb91be885fadef1aabe6e9edf2aab56cc 
  src/client/registry.cpp 771cf53c2edb8044dad042f0e800b14c86f72cbd 
  src/server/CMakeLists.txt 73d6c83b815f664ed06b9c8467a87018c71eefbc 
  src/server/display.h e5f1ed58537f3a1042e2832b359a29b21aa8d9ad 
  src/server/display.cpp cfcc1fcede74b1030eed40ef18704584ac9fbe55 
  src/server/dpms_interface.h PRE-CREATION 
  src/server/dpms_interface.cpp PRE-CREATION 
  src/server/dpms_interface_p.h PRE-CREATION 
  src/server/output_interface.h 080ec7f7867795628f6ac243849d4ddd0c67e11a 
  src/server/output_interface.cpp ccf305d19a0b57cb5082d5e644c6bd83c0bfdd8d 
  tests/CMakeLists.txt 44712ece1a6a2d9566594fee910c711742c6ab01 
  tests/dpmstest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125018/diff/


Testing
---

See added test application.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125110: two small fixes for kwaylandScanner

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125110/
---

(Updated Sept. 9, 2015, 3:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for kwin, Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 7d2f54a4088011061e9fc3816d036ef278d2422f by Sebastian 
Kügler to branch master.


Repository: kwayland


Description
---

- fix initializer type -- was hardcoded, seems like an oversight
- add semicolons after class declarations -- one less thing to fix in the 
resulting code


Diffs
-

  src/tools/generator.cpp 47e1343 

Diff: https://git.reviewboard.kde.org/r/125110/diff/


Testing
---


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Martin Klapetek]

> On Sept. 9, 2015, 9:26 p.m., Martin Klapetek wrote:
> >
> 
> Martin Klapetek wrote:
> Btw. do you have commit access?
> 
> Raphael Kugelmann wrote:
> I haven't tried it yet.
> But I think I have no further access rights for the repo.
> 
> Raphael Kugelmann wrote:
> sorry for this annoying question.
> How does this commit work. Is it possible to do it via ChangeBoard or 
> only via git?
> 
> Raphael Kugelmann wrote:
> a "git push" results into access denied, so I think I haven't commit 
> access.
> Can you please do the commit? Thanks!

Will do. Usually if you do couple good patches, you can request a developer 
account, so keep 'em coming ;)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/#review85064
---


On Sept. 9, 2015, 10:26 p.m., Raphael Kugelmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125063/
> ---
> 
> (Updated Sept. 9, 2015, 10:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors
> 
> 
> Diffs
> -
> 
>   gui/SensorDisplayLib/FancyPlotter.cpp 
> 6c2e8d14e0217c324845dc1b9b34481f3c6be34c 
> 
> Diff: https://git.reviewboard.kde.org/r/125063/diff/
> 
> 
> Testing
> ---
> 
> Fail test procedure:
> 1. create a FancyPlotter View with an Sensor
> 2. open the settings for this FancyPlotter view and goto Sensor Tab
> 3. add in the MainWindow (in the background) a new Sensor
> 4. Close the Setting window by pressing the OK button
> --> Crash
> 
> The Bugfix makes the mainwindow not editable while the settings dialog is 
> open.
> Therefore the written test above cannot be performed anymore.
> The Fail case cannot be reached anymore.
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125127: add discover to favorties

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125127/
---

Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Repository: plasma-desktop


Description
---

as requested by VDG


Diffs
-

  applets/kickoff/core/favoritesmodel.cpp 
ce49939e2bfd7987ba9fd5cf2cdf8f64cc6e7afb 

Diff: https://git.reviewboard.kde.org/r/125127/diff/


Testing
---

none. too lazy.

fwiw the discover notation is to prevent this breaking if aleix goes ahead with 
renaming muon-discover to discover in some future release


Thanks,

Harald Sitter

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125127: add discover to favorties

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125127/#review85075
---

Ship it!


+1 LGTM

- Aleix Pol Gonzalez


On Sept. 10, 2015, 12:11 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125127/
> ---
> 
> (Updated Sept. 10, 2015, 12:11 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> as requested by VDG
> 
> 
> Diffs
> -
> 
>   applets/kickoff/core/favoritesmodel.cpp 
> ce49939e2bfd7987ba9fd5cf2cdf8f64cc6e7afb 
> 
> Diff: https://git.reviewboard.kde.org/r/125127/diff/
> 
> 
> Testing
> ---
> 
> none. too lazy.
> 
> fwiw the discover notation is to prevent this breaking if aleix goes ahead 
> with renaming muon-discover to discover in some future release
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Raphael Kugelmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/
---

(Updated Sept. 9, 2015, 10:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit cee5e903812b5d2fae9e5be52440b8056626e95f by Martin 
Klapetek on behalf of Raphael Kugelmann to branch Plasma/5.4.


Repository: ksysguard


Description
---

Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors


Diffs
-

  gui/SensorDisplayLib/FancyPlotter.cpp 
6c2e8d14e0217c324845dc1b9b34481f3c6be34c 

Diff: https://git.reviewboard.kde.org/r/125063/diff/


Testing
---

Fail test procedure:
1. create a FancyPlotter View with an Sensor
2. open the settings for this FancyPlotter view and goto Sensor Tab
3. add in the MainWindow (in the background) a new Sensor
4. Close the Setting window by pressing the OK button
--> Crash

The Bugfix makes the mainwindow not editable while the settings dialog is open.
Therefore the written test above cannot be performed anymore.
The Fail case cannot be reached anymore.


Thanks,

Raphael Kugelmann

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125127: add discover to favorties

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125127/
---

(Updated Sept. 9, 2015, 10:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Changes
---

Submitted with commit 6580689bbc3995d9b6d6eab5c2b1ba65ff07f01d by Harald Sitter 
to branch master.


Repository: plasma-desktop


Description
---

as requested by VDG


Diffs
-

  applets/kickoff/core/favoritesmodel.cpp 
ce49939e2bfd7987ba9fd5cf2cdf8f64cc6e7afb 

Diff: https://git.reviewboard.kde.org/r/125127/diff/


Testing
---

none. too lazy.

fwiw the discover notation is to prevent this breaking if aleix goes ahead with 
renaming muon-discover to discover in some future release


Thanks,

Harald Sitter

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 352506] New: Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

[Erica Clawson]

https://bugs.kde.org/show_bug.cgi?id=352506

Bug ID: 352506
   Summary: Breeze High Contrast color scheme has defaults that
are bad for people with low contrast sensitivity
vision
   Product: Breeze
   Version: 5.4.0
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: blargle.rageq...@gmail.com

Breeze High Contrast by default has bright-blue title bars with thin, white
text.  This is illegible to me as someone who actually struggles with low
contrast sensitivity.  The title bars should have a dark background, just like
in Breeze Dark, for maximum visibility.  Additionally, after selecting Breeze
High Contrast I can no longer see the icons on buttons.  Because I'm also
dyslexic, button icons are incredibly useful for not needing to stop and try to
read the text on the buttons.  This can be fixed by switching to the Breeze
Dark icons, but this wasn't immediately obvious to me and I'm worried it won't
be to some others, either.

Reproducible: Always

Steps to Reproduce:
1. Start from vanilla plasma desktop.
2. Use Colors KCM to change the application color scheme to Breeze High
Contrast.
3. Click Apply.

Actual Results:  
It is hard for people with low contrast sensitivity to read the title bar, and
button icons seem to have disappeared.

Expected Results:  
People with low contrast sensitivity can suddenly use their desktops as well as
everyone else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 352506] Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=352506

Andrew Lake  changed:

   What|Removed |Added

 CC||jamboar...@gmail.com
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Andrew Lake  ---
Thanks for reporting Erica. We'll work to improve that color scheme and post
candidate color schemes here that we hope you might help us test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125129: Update baloo's D-Bus interface name in KCM

[Pinak Ahuja]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125129/
---

Review request for Plasma and Vishesh Handa.


Repository: plasma-desktop


Description
---

Also generate interface from XML


Diffs
-

  kcms/baloo/CMakeLists.txt 7415289 
  kcms/baloo/kcm.cpp d85f615 

Diff: https://git.reviewboard.kde.org/r/125129/diff/


Testing
---


Thanks,

Pinak Ahuja

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, line 167
> > 
> >
> > const QStorageInfo 

If I do that I get this:

/home/ovidiu/kde-devel/src/kde/workspace/plasma-desktop/kcms/baloo/kcm.cpp:167:5:
 error: invalid initialization of reference of type ‘QStorageInfo&’ from 
expression of type ‘const QStorageInfo’


> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, lines 168-169
> > 
> >
> > You can do it directly -- mountPoints << si.displayName()

I didn't do it directly because: it's easyer to debug if you keep the value in 
a variable before adding it to the list. But you are right, you can check the 
list's elements.


> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, lines 174-177
> > 
> >
> > This can also stay like it was, just do
> > 
> > return excluded.toSet() == mountPoints.toSet();
> > 
> > ...it will return the result of that comparison.
> > 
> > Or even 
> > 
> > return m_excludeFolders_FSW->excludeFolders().toSet() == 
> > mountPoints.toSet();
> > 
> > to simplify it completely.

That does not simplify the code. Your last example performs too many operations 
in the same line. It's debugging difficulty increases with that.
My proposal is more obvious at what it does (especially for new readers).

Also the compiler optimises that.


- Ovidiu-Florin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
---


On Sept. 9, 2015, 9:04 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> ---
> 
> (Updated Sept. 9, 2015, 9:04 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> ---
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/
---

(Updated Sept. 9, 2015, 9:47 p.m.)


Review request for Baloo, Plasma and Vishesh Handa.


Repository: plasma-desktop


Description
---

And simplified the way it searches for the mount points.


Diffs (updated)
-

  kcms/baloo/folderselectionwidget.h 6430b60 
  kcms/baloo/folderselectionwidget.cpp 3ad1764 
  kcms/baloo/kcm.h 6878e89 
  kcms/baloo/kcm.cpp d85f615 

Diff: https://git.reviewboard.kde.org/r/125117/diff/


Testing
---

Compiled and used.


Thanks,

Ovidiu-Florin BOGDAN

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, line 167
> > 
> >
> > const QStorageInfo 
> 
> Ovidiu-Florin BOGDAN wrote:
> If I do that I get this:
> 
> 
> /home/ovidiu/kde-devel/src/kde/workspace/plasma-desktop/kcms/baloo/kcm.cpp:167:5:
>  error: invalid initialization of reference of type ‘QStorageInfo&’ from 
> expression of type ‘const QStorageInfo’

I missed the const in front. Fixed now.


- Ovidiu-Florin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
---


On Sept. 9, 2015, 9:47 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> ---
> 
> (Updated Sept. 9, 2015, 9:47 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> ---
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Martin Klapetek]

> On Sept. 9, 2015, 8:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, lines 174-177
> > 
> >
> > This can also stay like it was, just do
> > 
> > return excluded.toSet() == mountPoints.toSet();
> > 
> > ...it will return the result of that comparison.
> > 
> > Or even 
> > 
> > return m_excludeFolders_FSW->excludeFolders().toSet() == 
> > mountPoints.toSet();
> > 
> > to simplify it completely.
> 
> Ovidiu-Florin BOGDAN wrote:
> That does not simplify the code. Your last example performs too many 
> operations in the same line. It's debugging difficulty increases with that.
> My proposal is more obvious at what it does (especially for new readers).
> 
> Also the compiler optimises that.

Personally I disagree that it increases debugging difficulty (that's what 
comments are for btw) but fair enough. The QStringList excluded should still be 
const though (const QStringList excluded = ... )


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
---


On Sept. 9, 2015, 8:47 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> ---
> 
> (Updated Sept. 9, 2015, 8:47 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> ---
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, lines 174-177
> > 
> >
> > This can also stay like it was, just do
> > 
> > return excluded.toSet() == mountPoints.toSet();
> > 
> > ...it will return the result of that comparison.
> > 
> > Or even 
> > 
> > return m_excludeFolders_FSW->excludeFolders().toSet() == 
> > mountPoints.toSet();
> > 
> > to simplify it completely.
> 
> Ovidiu-Florin BOGDAN wrote:
> That does not simplify the code. Your last example performs too many 
> operations in the same line. It's debugging difficulty increases with that.
> My proposal is more obvious at what it does (especially for new readers).
> 
> Also the compiler optimises that.
> 
> Martin Klapetek wrote:
> Personally I disagree that it increases debugging difficulty (that's what 
> comments are for btw) but fair enough. The QStringList excluded should still 
> be const though (const QStringList excluded = ... )

Fixed.


- Ovidiu-Florin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
---


On Sept. 9, 2015, 9:53 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> ---
> 
> (Updated Sept. 9, 2015, 9:53 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> ---
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125063: fix for Bug 260869

[Raphael Kugelmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/
---

Review request for Plasma.


Repository: ksysguard


Description
---

Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors


Diffs
-

  gui/SensorDisplayLib/FancyPlotter.cpp 
6c2e8d14e0217c324845dc1b9b34481f3c6be34c 

Diff: https://git.reviewboard.kde.org/r/125063/diff/


Testing
---

Fail test procedure:
1. create a FancyPlotter View with an Sensor
2. open the settings for this FancyPlotter view and goto Sensor Tab
3. add in the MainWindow (in the background) a new Sensor
4. Close the Setting window by pressing the OK button
--> Crash

The Bugfix makes the mainwindow not editable while the settings dialog is open.
Therefore the written test above cannot be performed anymore.
The Fail case cannot be reached anymore.


Thanks,

Raphael Kugelmann

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125118: [Icon widget] support dropping onto folder

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125118/
---

Review request for Plasma, Bhushan Shah, Emmanuel Pescosta, and Eike Hein.


Repository: plasma-workspace


Description
---

This allows to drop file(s) onto a folder and have it ask whether to 
copy/move/link and brings up error dialogs if any.


Diffs
-

  applets/icon/package/contents/ui/main.qml 49e91ca 
  applets/icon/plugin/icon_p.h 5b0f752 
  applets/icon/plugin/icon_p.cpp 97af67a 

Diff: https://git.reviewboard.kde.org/r/125118/diff/


Testing
---

Dropping brings up the copy/move/paste dialog, copied, moved, and linked files, 
works. Confirmation dialogs are desktop modal. Also, I had to create my own 
QDropEvent from the declarative one.

Modifiers are broken but this is apparently a Qt bug, also I don't know whether 
my int cast to flags is right. Thanks Emmanuel for guiding me through this.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/
---

(Updated Sept. 9, 2015, 9:45 p.m.)


Review request for Baloo, Plasma and Vishesh Handa.


Repository: plasma-desktop


Description
---

And simplified the way it searches for the mount points.


Diffs (updated)
-

  kcms/baloo/folderselectionwidget.h 6430b60 
  kcms/baloo/folderselectionwidget.cpp 3ad1764 
  kcms/baloo/kcm.h 6878e89 
  kcms/baloo/kcm.cpp d85f615 

Diff: https://git.reviewboard.kde.org/r/125117/diff/


Testing
---

Compiled and used.


Thanks,

Ovidiu-Florin BOGDAN

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/
---

(Updated Sept. 9, 2015, 9:53 p.m.)


Review request for Baloo, Plasma and Vishesh Handa.


Repository: plasma-desktop


Description
---

And simplified the way it searches for the mount points.


Diffs (updated)
-

  kcms/baloo/folderselectionwidget.h 6430b60 
  kcms/baloo/folderselectionwidget.cpp 3ad1764 
  kcms/baloo/kcm.h 6878e89 
  kcms/baloo/kcm.cpp d85f615 

Diff: https://git.reviewboard.kde.org/r/125117/diff/


Testing
---

Compiled and used.


Thanks,

Ovidiu-Florin BOGDAN

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Raphael Kugelmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/
---

(Updated Sept. 9, 2015, 8:26 nachm.)


Review request for Plasma.


Changes
---

updated comment


Repository: ksysguard


Description
---

Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors


Diffs (updated)
-

  gui/SensorDisplayLib/FancyPlotter.cpp 
6c2e8d14e0217c324845dc1b9b34481f3c6be34c 

Diff: https://git.reviewboard.kde.org/r/125063/diff/


Testing
---

Fail test procedure:
1. create a FancyPlotter View with an Sensor
2. open the settings for this FancyPlotter view and goto Sensor Tab
3. add in the MainWindow (in the background) a new Sensor
4. Close the Setting window by pressing the OK button
--> Crash

The Bugfix makes the mainwindow not editable while the settings dialog is open.
Therefore the written test above cannot be performed anymore.
The Fail case cannot be reached anymore.


Thanks,

Raphael Kugelmann

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124980/
---

(Updated Sept. 9, 2015, 8:28 nachm.)


Review request for Plasma and Martin Gräßlin.


Changes
---

- Address some issues
- Make "reload()" public so you can reload the model on demand (eg right before 
opening a plasmoid)

I think KDisplayManager needs a complete rewrite if we want to make it async - 
it still has a ton of legacy stuff (ConsoleKit, KDM, "dunno" (sic) enum values) 
and more fun.


Repository: plasma-workspace


Description
---

This way it can be used in the lock screen, user switcher, and a user switcher 
plasmoid I'm planning.

Compared to the one in the lock screen it can also get the user's full name and 
avatar, and some other information.

Perhaps we could also try to have it wait for the screen to actually lock 
before switching sessions?


Diffs (updated)
-

  components/CMakeLists.txt 21fc61c 
  components/sessionsprivate/CMakeLists.txt PRE-CREATION 
  components/sessionsprivate/qmldir PRE-CREATION 
  components/sessionsprivate/sessionsmodel.h PRE-CREATION 
  components/sessionsprivate/sessionsmodel.cpp PRE-CREATION 
  components/sessionsprivate/sessionsprivateplugin.h PRE-CREATION 
  components/sessionsprivate/sessionsprivateplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124980/diff/


Testing
---

Lists my sessions, allows to switch between them and start new ones. Locking 
when creating a new session is missing.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Raphael Kugelmann]

> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote:
> >
> 
> Martin Klapetek wrote:
> Btw. do you have commit access?

I haven't tried it yet.
But I think I have no further access rights for the repo.


- Raphael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/#review85064
---


On Sept. 9, 2015, 8:26 nachm., Raphael Kugelmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125063/
> ---
> 
> (Updated Sept. 9, 2015, 8:26 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors
> 
> 
> Diffs
> -
> 
>   gui/SensorDisplayLib/FancyPlotter.cpp 
> 6c2e8d14e0217c324845dc1b9b34481f3c6be34c 
> 
> Diff: https://git.reviewboard.kde.org/r/125063/diff/
> 
> 
> Testing
> ---
> 
> Fail test procedure:
> 1. create a FancyPlotter View with an Sensor
> 2. open the settings for this FancyPlotter view and goto Sensor Tab
> 3. add in the MainWindow (in the background) a new Sensor
> 4. Close the Setting window by pressing the OK button
> --> Crash
> 
> The Bugfix makes the mainwindow not editable while the settings dialog is 
> open.
> Therefore the written test above cannot be performed anymore.
> The Fail case cannot be reached anymore.
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Raphael Kugelmann]

> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote:
> >
> 
> Martin Klapetek wrote:
> Btw. do you have commit access?
> 
> Raphael Kugelmann wrote:
> I haven't tried it yet.
> But I think I have no further access rights for the repo.

sorry for this annoying question.
How does this commit work. Is it possible to do it via ChangeBoard or only via 
git?


- Raphael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/#review85064
---


On Sept. 9, 2015, 8:26 nachm., Raphael Kugelmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125063/
> ---
> 
> (Updated Sept. 9, 2015, 8:26 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors
> 
> 
> Diffs
> -
> 
>   gui/SensorDisplayLib/FancyPlotter.cpp 
> 6c2e8d14e0217c324845dc1b9b34481f3c6be34c 
> 
> Diff: https://git.reviewboard.kde.org/r/125063/diff/
> 
> 
> Testing
> ---
> 
> Fail test procedure:
> 1. create a FancyPlotter View with an Sensor
> 2. open the settings for this FancyPlotter view and goto Sensor Tab
> 3. add in the MainWindow (in the background) a new Sensor
> 4. Close the Setting window by pressing the OK button
> --> Crash
> 
> The Bugfix makes the mainwindow not editable while the settings dialog is 
> open.
> Therefore the written test above cannot be performed anymore.
> The Fail case cannot be reached anymore.
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 352497] New: laptop back light not coming back on after long period of lcd being in dpms power save mode.

[Vladi]

https://bugs.kde.org/show_bug.cgi?id=352497

Bug ID: 352497
   Summary: laptop back light not coming back on after long period
of lcd being in dpms power save mode.
   Product: Powerdevil
   Version: 5.4.1
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: vl...@aresgate.net

I have to use xbacklight -inc 100 to turn my backlight on my laptop after
prolonged lcd sleep.

Reproducible: Sometimes

Steps to Reproduce:
1. let kde go to power save mode
2. wake up using mouse
3. no backlight

Actual Results:  
no backlight for my laptop screen

Expected Results:  
backlight for my laptop screen

if I have a monitor pluged in it does come on just not my laptop screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 352497] laptop back light not coming back on after long period of lcd being in dpms power save mode.

[Vladi]

https://bugs.kde.org/show_bug.cgi?id=352497

Vladi  changed:

   What|Removed |Added

URL||https://bpaste.net/show/8c7
   ||7f03bd682

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Raphael Kugelmann]

> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote:
> >
> 
> Martin Klapetek wrote:
> Btw. do you have commit access?
> 
> Raphael Kugelmann wrote:
> I haven't tried it yet.
> But I think I have no further access rights for the repo.
> 
> Raphael Kugelmann wrote:
> sorry for this annoying question.
> How does this commit work. Is it possible to do it via ChangeBoard or 
> only via git?

a "git push" results into access denied, so I think I haven't commit access.
Can you please do the commit? Thanks!


- Raphael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/#review85064
---


On Sept. 9, 2015, 8:26 nachm., Raphael Kugelmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125063/
> ---
> 
> (Updated Sept. 9, 2015, 8:26 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors
> 
> 
> Diffs
> -
> 
>   gui/SensorDisplayLib/FancyPlotter.cpp 
> 6c2e8d14e0217c324845dc1b9b34481f3c6be34c 
> 
> Diff: https://git.reviewboard.kde.org/r/125063/diff/
> 
> 
> Testing
> ---
> 
> Fail test procedure:
> 1. create a FancyPlotter View with an Sensor
> 2. open the settings for this FancyPlotter view and goto Sensor Tab
> 3. add in the MainWindow (in the background) a new Sensor
> 4. Close the Setting window by pressing the OK button
> --> Crash
> 
> The Bugfix makes the mainwindow not editable while the settings dialog is 
> open.
> Therefore the written test above cannot be performed anymore.
> The Fail case cannot be reached anymore.
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
---



kcms/baloo/kcm.cpp (line 165)


the { goes to new line



kcms/baloo/kcm.cpp (line 167)


const QStorageInfo 



kcms/baloo/kcm.cpp (lines 168 - 169)


You can do it directly -- mountPoints << si.displayName()



kcms/baloo/kcm.cpp (lines 174 - 177)


This can also stay like it was, just do

return excluded.toSet() == mountPoints.toSet();

...it will return the result of that comparison.

Or even 

return m_excludeFolders_FSW->excludeFolders().toSet() == 
mountPoints.toSet();

to simplify it completely.


- Martin Klapetek


On Sept. 9, 2015, 8:04 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> ---
> 
> (Updated Sept. 9, 2015, 8:04 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> ---
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125107: Renamed functions and variables for better Qt compliance and better description

[Ovidiu-Florin BOGDAN]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125107/
---

(Updated Sept. 9, 2015, 5:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo, Plasma and Vishesh Handa.


Changes
---

Submitted with commit a80d1931d878ddf024975bbeeb869c2f731db194 by Ovidiu-Florin 
BOGDAN to branch master.


Repository: plasma-desktop


Description
---

Also added some Doxygen comments to better describe some class members.


Diffs
-

  kcms/baloo/configwidget.ui 512e4a5 
  kcms/baloo/folderselectionwidget.h 226ab45 
  kcms/baloo/folderselectionwidget.cpp b44d111 
  kcms/baloo/kcm.h 6ff5813 
  kcms/baloo/kcm.cpp 27d93e2 

Diff: https://git.reviewboard.kde.org/r/125107/diff/


Testing
---

Compiled and used.


Thanks,

Ovidiu-Florin BOGDAN

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125117: Moved check for all mount points excluded out of widget class

[Ovidiu-Florin BOGDAN]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/
---

Review request for Baloo, Plasma and Vishesh Handa.


Repository: plasma-desktop


Description
---

And simplified the way it searches for the mount points.


Diffs
-

  kcms/baloo/folderselectionwidget.h 6430b60 
  kcms/baloo/folderselectionwidget.cpp 3ad1764 
  kcms/baloo/kcm.h 6878e89 
  kcms/baloo/kcm.cpp d85f615 

Diff: https://git.reviewboard.kde.org/r/125117/diff/


Testing
---

Compiled and used.


Thanks,

Ovidiu-Florin BOGDAN

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/
---

(Updated Sept. 9, 2015, 8:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 6e663a9e85cf8017fc20e0c749e5a2d939cef98c by Kai Uwe 
Broulik to branch master.


Repository: kdeplasma-addons


Description
---

This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.

Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters 
picker mode, where you can click anywhere on the screen and have the color code 
(in a format you can configure) copied to your clipboard.
Clicking the color blob opens the history, showing the recentmost 9 colors (so 
it's a nice grid) which allow copying their respective color codes in various 
formats.
Activating the plasmoid (pressing the configured shortcut) will by default 
enter color picking mode, alternatively it brings up the popup like any other 
plasmoid.


Diffs
-

  applets/CMakeLists.txt c60c350 
  applets/colorpicker/CMakeLists.txt PRE-CREATION 
  applets/colorpicker/Messages.sh PRE-CREATION 
  applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
  applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
  applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
  applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
  applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
  applets/colorpicker/package/metadata.desktop PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
  applets/colorpicker/plugin/qmldir PRE-CREATION 
  applets/kolourpicker/CMakeLists.txt 522e0de 
  applets/kolourpicker/Messages.sh 072def0 
  applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
  applets/kolourpicker/kolourpicker.h bde3ff7 
  applets/kolourpicker/kolourpicker.cpp a4b0ea4 
  applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 

Diff: https://git.reviewboard.kde.org/r/124923/diff/


Testing
---

- I have the impression that the color picker is off by one pixel horizontally 
(QRect weirdness? or our Breeze crosshair cursor?)
- I didn't test with multiple screens


File Attachments


In a panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
On the desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
History
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
Formats menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
Settings
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125119: support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125119/
---

Review request for kwin and Plasma.


Repository: kwayland-integration


Description
---

client support for the sliding popups effect


Diffs
-

  src/windowsystem/waylandintegration.h 3a32448 
  src/windowsystem/waylandintegration.cpp b9b8865 
  src/windowsystem/windoweffects.cpp 91b8cd4 

Diff: https://git.reviewboard.kde.org/r/125119/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/#review85064
---

Ship it!



gui/SensorDisplayLib/FancyPlotter.cpp (line 295)


You might want to add that "open() opens the dialog modaly (ie. blocks the 
parent window)", it might be better understood why open


- Martin Klapetek


On Sept. 9, 2015, 9:09 p.m., Raphael Kugelmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125063/
> ---
> 
> (Updated Sept. 9, 2015, 9:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors
> 
> 
> Diffs
> -
> 
>   gui/SensorDisplayLib/FancyPlotter.cpp 
> 6c2e8d14e0217c324845dc1b9b34481f3c6be34c 
> 
> Diff: https://git.reviewboard.kde.org/r/125063/diff/
> 
> 
> Testing
> ---
> 
> Fail test procedure:
> 1. create a FancyPlotter View with an Sensor
> 2. open the settings for this FancyPlotter view and goto Sensor Tab
> 3. add in the MainWindow (in the background) a new Sensor
> 4. Close the Setting window by pressing the OK button
> --> Crash
> 
> The Bugfix makes the mainwindow not editable while the settings dialog is 
> open.
> Therefore the written test above cannot be performed anymore.
> The Fail case cannot be reached anymore.
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125063: fix for Bug 260869

[Martin Klapetek]

> On Sept. 9, 2015, 9:26 p.m., Martin Klapetek wrote:
> >

Btw. do you have commit access?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125063/#review85064
---


On Sept. 9, 2015, 9:09 p.m., Raphael Kugelmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125063/
> ---
> 
> (Updated Sept. 9, 2015, 9:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Bugfix for Bug 260869 - [steps] System Monitor crashes while changing sensors
> 
> 
> Diffs
> -
> 
>   gui/SensorDisplayLib/FancyPlotter.cpp 
> 6c2e8d14e0217c324845dc1b9b34481f3c6be34c 
> 
> Diff: https://git.reviewboard.kde.org/r/125063/diff/
> 
> 
> Testing
> ---
> 
> Fail test procedure:
> 1. create a FancyPlotter View with an Sensor
> 2. open the settings for this FancyPlotter view and goto Sensor Tab
> 3. add in the MainWindow (in the background) a new Sensor
> 4. Close the Setting window by pressing the OK button
> --> Crash
> 
> The Bugfix makes the mainwindow not editable while the settings dialog is 
> open.
> Therefore the written test above cannot be performed anymore.
> The Fail case cannot be reached anymore.
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125119: support for the slide protocol

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125119/#review85067
---



src/windowsystem/waylandintegration.cpp (line 125)


since the three functions differ but in one sub-token (and it seems we're 
getting more): macro?


- Thomas Lübking


On Sept. 9, 2015, 7:43 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125119/
> ---
> 
> (Updated Sept. 9, 2015, 7:43 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland-integration
> 
> 
> Description
> ---
> 
> client support for the sliding popups effect
> 
> 
> Diffs
> -
> 
>   src/windowsystem/waylandintegration.h 3a32448 
>   src/windowsystem/waylandintegration.cpp b9b8865 
>   src/windowsystem/windoweffects.cpp 91b8cd4 
> 
> Diff: https://git.reviewboard.kde.org/r/125119/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125120: [wip] support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/
---

Review request for kwin and Plasma.


Repository: kwin


Description
---

take and apply thhe informations from the wayland slide protocol in the sliding 
popups effect


Diffs
-

  effects/slidingpopups/slidingpopups.h ac3cf10 
  effects/slidingpopups/slidingpopups.cpp f6d9ec5 

Diff: https://git.reviewboard.kde.org/r/125120/diff/


Testing
---

slide to appear works, slide out to disappear doesn't.

the second time a popup is opened, kwin crashes and an assert is hit

kwin_wayland: 
/home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) 
const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= 
top() && y2 <= bottom()' failed.


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125119: support for the slide protocol

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125119/#review85066
---

Ship it!


I really like how straight forward we get these things to work

- Martin Gräßlin


On Sept. 9, 2015, 9:23 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125119/
> ---
> 
> (Updated Sept. 9, 2015, 9:23 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland-integration
> 
> 
> Description
> ---
> 
> client support for the sliding popups effect
> 
> 
> Diffs
> -
> 
>   src/windowsystem/waylandintegration.h 3a32448 
>   src/windowsystem/waylandintegration.cpp b9b8865 
>   src/windowsystem/windoweffects.cpp 91b8cd4 
> 
> Diff: https://git.reviewboard.kde.org/r/125119/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125119: support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125119/
---

(Updated Sept. 9, 2015, 7:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Changes
---

Submitted with commit 746873eec182545ed3bb5a059dd16d0fee1b448e by Marco Martin 
to branch master.


Repository: kwayland-integration


Description
---

client support for the sliding popups effect


Diffs
-

  src/windowsystem/waylandintegration.h 3a32448 
  src/windowsystem/waylandintegration.cpp b9b8865 
  src/windowsystem/windoweffects.cpp 91b8cd4 

Diff: https://git.reviewboard.kde.org/r/125119/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel