Re: Kirigami Page.title

2016-04-20 Thread Dirk Hohndel

> On Apr 20, 2016, at 7:51 PM, Martin Klapetek  
> wrote:
> 
> Is it possible to either hide the blue titlebar when empty
> or add things like buttons and icons in there?
> 
> In SpaceBar, the active conversation has this layout at
> the top of the Page:
> 
> [Presence Icon] Username [Close Conversation Button]
> 
> So in this case it doesn't make sense that this Page would
> have the standard blue titlebar too. Unless more things could
> go in there.
> 
> I can perhaps write a patch to hide it if empty, if you agree.

Well, you kinda can hide it already: simply set 

header.minimumHeight: 0
header.preferredHeight: 0
header.maximumHeight: 0



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127586: [calendar] Add a mark to days containing events

2016-04-20 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

(Updated April 21, 2016, 3:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 08312b2e340e10d640131c0186e81a0b9f0f2505 by Martin 
Klapetek to branch master.


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs
-

  src/declarativeimports/calendar/calendar.h 1849ada 
  src/declarativeimports/calendar/calendar.cpp 0c525b7 
  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Kirigami Page.title

2016-04-20 Thread Martin Klapetek
Is it possible to either hide the blue titlebar when empty
or add things like buttons and icons in there?

In SpaceBar, the active conversation has this layout at
the top of the Page:

[Presence Icon] Username [Close Conversation Button]

So in this case it doesn't make sense that this Page would
have the standard blue titlebar too. Unless more things could
go in there.

I can perhaps write a patch to hide it if empty, if you agree.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 361885] Kalarm crashes when closing main woindow

2016-04-20 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361885

Aleix Pol  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM
 CC||aleix...@kde.org

--- Comment #2 from Aleix Pol  ---
That's the bug, it's fixed in Qt, just need to wait for Qt 5.6.1.

https://bugreports.qt.io/browse/QTBUG-51648

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 361885] Kalarm crashes when closing main woindow

2016-04-20 Thread David Jarvie via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361885

David Jarvie  changed:

   What|Removed |Added

Product|kalarm  |Breeze
  Component|general |general
   Assignee|djar...@kde.org |plasma-devel@kde.org

--- Comment #1 from David Jarvie  ---
The crash is in the Breeze style code. Reassigning to Breeze.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D1452: Implement volume overdrive

2016-04-20 Thread drosca (David Rosca)
drosca added a comment.


  In https://phabricator.kde.org/D1452#26974, @colomar wrote:
  
  > There is a reason why "100%" is not the actual maximum volume you can get 
out of a device.
  >  I don't want us to be liable for either burst speakers or burst eardrums...
  
  
  Well, for most devices even 100% is too much so I wouldn't really see this as 
a problem.
  
  > Is there any way we can change the look of the part of the slider that is 
above 100%, like make it red or something? Or any way we can indicate "Hey, do 
this only if you know what you're doing!"
  
  I'm afraid there is not much to do about slider customization (unless it is 
replaced by custom slider which then won't use widget style).

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1452

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated, 86 lines] D1452: Implement volume overdrive

2016-04-20 Thread drosca (David Rosca)
drosca updated this revision to Diff 3438.
drosca added a comment.


  Fix showing volume % in applet

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1452?vs=3434=3438

BRANCH
  volume-overdrive

REVISION DETAIL
  https://phabricator.kde.org/D1452

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/VolumeIcon.qml
  applet/contents/ui/main.qml
  src/context.h
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-20 Thread David Rosca

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127702/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The 
source property will be empty for KCM pages.
This fixes correctly returning empty source for KCM pages.


Diffs
-

  src/plasmaquick/configmodel.cpp 3f69073 

Diff: https://git.reviewboard.kde.org/r/127702/diff/


Testing
---

Added qml config page to plasma-pa, KCM page now works fine.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 40 - Still Failing!

2016-04-20 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Apr 2016 20:08:19 +
Build duration: 3 min 42 sec

CHANGE SET
Revision 162c65ea1e5ca66ae3bff5d127ed3c7e72bca419 by hein: (Add missing 
namespace.)
  change: edit containments/desktop/package/contents/ui/main.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D1452: Implement volume overdrive

2016-04-20 Thread colomar (Thomas Pfeiffer)
colomar added a comment.


  I know Pavucontrol does the same, but I think this makes it too easy to go 
into overdrive.
  There is a reason why "100%" is not the actual maximum volume you can get out 
of a device.
  I don't want us to be liable for either burst speakers or burst eardrums...
  
  Is there any way we can change the look of the part of the slider that is 
above 100%, like make it red or something? Or any way we can indicate "Hey, do 
this only if you know what you're doing!"

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1452

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 39 - Still Failing!

2016-04-20 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Apr 2016 18:56:53 +
Build duration: 3 min 47 sec

CHANGE SET
Revision 77d4071bc8f2dde0ab8c43cbdaf1744c630c9971 by Jonathan Riddell: (Update 
version number for 5.6.3 GIT_SILENT)
  change: edit CMakeLists.txt
Revision bca9fc813e4dfe6faf59d5945ac19c96c49b1e6f by hein: (Fix DND on Folder 
View containments with locked widgets.)
  change: edit containments/desktop/package/contents/ui/main.qml
  change: edit containments/desktop/package/contents/code/FolderTools.js
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 24 - Fixed!

2016-04-20 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Apr 2016 18:50:38 +
Build duration: 5 min 30 sec

CHANGE SET
Revision bca9fc813e4dfe6faf59d5945ac19c96c49b1e6f by hein: (Fix DND on Folder 
View containments with locked widgets.)
  change: edit containments/desktop/package/contents/ui/main.qml
  change: edit containments/desktop/package/contents/code/FolderTools.js


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3369 
(69%)CONDITIONAL 1565/3770 (42%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1521 
(51%)CONDITIONAL 632/1711 (37%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
433/1116 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 24 - Fixed!

2016-04-20 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Apr 2016 18:50:38 +
Build duration: 5 min 30 sec

CHANGE SET
Revision bca9fc813e4dfe6faf59d5945ac19c96c49b1e6f by hein: (Fix DND on Folder 
View containments with locked widgets.)
  change: edit containments/desktop/package/contents/ui/main.qml
  change: edit containments/desktop/package/contents/code/FolderTools.js


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3369 
(69%)CONDITIONAL 1565/3770 (42%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1521 
(51%)CONDITIONAL 632/1711 (37%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
433/1116 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: another Kirigami issue - overlap of header and listview

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 07:32:04PM +0200, Marco Martin wrote:
> On Wednesday 20 April 2016 09:44:43 Dirk Hohndel wrote:
> > On Wed, Apr 20, 2016 at 10:36:05AM +0200, Marco Martin wrote:
> > > On Tuesday 19 April 2016, Dirk Hohndel wrote:
> > > > go). The latter always appears to have the top item aligned with the
> > > > header, but when I tap on the header and have scrollTopAnimation run to:
> > > > 0, then the header overlaps the top element in the ListView.
> > > > 
> > > > A patch like this seems to fix the problem
> > > 
> > > thanks, i pushed it plus some fixes on top of it (using topPadding instead
> > > of the height)
> > 
> > Did you have a chance to look at making the "badge" for the two and three
> > button case a little wider? If you're too busy, I'll be happy to try my
> > hands on that bit of QML :-)
> 
> in latest master should be a bit larger, if needed more can be further 
> tweaked 
> or if needed made different with 3 circles

I think this looks good. Will have to look at it across a number of
different devices tonight, but I think this strikes a nice balance in size
and position.

/D
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 38 - Failure!

2016-04-20 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Apr 2016 17:36:18 +
Build duration: 3 min 11 sec

CHANGE SET
Revision ff1f25bcd8a7f5877da4971d85c9d436bbe16d23 by David Rosca: (Add Help 
button to desktop theme KCM)
  change: edit kcms/desktoptheme/kcm_desktoptheme.desktop
  change: edit kcms/desktoptheme/kcm.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: another Kirigami issue - overlap of header and listview

2016-04-20 Thread Marco Martin
On Wednesday 20 April 2016 09:44:43 Dirk Hohndel wrote:
> On Wed, Apr 20, 2016 at 10:36:05AM +0200, Marco Martin wrote:
> > On Tuesday 19 April 2016, Dirk Hohndel wrote:
> > > go). The latter always appears to have the top item aligned with the
> > > header, but when I tap on the header and have scrollTopAnimation run to:
> > > 0, then the header overlaps the top element in the ListView.
> > > 
> > > A patch like this seems to fix the problem
> > 
> > thanks, i pushed it plus some fixes on top of it (using topPadding instead
> > of the height)
> 
> Did you have a chance to look at making the "badge" for the two and three
> button case a little wider? If you're too busy, I'll be happy to try my
> hands on that bit of QML :-)

in latest master should be a bit larger, if needed more can be further tweaked 
or if needed made different with 3 circles

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 127698: Always write the theme name to plasmarc, also if the default theme is chosen

2016-04-20 Thread Wolfgang Bauer

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127698/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Currently, the "name" key is deleted from plasmarc when you select the default 
theme (breeze) in the desktop theme KCM.
This leads to unexpected behaviour: If you set e.g. oxygen as look, and 
then set breeze as desktop theme, Plasma actually uses Air (the default desktop 
theme in the oxygen l) on next login instead of breeze. In other words, it is 
impossible to configure breeze as desktop theme when using a different 
look as breeze.

This fixes the problem by removing the check whether the default theme is 
selected and always writes the "name" config key to plasmarc.


Diffs
-

  src/plasma/private/theme_p.cpp 1aaf021 

Diff: https://git.reviewboard.kde.org/r/127698/diff/


Testing
---

Set oxygen as look, then set breeze as desktop theme. On next login, 
breeze is indeed used as desktop theme, without the patch Plasma will fall back 
to Air.

Changing themes or the look still works the same otherwise.


Thanks,

Wolfgang Bauer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: another Kirigami issue - overlap of header and listview

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 10:36:05AM +0200, Marco Martin wrote:
> On Tuesday 19 April 2016, Dirk Hohndel wrote:
> > go). The latter always appears to have the top item aligned with the
> > header, but when I tap on the header and have scrollTopAnimation run to:
> > 0, then the header overlaps the top element in the ListView.
> > 
> > A patch like this seems to fix the problem
> 
> thanks, i pushed it plus some fixes on top of it (using topPadding instead of 
> the height)

Did you have a chance to look at making the "badge" for the two and three
button case a little wider? If you're too busy, I'll be happy to try my
hands on that bit of QML :-)

/D
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 05:52:48PM +0200, Marco Martin wrote:
> On Wednesday 20 April 2016, Sebastian Kügler wrote:
> > On Tuesday 19 April 2016 16:31:41 Kai Uwe Broulik wrote:
> > > > 2.) On your Nexus 7, the whole thing indeed is way too small. This
> > > > seems to be a DPI scaling issue, though
> > > 
> > > I've seen QScreen physical dots per inch reporting rubbish on some
> > > Android devices, I think Nexus 7 was even one of them. See my comment in
> > > QTBUG-35701 for a workaround (basically asking Android API directly)
> > 
> > Could be solved by making these buttons sized with Units.gridUnit (which is
> > based on font size, just like everything else in Plasma).
> 
> they are, but subsurface must be doing something strange like setting 
> gridUnit 
> to something else somewhere, as i get most ui pieces based on units 
> ridiculously huge on my laptop (while in the component gallery they're sized 
> fine)

We set the font size based on preferences, IIRC - and we use the same
prefs for desktop and mobile (that's not just laziness - that allows me to
set up the proxy with the desktop version and then have the mobile version
built on the same system use those settings).

Could that be what causes the problem?

But that brings us back to the odd sizing of the three buttons on my
Nexus 7 - does the relative sizing between fonts and buttons on that seem
different?

/D
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/
---

(Updated April 20, 2016, 4:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Andreas Kainz.


Changes
---

Submitted with commit 1cf145861bc13f40f1eef2ae3c4eed739b160c8f by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

add named colors for positive (usually green)
neutral(usually yellow) negative(usually red)
foreground objects, such as text or parts of
svg icons/themes


Diffs
-

  autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
  autotests/themetest.cpp 3992246 
  src/declarativeimports/core/colorscope.h b0f0ada 
  src/declarativeimports/core/colorscope.cpp 5f7363b 
  src/declarativeimports/core/quicktheme.h f1af4ca 
  src/declarativeimports/core/quicktheme.cpp 3411b3d 
  src/plasma/private/theme_p.cpp 1aaf021 
  src/plasma/theme.h 271328c 

Diff: https://git.reviewboard.kde.org/r/127696/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-20 Thread Marco Martin
On Wednesday 20 April 2016, Sebastian Kügler wrote:
> On Tuesday 19 April 2016 16:31:41 Kai Uwe Broulik wrote:
> > > 2.) On your Nexus 7, the whole thing indeed is way too small. This
> > > seems to be a DPI scaling issue, though
> > 
> > I've seen QScreen physical dots per inch reporting rubbish on some
> > Android devices, I think Nexus 7 was even one of them. See my comment in
> > QTBUG-35701 for a workaround (basically asking Android API directly)
> 
> Could be solved by making these buttons sized with Units.gridUnit (which is
> based on font size, just like everything else in Plasma).

they are, but subsurface must be doing something strange like setting gridUnit 
to something else somewhere, as i get most ui pieces based on units 
ridiculously huge on my laptop (while in the component gallery they're sized 
fine)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/#review94733
---


Fix it, then Ship it!




Some minor stuff inline. If the artists are happy with the semantics, go for it.


src/declarativeimports/core/colorscope.h (line 68)


What does positive mean exactly in this context?
@since 5.22? (also for following properties)



src/declarativeimports/core/colorscope.h (line 73)


neutral? (perhaps also explain "neutral"'s meaning.



src/declarativeimports/core/colorscope.h (line 80)


positive -> negative, also please explain



src/declarativeimports/core/colorscope.cpp (line 189)


double empty line



src/declarativeimports/core/colorscope.cpp (line 202)


double empty line



src/declarativeimports/core/colorscope.cpp (line 213)


double empty line


- Sebastian Kügler


On April 20, 2016, 12:49 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127696/
> ---
> 
> (Updated April 20, 2016, 12:49 p.m.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> add named colors for positive (usually green)
> neutral(usually yellow) negative(usually red)
> foreground objects, such as text or parts of
> svg icons/themes
> 
> 
> Diffs
> -
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
>   autotests/themetest.cpp 3992246 
>   src/declarativeimports/core/colorscope.h b0f0ada 
>   src/declarativeimports/core/colorscope.cpp 5f7363b 
>   src/declarativeimports/core/quicktheme.h f1af4ca 
>   src/declarativeimports/core/quicktheme.cpp 3411b3d 
>   src/plasma/private/theme_p.cpp 1aaf021 
>   src/plasma/theme.h 271328c 
> 
> Diff: https://git.reviewboard.kde.org/r/127696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-20 Thread Sebastian Kügler
On Tuesday 19 April 2016 16:31:41 Kai Uwe Broulik wrote:
> > 2.) On your Nexus 7, the whole thing indeed is way too small. This seems
> > to be a DPI scaling issue, though
> I've seen QScreen physical dots per inch reporting rubbish on some Android
> devices, I think Nexus 7 was even one of them. See my comment in
> QTBUG-35701 for a workaround (basically asking Android API directly)

Could be solved by making these buttons sized with Units.gridUnit (which is 
based on font size, just like everything else in Plasma).
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-20 Thread Sebastian Kügler
On Tuesday 19 April 2016 05:03:01 Dirk Hohndel wrote:
> > Since it's not something that Kirigami was made for, I fear that at some 
> > point, it will just break, and it would neither be good if Kirigami had
> > to 
> > adapt to Subsurface-mobile's specialties, nor if you had to work
> > "against" 
> > Kirigami.
> 
> No such intention here. I know that Sebastian and Marco worked on this
> initial implementation together (quite a while ago by now). It works.
> It doesn't seem to break things. I wouldn't be surprised if all this
> could be done better, but I don't feel competent to judge that.
> 
> > Maybe the fact that you are doing these "weird things" points to an
> > important  pattern which Kirigami is missing and should be added in a
> > proper way.

> Sebastian, can you comment on that?

Well, why should pages not support states? These two things seem rather 
orthogonal to me.

I know Marco wasn't overly happy with the separate view and edit states of the 
dive list, but /in my mind/ it makes complete sense. (Gratuitous opportunity 
to make the obvious "sebas, that's only in *your* head!" remarks. :))

That said, I'm not married to the setup, it can be made separate pages as 
well, but would have to sync all the properties back and forth then (which to 
some degree, it already does).

Cheers,
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Accepted] D1445: Get the logind session to take over through env variable instead of own PID

2016-04-20 Thread bshah (Bhushan Shah)
bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision is now accepted and ready to land.


  Please adjust commit message to remove reference of KWIN_LOGIN_SESSION before 
landing this.

REPOSITORY
  rKWIN KWin

BRANCH
  logind-session-arg

REVISION DETAIL
  https://phabricator.kde.org/D1445

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Accepted] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

2016-04-20 Thread bshah (Bhushan Shah)
bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.


  Tested and works on mobile.

REPOSITORY
  rKWIN KWin

BRANCH
  vt-integration-through-logind

REVISION DETAIL
  https://phabricator.kde.org/D1444

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, helio, Plasma, bshah
Cc: bshah, helio, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated, 95 lines] D1443: Applet: Move Application streams with drag and drop

2016-04-20 Thread drosca (David Rosca)
drosca updated this revision to Diff 3435.
drosca added a comment.


  Fix issues

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1443?vs=3403=3435

BRANCH
  applet-movestreams

REVISION DETAIL
  https://phabricator.kde.org/D1443

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, sebas, Plasma, Plasma: Design
Cc: sebas, colomar, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Marco Martin


> On April 20, 2016, 1:04 p.m., Andreas Kainz wrote:
> > sorry marco but I'm not that good in code reading. what's the difference in 
> > the second review?

added stuff to be able to use those colors from qml plasmoids as well


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/#review94730
---


On April 20, 2016, 12:49 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127696/
> ---
> 
> (Updated April 20, 2016, 12:49 p.m.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> add named colors for positive (usually green)
> neutral(usually yellow) negative(usually red)
> foreground objects, such as text or parts of
> svg icons/themes
> 
> 
> Diffs
> -
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
>   autotests/themetest.cpp 3992246 
>   src/declarativeimports/core/colorscope.h b0f0ada 
>   src/declarativeimports/core/colorscope.cpp 5f7363b 
>   src/declarativeimports/core/quicktheme.h f1af4ca 
>   src/declarativeimports/core/quicktheme.cpp 3411b3d 
>   src/plasma/private/theme_p.cpp 1aaf021 
>   src/plasma/theme.h 271328c 
> 
> Diff: https://git.reviewboard.kde.org/r/127696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Andreas Kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/#review94730
---



sorry marco but I'm not that good in code reading. what's the difference in the 
second review?

- Andreas Kainz


On April 20, 2016, 12:49 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127696/
> ---
> 
> (Updated April 20, 2016, 12:49 nachm.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> add named colors for positive (usually green)
> neutral(usually yellow) negative(usually red)
> foreground objects, such as text or parts of
> svg icons/themes
> 
> 
> Diffs
> -
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
>   autotests/themetest.cpp 3992246 
>   src/declarativeimports/core/colorscope.h b0f0ada 
>   src/declarativeimports/core/colorscope.cpp 5f7363b 
>   src/declarativeimports/core/quicktheme.h f1af4ca 
>   src/declarativeimports/core/quicktheme.cpp 3411b3d 
>   src/plasma/private/theme_p.cpp 1aaf021 
>   src/plasma/theme.h 271328c 
> 
> Diff: https://git.reviewboard.kde.org/r/127696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/
---

(Updated April 20, 2016, 12:49 p.m.)


Review request for Plasma and Andreas Kainz.


Repository: plasma-framework


Description
---

add named colors for positive (usually green)
neutral(usually yellow) negative(usually red)
foreground objects, such as text or parts of
svg icons/themes


Diffs (updated)
-

  autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
  autotests/themetest.cpp 3992246 
  src/declarativeimports/core/colorscope.h b0f0ada 
  src/declarativeimports/core/colorscope.cpp 5f7363b 
  src/declarativeimports/core/quicktheme.h f1af4ca 
  src/declarativeimports/core/quicktheme.cpp 3411b3d 
  src/plasma/private/theme_p.cpp 1aaf021 
  src/plasma/theme.h 271328c 

Diff: https://git.reviewboard.kde.org/r/127696/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D1452: Implement volume overdrive

2016-04-20 Thread drosca (David Rosca)
drosca added a comment.


  F112392: overdrive-kcm.png 

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1452

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated] D1452: Implement volume overdrive

2016-04-20 Thread drosca (David Rosca)
drosca added a reviewer: Plasma: Design.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1452

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Request, 86 lines] D1452: Implement volume overdrive

2016-04-20 Thread drosca (David Rosca)
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It is now possible to set volume up to 150% from KCM.
  
  BUG: 351438

TEST PLAN
  For applet there will be config option to set maximum volume (100% - 150%), 
in next review.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  volume-overdrive

REVISION DETAIL
  https://phabricator.kde.org/D1452

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/VolumeIcon.qml
  applet/contents/ui/main.qml
  src/context.h
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Marco Martin


> On April 20, 2016, 11:46 a.m., Andreas Kainz wrote:
> > there is one problem the icon colors don't fit the colors from the color 
> > scheme
> > 
> > https://techbase.kde.org/Projects/Usability/HIG/Color
> > 
> > icon red != danger red
> > icon green != verdant green
> > 
> > plasma blue is nearly equal with icon blue but the other colors don't fit.
> > 
> > If you like I can check if the more fleshy new colors would work as well 
> > but I think not cause the idea of monochrome icons is to move the user 
> > interface to the background and let the content be more visible.

the color that are available from the color theme are text colors, so the 
normal icon color is text color, and as well for those red/yellow/blue (to see, 
go in the color theme config kcm) in the breeze color scheme is actually #27ae60
one possibility may be playing with opacity such as overlaid over the standard 
background, the resulting color is toned down the right amount


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/#review94728
---


On April 20, 2016, 11:21 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127696/
> ---
> 
> (Updated April 20, 2016, 11:21 a.m.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> add named colors for positive (usually green)
> neutral(usually yellow) negative(usually red)
> foreground objects, such as text or parts of
> svg icons/themes
> 
> 
> Diffs
> -
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
>   autotests/themetest.cpp 3992246 
>   src/plasma/private/theme_p.cpp 1aaf021 
>   src/plasma/theme.h 271328c 
> 
> Diff: https://git.reviewboard.kde.org/r/127696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Andreas Kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/#review94728
---



there is one problem the icon colors don't fit the colors from the color scheme

https://techbase.kde.org/Projects/Usability/HIG/Color

icon red != danger red
icon green != verdant green

plasma blue is nearly equal with icon blue but the other colors don't fit.

If you like I can check if the more fleshy new colors would work as well but I 
think not cause the idea of monochrome icons is to move the user interface to 
the background and let the content be more visible.

- Andreas Kainz


On April 20, 2016, 11:21 vorm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127696/
> ---
> 
> (Updated April 20, 2016, 11:21 vorm.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> add named colors for positive (usually green)
> neutral(usually yellow) negative(usually red)
> foreground objects, such as text or parts of
> svg icons/themes
> 
> 
> Diffs
> -
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
>   autotests/themetest.cpp 3992246 
>   src/plasma/private/theme_p.cpp 1aaf021 
>   src/plasma/theme.h 271328c 
> 
> Diff: https://git.reviewboard.kde.org/r/127696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Powerdevil] [Bug 361974] Power saving settings for monitor have no effect

2016-04-20 Thread Christoph Feck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361974

Christoph Feck  changed:

   What|Removed |Added

   Assignee|plasma-b...@kde.org |plasma-devel@kde.org
  Component|general |general
Product|systemsettings  |Powerdevil

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 127696: add Positive, Neutral, Negative text colors

2016-04-20 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

add named colors for positive (usually green)
neutral(usually yellow) negative(usually red)
foreground objects, such as text or parts of
svg icons/themes


Diffs
-

  autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
  autotests/themetest.cpp 3992246 
  src/plasma/private/theme_p.cpp 1aaf021 
  src/plasma/theme.h 271328c 

Diff: https://git.reviewboard.kde.org/r/127696/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: another Kirigami issue - overlap of header and listview

2016-04-20 Thread Marco Martin
On Tuesday 19 April 2016, Dirk Hohndel wrote:
> go). The latter always appears to have the top item aligned with the
> header, but when I tap on the header and have scrollTopAnimation run to:
> 0, then the header overlaps the top element in the ListView.
> 
> A patch like this seems to fix the problem

thanks, i pushed it plus some fixes on top of it (using topPadding instead of 
the height)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Closed] D1449: Hook up virtual_desktop_changeable state.

2016-04-20 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINf2e4e1192936: Hook up virtual_desktop_changeable state. 
(authored by hein).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1449?vs=3428=3433

REVISION DETAIL
  https://phabricator.kde.org/D1449

AFFECTED FILES
  abstract_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Closed] D1448: Add a virtual_desktop_changable state to the window protocol.

2016-04-20 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND021f67f3f470: Add a virtual_desktop_changable state 
to the window protocol. (authored by hein).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1448?vs=3427=3432

REVISION DETAIL
  https://phabricator.kde.org/D1448

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated, 240 lines] D1366: Add Event Sounds stream to Applications list

2016-04-20 Thread drosca (David Rosca)
drosca updated this revision to Diff 3431.
drosca added a comment.


  Store device name for event role stream

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1366?vs=3308=3431

BRANCH
  event-sounds-stream

REVISION DETAIL
  https://phabricator.kde.org/D1366

AFFECTED FILES
  src/CMakeLists.txt
  src/context.cpp
  src/context.h
  src/eventstream.cpp
  src/eventstream.h
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/main.qml
  src/maps.h
  src/pulseobject.h
  src/stream.cpp
  src/stream.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: broulik, colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma 5.7 Test Days prep meeting #2 notes & log

2016-04-20 Thread Luca Beltrame
Il 19 aprile 2016 14:10:56 CEST, Eike Hein  ha scritto:

>- No comm yet with other distros
>- einar77 may be able to interface with openSUSE for us

Thanks for poking me - the ISOs were stuck due to a packaging hiccup. I can say 
that we'll be able to provide test ISOs. I put links to them in the wiki as 
well (Riddell poked me on IRC about them).

-- 
Luca Beltrame
GPG key ID: 6E1A4E79
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Accepted] D1448: Add a virtual_desktop_changable state to the window protocol.

2016-04-20 Thread Martin Gräßlin
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Accepted] D1449: Hook up virtual_desktop_changeable state.

2016-04-20 Thread Martin Gräßlin
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel