[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

[jriddell (Jonathan Riddell)]

jriddell added a comment.


  Maintainers answered on https://github.com/googlei18n/noto-fonts/issues/711 
and they seem to recommend git versions over tar versions

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1816

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jriddell, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126689: Change minimum Size of Calendar

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126689/
---

(Updated Juni 10, 2016, 10:42 nachm.)


Status
--

This change has been discarded.


Review request for Plasma and Heiko Tietze.


Repository: plasma-workspace


Description
---

it's the minimum usefull size for the calendar applet on the desktop

https://git.reviewboard.kde.org/r/126356/


Diffs
-

  applets/calendar/contents/ui/main.qml f545e47 

Diff: https://git.reviewboard.kde.org/r/126689/diff/


Testing
---


File Attachments


calendar min
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/94ccc241-fc5d-4987-afd4-9139ab0d45d7__calendarMinimumSize.png
calender size wi
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/d73ce900-fcad-498f-9570-34842483b60e__calenderSize.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126356: change minimum size of clipboard

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/
---

(Updated Juni 10, 2016, 10:40 nachm.)


Status
--

This change has been discarded.


Review request for Plasma and Heiko Tietze.


Repository: plasma-workspace


Description
---

if you use clipboard on the desktop the minimum window height is heigher than 
you use clipboard from the panel (drop down window). As the user can define the 
width and height for the desktop plasmoid the minimum allowed height should be 
at least the same than the drop down window in the panel. so I change the 
minimumHeig to 16.


Diffs
-

  applets/clipboard/contents/ui/clipboard.qml 97230c1 

Diff: https://git.reviewboard.kde.org/r/126356/diff/


Testing
---


File Attachments


old before with 26 min height
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
new after with 16 min height
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/566b420b-df44-44d4-86b3-b9f2d441aed8__clipboardMinimumSize.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/
---

(Updated June 10, 2016, 10:37 p.m.)


Review request for Plasma and Friedrich W. H. Kossebau.


Changes
---

only the defined changes

I don't use versions or something else. If you found an issue please let me 
know. I don't add new stuff only coding issues.


Repository: kdeplasma-addons


Description
---

the scaling work now better and the pading between the single lines can be 
smaler (If you make the applet higher you can also have the old line spacing)

it's my first qml change, so ...

on my todo, I'd like to change the powerd by weather.com text color so a 
secondary gray (bring it a bit more to the background), but I don't know how.


Diffs (updated)
-

  applets/weather/package/contents/ui/TopPanel.qml 1821f16 
  applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
  applets/weather/package/contents/ui/main.qml d490728 

Diff: https://git.reviewboard.kde.org/r/128108/diff/


Testing
---

with breeze and breeze dark color scheme on two different pc's. the icons are 
breeze weather icons (master)


File Attachments


screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
I hope I had fixed all open issues. I now have only one open issue I could 
change the linkColor but I can't change the color when there is no link like in 
noaa
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

SDDM Theme update

[kainz.a]

Hi David,

kde neon dev ship the new breeze sddm theme (thanks jonathan). It look
really good, but I have also some remarks:

1. the avatar icon is to small (not the same size than the plymount icon)
2. can we use the ? and generic avatar I prepare for you
3. the search for user avatar is higher than the user avatar
4. can we align center the button text like the user name (cause the theme
is also center align)
5. you see the breeze cursor only when you hover the avatar or the bottons
(not the wallpaper) it is possible to see also the breeze cursors when you
are at the wallpaper
6. the drop down indicators (session and keyboard layout) look to smal
7. can the drop down text have a bigger size
8. it look like there is a problem with the restart icon (I will check this)
9. when you use the tab key to switch between the bottons you see a light
blue frame around the botton can it switch to the same layout as you see
when you hover the botton with the mouse

thank you very much david that you work on the theme.
Andreas Kainz
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Mark Gaiser]

This is funny. It's related to this, but i didn't want to keep this
information from you folks :)

Now that i have this issue i'm looking at some old mailing list archives of
2008.
At one point there apparently was a proposal for a "JobViewServer"
specification [1] that supported file transfer details and was originally
inspired by this mockup [2]. That specification apparently never lasted
long since it was superseded by the notifications specifications [3]. That
spec in turn apparently lost the ability to send file progress updates over
dbus. Mind you, this was 2008! Then - years later - ubuntu apparently
somewhere in 2011 [4] made the LauncherAPI (the wiki history goes back till
Feb. 2011 so i guess it is from around that time).

In 2011 Ubuntu apparently had the power to do what was years before
envisioned for KDE [2] and somewhere in 2010 also implemented for KDE [5].
I don't think it ever made it in an official KDE release.

Now - again years later - Kai apparently stumbled upon the Ubuntu
LauncherAPI [4] and implemented it for Plasma, what was supposed to be a
KDE idea to begin with. It's ironic how old ideas somewhere get lost in
history to be reinvented by someone else and then picked up by the team
that originally invented it in the first place :)

So much irony!

I do have one question for this though. Why did the transfer progress never
made it in the notifications api? That really smells like a massive missed
opportunity back in the 2008 days? All it took would have been a revision
update (current one is 0.9 from 2006). And perhaps another revision with
the other missing bits that the LauncherAPI has which the notification spec
lacks.

Cheers,
Mark

[1]
http://markmail.org/message/vlfjvfksbu3643u7#query:+page:1+mid:2p7ait73n5l2nqeu+state:results
[2] http://kde-look.org/content/show.php?content=33673
[3] http://www.galago-project.org/specs/notification/0.9/index.html
[4] https://wiki.ubuntu.com/Unity/LauncherAPI
[5] http://kde-look.org/content/show.php/SmartNotify?content=133472

On Fri, Jun 10, 2016 at 10:10 PM, Mark Gaiser  wrote:

> On Fri, Jun 10, 2016 at 9:04 PM, Kai Uwe Broulik 
> wrote:
>
>> Hi,
>>
>> > Could you please reconsider that implementation detail?
>>
>> Why? You still have the job progress in the notification area with time
>> and controls by default. It's just that you need to disable them both for
>> the legacy dialog to show up.
>>
>
> Sure, do you mind explaining how i can turn these settings back on?
> I really can't find those settings anymore and if i remember correctly the
> one setting to change the progress from notification area to dialog only
> shows up if you have the notification area one. I had that set to the
> dialog one so now i can't get that setting to appear anymore.. Or i'm just
> overlooking it every single time..
>
> I had also disabled the status in the taskbar (i was guessing that would
> bring back the dialog since the other setting would already be OK for me),
> but no dialog appeared. Granted, i didn't restart plasma... I will try
> again with a plasma restart after it (note: those simple things shouldn't
> require a desktop restart..)
>
> But ehh.. Your suggestion would make me lose the status in the taskbar..
> I'm ok with that, but i find that feature rather neat. Isn't there a way to
> have the dialog and the taskbar status?
>
>>
>> I was thinking of providing the full UI in task manager but since not all
>> jobs have an application (window) associated with them I didn't.
>
>
> I think that would get a bit full in the popup.. You would have the
> transfer speed in there (perhaps in chart form like the network manager
> has?) and controls to pause and cancel. It might fit, but it might also
> feel like too much information for the user. Then again, please do that
> since it would be much better :)
>
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Mark Gaiser]

On Fri, Jun 10, 2016 at 9:04 PM, Kai Uwe Broulik 
wrote:

> Hi,
>
> > Could you please reconsider that implementation detail?
>
> Why? You still have the job progress in the notification area with time
> and controls by default. It's just that you need to disable them both for
> the legacy dialog to show up.
>

Sure, do you mind explaining how i can turn these settings back on?
I really can't find those settings anymore and if i remember correctly the
one setting to change the progress from notification area to dialog only
shows up if you have the notification area one. I had that set to the
dialog one so now i can't get that setting to appear anymore.. Or i'm just
overlooking it every single time..

I had also disabled the status in the taskbar (i was guessing that would
bring back the dialog since the other setting would already be OK for me),
but no dialog appeared. Granted, i didn't restart plasma... I will try
again with a plasma restart after it (note: those simple things shouldn't
require a desktop restart..)

But ehh.. Your suggestion would make me lose the status in the taskbar..
I'm ok with that, but i find that feature rather neat. Isn't there a way to
have the dialog and the taskbar status?

>
> I was thinking of providing the full UI in task manager but since not all
> jobs have an application (window) associated with them I didn't.


I think that would get a bit full in the popup.. You would have the
transfer speed in there (perhaps in chart form like the network manager
has?) and controls to pause and cancel. It might fit, but it might also
feel like too much information for the user. Then again, please do that
since it would be much better :)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Kai Uwe Broulik]

Hi,

> Could you please reconsider that implementation detail?

Why? You still have the job progress in the notification area with time and 
controls by default. It's just that you need to disable them both for the 
legacy dialog to show up.

I was thinking of providing the full UI in task manager but since not all jobs 
have an application (window) associated with them I didn't. 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Thomas Pfeiffer]

On 10.06.2016 20:53, Mark Gaiser wrote:
On Fri, Jun 10, 2016 at 6:55 PM, Kai Uwe Broulik > wrote:


Hi,

oh, heh. Yeah I'm using the job dataengine and if there's any user of it
the job view server will be started and job progress is sent there instead.

You can disable the "show application status" thing in task manager
settings. Might need two separate settings (one for unity launchers, one
for application jobs).

Cheers,
Kai Uwe


oh..

Could you please reconsider that implementation detail?

I like the status in the taskbar, but i would like it to be *additional* 
information besides the information that used to be shown. In my case i'd like 
to have the process window (where i can actually see how fast a transfer is 
progressing, how long it will take and cancel it if needed for whatever 
reason). Now i can't do anything, not even cancel it..




Wouldn't it make much more sense to integrate the needed functionality in the 
taskbar popup instead of having progress shown in two different places at once?


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Mark Gaiser]

On Fri, Jun 10, 2016 at 6:55 PM, Kai Uwe Broulik 
wrote:

> Hi,
>
> oh, heh. Yeah I'm using the job dataengine and if there's any user of it
> the job view server will be started and job progress is sent there instead.
>
> You can disable the "show application status" thing in task manager
> settings. Might need two separate settings (one for unity launchers, one
> for application jobs).
>
> Cheers,
> Kai Uwe
>

oh..

Could you please reconsider that implementation detail?

I like the status in the taskbar, but i would like it to be *additional*
information besides the information that used to be shown. In my case i'd
like to have the process window (where i can actually see how fast a
transfer is progressing, how long it will take and cancel it if needed for
whatever reason). Now i can't do anything, not even cancel it..
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

[Friedrich W. H. Kossebau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/#review96349
---



With the latest diff I get these runtime errors on the console:

file:///home/koder/System/kf5-devel/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/TopPanel.qml:62:15:
 Unable to assign [undefined] to QString
file:///home/koder/System/kf5-devel/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/TopPanel.qml:73:15:
 Unable to assign [undefined] to QString
file:///home/koder/System/kf5-devel/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/TopPanel.qml:83:15:
 Unable to assign [undefined] to QString

And accordingly broken does the toppanel look here. So please fix that.

More, please remove the changes you added in the last version of this review 
request to the busy indicator and the high/low display again and provide them 
in a separate review request, those might need more discussion. The other 
design changes you did in the first version of this review request seemed fine 
to me, so let's get them in independently already (but only with a fixed 
version :) ).

- Friedrich W. H. Kossebau


On June 8, 2016, 10:25 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128108/
> ---
> 
> (Updated June 8, 2016, 10:25 p.m.)
> 
> 
> Review request for Plasma and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> the scaling work now better and the pading between the single lines can be 
> smaler (If you make the applet higher you can also have the old line spacing)
> 
> it's my first qml change, so ...
> 
> on my todo, I'd like to change the powerd by weather.com text color so a 
> secondary gray (bring it a bit more to the background), but I don't know how.
> 
> 
> Diffs
> -
> 
>   applets/weather/package/contents/ui/FiveDaysView.qml 5023373 
>   applets/weather/package/contents/ui/TopPanel.qml 1821f16 
>   applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
>   applets/weather/package/contents/ui/configWeatherStation.qml 86ed521 
>   applets/weather/package/contents/ui/main.qml d490728 
> 
> Diff: https://git.reviewboard.kde.org/r/128108/diff/
> 
> 
> Testing
> ---
> 
> with breeze and breeze dark color scheme on two different pc's. the icons are 
> breeze weather icons (master)
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
> I hope I had fixed all open issues. I now have only one open issue I could 
> change the linkColor but I can't change the color when there is no link like 
> in noaa
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 135 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/135/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Jun 2016 18:14:13 +
Build duration: 9 min 39 sec

CHANGE SET
Revision 528a51fa5935cd43d72eff51961d0c2374ce2034 by Friedrich W. H. Kossebau: 
([weather] Document amp; align data types and values set for weather)
  change: edit dataengines/weather/ions/wetter.com/ion_wettercom.cpp
  change: edit templates/ion-dataengine/src/ion-%{APPNAMELC}.cpp
  change: edit dataengines/weather/ions/data/envcan_i18n.dat
  change: edit dataengines/weather/ions/ion.h
  change: edit dataengines/weather/ions/envcan/ion_envcan.h
  change: edit dataengines/weather/ions/noaa/ion_noaa.cpp
  change: edit dataengines/weather/ions/bbcukmet/ion_bbcukmet.h
  change: edit dataengines/weather/ions/data/bbcukmet_i18n.dat
  change: edit dataengines/weather/ions/noaa/ion_noaa.h
  change: edit dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  change: edit dataengines/weather/ions/envcan/ion_envcan.cpp
  change: edit dataengines/weather/ions/ion.cpp
  change: edit dataengines/weather/ions/data/noaa_i18n.dat


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5016 
(39%)CONDITIONAL 1381/5070 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2742 (5%)CONDITIONAL 
87/2797 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New idea for Plasma's logo

[Thomas Pfeiffer]

On 10.06.2016 11:44, Alessandro Longo wrote:
I like a lot the idea. I suggest to invite people to post their logos to 
visual-design mailing list, to to let them know that it exists. Sending an 
email with an attachment should be enough accessible for everyone and we will 
have a transparent process and a log of discussions.


I would not do it on the mailing list. Subscribing to a mailing list is a bigger 
barrier for many than signing up on our forums, and previous design competitions 
have always taken place on the forums, so I'd do this one there as well.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Kai Uwe Broulik]

Hi,

oh, heh. Yeah I'm using the job dataengine and if there's any user of it the 
job view server will be started and job progress is sent there instead. 

You can disable the "show application status" thing in task manager settings. 
Might need two separate settings (one for unity launchers, one for application 
jobs).

Cheers, 
Kai Uwe 



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: What happened to Dolphin's transfer dialog?

[Mark Gaiser]

Thank you, Alexander!

I was also suspecting that change to have caused it, but i don't see that
change disabling (or removing) the progress window.
Actually, i;m not even sure which part is responsible for putting the
progress window in screen. It could be dolphin specific, but it could also
be KIO.. Or something in dolphin that triggers something in KIO.

It's likely one of the two, but i don't know any of that with 100%
certainty.

Anyway, i hope the plasma folks have a better understanding of where
something might have gone wrong.

On Thu, Jun 9, 2016 at 2:57 PM, Alexander Potashev 
wrote:

> CCed plasma-devel and Kai because your problem is probably tied with
> this commit:
>
>
> http://commits.kde.org/plasma-desktop/e284e9dc17051f22d05985e218fa44ddaba78de5
>
> --
> Alexander Potashev
>
> 2016-06-05 19:29 GMT+03:00 Mark Gaiser :
> > Hi,
> >
> > I used to have the file transfer dialog n Dolphin.
> > Plasma by default showed (past tense, it changed) the copy of a file in
> the
> > lower right corner in some round animating thing that was slowly filling
> up.
> > I never found that very useful and disabled it since that gave me the
> "old
> > fashioned" file transfer dialog. That was OK.
> >
> > Now however, i just noticed that i have no transfer dialog at all
> anymore.
> > All i have now is a transfer
> > "status" by looking at the taskbar which now fills up. That on it's own
> - as
> > supplement - would've been a very nice addition, no argument there. But
> now
> > i don't see a transfer speed, don't have an option to cancel a transfer
> at
> > all. That cannot be the intended way of how this is supposed to work,
> right?
> >
> > So, ehh.. Did the file transfer dialog got removed?
> > Or is there still an option somewhere to turn it back on?
> >
> > Cheers,
> > Mark
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D1820: Properly call Toplevel::setSurface for wl_surface_id X11 client message event

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  For an X11 window through Xwayland KWin gets a client message with the
  Surface id. KWin has two code paths for handling that:
  
  - Wayland Surface is created after the X11 event
  - Wayland Surface is created before the X11 event
  
  In the first code path in WaylandServer KWin called Toplevel::setSurface,
  the other code path just updated the m_surface without calling into
  setSurface. This means the connects for the Surface were not set up,
  resulting in the worst case in accessing deleted memory after the Surface
  was destroyed.
  
  This change now ensures that setSurface is called from both code paths.
  That should fix the potential crash and could also be a fix to the
  problem that sometimes X windows seem to not be damaged correctly.

REPOSITORY
  rKWIN KWin

BRANCH
  events-call-setSurface

REVISION DETAIL
  https://phabricator.kde.org/D1820

AFFECTED FILES
  events.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

[jriddell (Jonathan Riddell)]

jriddell added a comment.


  Release management of Noto is curious, depending on where you get your 
release from it is released.
  
  I've filed an issue to ask why it's not in the download tar 
https://github.com/googlei18n/noto-fonts/issues/711
  
  Our current default is Oxygen Mono which is unmaintained and no longer 
released so it's no worse.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1816

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jriddell, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  If it's not released, we can't use it.
  
  I'm sure you've personally told me that when I've needed Kubuntu to do 
something in the past.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1816

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jriddell, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 11 lines] D1816: Switch to Noto Mono as default monospace font

[jriddell (Jonathan Riddell)]

jriddell created this revision.
jriddell added reviewers: Plasma, Plasma: Design.
jriddell set the repository for this revision to rPLASMAINTEGRATION Integration 
for Qt applications in Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Noto Mono was added to Noto's git repository in January. Although it's not in 
the tar download of Noto fonts it is just as available to package as the 
previous font Oxygen mono.

TEST PLAN
  Install, log out and in again, you should have noto font.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1816

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kfontsettingsdata.cpp
  src/platformtheme/mono_font.sh
  src/platformtheme/mono_font.upd

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jriddell, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127781: Remove clearly broken code

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127781/
---

(Updated June 10, 2016, 1:47 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 0204ff4446b4ee397bb1c7b979acad951de8be22 by David 
Edmundson to branch master.


Repository: plasma-integration


Description
---

This line never would have found anything and therefore clearly is not
used and wasn't tested.

Even assuming there wasn't a typo, it's a hardcoded path and we don't
install anything there.


Diffs
-

  src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e 

Diff: https://git.reviewboard.kde.org/r/127781/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1814: Add TaskManager requestActivities

[mart (Marco Martin)]

mart added a comment.


  +1

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1814

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 97 lines] D1815: Add an Activities list into the context menu

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes the task manager's context menu match KWin's titlebar context
  menu.
  
  BUG: 261649
  CCBUG: 360293

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  activities_menu

REVISION DETAIL
  https://phabricator.kde.org/D1815

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/Task.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 156 lines] D1814: Add TaskManager requestActivities

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Acts like requestVirtualDesktops only with a QStringList
  
  make runningActivities invokable

TEST PLAN
  See subsequent plasma-desktop review

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1814

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.h
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1744: Fix the ignore struts multi-screen handling

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D1744#33668, @apol wrote:
  
  > I just tested the patch, the issue isn't solved here.
  
  
  can you please xprop the panel and provide the xrandr. I just want to be sure 
that you are not hitting a similar problem like @lbeltrame whose panel had an 
incorrect strut value in addition.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1744

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, lbeltrame, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1779: Add a parent_window event to Plasma Window interface

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D1779#33666, @hein wrote:
  
  >   Now if the latter is the semantics we want to bake into the protocol, we 
should make that clear in the docs and consider misuse a bug (i.e. document 
that it's wrong to have a window with a parent if the window isn't temporary). 
Otherwise we shouldn't use "transient".
  
  
  Transient in the context of windowing system has the meaning parent-child 
relationship. That's the only usage of the word I know. E.g. see 
https://en.wikipedia.org/wiki/Transient_%28computer_programming%29#X
  
  On Wayland the situation is exactly the same and what this API provides is a 
parent-child relationship - which is a transient. Following the description of 
Wikipedia the child window will not outlife the parent window, thus it's a 
"transient" or a "temporary" window.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1779

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1744: Fix the ignore struts multi-screen handling

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  I just tested the patch, the issue isn't solved here.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1744

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, lbeltrame, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1779: Add a parent_window event to Plasma Window interface

[hein (Eike Hein)]

hein added a comment.


  Hmm I'm concerned about using "transient" in the API docs and code. 
"Transient" is a descriptory adjective that means "temporary", i.e. if a window 
is a transient to some other window, it communicates two things: The 
association to the other window, and the expectation that this window is not 
permanent and shouldn't be treated as such. Now if the latter is the semantics 
we want to bake into the protocol, we should make that clear in the docs and 
consider misuse a bug (i.e. document that it's wrong to have a window with a 
parent if the window isn't temporary). Otherwise we shouldn't use "transient".

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1779

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 134 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/134/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Jun 2016 10:55:53 +
Build duration: 10 min

CHANGE SET
Revision 2d7b6692d3647c643d6feee2e8585f3a060b4b24 by hein: (Add missing 
hasChildren() implementation.)
  change: edit libtaskmanager/taskgroupingproxymodel.cpp
  change: edit libtaskmanager/taskgroupingproxymodel.h


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5016 
(39%)CONDITIONAL 1381/5070 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2742 (5%)CONDITIONAL 
87/2797 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128148/
---

(Updated June 10, 2016, 1:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit f5ad210742c9fe27e7dd7988221777a1346976d0 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

If x > screenWidth should be if x > screenLeft + screenWidth 

otherwise all right hand screens get offset


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.cpp 
926df31c0c6db48549d340207d11fd298b52b629 

Diff: https://git.reviewboard.kde.org/r/128148/diff/


Testing
---

TaskManager context menus open in the right place.

(alternately qmenu seems to do this anyway, so I think we can just delete this 
entire section)


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1811: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN2343a90aa517: UpdateClientArea from 
ShellClient::doSetGeometry if the ShellClient has a strut (authored by 
graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1811?vs=4320=4325#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1811?vs=4320=4325

REVISION DETAIL
  https://phabricator.kde.org/D1811

AFFECTED FILES
  autotests/wayland/struts_test.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1799: Add missing hasChildren() implementation.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE2d7b6692d364: Add missing hasChildren() 
implementation. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1799?vs=4291=4324

REVISION DETAIL
  https://phabricator.kde.org/D1799

AFFECTED FILES
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1811: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut

[Martin Gräßlin]

graesslin added a comment.


  Just as an fyi: I added a test case to expose the actual problem to the 
change which I'll now push.

REPOSITORY
  rKWIN KWin

BRANCH
  update-struts-on-geometry-change

REVISION DETAIL
  https://phabricator.kde.org/D1811

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128148/#review96343
---


Ship it!




Ship It!

- Eike Hein


On June 10, 2016, 9:56 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128148/
> ---
> 
> (Updated June 10, 2016, 9:56 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> If x > screenWidth should be if x > screenLeft + screenWidth 
> 
> otherwise all right hand screens get offset
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp 
> 926df31c0c6db48549d340207d11fd298b52b629 
> 
> Diff: https://git.reviewboard.kde.org/r/128148/diff/
> 
> 
> Testing
> ---
> 
> TaskManager context menus open in the right place.
> 
> (alternately qmenu seems to do this anyway, so I think we can just delete 
> this entire section)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D1813#33652, @mart wrote:
  
  > shouldn't be kde2QtFilter() fixed instead?
  
  
  I guess I can try, but I'm not sure what exactly the function does...
  Btw this is the commit where it was introduced: 
https://github.com/KDE/kdelibs/commit/365105fa9f827ffb7401c86eb6c1c1f4f088236a

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: mart, plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

[mart (Marco Martin)]

mart added a comment.


  shouldn't be kde2QtFilter() fixed instead?

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: mart, plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1793: [Device Notifier] Be more declarative

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1793

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1803: Fix the strut handling for wayland clients

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN58db4777966e: Fix the strut handling for wayland clients 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1803?vs=4299=4323

REVISION DETAIL
  https://phabricator.kde.org/D1803

AFFECTED FILES
  autotests/wayland/struts_test.cpp
  geometry.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: bshah, plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 25 lines] D1813: Fix selected name filter with multiple mimetypes

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Plasma.
elvisangelaccio added a subscriber: Plasma.
elvisangelaccio set the repository for this revision to rPLASMAINTEGRATION 
Integration for Qt applications in Plasma.
elvisangelaccio added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  For some reason, the `kde2QtFilter()` function returns an empty string when 
the filedialog has more than one mimetype set (through `setMimeTypeFilters()`) 
and the user selects a specific filter (among the default filters provided by 
those mimetypes).
  
  This patch just adds a simple fallback when that function is about to return 
an empty string.

TEST PLAN
  - build/tests/qfiledialogtest --mimeFilter application/json --mimeFilter 
application/zip
  - Select the json filter
  - Select a json file
  - Check the "selected name filter" in the debug output. Without patch -> 
empty string, with the patch: `JSON document (*.json)`

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1813

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  tests/qfiledialogtest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1803: Fix the strut handling for wayland clients

[bshah (Bhushan Shah)]

bshah added a comment.


  Sounds sane, but not completely confident to Accept it.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1803

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: bshah, plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128148/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

If x > screenWidth should be if x > screenLeft + screenWidth 

otherwise all right hand screens get offset


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.cpp 
926df31c0c6db48549d340207d11fd298b52b629 

Diff: https://git.reviewboard.kde.org/r/128148/diff/


Testing
---

TaskManager context menus open in the right place.

(alternately qmenu seems to do this anyway, so I think we can just delete this 
entire section)


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1811: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  update-struts-on-geometry-change

REVISION DETAIL
  https://phabricator.kde.org/D1811

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New idea for Plasma's logo

[Alessandro Longo]

I like a lot the idea. I suggest to invite people to post their logos to 
visual-design mailing list, to to let them know that it exists. Sending 
an email with an attachment should be enough accessible for everyone and 
we will have a transparent process and a log of discussions.


--
Alessandro Longo
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New idea for Plasma's logo

[Alessandro Longo]

Il 09-06-2016 11:49 Thomas Pfeiffer ha scritto:


You posted a screenshot from your system on Google+ [1] where you use
your proposed logo (although not in monochrome) as a launcher icon.
This might have added to the confusion.

[1]
https://plus.google.com/u/0/photos/photo/100036546744213767408/6287945369516307842


I was testing the logo and in the meanwhile I posted a screenshot to 
show an other thing, I didn't think this could make confusion, sorry. 
The post is on my Google+ stream, I think I should be able to post 
things freely on my Google+ stream or in my blog, without caring of 
people think is something official. This would be a problem also because 
of my posts "Plasma Tricks" that sometimes are very hackish and (I 
suppose) not so recommended by Plasma developers.
So I hope we can clarify what we can post to make clear it's not 
"official".


About people that thought my logo was reviewed by VDG, why didn't they 
speak directly in mailing list? I would have been happy to clarify it in 
that day.


--
Alessandro Longo
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 3 lines] D1812: Update window geometry when creating the decoration in ShellClient

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  When managing a new decorated ShellClient we observed that the window
  gets placed with a wrong geometry and on next damage event expands into
  a strutted area.
  
  The main reason for this behavior is that the window geometry did not
  get updated when creating the decoration. With this change the geometry
  gets updated, so that the placement is performed on the correct geometry.
  
  The change itself does not yet cover all conditions. E.g. a maximized
  windows which will get decorations will be incorrectly sized. This
  requires further changes.

REPOSITORY
  rKWIN KWin

BRANCH
  update-geometry-on-create-deco

REVISION DETAIL
  https://phabricator.kde.org/D1812

AFFECTED FILES
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128144: Windecoration KCM theme color

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128144/#review96340
---



\-1

Using Plasma theme in widgets-dialogs is a no-go.

Proper fix would be:
SystemPalette \{
id: syspal
\}

and then for the buttons and stuff: syspal.base and so on. Ideally the 
decoration QML bridge exposed the current colorscheme for the decoration-


kcmkwin/kwindecoration/qml/Buttons.qml (line 47)


While at it, add spaces:

15 * layout.spacing



kcmkwin/kwindecoration/qml/Buttons.qml (lines 216 - 217)


I fear this might lead to double spacing when Qt applies its widget-scaling 
and then Plasma does it ontop.



kcmkwin/kwindecoration/qml/Buttons.qml (lines 221 - 224)


Why that change?


- Kai Uwe Broulik


On Juni 9, 2016, 11:30 nachm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128144/
> ---
> 
> (Updated Juni 9, 2016, 11:30 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> change the button area of the windowdecoration kcm to use the theme colors.
> 
> 
> Diffs
> -
> 
>   kcmkwin/kwindecoration/qml/Buttons.qml 2e64873 
> 
> Diff: https://git.reviewboard.kde.org/r/128144/diff/
> 
> 
> Testing
> ---
> 
> system settings -> Window Decoration -> Buttons tab used breeze dark color 
> scheme.
> 
> 
> File Attachments
> 
> 
> dark theme bug
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/09/e0dd4fae-2a84-4b1e-a37d-f0ad75899050__bug.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel