[kio-extras] [Bug 366638] [16.04] sftp stuck operations. Can operate only if reopening Dolphin

2016-10-26 Thread Germano Massullo
https://bugs.kde.org/show_bug.cgi?id=366638

--- Comment #5 from Germano Massullo  ---
Confirming on 16.08.1 / 5.26.0 / Plasma 5.7.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-26 Thread drosca (David Rosca)
drosca added a comment.


  In https://phabricator.kde.org/D2314#58816, @Zren wrote:
  
  > All I did was copy the Menu widget's pattern (sorta) since it was the first 
example I could find.
  
  
  Yeah, PlasmaComponents.ContextMenu sucks but if possible, I would prefer the 
declarative approach too. If not, then fine, but at least replace the 
Qt.createQmlObject with Component.createObject.
  
  > Not sure if VDG has talked about this yet, but here's a few things that 
could be added on top of the this context menu:
  > 
  > - Toggle Volume Boost (between 100% and 150%) so maximum isn't always 150%.
  > - Selecting "Default [device]" can move all the current app streams to that 
device.
  
  Sure, if we have a context menu I am not against adding a few more features 
to it. However, the main question for VDG is if we may actually have the 
context menu at all.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2314

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, #plasma, #plasma:_design
Cc: davidedmundson, drosca, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart added a comment.


  in this version, i'm rebuilding everything on scriptengine teardown, this 
should make work correctly even if one adds a new plugin, or removes one.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Updated, 42 lines] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart updated this revision to Diff 7679.
mart added a comment.


  - move the config syncing in ~ScriptEngine()

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3166?vs=7672=7679

BRANCH
  arcpatch-D3166

REVISION DETAIL
  https://phabricator.kde.org/D3166

AFFECTED FILES
  shell/scripting/containment.cpp
  shell/scripting/scriptengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Updated] D3168: Use microphone volume icon for capture devices/streams in applet

2016-10-26 Thread drosca (David Rosca)
drosca added a reviewer: Plasma: Design.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D3168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated, 68 lines] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7677.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  qvector::fill

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3159?vs=7666=7677

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3159

AFFECTED FILES
  main_wayland.cpp
  platform.cpp
  platform.h
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.h
  screens.cpp
  screens.h
  wayland_server.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Updated, 2,277 lines] D3169: Implementation of PointerGestures protocol

2016-10-26 Thread Martin Gräßlin
graesslin updated this revision to Diff 7676.
graesslin added a comment.


  Fix comments.
  
  Apparently I also need to try to compile after adding documentation...

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3169?vs=7675=7676

BRANCH
  pointer-gestures

REVISION DETAIL
  https://phabricator.kde.org/D3169

AFFECTED FILES
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_wayland_seat.cpp
  src/client/CMakeLists.txt
  src/client/pointergestures.cpp
  src/client/pointergestures.h
  src/client/protocols/pointer-gestures-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/pointer_interface_p.h
  src/server/pointergestures_interface.cpp
  src/server/pointergestures_interface.h
  src/server/pointergestures_interface_p.h
  src/server/pointergestures_interface_v1.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h
  src/tools/mapping.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 2,277 lines] D3169: Implementation of PointerGestures protocol

2016-10-26 Thread Martin Gräßlin
graesslin created this revision.
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Plasma on Wayland.

REVISION SUMMARY
  Pointer gestures are created for a pointer and there are two types of
  gestures: swipe and pinch.
  
  At a given time there can only be one active gesture. The implementation
  in SeatInterface ensures that there can only be one active gesture.
  
  Each gesture consists of a start event, 0 to multiple update events and
  an end event. The end can also be a cancel. To better support this the
  implementation doesn't follow the protocol and splits end and cancel
  into dedicated methods in the server side and into dedicated signals in
  the client side.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  pointer-gestures

REVISION DETAIL
  https://phabricator.kde.org/D3169

AFFECTED FILES
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_wayland_seat.cpp
  src/client/CMakeLists.txt
  src/client/pointergestures.cpp
  src/client/pointergestures.h
  src/client/protocols/pointer-gestures-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/pointer_interface_p.h
  src/server/pointergestures_interface.cpp
  src/server/pointergestures_interface.h
  src/server/pointergestures_interface_p.h
  src/server/pointergestures_interface_v1.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h
  src/tools/mapping.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D3168: Use microphone volume icon for capture devices/streams in applet

2016-10-26 Thread drosca (David Rosca)
drosca added a comment.


  F379870: Spectacle.M21792.png 

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D3168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Request, 62 lines] D3168: Use microphone volume icon for capture devices/streams in applet

2016-10-26 Thread drosca (David Rosca)
drosca created this revision.
drosca added a reviewer: Plasma.
drosca added a subscriber: andreaska.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It doesn't make sense to show speaker volume icon
  for capture streams when we now have microphone volume icons.

TEST PLAN
  The only issue is with default Breeze icons where the speaker
  volume icon visually looks bigger than the microphone volume because the
  volume indicator is on the right for speaker icon and on the top for the
  microphone icon.
  @andreaska Any ideas?

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3168

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/VolumeIcon.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Commented On] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart added a comment.


  In https://phabricator.kde.org/D3166#58841, @davidedmundson wrote:
  
  > Also this script is making an optimistic assumption that in the script 
where you might be modding containment configs, you'd create a containment 
instance. That's not always true (like from the evaluate script DBus calls).
  
  
  yeah, if no containment wrapper instances exist, this may not get executed.
  I think it should probably be attempted when tearing down the whole scripting 
engine stuff instead.
  
  in order to make adding actions (or changing existing ones) working, a loop 
of Containment::setContainmentActions should be executed looping trought the 
config that just has been written
  
  > Maybe do this for 5.8, but you really need to expose a new method (or even 
Actions object) to do this properly - or to delay the loading.
  
  I would really like to avoid creating any new api  with this qtscript stuff, 
given the state of qtscript, but I think is feasible to make the current manual 
config poking fully work.
  existing scripts in 5.8 has to work, so yeah.
  i don't see possible delaying the loading, as the desktop containment has to 
already exist by the time the script is executed (see the long story of fixes 
of scripting during the early 5.7)
  
  > BTW: The script in the bug report has a bug, it's only going to configure 
the actions on containment 0; even though you'll be reconfiguring the "correct" 
one.
  
  no, that group is not the containment id, it is the containment type, so 
[ActionPlugins][0] means plugins for desktop containments, [ActionPlugins][1] 
for panel containments (enum ContainmentType in plasma.h) so that script 
correctly changes actions for "desktop" containments

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Requested Changes To] D3166: make sure containment actions config is up to date

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Edit, I think I understand.
  
  So the script is modifying the actions not through some actions part of the 
API, but through just manually prodding the config.
  Manually prodding the config naturally has no effect at runtime changes.
  
  This isn't a very thorough solution.
  
  You're covering containment actions being reconfigured, but not covering them 
being added or removed - an equally plausible thing to script.
  
  Also this script is making an optimistic assumption that in the script where 
you might be modding containment configs, you'd create a containment instance. 
That's not always true (like from the evaluate script DBus calls).
  
  Maybe do this for 5.8, but you really need to expose a new method (or even 
Actions object) to do this properly - or to delay the loading.
  
  BTW: The script in the bug report has a bug, it's only going to configure the 
actions on containment 0; even though you'll be reconfiguring the "correct" one.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Commented On] D3166: make sure containment actions config is up to date

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson added a comment.


  > If the containment actions plugins have been
  
  configured in the startup script, their config must be
  reloaded when the script ends,
  
  That part makes sensebut why is this code in the containment destructor?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Request, 21 lines] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  if the containment actions plugins have been
  configured in the startup script, their config must be
  reloaded when the script ends, otherwise during the plasma
  session the config will be outdated
  
  BUG:371704

TEST PLAN
  the patch has been tested on new sessions with a customized look and feel 
package (maui) that changes the visible context menu entries

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/resetcontact

REVISION DETAIL
  https://phabricator.kde.org/D3166

AFFECTED FILES
  shell/scripting/containment.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D3163: Remove deprecated useraccount

2016-10-26 Thread Martin Gräßlin
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3163

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-26 Thread Zren (Chris Holland)
Zren added a comment.


  > Do we need to do it programatically?
  
  All I did was copy the Menu widget's pattern (sorta) since it was the first 
example I could find. It would need to populate hundreds of menu's (most 
unused), so that makes sense that it would do things dynamically.
  
  Not sure if VDG has talked about this yet, but here's a few things that could 
be added on top of the this context menu:
  
  - Toggle Volume Boost (between 100% and 150%) so maximum isn't always 150%.
  - Selecting "Default [device]" can move all the current app streams to that 
device.
  
  
https://github.com/Zren/plasma-applets/blob/master/org.kde.plasma.volumewin7mixer/package/contents/ui/MixerItem.qml#L455
  
  F379785: 2016-10-26___08-37-07.png 

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2314

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, #plasma, #plasma:_design
Cc: davidedmundson, drosca, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Request, 1 line] D3165: Remove line that does nothing

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  AppletInterface is designed to expose Applet methods to QML space.
  
  Emitting a signal on appletinterface from QML doesn't acheieve anything
  as all we'll do is notify the QML code which we're already in.
  
  We intention was probably to re-evaluate anything connected to
  Applet::contextualActionsAboutToShow, but that's not happening.

TEST PLAN
  Opened toolbox, it looked the same

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3165

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: Review Request 129263: Don't show "Alternatives" menu by default

2016-10-26 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129263/
---

(Updated Oct. 26, 2016, 1:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c2465889991a2ebc88195dd008e49afdff7023a5 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

And only enable it in the contextMenuAboutToShow connection.

We currently enable/disable the menu in this slot, but we default to it on. 
This meant other users of actions() that can't correctly emit 
contextMenuAboutToShow gain an extra entry which might not be relevant.


Diffs
-

  src/plasma/private/applet_p.cpp bfb6d2502a2fc804497e571e7000e20a40a20d5c 

Diff: https://git.reviewboard.kde.org/r/129263/diff/


Testing
---

Appears on kickoff
Doesn't appear on the system tray

(as before)

No longer appears in the toolbox (new fix)


Thanks,

David Edmundson



Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread Marco Martin


> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote:
> > This made the Alternatives action visible in toolbox menu.
> > 
> > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on 
> > `AppletInterface`, but the connection between 
> > `Applet::contextualActionsAboutToShow` and 
> > `AppletInterface::contextualActionsAboutToShow` is only one way (signal 
> > from `Applet` gets propageted to `AppletInterface`, not the other way).
> > This never worked (emitting `contextualActionsAboutToShow` from plasmoid), 
> > but only this change exposed it.
> > 
> > I have no idea how to fix it, other than adding new method to 
> > `AppletInterface` to emit this signal or hacky both-way connection.
> 
> David Edmundson wrote:
> can we not just set the default visibility of the action to false?
> That way if aboutToShow fails, we don't show this.
> 
> David Rosca wrote:
> Ah right, indeed, simple solution :D
> But the underlying issue still remains, which would be good to somehow 
> fix (or just say it doesn't work like that and don't try to call it from 
> plasmoids).
> 
> David Edmundson wrote:
> Emitting a signal on another object is already implicitly a bit of a 
> hack, I don't a user should expect that to always work.
> 
> As you said above, the only proper fix is a new method in 
> AppletInterface. Shall I do that?
> 
> I'd like to merge https://git.reviewboard.kde.org/r/129263/ anyway so 
> that we can fix Plasma 5.8.

yeah, that small fix makes sense.

i would keep it as is as that changes fixes it, to avoid to add a new method 
until really needed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/#review100291
---


On Oct. 3, 2016, 10:45 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129086/
> ---
> 
> (Updated Oct. 3, 2016, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's reasnoble to expect people to download an applet just before trying
> to change an existing applet using the alternatives system.
> 
> Therefore doing the check that any alternative applets exist during applet 
> initialisation time is semantically
> wrong as the option will be prematurely disabled.
> 
> This patch moves it to be verified in contextualActionsAboutToShow.
> 
> This patch also gives a startup performance boost.
> Loading all the applets metadata takes a small amount of time (~50 
> milliseconds) not really noticable when you're doing it once, but it adds up 
> when we're doing it for a lot of applets in a row.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
>   src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 
> 
> Diff: https://git.reviewboard.kde.org/r/129086/diff/
> 
> 
> Testing
> ---
> 
> Right click on kickoff, option was there and worked
> Right click on system tray, no option
> Locked widges, option wasn't there
> Unlocked widgets, option in kickoff came back
> 
> Context menu still appears "instantly"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Re: Review Request 129263: Don't show "Alternatives" menu by default

2016-10-26 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129263/#review100297
---


Ship it!




Ship It!

- Marco Martin


On Oct. 26, 2016, 10:56 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129263/
> ---
> 
> (Updated Oct. 26, 2016, 10:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> And only enable it in the contextMenuAboutToShow connection.
> 
> We currently enable/disable the menu in this slot, but we default to it on. 
> This meant other users of actions() that can't correctly emit 
> contextMenuAboutToShow gain an extra entry which might not be relevant.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/applet_p.cpp bfb6d2502a2fc804497e571e7000e20a40a20d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/129263/diff/
> 
> 
> Testing
> ---
> 
> Appears on kickoff
> Doesn't appear on the system tray
> 
> (as before)
> 
> No longer appears in the toolbox (new fix)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson


> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote:
> > This made the Alternatives action visible in toolbox menu.
> > 
> > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on 
> > `AppletInterface`, but the connection between 
> > `Applet::contextualActionsAboutToShow` and 
> > `AppletInterface::contextualActionsAboutToShow` is only one way (signal 
> > from `Applet` gets propageted to `AppletInterface`, not the other way).
> > This never worked (emitting `contextualActionsAboutToShow` from plasmoid), 
> > but only this change exposed it.
> > 
> > I have no idea how to fix it, other than adding new method to 
> > `AppletInterface` to emit this signal or hacky both-way connection.
> 
> David Edmundson wrote:
> can we not just set the default visibility of the action to false?
> That way if aboutToShow fails, we don't show this.
> 
> David Rosca wrote:
> Ah right, indeed, simple solution :D
> But the underlying issue still remains, which would be good to somehow 
> fix (or just say it doesn't work like that and don't try to call it from 
> plasmoids).

Emitting a signal on another object is already implicitly a bit of a hack, I 
don't a user should expect that to always work.

As you said above, the only proper fix is a new method in AppletInterface. 
Shall I do that?

I'd like to merge https://git.reviewboard.kde.org/r/129263/ anyway so that we 
can fix Plasma 5.8.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/#review100291
---


On Oct. 3, 2016, 10:45 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129086/
> ---
> 
> (Updated Oct. 3, 2016, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's reasnoble to expect people to download an applet just before trying
> to change an existing applet using the alternatives system.
> 
> Therefore doing the check that any alternative applets exist during applet 
> initialisation time is semantically
> wrong as the option will be prematurely disabled.
> 
> This patch moves it to be verified in contextualActionsAboutToShow.
> 
> This patch also gives a startup performance boost.
> Loading all the applets metadata takes a small amount of time (~50 
> milliseconds) not really noticable when you're doing it once, but it adds up 
> when we're doing it for a lot of applets in a row.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
>   src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 
> 
> Diff: https://git.reviewboard.kde.org/r/129086/diff/
> 
> 
> Testing
> ---
> 
> Right click on kickoff, option was there and worked
> Right click on system tray, no option
> Locked widges, option wasn't there
> Unlocked widgets, option in kickoff came back
> 
> Context menu still appears "instantly"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Review Request 129263: Don't show "Alternatives" menu by default

2016-10-26 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129263/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

And only enable it in the contextMenuAboutToShow connection.

We currently enable/disable the menu in this slot, but we default to it on. 
This meant other users of actions() that can't correctly emit 
contextMenuAboutToShow gain an extra entry which might not be relevant.


Diffs
-

  src/plasma/private/applet_p.cpp bfb6d2502a2fc804497e571e7000e20a40a20d5c 

Diff: https://git.reviewboard.kde.org/r/129263/diff/


Testing
---

Appears on kickoff
Doesn't appear on the system tray

(as before)

No longer appears in the toolbox (new fix)


Thanks,

David Edmundson



Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca


> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote:
> > This made the Alternatives action visible in toolbox menu.
> > 
> > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on 
> > `AppletInterface`, but the connection between 
> > `Applet::contextualActionsAboutToShow` and 
> > `AppletInterface::contextualActionsAboutToShow` is only one way (signal 
> > from `Applet` gets propageted to `AppletInterface`, not the other way).
> > This never worked (emitting `contextualActionsAboutToShow` from plasmoid), 
> > but only this change exposed it.
> > 
> > I have no idea how to fix it, other than adding new method to 
> > `AppletInterface` to emit this signal or hacky both-way connection.
> 
> David Edmundson wrote:
> can we not just set the default visibility of the action to false?
> That way if aboutToShow fails, we don't show this.

Ah right, indeed, simple solution :D
But the underlying issue still remains, which would be good to somehow fix (or 
just say it doesn't work like that and don't try to call it from plasmoids).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/#review100291
---


On Oct. 3, 2016, 10:45 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129086/
> ---
> 
> (Updated Oct. 3, 2016, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's reasnoble to expect people to download an applet just before trying
> to change an existing applet using the alternatives system.
> 
> Therefore doing the check that any alternative applets exist during applet 
> initialisation time is semantically
> wrong as the option will be prematurely disabled.
> 
> This patch moves it to be verified in contextualActionsAboutToShow.
> 
> This patch also gives a startup performance boost.
> Loading all the applets metadata takes a small amount of time (~50 
> milliseconds) not really noticable when you're doing it once, but it adds up 
> when we're doing it for a lot of applets in a row.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
>   src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 
> 
> Diff: https://git.reviewboard.kde.org/r/129086/diff/
> 
> 
> Testing
> ---
> 
> Right click on kickoff, option was there and worked
> Right click on system tray, no option
> Locked widges, option wasn't there
> Unlocked widgets, option in kickoff came back
> 
> Context menu still appears "instantly"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson


> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote:
> > This made the Alternatives action visible in toolbox menu.
> > 
> > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on 
> > `AppletInterface`, but the connection between 
> > `Applet::contextualActionsAboutToShow` and 
> > `AppletInterface::contextualActionsAboutToShow` is only one way (signal 
> > from `Applet` gets propageted to `AppletInterface`, not the other way).
> > This never worked (emitting `contextualActionsAboutToShow` from plasmoid), 
> > but only this change exposed it.
> > 
> > I have no idea how to fix it, other than adding new method to 
> > `AppletInterface` to emit this signal or hacky both-way connection.

can we not just set the default visibility of the action to false?
That way if aboutToShow fails, we don't show this.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/#review100291
---


On Oct. 3, 2016, 10:45 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129086/
> ---
> 
> (Updated Oct. 3, 2016, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's reasnoble to expect people to download an applet just before trying
> to change an existing applet using the alternatives system.
> 
> Therefore doing the check that any alternative applets exist during applet 
> initialisation time is semantically
> wrong as the option will be prematurely disabled.
> 
> This patch moves it to be verified in contextualActionsAboutToShow.
> 
> This patch also gives a startup performance boost.
> Loading all the applets metadata takes a small amount of time (~50 
> milliseconds) not really noticable when you're doing it once, but it adds up 
> when we're doing it for a lot of applets in a row.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
>   src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 
> 
> Diff: https://git.reviewboard.kde.org/r/129086/diff/
> 
> 
> Testing
> ---
> 
> Right click on kickoff, option was there and worked
> Right click on system tray, no option
> Locked widges, option wasn't there
> Unlocked widgets, option in kickoff came back
> 
> Context menu still appears "instantly"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/#review100291
---



This made the Alternatives action visible in toolbox menu.

The problem is that toolbox tries to emit `contextualActionsAboutToShow` on 
`AppletInterface`, but the connection between 
`Applet::contextualActionsAboutToShow` and 
`AppletInterface::contextualActionsAboutToShow` is only one way (signal from 
`Applet` gets propageted to `AppletInterface`, not the other way).
This never worked (emitting `contextualActionsAboutToShow` from plasmoid), but 
only this change exposed it.

I have no idea how to fix it, other than adding new method to `AppletInterface` 
to emit this signal or hacky both-way connection.

- David Rosca


On Oct. 3, 2016, 10:45 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129086/
> ---
> 
> (Updated Oct. 3, 2016, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's reasnoble to expect people to download an applet just before trying
> to change an existing applet using the alternatives system.
> 
> Therefore doing the check that any alternative applets exist during applet 
> initialisation time is semantically
> wrong as the option will be prematurely disabled.
> 
> This patch moves it to be verified in contextualActionsAboutToShow.
> 
> This patch also gives a startup performance boost.
> Loading all the applets metadata takes a small amount of time (~50 
> milliseconds) not really noticable when you're doing it once, but it adds up 
> when we're doing it for a lot of applets in a row.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
>   src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 
> 
> Diff: https://git.reviewboard.kde.org/r/129086/diff/
> 
> 
> Testing
> ---
> 
> Right click on kickoff, option was there and worked
> Right click on system tray, no option
> Locked widges, option wasn't there
> Unlocked widgets, option in kickoff came back
> 
> Context menu still appears "instantly"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



[Differential] [Changed Subscribers] D3159: Set wayland output scale

2016-10-26 Thread broulik (Kai Uwe Broulik)
broulik added inline comments.

INLINE COMMENTS

> x11windowed_backend.cpp:477-480
> +QVector ret;
> +for (auto it = m_windows.constBegin(); it != m_windows.constEnd(); ++it) 
> {
> +ret << initialOutputScale();
> +}

QVector ::fill(const T , int size = -1)

Assigns value to all items in the vector. If size is different from -1 (the 
default), the vector is resized to size size beforehand.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3159

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Updated, 70 lines] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7666.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  int -> real

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3159?vs=7660=7666

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3159

AFFECTED FILES
  main_wayland.cpp
  platform.cpp
  platform.h
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.h
  screens.cpp
  screens.h
  wayland_server.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Commented On] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in main_wayland.cpp:638
> hmm I'm not sure whether we should implement it as an int factor. Even if 
> Wayland only supports integer scaling, I think that's a bad idea and we 
> should rather go with fractal scaling from the start. Of course towards 
> Wayland we need to expose it as integer scaling. But in case Wayland gets an 
> update we would be prepared.

Makes sense to me. I'll do that change.

> graesslin wrote in wayland_server.cpp:353
> At the moment KWin doesn't scale yet. I think we should not start to export 
> scale to Wayland as long as we don't support it.
> 
> The idea behind the scale in Wayland is that the compositor itself scales up 
> all surfaces which don't provide the correct scale factor. Just mentioning in 
> case you are not aware of it.

I started doing the relevant surface scaling, but that's quite a bit more 
complex than it might first appear (and the Qt QPA needs multiple patches...) 
so I need to split this into multiple smaller parts.

Personally, I think setting this now is fine because I haven't implemented 
anything in the DRM backend, so this is only going to affect kwin when this 
config option is explicitly set.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3159

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D3089: WIP: Restore global menu support

2016-10-26 Thread Martin Gräßlin
graesslin added inline comments.

INLINE COMMENTS

> abstract_client.h:667
> +void applicationMenuActiveChanged(bool);
> +void requestShowApplicationMenu();
>  

is that a signal (context is missing in diff)? If yes it sounds more like a 
slot.

> abstract_client.h:1017
> +
> +bool m_applicationMenuActive;
> +QString m_applicationMenuServiceName;

default init missing

> appmenu.cpp:68-71
> +return Workspace::self()->findClient([&](const Client *c) {
> +return c->applicationMenuServiceName() == serviceName
> +&& c->applicationMenuObjectPath() == menuObjectPath.path();
> +});

careful here: that will only find (X11) Clients but not ShellClient. You might 
want a variant which finds AbstractClients.

> client.cpp:2150-2151
> +{
> +const QString  = 
> QString::fromUtf8(Xcb::StringProperty(m_client, 
> atoms->kde_net_wm_appmenu_service_name));
> +const QString  = 
> QString::fromUtf8(Xcb::StringProperty(m_client, 
> atoms->kde_net_wm_appmenu_object_path));
> +

this causes two roundtrips to the X server. Please split into variants which 
reduce to one roundtrip in the case of the update  (from events.cpp) and to 
zero roundtrips in case of manage.

> client.h:334
>  
> +void updateApplicationMenu();
> +

I don't like that it has the same name as a method in parent class

> shell_client.h:138
>  
> +void updateApplicationMenu();
> +

I don't like that it has the same name as a method in parent class

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3089

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2016-10-26 Thread somnium
https://bugs.kde.org/show_bug.cgi?id=371276

somnium  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|INVALID |---

--- Comment #5 from somnium  ---
Is it maybe possible, that the password prompt is not working? My ssd is
encrypted.

In KDE NEON in an Virtualbox it is working, because I have no password prompt.

It is also working in an x11 enviroment on openSUSE and Arch, but only the
animation. I can't test the password prompt in x11.

So maybe this is failing in breeze-plymouth.

I really don't know what else can be wrong as all the other graphical splash
screens are working, only breeze-plymouth stays black.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 1,233 lines] D3163: Remove deprecated useraccount

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It was only kept behind to install some pictures, which are now
  installed by user-manager.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3163

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/useraccount/CMakeLists.txt
  kcms/useraccount/Messages.sh
  kcms/useraccount/README
  kcms/useraccount/chfacedlg.cpp
  kcms/useraccount/chfacedlg.h
  kcms/useraccount/faceDlg.ui
  kcms/useraccount/kcm_useraccount.desktop
  kcms/useraccount/kcm_useraccount.kcfg
  kcms/useraccount/main.cpp
  kcms/useraccount/main.h
  kcms/useraccount/main_widget.ui
  kcms/useraccount/pics/  Ada.png
  kcms/useraccount/pics/  Alice.png
  kcms/useraccount/pics/  Grace.png
  kcms/useraccount/pics/  James.png
  kcms/useraccount/pics/  Leonardo.png
  kcms/useraccount/pics/  Mahatma.png
  kcms/useraccount/pics/  Mowgli.png
  kcms/useraccount/pics/ Dragon.png
  kcms/useraccount/pics/ Kati.png
  kcms/useraccount/pics/ Konqui.png
  kcms/useraccount/pics/ Logger.png
  kcms/useraccount/pics/ Parley.png
  kcms/useraccount/pics/ Rekonqui.png
  kcms/useraccount/pics/CMakeLists.txt
  kcms/useraccount/pics/_bomb.png
  kcms/useraccount/pics/_happy.png
  kcms/useraccount/pics/blackbox.png
  kcms/useraccount/pics/green.png
  kcms/useraccount/pics/listening.png
  kcms/useraccount/pics/notme.png
  kcms/useraccount/pics/sources/  Ada.svgz
  kcms/useraccount/pics/sources/  Alice.svgz
  kcms/useraccount/pics/sources/  Grace.svgz
  kcms/useraccount/pics/sources/  James.svgz
  kcms/useraccount/pics/sources/  Leonardo.svgz
  kcms/useraccount/pics/sources/  Mahatma.svgz
  kcms/useraccount/pics/sources/  Mowgli.svgz
  kcms/useraccount/pics/sources/ Dragon.svgz
  kcms/useraccount/pics/sources/ Kati.svgz
  kcms/useraccount/pics/sources/ Konqui.svgz
  kcms/useraccount/pics/sources/ Logger.svgz
  kcms/useraccount/pics/sources/ Parley.svgz
  kcms/useraccount/pics/sources/ Rekonqui.svgz
  kcms/useraccount/pics/sources/_bomb.svgz
  kcms/useraccount/pics/sources/_happy.svgz
  kcms/useraccount/pics/sources/blackbox.svgz
  kcms/useraccount/pics/sources/green.svgz
  kcms/useraccount/pics/sources/listening.svgz
  kcms/useraccount/pics/sources/notme.svgz
  kcms/useraccount/pics/sources/tv.svgz
  kcms/useraccount/pics/tv.png
  kcms/useraccount/settings.kcfgc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: Review Request 129255: Fixed unrar version check.

2016-10-26 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129255/#review100290
---


Ship it!




Ship It!

- Marco Martin


On Oct. 24, 2016, 9:27 p.m., Massimiliano Torromeo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129255/
> ---
> 
> (Updated Oct. 24, 2016, 9:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 341305
> https://bugs.kde.org/show_bug.cgi?id=341305
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> The parameter "--version" stopped working since unrar 5.2 which was
> released almost 2 years ago.
> With this change this now becomes the minimum version required but
> every distribution that is going to include a version of KDE with
> this commit has probably been using unrar > 5.2 for quite a while
> so I don't think there is any need to provide a fallback.
> 
> This fixes bugs 367626 and 341305
> 
> 
> Diffs
> -
> 
>   thumbnail/comiccreator.cpp 4ec0db8c6953e2d9983e4a9d7f542b27404175e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129255/diff/
> 
> 
> Testing
> ---
> 
> Verified that the previously missing thumbnails for cbr files are now being 
> correctly generated.
> 
> 
> Thanks,
> 
> Massimiliano Torromeo
> 
>



Re: Minutes Monday Plasma Meeting

2016-10-26 Thread Marco Martin
On Monday 24 October 2016, Sebastian Kügler wrote:
> Plasma meeting (IRC), 24-10-2016
> 
> Present: mgraesslin, romangg, bshah, d_ed, Sho, sebas

been away on monday and tuesday, adding my stuff for last week:

* port all output in libplasma to QCDebug/QCWarning
* prototype of a more modern/minimal looking scrollbar in Breeze 
https://www.youtube.com/watch?v=O72qxQHjHcw wip patch (code still ugly) 
https://phabricator.kde.org/D3131
* Kirigami2
** first rough Android deploy of the gallery, lot known bugs: 
http://notmart.org/misc/kirigami/kirigami-gallery.apk
** tabbar page in the gallery for testing
** better Page margins for non scrollable pages
** better interaction with the minimal scrollbar style
* work on QQC2 desktop style
** better look for the scrollbar
** TabBar.qml
** TabButton.qml
** TextEdit.qml
** fixed issues in other controls
** removed Kirigami dependencies

-- 
Marco Martin


Re: moving kdepasswd to plasma-desktop/kcms/useraccount?

2016-10-26 Thread Marco Martin
On Monday 24 October 2016, Aleix Pol wrote:
> I don't think this addresses David's question.
> 
> "weird politics" is a bad explanation (I'm unaware of the back story).
> 
> Does that mean we can remove it then?

indeed, it's time for a final decision on this


-- 
Marco Martin


[Differential] [Updated, 299 lines] D3089: WIP: Restore global menu support

2016-10-26 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 7664.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - Rebase on master
  - Implement ShellClient so it reads the property from Wayland windows
  
  The menu button shows up on Wayland but the menu itself doesn't - the menu is 
properly exported, though, I can access the menu from my applet just fine, as 
long as I know the DBus service name and object path, that is.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7575=7664

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D3159: Set wayland output scale

2016-10-26 Thread Martin Gräßlin
graesslin added a comment.


  I suggest to also implement in the virtual platform in order to be able to 
auto-test it.

INLINE COMMENTS

> main_wayland.cpp:528
> +i18n("The scale for windowed mode. 
> Default value is 1."),
> +QStringLiteral("height"));
> +scaleOption.setDefaultValue(QString::number(1));

careful here: copy and paste error

> main_wayland.cpp:638
>  int outputCount = 1;
> +int outputScale = 1;
>  

hmm I'm not sure whether we should implement it as an int factor. Even if 
Wayland only supports integer scaling, I think that's a bad idea and we should 
rather go with fractal scaling from the start. Of course towards Wayland we 
need to expose it as integer scaling. But in case Wayland gets an update we 
would be prepared.

> wayland_server.cpp:353
>  OutputInterface *output = m_display->createOutput(m_display);
> +output->setScale(s->scale(i));
>  const QRect  = s->geometry(i);

At the moment KWin doesn't scale yet. I think we should not start to export 
scale to Wayland as long as we don't support it.

The idea behind the scale in Wayland is that the compositor itself scales up 
all surfaces which don't provide the correct scale factor. Just mentioning in 
case you are not aware of it.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3159

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D3162: Pass a desktopfile name to kcmshell5

2016-10-26 Thread Martin Gräßlin
graesslin added a comment.


  F379470: kwin_screenshot_ri2629.png 

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3162

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas


[Differential] [Request, 70 lines] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Provides a virtual method in Screens where backends can supply the scale
  of each screen, this is then set on each output.
  
  For the X windowed backend this value is taken from a command line
  parameter.

TEST PLAN
  Ran windowed mode with --scale 1 and 2
  then kate --platform=wayland from another screen.
  On the latter case UI elements were scaled up correctly

REPOSITORY
  rKWIN KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3159

AFFECTED FILES
  main_wayland.cpp
  platform.cpp
  platform.h
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.h
  screens.cpp
  screens.h
  wayland_server.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas


[Differential] [Updated] D3160: [kcmshell] set application data only after parsing command line

2016-10-26 Thread Martin Gräßlin
graesslin added a dependent revision: D3161: [kcmshell] Use desktop file name 
of module as app's desktop file.

REPOSITORY
  rKDECLITOOLS KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D3160

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 10 lines] D3161: [kcmshell] Use desktop file name of module as app's desktop file

2016-10-26 Thread Martin Gräßlin
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  By default kcmshell5 registers as org.kde.kcmshell5, but such a desktop
  file does not exist. Which means that on Wayland neither window manager
  nor task manager is able to provide a useful window icon for
  configuration window.
  
  This change tries to locate the desktop file of the module passed to
  kcmshell5. If it is found it is set as the application's desktop file
  name. Thus the compositor and task manager actually know the desktop
  file which was used to start the kcmshell5 instance.
  
  This is only done if kcmshell5 is invoked for only one module. In case
  of multiple modules the application invoking kcmshell5 should pass a
  proper desktop file name through the command line argument. And if the
  desktopfile got specified already it is not updated from the module.

TEST PLAN
  KWin Effects KCM shows proper icon on Wayland

REPOSITORY
  rKDECLITOOLS KDE CLI Utilities

BRANCH
  desktop-file-name

REVISION DETAIL
  https://phabricator.kde.org/D3161

AFFECTED FILES
  kcmshell/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D3161: [kcmshell] Use desktop file name of module as app's desktop file

2016-10-26 Thread Martin Gräßlin
graesslin added a comment.


  F379454: kwin_screenshot_QZ2629.png 
  
  Desktop Effect settings show proper icon on Wayland instead of generic one.

REPOSITORY
  rKDECLITOOLS KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D3161

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 6 lines] D3160: [kcmshell] set application data only after parsing command line

2016-10-26 Thread Martin Gräßlin
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KAboutData provides some information needed for the output of the
  command line options like version. Thus it needs to be called before
  processing the QCommandLineParser. But if done before any command line
  arguments are processed the switch like --desktopfile does not work.
  
  This change reorders the calls so that the command line is first parsed,
  then the options of the KAboutData are processed. After that the about
  data is set on the application and the command line parser is processed.
  
  With this change both the version option and the desktopfile option is
  working. It's important for kcmshell to have the desktopfile option
  working so that applications using kcmshell5 as a helper to show
  configuration can pass their own app id to kcmshell5, so that it e.g.
  registers to a Wayland compositor as org.kde.foo instead of
  org.kde.kcmshell5.

TEST PLAN
  Run kcmshell5 --version, --help, --list and --desktopfile
  and compared to variant before

REPOSITORY
  rKDECLITOOLS KDE CLI Utilities

BRANCH
  kaboutdata-parse

REVISION DETAIL
  https://phabricator.kde.org/D3160

AFFECTED FILES
  kcmshell/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D3161: [kcmshell] Use desktop file name of module as app's desktop file

2016-10-26 Thread Martin Gräßlin
graesslin added a dependency: D3160: [kcmshell] set application data only after 
parsing command line.

REPOSITORY
  rKDECLITOOLS KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D3161

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 8 lines] D3162: Pass a desktopfile name to kcmshell5

2016-10-26 Thread Martin Gräßlin
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  In order to have a proper window icon for kcmshell5 on Wayland KWin
  needs to pass a desktop file name as command line argument.
  
  The desktop file of kwinfocus is used as it uses the
  preferences-system-windows icon which is also the icon on X11.

REPOSITORY
  rKWIN KWin

BRANCH
  useractions-desktopfile

REVISION DETAIL
  https://phabricator.kde.org/D3162

AFFECTED FILES
  useractions.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas