[Differential] [Closed] D3225: Don't snap to auto-hidden panels

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN679e41780888: Don't snap to auto-hidden panels (authored 
by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3225?vs=7822&id=7845

REVISION DETAIL
  https://phabricator.kde.org/D3225

AFFECTED FILES
  autotests/integration/move_resize_window_test.cpp
  geometry.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3227: [helpers/killer] Use instead of

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN7681e312c580: [helpers/killer] Use  instead of  
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3227?vs=7829&id=7846

REVISION DETAIL
  https://phabricator.kde.org/D3227

AFFECTED FILES
  helpers/killer/killer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, schwarzer, #plasma, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Jannis Mat]

https://bugs.kde.org/show_bug.cgi?id=350365

Jannis Mat  changed:

   What|Removed |Added

 CC||jan...@hackbraten.men

--- Comment #7 from Jannis Mat  ---
Same problem here on Gentoo, running Linux 4.7.10, KDE frameworks 5.26.0 and
Plasma 5.7.5. I have first seen this after upgrading from Plasma 5.6 and
frameworks 5.23.
Also, it seems that only the systray is affected by this. The lockscreen shows
the battery level and the screen brightness is set correctly when unplugging
from AC power.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Jannis Mast]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #8 from Jannis Mast  ---
(In reply to Jannis Mast from comment #7)
> Same problem here on Gentoo, running Linux 4.7.10, KDE frameworks 5.26.0 and
> Plasma 5.7.5. I have first seen this after upgrading from Plasma 5.6 and
> frameworks 5.23.
> Also, it seems that only the systray is affected by this. The lockscreen
> shows the battery level and the screen brightness is set correctly when
> unplugging from AC power.

I've just noticed that restarting plasmashell seems to fix this sometimes (no
need to log out and restart the entire session)

Plasmashell produces the following output in .xsession-errors, could be related
to this problem?
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:39:
Unable to assign [undefined] to int   
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:44:39:
Unable to assign [undefined] to bool

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: DrKonqi and BKO

[René J . V . Bertin]

Martin Klapetek wrote:


>> Bug trackers are not trace trackers. Spending time on solving the
>> actual problem is the best thing https://retrace.fedoraproject.org/
>> https://errors.ubuntu.com/
> 
> 
> They're not, yet we're using it as one. So might as well improve
> the experience at least a bit.

Are we? I have no idea what a trace tracker is, and the intro on the fedora 
site 
doesn't tell me much more than that it analyses coredumps and then makes the 
information available to the person who submitted it.

I don't see how that would help KDE when bug reports are coming from Mac, MSWin 
or any other non-Linux platform. I would like to think that any developer of a 
(KDE) application or library that isn't platform-specific by its intended 
application would be interested in receiving reports from all platforms where 
his/her code is used.

Backtraces are a crucial part of bug reports, so support for them has their 
place on bug trackers and in utilities to submit reports to those trackers. The 
only reason why uploading a backtrace as an attachment isn't currently the 
ideal 
solution for the current problems is that this makes it impossible to search 
for 
existing bug reports.

However, I do think it's more important that bug report can be filed as easily 
as 
possible; if that means dropping the duplicate-search feature for the time 
being, so be it. After all, it's not like it's giving the perfect protection 
against duplicate reports.

Either way, if "solving the actual problem" means looking into trace trackers 
that's not a DrKonqi responsibility - not until there is such a thing to 
interface with.

R.

[Differential] [Commented On] D3210: make scrollbar size configurable

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D3210#60184, @colomar wrote:
  
  > It does make sense to me to give the option to turn the slim scroll bar as 
such on and off. I can imagine some people being uncomfortable with the 
animation on mouseover.
  >  Being able to configure individual parameters is probably overkill, 
however.
  
  
  So, just to make sure I understand:
  
  - 1 option to "only show full scrollbar on mouse over" (as we have now)
  - 1 option to "use slim scrollbar" (with reduced width handle)
  
  Is that what you have in mind ? or do you suggest to group the two ? 
  (in which case I'm pretty sure some users will want one and not the other, 
namely slim scrollbar with groove always visible, no groove but large handle, 
etc.)
  
  Also,
  
  - what about keeping the hit area unchanged (20 pixels), and consistent with 
the rest of breeze, this whether the scrollbar is slim or not ?
  - and what about an even larger toolbar (as in the current patch) ? (which I 
think is not necessary, and inconsistent with the rest of breeze).
  
  Note that if we don't add a larger scrollbar, then the current combobox can 
be turned into a simple checkbox (which I would find preferable too).
  
  Thanks for the feedback,
  
  Hugo
  
  One last comment about options: every time one adds one, one make the code 
maintenance more complicated, with more combinations to test each time a change 
to the code is made. Just saying :)

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Review Request 129318: Add an option to context menu to launch the application on a discrete graphics card

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129318/
---

Review request for Plasma and Eike Hein.


Repository: plasma-desktop


Description
---

In Fedora 25 there have been many improvements regarding dual graphics support 
and they recently added an option to Gnome to launch the application using a 
dicrete graphics card, by just overriding DRI_PRIME environment variable, see 
http://www.hadess.net/2016/10/dual-gpu-integration-in-gnome.html. This option 
is available based on simple dbus service implemented here 
https://github.com/hadess/switcheroo-control/ providing just a single property 
whether the user has dual GPU. This dbus thingie is enabled in Fedora 25 by 
default. This patch tries to add this option the same way as Gnome does. I'm 
just not sure about using qputenv(), but I couldn't find a better way as using 
QProcess, which allows to set environment variables, won't have that nice mouse 
effect of opening application, at least I think it won't.


Diffs
-

  applets/kicker/plugin/actionlist.h 869354c 
  applets/kicker/plugin/actionlist.cpp 2aa97d9 
  applets/kicker/plugin/appentry.cpp 80290e1 
  applets/kicker/plugin/recentusagemodel.cpp 24874ff 
  applets/kicker/plugin/runnermatchesmodel.cpp 4e4845c 

Diff: https://git.reviewboard.kde.org/r/129318/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129318: Add an option to context menu to launch the application on a discrete graphics card

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129318/
---

(Updated Lis. 3, 2016, 9:21 dop.)


Review request for Plasma and Eike Hein.


Changes
---

Remove trailing spaces, somehow this auto-remove trailing spaces was disabled 
in my KDevelop.


Repository: plasma-desktop


Description
---

In Fedora 25 there have been many improvements regarding dual graphics support 
and they recently added an option to Gnome to launch the application using a 
dicrete graphics card, by just overriding DRI_PRIME environment variable, see 
http://www.hadess.net/2016/10/dual-gpu-integration-in-gnome.html. This option 
is available based on simple dbus service implemented here 
https://github.com/hadess/switcheroo-control/ providing just a single property 
whether the user has dual GPU. This dbus thingie is enabled in Fedora 25 by 
default. This patch tries to add this option the same way as Gnome does. I'm 
just not sure about using qputenv(), but I couldn't find a better way as using 
QProcess, which allows to set environment variables, won't have that nice mouse 
effect of opening application, at least I think it won't.


Diffs (updated)
-

  applets/kicker/plugin/actionlist.h 869354c 
  applets/kicker/plugin/actionlist.cpp 2aa97d9 
  applets/kicker/plugin/appentry.cpp 80290e1 
  applets/kicker/plugin/recentusagemodel.cpp 24874ff 
  applets/kicker/plugin/runnermatchesmodel.cpp 4e4845c 

Diff: https://git.reviewboard.kde.org/r/129318/diff/


Testing
---


Thanks,

Jan Grulich

[Differential] [Request, 9 lines] D3239: [kstyle] Delay init of Wayland setup till next event cycle

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: Plasma, broulik, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a change mostly for KWin (the Wayland compositor). The internal
  Wayland connection is created after the QStyle is created in the case of
  KWin. But both are created before the event dispatcher is run for the
  first time. So delaying by one cycle makes it work for KWin and also all
  other Wayland applications.
  
  BUG: 372001
  FIXED-IN: 5.8.4

REPOSITORY
  rBREEZE Breeze

BRANCH
  delay-init-wayland-shadow-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3239

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3239: [kstyle] Delay init of Wayland setup till next event cycle

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  No objection, you're the expert ! 
  Thanks !

REPOSITORY
  rBREEZE Breeze

BRANCH
  delay-init-wayland-shadow-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3239

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 11 lines] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: Plasma, broulik, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Another change mostly for KWin (Wayland compositor). KWin destroys it's
  internal Wayland connection prior to the QStyle getting destroyed. As
  the ShadowHelper initialized Wayland objects those would be destroyed
  after the connection is destroyed. With latest Wayland library this
  would cause a crash.
  
  Thus unpolish is implemented in the style and deletes the ShadowHelper.
  KWin can on tear down invoke the unpolish and thus make sure it doesn't
  crash.
  
  CCBUG: 372001

REPOSITORY
  rBREEZE Breeze

BRANCH
  unpolish-app-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3240

AFFECTED FILES
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 8 lines] D3241: Unpolish QStyle on QApp prior to destroying internal Wayland connection

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The QStyle might interact with our internal Wayland connection. If the
  cleanup happens after destroying our internal Wayland connection KWin
  will crash at tear-down.
  
  With this change the QStyle can perform cleanup already prior to the
  deconstruction of the Wayland connection.
  
  CCBUG: 372001

REPOSITORY
  rKWIN KWin

BRANCH
  style-unpolish-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3241

AFFECTED FILES
  autotests/integration/kwin_wayland_test.cpp
  main_wayland.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  Did you test whether unpolish is actually called ? Last time I tried, it was 
not, at least not always. (depending on whether you run a QApplication, 
KApplication, etc.)
  This is what led to the mess of destroying the singleton style in the plugin 
helper, which in turn created other crashes, and which was removed aferwards.
  This all story of QStyle dinitialization is a mess ...

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D3240#60257, @hpereiradacosta wrote:
  
  > Did you test whether unpolish is actually called ? Last time I tried, it 
was not, at least not always. (depending on whether you run a QApplication, 
KApplication, etc.)
  >  This is what led to the mess of destroying the singleton style in the 
plugin helper, which in turn created other crashes, and which was removed 
aferwards.
  >  This all story of QStyle dinitialization is a mess ...
  
  
  Ah
  sorry.
  I misread the fact that you actually make sure that kwin calls the unpolish.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3239: [kstyle] Delay init of Wayland setup till next event cycle

[Martin Gräßlin]

graesslin added a comment.


  see also https://phabricator.kde.org/D3241 and 
https://phabricator.kde.org/D3240

REPOSITORY
  rBREEZE Breeze

BRANCH
  delay-init-wayland-shadow-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3239

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3240#60265, @hpereiradacosta wrote:
  
  > In https://phabricator.kde.org/D3240#60257, @hpereiradacosta wrote:
  >
  > > Did you test whether unpolish is actually called ? Last time I tried, it 
was not, at least not always. (depending on whether you run a QApplication, 
KApplication, etc.)
  > >  This is what led to the mess of destroying the singleton style in the 
plugin helper, which in turn created other crashes, and which was removed 
aferwards.
  > >  This all story of QStyle dinitialization is a mess ...
  >
  >
  > Ah
  >  sorry.
  >  I misread the fact that you actually make sure that kwin calls the 
unpolish.
  
  
  For the general case you are right. Unpolish is only called from 
QApplication::setStyle when the old style gets destroyed. On Application 
tear-down it's not called.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 110 lines] D3242: Add an option to context menu to launch the application on a discrete graphics card

[jgrulich (Jan Grulich)]

jgrulich created this revision.
jgrulich added reviewers: hein, Plasma.
jgrulich set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In Fedora 25 there have been many improvements regarding dual graphics 
support and they recently added an option to Gnome to launch the application 
using a dicrete graphics card, by just overriding DRI_PRIME environment 
variable, see http://www.hadess.net/2016/10/dual-gpu-integration-in-gnome.html. 
This option is available based on simple dbus service implemented here 
https://github.com/hadess/switcheroo-control/ providing just a single property 
whether the user has dual GPU. This dbus thingie is enabled in Fedora 25 by 
default. This patch tries to add this option the same way as Gnome does. I'm 
just not sure about using qputenv(), but I couldn't find a better way as using 
QProcess, which allows to set environment variables, won't have that nice mouse 
effect of opening application, at least I think it won't.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3242

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129318: Add an option to context menu to launch the application on a discrete graphics card

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129318/
---

(Updated Lis. 3, 2016, 10:09 dop.)


Status
--

This change has been discarded.


Review request for Plasma and Eike Hein.


Repository: plasma-desktop


Description
---

In Fedora 25 there have been many improvements regarding dual graphics support 
and they recently added an option to Gnome to launch the application using a 
dicrete graphics card, by just overriding DRI_PRIME environment variable, see 
http://www.hadess.net/2016/10/dual-gpu-integration-in-gnome.html. This option 
is available based on simple dbus service implemented here 
https://github.com/hadess/switcheroo-control/ providing just a single property 
whether the user has dual GPU. This dbus thingie is enabled in Fedora 25 by 
default. This patch tries to add this option the same way as Gnome does. I'm 
just not sure about using qputenv(), but I couldn't find a better way as using 
QProcess, which allows to set environment variables, won't have that nice mouse 
effect of opening application, at least I think it won't.


Diffs
-

  applets/kicker/plugin/actionlist.h 869354c 
  applets/kicker/plugin/actionlist.cpp 2aa97d9 
  applets/kicker/plugin/appentry.cpp 80290e1 
  applets/kicker/plugin/recentusagemodel.cpp 24874ff 
  applets/kicker/plugin/runnermatchesmodel.cpp 4e4845c 

Diff: https://git.reviewboard.kde.org/r/129318/diff/


Testing
---


Thanks,

Jan Grulich

[Differential] [Changed Subscribers] D3242: Add an option to context menu to launch the application on a discrete graphics card

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> runnermatchesmodel.cpp:169
> +#if HAVE_X11
> +if (QX11Info::isPlatformX11()) {
> +timeStamp = QX11Info::appUserTime();

Please use KWindowSystem::isPlatformX11.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 241 lines] D3243: [kioslave/remote] Port away from kdelibs4support

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The `remote:/` kioslave now builds without kdelibs4support.
  The second commit also removes the tests subfolder, since the executable was a
  noop.

TEST PLAN
  remote:/ still works in Dolphin.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  port-remote

REVISION DETAIL
  https://phabricator.kde.org/D3243

AFFECTED FILES
  kioslave/remote/CMakeLists.txt
  kioslave/remote/kdedmodule/CMakeLists.txt
  kioslave/remote/kdedmodule/remotedirnotify.cpp
  kioslave/remote/kdedmodule/remotedirnotify.h
  kioslave/remote/kdedmodule/remotedirnotifymodule.cpp
  kioslave/remote/kio_remote.cpp
  kioslave/remote/remoteimpl.cpp
  kioslave/remote/remoteimpl.h
  kioslave/remote/tests/CMakeLists.txt
  kioslave/remote/tests/testremote.cpp
  kioslave/remote/tests/testremote.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 107 lines] D3242: Add an option to context menu to launch the application on a discrete graphics card

[jgrulich (Jan Grulich)]

jgrulich removed rPLASMADESKTOP Plasma Desktop as the repository for this 
revision.
jgrulich updated this revision to Diff 7852.
jgrulich marked an inline comment as done.
jgrulich added a comment.


  Use KWindowSystem::isPlatformX11() instead of QX11Info::isPlatformX11().

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3242?vs=7851&id=7852

REVISION DETAIL
  https://phabricator.kde.org/D3242

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  According to our bug report on this: 
https://bugs.kde.org/show_bug.cgi?id=371497 one also needs to restart kwin in 
xrender and mess about with some other things.
  
  Have you tested this on a real dual machine? and did you have those problems?

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: davidedmundson, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3229: Disable starting kactivitymanagerd throughout launchertasksmodeltest

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb63b2924254a: Disable starting 
kactivitymanagerd throughout launchertasksmodeltest (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3229?vs=7831&id=7854#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3229?vs=7831&id=7854

REVISION DETAIL
  https://phabricator.kde.org/D3229

AFFECTED FILES
  libtaskmanager/autotests/launchertasksmodeltest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, hein
Cc: hein, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

[jgrulich (Jan Grulich)]

jgrulich added a comment.


  I tested this on my laptop where I have both intel and nvidia cards and it 
seems to working without any issue for me. Note that in Fedora 25 here have 
been many improvements regarding dual graphics support so that may be the 
reason why it works for me. Another reason might be that I use Noveau driver 
and not the proprietary one.

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: davidedmundson, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3244: Internal windows cannot be minimized

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, broulik.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  This change ensures that the DebugConsole does not have a minimize
  button.
  
  BUG: 372000
  FIXED-IN: 5.8.4

REPOSITORY
  rKWIN KWin

BRANCH
  internal-window-non-minimize-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3244

AFFECTED FILES
  autotests/integration/debug_console_test.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3244: Internal windows cannot be minimized

[Martin Gräßlin]

graesslin added a comment.


  F396413: kwin_screenshot_f29787.png 

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3244

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 534 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Nov 2016 10:29:45 +
Build duration: 5 min 55 sec

CHANGE SET
Revision b63b2924254a96fda6cd6535d295f82aba2249e2 by David Edmundson: (Disable 
starting kactivitymanagerd throughout launchertasksmodeltest)
  change: edit libtaskmanager/autotests/launchertasksmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 53/73 (73%)CLASSES 53/73 (73%)LINE 2103/5594 
(38%)CONDITIONAL 1444/5538 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 
36/66 (55%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/20 (30%)CLASSES 6/20 (30%)LINE 194/3245 (6%)CONDITIONAL 
119/3197 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 
17/64 (27%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 534 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Nov 2016 10:29:45 +
Build duration: 5 min 55 sec

CHANGE SET
Revision b63b2924254a96fda6cd6535d295f82aba2249e2 by David Edmundson: (Disable 
starting kactivitymanagerd throughout launchertasksmodeltest)
  change: edit libtaskmanager/autotests/launchertasksmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 53/73 (73%)CLASSES 53/73 (73%)LINE 2103/5594 
(38%)CONDITIONAL 1444/5538 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 
36/66 (55%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/20 (30%)CLASSES 6/20 (30%)LINE 194/3245 (6%)CONDITIONAL 
119/3197 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 
17/64 (27%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3242#60294, @davidedmundson wrote:
  
  > According to our bug report on this: 
https://bugs.kde.org/show_bug.cgi?id=371497 one also needs to restart kwin in 
xrender and mess about with some other things.
  
  
  Eh no, that seems to be just the user thinking it might make sense. Most 
likely the game tears down the compositor any way.

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: davidedmundson, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3242#60307, @graesslin wrote:
  
  > In https://phabricator.kde.org/D3242#60294, @davidedmundson wrote:
  >
  > > According to our bug report on this: 
https://bugs.kde.org/show_bug.cgi?id=371497 one also needs to restart kwin in 
xrender and mess about with some other things.
  >
  >
  > Eh no, that seems to be just the user thinking it might make sense. Most 
likely the game tears down the compositor any way.
  
  
  Hmm according to the bug report a compositor must be running. If that's in 
deed the case, then this will break with KWin's terminate compositing on game 
request. If the OpenGL compositor (or xrender compositor) needs to be on, then 
the overhead for the game will be so significant that it might destroy the 
benefit of running on concrete card.
  
  This would require a 180 degree turn on KWin's "how to get game fast" 
approach. Our current approach is disabling compositing. We would need to 
significantly invest into gaming on compositing experience if we have to change 
that.

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, hein, #plasma
Cc: davidedmundson, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  
  
  > For the general case you are right. Unpolish is only called from 
QApplication::setStyle when the old style gets destroyed. On Application 
tear-down it's not called.
  
  To be honest, I am a bit uneasy about this change. Sounds somewhat like 
abusing the API (since you then call the method explicitly in kwin). What if 
people later on start adding other "destruction" stuff in unpolish, unaware 
that it is actually not called ?
  
  Maybe something cleaner would be to move everything from the destructor to 
unpolish (with proper reassignment to nullptr), and then call unpolish 
explicitely in the destructor.
  The whole thing with tons of comments/warning ?

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3240#60309, @hpereiradacosta wrote:
  
  > > For the general case you are right. Unpolish is only called from 
QApplication::setStyle when the old style gets destroyed. On Application 
tear-down it's not called.
  >
  > To be honest, I am a bit uneasy about this change. Sounds somewhat like 
abusing the API (since you then call the method explicitly in kwin). What if 
people later on start adding other "destruction" stuff in unpolish, unaware 
that it is actually not called ?
  >
  > Maybe something cleaner would be to move everything from the destructor to 
unpolish (with proper reassignment to nullptr), and then call unpolish 
explicitely in the destructor.
  >  The whole thing with tons of comments/warning ?
  
  
  I don't like calling virtual methods from a dtor, always a mess. But we can 
do a private cleanup method and call it from both dtor and unpolish. Would that 
be OK to you?

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  
  
  > I don't like calling virtual methods from a dtor, always a mess.
  
  agreed
  
  > But we can do a private cleanup method and call it from both dtor and 
unpolish. Would that be OK to you?
  
  yes

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Stepping down as KGlobalAccel maintainer

[Martin Graesslin]

Hi frameworks developers,

I decided to step down as the maintainer of KGlobalAccel. I haven't done any 
work on KGlobalAccel this year and bug reports just linger. A big problem for 
me maintaining KGlobalAccel is that most work is needed in the X11 
implementation. As I no longer use X11 and cannot simulate it under Wayland I 
don't think I'm in any position to further maintain KGlobalAccel. Also this is 
something I don't expect to change in future. I don't see myself switching 
into an X11 session just to investigate a bug in KGlobalAccel.

I hope that we find an interested developer to take over the maintainership. 
Best would be someone with X11 knowledge.

Best Regards
Martin Gräßlin

[Differential] [Updated, 22 lines] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[Martin Gräßlin]

graesslin updated this revision to Diff 7858.
graesslin added a comment.


  Implement a private cleanup method invoked by dtor and unpolish

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3240?vs=7849&id=7858

BRANCH
  unpolish-app-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3240

AFFECTED FILES
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  ship-it

REPOSITORY
  rBREEZE Breeze

BRANCH
  unpolish-app-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3242: Add an option to context menu to launch the application on a discrete graphics card

[hein (Eike Hein)]

hein added a comment.


  I'm not sure this is the right approach. If we add this to Kicker, it won't 
work in any of these other ways to launch an app:
  
  - KRunner
  - "Start New Instance" in the Task Manager
  - The Icon applet in the panel or on the desktop
  - The menu desktop containment action
  - File associations
  - Global shortcuts
  
  ...
  
  We'd end up patching this in all over the place. :(
  
  I think it would make more sense to do it a bit like this:
  
  - A new X-KDE-* .desktop file key for "start on discrete"
  - Code in KPropertiesDialog and kmenuedit to set this bit
  
  The above write out a .desktop file in $HOME shadowing the system one; it's 
how you e.g. also change an app's icon on the system to a custom one.

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, #plasma, hein
Cc: davidedmundson, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3210#60230, @hpereiradacosta wrote:
  
  > So, just to make sure I understand:
  >
  > - 1 option to "only show full scrollbar on mouse over" (as we have now)
  > - 1 option to "use slim scrollbar" (with reduced width handle) Is that what 
you have in mind ? or do you suggest to group the two ? (in which case I'm 
pretty sure some users will want one and not the other, namely slim scrollbar 
with groove always visible, no groove but large handle, etc.)
  
  
  personally, (and would be good if thomas, jens or alex from the cdg weigh on 
that) I would have the default as:
  
  - small scrollbar
  - show on mouseover enabled
  - no arrow buttons
  
  tough i feel there may be the need for configuration options, even tough i 
usually really dislike them, for the code complexity reason you rightly 
mentioned
  
  > Thanks for the feedback,
  > 
  > Hugo
  > 
  > One last comment about options: every time one adds one, one make the code 
maintenance more complicated, with more combinations to test each time a change 
to the code is made. Just saying :)
  
  yep, i fully agree with that.
  unfortunately over the years  i seen the storm that can happen every time one 
changes anything visual (seems that changing the size of something is even more 
delicate as shown by a recent storm over systray icons size) so yeah, I'm just 
a bit afraid to :) (could fall into the category of the "omg they are pushing a 
mobile ui on me" kind of hater)
  
  we could even try to make this not configurable for 5.9 and see what the 
feedback is and eventually get the options back later..

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 4 lines] D3247: Invert the scroll direction for wheel events on internal windows

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, broulik.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  For whatever reason Qt scrolled the wrong way on internal windows. As a
  new QWheelEvent is constructed anyway, just multiply by -1 to get the
  direction fixed.
  
  BUG: 371999
  FIXED-IN: 5.8.4

TEST PLAN
  Tried debug console in nested setup, scrolled correctly now.

REPOSITORY
  rKWIN KWin

BRANCH
  invert-scroll-direction-internal-window-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3247

AFFECTED FILES
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Plasma Mobile: Nexus 5 / Multirom

[Tobias Girstmair]

Hi,

I tried to install Plasma Mobile using both of these methods:
 * https://community.kde.org/Plasma/Mobile/MultiROM
 * https://plasma-mobile.org/multirom/

However, I failed. Using the patched MultiRom Manager (downloading from 
http://kubuntu.plasma-mobile.org/pool/), it fails with (translated from 
German)

 > Checking file device-687a931c47e1...d6b63d42054.tar.xz...FAILED
Using pm-flashtool/flash-multirom, it sucessfully downloads, pushes and 
extracts the archives to the phone, but (both the patched and original) 
MultiRom Manager and TWRP recovery can't see it.


Any help will be highly appreciated.

Thanks,
Tobias

Re: Review Request 129315: Don't install plasmoid desktop files as services

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/#review100537
---



I'm in favor of this, let's wait to 5.29 tough

- Marco Martin


On Nov. 3, 2016, 1:06 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129315/
> ---
> 
> (Updated Nov. 3, 2016, 1:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It shouldn't have an impact anymore.
> 
> 
> Diffs
> -
> 
>   KF5PlasmaMacros.cmake 5827854 
> 
> Diff: https://git.reviewboard.kde.org/r/129315/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Differential] [Commented On] D3210: make scrollbar size configurable

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  
  
  > personally, (and would be good if thomas, jens or alex from the cdg weigh 
on that) I would have the default as:
  > 
  > - small scrollbar
  > - show on mouseover enabled
  > - no arrow buttons
  
  +1 on this.
  Been using this setup for few days now and am  very happy with it
  
  > tough i feel there may be the need for configuration options,
  
  ok :)
  so far I have been the only one advocating for not having an option anyway.
  
  > even tough i usually really dislike them, for the code complexity reason 
you rightly mentioned
  
  
  
  > we could even try to make this not configurable for 5.9 and see what the 
feedback is and eventually get the options back later..
  
  yes. In fact  you could even push the code "as is", but removing without the 
ui elements. (to have "hidden" options)

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3247: Invert the scroll direction for wheel events on internal windows

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  How does that affect horizontal scrolling? Also, does that already take into 
account scroll direction "natural"/normal (or was that maybe the case for it 
being wrong in the first place?)?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3247

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 128793: [kio_mtp] Improve warning message

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128793/
---

(Updated Nov. 3, 2016, 1:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit e5619efafdd9c316e6d3e609ddd73939dea3e270 by Elvis 
Angelaccio to branch master.


Repository: kio-extras


Description
---

Sometimes the "Maybe you need to unlock your device?" message appears even if 
the user has unlocked their device, so it's not very useful. This happened to 
me as well and I had to look for [the 
fix](https://forums.opensuse.org/showthread.php/510787-android-phone-mtp-can-t-access-folders?p=2736133#post2736133)
 on google.

Since this warning is displayed also when MTP is disabled on the phone's side, 
let's warn the user about this.


Diffs
-

  mtp/kio_mtp.cpp 8a9b26e 

Diff: https://git.reviewboard.kde.org/r/128793/diff/


Testing
---


Thanks,

Elvis Angelaccio

Review Request 129321: Don't redeclare signal and then not use it anyway

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129321/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Fixes runtime warning


Diffs
-

  src/declarativeimports/core/tooltip.h 
d38c49ba5b8f20a5ff2a16a87ac935ca20b9a69d 

Diff: https://git.reviewboard.kde.org/r/129321/diff/


Testing
---

grepped Tooltip.* for usage, and there was none

and any external usage will now just use QQuickItem::visibleChanged() anyway


Thanks,

David Edmundson

[Differential] [Request, 14 lines] D3249: Use our tooling for installing plasmoids

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  use kpackage/plasma macros to install the files. This way we get all
  the features provided by the macro.

TEST PLAN
  didn't find regressions

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3249

AFFECTED FILES
  applets/CMakeLists.txt
  applets/activitypager/CMakeLists.txt
  applets/kickerdash/CMakeLists.txt
  applets/konsoleprofiles/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 26 lines] D3250: Use Plasma tooling for installing plasmoids

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Uses plasma_install_package() instead of doing it separately

TEST PLAN
  still works

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3250

AFFECTED FILES
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  containments/CMakeLists.txt
  containments/folder/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/qml/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129321: Don't redeclare signal and then not use it anyway

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129321/#review100538
---


Ship it!




Ship It!

- Marco Martin


On Nov. 3, 2016, 1:48 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129321/
> ---
> 
> (Updated Nov. 3, 2016, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fixes runtime warning
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.h 
> d38c49ba5b8f20a5ff2a16a87ac935ca20b9a69d 
> 
> Diff: https://git.reviewboard.kde.org/r/129321/diff/
> 
> 
> Testing
> ---
> 
> grepped Tooltip.* for usage, and there was none
> 
> and any external usage will now just use QQuickItem::visibleChanged() anyway
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Commented On] D3247: Invert the scroll direction for wheel events on internal windows

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3247#60362, @broulik wrote:
  
  > How does that affect horizontal scrolling?
  
  
  The same: as we multiple by -1 it's also corrected now. Though I admit to not 
have tested it (yet)
  
  > Also, does that already take into account scroll direction "natural"/normal 
(or was that maybe the case for it being wrong in the first place?)?
  
  The cause in the first place is that Qt expects the delta in another 
dimension. I just verified by looking at Qt code and there it's also multiplied 
by a negative value: 
https://code.qt.io/cgit/qt/qtwayland.git/tree/src/client/qwaylandinputdevice.cpp#n557

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3247

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Affenfels: Plasma Sprint 6-12 Feb 2017

[Jonathan Riddell]

Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in Stuttgart.

https://community.kde.org/Plasma/Affenfels

https://reimbursements.kde.org/events/25

Includes the option of a road trip from FOSDEM if you're going to both.

Jonathan

[Differential] [Closed] D3232: [Lock Screen] Don't assume last user is "New Session" entry

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd1133288c335: [Lock Screen] Don't assume last 
user is "New Session" entry (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3232?vs=7835&id=7865

REVISION DETAIL
  https://phabricator.kde.org/D3232

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, subdiff, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 3 lines] D3231: [Lock Screen] Show "Switch User" button only if allowed

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 7866.
broulik added a comment.


  Take into account canSwitchUser

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3231?vs=7834&id=7866

REVISION DETAIL
  https://phabricator.kde.org/D3231

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 92 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 7870.
mart added a comment.


  - make the scrollbar size config a simple checkbox

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=7783&id=7870

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3244: Internal windows cannot be minimized

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  internal-window-non-minimize-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3244

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3247: Invert the scroll direction for wheel events on internal windows

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Verified that horizontal scrolling also scrolls correctly (dragged one 
TreeWidget colum super wide to have it scroll)

REPOSITORY
  rKWIN KWin

BRANCH
  invert-scroll-direction-internal-window-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3247

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3220: Introduce new pre-layout script hook

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb9760e852042: Introduce new pre-layout script 
hook (authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3220?vs=7799&id=7875

REVISION DETAIL
  https://phabricator.kde.org/D3220

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: apol, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

[dmitryshachnev (Dmitry Shachnev)]

dmitryshachnev added a comment.


  > in KXMLGui applications you still get a traditional menu bar in addition to 
the global menu, it seems it explicitly sets visible true on the menu bar - in 
VLC it hides its own menu bar.
  
  This will be fixed in Qt 5.7.1, see this commit 
.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: dmitryshachnev, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  If I understood it correctly (that there is only a checkbox "Only show full 
scrollbar on mouse over" added to the config) then that is exactly what I had 
in mind.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Plasma Mobile: Nexus 5 / Multirom

[Bhushan Shah]

Hello,

On Thu, Nov 03, 2016 at 01:41:58PM +0100, Tobias Girstmair wrote:
> Using pm-flashtool/flash-multirom, it sucessfully downloads, pushes and
> extracts the archives to the phone, but (both the patched and original)
> MultiRom Manager and TWRP recovery can't see it.

Can you tell me which instructions you followed to get it working? I've
just updated the wiki page about new Cyanogenmod base to include
instructions for MultiROM

https://community.kde.org/Plasma/Mobile/CyanogenModBase#MultiROM_instructions_.28For_dualboot.29

Can you try following that?

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

[Differential] [Changed Subscribers] D3222: Correctly set i18n suffix in mousemark spinbox.

[shumski (Hrvoje Senjan)]

shumski added inline comments.

INLINE COMMENTS

> CMakeLists.txt:89
>  KIO
> +TextWidgets
>  NewStuff

> Note, "new" dependency was already linked implicitly in other kwin, but we 
> need to add it for this KCM.

For completeness sake,  ktextwidgets devel files where not present in 
buildroot, before this patch, when building kwin. Of KF5, only kparts, khtml 
and kdelibs4support are publicly pulling in ktextwidgets.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3222

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: shumski, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas