[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  What would be the best place to put a little utility (similar to notify-send 
or kdialog --passivepopup) for this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 160 lines] D3630: [Digital Clock] Bug fixes and ui code optimization

[subdiff (Roman Gilg)]

subdiff created this revision.
subdiff added a reviewer: Plasma.
subdiff added a subscriber: plasma-devel.
subdiff set the repository for this revision to R120 Plasma Workspace.
subdiff added a project: Plasma.

REVISION SUMMARY
  This patch is meant to improve the Digital Clock applet in the following ways:
  
  - Fixed timezone size and alignment in vertical mode
  - Instead of `Flow` uses `Grid` for labels as it's simpler and gives better 
control over alignment
  - Seperator in small horizontal mode centered between date and time and in 
height now dependent on label size
  - Less empty space around time in small horizontal mode
  - Binding loop and initlializting anchor errors fixed
  - Element now size completely down and have always the same ratio to each 
other (with the time being the largest)
  - Round functions removed since they disrupted the resizing for small sizes
  
  F684112: Screenshot_20161209_030258.png  
F684113: Screenshot_20161209_030412.png  
F684114: Screenshot_20161209_030542.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3630

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Selecting a Plasma logo

[Sebastian Kügler]

On Wednesday, December 7, 2016 1:58:34 PM UTC Jens Reuterberg wrote:
> About half a year ago this thread started and so far no actual change has
> happened.

That's embarrasing. :-( 

Thanks for bringing this topic up, though.

> The background is that the past logo for Plasma Desktop was disagreed upon
> by the Plasma developer team and they wanted a new one. Thomas created a
> competition of sorts which had a lot of suggestions in it.
> 
> Currently, no final decision has been made on this which leaves us with
> three options:
> 1) VDG decides.
> 2) The developers decide
> 3) We use the KDE logo
> 
> Now
> 
> #1 means that we with a high level of chance will go to the Plasma logo we
> had before this started. 

I'd welcome this, it's a very pragmatical decision to pick the strongest 
contender when no other has shown to be significantly better. Also it's safe 
(the current logo is proven to work technically, and it's the least costly 
option for us to use, as it's already available in most forms, just not 
consistently applied.

Also, you guys are most affected by the lack of a clear logo / branding 
guideline in your daily work, and I think we've wasted enough of our 
collective time on this.

Personally, I have grown to really like the logo and to me it bears meaning 
(and flexibility for interpretation). Especially the representation of shell is 
something that strokes me in just the right way by appealing to the geek in 
me.

> There is zero criticism against it that has been
> valid except that the developers who didn't like it in the first place
> didn't like it. Which is relevant of course.

To a degree, yes. But not in a blocking role, only to propose alternatives.

> #2 means this thread needs a choice. This WILL NOT continue in any
> structured form where people are egged on to make "suggestions" and then a
> round table debate. It has taken work time from VDG contributors, caused
> meaningless arguments and bikeshedding and has been the kind of work we can
> all see will never end. I honestly regret not having the courage to say
> "No" when it was first debated.
> (if some designer wants to work with the Plasma Developers on this, go for
> it, no one will stop you of course. But the VDG will not supply designers
> to this task formally or make any further efforts which has been so far a
> half a year of throwing manhours into a pit)

That's entirely understandable. The VDG is much more affected by the lack of a 
clear branding guideline than the people who write the code. You are right to 
complain and to ask to not have your time wasted.

> #3 Means that we take the work on seperating KDE the community from Plasma
> the desktop and pretend it didn't happen. Which sounds dramatic but its
> essentially leaving it as a status quo.

For all the obvious reasons, no, let's not destroy this effort. The branding 
serves a clear purpose and solves real problems.

> [...] Unless something is posted here my assumption is that the design 
> decision is up to the KDE Design Group/VDG and we will choose, reply and 
> move on with this and our lives.

Yes, let's please do that.
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org

Re: Selecting a Plasma logo

[Sebastian Kügler]

On Wednesday, December 7, 2016 3:51:39 PM UTC Ken Vermette wrote:
> Here's my proposal: we get a form up tomorrow, put it on plasma-devel
> mailing lists. We set the voting deadline to December 23rd midnight, giving
> the vote just over two weeks. That gives us a time to commit the new logo
> to Plasma 5.9 before freeze, and for those of us who celebrate the holidays
> in December we can announce the new logo as a "Present" on Planet KDE.
> 
> Does that sound like a plan?

Nope. I have two issues with this:

* We would put an important decision for our branding in the hands of, a 
sample of our users, developers, contributors, ...? This doesn't work because 
we don't have clear rules who gets to vote in the first place, and then down 
the rabbit hole from there. On top of that, I think it's inherently broken to 
assign such a decision to a vote. How often have you heard that design by 
committee has produced excellent results. You're essentially trying to create  
a new process, that's not proven to deliver quality results. We might almost 
as well throw dice.

* As Jens said so eloquently, we've wasted enough time on this, a pragmatic 
decision is needed. There's hardly any reason at this point to not trust our 
proven processes and leave the last word in important design decisions to the 
VDG.
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org

Re: Selecting a Plasma logo

[Sebastian Kügler]

On Wednesday, December 7, 2016 8:58:34 PM UTC Martin Gräßlin wrote:
> Personally I find it important that the developers have a say in what 
> the logo is. I think we identify by it and the logo needs to work with 
> us.

We did have a say, more than one (on the forums, we had the logo's posted for 
feedback on the wiki,  , and neither process has delivered a firm decision 
when we got to make it. Let's admit defeat on this process and move on. Let's 
also accept that aside from potential technical issues (which I think there 
are none deal-breaking), that the choice of a logo boils down to sentimental 
value, and being able to identify one's work and effort with the logo. To me 
personally, I can connect quite well to the current-de-facto-temporary logo.

I think at this point, it's entirely fair to those who are most affected by 
the lack of a clear branding (mainly our logo) to say "Look guys, you had 
months to come to a decision, you haven't, we're now moving on with this.".
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org

[Differential] [Request, 127 lines] D3628: Refresh the ScreenGeometry data role whenever a screen is added or changes its geometry.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  As this happens the screen filtering higher up in the proxy chain
  culimating in TasksModel needs to be re-executed, as it compares
  ScreenGeometry against a property value set on the model. Without
  this update, tasks may disappear from views using TasksModel.
  
  Mapping the trigger conditions to affected rows is deliberately
  maximally coarse; see implementation comment in code.
  
  BUG:373075

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D3628

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/abstractwindowtasksmodel.cpp
  libtaskmanager/abstractwindowtasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3585: Fix building library with qmake

[drosca (David Rosca)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:48b9c50a88d4: Fix building library with qmake (authored 
by drosca).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3585?vs=8740=8876

REVISION DETAIL
  https://phabricator.kde.org/D3585

AFFECTED FILES
  kirigami.pro

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #kirigami, mart
Cc: plasma-devel, apol

Re: [KWin - Dock Question] - How to hide a window from PresentWindows effect?

[Martin Gräßlin]

Am 2016-12-08 20:28, schrieb Michail Vourlakos:

On 08/12/2016 09:09 μμ, Martin Graesslin wrote:
In the case of the XCB Qt plugin the ordering of the calls is 
important. You
need to set such flags before the window is created. Calls to 
KWindowSystem can

destroy it again.

If you want to check how it's done: look at the Plasma::Dialog class 
which

supports a no input mode for the OSD.

can you please point me more precisely in this code please? where is
the Plasma:Dialog c++ code?


https://cgit.kde.org/plasma-framework.git/tree/src/plasmaquick/dialog.cpp

the property in question is outputOnly. But it looks like that's only 
using an input shape which might (?) not help you.






  > m_dockWindow->setFlags(Qt::WindowDoesNotAcceptFocus |

Qt::FramelessWindowHint);

Is there a way if I set my dock with:
  > KWindowSystem::setType(m_dockWindow->winId(), NET::Dock);

to be able to lower it afterwards?

What do you mean with "lower it"?


If I set :

KWindowSystem::setType(m_dockWindow->winId(), NET::Dock);

my dock is always on top and I can never lower it below normal 
windows..


Well yes, that's the idea of a Dock. Of course it's on top of all 
windows. If you don't want that, don't use a dock.


On X11 KWin supports windows can cover through having a dock set to keep 
below. But that won't work on Wayland and thus I heavily recommend 
against it.


Cheers
Martin

Re: [KWin - Dock Question] - How to hide a window from PresentWindows effect?

[Martin Graesslin]

On Thursday, December 8, 2016 8:53:00 PM CET you wrote:
> > The problem here is clearly that your window is still accepting focus. If
> > it doesn't accept focus KWin will skip it. So verify with xprop and
> > xwininfo that the window is really excluding focus.
> 
> Where do I look Martin? I am sending my outputs...
> How do I really exclude focus except setting?

Checking from KWin code: a window is included in window switching if it is
a normal or dialog window and wantsInput. WantsInput is a check for whether 
the window supports the TakeFocusProtocol.

In your case: it's a normal window (_NET_WM_WINDOW_TYPE(ATOM) = 
_KDE_NET_WM_WINDOW_TYPE_OVERRIDE, _NET_WM_WINDOW_TYPE_NORMAL)

and it supports the take focus protocol (WM_PROTOCOLS(ATOM): protocols  
WM_DELETE_WINDOW, WM_TAKE_FOCUS)

Thus KWin includes it in the switcher.

In the case of the XCB Qt plugin the ordering of the calls is important. You 
need to set such flags before the window is created. Calls to KWindowSystem can 
destroy it again.

If you want to check how it's done: look at the Plasma::Dialog class which 
supports a no input mode for the OSD.

> 
>  > m_dockWindow->setFlags(Qt::WindowDoesNotAcceptFocus |
> 
> Qt::FramelessWindowHint);
> 
> Is there a way if I set my dock with:
>  > KWindowSystem::setType(m_dockWindow->winId(), NET::Dock);
> 
> to be able to lower it afterwards?

What do you mean with "lower it"?

Cheers
Martin

> 
> 
> Thanks a lot
> 
> regards,
> michail
> 
> 
> --
> 
> xwininfo: Window id: 0x6a00030 "Plasma"
> 
>Absolute upper-left X:  0
>Absolute upper-left Y:  901
>Relative upper-left X:  0
>Relative upper-left Y:  0
>Width: 1680
>Height: 149
>Depth: 32
>Visual: 0x72
>Visual Class: TrueColor
>Border width: 0
>Class: InputOutput
>Colormap: 0x6a0002f (not installed)
>Bit Gravity State: NorthWestGravity
>Window Gravity State: NorthWestGravity
>Backing Store State: NotUseful
>Save Under State: no
>Map State: IsViewable
>Override Redirect State: no
>Corners:  +0+901  -0+901  -0-0  +0-0
>-geometry 1680x149+0-0
> 
> ---
> xprop:
> _KDE_NET_WM_ACTIVITIES(STRING) = "----"
> _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE,
> _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_MINIMIZE,
> _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_MAXIMIZE_HORZ,
> _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CHANGE_DESKTOP,
> _NET_WM_ACTION_CLOSE
> WM_STATE(WM_STATE):
>  window state: Normal
>  icon window: 0x0
> _NET_WM_USER_TIME(CARDINAL) = 56530163
> _NET_WM_STATE(ATOM) = _NET_WM_STATE_ABOVE, _NET_WM_STATE_STAYS_ON_TOP,
> _NET_WM_STATE_SKIP_TASKBAR, _NET_WM_STATE_SKIP_PAGER
> _NET_WM_DESKTOP(CARDINAL) = 4294967295
> _NET_WM_ICON(CARDINAL) =Icon (16 x 16):
> 
> XdndAware(ATOM) = BITMAP
> WM_NAME(STRING) =
> _NET_WM_NAME(UTF8_STRING) = "Plasma"
> _KDE_NET_WM_USER_CREATION_TIME(CARDINAL) = 55504946
> _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x1, 0x0, 0x0, 0x0
> _NET_WM_WINDOW_TYPE(ATOM) = _KDE_NET_WM_WINDOW_TYPE_OVERRIDE,
> _NET_WM_WINDOW_TYPE_NORMAL
> _XEMBED_INFO(_XEMBED_INFO) = 0x0, 0x1
> WM_CLIENT_LEADER(WINDOW): window id # 0x6ad
> WM_HINTS(WM_HINTS):
>  Client accepts input or input focus: False
>  Initial state is Normal State.
> _NET_WM_PID(CARDINAL) = 28689
> _NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 49105
> WM_CLASS(STRING) = "plasmashell", "plasmashell"
> WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS,
> _NET_WM_PING, _NET_WM_SYNC_REQUEST
> WM_NORMAL_HINTS(WM_SIZE_HINTS):
>  user specified location: 0, 901
>  user specified size: 1680 by 149
>  window gravity: Static
> 
> 



signature.asc
Description: This is a digitally signed message part.

[Differential] [Closed] D3488: [platforms/wayland] Use a ConfinedPointer if available

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:2defd6bb6487: [platforms/wayland] Use a ConfinedPointer 
if available (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3488?vs=8477=8864

REVISION DETAIL
  https://phabricator.kde.org/D3488

AFFECTED FILES
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, eliasp

[Differential] [Closed] D3506: Implement support for pointer constraints

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:0c5ca405cc6d: Implement support for pointer constraints 
(authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3506?vs=8518=8865#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3506?vs=8518=8865

REVISION DETAIL
  https://phabricator.kde.org/D3506

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/kwin_wayland_test.h
  autotests/integration/pointer_constraints_test.cpp
  autotests/integration/test_helpers.cpp
  input.cpp
  input.h
  keyboard_input.cpp
  pointer_input.cpp
  pointer_input.h
  wayland_server.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, eliasp

Re: [KWin - Dock Question] - How to hide a window from PresentWindows effect?

[Martin Graesslin]

On Thursday, December 8, 2016 7:17:31 PM CET Michail Vourlakos wrote:
> Hello everyone,
> 
> in NowDock I have managed to subclass a QuickWindow in order to provide
> masking and various visibility states for the dock.
> 
> In all the visibility states I am setting for this subclassed window:
> 
> m_dockWindow->setFlags(Qt::FramelessWindowHint|Qt::WindowDoesNotAcceptFocus)
> ; KWindowSystem::setState(m_dockWindow->winId(), NET::SkipTaskbar |
> NET::SkipPager);
> 
> 
> but even though the above code enables me to make my dock ontop or
> onbottom when I need it, it doesnt hide my dock from the "present
> windows effect" and from the "Alt+Tab". I tried to use:
> 
> KWindowSystem::setType(m_dockWindow->winId(), NET::Dock);
> 
> m_dockWindow->setFlags(m_dockWindow->flags() ^ (Qt::WindowStaysOnTopHint));
> 
> 
> but it didnt help, the dock is still shown in the window effects

There is no way for a window to hint that it should be excluded from 
switchers. Only inside KWin there is a windows-specific rule to exclude windows 
from switchers.

The problem here is clearly that your window is still accepting focus. If it 
doesn't accept focus KWin will skip it. So verify with xprop and xwininfo that 
the window is really excluding focus.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.

[Differential] [Accepted] D3585: Fix building library with qmake

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3585

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Changed Subscribers] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> groupingplasmoid.kdev4:1
> +[Buildset]
> +BuildItems=@Variant(\x00\x00\x00\t\x00\x00\x00\x00\x01\x00\x00\x00\x0b\x00\x00\x00\x00\x01\x00\x00\x00
>  
> \x00g\x00r\x00o\x00u\x00p\x00i\x00n\x00g\x00p\x00l\x00a\x00s\x00m\x00o\x00i\x00d)

this foder shouldn't be added

> groupedappletscontainer.cpp:132
> +} else {
> +m_innerContainment->setFormFactor(Plasma::Types::Horizontal);
> +}

when this containment is in a desktop, shouldn't be better for it to be planer 
instead to let more applets to be expanded?

> main.qml:28
> +
> +Layout.minimumWidth: internalSystray ? 
> internalSystray.Layout.minimumWidth : 0
> +Layout.minimumHeight: internalSystray ? 
> internalSystray.Layout.minimumHeight : 0

rename *systray?

> groupingplasmoid.kdev4:1
> +[Project]
> +CreatedFrom=CMakeLists.txt

remove this file?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3620

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[KWin - Dock Question] - How to hide a window from PresentWindows effect?

[Michail Vourlakos]

Hello everyone,

in NowDock I have managed to subclass a QuickWindow in order to provide 
masking and various visibility states for the dock.


In all the visibility states I am setting for this subclassed window:

m_dockWindow->setFlags(Qt::FramelessWindowHint|Qt::WindowDoesNotAcceptFocus);
KWindowSystem::setState(m_dockWindow->winId(), NET::SkipTaskbar | 
NET::SkipPager);



but even though the above code enables me to make my dock ontop or 
onbottom when I need it, it doesnt hide my dock from the "present 
windows effect" and from the "Alt+Tab". I tried to use:


KWindowSystem::setType(m_dockWindow->winId(), NET::Dock);

m_dockWindow->setFlags(m_dockWindow->flags() ^ (Qt::WindowStaysOnTopHint));


but it didnt help, the dock is still shown in the window effects

I also tried:


KWindowSystem::setType(m_dockWindow->winId(), NET::Dock);

but even though this hides my dock from the kwin effects it also makes 
my dock "always on top" and I dont want this in most of my visibility 
states...



any ideas?

regards,

michail

[Differential] [Commented On] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  F679341: Spectacle.X13741.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3620

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 1,037 lines] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Restore the "grouped" plasmoid of KDE4.
  
  It's somewhat similar to the system tray internally, it creates a
  containment then has a thin wrapper to display plasmoids in a tab.
  
  Plasmoids will display their compact/full representation depending on
  the size of the tab, if compacted, the full representation will appear
  as a dialog just outside the tab area.

TEST PLAN
  Dragged some applets in
  Right click, removed an applet
  Tested restoration after shutdown
  Tested applets with popups (like analog clock or kickoff)
  Tested remove/restore

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3620

AFFECTED FILES
  applets/CMakeLists.txt
  applets/grouping/.kdev4/groupingplasmoid.kdev4
  applets/grouping/CMakeLists.txt
  applets/grouping/Messages.sh
  applets/grouping/container/CMakeLists.txt
  applets/grouping/container/groupedappletscontainer.cpp
  applets/grouping/container/groupedappletscontainer.h
  applets/grouping/container/package/contents/ui/main.qml
  applets/grouping/container/package/metadata.desktop
  applets/grouping/groupingcontainment.cpp
  applets/grouping/groupingcontainment.h
  applets/grouping/groupingplasmoid.kdev4
  applets/grouping/package/contents/applet/CompactApplet.qml
  applets/grouping/package/contents/config/config.qml
  applets/grouping/package/contents/config/main.xml
  applets/grouping/package/contents/ui/items/AbstractItem.qml
  applets/grouping/package/contents/ui/items/PlasmoidItem.qml
  applets/grouping/package/contents/ui/main.qml
  applets/grouping/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 52 lines] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.
broulik updated this revision to Diff 8854.
broulik added a comment.


  - Drop plasmashell from interface name and upper camel case

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3606?vs=8853=8854

REVISION DETAIL
  https://phabricator.kde.org/D3606

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 52 lines] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik removed a subscriber: davidedmundson.
broulik updated this revision to Diff 8853.
broulik added a comment.


  - Support passing "uids" as stringlist, my initial QVariantList with int 
approach didnt really work
  - Enable only if configured

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3606?vs=8806=8853

REVISION DETAIL
  https://phabricator.kde.org/D3606

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Note that actions won't work, we'd always be replying on the session bus. 
(this is solvable)

INLINE COMMENTS

> notificationsengine.cpp:70
> +// TODO only do that when plasmashellrc has [Notifications] 
> BroadcastAllowed or sth like that
> +QDBusConnection::systemBus().connect({}, {}, 
> QStringLiteral("org.kde.plasmashell.broadcastNotification"),
> + QStringLiteral("Notify"), this, 
> SLOT(onBroadcastNotification(QMap)));

I'd get rid of the plasmashell in the iface name.
Otherwise you're tying an implementation detail into an API.

Also for whatever reason convention is to be UpperCamelCase (i.e 
BroadcastNotification not broadcastNotification)

> notificationsengine.cpp:426
> +auto userId = properties.value(QStringLiteral("uid")).toULongLong();
> +if (userId) {
> +userIds.append(userId);

is it intended that you can't send a message to root?

otherwise toULongLong( );
if (rc) {..}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "RFC: Listen for broadcast notifications on 
system bus" to "Listen for broadcast notifications on system bus".
broulik updated the summary for this revision.
broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

[knambiar (Rajeesh K Nambiar)]

knambiar added a comment.


  A query about the dbus calls in findTouchpads().

INLINE COMMENTS

> kwinwaylandbackend.cpp:72
> +QStringList devicesSysNames;
> +QVariant reply = m_deviceManager->property("devicesSysNames");
> +if (reply.isValid()) {

Just wondering whether these calls are synchronous and may cause delay in 
startup.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3617

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #kwin, #plasma_on_wayland, #plasma, #vdg
Cc: knambiar, kwin, plasma-devel, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, eliasp, sebas