D15110: Fix scrollbars in LibreOffice

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:43f2cb7c2334: Fix scrollbars in LibreOffice (authored by 
gepardo, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15110?vs=40529=40679#toc

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15110?vs=40529=40679

REVISION DETAIL
  https://phabricator.kde.org/D15110

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: gepardo, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15110: Fix scrollbars in LibreOffice

[Alexander Kernozhitsky]

gepardo added a comment.


  @davidedmundson, can you please merge this revision? I don't have a developer 
account, so I can't do it.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D15110

To: gepardo, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13481: Recommend window border size "None"

[Andres Betts]

abetts added a comment.


  I think we were able to identify the issues, even the ones pointed out in the 
discussions earlier in this ticket. I feel that we have a path forward.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13481

To: romangg, #plasma, #vdg
Cc: pedrogomes1698, hein, januz, ngraham, davidedmundson, graesslin, abetts, 
mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D13481: Recommend window border size "None"

[Nathaniel Graham]

ngraham added a comment.


  Yes, the plan was (is?) to make the content area touch the window edge with 
no separation at all, the way it does in for example apps on GNOME, 
ElementaryOS, Cinnamon, Windows, and macOS, not to mention our own Kirigami 
apps and some non-Kirigami apps like Konsole and Okular
  
  @romangg @hein @mart @davidedmundson @abetts we had some discussions about 
this at Akademy and if I recall, someone came up with an interesting solution 
to the "dead zone" problem; does anyone remember what it was? I'm still not 
convinced that this issue is a hard blocker, but I would be all for trying our 
best to address it if it helps us move forward.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13481

To: romangg, #plasma, #vdg
Cc: pedrogomes1698, hein, januz, ngraham, davidedmundson, graesslin, abetts, 
mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D13481: Recommend window border size "None"

[Pedro Gomes]

pedrogomes1698 added a comment.


  I'm on board with removing the borders, just wondering if things like this 
will be changed:
  
  Dolphin has nice spacing with borders:
  
  https://ibb.co/eur6tU
  
  With no borders it's way too close to the edge:
  
  https://ibb.co/gwXCYU

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13481

To: romangg, #plasma, #vdg
Cc: pedrogomes1698, hein, januz, ngraham, davidedmundson, graesslin, abetts, 
mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D14807: [AppStream Runner] Also search when there were errors during Pool::load

[Stefan Brüns]

bruns added a comment.


  Anyone at home? Not answering a simple question is rude, at best.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14807

To: bruns, #plasma, apol, #frameworks
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

[Jan Grulich]

jgrulich added a comment.


  Can we get some opinions from KDE Neon people? I have older review to bump NM 
requirements to 1.4.0 here https://phabricator.kde.org/D12493.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14835

To: volkov, #plasma, jgrulich, sitter, jriddell
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14035: Unbreak SSH agent support for SSH VPN tunnels.

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:38b659465d86: Unbreak SSH agent support for SSH VPN 
tunnels. (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14035?vs=39036=40664

REVISION DETAIL
  https://phabricator.kde.org/D14035

AFFECTED FILES
  kded/secretagent.cpp

To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14130: Parse protocol in port option

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1feaa4ca1cdf: Parse protocol in port option (authored by 
martinschulze, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14130?vs=37796=40663

REVISION DETAIL
  https://phabricator.kde.org/D14130

AFFECTED FILES
  vpn/openvpn/openvpn.cpp

To: martinschulze, #plasma, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15145: Fixes minor memory leak in the KNSBackend

[David Hallas]

hallas closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D15145

To: hallas, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

[Nathaniel Graham]

ngraham added a comment.


  In D13415#317064 , @sharvey wrote:
  
  > Thanks for the investigation. I've been hoping someone else would lend a 
pair of eyes to this problem for ages.
  >
  > When you change the icon in `user-manager` repeatedly, are you prompted for 
a root password **every time**? On my system (Tumbleweed), there's a "grace 
period" where I don't get re-prompted and the icon doesn't change reliably.
  
  
  Right, there is a "grace period" of five minutes after every time you enter 
your password. This is built into PolicyKit, I believe. As far as I can tell 
from keeping a Dolphin window open showing the contents of 
`/var/lib/AccountsService/icons/`, the icon immediately gets updated correctly 
on disk every single time I change it in `user-manager`. I'm unable to fully 
confirm your assertion that the icon only reliably gets changed in Kickoff 
after being promped for a password. For me, it's a bit more subtle than that: 
the icon only reliably gets changed in Kickoff  the **first** time I change it 
in `user-manager` that triggers a PolKit prompt after plasmashell has been 
started or restarted. I get a blank circle for all other circumstances:
  
  - Change icon in `user-manager` after restarting plasmashell less than 5 
minutes after the last change, such that there is no PolKit prompt
  - Change icon in `user-manager` twice after restarting plasmashell, waiting 
more than 5 minutes each time so a PolKit prompt will be triggered; second 
update does not change Kickoff
  
  I can also confirm @hein's report that this patch is 100% reliable when 
**not** using `user-manager`. I patched `KUser::faceIconPath()` in 
`KCoreAddons` to only ever return the `~/.face.icon` path, instead of 
`/var/lib/AccountsService/icons/$username`, and it becomes 100% reliable. I 
don't get the "Unsupported image format" error anymore, which is a little odd 
because the two images are identical:
  
  $  (master) md5sum /var/lib/AccountsService/icons/dev ~/.face.icon 
  28badcce926e3e4b1696e8bcac7b04d9  /var/lib/AccountsService/icons/dev
  28badcce926e3e4b1696e8bcac7b04d9  /home/dev/.face.icon
  
  What a weird bug.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13415

To: sharvey, ngraham, davidedmundson, mart, apol, abetts
Cc: sefaeyeoglu, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15145: Fixes minor memory leak in the KNSBackend

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Please put it in master.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15145

To: hallas, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D15130: make mycroftplasmoidplugin translatable

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  LGTM

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D15130

To: lueck, #plasma, #localization, Aiix, yurchor, apol
Cc: apol, yurchor, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

[Andres Betts]

abetts added a comment.


  Just a nitpick: Since we have a checkbox and then a label, can the label also 
have the word "Enable". We have transitioned into making actionable checkboxes 
to start their label with an active verb.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14989

To: phuongn, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 40647.
dkardarakos edited the summary of this revision.
dkardarakos added a comment.


  Function isSeparator removed

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15143?vs=40639=40647

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml
  src/controls/templates/AbstractListItem.qml

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D13617: Support kwin fractional scaling in wayland backend

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:3a0e95629912: Support kwin fractional scaling in wayland 
backend (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13617?vs=36349=40645#toc

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13617?vs=36349=40645

REVISION DETAIL
  https://phabricator.kde.org/D13617

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: davidedmundson, #kwin, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15145: Fixes minor memory leak in the KNSBackend

[David Hallas]

hallas created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes minor memory leak in the KNSBackend, the destructor of KNSBackend
  failed to delete the contents of the m_rootCategories vector.

TEST PLAN
  Build with -fsanitize=address
  Open and close Discover

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15145

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: hallas
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15143: Allow creation of separator Actions

[Kai Uwe Broulik]

broulik added a comment.


  `isSeparator()` is for use in C++, that method is neither a slot nor 
`Q_INVOKABLE` so you cannot use it from QML anyway.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos added a comment.


  isSeparator function has been added to ensure compatibility with QAction 
https://doc.qt.io/qt-5/qaction.html#isSeparator. We do not need it?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D14487: [Klipper] Only create KHelpMenu when used

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:adff6dcf7759: [Klipper] Only create KHelpMenu when used 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14487?vs=38783=40641

REVISION DETAIL
  https://phabricator.kde.org/D14487

AFFECTED FILES
  klipper/klipperpopup.cpp

To: broulik, #plasma, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15143: Allow creation of separator Actions

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Action.qml:172
> + */
> +function isSeparator() {
> +return separator;

That function is superfluous, you have the property after all

> ActionsMenu.qml:55
>  if (!action.children || action.children.length === 0) {
> -item = theMenu.itemDelegate.createObject(null, { 
> ourAction: action });
> +if (typeof action.isSeparator === "function" && 
> action.isSeparator()) {
> +item = theMenu.separatorDelegate.createObject(null, 
> {});

`if (action.separator)`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  The QAction class allows an action to be considered a separator. In Kirigami 
Action the separator property and the isSeparator function have been added to 
serve the same purpose. A set of delegates have been changed to draw a 
separator in case that an Action with separator:true has been found in the 
model.

TEST PLAN
  Add contextual or global actions like this:
  
  Kirigami.Action {
  
separator: true
  
  }

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml
  src/controls/templates/AbstractListItem.qml

To: dkardarakos, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

[Alexander Volkov]

volkov updated this revision to Diff 40632.
volkov added a comment.


  minimize the number of setDeviceStatisticsRefreshRateMs() callings

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14835?vs=39790=40632

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14835

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/TrafficMonitor.qml
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/models/networkmodelitem.h

To: volkov, #plasma, jgrulich
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14581: support for multilevel kcms

[Marco Martin]

mart updated this revision to Diff 40627.
mart added a comment.


  - remove old remains of extra layouts

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14581?vs=40502=40627

BRANCH
  arcpatch-D14581

REVISION DETAIL
  https://phabricator.kde.org/D14581

AFFECTED FILES
  core/ModuleView.cpp

To: mart, #plasma, #vdg
Cc: davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

[Scott Harvey]

sharvey added a comment.


  Thanks for the investigation. I've been hoping someone else would lend a pair 
of eyes to this problem for ages.
  
  When you change the icon in `user-manager` repeatedly, are you prompted for a 
root password **every time**? On my system (Tumbleweed), there's a "grace 
period" where I don't get re-prompted and the icon doesn't change reliably. It 
may be different on different system. @hein has said this works for him, but 
his system ( Fedora?) doesn't use `user-manager`.
  
  I think there's either a bug in QML or some weirdness in `user-manager` that 
I haven't been able to track down.
  
  Thanks for the tip on cutting the `OpacityMask` circle, although I doubt it's 
related to the bigger issue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13415

To: sharvey, ngraham, davidedmundson, mart, apol, abetts
Cc: sefaeyeoglu, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13853: Fix setting primary connector if primary output changed

[Robert Hoffmann]

hoffmannrobert added a comment.


  Thanks for reviewing. Can you please land it for me, I don't have commit 
access.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13853

To: hoffmannrobert, #plasma, mart, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

[Phuong Nguyen]

phuongn updated this revision to Diff 40619.
phuongn added a comment.


  Correct the erroneous logic for determining the next and previous desktop 
index

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14989?vs=40555=40619

REVISION DETAIL
  https://phabricator.kde.org/D14989

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/config.ui
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h
  
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop

To: phuongn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

[Phuong Nguyen]

phuongn updated this revision to Diff 40618.
phuongn added a comment.


  Correct the erroneous logic for determining the next and previous desktop 
index

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14988?vs=40549=40618

REVISION DETAIL
  https://phabricator.kde.org/D14988

AFFECTED FILES
  applets/pager/package/contents/config/main.xml
  applets/pager/package/contents/ui/configGeneral.qml
  applets/pager/package/contents/ui/main.qml

To: phuongn, #plasma, #vdg, davidedmundson
Cc: zzag, ngraham, abetts, davidedmundson, broulik, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart