D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  Kirigami FormLayout is a really nice control to work with. I'm a big fan. 
This port was easy peasy and I can't wait to do more of these!
  
  The double `Kirigami.Separator` items are to approximate what's wanted for 
https://bugs.kde.org/show_bug.cgi?id=399959, but this is probably an incorrect 
usage of them as-is. Would like to get @mart's opinion on the best way to add 
some whitespace to a Kirigami FormLayout.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43835.
ngraham added a comment.


  No more ugly hacks: port the whole thing to use a Kirigami FormLayout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43758=43835

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

[Nathaniel Graham]

ngraham updated this revision to Diff 43832.
ngraham added a comment.


  Do that correctly

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16287?vs=43831=43832

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16287

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/weather/package/contents/ui/FullRepresentation.qml

To: ngraham, #plasma, kossebau
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

[Nathaniel Graham]

ngraham updated this revision to Diff 43831.
ngraham added a comment.


  Rebase on master

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16287?vs=43830=43831

BRANCH
  configure-icons (branched from Plasma/5.14)

REVISION DETAIL
  https://phabricator.kde.org/D16287

AFFECTED FILES
  CMakeLists.txt
  applets/comic/package/contents/ui/main.qml
  applets/mediaframe/package/contents/ui/main.qml
  applets/mediaframe/plugin/mediaframe.cpp
  applets/mediaframe/plugin/mediaframe.h
  applets/weather/package/contents/ui/FullRepresentation.qml
  dataengines/potd/bingprovider.json
  runners/datetime/datetimerunner.cpp
  wallpapers/potd/metadata.desktop

To: ngraham, #plasma, kossebau
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  Nice catch, it looks like that's exactly right. Rebasing on master.
  
  @mart, any thoughts on https://bugs.kde.org/show_bug.cgi?id=399952?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16287

To: ngraham, #plasma, kossebau
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Not exactly sure, but:
  
  Icons for buttons might be a newer property than the min one for 
kdeplasma-addons 5.14 (which seems KF 5.50):
  
  The property seems only present since KF 5.51:  
https://phabricator.kde.org/R242:85cab5772c560ea248c490d9d58db87296dec06b
  
  Too bad properties as documented on 
https://api.kde.org/frameworks/plasma-framework/html/classorg_1_1kde_1_1plasma_1_1components_1_1Button.html
 do not have "Since" comments on them.
  
  So chance is this fix can be only done for master/Plasma 5.15.
  
  No time for deeper inspection right now myself, please check.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16287

To: ngraham, #plasma, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch gives the Comics and Weather widgets appropriate icons for their 
Configure... buttons.
  
  BUG: 399888
  FIXED-IN: 5.14.2

TEST PLAN
  [image goes here]
  
  Note that the size discrepancy appears to be an unrelated `PlasmaComponents3` 
bug: https://bugs.kde.org/show_bug.cgi?id=399952 (The Weather widget on top 
uses PC3, while the comits widget on bottom uses PC2)

REPOSITORY
  R114 Plasma Addons

BRANCH
  configure-icons (branched from Plasma/5.14)

REVISION DETAIL
  https://phabricator.kde.org/D16287

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/weather/package/contents/ui/FullRepresentation.qml

To: ngraham, #plasma, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:754efdedd4ee: [Lock Screen] Do not try to unlock when 
unvisible (authored by thsurrel).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16219?vs=43792=43824

REVISION DETAIL
  https://phabricator.kde.org/D16219

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MainBlock.qml

To: thsurrel, #plasma, #vdg, ngraham, davidedmundson
Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16284: do not force text for ToolButton

[Alexander Stippich]

astippich added a comment.


  I noticed this while porting from qqc1 to qqc2 for #Elisa 
, as the qqc2 ToolButton did not behave 
as expected.
  I don't know the reason why this was added and also have no clue about the 
implications this change may have.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text for ToolButton

[Alexander Stippich]

astippich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Do not force to display text besides the icon
  for the ToolButton

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16284

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: astippich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 43814.
hein edited the summary of this revision.
hein added a comment.


  Drop the TODO note from the message.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=43315=43814

BRANCH
  arcpatch-D14542

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Eike Hein]

hein updated this revision to Diff 43811.
hein added a comment.


  Remove two arg() fixes in the diff that should be in the other containment 
action diff

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15599?vs=43810=43811

BRANCH
  arcpatch-D15599

REVISION DETAIL
  https://phabricator.kde.org/D15599

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h

To: hein, mart, davidedmundson
Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Eike Hein]

hein updated this revision to Diff 43810.
hein added a comment.


  - Fix another arg() call
  - Do delete+remove in one step with take()
  - Fix loop condition
  
  Addressing other review comments:
  
  - More change tracking is not needed because of the later loop that 
indiscriminately calls setText/setData on all actions
  - The suggested qDeleteAll+resize method doesn't work because QHash has no 
resize()

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15599?vs=43754=43810

BRANCH
  arcpatch-D15599

REVISION DETAIL
  https://phabricator.kde.org/D15599

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h
  containmentactions/switchwindow/switch.cpp

To: hein, mart, davidedmundson
Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This commit splits ksmserver's xsession shutdown logic from performing
  the actual shutdown and running shutdown scripts and implement proposed
  org.kde.Shutdown interface.
  
  Intended longer term target is to move this to a separate executable.
  
  KSMServer's existing logout dbus method still exists for compatibility
  forwarding to the new interface.
  
  There are 2 minor behavioural changes.
  
  The shutdownMode property (which doesn't seem to do anything and is not
  exposed in our UI) is not kept.
  
  If you shutdown /whilst/ starting up somehow, previously we delayed
  showing the logout prompt, we now delay performing the actual logout.

TEST PLAN
  Logged out / shut down using the old API
  Logged out / shut down using the new DBus API

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksmserver_split

REVISION DETAIL
  https://phabricator.kde.org/D16277

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16275: don't set a user if there is no user

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:efd4c22bbe60: dont set a user if there is no user 
(authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16275?vs=43798=43799#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16275?vs=43798=43799

REVISION DETAIL
  https://phabricator.kde.org/D16275

AFFECTED FILES
  knetattach/knetattach.cpp

To: sitter, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16275: don't set a user if there is no user

[Harald Sitter]

sitter added a comment.


  I think ... since this gets put into the desktop file via `toDisplayString` 
and `toDisplayString` has the behavior that
  
  > With the default options, the resulting QString can be passed back to a 
QUrl later on, but any password that was present initially will be lost.
  
  what QUrl does is probably accurate. In that an empty QString is not a null 
QString, so if the goal is to reconstruct the same QUrl out of the string then 
encoding the empty username like that is reasonable. I've had a quick grep 
through rfc2396 and from a spec POV `@host == host` though.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16275

To: sitter, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma 5.15 Kickoff Meeting Minutes

[Jonathan Riddell]

People:
kbroulik
fvogt
acheronuk
sho
d_ed
apol
tsimonq2
nicofee
Aix
notmart
leszek
bshah
pepo
ivan (late to the party)
ripper17

* 5.14 review
Smooth release, no major problems, nice additions. Lack of bling new
features for a nice video but polish is more important.

Jonathan told not to snapshot KDE neon before release time even if
this means delays to ISO creation

5.15 features etherpad to be made at start of cycle and put in IRC /topic

phab 5.15 task created, can be used to track other tasks
https://phabricator.kde.org/T9887

* 2019 releases
Keep 4 month release cycle, 3 releases a year, Jonathan to make 2019 timetable

* LTS cycle
Jonathan to contact distros with dates of Plasma and Qt releases and
ask for desires for an LTS Plasma
* Jonathan to ask distros if further 5.12 LTS updates would be used
proposing every 6 months

* Qt and KF5 Deps
Qt 5.11 (or 5.12) is fine for Plasma 5.15
Dep on KF5 latest before beta, 5.55

* Phab item e-mail notifications
No e-mail sent to David for this item? To be investigated
https://phabricator.kde.org/T9658

* KCM porting
- Some to be moved to Plasma Workspace from Desktop for mobile use
case e.g. locale
- Plasma devs should try to port one or two each per cycle
https://phabricator.kde.org/project/view/254/
- sho to commit to  Accessibility KCM

* Other Todo items were discussed with comments added to Phab items

* p-b-i build-dep to be lowered and this promoted to distros so it can
be added to older Plasma releases [Jonathan and Kai Uwe]

* Jonathan to add tasks from other phab board such as accessibility
one to 5.15 task on phab

D16275: don't set a user if there is no user

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I wonder why `QUrl` doesn't clean that up on its own

INLINE COMMENTS

> knetattach.cpp:204
>  url.setHost(_host->text().trimmed());
> -url.setUserName(_user->text().trimmed());
> +auto trimmedUser = _user->text().trimmed();
> +if (!trimmedUser.isEmpty()) {

lazy, `const QString`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16275

To: sitter, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16275: don't set a user if there is no user

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it doesn't have technical downsides but ends up creating urls of the type
  
  scheme://@host/path
  
  which is technically equal to scheme://host/path, so the excess @ is really
  just not necessary. simply check if the username is empty and if so
  do not set a username on the QUrl

TEST PLAN
  - no useless @
  - setting up fish connection with and without username still works (without 
defaults to local username)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16275

AFFECTED FILES
  knetattach/knetattach.cpp

To: sitter, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16273: port knetattach from kurl to qurl

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:53255b7854eb: port knetattach from kurl to qurl (authored 
by sitter).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16273?vs=43794=43797

REVISION DETAIL
  https://phabricator.kde.org/D16273

AFFECTED FILES
  knetattach/knetattach.cpp
  knetattach/knetattach.h

To: sitter, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Nathaniel Graham]

ngraham added a comment.


  Let's land this on the `Plasma/5.14` branch and then merge to master. See 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_enterpressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg, ngraham, davidedmundson
Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Andres Betts]

abetts added a comment.


  +1 for the idea!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_enterpressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16273: port knetattach from kurl to qurl

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  kurl is deprecated.
  
  - s/kurl/qurl
  - non-existent functions ported per deprecation recommendation
  - fileEncoding replaced with url.queryItemValue("charset") which should be 
the fitting replacement from a quick look at the kurl code
  
  unfortunately there are still more kdelibs4support requirements left it
  seems :(

TEST PLAN
  - builds
  - connects to smb

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16273

AFFECTED FILES
  knetattach/knetattach.cpp
  knetattach/knetattach.h

To: sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Thomas Surrel]

thsurrel updated this revision to Diff 43792.
thsurrel added a comment.


  Do not access parent property directly
  Thanks for the comment davidedmundson

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16219?vs=43644=43792

BRANCH
  arc_enterpressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16219

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MainBlock.qml

To: thsurrel, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[David Edmundson]

davidedmundson added a comment.


  It's ok as-is, there's a code change that would make things a bit better.

INLINE COMMENTS

> MainBlock.qml:65
> +onAccepted: {
> +if (lockScreenRoot.uiVisible) {
> +startLogin();

It's generally bad practice to reference properties in the parent scope, it 
makes future refactors very difficult.

I would prefer an explicit property on MainBlock and then have LockScreenUi.qml 
bind that when it instantiates the MainBlock.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_enterpressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Willing to contribute

[Jonathan Riddell]

On Mon, Oct 15, 2018 at 12:51:54AM +0200, Aleix Pol wrote:
> On Sat, Oct 13, 2018 at 5:05 PM Antoon BERES  wrote:
> >
> > Hello,
> >
> > I'm pretty new to opensource projects etc in general, nevertheless, as a 
> > novice programmer the plasma-mobile project grabbed my interest. I am a 
> > chemist and hobby/amateur programmer (mainly python and C, still learning 
> > C, ..) I have been a linux/pc enthousiast for a long time and would love 
> > this project to succeed. My skills might not seem like much, and i might 
> > not be as much of use as some of the better professional programmers, but I 
> > am willing to learn and put effort into this project. I also have skills in 
> > photo-editing if those might be of use. If anyone can give me anything to 
> > do, I will gladly try to make it happen. It would be a good way to improve 
> > my programming and linux knowledge even further as well as gain experience 
> > with open source projects all while contributing to a project i support.
> >
> > Thanks.
> 
> Dear Antoon,
> Best way to get started is to find something that doesn't work for you
> and solve it. This way you'll have to go through setting up the
> environment, submitting a patch, etc.
> 
> Here's a good place to start from:
> https://community.kde.org/Get_Involved

Other tips
Hang out with us on #plasma
Join the Kickoff meeting which is about to happen there
Play around with C++, Qt and Qt Quick/QML
Go through the todos
Plasma: https://phabricator.kde.org/project/view/35/
Plasma Mobile: https://phabricator.kde.org/tag/plasma:_mobile/
Plasma Docs: https://phabricator.kde.org/tag/plasma:_docs/
Plasma on Wayland: https://phabricator.kde.org/project/view/99/
Plasma Accessibility: https://phabricator.kde.org/project/view/249/
Plasma KCM Redesign: https://phabricator.kde.org/project/view/254/
Convergence? https://phabricator.kde.org/project/view/240/
KWin: https://phabricator.kde.org/project/view/98/

KCM Redesign is probably a great one to get smallish interesting and useful 
projects in if you know C++ and QMl

Triage bugs on bugs.kde.org plasmashell component

Jonathan

meeting in 10 minutes

[Jonathan Riddell]

https://notes.kde.org/p/plasma-5.15-kickoff
#plasma

D15093: Add WireGuard capability.

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> CMakeLists.txt:8
> +wireguardauth.cpp
> +wireguardadvancedwidget.cpp
> +)

Missing wireguardkeyvalidator.cpp

> CMakeLists.txt:29
> +KF5::KIOWidgets
> +KF5::CoreAddons
> +)

Linking against following ones is enough:

  plasmanm_internal
  plasmanm_editor
  KF5::ConfigCore
  KF5::CoreAddons
  KF5::I18n
  KF5::KIOWidgets
  KF5::WidgetsAddons

> plasmanetworkmanagement_wireguardui.desktop:16
> +X-KDE-PluginInfo-EnabledByDefault=false
> +Name=WireGuard based VPN
> +Comment=Compatible with WireGuard VPN servers

Name could be just WireGuard I guess

> wireguardadvancedwidget.cpp:41
> +WireGuardAdvancedWidget::WireGuardAdvancedWidget(const 
> NetworkManager::VpnSetting::Ptr 
> + , QPalette normalPalette
> + , QPalette warningPalette

Coding style

> wireguardadvancedwidget.cpp:58
> +connect(d->ui.buttonBox, ::rejected, this, 
> ::reject);
> +connect(d->ui.presharedKeyLineEdit
> +, ::textChanged

Coding style

> wireguardadvancedwidget.cpp:63
> +connect(d->ui.tableLineEdit
> +, ::textChanged
> +, this

Coding style

> wireguardadvancedwidget.cpp:87
> +}
> +isPresharedKeyValid();
> +}

This validation doesn't seem to work, I can click on "ok" button even when the 
advanced widget is empty. Also it's a bit weird  that the function name 
suggests something else then it's doing. I would suggest splitting this into 
something like "updatePresharedKeyValidation()" and to the one you have now. 
One would really do just the check, the other would update the color.

Same please do for classic wireguard widget.

> wireguardadvancedwidget.cpp:92
> +{
> +delete d->keyValidator;
> +delete d->listenPortValidator;

Perhaps you should write a destructor for the private widget and here just 
delete the d-pointer.

> wireguardadvancedwidget.h:42
> +explicit WireGuardAdvancedWidget(const NetworkManager::VpnSetting::Ptr 
> 
> + , QPalette normalPalette
> + , QPalette warningPalette

Coding style

> wireguardwidget.cpp:30
> +#include 
> +#include 
> +

KColorScheme has been removed/deprecated in KDE Frameworks and it's only in 
KDELibs4support which we don't want to use. You should use QPalette instead.

> wireguardwidget.cpp:39
> +NetworkManager::VpnSetting::Ptr setting;
> +KSharedConfigPtr config;
> +QPalette warningPalette;

You also will not need this, because QPalette already should have used colors 
thanks to our KDE platform theme.

> wireguardwidget.cpp:60
> +
> +KColorScheme::adjustBackground(d->warningPalette
> +   , KColorScheme::NegativeBackground

Do not use KColorScheme. Use QPalette instead and you don't need to keeping it 
as class variable.

> wireguardwidget.cpp:73
> +
> +connect(d->ui.addressIPv4LineEdit, ::textChanged, this, 
> ::slotWidgetChanged);
> +connect(d->ui.addressIPv4LineEdit, ::textChanged, this, 
> ::isAddressValid);

Split isFooValid() functions, as mentioned in the advanced widget. Also 
slotWidgetChanged() will call isValid() I think, which means that each 
isFooValid() is called twice.

> wireguardwidget.cpp:196
> +QPointer adv = new 
> WireGuardAdvancedWidget(d->setting
> +, 
> d->normalPalette
> +, 
> d->warningPalette

Coding style

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

[Jan Grulich]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:71833088fb26: Upgrade SimpleIpV4AddressValidator and 
SimpleIpV6AddressValidator (authored by andersonbruce, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15520?vs=42297=43784

REVISION DETAIL
  https://phabricator.kde.org/D15520

AFFECTED FILES
  CMakeLists.txt
  libs/editor/CMakeLists.txt
  libs/editor/simpleiplistvalidator.cpp
  libs/editor/simpleiplistvalidator.h
  libs/editor/simpleipv4addressvalidator.cpp
  libs/editor/simpleipv4addressvalidator.h
  libs/editor/simpleipv6addressvalidator.cpp
  libs/editor/simpleipv6addressvalidator.h
  tests/CMakeLists.txt
  tests/simpleiplisttest.cpp
  tests/simpleipv4test.cpp
  tests/simpleipv6test.cpp

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.


  Thanks for the contribution. I'll push this change and do just some minor 
changes to the tests so you don't have to again go through review.

INLINE COMMENTS

> CMakeLists.txt:99
>  add_subdirectory(vpn)
> +add_subdirectory(tests)
>  

Tests shouldn't be build automatically, you should add somethine like 
https://cgit.kde.org/networkmanager-qt.git/tree/CMakeLists.txt#n43.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15520

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in startup.cpp:94-95
> Can these happen in parallel? In the old code (as far as I can understand it) 
> it did auto start first and then kcminit phase 1? or does `addSubjob` queue 
> them one after the other (doesn't look like it)?

Well read!

It was deliberate, but I should have commented it in the description.

Autostart apps job only launches, it doesn't (currently) block waiting for them 
to start.

Therefore it's effectively in parallel already.

> broulik wrote in startup.cpp:143
> As a next step I'd like to see this ported to libcanberra :P

Canberra has a systemd unit that plays startup/shutdown sounds automatically. 
It could be entirely someone elses problem. \o/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16269: Show correct current download and upload speed

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c5593b02df38: Show correct current download and upload 
speed (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16269?vs=43781=43782

REVISION DETAIL
  https://phabricator.kde.org/D16269

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  libs/models/networkmodel.cpp

To: jgrulich, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 7 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/7/
 Project:
stable-kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 17 Oct 2018 08:52:37 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2548)14%
(214/1481)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/158)0%
(0/84)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1249)21%
(138/666)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/221)0%
(0/116)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/35)

D16269: Show correct current download and upload speed

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  After recent change to use NM::DeviceStatistics instead of plasma dataengine, 
this part
  of code wasn't changed and instead of showing current download/upload speed, 
it was
  showing total downloaded/uploaded size

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16269

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  libs/models/networkmodel.cpp

To: jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

[Kai Uwe Broulik]

broulik added a comment.


  Pretty cool!

INLINE COMMENTS

> startup.cpp:94-95
> +qCDebug(KSMSERVER) << "Phase 0";
> +addSubjob(new AutoStartAppsJob(0));
> +addSubjob(new KCMInitJob(1));
> +}

Can these happen in parallel? In the old code (as far as I can understand it) 
it did auto start first and then kcminit phase 1? or does `addSubjob` queue 
them one after the other (doesn't look like it)?

> startup.cpp:143
>  }
>  Phonon::AudioOutput *m_audioOutput = new 
> Phonon::AudioOutput(Phonon::NotificationCategory, );
>  

As a next step I'd like to see this ported to libcanberra :P

> startup.cpp:206
> +connect(loginSound, ::finished, loginSound, 
> ::deleteLater);
> +loginSound->start();});
> +connect(phase2, ::finished, this, ::finishStartup);

Coding style, `});` on new line

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart