D21668: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cd6a8e081536: Modernize and redesign the Night Color 
config window (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59689=59698

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #vdg, ngraham, romangg, mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: Modernize and redesign the Night Color config window

2019-06-12 Thread Roman Gilg 
romangg added a comment.


  Looks nice! :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf added a comment.


  Thanks for having a look guys :)
  
  In D21668#478879 , @ngraham wrote:
  
  > Much better! Is there a reason why we need a ColumnLayout to hold those two 
FormLayouts in `main.qml`? Could all the stuff in the second one just go into 
the first one instead? Then you could get rid of the Columnlayout entirely
  
  
  That's what I wanted to do in the first place and was the first version I 
posted here, but it resulted in big binding loop issues and twinFormLayouts of 
loader forms failing to achieve alignment with the main one.
  
  There's still some points of improvement here I think:
  
  - child form layouts are only interlinked with the main one, but not vice 
versa -> the odds aren't big, but should there be any language where the labels 
in child layouts are longer that the ones in the main one, it will mess up the 
alignment
  - old bug: the times in the Locations mode should automatically be updated 
upon entering new coordinates (right now it only does so when switching modes)
  - kcm doesn't have the totally left aligned form layout mode when you shrink 
the window -> might be because of the SimpleKCM wrapper, not sure
  
  Fixing those things might come a lot easier to someone with more experience, 
but I'll keep them in mind for when I have more free time.
  
  For now I'll land this as I think the UI is in dire need of improvement!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21725: Use a native application for starting plasma

2019-06-12 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 59693.
apol added a comment.


  --verbose

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21725?vs=59597=59693

BRANCH
  apol/startkde

REVISION DETAIL
  https://phabricator.kde.org/D21725

AFFECTED FILES
  plasma.desktop.cmake
  plasmawayland.desktop.cmake
  startkde/CMakeLists.txt
  startkde/config-startplasma.h.cmake
  startkde/kcheckrunning/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp
  startkde/kcheckrunning/kcheckrunning.h
  startkde/kstartupconfig/CMakeLists.txt
  startkde/kstartupconfig/kdostartupconfig.cpp
  startkde/kstartupconfig/kstartupconfig.cpp
  startkde/plasma-sourceenv.sh
  startkde/startkde.cmake
  startkde/startplasma-wayland.cpp
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cmake
  startkde/startplasma.cpp
  startkde/startplasma.h
  startkde/startplasmacompositor.cmake

To: apol, #plasma, fvogt
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21668: Modernize and redesign the Night Color config window

2019-06-12 Thread Nathaniel Graham 
ngraham added a comment.


  Still, this looks great as-is. Probably landable now IMO, and a big 
improvement.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: Modernize and redesign the Night Color config window

2019-06-12 Thread Nathaniel Graham 
ngraham added a comment.


  Much better! Is there a reason why we need a ColumnLayout to hold those two 
FormLayouts in `main.qml`? Could all the stuff in the second one just go into 
the first one instead? Then you could get rid of the Columnlayout entirely

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf updated this revision to Diff 59689.
filipf edited the summary of this revision.
filipf added a comment.


  spacing of the main ColumnLayout needs to be 0

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59688=59689

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf updated this revision to Diff 59688.
filipf added a comment.


  make the form layouts respond to window resizing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59682=59688

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21326: Make limtedrowcountproxymodel usable from QML

2019-06-12 Thread David Edmundson 
davidedmundson abandoned this revision.
davidedmundson added a comment.


  Discover has a pagniation model which if you only use the first page covers 
this case.
  
  Lets try and get that one in frameworks instead

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21326

To: davidedmundson, #plasma
Cc: broulik, apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21758: [ksmserver] Drop internal loading of alternative window managers

2019-06-12 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e89473103c5b: [ksmserver] Drop internal loading of 
alternative window managers (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21758?vs=59629=59685

REVISION DETAIL
  https://phabricator.kde.org/D21758

AFFECTED FILES
  ksmserver/KSMServerInterface.h
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/server.cpp
  ksmserver/server.h

To: davidedmundson, #plasma, broulik, apol
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21757: [ksmserver] Drop multi X screen support

2019-06-12 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0916d9702a60: [ksmserver] Drop multi X screen support 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21757?vs=59628=59684

REVISION DETAIL
  https://phabricator.kde.org/D21757

AFFECTED FILES
  ksmserver/main.cpp
  ksmserver/server.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Nathaniel Graham 
ngraham added a comment.


  If I had to guess, it's because they're inside a column that doesn't span the 
full width of the page.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf added a comment.


  In D21668#478822 , @davidedmundson 
wrote:
  
  > > getting there; all is aligned now, it's just that the content needs to be 
unstiffened
  >
  > What does that mean
  >
  > Please remove the WIP tag when things are ready for review.
  >
  > Generally this looks good to me, ++
  
  
  Form layouts should be horizontally centered and adjust to the window size. 
Right now they're painfully stuck on the left side and won't budge when 
resizing the window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread David Edmundson 
davidedmundson added a comment.


  > getting there; all is aligned now, it's just that the content needs to be 
unstiffened
  
  What does that mean
  
  Please remove the WIP tag when things are ready for review.
  
  Generally this looks good to me, ++

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf updated this revision to Diff 59682.
filipf added a comment.


  getting there; all is aligned now, it's just that the content needs to be 
unstiffened

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59404=59682

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf added a comment.


  OK, so everything works nice if the form layouts simply reside in main.qml as 
components. It's when we spawn them through loaders that we get binding loops 
and misalignment (even if twinFormLayouts is specified!). The loader is not 
specifying geometry to the layouts so everything gets messed up.
  
  Unless there is some way to address this, I can remove the extra .qml view 
files, i.e. merge them with main.qml. There's also the method of anchoring the 
source components in the loader left and right. Neither seem ideal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21134: [Notifications] Tweak paddings

2019-06-12 Thread Alessandro Longo 
alex-l added a comment.


  Just a mockup but is this middle ground solution good enough?
  
  F6885918: immagine.png 
  
  ( I also suggested to move the disappearing indicator at the bottom here 
 )

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, LeGast00n, 
ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19745: Fix system tray UI/UX & refactor

2019-06-12 Thread Kai Uwe Broulik 
broulik added a comment.


  Will you address the broken event delivery to the compact applet item?

INLINE COMMENTS

> ratijastk wrote in AbstractItem.qml:22
> Not exactly. But old layouts used to have a load of restrictions, for sure.

"Old layouts"? You only use `Layouts 1.2` features as far as I can tell

> ratijastk wrote in AbstractItem.qml:30
> Oh, give it a rest.  These two lines looking good together, this way it is 
> clear that they are an opposite of each other.

You first have to evaluate the inner statement in your head and then negate it 
vs. just seeing at a glance what it is supposed to do

> ratijastk wrote in AbstractItem.qml:74
> Not even sure, is it directly my mistake, or rebase on that later master 
> branch. Could you provide more specific numbers, please?

When I revert this patch in master the icons return to normal, so this isn't a 
rebase issue.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21110: On config read adjust outputs positions to global value changes

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59671.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21110?vs=57836=59671

BRANCH
  1controlAdjustPositions

REVISION DETAIL
  https://phabricator.kde.org/D21110

AFFECTED FILES
  kded/output.cpp
  kded/output.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16997: [kcm] Expose interface to control output property retention

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59670.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16997?vs=57835=59670

BRANCH
  1controlKcm

REVISION DETAIL
  https://phabricator.kde.org/D16997

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/widget.cpp
  kcm/src/widget.h

To: romangg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16996: Add method to write retention to configuration control files

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59669.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16996?vs=57834=59669

BRANCH
  1controlWrite

REVISION DETAIL
  https://phabricator.kde.org/D16996

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16995: Consider identical display models in ControlConfig

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59667.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16995?vs=57833=59667

BRANCH
  1controlNameSpecific

REVISION DETAIL
  https://phabricator.kde.org/D16995

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp
  kded/output.cpp
  kded/output.h
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16994: Split Control class into configurations and outputs control classes

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59665.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16994?vs=57832=59665

BRANCH
  1controlClass

REVISION DETAIL
  https://phabricator.kde.org/D16994

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16993: Add a common directory for functionality being used by kcm and daemon

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59664.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16993?vs=57831=59664

BRANCH
  1commonInterfacesWithClass

REVISION DETAIL
  https://phabricator.kde.org/D16993

AFFECTED FILES
  common/control.cpp
  common/control.h
  common/globals.cpp
  common/globals.h
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16992: Introduce secondary control channel of the KScreen daemon

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59663.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16992?vs=57830=59663

BRANCH
  1controlRetention

REVISION DETAIL
  https://phabricator.kde.org/D16992

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/229fa9e8a378cb151d7302df42666774
  tests/kded/serializerdata/control/configs/8684e883209d7644eb76feea2081c431
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16991: Introduce concept of global and individual output data retention

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59662.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16991?vs=57829=59662

BRANCH
  1dirIndividualOutputs

REVISION DETAIL
  https://phabricator.kde.org/D16991

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16990: [kded] Separate configuration storage path

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59661.
romangg added a comment.


  Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16990?vs=57660=59661

BRANCH
  1configsLocation

REVISION DETAIL
  https://phabricator.kde.org/D16990

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  tests/kded/configtest.cpp

To: romangg, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20237: Port to new KWorkspace API

2019-06-12 Thread Eike Hein 
hein updated this revision to Diff 59660.
hein added a comment.


  - Fix typo
  - Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20237?vs=55487=59660

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20237

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/plugin/abstractmodel.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/systementry.cpp
  applets/kicker/plugin/systementry.h
  applets/kicker/plugin/systemmodel.cpp
  applets/kicker/plugin/systemmodel.h
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: hein, #plasma, davidedmundson
Cc: broulik, apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D16989: [kded] Introduce Config wrapper class

2019-06-12 Thread Roman Gilg 
romangg updated this revision to Diff 59653.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16989?vs=57655=59653

BRANCH
  1configClass

REVISION DETAIL
  https://phabricator.kde.org/D16989

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializertest.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

2019-06-12 Thread Harald Sitter 
sitter updated this revision to Diff 59651.
sitter added a comment.


  handle error conditions
  
  since we use QSP::locate we can at most have 0-1 service. 
  in the event that we have 0 we'll set the kjob into error state and return 
false as result.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21761?vs=59638=59651

BRANCH
  soliduiserver

REVISION DETAIL
  https://phabricator.kde.org/D21761

AFFECTED FILES
  dataengines/hotplug/CMakeLists.txt
  dataengines/hotplug/Messages.sh
  dataengines/hotplug/deviceaction.cpp
  dataengines/hotplug/deviceaction.h
  dataengines/hotplug/deviceserviceaction.cpp
  dataengines/hotplug/deviceserviceaction.h
  dataengines/hotplug/hotplugjob.cpp
  soliduiserver/CMakeLists.txt
  soliduiserver/deviceaction.cpp
  soliduiserver/deviceaction.h
  soliduiserver/deviceactionsdialog.cpp
  soliduiserver/deviceactionsdialog.h
  soliduiserver/deviceactionsdialogview.ui
  soliduiserver/devicenothingaction.cpp
  soliduiserver/devicenothingaction.h
  soliduiserver/deviceserviceaction.cpp
  soliduiserver/deviceserviceaction.h
  soliduiserver/soliduiserver.cpp
  soliduiserver/soliduiserver.h

To: sitter, broulik
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21765: drop kdelibs4support from filebrowser dataengine

2019-06-12 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3b21b593f656: drop kdelibs4support from filebrowser 
dataengine (authored by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21765?vs=59643=59649

REVISION DETAIL
  https://phabricator.kde.org/D21765

AFFECTED FILES
  dataengines/filebrowser/CMakeLists.txt
  dataengines/filebrowser/filebrowserengine.cpp

To: sitter, davidedmundson
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21766: do not use legacy app_icon helper on klipper

2019-06-12 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:24874e13cbeb: do not use legacy app_icon helper on 
klipper (authored by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21766?vs=59646=59648

REVISION DETAIL
  https://phabricator.kde.org/D21766

AFFECTED FILES
  klipper/CMakeLists.txt

To: sitter, davidedmundson
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

2019-06-12 Thread Harald Sitter 
sitter added a comment.


  How do I correctly forward a visible error to the caller though? This 
ServiceJob tech is fairly beyond me. Showing a KNotification on error may be a 
solution, but surely there must be a better way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21761

To: sitter, broulik
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21766: do not use legacy app_icon helper on klipper

2019-06-12 Thread Harald Sitter 
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  kde4_add_app_icon is fairly deprecated. additionally the call itself
  was madness because it actually pulls the icon out of oxygen in the install
  location. that is assuming the icon theme is even installed at build time
  (which is probably always not true in our binary factorization
  environments). lastly the app_icon helper is only useful to pick up
  icons for osx and windows, neither are target platforms for plasma.
  
  remove the app_icon call entirely until a use for it arises, which should
  be... never... unless we decide that we want to replace explorer.exe ;)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  noappicon

REVISION DETAIL
  https://phabricator.kde.org/D21766

AFFECTED FILES
  klipper/CMakeLists.txt

To: sitter
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21765: drop kdelibs4support from filebrowser dataengine

2019-06-12 Thread Harald Sitter 
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this engine is not used anywhere!
  
  the engine used kfilemetadata to obtain metadata of a file. KFM however
  is entirely defunct and does absolutely nothing without nepomuk.
  that is to say: it is already broken for years and in fact not even
  correctly sets the item.type key because of how the original code worked.
  
  this change drops the kfilemetdata use altogether and instead sets the
  item.type (which we can easily determine) to file when working with a file
  
  in theory (I think) Baloo/File is the modern replacement for kfilemetadata,
  but its properties are no longer "stringy" so we'd have to map a huge
  enum manually into stringy keys for our representation. which at this time
  seems not worth it, considering we (KDE) do not seem to use the engine
  anymore and third parties would have had an entirely broken engine WRT file
  sources as well, so I am guessing no one outside KDE uses it either.
  all things considered I think simply rolling the engine back to the
  minimum functional use is the best course of action here.
  
  this effectively only changes the engine behavior to once again set
  item.type=file on actual files while making it no longer require
  kdelibs4support.

TEST PLAN
  in engine explorer requesting a directory gives unaltered directory data,
  when requesting a file it correctly sets the type to file

REPOSITORY
  R120 Plasma Workspace

BRANCH
  filebrowser

REVISION DETAIL
  https://phabricator.kde.org/D21765

AFFECTED FILES
  dataengines/filebrowser/CMakeLists.txt
  dataengines/filebrowser/filebrowserengine.cpp

To: sitter
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21762: do not use long deprecated QString::toAscii

2019-06-12 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> waylandtasksmodel.cpp:350
>  // cross-process DND.
> -return QString("windowsystem/winid+" + uuid.toString().toAscii());
> +return QString("windowsystem/winid+" + uuid.toString().toLatin1());
>  }

It's using weird API we shouldn't be using. It's creating a QString after all 
so I'd do:
`return QStringLiteral("windowsystem/winid+") + uuid.toString();`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21762

To: sitter, hein
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21764: Port all plasma workspace to new libkworkspace API

2019-06-12 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  ContainmentActions had some old windows code was dropped as that's
  clearly unused.
  
  logout and leave actions now enable/disable at runtime, so in future can
  respond to config changes when that's added to libkworkspace.
  
  DataEngines and the krunner code should have no visible changes

TEST PLAN
  Left from the desktop and from krunner
  Changed the default action in ksmserver's kcm
  Confirmed that changes the default leave action changed

REPOSITORY
  R120 Plasma Workspace

BRANCH
  kworkspace3

REVISION DETAIL
  https://phabricator.kde.org/D21764

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  dataengines/powermanagement/powermanagementjob.cpp
  dataengines/powermanagement/powermanagementjob.h
  ksmserver/shutdown.cpp
  runners/sessions/sessionrunner.cpp
  runners/sessions/sessionrunner.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21763: [kcms/ksmserver] Port to new kworkspace API

2019-06-12 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  requestShutDown is replaced

TEST PLAN
  Bodged the code so that it made my system think it had firmware support
  Clicked checkbox, pressed button. Got my shutdown prompt

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21763

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21762: do not use long deprecated QString::toAscii

2019-06-12 Thread Harald Sitter 
sitter created this revision.
sitter added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  use toLatin1 instead

TEST PLAN
  builds

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21762

AFFECTED FILES
  libtaskmanager/waylandtasksmodel.cpp

To: sitter, hein
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

2019-06-12 Thread Kai Uwe Broulik 
broulik added a comment.


  In D21761#478528 , @sitter wrote:
  
  > I suppose it should never happen that an action cannot be resolved, so 
maybe an assertion to that extent is sufficient?
  
  
  Given device notifier only invokes it on actions it queried for earlier, it 
should not fail. However, dataengines are kinda "public API", so a 3rd party 
applet could trip an error here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21761

To: sitter, broulik
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

2019-06-12 Thread Harald Sitter 
sitter added a comment.


  I am unsure about the error handling in `HotplugJob::start` I suppose it 
should never happen that an action cannot be resolved, so maybe an assertion to 
that extent is sufficient?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21761

To: sitter, broulik
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

2019-06-12 Thread Harald Sitter 
sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it was the only remaining user of that dialog helper.
  the connection between the two was fairly meh. the engine would invoke the
  kded module over dbus, the module would then process the request, find that
  only one desktop entry is specified, resulting in one action being found
  and then running that action on behalf of the engine. this is overly
  complicated for no additional gain. the engine is the sole user of this
  functionality AND it already had knowledge of the service system, so
  soliduiserver in this case doesn't actually add anything. it's just a more
  involved call chain.
  
  the useful code of soliduiserver is now in the hotplug dataengine directly
  and the soliduiserver no longer supports the actions dialog. hotplug is now
  the sole authority for hotplugging.
  
  soliduiserver:
  
  - include cleanup
  - all classes no longer in use have been removed
  - kdelibs4support is no longer a link target
  - new link targets i18n + widgetsaddons (previously pulled in by 
kdelibs4support)
  
  hotplug:
  
  - hotplugjob now directly executes service actions using classes imported 
from soliduiserver
  - no longer links qtdbus
  - new translation domain plasma_engine_hotplug (for i18n call in imported 
service classes)
  - new link against ki18n for that reason

TEST PLAN
  running an action works same as before, internally it no longer relies on 
dbus/kded

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21761

AFFECTED FILES
  dataengines/hotplug/CMakeLists.txt
  dataengines/hotplug/Messages.sh
  dataengines/hotplug/deviceaction.cpp
  dataengines/hotplug/deviceaction.h
  dataengines/hotplug/deviceserviceaction.cpp
  dataengines/hotplug/deviceserviceaction.h
  dataengines/hotplug/hotplugjob.cpp
  soliduiserver/CMakeLists.txt
  soliduiserver/deviceaction.cpp
  soliduiserver/deviceaction.h
  soliduiserver/deviceactionsdialog.cpp
  soliduiserver/deviceactionsdialog.h
  soliduiserver/deviceactionsdialogview.ui
  soliduiserver/devicenothingaction.cpp
  soliduiserver/devicenothingaction.h
  soliduiserver/deviceserviceaction.cpp
  soliduiserver/deviceserviceaction.h
  soliduiserver/soliduiserver.cpp
  soliduiserver/soliduiserver.h

To: sitter, broulik
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20804: RFC: Try getting the X keyboard grab multiple times

2019-06-12 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:4af9ea1e2c9d: Try getting the X keyboard grab multiple 
times (authored by davidedmundson).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20804?vs=56950=59637

REVISION DETAIL
  https://phabricator.kde.org/D20804

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h
  ksldapp.cpp
  ksldapp.h

To: davidedmundson, #plasma, #kwin, zzag
Cc: zzag, broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21113: Allow hiding option items depending on available extension and version in the host

2019-06-12 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in options.js:82
> AFAICT it doesn't conflict, but IMO it's a bit confusing if there's both a 
> global array `subsystemStatus` in extension.js and a function 
> `subsystemStatus()` in options.js.

I'll rename this to `getSubsystemStatus()` then

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21113

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21748: Replace the excludeRange mode setting when already available

2019-06-12 Thread Bhushan Shah 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:08ec9a036bf5: Replace the excludeRange mode setting when 
already available (authored by bshah).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21748?vs=59601=59630

REVISION DETAIL
  https://phabricator.kde.org/D21748

AFFECTED FILES
  kcms/fonts/kxftconfig.cpp

To: bshah, fvogt, ngraham
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart