D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Mirai Komachi]

miraiko added a comment.


  Thank you for the review.
  
  In D24711#548523 , @ngraham wrote:
  
  > Did this change recently?
  
  
  According to xf86-input-libinput git, this has been since 2015.
  
https://cgit.freedesktop.org/xorg/driver/xf86-input-libinput/commit/?id=0163482e22ad65ec51e3636cf31f9f39e29ff709
  "Now" is a superfluous word here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24721: Bug 399530

[Bruno Gonçalves]

brunogoncalves created this revision.
brunogoncalves added a reviewer: Discover Software Store.
brunogoncalves added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
brunogoncalves requested review of this revision.

REVISION SUMMARY
  Separates appstream, flatpak and snap packages, also informs package version 
and package type next to name.
  
  F7611847: discover-separated.jpg 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24721

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
  libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
  libdiscover/backends/SnapBackend/SnapResource.cpp

To: brunogoncalves, #discover_software_store
Cc: plasma-devel, #discover_software_store, LeGast00n, The-Feren-OS-Dev, 
semareit, jraleigh, bam, fbampaloukas, GB_2, ragreen, ixoos, ZrenBot, James, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a comment.


  In D24706#548676 , @ngraham wrote:
  
  > Hmm, I'm not sure it's working then. Focused pushbuttons still get a blue 
background.
  
  
  I didn't change the diff yet

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24687: [KCM] Add output selector ComboBox

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> Panel.qml:33
> +level: 2
> +// FIXME i18n change text in master
> +text: i18n("Settings for %1", " ")

what does this FIXME mean?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24687

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24719: Fix laptop screen being off when opening the lid

[Roman Gilg]

romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> config.cpp:88
>  {
> -const QString openLidFilePath = filePath() % 
> QStringLiteral("_lidOpened");
> +const QString openLidFilePath = id() % QStringLiteral("_lidOpened");
>  auto config = readFile(openLidFilePath);

Rename variable

> config.cpp:90
>  auto config = readFile(openLidFilePath);
>  QFile::remove(openLidFilePath);
>  return config;

`configsDirPath()` needs to be prepended here now.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24719

To: nicolasfella, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:eac67d4fad3b: [Updates page] Add text to the checkbox 
instead of putting it in a separate… (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24712?vs=68087=68106

REVISION DETAIL
  https://phabricator.kde.org/D24712

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #discover_software_store, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

[Nathaniel Graham]

ngraham added a comment.


  @aspotashev is a translator and he's approved, so I'd say you're good to go.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I'm not sure it's working then. Focused pushbuttons still get a blue 
background.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a comment.


  In D24706#548444 , @ngraham wrote:
  
  > Oh nice, lol. Could you do the same thing for pushbuttons and non-checked 
toggle buttons and comboboxes too? That way the focus behavior for checked 
toggle buttons wouldn't become inconsistent with the focus behavior for those 
other items.
  
  
  They all get their looks from the same helper functions, so that's basically 
already done.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf added a comment.


  The paddings issue is actually the same as with notifications (D21813 
). We can tweak it here and then alter it 
for all desktop themes, some of which already add extra padding on their own. 
This means we're messing with their looks.
  
  Or we could add padding to our SVGs, which seems neater. I don't have the SVG 
skills to do it, but if we opt for that I'll just revert the padding changes 
here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

[Filip Fila]

filipf added a comment.


  Do we have a green light for 5.17.1? How do I tag the translators?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Yeah, can't get this to work properly anyway.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24567

To: filipf, #vdg, #plasma, mart
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf updated this revision to Diff 68103.
filipf added a comment.


  remove useless leftover stuff from WIP versions

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24720?vs=68102=68103

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:93
> +icon.name: "window-pin"
> +//tooltip: i18n("Keep Open")
> +}

How do I use tooltips with PC3 here again?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Currently the code that draws plasmoid popups utilizes an anchor based 
approach.
  
  I think layouts are a more elegant solution so this patch makes use of them.
  
  I also tried to tweak the paddings some.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23330: Make manual control compatible with redshift >= 1.12

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R885:898c3a4cfc6c: Make manual control compatible with 
redshift = 1.12 (authored by vermeeren, committed by ngraham).

REPOSITORY
  R885 Redshift Control for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23330?vs=64263=68101

REVISION DETAIL
  https://phabricator.kde.org/D23330

AFFECTED FILES
  package/contents/ui/CompactRepresentation.qml

To: vermeeren, martinkostolny, #plasma, mart
Cc: mart, ltoscano, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24718: [wayland] Don't init m_internalConfig twice

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:f948b5bcedbb: [wayland] Dont init m_internalConfig 
twice (authored by nicolasfella).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24718?vs=68097=68100

REVISION DETAIL
  https://phabricator.kde.org/D24718

AFFECTED FILES
  backends/kwayland/waylandbackend.cpp

To: nicolasfella, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24719: Fix laptop screen being off when opening the lid

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  filePath() returns the full path to the config file. readFile() then prepends 
configsDirPath() to the path, leading to a garbled file path and making it 
impossible to load the right file. We should instead just pass id() + _lidOpen 
to readFile.

TEST PLAN
  Connected a monitor to my laptop. Closed and reopened the lid.
  Before:
  Laptop screen was off. Needed turning on in the KCM.
  After:
  Laptop screen is on.
  
  Both X11 and Wayland

REPOSITORY
  R104 KScreen

BRANCH
  fixit

REVISION DETAIL
  https://phabricator.kde.org/D24719

AFFECTED FILES
  kded/config.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24712

To: ngraham, apol, #discover_software_store, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24713: [RFC] [Updates page] use fancier logic for handling elided Old+New version strings

[Nathaniel Graham]

ngraham updated this revision to Diff 68098.
ngraham added a comment.


  Make it display

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24713?vs=68088=68098

BRANCH
  fancier-long-version-string-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24713

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, apol, broulik, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

[Aleix Pol Gonzalez]

apol added a comment.


  You can test using `--backends dummy`.
  To enable the build of the dummy backend, you pass -DBUILD_DummyBackend=ON to 
cmake.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24712

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24717: [Advanced Settings] Clean up UI file

[David Edmundson]

davidedmundson added a comment.


  Looks the same.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D24717

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24718: [wayland] Don't init m_internalConfig twice

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It it initialized 4 lines prior. Once should be enough.

TEST PLAN
  addOutput/removeOutput isn't duplicated any more

REPOSITORY
  R110 KScreen Library

BRANCH
  notwins

REVISION DETAIL
  https://phabricator.kde.org/D24718

AFFECTED FILES
  backends/kwayland/waylandbackend.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Arjen Hiemstra]

ahiemstra added a comment.


  > now has the order main action, left, right. before was left, main right.
  >  it does change a bit the behavior, tough i see the point of making sure 
that the main action is always the last being hidden (i wonder how it would be 
making it hide last even if not the last)
  
  While working on it, I realised that the left, main, right order actually 
doesn't make sense when placed in the toolbar, considering the main action is 
the most important action and normal order would be left-to-right with the most 
imporant on the leftmost place. It is easy enough to change back but I do 
consider this more "correct".
  
  > testing it i did find a major problem: if i resize the window quickly 
(kirigami gallery 2 columns mode) when it goes from icon+text to just icon, the 
window freezes for an instant, seems quite expensive, while before didn't do 
that
  >  from the code nothing should have gotten particularly worse, so not sure 
how to debug
  
  The main cause for this I believe is in the toolbar header file. It currently 
removes the overflow actions from the main action list when switching to the 
icon-only layout, which causes removal/recreation of hidden actions used for 
layout. I've been looking at implementing this behaviour in the actual 
actiontoolbar, which hopefully removes the need for all of that and speed up 
things. It's why this is still WIP. :)

REPOSITORY
  R169 Kirigami

BRANCH
  contextactions_in_toolbar

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami, ngraham
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24717: [Advanced Settings] Clean up UI file

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Remove pointless outer layout and spacer items.
  
  BUG: 412971
  FIXED-IN: 5.17.1

TEST PLAN
  Looks almost the same still, haven't tested on Qt 5.14.
  Should probably use two flat `QGroupBox`es instead but the "Battery levels" 
label uses HTML `` to become bold and excess whitespace at the end, i.e. 
would require string changes, so this is good enough for stable.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D24717

AFFECTED FILES
  kcmodule/global/generalPage.ui

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24715: Show a message indicating that no TB devices are connected when the list is empty

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, dvratil.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  ...Otherwise the user might think that it's just broken.

TEST PLAN
  Before: F7609800: Before.png 
  After: F7609799: After.png 

REPOSITORY
  R1044 Plasma Thunderbolt Integration

BRANCH
  helpful-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24715

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceList.qml

To: ngraham, #vdg, #plasma, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Nathaniel Graham]

ngraham added a comment.


  Thanks for submitting this patch!
  
  What exactly do you mean by "now"? Did this change recently?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24713: [RFC] [Updates page] use fancier logic for handling elided Old+New version strings

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, broulik, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  @broulik taught me how to do this! It's more robust than the current logic, 
which
  doesn't expand to the full form when the window becomes wide enough to show 
the
  whole string without eliding.

TEST PLAN
  As yet untested; need to test first, preferably on neon where the version 
strings are
  enormous

REPOSITORY
  R134 Discover Software Store

BRANCH
  fancier-long-version-string-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24713

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, apol, broulik, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

TEST PLAN
  Can't test; no updates available right now

REPOSITORY
  R134 Discover Software Store

BRANCH
  real-checkbox-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24712

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24488: [kcm] Don't transform button to show rotated icon

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ae555055b2ea: [kcm] Dont transform button to show 
rotated icon (authored by davidedmundson).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24488?vs=68085=68086

REVISION DETAIL
  https://phabricator.kde.org/D24488

AFFECTED FILES
  kcm/package/contents/ui/RotationButton.qml

To: davidedmundson, #plasma, ngraham, romangg
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Mirai Komachi]

miraiko created this revision.
miraiko added a reviewer: Plasma.
miraiko added a project: Plasma.
miraiko requested review of this revision.

REVISION SUMMARY
  LIBINPUT_PROP_ACCEL_PROFILE_ENABLED now contains two values, 
valueWriterPart function didn't handle it correctly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

AFFECTED FILES
  kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp

To: miraiko, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24488: [kcm] Don't transform button to show rotated icon

[David Edmundson]

davidedmundson updated this revision to Diff 68085.
davidedmundson added a comment.


  Use units
  Use rotation directly

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24488?vs=68077=68085

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24488

AFFECTED FILES
  kcm/package/contents/ui/RotationButton.qml

To: davidedmundson, #plasma, ngraham, romangg
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/26/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 16 Oct 2019 20:26:21 +
 Build duration:
3 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.tests Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.tests.kded.kscreen_kded_configtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)48%
(14/29)48%
(14/29)42%
(1364/3227)31%
(722/2330)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalscommon75%
(3/4)75%
(3/4)47%
(59/126)50%
(29/58)console0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/74)kcm0%
(0/7)0%
(0/7)0%
(0/937)0%
(0/567)kded70%
(7/10)70%
(7/10)55%
(693/1259)41%
(442/1069)plasmoid0%
(0/2)0%
(0/2)0%
(0/39)0%
(0/10)tests.kded100%
(2/2)100%
(2/2)93%
(570/610)47%
(242/518)tests.osd100%
(2/2)100%
(2/2)60%
(42/70)26%
(9/34)

D24488: [kcm] Don't transform button to show rotated icon

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> RotationButton.qml:41
> +source: "view-preview"
> +transform: Rotation {
> +origin {

why not just use `rotation` property?

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24488

To: davidedmundson, #plasma, ngraham, romangg
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:03ce6234aa96: [Weather data engine] Handle windy 
conditions in NOAA backend (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24483?vs=67640=68081

REVISION DETAIL
  https://phabricator.kde.org/D24483

AFFECTED FILES
  dataengines/weather/ions/ion.cpp
  dataengines/weather/ions/ion.h
  dataengines/weather/ions/noaa/ion_noaa.cpp

To: ngraham, kossebau, #plasma, spstarr
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a comment.


  I feel like the hover effect is not obvious enough though. In the future, I 
might want to make it so that the hover color is mixed with the current 
background color. That way it will be more visually related to whatever the 
toggled/untoggled state is. I might need to change the hover color to a shade 
of gray for that to look right.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Nathaniel Graham]

ngraham added a comment.


  Oh nice, lol. Could you do the same thing for pushbuttons and non-checked 
toggle buttons and comboboxes too? That way the focus behavior for checked 
toggle buttons wouldn't become inconsistent with the focus behavior for those 
other items.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a comment.


  Same thing, but with the toggle button focused and toggled.
  F7609177: Screenshot_20191016_153732.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a subscriber: ngraham.
ndavis added a comment.


  In D24706#548392 , @ngraham wrote:
  
  > I see what you're trying to do here, and I approve. But I think it might 
make more sense to more generally rethink how we indicate focus for buttons. 
IMO we should draw a highlight around the edges rather than changing the 
background color, for the following reasons:
  >
  > - It would avoid any confusion whatsoever regarding checkable buttons
  > - It would make the currently focused button stop inappropriately looking 
like it's a dialog's default button
  > - It would be more consistent with how focus is indicated for other UI 
elements in Breeze (e.g toolbuttons and line edits)
  > - It would be more consistent with how other focus is indicated for other 
widget styles and platforms (e.g. macOS, Windows, and GNOME's Adwaita all show 
focus with a line around the edges)
  
  
  We already do that, it would just be a matter of removing the logic for using 
the focus color in the background. Here I did that to the focus color and the 
hover color: F7609151: Screenshot_20191016_153517.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24488: [kcm] Don't transform button to show rotated icon

[Nathaniel Graham]

ngraham added a comment.


  5.17?

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24488

To: davidedmundson, #plasma, ngraham
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24488: [kcm] Don't transform button to show rotated icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> RotationButton.qml:59
>  
> -implicitWidth: 45
> -implicitHeight: 45
> +implicitWidth: contentItem.implicitWidth + 2 * 4
> +implicitHeight: contentItem.implicitHeight + 2 * 4

Kirigami.units.smallSpacing instead of hardcoded 2

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24488

To: davidedmundson, #plasma, ngraham
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24488: [kcm] Don't transform button to show rotated icon

[David Edmundson]

davidedmundson added a comment.


  If Kai says this is the right approach, it probably is

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24488

To: davidedmundson, #plasma
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24488: [kcm] Don't transform button to show rotated icon

[David Edmundson]

davidedmundson updated this revision to Diff 68077.
davidedmundson added a comment.


  update2

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24488?vs=68076=68077

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24488

AFFECTED FILES
  kcm/package/contents/ui/RotationButton.qml

To: davidedmundson, #plasma
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24488: [kcm] Don't transform button to show rotated icon

[David Edmundson]

davidedmundson updated this revision to Diff 68076.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.


  update

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24488?vs=67488=68076

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24488

AFFECTED FILES
  kcm/package/contents/ui/RotationButton.qml

To: davidedmundson, #plasma
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24706: Don't use focus color on checkable button backgrounds

[Nathaniel Graham]

ngraham added a comment.


  I see what you're trying to do here, and I approve. But I think it might make 
more sense to more generally rethink how we indicate focus for buttons. IMO we 
should draw a highlight around the edges rather than changing the background 
color, for the following reasons:
  
  - It would avoid any confusion whatsoever regarding checkable buttons
  - It would make the currently focused button stop inappropriately looking 
like it's a dialog's default button
  - It would be more consistent with how focus is indicated for other UI 
elements in Breeze (e.g toolbuttons and line edits)
  - It would be more consistent with how other focus is indicated for other 
widget styles and platforms (e.g. macOS, Windows, and GNOME's Adwaits all show 
focus with a line around the edges)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24488: [kcm] Don't transform button to show rotated icon

[Kai Uwe Broulik]

broulik added a comment.


  I would still suggest overriding the `contentItem` of the `Button` and put a 
rotated `Kirigami.Icon` in there without actually transforming the entire 
button.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24488

To: davidedmundson, #plasma
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

ngraham added a comment.


  Nice. The icons should go in today, after which I'll land this.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma, spstarr
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24488: [kcm] Don't transform button to show rotated icon

[Nathaniel Graham]

ngraham added a comment.


  I agree with roman that the rotated icons are preferable from a usability 
perspective. Maybe we need new icons then? #VDG 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24488

To: davidedmundson, #plasma
Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a comment.


  The hover color is still kind of an issue, but less of an issue. It looked 
really stiff and unnatural without something to indicate that it can be hovered.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis updated this revision to Diff 68070.
ndavis added a comment.


  Wait no, I got it
  
  - Don't use HighlightedText if sunken

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24706?vs=68069=68070

BRANCH
  focus-toggle-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24706

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14245: Use '-P' option to properly adjust color temperature in manual mode

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Superseded by D23330 .

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14245

To: ngraham, martinkostolny, andrewc
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23401: Fix scroll control (add -P option)

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Superseded by D23330 .

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23401

To: ngraham, martinkostolny, srenaud
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14068: add -P switch to one-shot redshift call

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Superseded by D23330 .

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: ngraham, #plasma, romangg, martinkostolny, grmat
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  This works really well in Discover, Kamoso, and kirigami-gallery. Still a big 
thumbs-up from me.

REPOSITORY
  R169 Kirigami

BRANCH
  contextactions_in_toolbar

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami, ngraham
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a comment.


  Darn, I just realized the text still uses the highlight text color. Not sure 
how to fix that besides changing the color in the colorscheme.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis updated this revision to Diff 68069.
ndavis removed a subscriber: ngraham.
ndavis added a comment.


  Change the style of the if else in the AnimationHover section

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24706?vs=68068=68069

BRANCH
  focus-toggle-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24706

AFFECTED FILES
  kstyle/breezehelper.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Nathaniel Graham]

ngraham added a comment.


  Before/after images or video?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This fixes a usability problem where it was hard to tell whether or not a 
focused and checkable button was checked because the focus color would always 
show unless another button took the focus.

REPOSITORY
  R31 Breeze

BRANCH
  focus-toggle-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24706

AFFECTED FILES
  kstyle/breezehelper.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24208: [Notifications] Dodge Plasma dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D24208#548315 , @meven wrote:
  
  > In D24208#548272 , @ngraham 
wrote:
  >
  > > In D24208#548153 , @broulik 
wrote:
  > >
  > > > Bluetooth could provide some better feedback inside the plasmoid.
  > >
  > >
  > > Agreed, notifications shouldn't be used when the app/window/UI/whatever 
is still open; feedback should be provided there instead.
  >
  >
  > I disagree plasmoid should avoid sending notifications.
  
  
  It's fine for plasmoids to send notifications. But when the system tray popup 
is open, a better location for the feedback is right there, where your eyeballs 
are currently looking. In principle, notifications are used for apps that you 
aren't actively using, to inform you of something happening that you might 
otherwise miss. If you're currently using the app, the app can show you the 
information directly, with no need to send a notification.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham, mart
Cc: meven, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting added a comment.


  In D24276#548330 , @mart wrote:
  
  > this only affects the old standalone executable, right?
  
  
  Um, I guess so. I didn't realize there was something else...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24276

To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma
Cc: mart, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/25/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 16 Oct 2019 16:47:00 +
 Build duration:
2 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 90 lines...][2019-10-16T16:48:55.940Z] Cloning the remote Git repository[2019-10-16T16:48:55.983Z] Cloning repository https://anongit.kde.org/kapidox[2019-10-16T16:48:55.984Z]  > git init /home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 SUSEQt5.12/ci-tooling/kapidox # timeout=10[2019-10-16T16:48:55.993Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2019-10-16T16:48:55.993Z]  > git --version # timeout=10[2019-10-16T16:48:55.995Z]  > git fetch --tags --force --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-16T16:48:57.976Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2019-10-16T16:48:57.979Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-16T16:48:58.076Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2019-10-16T16:48:58.162Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2019-10-16T16:48:58.163Z]  > git fetch --tags --force --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-16T16:48:59.107Z] Checking out Revision bae3cb345db28128f21551f844e4701d4ed4e744 (origin/master)[2019-10-16T16:48:59.298Z] Commit message: "GIT_SILENT Upgrade KF5 version to 5.64.0."[2019-10-16T16:48:59.064Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-10-16T16:48:59.151Z]  > git config core.sparsecheckout # timeout=10[2019-10-16T16:48:59.153Z]  > git checkout -f bae3cb345db28128f21551f844e4701d4ed4e744 # timeout=10[Pipeline] checkout[2019-10-16T16:48:59.974Z] No credentials specified[2019-10-16T16:49:00.057Z] Cloning the remote Git repository[2019-10-16T16:49:00.100Z] Cloning repository https://anongit.kde.org/kde-dev-scripts[2019-10-16T16:49:00.100Z]  > git init /home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 SUSEQt5.12/ci-tooling/kde-dev-scripts # timeout=10[2019-10-16T16:49:00.117Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-10-16T16:49:00.117Z]  > git --version # timeout=10[2019-10-16T16:49:00.120Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-16T16:49:03.498Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-16T16:49:03.501Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-16T16:49:03.608Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-16T16:49:03.694Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-10-16T16:49:03.694Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-16T16:49:04.654Z] Checking out Revision 7db3c74d0335682a78bbcb741325004b36a68a90 (origin/master)[2019-10-16T16:49:04.854Z] Commit message: "Merge remote-tracking branch 'origin/Applications/19.08'"[Pipeline] }[Pipeline] // stage[Pipeline] stage[2019-10-16T16:49:04.612Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-10-16T16:49:04.698Z]  > git config core.sparsecheckout # timeout=10[2019-10-16T16:49:04.699Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[Pipeline] { (Setup Dependencies)[Pipeline] sh[2019-10-16T16:49:09.041Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kscreen --branchGroup stable-kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-16T16:49:14.010Z] Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5[2019-10-16T16:49:15.058Z] Retrieving: Plasma-kcodecs-stable-kf5-qt5[2019-10-16T16:49:16.715Z] Retrieving: Plasma-karchive-stable-kf5-qt5[2019-10-16T16:49:18.369Z] Retrieving: Plasma-ki18n-stable-kf5-qt5[2019-10-16T16:49:20.706Z] Retrieving: Plasma-kcoreaddons-stable-kf5-qt5[2019-10-16T16:49:23.045Z] Retrieving: Plasma-polkit-qt-1-stable-kf5-qt5[2019-10-16T16:49:24.701Z] Retrieving: Plasma-kauth-stable-kf5-qt5[2019-10-16T16:49:26.354Z] Retrieving: Plasma-kconfig-stable-kf5-qt5[2019-10-16T16:49:41.770Z] Retrieving: Plasma-kdoctools-stable-kf5-qt5[2019-10-16T16:49:41.770Z] Traceback (most recent call last):[2019-10-16T16:49:41.770Z]   File "/usr/lib64/python3.7/urllib/request.py", line 1317, in do_open[2019-10-16T16:49:41.770Z] encode_chunked=req.has_header('Transfer-encoding'))[2019-10-16T16:49:41.770Z]   File "/usr/lib64/python3.7/http/client.py", line 1241, in request[2019-10-16T16:49:41.770Z] self._send_request(method, url, body, headers, 

D24276: Add text to speech functionality to klipper.

[Marco Martin]

mart added a comment.


  this only affects the old standalone executable, right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24276

To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma
Cc: mart, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24208: [Notifications] Dodge Plasma dialogs

[Kai Uwe Broulik]

broulik added a comment.


  > Hidding the notification behind a popup is at best a workaround.
  
  It is.
  
  > What if you receive an email while changing your audio setup ?
  
  Then you close the popup and get the notification, I don't see an issue with 
that. It's not like you fiddle with System Tray for long periods of time, are 
you? The only reason I previously had to keep System Tray open was to monitor a 
copy progress but that is possible without doing that nowadays.
  
  > how long before we get bug reports ?
  
  Dunno. I got bug reports about notifications covering System Tray before 
that. You can never make people happy.
  
  > So I thought you would consider adding it somewhere on your infinite TODO 
list ^^
  
  I don't have any concrete plans. Maybe one day when I can be arsed to but 
moving the popups out of the way in a sensible fashion as a group is a lot 
harder than just hiding them individually.
  When your panel is on the left, where to move the notifications? What if 
there isn't enough room to move them out of the way? etc
  
  > In the end I am happy opening a notification bug, to let us deal with it it 
in due times.
  
  Sure.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham, mart
Cc: meven, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24704: [KCM] Show the same name in the replication model that's shown in the title

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ba20c56a724f: [KCM] Show the same name in the replication 
model thats shown in the title (authored by ngraham).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24704?vs=68064=68065

REVISION DETAIL
  https://phabricator.kde.org/D24704

AFFECTED FILES
  kcm/output_model.cpp

To: ngraham, romangg, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24208: [Notifications] Dodge Plasma dialogs

[Méven Car]

meven added a comment.


  In D24208#548272 , @ngraham wrote:
  
  > In D24208#548153 , @broulik 
wrote:
  >
  > > Bluetooth could provide some better feedback inside the plasmoid.
  >
  >
  > Agreed, notifications shouldn't be used when the app/window/UI/whatever is 
still open; feedback should be provided there instead.
  
  
  I disagree plasmoid should avoid sending notifications.
  Since very often their behavior is by nature asynchronous the result of an 
operation can happen after the popup is closed.
  And having two code path for plasmoid to notify the user depending or not 
whether they are displayed is not recommendable.
  Because it would complicate the implementation and would make user experience 
inconsistent.
  
  > 
  > 
  >> Pointless confirmation notifications in plasma-nm were the main reason for 
this patchset.
  > 
  > I think the same applies to plasma-nm. See also 
https://bugs.kde.org/show_bug.cgi?id=409774
  
  This is a separate issue : the plasmoid should mute itself in this case as 
the notification is the results of user interaction.
  Hidding the notification behind a popup is at best a workaround.
  
  The issue I report here is not limited to notification originating from tray 
popup plasmoid.
  What if you receive an email while changing your audio setup ?
  You miss the notification until you are done with your setup, that's adding 
more chances to miss the notification.
  More generally displaying a popup should not hide notification IMO (and 
notifications should rarely be hidden).
  
  So yes @broulik I would be happy to patch this but I am not a specialist and 
it would take me quite some effort.
  On the other end the feature has been recently added and should be refined 
IMO (I am trying to make this point): how long before we get bug reports ?
  So I thought you would consider adding it somewhere on your infinite TODO 
list ^^
  
  I am sorry I react only now but I saw this issue with this arising when the 
review was opened but did not react due to LIFE(tm)
  
  In the end I am happy opening a notification bug, to let us deal with it it 
in due times.
  This is probably more appropriate than discussing this here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham, mart
Cc: meven, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24704: [KCM] Show the same name in the replication model that's shown in the title

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  5.17 confirmed

REPOSITORY
  R104 KScreen

BRANCH
  replica-output-names (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24704

To: ngraham, romangg, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24704: [KCM] Show the same name in the replication model that's shown in the title

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: romangg, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch makes the name shown in the combobox match the name shown for each 
individual
  output. Now they match, so you can actually tell what output is being 
replicated.
  
  Targeting the 5.17 branch.

TEST PLAN
  Before: F7608190: Before.png 
  After: F7608191: After.png 

REPOSITORY
  R104 KScreen

BRANCH
  replica-output-names (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24704

AFFECTED FILES
  kcm/output_model.cpp

To: ngraham, romangg, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24224: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added a comment.


  In D24224#547897 , @tcanabrava 
wrote:
  
  > F7605185: kcm_access.png 
  
  
  Lists such as these always need frames and backgrounds, like how it looks in 
the Notifications KCM. Just copy that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24687: [KCM] Add output selector ComboBox

[Nathaniel Graham]

ngraham added a comment.


  This is a big improvement IMO. You can also remove the little dots at the 
bottom too. +1 for getting it into 17.1.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24687

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24666: Be explicit about X11 or Wayland for the dev session names

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:63dca8847085: Be explicit about X11 or Wayland for the 
dev session names (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24666?vs=67984=68061

REVISION DETAIL
  https://phabricator.kde.org/D24666

AFFECTED FILES
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24208: [Notifications] Dodge Plasma dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D24208#548153 , @broulik wrote:
  
  > Bluetooth could provide some better feedback inside the plasmoid.
  
  
  Agreed, notifications shouldn't be used when the app/window/UI/whatever is 
still open; feedback should be provided there instead.
  
  > Pointless confirmation notifications in plasma-nm were the main reason for 
this patchset.
  
  I think the same applies to plasma-nm. See also 
https://bugs.kde.org/show_bug.cgi?id=409774

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham, mart
Cc: meven, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24701: Notify about change after cursor config is saved

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Before that patch the cursor change signal was only transmitted after
  a configuration was applied on a fly. Because the cursor change is
  not applied on a fly on Wayland session yet, the signal is not emitted and
  therefore users of that signal are not notified about cursor change.
  
  Now the signal is emitted after the configuration save, so its users are
  notified.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  notify-cursor-change-wayland

REVISION DETAIL
  https://phabricator.kde.org/D24701

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24688: [KCM] Disallow dropping screen outside of reachable area

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in Screen.qml:83
> Suggestions?

IMO magic numbers are probably okay here, but 20 is pretty similar to GridUnit 
so maybe just use multiples of that instead?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

[Nathaniel Graham]

ngraham added a comment.


  I agree that it would probably make more sense to allow the system tray popup 
to be arbitrarily resized, and use a panel instead when you wand a vertical 
sidebar type of UI. The issues with using a panel to accomplish that are 
discussed in https://bugs.kde.org/show_bug.cgi?id=412483.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24567

To: filipf, #vdg, #plasma, mart
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham added a comment.


  I think this patch needs some changes (outlined above).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24668: Simplify kcms cmake file

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c72a1d5ce982: Simplify kcms cmake file (authored by 
bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24668?vs=67987=68056

REVISION DETAIL
  https://phabricator.kde.org/D24668

AFFECTED FILES
  kcms/CMakeLists.txt

To: bport, #plasma, ervin, mart, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24670: KCM fonts : Rearrange code

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:36d8d9e32351: KCM fonts : Rearrange code (authored by 
bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24670?vs=67989=68058

REVISION DETAIL
  https://phabricator.kde.org/D24670

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, ervin, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24669: Port fonts KCM to KConfigXT

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a4d23764ea46: Port fonts KCM to KConfigXT (authored by 
bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24669?vs=67988=68057#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24669?vs=67988=68057

REVISION DETAIL
  https://phabricator.kde.org/D24669

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontssettings.kcfg
  kcms/fonts/fontssettings.kcfgc
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24698: Leverage latest KConfig changes

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:05ec670029db: Leverage latest KConfig changes (authored 
by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24698?vs=68047=68054

REVISION DETAIL
  https://phabricator.kde.org/D24698

AFFECTED FILES
  kcms/desktoptheme/desktopthemesettings.kcfgc
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h

To: ervin, #plasma, mart, broulik, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24699: Disable the module if the setting is locked down

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:77cfc0dc78fd: Disable the module if the setting is locked 
down (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24699?vs=68048=68055

REVISION DETAIL
  https://phabricator.kde.org/D24699

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml

To: ervin, #plasma, mart, broulik, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D24634#548229 , @mart wrote:
  
  > In D24634#547077 , @ngraham 
wrote:
  >
  > > Oh, this is so nice!
  >
  >
  > can you test/qa some existing apps? (at least discover and kamoso ?)
  
  
  Will do!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Marco Martin]

mart added a comment.


  In D24634#547077 , @ngraham wrote:
  
  > Oh, this is so nice!
  
  
  can you test/qa some existing apps? (at least discover and kamoso ?)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Marco Martin]

mart added a comment.


  testing it i did find a major problem: if i resize the window quickly 
(kirigami gallery 2 columns mode) when it goes from icon+text to just icon, the 
window freezes for an instant, seems quite expensive, while before didn't do 
that

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Marco Martin]

mart added a comment.


  now has the order main action, left, right. before was left, main right.
  it does change a bit the behavior, tough i see the point of making sure that 
the main action is always the last being hidden (i wonder how it would be 
making it hide last even if not the last)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24373: [KCM] Limit scale factor increment to 6.25% on X11

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:2b23256b0a47: [KCM] Limit scale factor increment to 6.25% 
on X11 (authored by ngraham).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24373?vs=68051=68053

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 6.25% on X11

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Thank you Nate. master branch only.

REPOSITORY
  R104 KScreen

BRANCH
  0625-increment-on-x11

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 6.25% on X11

[Nathaniel Graham]

ngraham updated this revision to Diff 68051.
ngraham added a comment.


  Update message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24373?vs=68050=68051

BRANCH
  0625-increment-on-x11

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Nathaniel Graham]

ngraham updated this revision to Diff 68050.
ngraham added a comment.


  Rebase

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24373?vs=67226=68050

BRANCH
  0625-increment-on-x11

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Roman Gilg]

romangg added a comment.


  Actually I would like to expose the fact that we are doing that only on X11. 
People not knowing what this is can ignore it. Also it is a single factor, not 
multiple as with multi output DPI scaling on Wayland.
  
  How about:
  
The global scale factor is limited to multiples of 6.25% to minimize visual 
glitches in applications on the X11 windowing system.

REPOSITORY
  R104 KScreen

BRANCH
  0625-increment-on-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24370: [KCM] Display scale factor as a percentage, not a decimal

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:0f52663c7829: [KCM] Display scale factor as a percentage, 
not a decimal (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24370?vs=67215=68049#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24370?vs=67215=68049

REVISION DETAIL
  https://phabricator.kde.org/D24370

AFFECTED FILES
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: ndavis, dhaumann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24699: Disable the module if the setting is locked down

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Cool!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24699

To: ervin, #plasma, mart, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24699: Disable the module if the setting is locked down

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  In this case we simply disable the whole module since it manages only a
  single key really. We could go finer grained allowing to add/remove
  themes, but it'd be pointless really (and also removal has a side
  effect on the selected theme anyway).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24699

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml

To: ervin, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24698: Leverage latest KConfig changes

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  - Use the ctor with parent (no need to call setParent anymore)
  - Use isSaveNeeded on the settings object (thus m_currentTheme can go away 
and overall logic is simplified)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24698

AFFECTED FILES
  kcms/desktoptheme/desktopthemesettings.kcfgc
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h

To: ervin, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24324: [GTK2] Add program to libexec for GTK2 recoloration

[Nathaniel Graham]

ngraham added a comment.


  How about calling this new one "Breeze" and renaming the old one "Breeze 
(fixed colors)" or something like that?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24324

To: cblack, #breeze
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24677: Add `sudo` to the lines in install-sessions.sh that need it so you don't need to sudo the whole thing

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c12befa1c65b: Add `sudo` to the lines in 
install-sessions.sh that need it so you dont need… (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24677?vs=68000=68045

REVISION DETAIL
  https://phabricator.kde.org/D24677

AFFECTED FILES
  login-sessions/install-sessions.sh.cmake

To: ngraham, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D18299: ComboBox: fix default delegate

[Kai Uwe Broulik]

broulik added a comment.


  I checked Qt source code and Qt indeed should handle this on its own, it also 
works fine hwere without the code.
  Worse, the explicit assignment from QML breaks any binding set on 
`currentIndex`.
  In the handler that's called when the delegate model creates a delegate it 
does the following
  
void QQuickComboBoxPrivate::createdItem(int index, QObject *object)
{
...
QQuickAbstractButton *button = qobject_cast(object);
if (button) {
button->setFocusPolicy(Qt::NoFocus);
connect(button, ::clicked, this, 
::itemClicked);
connect(button, ::hoveredChanged, this, 
::itemHovered);
}
  
  `ItemDelegate` is an `AbstractButton` and in `itemClicked` it sets the 
`currentIndex` and emits `activated`.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18299

To: apol, #frameworks, davidedmundson
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24208: [Notifications] Dodge Plasma dialogs

[Kai Uwe Broulik]

broulik added a comment.


  Bluetooth could provide some better feedback inside the plasmoid.
  Pointless confirmation notifications in plasma-nm were the main reason for 
this patchset.
  Sliding could be done but is a lot more complicated than this patchset since 
the dialogs are individual, patches welcome...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham, mart
Cc: meven, mart, ngraham, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D23578: Before requesting a scan, check the time threshold

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> meven wrote in main.qml:77
> I removed this because
> 
> 1:
> Request scan failure should never happen anymore because the handler makes 
> sure never to call requestScan too often.
> The timer can just constantly ask for request scans it does not impact the 
> "real" requestScan sent.
> 
> 2:
> Now the scans are per interface, meaning we check the interface states by 
> interface and they could have different state.
> It does not match well with this timer : if an interface fails, should we 
> stop to scan the others ? I believe not.
> A solution would be to have timer by interface, but we already have this in 
> the handler anyway so it seems overkill to do it here.

@jgrulich Any feedback ?
You approved this a while back but we still have this point to deal with.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D23578

REVISION DETAIL
  https://phabricator.kde.org/D23578

To: meven, #plasma, jgrulich
Cc: plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D24687: [KCM] Add output selector ComboBox

[Kai Uwe Broulik]

broulik added a comment.


  > I thought about showing some mini-symbols for disabled outputs on one of 
the sides of the overview at a fixed position.
  
  What do you need a proxy model for that? The outputs are part of the model, 
just `visible: model.enabled`. You could just have the delegate look 
differently and be positioned somewhere else and non-draggable when it is 
disabled?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24687

To: broulik, #plasma, #vdg, romangg
Cc: mart, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra