Re: 2 kirigami fixes for a point release

[Friedrich W. H. Kossebau]

Am Dienstag, 18. Februar 2020, 04:03:05 CET schrieb Nate Graham:
> On 2020-02-16 14:43, Albert Astals Cid wrote:
> > Maybe i explain myself wrongly, i'm not blaming distros at all.
> > 
> > They made a decision, we/I may agree with them or not, that's *my/our*
> > problem, what I was disagreeing is to us having to do extra work because
> > someone elses (the distros) decision.
> We already do this: it's called the Plasma LTS product. :-) It's been
> specifically created to cater to various distros' desires for an
> extended-support product they can ship to users of their own LTS releases.
> 
> However all the autotests in the world will not resolve the fundamental
> incompatibility between the Plasma LTS product, which is built around
> the release model of extended, ongoing bugfix releases, and Frameworks,
> which is built around a rolling release model with no bugfix releases at
> all.

For one, distribution seem to be just fine with that. And it should be them to 
complain if they cannot make use of Plasma LTS to create a product endorsed by 
their distribution/operating system flavour users. Why would the package and 
use Plasma otherwise, if not to create a usable product.
They simply create their own KF LTS, by backporting patches which they define  
important enough to the version of KF they use. Like they do for all the other 
software where they pinpointed to a certain version and where upstream does 
not do a matching LTS, starting with the Linux kernel.

And as said before, the Plasma team could just maintain some LTS version of KF 
next to the normal master release branch and the normal releases. That branch 
could then even be synced with the release schedule pf Plasma LTS, incl. the 
lifespan,

Is there a list of Plasma LTS usages in distributions which are horrible 
because of important fixes to KF not being backported? Or is this more a 
theoretical problem you are afraid of seeing the current quality hick-up?

Cheers
Friedrich

How to close PMC?

[Peter Lorenz]

Hi all,


I' wondering: How do I close the PMC? I can't find anything to do this.

I am running PMC on a laptop with arch linux.
And have always the newest builds installed.

It seems, all I can do is restart the computer.

Can somebody help with this?

Thanks in advance!

Peter Lorenz

Re: 2 kirigami fixes for a point release

[Friedrich W. H. Kossebau]

Sorry, no time to rewrite to make this short.

Am Mittwoch, 12. Februar 2020, 21:59:32 CET schrieb Nate Graham:
> [+ frameworks and plasma mailing lists]
> 
> On 2020-02-12 11:31, Albert Astals Cid wrote:
> > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va 
escriure:
> >> On another note, I have to admit I'm starting to doubt how well our LTS
> >> Plasma product works without a corresponding LTS frameworks release to
> >> support it. We can fix bugs in software that uses the Plasma release
> >> schedule till the cows come home, but if the bug is in Frameworks, users
> >> are stuck with it forever since LTS distros don't typically ship new
> >> Frameworks releases.

Yes, this has been questioned a few times. Also seeing Plasma LTS used 
together with a non-LTS Qt is a bit strange.
But somehow it seems there has not been enough pain for those using the Plasma 
LTS to change something. Possibly because distributions simply backport 
important bug fixes for KF themselves, kind of maintaining their own KF LTS 
version of the KF version they pinpointed to when they froze the ingredients 
to their OS. Because they are used to do this for other projects as well, and 
so miss this could be done in cooperation with upstream.

IMHO distributions using Plasma LTS, Plasma team & other stakeholders should 
team up here and maintain a matching LTS branch of Frameworks together at the 
central KDE repos together. Well, and a version also satisfying other clients 
of KF, like non-workspace applications from KDE.

It's not a reason to change normal KF release cycle.

BTW, we release our software in variants of GPL. We give distributions lots of 
rights by that license to do with the source code what they like, not what 
pleases us as authors. So we want to do cooperation here, not get into any 
form of commandeering them, as it starts sounding elsewhere in this thread.

If unsatisfied with the quality, make Plasma a trademark and hand it out only 
to distributions which are complying with the standards the Plasma team is 
fine with ;) 
Oh, look, an iceweasel is running over there... ;)

> >> Yes yes, they should, and all that--but they don't.
> >> 
> >> It seems like we either need to:
> >> - Work on convincing these distros to ship Frameworks versions in a
> >> rolling manner to their LTS users
> >> - Provide an LTS Frameworks product that can receive bugfixes and get
> >> point releases, to support the Plasma LTS product
> >> - Stop misleadingly offering a Plasma LTS product, since everything in
> >> it that comes from Frameworks isn't actually LTS
> > 
> > This should not matter, Plasma LTS is built on *lots* of other libraries
> > that are not LTS either.
> > 
> > If it matters is because the quality of KF5 releases are not good, that's
> > what should be fixed IMHO.
> Yes, the Frameworks 5.67 release was indeed was quite buggy and
> regression-filled from a Plasma perspective :(
> 
> However buggy releases are the proximate cause, not the root cause. We
> have to ask: what causes buggy releases?
> 
> I would argue that bugginess is baked into the Frameworks product by
> virtue of its very fast one-month release cycle and lack of beta
> periods, as there are for apps and Plasma. No matter how diligent patch
> review is, regressions always sneak in; that's why QA and beta-testing
> exist.

This assumes the master branch of KF modules serves the purpose of beta 
testing. My understanding is: it does not. And could not be, for the very 
reason you gave, too little time and too few testers.

The master branch's purpose is mainly to collect all changes for the next 
release, and serve as reference when merging dependent changes across multiple 
repos for CI. It should be in the state of "always releaseable".

Which also means patches going in should have seen a beta period by the people 
doing the patches _before_ merging them, and be well understood in their 
potential side-effects. Yes, this also means that for cross-repo/products 
developer should have first done some testing for some time with locally 
patched variants of all affected repos, if unsure about their changes (say, 
removing an unused variable is well understood in effect scope and does not 
need lots of testingi).
But by default crowd-sourcing the QA to fellow developers also working against 
current master and wanting to test-drive their own changes is not the way to 
go. For one they do not know they should test certain things and thus might 
not even get close to things, thus not do any testing, or it will conflict 
with their own work, when they cannot be sure it was their own change or 
someone else's which breaks things, wasting efforts in finding causes.

Needing longer beta test phases also hints that some product is not well 
understood or designed, and things fall apart easily. That needs fixing of the 
product itself, to become reliably maintainable and expandable.

Looking at the reasoning for the recent requests for KF tarb

D27457: Move kcminit_startup and kded to plasma-session

[Fabian Vogt]

fvogt reopened this revision.
fvogt added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> startup.cpp:211
> +const QVector sequence = {
> +new StartProcessJob(QStringLiteral("kcminit_startup"), {}),
> +new StartServiceJob(QStringLiteral("kded5"), {}, 
> QStringLiteral("org.kde.kded"), QProcess::systemEnvironment() << QStringList{ 
> QStringLiteral("KDED_STARTED_BY_KDEINIT=1") }),

This (and below) are started with an empty environment, which means that 
neither `DISPLAY`, `WAYLAND_DISPLAY` or `XAUTHORITY` are set. So everything 
breaks horribly, as seen by @lbeltrame and openQA.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> fvogt wrote in startup.cpp:211
> This (and below) are started with an empty environment, which means that 
> neither `DISPLAY`, `WAYLAND_DISPLAY` or `XAUTHORITY` are set. So everything 
> breaks horribly, as seen by @lbeltrame and openQA.

StartProcessJob I think is fine. It's not set, so it'll inherit.

It's the extra arg to StartServiceJob that has potential to wipe the env.

It defaults to empty

and we do p->setEnvironment(m_env);

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> davidedmundson wrote in startup.cpp:211
> StartProcessJob I think is fine. It's not set, so it'll inherit.
> 
> It's the extra arg to StartServiceJob that has potential to wipe the env.
> 
> It defaults to empty
> 
> and we do p->setEnvironment(m_env);

> StartProcessJob I think is fine. It's not set, so it'll inherit.

It is set in line 440, which defaults to empty (line 90 in the header) as well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75890.
bport added a comment.


  fix build. KRDB can't use Kxftconfig directly so we can't avoid stuff in 
kdeglobals

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75844&id=75890

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Méven Car]

meven updated this revision to Diff 75891.
meven marked an inline comment as done.
meven added a comment.


  Remove m_settings AutomounterSettings member from DeviceAutomounterKCM

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27127?vs=75845&id=75891

BRANCH
  arcpatch-D27127

REVISION DETAIL
  https://phabricator.kde.org/D27127

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.h
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> bport wrote in DeviceAutomounterKCM.cpp:84
> We can also change kcfgc to add parent in constructor

It would imply make AutomounterSettings not-static.
I would need to change the DeviceModel that uses AutomounterSettings static 
functions as well.

> ervin wrote in DeviceAutomounterKCM.cpp:57
> Missing this as parent, this is leaked. Also I'd likely move that in the ctor 
> initialization list (same thing for m_devices actually, maybe in another 
> patch, your call).

I removed the m_settings instead, relying solely on the singleton.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, broulik, ervin, meven, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: bport, #plasma, broulik, ervin, meven, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  This looks like a good kcms to convert to KConfigXT...

INLINE COMMENTS

> krdb.cpp:756
> +  QString theme = mousecfg.readEntry("cursorTheme", 
> QString("breeze_cursors"));
> +  QString size  = mousecfg.readEntry("cursorSize", QString("0"));
>QString contents;

0 is unintuitive, it is for "default"/autodetermined I guess.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

To: bport, #plasma, broulik, ervin, meven, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27467: make sure ifa_addr isn't null

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:8cb749531a3c: make sure ifa_addr isn't null 
(authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27467?vs=75865&id=75896

REVISION DETAIL
  https://phabricator.kde.org/D27467

AFFECTED FILES
  Modules/nics/nic.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

[Will Stephenson]

wstephenson updated this revision to Diff 75898.
wstephenson added a comment.


  Removed debug statement;
  Added changed qml file to diff.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27353?vs=75562&id=75898

REVISION DETAIL
  https://phabricator.kde.org/D27353

AFFECTED FILES
  desktoppackage/contents/activitymanager/ActivityItem.qml
  imports/activitymanager/CMakeLists.txt
  imports/activitymanager/switcherbackend.cpp
  imports/activitymanager/switcherbackend.h

To: wstephenson, #plasma, ivan, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[David Redondo]

davidre added a comment.


  In D27470#613348 , @meven wrote:
  
  > This looks like a good kcms to convert to KConfigXT...
  
  
  This isn't even a kcm :D
  See Kai's mail to plasma-devel
  https://mail.kde.org/pipermail/plasma-devel/2020-February/110655.html

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

To: bport, #plasma, broulik, ervin, meven, crossi
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[George Vogiatzis]

gvgeo updated this revision to Diff 75899.
gvgeo added a comment.


  Rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27420?vs=75817&id=75899

BRANCH
  FreeThePort3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounterKCM.cpp:57
> I removed the m_settings instead, relying solely on the singleton.

I tend to consider this as a step back to be honest. Singletons tend to be more 
trouble down the line when something goes wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ervin wrote in DeviceAutomounterKCM.cpp:57
> I tend to consider this as a step back to be honest. Singletons tend to be 
> more trouble down the line when something goes wrong.

Please beware this will make my patch quite a lot more intrusive, DeviceModel 
for instance, will need a field to keep some reference to the 
AutomounterSettings

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Benjamin Port]

bport added a comment.


  This is not a KCM, and because of how stuff works with KRDB we can't reuse 
kcfg easily there (because build by 5 or 6 kcm)
  About the 0 as default value, perhaps we can change that but it's totally 
unrelated to this patch, goal there is only to honor default value as set by 
kcfg

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

To: bport, #plasma, broulik, ervin, meven, crossi
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27367: fix activity runner

[Oleg Solovyov]

McPain updated this revision to Diff 75900.
McPain marked an inline comment as done.
McPain added a comment.


  removed 2nd hunk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27367?vs=75605&id=75900

REVISION DETAIL
  https://phabricator.kde.org/D27367

AFFECTED FILES
  runners/activities/activityrunner.cpp

To: McPain, broulik, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounterKCM.cpp:57
> Please beware this will make my patch quite a lot more intrusive, DeviceModel 
> for instance, will need a field to keep some reference to the 
> AutomounterSettings

Sure, moving away from a singleton is always intrusive (just like moving away 
from a global variable which it is really). Let's aim for it in a different 
specific patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[David Edmundson]

davidedmundson updated this revision to Diff 75901.
davidedmundson added a comment.


  Fix process env
  Correctly wait for kcminit phase 0 to finish

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27457?vs=75834&id=75901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27471: [plasma-session] Avoid potential race condition starting a service

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If for some reason a service is started before StartServiceJob runs, we
  will end up blocking forever.

TEST PLAN
  Logged in

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27471

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27471: [plasma-session] Avoid potential race condition starting a service

[David Edmundson]

davidedmundson added a comment.


  I think for 5.18

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27471

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Fabian Vogt]

fvogt added a comment.


  As there's no reason to clear the environment, wouldn't it be more useful if 
`StartServiceJob` would only allow adding/overwriting variables?
  `StartProcessJob` does not need an option to set the environment at all 
AFAICT.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27472: [plasma-session] Cleanup StartServiceJob

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Mostly just a code cleanup, also uses the correct version of
  startDetached

TEST PLAN
  Logged out/ logged in

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27472

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[David Edmundson]

davidedmundson added a comment.


  > As there's no reason to clear the environment, wouldn't it be more useful 
if StartServiceJob would only allow adding/overwriting variables?
  
  Possibly. My logic was that I didn't want to lose the possibility to unset 
something.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75906.
gvgeo edited the test plan for this revision.
gvgeo added a dependency: D27392: [Applet]Add info messages..
gvgeo added a comment.


  TODO from the last update.
  Improved comments.
  Removed fill anchor from listview.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75831&id=75906

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  1 picture, 1 problem, 2 issues.
  F8110442: Screenshot_20200218_124006.png 

  I understand why margins exist. But this, is wrong.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  The worst problem I could found, by ignoring the margins.
  Theme "Underworld".
  F8110467: Screenshot_20200218_134914.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27472: [plasma-session] Cleanup StartServiceJob

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> startup.cpp:438
> -
> -connect(p, &QProcess::errorOccurred, this, [this] 
> (QProcess::ProcessError error) {
> -qCWarning(PLASMA_SESSION) << "error on process" << error << 
> m_process << m_args;

Are you sure showing an error message on error is not useful anymore?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27472

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27472: [plasma-session] Cleanup StartServiceJob

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in startup.cpp:438
> Are you sure showing an error message on error is not useful anymore?

we have one on the  startDetached retun value.

once we double fork and detach I didn't think we would get any other warnings.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27472

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/58/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 18 Feb 2020 12:38:32 +
 Build duration:
1 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-02-18T12:39:59.631Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-18T12:39:59.631Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-02-18T12:39:59.631Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/58/display/redirect'[2020-02-18T12:39:59.631Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-18T12:39:59.631Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-18T12:39:59.631Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-18T12:39:59.631Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-18T12:39:59.631Z] NODE_NAME = 'Docker Swarm-56bcb8013cc5'[2020-02-18T12:39:59.631Z] HOST  = '56bcb8013cc5'[2020-02-18T12:39:59.631Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-18T12:39:59.631Z] USER  = 'jenkins'[2020-02-18T12:39:59.631Z] MORE  = '-sl'[2020-02-18T12:39:59.631Z] CSHEDIT   = 'emacs'[2020-02-18T12:39:59.631Z] SHLVL = '2'[2020-02-18T12:39:59.631Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-58'[2020-02-18T12:39:59.631Z] WINDOWMANAGER = 'xterm'[2020-02-18T12:39:59.631Z] PAGER = 'less'[2020-02-18T12:39:59.631Z] EXECUTOR_NUMBER   = '0'[2020-02-18T12:39:59.631Z] CVS_RSH   = 'ssh'[2020-02-18T12:39:59.631Z] LIBGL_DEBUG   = 'quiet'[2020-02-18T12:39:59.631Z] STAGE_NAME= 'Configuring Build'[2020-02-18T12:39:59.631Z] NODE_LABELS   = 'Docker Swarm-56bcb8013cc5 SUSEQt5.12'[2020-02-18T12:39:59.631Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-18T12:39:59.631Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-18T12:39:59.631Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-18T12:39:59.631Z] PROFILEREAD   = 'true'[2020-02-18T12:39:59.631Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-18T12:39:59.631Z] HOSTTYPE  = 'x86_64'[2020-02-18T12:39:59.631Z] BUILD_ID  = '58'[2020-02-18T12:39:59.631Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-18T12:39:59.631Z] OLDPWD= '/home/jenkins'[2020-02-18T12:39:59.631Z] LC_CTYPE  = 'C.UTF-8'[2020-02-18T12:39:59.631Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-18T12:39:59.631Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-18T12:39:59.631Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-18T12:39:59.631Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-18T12:39:59.631Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-18T12:39:59.631Z] QT_SELECT = 'qt5'[2020-02-18T12:39:59.631Z] LANG  = 'en_US.UTF-8'[2020-02-18T12:39:59.631Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-18T12:39:59.631Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-18T12:39:59.631Z] [2020-02-18T12:39:59.631Z] [2020-02-18T12:39:59.631Z] == Commencing Configuration:[2020-02-18T12:39:59.631Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-02-18T12:39:59.631Z] -- The C compiler identification is GNU 9.2.1[2020-02-18T12:39:59.887Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-18T12:39:59.887Z] -- Check for working C compiler: /usr/bin/cc[2020-02-18T12:39:59.887Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-18T12:39:59.887Z] -- Detecting C compiler ABI info[2020-02-18T12:39:59.887Z] -- Detecting C compiler ABI info - done[2020-02-18T12:39:59.887Z] -- Detecting C compile features[2020-02-18T12:39:59.887Z] -- Detecting C compile features - done[2020-02-18T12:39:59.887Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-18T12:39:59.887Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-18T12:39:59.887Z] -- Det

D27471: [plasma-session] Avoid potential race condition starting a service

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:854b64fc130b: [plasma-session] Avoid hypothetical race 
condition starting a service (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27471?vs=75902&id=75907#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27471?vs=75902&id=75907

REVISION DETAIL
  https://phabricator.kde.org/D27471

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: davidedmundson, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/4/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 18 Feb 2020 12:38:22 +
 Build duration:
3 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 399 lines...][2020-02-18T12:41:15.125Z] [16/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest.cpp.obj[2020-02-18T12:41:16.525Z] [17/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.cpp.obj[2020-02-18T12:41:17.402Z] [18/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\attachmentclient.cpp.obj[2020-02-18T12:41:17.402Z] [19/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugsearch.cpp.obj[2020-02-18T12:41:17.402Z] [20/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj[2020-02-18T12:41:17.402Z] [21/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugclient.cpp.obj[2020-02-18T12:41:17.402Z] [22/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commentclient.cpp.obj[2020-02-18T12:41:17.402Z] [23/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugupdate.cpp.obj[2020-02-18T12:41:17.677Z] [24/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\exceptions.cpp.obj[2020-02-18T12:41:17.677Z] [25/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\clientbase.cpp.obj[2020-02-18T12:41:17.677Z] [26/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugfieldclient.cpp.obj[2020-02-18T12:41:17.677Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\jsoncommand.cpp.obj[2020-02-18T12:41:17.950Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\productclient.cpp.obj[2020-02-18T12:41:18.892Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newattachment.cpp.obj[2020-02-18T12:41:19.299Z] [30/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-02-18T12:41:19.557Z] [31/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-02-18T12:41:19.557Z] [32/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\comment.cpp.obj[2020-02-18T12:41:19.557Z] [33/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\querycommand.cpp.obj[2020-02-18T12:41:19.557Z] [34/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\logindetails.cpp.obj[2020-02-18T12:41:19.820Z] [35/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-02-18T12:41:20.146Z] [36/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-02-18T12:41:20.406Z] [37/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla_debug.cpp.obj[2020-02-18T12:41:20.674Z] [38/149] Automatic MOC for target gdbbacktracelinetest[2020-02-18T12:41:20.956Z] [39/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\product.cpp.obj[2020-02-18T12:41:20.956Z] [40/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\qbugzilla_autogen\mocs_compilation.cpp.obj[2020-02-18T12:41:20.956Z] [41/149] Building CXX object src\tests\CMakeFiles\gdbbacktracelinetest.dir\gdbbacktracelinetest_autogen\mocs_compilation.cpp.obj[2020-02-18T12:41:21.228Z] [42/149] Linking CXX static library lib\qbugzilla.lib[2020-02-18T12:41:21.497Z] [43/149] Automatic MOC for target backtraceparsertest[2020-02-18T12:41:21.497Z] [44/149] Linking CXX executable bin\crashtest.exe[2020-02-18T12:41:21.768Z] [45/149] Automatic MOC for target backtraceparsertest_manual[2020-02-18T12:41:21.768Z] [46/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\callbacks.cpp.obj[2020-02-18T12:41:22.383Z] [47/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj[2020-02-18T12:41:22.383Z] [48/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\__\drkonqi_debug.cpp.obj[2020-02-18T12:41:22.646Z] [49/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\abstract_generator.cpp.obj[2020-02-18T12:41:23.661Z] [50/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\msvc_generator.cpp.obj[2020-02-18T12:41:23.925Z] [51/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_autogen\mocs_compilation.cpp.obj[2020-02-18T12:41:23.925Z] [52/149] Buildin

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 35 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/35/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 18 Feb 2020 12:38:29 +
 Build duration:
4 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 198 lines...][2020-02-18T12:42:23.414Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-02-18T12:42:23.414Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2020-02-18T12:42:23.414Z] EDITOR= 'vi'[2020-02-18T12:42:23.414Z] ENV   = '/home/jenkins/.shrc'[2020-02-18T12:42:23.414Z] HUDSON_HOME   = '/home/production/data'[2020-02-18T12:42:23.414Z] BUILD_ID  = '35'[2020-02-18T12:42:23.414Z] OLDPWD= '/usr/home/jenkins'[2020-02-18T12:42:23.414Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-18T12:42:23.414Z] _ = '/usr/local/bin/java'[2020-02-18T12:42:23.414Z] TERM  = 'su'[2020-02-18T12:42:23.414Z] NODE_LABELS   = 'FreeBSD Builder Iota FreeBSDQt5.13'[2020-02-18T12:42:23.414Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-35'[2020-02-18T12:42:23.414Z] BUILD_DISPLAY_NAME= '#35'[2020-02-18T12:42:23.415Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/35/display/redirect'[2020-02-18T12:42:23.415Z] USER  = 'jenkins'[2020-02-18T12:42:23.415Z] HOME  = '/home/jenkins'[2020-02-18T12:42:23.415Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/35/'[2020-02-18T12:42:23.415Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-02-18T12:42:23.415Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-18T12:42:23.415Z] SHELL = '/bin/sh'[2020-02-18T12:42:23.415Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-18T12:42:23.415Z] STAGE_NAME= 'Configuring Build'[2020-02-18T12:42:23.415Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-02-18T12:42:23.415Z] BLOCKSIZE = 'K'[2020-02-18T12:42:23.415Z] EXECUTOR_NUMBER   = '0'[2020-02-18T12:42:23.415Z] SHLVL = '0'[2020-02-18T12:42:23.415Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-18T12:42:23.415Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-18T12:42:23.415Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-18T12:42:23.415Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-18T12:42:23.415Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-18T12:42:23.415Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-18T12:42:23.415Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-18T12:42:23.415Z] QT_SELECT = 'qt5'[2020-02-18T12:42:23.415Z] LANG  = 'en_US.UTF-8'[2020-02-18T12:42:23.415Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-18T12:42:23.415Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-18T12:42:23.415Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-18T12:42:23.415Z] [2020-02-18T12:42:23.415Z] [2020-02-18T12:42:23.415Z] == Commencing Configuration:[2020-02-18T12:42:23.415Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-18T12:42:23.674Z] -- The C compiler identification is Clang 8.0.1[2020-02-18T12:42:23.931Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-18T12:42:23.931Z] -- Check for working C compiler: /usr/bin/cc[2020-02-18T12:42:24.192Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-18T12:42:24.192Z] -- Detecting C compiler ABI info[2020-02-18T12:42:24.526Z] -- Detecting C compiler ABI info - done[2020-02-18T12:42:24.526Z] -- Detecting C compile features[2020-02-18T12:42:24.526Z] -- Detecting C compile features - done[2020-02-18T12:42:24.526Z] -- Check for working CXX compiler: /usr/bin/c++[2020

D27471: [plasma-session] Avoid potential race condition starting a service

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> startup.cpp:429
>  {
> +if 
> (QDBusConnection::sessionBus().interface()->isServiceRegistered(m_serviceId)) 
> {
> +qCDebug(PLASMA_SESSION) << m_process << "already running";

Could probably use an `m_service.isEmpty()` check since it will still 
needlessly do a `NameHasOwner` call

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27471

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27471: [plasma-session] Avoid potential race condition starting a service

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in startup.cpp:429
> Could probably use an `m_service.isEmpty()` check since it will still 
> needlessly do a `NameHasOwner` call

All usages of this class (which is just the 1 case to start ksmserver!) have a 
name passed.

Without a name it wouldn't ever finish.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27471

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 264 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/264/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 18 Feb 2020 12:41:21 +
 Build duration:
8 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 276 lines...][2020-02-18T12:50:06.055Z] WINDOWMANAGER = 'xterm'[2020-02-18T12:50:06.055Z] PAGER = 'less'[2020-02-18T12:50:06.055Z] EXECUTOR_NUMBER   = '0'[2020-02-18T12:50:06.055Z] CVS_RSH   = 'ssh'[2020-02-18T12:50:06.055Z] LIBGL_DEBUG   = 'quiet'[2020-02-18T12:50:06.055Z] STAGE_NAME= 'Configuring Build'[2020-02-18T12:50:06.055Z] NODE_LABELS   = 'Docker Swarm-d1e497ceac68 SUSEQt5.12'[2020-02-18T12:50:06.055Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-18T12:50:06.055Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-18T12:50:06.055Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-18T12:50:06.055Z] PROFILEREAD   = 'true'[2020-02-18T12:50:06.055Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-18T12:50:06.055Z] HOSTTYPE  = 'x86_64'[2020-02-18T12:50:06.055Z] BUILD_ID  = '264'[2020-02-18T12:50:06.055Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-18T12:50:06.055Z] OLDPWD= '/home/jenkins'[2020-02-18T12:50:06.055Z] LC_CTYPE  = 'C.UTF-8'[2020-02-18T12:50:06.055Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-18T12:50:06.055Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-18T12:50:06.055Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-18T12:50:06.055Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-18T12:50:06.055Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-18T12:50:06.055Z] QT_SELECT = 'qt5'[2020-02-18T12:50:06.055Z] LANG  = 'en_US.UTF-8'[2020-02-18T12:50:06.055Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-18T12:50:06.055Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-18T12:50:06.055Z] [2020-02-18T12:50:06.055Z] [2020-02-18T12:50:06.055Z] == Commencing Configuration:[2020-02-18T12:50:06.055Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12"[2020-02-18T12:50:06.313Z] -- The C compiler identification is GNU 9.2.1[2020-02-18T12:50:06.313Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-18T12:50:06.313Z] -- Check for working C compiler: /usr/bin/cc[2020-02-18T12:50:06.574Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-18T12:50:06.574Z] -- Detecting C compiler ABI info[2020-02-18T12:50:06.574Z] -- Detecting C compiler ABI info - done[2020-02-18T12:50:06.574Z] -- Detecting C compile features[2020-02-18T12:50:06.574Z] -- Detecting C compile features - done[2020-02-18T12:50:06.574Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-18T12:50:06.832Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-18T12:50:06.832Z] -- Detecting CXX compiler ABI info[2020-02-18T12:50:06.832Z] -- Detecting CXX compiler ABI info - done[2020-02-18T12:50:06.832Z] -- Detecting CXX compile features[2020-02-18T12:50:06.832Z] -- Detecting CXX compile features - done[2020-02-18T12:50:06.832Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-02-18T12:50:06.832Z] -- Looking for __GLIBC__[2020-02-18T12:50:07.086Z] -- Looking for __GLIBC__ - found[2020-02-18T12:50:07.086Z] -- Performing Test _OFFT_IS_64BIT[2020-02-18T12:50:07.086Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-18T12:50:07.086Z] -- Performing Test HAVE_DATE_TIME[2020-02-18T12:50:07.342Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-18T12:50:07.342Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.68.0") [2020-02-18T12:50:07.342Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-02-18T12:50:07.342Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for pla

D27472: [plasma-session] Cleanup StartServiceJob

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Turns out this is fixing up something that changed in the non-merged patch.
  
  I may as well squash it there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27472

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[David Edmundson]

davidedmundson updated this revision to Diff 75908.
davidedmundson added a comment.


  rebase and squash changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27457?vs=75901&id=75908

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 52 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/52/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 18 Feb 2020 12:43:33 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2020-02-18T12:57:50.709Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/52/display/redirect'[2020-02-18T12:57:50.709Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-18T12:57:50.709Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2020-02-18T12:57:50.709Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-18T12:57:50.709Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-18T12:57:50.709Z] NODE_NAME = 'Docker Swarm-eeb95c299469'[2020-02-18T12:57:50.709Z] HOST  = 'eeb95c299469'[2020-02-18T12:57:50.709Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-18T12:57:50.709Z] USER  = 'jenkins'[2020-02-18T12:57:50.709Z] MORE  = '-sl'[2020-02-18T12:57:50.709Z] CSHEDIT   = 'emacs'[2020-02-18T12:57:50.709Z] SHLVL = '2'[2020-02-18T12:57:50.709Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-52'[2020-02-18T12:57:50.709Z] WINDOWMANAGER = 'xterm'[2020-02-18T12:57:50.709Z] PAGER = 'less'[2020-02-18T12:57:50.709Z] EXECUTOR_NUMBER   = '0'[2020-02-18T12:57:50.709Z] CVS_RSH   = 'ssh'[2020-02-18T12:57:50.709Z] LIBGL_DEBUG   = 'quiet'[2020-02-18T12:57:50.709Z] STAGE_NAME= 'Configuring Build'[2020-02-18T12:57:50.709Z] NODE_LABELS   = 'Docker Swarm-eeb95c299469 SUSEQt5.12'[2020-02-18T12:57:50.709Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-18T12:57:50.709Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-18T12:57:50.709Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-18T12:57:50.709Z] PROFILEREAD   = 'true'[2020-02-18T12:57:50.709Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-18T12:57:50.709Z] HOSTTYPE  = 'x86_64'[2020-02-18T12:57:50.709Z] BUILD_ID  = '52'[2020-02-18T12:57:50.709Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-18T12:57:50.709Z] OLDPWD= '/home/jenkins'[2020-02-18T12:57:50.709Z] LC_CTYPE  = 'C.UTF-8'[2020-02-18T12:57:50.709Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-18T12:57:50.709Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-18T12:57:50.709Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-18T12:57:50.709Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-18T12:57:50.709Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-18T12:57:50.709Z] QT_SELECT = 'qt5'[2020-02-18T12:57:50.709Z] LANG  = 'en_US.UTF-8'[2020-02-18T12:57:50.709Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-18T12:57:50.709Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-18T12:57:50.709Z] [2020-02-18T12:57:50.709Z] [2020-02-18T12:57:50.709Z] == Commencing Configuration:[2020-02-18T12:57:50.709Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2020-02-18T12:57:51.728Z] -- The C compiler identification is GNU 9.2.1[2020-02-18T12:57:51.728Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-18T12:57:51.728Z] -- Check for working C compiler: /usr/bin/cc[2020-02-18T12:57:51.986Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-18T12:57:51.986Z] -- Detecting C compiler ABI info[2020-02-18T12:57:51.986Z] -- Detecting C compiler ABI info - done[2020-02-18T12:57:51.986Z] -- Detecting C compile features[2020-02-18T12:57:51.986Z] -- Detecting C compile features - done[2020-02-18T12:57:51.986Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-18T12:57:51.986Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-18T12:57:51.986Z] -- Detecting CXX compiler ABI info[2020-02-18T12:57:51.986Z] -- Detecting CXX compiler ABI info - done[2020-02-18T12:57:51.986Z] -- Detecting CXX compile features[2020-02-18T12:57:51.986Z] -- D

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 99 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/99/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 18 Feb 2020 12:43:47 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 267 lines...][2020-02-18T12:58:45.426Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-18T12:58:45.426Z] USER  = 'jenkins'[2020-02-18T12:58:45.426Z] MORE  = '-sl'[2020-02-18T12:58:45.426Z] CSHEDIT   = 'emacs'[2020-02-18T12:58:45.426Z] SHLVL = '2'[2020-02-18T12:58:45.426Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 SUSEQt5.12-99'[2020-02-18T12:58:45.426Z] WINDOWMANAGER = 'xterm'[2020-02-18T12:58:45.426Z] PAGER = 'less'[2020-02-18T12:58:45.426Z] EXECUTOR_NUMBER   = '0'[2020-02-18T12:58:45.426Z] CVS_RSH   = 'ssh'[2020-02-18T12:58:45.426Z] LIBGL_DEBUG   = 'quiet'[2020-02-18T12:58:45.426Z] STAGE_NAME= 'Configuring Build'[2020-02-18T12:58:45.426Z] NODE_LABELS   = 'Docker Swarm-b03e5c8e6b9f SUSEQt5.12'[2020-02-18T12:58:45.426Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-18T12:58:45.426Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-18T12:58:45.426Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-18T12:58:45.426Z] PROFILEREAD   = 'true'[2020-02-18T12:58:45.426Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-18T12:58:45.426Z] HOSTTYPE  = 'x86_64'[2020-02-18T12:58:45.426Z] BUILD_ID  = '99'[2020-02-18T12:58:45.426Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-18T12:58:45.426Z] OLDPWD= '/home/jenkins'[2020-02-18T12:58:45.426Z] LC_CTYPE  = 'C.UTF-8'[2020-02-18T12:58:45.426Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-18T12:58:45.426Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-18T12:58:45.426Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-18T12:58:45.426Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-18T12:58:45.426Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-18T12:58:45.426Z] QT_SELECT = 'qt5'[2020-02-18T12:58:45.426Z] LANG  = 'en_US.UTF-8'[2020-02-18T12:58:45.426Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-18T12:58:45.426Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-18T12:58:45.426Z] [2020-02-18T12:58:45.426Z] [2020-02-18T12:58:45.426Z] == Commencing Configuration:[2020-02-18T12:58:45.426Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12"[2020-02-18T12:58:45.426Z] -- The C compiler identification is GNU 9.2.1[2020-02-18T12:58:45.682Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-18T12:58:45.682Z] -- Check for working C compiler: /usr/bin/cc[2020-02-18T12:58:45.682Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-18T12:58:45.682Z] -- Detecting C compiler ABI info[2020-02-18T12:58:45.682Z] -- Detecting C compiler ABI info - done[2020-02-18T12:58:45.682Z] -- Detecting C compile features[2020-02-18T12:58:45.682Z] -- Detecting C compile features - done[2020-02-18T12:58:45.682Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-18T12:58:45.682Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-18T12:58:45.682Z] -- Detecting CXX compiler ABI info[2020-02-18T12:58:45.936Z] -- Detecting CXX compiler ABI info - done[2020-02-18T12:58:45.936Z] -- Detecting CXX compile features[2020-02-18T12:58:45.936Z] -- Detecting CXX compile features - done[2020-02-18T12:58:45.936Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2020-02-18T12:58:45.936Z] -- Looking for __GLIBC__[2020-02-18T12:58:45.936Z] -- Looking for __GLIBC__ - found[2020-02-18T12:58:45.936Z] -- Performing Test _OFFT_IS_64BIT[2020-02-18T12:58:46.191Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-18T12:58:46.191Z] -- Performing Test HAVE_DATE_TIME[2020-02-18T12:58:46.191Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-18T12:58:46.191Z] -- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmak

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 265 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/265/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 18 Feb 2020 12:50:28 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 276 lines...][2020-02-18T13:01:35.455Z] WINDOWMANAGER = 'xterm'[2020-02-18T13:01:35.455Z] PAGER = 'less'[2020-02-18T13:01:35.455Z] EXECUTOR_NUMBER   = '0'[2020-02-18T13:01:35.455Z] CVS_RSH   = 'ssh'[2020-02-18T13:01:35.455Z] LIBGL_DEBUG   = 'quiet'[2020-02-18T13:01:35.455Z] STAGE_NAME= 'Configuring Build'[2020-02-18T13:01:35.455Z] NODE_LABELS   = 'Docker Swarm-1c2f368d47fe SUSEQt5.12'[2020-02-18T13:01:35.455Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-18T13:01:35.455Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-18T13:01:35.455Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-18T13:01:35.455Z] PROFILEREAD   = 'true'[2020-02-18T13:01:35.455Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-18T13:01:35.455Z] HOSTTYPE  = 'x86_64'[2020-02-18T13:01:35.455Z] BUILD_ID  = '265'[2020-02-18T13:01:35.455Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-18T13:01:35.455Z] OLDPWD= '/home/jenkins'[2020-02-18T13:01:35.455Z] LC_CTYPE  = 'C.UTF-8'[2020-02-18T13:01:35.455Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-18T13:01:35.455Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-18T13:01:35.455Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-18T13:01:35.455Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-18T13:01:35.455Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-18T13:01:35.455Z] QT_SELECT = 'qt5'[2020-02-18T13:01:35.455Z] LANG  = 'en_US.UTF-8'[2020-02-18T13:01:35.455Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-18T13:01:35.455Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-18T13:01:35.455Z] [2020-02-18T13:01:35.455Z] [2020-02-18T13:01:35.455Z] == Commencing Configuration:[2020-02-18T13:01:35.455Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12"[2020-02-18T13:01:35.727Z] -- The C compiler identification is GNU 9.2.1[2020-02-18T13:01:36.130Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-18T13:01:36.130Z] -- Check for working C compiler: /usr/bin/cc[2020-02-18T13:01:36.130Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-18T13:01:36.130Z] -- Detecting C compiler ABI info[2020-02-18T13:01:36.130Z] -- Detecting C compiler ABI info - done[2020-02-18T13:01:36.130Z] -- Detecting C compile features[2020-02-18T13:01:36.130Z] -- Detecting C compile features - done[2020-02-18T13:01:36.130Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-18T13:01:36.402Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-18T13:01:36.402Z] -- Detecting CXX compiler ABI info[2020-02-18T13:01:36.667Z] -- Detecting CXX compiler ABI info - done[2020-02-18T13:01:36.667Z] -- Detecting CXX compile features[2020-02-18T13:01:36.667Z] -- Detecting CXX compile features - done[2020-02-18T13:01:36.667Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-02-18T13:01:36.667Z] -- Looking for __GLIBC__[2020-02-18T13:01:37.077Z] -- Looking for __GLIBC__ - found[2020-02-18T13:01:37.077Z] -- Performing Test _OFFT_IS_64BIT[2020-02-18T13:01:37.362Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-18T13:01:37.362Z] -- Performing Test HAVE_DATE_TIME[2020-02-18T13:01:37.623Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-18T13:01:38.633Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.68.0") [2020-02-18T13:01:38.633Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-02-18T13:01:38.633Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-de

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c7c190488e46: Breeze widgetStyle value is Breeze 
(authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27407?vs=75699&id=75909

REVISION DETAIL
  https://phabricator.kde.org/D27407

AFFECTED FILES
  lookandfeel/contents/defaults

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75911.
The-Feren-OS-Dev marked an inline comment as done.
The-Feren-OS-Dev added a comment.


  Moved baseSize declaration and changed it to a standard variable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75869&id=75911

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75912.
The-Feren-OS-Dev added a comment.


  Updated diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75873&id=75912

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75913.
The-Feren-OS-Dev added a comment.


  Updated diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75912&id=75913

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  Abandoned because @lmontel just commits changes instead of reviewing other 
people's patches. :(

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27424: Add missing cursors for Chromium-based apps

[Guilherme Silva]

guilhermesilva added a comment.


  Absolutely! Thank you very much.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27424

To: guilhermesilva, #breeze, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven updated this revision to Diff 75920.
meven marked 2 inline comments as done.
meven added a comment.


  Add a validLastCurrentIndex function, check emailClientService is not null 
before using it

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27395?vs=75695&id=75920

BRANCH
  arcpatch-D27395

REVISION DETAIL
  https://phabricator.kde.org/D27395

AFFECTED FILES
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: meven, bport, ervin, crossi, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27358: Sync ("Wayland") appending to match SDDM

[Fabian Vogt]

fvogt added a comment.


  Note that this behaviour of sddm is not in any release yet - only in git.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27358

To: davidedmundson, #plasma, ngraham
Cc: fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: Plasma.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. #plasma  folks, is this all 
technically correct?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27411: Port away from deprecated API

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a subscriber: mlaurent.
apol added a comment.


  @mlaurent did the same but he doesn't put his patches through review.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27411

To: apol, jgrulich
Cc: mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Méven Car]

meven marked 4 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ervin wrote in DeviceAutomounterKCM.cpp:57
> Sure, moving away from a singleton is always intrusive (just like moving away 
> from a global variable which it is really). Let's aim for it in a different 
> specific patch.

Just waiting for this review then, I am preparing the next patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Aleix Pol Gonzalez]

apol added a comment.


  Both the isServiceRegistered and the env changes make sense to me.

INLINE COMMENTS

> startup.cpp:232
>  connect(loginSound, &NotificationThread::finished, loginSound, 
> &NotificationThread::deleteLater);
>  loginSound->start();});
>  

Unrelated change.

> startup.cpp:421
> +m_process->setArguments(args);
> +m_process->setProcessEnvironment(env);
> +

Maybe it would make sense to do the merging of envs here? This way we only set 
when it's necessary.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Nathaniel Graham]

ngraham added subscribers: mlaurent, ngraham.
ngraham added a comment.


  @mlaurent ^^

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Nathaniel Graham]

ngraham added a comment.


  This probably fixes at least one of these:
  
  - https://bugs.kde.org/show_bug.cgi?id=385920
  - https://bugs.kde.org/show_bug.cgi?id=413783
  - https://bugs.kde.org/show_bug.cgi?id=382604
  - https://bugs.kde.org/show_bug.cgi?id=414109

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

To: bport, #plasma, broulik, ervin, meven, crossi, davidedmundson
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

[Méven Car]

meven created this revision.
meven added reviewers: ervin, crossi, bport, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Depends on D27127 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27127

REVISION DETAIL
  https://phabricator.kde.org/D27480

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.h
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kcm/DeviceModel.h
  solid-device-automounter/kded/DeviceAutomounter.cpp
  solid-device-automounter/kded/DeviceAutomounter.h
  solid-device-automounter/lib/AutomounterSettings.cpp
  solid-device-automounter/lib/AutomounterSettings.h
  solid-device-automounter/lib/AutomounterSettingsBase.kcfgc

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounterKCM.cpp:57
> Just waiting for this review then, I am preparing the next patch

D27480 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Laurent Montel]

mlaurent added a comment.


  In D27408#613565 , @ngraham wrote:
  
  > @mlaurent ^^
  
  
  Just a question: How I can see it if nobody adds me as reviewer (if I 
remember I was the only one guys who works against qt5.15 from several months 
so why don't add me as reviewer ? )? (For sure I have some scripts for automate 
theses changes so I commit quickly it)
  
  but this patch was wrong as QOverload::of(&QComboBox::currentIndexChanged), was created in qt5.15 not in 
"<= qt5.15" so in qt5.15.1 it will failed when  we compile without deprecated 
methods.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> componentchooser.h:51
>  
> +int validLastCurrentIndex() {
> +// m_currentIndex == -1 means there are no previously saved value

{ in new line, add const

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27481: [WIP]Panel spacer that can center things

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  - Make the panel spacer take a lot more space when is in expanding mode, so 
much
  
  to "win" against the taskbar and collapse it to its minimum size (seems the
  most expected behavior after some discussions in vdg channel)
  
  - make it paint a background when in edit mode
  - when two spacers are present in the panel, they try to center all the 
content
  
  that is in between them (if possible), so that is always at the center of the 
panel,
  even if there is more content on one side rather than the other

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/panelSpacer

REVISION DETAIL
  https://phabricator.kde.org/D27481

AFFECTED FILES
  applets/CMakeLists.txt
  applets/panelspacer/CMakeLists.txt
  applets/panelspacer/Messages.sh
  applets/panelspacer/contents/config/main.xml
  applets/panelspacer/contents/ui/main.qml
  applets/panelspacer/metadata.desktop
  applets/panelspacer/package/contents/config/main.xml
  applets/panelspacer/package/contents/ui/main.qml
  applets/panelspacer/package/metadata.desktop
  applets/panelspacer/plugin/CMakeLists.txt
  applets/panelspacer/plugin/panelspacer.cpp
  applets/panelspacer/plugin/panelspacer.h

To: mart, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27481: [WIP]Panel spacer that can center things

[Marco Martin]

mart added a comment.


  Implementation-wise could make sense for the implementation be in the panel 
itself, tough it may be difficult to control from the external panel 
configuration tool
  
  Usability-wise i think would be fine if the first spacer is added at the end 
of the panel, and the second at the beginning, trigering the centering for the 
whole panel contents, tough again is a bit difficult to trigger from the 
external panel configuration toolbar

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Méven Car]

meven updated this revision to Diff 75926.
meven added a comment.


  Make validLastCurrentIndex const, newline before {

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27395?vs=75920&id=75926

BRANCH
  arcpatch-D27395

REVISION DETAIL
  https://phabricator.kde.org/D27395

AFFECTED FILES
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserterminal.cpp

To: meven, bport, ervin, crossi, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Aleix Pol Gonzalez]

apol added a comment.


  In D27408#613598 , @mlaurent wrote:
  
  > Just a question: How I can see it if nobody adds me as reviewer (if I 
remember I was the only one guys who works against qt5.15 from several months 
so why don't add me as reviewer ? )? (For sure I have some scripts for automate 
theses changes so I commit quickly it)
  
  
  Do you want us to add you on every review? I'd say you can just subscribe to 
Plasma and Frameworks if you are planning to work on Plasma and Frameworks.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27367: fix activity runner

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2a979a4bbebe: fix activity runner (authored by McPain, 
committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27367?vs=75900&id=75928

REVISION DETAIL
  https://phabricator.kde.org/D27367

AFFECTED FILES
  runners/activities/activityrunner.cpp

To: McPain, broulik, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for your patch @alex. However since this is a targeted bugfix, I would 
like to land it now on the stable branch. Since your patch includes 
refactoring, it needs to go into the next release. I'll land this now, and then 
you can remove this bugfix from your patch. Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

To: McPain, heikobecker, ngraham
Cc: ngraham, alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:f0431c95a895: fix condition in KonsoleProfiles::run 
(authored by McPain, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27365?vs=75596&id=75929

REVISION DETAIL
  https://phabricator.kde.org/D27365

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp

To: McPain, heikobecker, ngraham
Cc: ngraham, alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Nathaniel Graham]

ngraham added a comment.


  Can you rebase this patch now?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Laurent Montel]

mlaurent added a comment.


  no each reviews but when you create a patch for qt5.15 as I was the only dev 
which worked on qt5.15 it was logical to add me.
  I will not subscribe for each commit in plasma/framework, for sure after 
20-30 commits I will not read them. I have ~ 200 mails by days, so for sure I 
will not be able to read them.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex updated this revision to Diff 75930.
alex added a comment.


  Rebase patch as requested

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=75724&id=75930

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo added a comment.


  Thanks Nate, both for explaining and taking care of the patches yesterday.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27470: Set good default value for cursor theme and size in KRDB

[Nathaniel Graham]

ngraham added a comment.


  Can you run `arc amend` on your local branch to pick up the changes I just 
made to the description, and then land this on the stable branch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27470

To: bport, #plasma, broulik, ervin, meven, crossi, davidedmundson
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  Is there any problem with this patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo added a comment.


  Can I close this patch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  We're waiting for @davidedmundson to re-review it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[Nathaniel Graham]

ngraham added a comment.


  I don't know enough to say whether it makes sense to fix this here, or in Qt. 
I'd like a #plasma  or maybe #kwin 
 person to weigh in.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[Nathaniel Graham]

ngraham added a comment.


  You're welcome!

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Following D27407  provide kconf update 
script to fix user configuration for widgetStyle when Breeze global theme is 
applied

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/style_widgetstyle_default_breeze.pl
  kcms/style/style_widgetstyle_default_breeze.upd

To: crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  BUG 397595

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27483

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Nathaniel Graham]

ngraham added a comment.


  In D27408#613637 , @mlaurent wrote:
  
  > no each reviews but when you create a patch for qt5.15 as I was the only 
dev which worked on qt5.15 it was logical to add me.
  >  I will not subscribe for each commit in plasma/framework, for sure after 
20-30 commits I will not read them. I have ~ 200 mails by days, so for sure I 
will not be able to read them.
  
  
  We all get that many emails per day, or more.
  
  Making sure that commits get reviewed is an important part of keeping up the 
quality. Even obvious-seeming bugfixes can regress things. If your workflow 
makes it impossible for you to seek review for your commits, or to review other 
people's commits, then maybe there's something wrong with your workflow.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27481: [WIP]Panel spacer that can center things

[Nathaniel Graham]

ngraham added a comment.


  Super cool feature! This was one of the things I was missing for D24223 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

[Cyril Rossi]

crossi updated this revision to Diff 75933.
crossi added a comment.


  restore blank line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27483?vs=75932&id=75933

REVISION DETAIL
  https://phabricator.kde.org/D27483

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, ervin, bport, meven, davidedmundson, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Nathaniel Graham]

ngraham added a comment.


  How do I trigger this to get run? Restarting plasmashell or opening the Style 
KCM didn't seem to do it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch please. :)
  
  Oh and the syntax is `BUG: 397595` (note the colon)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27483

To: crossi, ervin, bport, meven, davidedmundson, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27088: [applets/SystemTray] Implement sorting in the model

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  The role names part is nice.
  
  I have one major-ish comment, and 2 pendantic comments that I don't really 
care about.

INLINE COMMENTS

> sortedsystemtraymodel.cpp:47
> +if (categoriesComparison == 0) {
> +return compareDisplayAlphabetically(left, right);
> +} else {

I think calling QSortFilterProxyModel::lessThan(left, right); would do the same

then you don't need compareDisplayAlphabetically

your implementation looks fine though, so do whichever

> sortedsystemtraymodel.h:35
> +protected:
> +virtual bool lessThan(const QModelIndex &source_left, const QModelIndex 
> &source_right) const override;
> +

We tend not to write virtual at the start now we have the clearer override 
keyword

> systemtraymodel.cpp:115
> +dataItem->setData(applet->title(), Qt::DisplayRole);
> +connect(applet, &Plasma::Applet::titleChanged, this, [dataItem] (const 
> QString &title) {
> +dataItem->setData(title, static_cast(Qt::DisplayRole));

The applet is still alive after removeApplet is called. "this" is still alive

dataItem is not.

If an applet is added, removed   and then (potentially during applet teardown) 
it changes its title, this would crash.

I don't know if that's a realistic scenario or not,  but I would still maybe 
disconnect all signals from applet -> this on removeApplet?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27088

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks like a sane clean-up to me. #konsole 
 and.or #plasma 
 folks?

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  In D27482#613699 , @ngraham wrote:
  
  > How do I trigger this to get run? Restarting plasmashell or opening the 
Style KCM didn't seem to do it.
  
  
  To run the update script, just apply the patch and rebuild plasma-desktop.
  
  To confirm it has run in .config/kconf_updaterc at the end you will see
  
[style_widgetstyle_default_breeze.upd]
done=StyleWidgetStyleDefaultBreeze,StyleRemoveGeneralWidgetStyle
  
  And in .config/kdeglobals should have updated `widgetStyle` entry in group 
`KDE`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added a comment.


  This fix the issue for Breeze theme, but according to bug description 
(https://bugs.kde.org/show_bug.cgi?id=417515) some configuration file may also 
have `oxygen` instead of `Oxygen`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Nathaniel Graham]

ngraham added a comment.


  In D27482#613714 , @crossi wrote:
  
  > In D27482#613699 , @ngraham 
wrote:
  >
  > > How do I trigger this to get run? Restarting plasmashell or opening the 
Style KCM didn't seem to do it.
  >
  >
  > To run the update script, just apply the patch and rebuild plasma-desktop.
  
  
  Did that.
  
  > To confirm it has run in .config/kconf_updaterc at the end you will see
  > 
  >   [style_widgetstyle_default_breeze.upd]
  >   done=StyleWidgetStyleDefaultBreeze,StyleRemoveGeneralWidgetStyle
  
  I see the following:
  
[style_widgetstyle_default_breeze.upd]
ctime=1582046255
done=StyleWidgetStyleDefaultBreeze
mtime=1582046231
  
  
  
  > And in .config/kdeglobals should have updated `widgetStyle` entry in group 
`KDE`
  
  I still see `widgetStyle=breeze` (not capitalized) in the file. :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[Aleix Pol Gonzalez]

apol added a comment.


  +1 patch makes sense to me

INLINE COMMENTS

> FolderItemDelegate.qml:435
> +radius: Math.round(5 * units.devicePixelRatio)
> +samples: radius * 2 + 1
>  spread: 0.05

Why's the + 1?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> FolderItemDelegate.qml:435
> +radius: Math.round(5 * units.devicePixelRatio)
> +samples: radius * 2 + 1
>  spread: 0.05

https://doc.qt.io/qt-5/qml-qtgraphicaleffects-dropshadow.html#samples-prop
`Ideally, this value should be twice as large as the highest required radius 
value plus`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> FolderItemDelegate.qml:435
> +radius: Math.round(5 * units.devicePixelRatio)
> +samples: radius * 2 + 1
>  spread: 0.05

And I ate the "one"
`Ideally, this value should be twice as large as the highest required radius 
value plus one`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo updated this revision to Diff 75935.
gvgeo added a comment.


  More style fixes. (indentation restore)

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=75820&id=75935

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2/17/20 11:08 PM, Luca Beltrame wrote:

In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto:


think KDE software should be presented to users. Basically, we
acknowledge that Neon is already an actual OS--the "KDE OS"--and we


Please don't suggest such downstream-hostile solutions, in particular because
this failing is entirely upstream. We have already plenty in FOSS, I don't
want KDE to be yet another community that "adopts" them.

"We messed up so let's make things our way" is not an acceptable approach.


Neon is already an OS, whether or not you want to admit it. It's 
installed from an ISO. A hardware vendor (Slimbook) is shipping it on 
laptops that people can and do buy. My wife has it installed on her 
computer. It's an OS as much as any other Ubuntu-derived distro can be 
considered an OS.


I actually happen to use openSUSE Tumbleweed myself instead of Neon for 
a variety of reasons, and I'm happy with it. I'm not saying "Neon is an 
OS!" because I think everyone should immediately switch to it and stop 
using other distros. There's room in the universe of KDE distros for one 
more that happens to be a first-party product--as evidenced by the fact 
that Neon has existed for four years and the whole world hasn't come 
tumbling down. I mean, Microsoft got into the PC hardware business in 
competition with Dell, HP, Toshiba, et al, and it didn't destroy their 
business. Far from it: the new entries from Microsoft spurred everyone 
else to improve their own offerings, broadly lifting the quality of PC 
hardware for everyone.


Nate

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2/16/20 2:55 PM, Friedrich W. H. Kossebau wrote:

Yes, this has been questioned a few times. Also seeing Plasma LTS used
together with a non-LTS Qt is a bit strange.
But somehow it seems there has not been enough pain for those using the Plasma
LTS to change something. Possibly because distributions simply backport
important bug fixes for KF themselves, kind of maintaining their own KF LTS
version of the KF version they pinpointed to when they froze the ingredients
to their OS. Because they are used to do this for other projects as well, and
so miss this could be done in cooperation with upstream.


There has been pain. This thread mentions a number of examples, and 
There were quite a few for the last 5.12 LTS too. But more generally, 
the pain is baked into Frameworks due to the lack of any bugfix 
releases. For example Kubuntu 18.04 shipped with the Plasma 5.12 LTS and 
Frameworks 5.44. That Plasma version has continued to receive bugfix 
point releases since then. But the Frameworks product has not, and so 
users have now missed out on two years worth of bugfixes. I don't know 
about openSUSE, but I know that Kubuntu does not have the resources to 
backport individual KF bugfixes--I repeatedly requested this as I 
identified them and none ever got backported. But they do ship point 
releases for Plasma, so they could ship point releases for an LTS 
Frameworks version.




IMHO distributions using Plasma LTS, Plasma team & other stakeholders should
team up here and maintain a matching LTS branch of Frameworks together at the
central KDE repos together. Well, and a version also satisfying other clients
of KF, like non-workspace applications from KDE.

It's not a reason to change normal KF release cycle.


I like that idea. So perhaps we could say that the KF version which 
happens to be the dependency for a Plasma LTS release could have bugfix 
releases? Would that be reasonable?



Nate

Re: How to close PMC?

[Nate Graham]

What is PMC? Plasma Media Center? Something else?

Nate


On 2/15/20 4:47 AM, Peter Lorenz wrote:

Hi all,


I' wondering: How do I close the PMC? I can't find anything to do this.

I am running PMC on a laptop with arch linux.
And have always the newest builds installed.

It seems, all I can do is restart the computer.

Can somebody help with this?

Thanks in advance!

Peter Lorenz

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2/16/20 2:55 PM, Friedrich W. H. Kossebau wrote:

Yes, this has been questioned a few times. Also seeing Plasma LTS used
together with a non-LTS Qt is a bit strange.
But somehow it seems there has not been enough pain for those using the Plasma
LTS to change something. Possibly because distributions simply backport
important bug fixes for KF themselves, kind of maintaining their own KF LTS
version of the KF version they pinpointed to when they froze the ingredients
to their OS. Because they are used to do this for other projects as well, and
so miss this could be done in cooperation with upstream.


There has been pain. This thread mentions a number of examples, and 
There were quite a few for the last 5.12 LTS too. But more generally, 
the pain is baked into Frameworks due to the lack of any bugfix 
releases. For example Kubuntu 18.04 shipped with the Plasma 5.12 LTS and 
Frameworks 5.44. That Plasma version has continued to receive bugfix 
point releases since then. But the Frameworks product has not, and so 
users have now missed out on two years worth of bugfixes. I don't know 
about openSUSE, but I know that Kubuntu does not have the resources to 
backport individual KF bugfixes--I repeatedly requested this as I 
identified them and none ever got backported. But they do ship point 
releases for Plasma, so they could ship point releases for an LTS 
Frameworks version.




IMHO distributions using Plasma LTS, Plasma team & other stakeholders should
team up here and maintain a matching LTS branch of Frameworks together at the
central KDE repos together. Well, and a version also satisfying other clients
of KF, like non-workspace applications from KDE.

It's not a reason to change normal KF release cycle.


I like that idea. So perhaps we could say that the KF version which 
happens to be the dependency for a Plasma LTS release could have bugfix 
releases? Would that be reasonable?



Nate

D27408: Fix build with Qt 5.15.0

[Laurent Montel]

mlaurent added a comment.


  So you review all patch from all repo ? :) awesome ! I am not able to do it! 
And I don't want to do it otherwise no possible to work on my projects.
  But I am happy that you do it ! :)
  
  So for sure I will not review all patchs from framework/plasma, but I am not 
against for reviewing qt5.15 patch.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27408: Fix build with Qt 5.15.0

[Nathaniel Graham]

ngraham added a comment.


  Yes I at least look at all new patches for Plasma, Frameworks, and many KDE 
apps. If I'm capable of reviewing them, I do. If not, I try to add people to 
the reviewers list who I think can, if they're not already marked as reviewers.
  
  We can add you as a reviewer for porting/Qt-related patches, sure.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart