Re: Information regarding upcoming Gitlab Migration: clarifications

[Ben Cooksley]

On Fri, May 1, 2020 at 4:38 PM Nate Graham  wrote:
>
>
>
> On 4/30/20 5:59 PM, Aleix Pol wrote:
> > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
> >> Am I the only person that just has all the repos on the same folder? I 
> >> thought it was the common thing to do :?
> >
> > I do too
>
> Same here. kdesrc-build's default settings do this, and download all
> repos into ~/kde/src without any of the levels of hierarchy. This would
> seem to require unique repo names, no?

Not necessarily.

Git allows you to override the name that the local folder is called
when cloning, so there is no reason why we can't specify something in
the metadata to override the local name that the folder gets called in
your local checkout folder.
This would allow for example:

- frameworks/kcoreaddons on Gitlab continues to be called
'kcoreaddons' in your local checkout folder
- maui/dialer on Gitlab gets called 'maui-dialer' in your local checkout folder

This allows for the URLs on Gitlab to make sense, while simultaneously
allowing your local source checkout folders to continue to work in the
manner in which they do currently.
Note that we do not expect people to hit this in many cases - this is
about giving us the flexibility for the long term without imposing
unnecessary bureaucracy and limits on projects within the KDE
umbrella.

Automated tooling such as kdesrc-build and the proposed clone script
(that searches in namespaces) should be able to handle this without
much issue.
In the case of manually done clones, it is reasonable to expect people
to know what they're doing with their clones, and name them
appropriately in the event they have a collision.

Does this sound acceptable?

>
> The group categorization we've been discussing may be useful on the web
> UI for newcomers, but it has no value for your source checkout folder
> IMO, where it just makes it slightly more annoying to navigate from one
> repo to another.
>
> Nate

Cheers,
Ben

Re: Information regarding upcoming Gitlab Migration

[Ben Cooksley]

On Fri, May 1, 2020 at 2:46 AM Nate Graham  wrote:
>
> If I'm understanding things, we have solutions to most or all of the
> objections raised so far:
>
> - Projects will be allowed to live in--or at least appear in--multiple
> top-level groups (e.g. plasma-framework could appear in both the
> Frameworks top-level group and also the Plasma top-level group)

Projects will have the option to appear in multiple groups yes.

>
> - kdesrc-build and other scripts can be updated to allow people to
> easily check out repos using git prefixes (e.g. so that something like
> `git clone kde:dolphin` will still work regardlyss of a project's
> underlying group)

The syntax will probably be slightly different to that, but the
concept is correct yes.

>
> - cgit will continue to exist for three weeks to provide some transition
> time

Correct.

>
> - Each repo can have its own workboard in addition to the single
> group-level workboard

Correct, just one small clarification: each project (repository) can
have multiple workboards, there is no limit to this.
Groups are limited to a single workboard.

>
> If the above are accurate, then I firmly support the proposal.
>
> As for the actual grouping, I think it makes sense to have top-level
> groups for Frameworks, Plasma, PIM, etc. as originally proposed. I can
> support putting apps into category-specific groups (e.g. Multimedia,
> Office, Graphics, Games, etc) as long as apps could appear in multiple
> groups if needed for the case of apps that logically span boundaries
> (e.g. repos for PlaMo apps could appear in both the Plasma Mobile
> top-level group and also the relevant app group).
>
>
> Nate

Cheers,
Ben

Re: Information regarding upcoming Gitlab Migration: clarifications

[Nate Graham]

On 4/30/20 5:59 PM, Aleix Pol wrote:

El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid

Am I the only person that just has all the repos on the same folder? I thought 
it was the common thing to do :?


I do too


Same here. kdesrc-build's default settings do this, and download all 
repos into ~/kde/src without any of the levels of hierarchy. This would 
seem to require unique repo names, no?


The group categorization we've been discussing may be useful on the web 
UI for newcomers, but it has no value for your source checkout folder 
IMO, where it just makes it slightly more annoying to navigate from one 
repo to another.


Nate

D27960: Make it possible to scroll through the padding

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid that for me there is no change from last time. :( If a two-finger 
scroll event is initiated to the left or right of the application screenshots 
component, the scroll behavior is really jerky and weird. Do you need a video 
or something?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27960

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

cblack updated this revision to Diff 81642.
cblack added a comment.


  Add explanatory comment

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29307?vs=81609=81642

BRANCH
  cblack/smallfont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29307

AFFECTED FILES
  CMakeLists.txt
  kirigami-plasmadesktop-integration/CMakeLists.txt
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: repo freeze tomorrow

[Aleix Pol]

On Thu, Apr 30, 2020 at 7:57 PM Rik Mills  wrote:
>
> On 30/04/2020 18:33, Aleix Pol wrote:
> > Yes, in practice.
>
> In practice? What other way is there? Now I check some more they seem
> very non-optional.

I mean that plasma-wayland-protocols is supposed to be released
outside of Plasma (as it will be a kwayland dependency eventually).
Sorry, could have explained myself better.

Aleix

D29312: Change microphoneindicator for reporting audio monitors

[Giusy Margarita]

kurmikon added a comment.


  @nicolasfella if an application is recording directly from an input device (a 
simple microphone), your hint would be the solution: we should check and 
exclude sink source monitors.
  
  This way PulseEffects would be correctly excluded. But I was thinking a 
special case which would lead to another issue. If in the future there will be 
(or maybe it already exists) an application that records from multiple input 
devices (something to mix from more than one microphone), this app should 
create a monitor sink to redirect every source, then it has to record from the 
monitor.
  
  In the case, if we exclude applications recoding from a sink monitor, we will 
exclude this app that really is using microphones, which is not the primary 
intended purpose.
  
  So, the best approach is to cover all cases and report "an app is monitoring 
something" when it is recoding from whichever source.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration: clarifications

[Aleix Pol]

On Fri, May 1, 2020 at 1:08 AM Nicolás Alvarez
 wrote:
>
> El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
> (aa...@kde.org) escribió:
> >
> > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va 
> > escriure:
> > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić  wrote:
> > > >
> > > > > We have made a big fuss in the past about having different projects
> > > > > that do the same thing and now we'll have that but also we'll have
> > > > > several projects with the same name?
> > > > > It really feels off to me and I wonder if this is related to the move 
> > > > > to
> > > > > gitlab.
> > > >
> > > > +1 to both sentiments - that projects should have different names and 
> > > > that
> > > > this is a bit off topic for the gitlab migration.
> > >
> > > The projects *DO* have very different names. That *HAS NOT* changed.
> > > To use the example Bhushan gave above, one is called Plasma Mobile
> > > Dialer and the other one is called Maui Dialer.
> > >
> > > With the current git.kde.org setup, we have a flat namespace, so all
> > > repositories if the name appears to be generic (as dialer is) have to
> > > be namespaced by prefixing of the repository name.
> > >
> > > With Gitlab however we will now namespaces that group repositories,
> > > making the prefixing unnecessary and as some projects have complained
> > > about, duplicative.
> > >
> > > Otherwise you end up with plasma-mobile/plasma-mobile-dialer as your
> > > path, which just looks silly.
> >
> > Am I the only person that just has all the repos on the same folder? I 
> > thought it was the common thing to do :?

I do too

> Oh, your local path could be anywhere. It doesn't even need the same
> name, you can put it in the same folder as the rest and call it
> dial-thingy :)

And then you'll have to have a modified build script to account for
thingy because KDE can't stay consistent at naming.

I suggest not to use the gitlab transition to make such an important change.

Aleix

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

masonm updated this revision to Diff 81640.
masonm added a comment.


  Fix preventing layer from pushing itself

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29294?vs=81619=81640

BRANCH
  add-pagepool-layer-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29294

AFFECTED FILES
  .gitignore
  autotests/CMakeLists.txt
  autotests/pagepool/tst_layers.qml
  src/controls/PagePoolAction.qml
  src/controls/PageRow.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 59 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/59/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 22:03:20 +
 Build duration:
1 hr 39 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testScreenEdgesFailed: projectroot.autotests.kwin_testScreensFailed: projectroot.autotests.kwin_testScriptedEffectLoaderName: projectroot.autotests Failed: 2 test(s), Passed: 106 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testModiferOnlyShortcutName: projectroot.autotests.integration Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)57%
(323/562)57%
(323/562)42%
(31527/74293)32%
(14204/43915)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault87%
(133/153)87%
(133/153)65%
(19519/30198)50%
(9872/19779)colorcorrection100%
(7/7)100%
(7/7)79%
(672/855)59%
(238/401)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)79%
(444/562)65%
(140/216)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/379)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/693)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
(79/970)3%
(29/894)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/233)2%
(3/158)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(46/657)1%
(5/552)effects.glide67%
(2/3)67%
 

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in DeviceItem.qml:34
> This is all over the place for me. All the free space jobs in the dataengine 
> get the root size back. Not sure if a local issue or KIO? @dfaure

Please give me a proper bug report in KIO terms :-)
What class do you use, what do you get as a result?

I don't see a bug in a TODO comment in some QML code ;)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration: clarifications

[Nicolás Alvarez]

El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
(aa...@kde.org) escribió:
>
> El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure:
> > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić  wrote:
> > >
> > > > We have made a big fuss in the past about having different projects
> > > > that do the same thing and now we'll have that but also we'll have
> > > > several projects with the same name?
> > > > It really feels off to me and I wonder if this is related to the move to
> > > > gitlab.
> > >
> > > +1 to both sentiments - that projects should have different names and that
> > > this is a bit off topic for the gitlab migration.
> >
> > The projects *DO* have very different names. That *HAS NOT* changed.
> > To use the example Bhushan gave above, one is called Plasma Mobile
> > Dialer and the other one is called Maui Dialer.
> >
> > With the current git.kde.org setup, we have a flat namespace, so all
> > repositories if the name appears to be generic (as dialer is) have to
> > be namespaced by prefixing of the repository name.
> >
> > With Gitlab however we will now namespaces that group repositories,
> > making the prefixing unnecessary and as some projects have complained
> > about, duplicative.
> >
> > Otherwise you end up with plasma-mobile/plasma-mobile-dialer as your
> > path, which just looks silly.
>
> Am I the only person that just has all the repos on the same folder? I 
> thought it was the common thing to do :?

Oh, your local path could be anywhere. It doesn't even need the same
name, you can put it in the same folder as the rest and call it
dial-thingy :)

This is about the server path (eg. the clone URL) looking redundant:
invent.kde.org/plasma-mobile/plasma-mobile-dialer.

-- 
Nicolás

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 70 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/70/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 30 Apr 2020 22:03:22 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineFailed: projectroot.autotests.kwin_testScreenEdgesFailed: projectroot.autotests.kwin_testScreensFailed: projectroot.autotests.kwin_testScriptedEffectLoaderName: projectroot.autotests Failed: 11 test(s), Passed: 97 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDontCrashAuroraeDestroyDecoFailed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testModiferOnlyShortcutFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXdgShellClientFailed: projectroot.autotests.integration.kwin_testXdgShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 5 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.14 - Build # 48 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.14/48/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 22:03:18 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kcms.lookandfeel.autotests.lookandfeel_kcmTest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)16%
(59/368)16%
(59/368)12%
(3708/31348)9%
(1729/19017)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/180)0%
(0/107)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/359)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/317)0%
(0/224)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2351)28%
(419/1503)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
 

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 61 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/61/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 30 Apr 2020 22:03:20 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kcms.lookandfeel.autotests.lookandfeel_kcmTest

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.14 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.14/8/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 22:03:17 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4111)0%
(0/2669)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1463)0%
(0/1085)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/833)0%
(0/479)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/237)0%
(0/122)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1026)0%
(0/750)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/198)0%
(0/93)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/72)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/80)0%
(0/22)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/118)0%
(0/46)

KDE CI: Plasma » powerdevil » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 30 Apr 2020 22:03:18 +
 Build duration:
1 min 46 sec and counting

2 new repositories: plasma-wayland-protocols and kwayland-server

[Aleix Pol]

Hi everyone,
After long discussions, we have broken kwayland into 3 pieces so we
can work and improve kwin_wayland without having to extend our stable
framework constantly. This of course comes together with an updated
policy with regards to where things should be developed with the goal
of only adding Wayland protocol implementation public interfaces in
the cases that will be shared among several users.

This then includes 2 new repositories:
kdesupport/plasma-wayland-protocols
kde/workspace/kwayland-server

The first should be released independently whenever we have a new
protocol, the latter only together with the rest of Plasma.

Over the next months we'll adapt KWayland as well to depend on
plasma-wayland-protocols and deprecate some of its parts that are now
duplicated.

Anything compiling against kwayland for now is fine and will continue
to work. It still needs to be installed.
All 3 are co-installable.

Sorry for the extra work of caring for the extra repositories. We are
convinced it will be worth it in the long run.

Best regards,
Aleix

Re: Information regarding upcoming Gitlab Migration: clarifications

[Albert Astals Cid]

El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure:
> On Fri, May 1, 2020 at 6:04 AM Ivan Čukić  wrote:
> >
> > > We have made a big fuss in the past about having different projects
> > > that do the same thing and now we'll have that but also we'll have
> > > several projects with the same name?
> > > It really feels off to me and I wonder if this is related to the move to
> > > gitlab.
> >
> > +1 to both sentiments - that projects should have different names and that
> > this is a bit off topic for the gitlab migration.
> 
> The projects *DO* have very different names. That *HAS NOT* changed.
> To use the example Bhushan gave above, one is called Plasma Mobile
> Dialer and the other one is called Maui Dialer.
> 
> With the current git.kde.org setup, we have a flat namespace, so all
> repositories if the name appears to be generic (as dialer is) have to
> be namespaced by prefixing of the repository name.
> 
> With Gitlab however we will now namespaces that group repositories,
> making the prefixing unnecessary and as some projects have complained
> about, duplicative.
> 
> Otherwise you end up with plasma-mobile/plasma-mobile-dialer as your
> path, which just looks silly.

Am I the only person that just has all the repos on the same folder? I thought 
it was the common thing to do :?

Cheers,
  Albert

> 
> >
> > Cheers,
> > Ivan
> >
> >
> 
> Regards,
> Ben
> 
> >
> > --
> > dr Ivan Čukić
> > i...@cukic.co, https://cukic.co/
> > gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12
> >
> >
> 

D26636: [Widget Explorer] Work around bad kerning

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26636

To: filipf, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This makes it take up less vertical space in the header area and also match 
the similar
  messang in the notifications applet.

TEST PLAN
  F8274308: vokoscreenNG-2020-04-30_14-38-19.webm 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve-battery-applet-top-bar-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29315

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

To: ngraham, #vdg, #plasma, broulik, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29312: Change microphoneindicator for reporting audio monitors

[Giusy Margarita]

kurmikon added a comment.


  In D29312#660704 , @nicolasfella 
wrote:
  
  > In D29312#660702 , @kurmikon 
wrote:
  >
  > > In D29312#660670 , 
@nicolasfella wrote:
  > >
  > > > > but due to a lack in qt libraries
  > > >
  > > > Can you elaborate on this? What is Qt lacking?
  > >
  > >
  > > I'm not an expert, so I don't really know. Reading the bug report, 
there's no way to discern input devices from monitor sinks. So if you want to 
report applications that are using a microphone, you end up showing 
applications like PuseEffects that create a monitor sink. Those applications 
can use a microphone but in most cases don't, because PulseEffects is mostly 
used to apply effects to output streams (but need to record those streams 
effectively).
  >
  >
  > Qt is not really involved in this. What matters is what libpulse offers, 
and it seems to me that we can check whether a sink is a monitor 
(https://freedesktop.org/software/pulseaudio/doxygen/structpa__source__info.html#a5e304b796ce71c7fa54e5a88f630).
 One would need to add a method isMonitor to Sink that reads this information 
and then we can not show the indicator when it's a monitor
  
  
  I'm afraid that application that really use a microphone, create a monitor 
sink.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29312: Change microphoneindicator for reporting audio monitors

[Nicolas Fella]

nicolasfella added a comment.


  In D29312#660702 , @kurmikon wrote:
  
  > In D29312#660670 , @nicolasfella 
wrote:
  >
  > > > but due to a lack in qt libraries
  > >
  > > Can you elaborate on this? What is Qt lacking?
  >
  >
  > I'm not an expert, so I don't really know. Reading the bug report, there's 
no way to discern input devices from monitor sinks. So if you want to report 
applications that are using a microphone, you end up showing applications like 
PuseEffects that create a monitor sink. Those applications can use a microphone 
but in most cases don't, because PulseEffects is mostly used to apply effects 
to output streams (but need to record those streams effectively).
  
  
  Qt is not really involved in this. What matters is what libpulse offers, and 
it seems to me that we can check whether a sink is a monitor 
(https://freedesktop.org/software/pulseaudio/doxygen/structpa__source__info.html#a5e304b796ce71c7fa54e5a88f630).
 One would need to add a method isMonitor to Sink that reads this information 
and then we can not show the indicator when it's a monitor

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29312: Change microphoneindicator for reporting audio monitors

[Giusy Margarita]

kurmikon added a comment.


  In D29312#660670 , @nicolasfella 
wrote:
  
  > > but due to a lack in qt libraries
  >
  > Can you elaborate on this? What is Qt lacking?
  
  
  I'm not an expert, so I don't really know. Reading the bug report, there's no 
way to discern input devices from monitor sinks. So if you want to report 
applications that are using a microphone, you end up showing applications like 
PuseEffects that create a monitor sink. Those application can use a microphone 
but in most cases don't, because PulseEffects is mostly used to apply effects 
to output streams (but need to record those streams effectively).

INLINE COMMENTS

> ngraham wrote in microphoneindicator.cpp:264
> I don't think this needs to be removed. If an app is "monitoring audio" but 
> there 's no audio recording device, that it hardly matters, right?

First of all, I'm not a c++ developer, I just changed strings, I don't even 
know what m_sourceModel is. I assume it's a structure listing input sinks, so 
if you don't have microphones connected, you won't see the indicator, right?

If I assumed right, this is useless I think, because when you connect a 
microphone, the indicator will show PulseEffects even if nothing is recording 
from the mic. Plus, some systems have microphone integrated, always connected, 
so it's useless in this case.

The point is: you want to show applications using microphones? So, show only 
them, and not monitor sinks.

Since it seems that can't be achieved, show everything is monitoring an audio 
stream,  including applications using microphone and monitor sinks. So, if 
there's no audio recording device, show monitor sinks (if they are present).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration: clarifications

[Ben Cooksley]

On Fri, May 1, 2020 at 5:58 AM Nate Graham  wrote:
>
>
>
> On 4/30/20 11:43 AM, Aleix Pol wrote:
> > IMHO needing tools ad-hoc to KDE development can be a barrier of entrance.
> > I feel like these things make us look distant, it's important that
> > people's skills translate automatically when they want to get started.
>
> True, but if you're a new contributor, presumably our infrastructure
> would do the right thing the first time and you wouldn't need to use any
> migration script, right?

That is correct.

>
> Nate

Cheers,
Ben

Re: Information regarding upcoming Gitlab Migration: clarifications

[Ben Cooksley]

On Fri, May 1, 2020 at 6:04 AM Ivan Čukić  wrote:
>
> > We have made a big fuss in the past about having different projects
> > that do the same thing and now we'll have that but also we'll have
> > several projects with the same name?
> > It really feels off to me and I wonder if this is related to the move to
> > gitlab.
>
> +1 to both sentiments - that projects should have different names and that
> this is a bit off topic for the gitlab migration.

The projects *DO* have very different names. That *HAS NOT* changed.
To use the example Bhushan gave above, one is called Plasma Mobile
Dialer and the other one is called Maui Dialer.

With the current git.kde.org setup, we have a flat namespace, so all
repositories if the name appears to be generic (as dialer is) have to
be namespaced by prefixing of the repository name.

With Gitlab however we will now namespaces that group repositories,
making the prefixing unnecessary and as some projects have complained
about, duplicative.

Otherwise you end up with plasma-mobile/plasma-mobile-dialer as your
path, which just looks silly.

>
> Cheers,
> Ivan
>
>

Regards,
Ben

>
> --
> dr Ivan Čukić
> i...@cukic.co, https://cukic.co/
> gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12
>
>

Re: Information regarding upcoming Gitlab Migration: clarifications

[Ben Cooksley]

On Fri, May 1, 2020 at 5:44 AM Aleix Pol  wrote:
>
> On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah  wrote:
> >
> > Good afternoon,
> >
> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > replies]
> >
> > I want to clarify some bits for which we have gotten a questions about,
> >
> > - Non unique naming: There's some teams which prefer if we dropped the
> >   namespace- part from their name which we have added. While currently
> >   this does not result in the naming conflict right away, we realize
> >   this will cause it at one point, for example,
> >
> >   maui-dialer -> maui/dialer
> >   plasma-dialer -> plasma-mobile/dialer
> >
> >   To minimize the impact of the Gitlab move we won't be doing such
> >   renames which introduce non-unique names right away. But we would
> >   prefer if the existing tooling or infrastructure is ready for this
> >   kind of cases at later point. Only way to enforce non-unique naming is
> >   one big KDE/ subgroup which we want to avoid.
> >
> >   Current naming in the repo-metadata branch[1] I've pointed does not
> >   reflect those renames, as we are not planning to do those renames
> >   right away during gitlab move, but at a later stage.
>
> We have made a big fuss in the past about having different projects
> that do the same thing and now we'll have that but also we'll have
> several projects with the same name?
> It really feels off to me and I wonder if this is related to the move to 
> gitlab.
>
> > - Existing configurations: we want to reduce impact on existing release
> >   schedule, and existing developer workflow,  therefore we will continue
> >   to privide the existing anongit.kde.org and git.kde.org (although this
> >   will be read-only) with current flat structuring for 3 weeks after
> >   actual migration, which will keep the existing scripts/clones working
> >   enough to give developers time to change to the new structure.
> >
> >   We will also try to provide a script which allows you to migrate your
> >   existing clones to new repo paths and as mentioned by Ben in other
> >   message, potentially a git-kde script which would allow you to clone
> >   individual repository without knowing it's namespace (provided that
> >   there is no conflict of it's name). like "git kde karchive"
>
> IMHO needing tools ad-hoc to KDE development can be a barrier of entrance.
> I feel like these things make us look distant, it's important that
> people's skills translate automatically when they want to get started.

These tools are being provided as migration assistants.

New contributors won't have a problem, as they'll be used to finding
the project at games/knetwalk (to use an example).

>
> > - Translations: we will co-ordinate with the translations team to let
> >   them adapt their tooling to updated structure as this requires changes
> >   on their side how translations are stored in svn repository
>
> Thanks! :)

Cheers,
Ben

D29308: Fix excessive right padding in scrollable page

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e97ffaa7a6b3: Fix excessive right padding in scrollable 
page (authored by nicolasfella).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29308?vs=81611=81626

REVISION DETAIL
  https://phabricator.kde.org/D29308

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: nicolasfella, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29312: Change microphoneindicator for reporting audio monitors

[Nicolas Fella]

nicolasfella added a comment.


  > but due to a lack in qt libraries
  
  Can you elaborate on this? What is Qt lacking?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29312: Change microphoneindicator for reporting audio monitors

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> microphoneindicator.cpp:264
>  {
> -// If there are no microphones present, there's nothing to record
> -if (m_sourceModel->rowCount() == 0) {

I don't think this needs to be removed. If an app is "monitoring audio" but 
there 's no audio recording device, that it hardly matters, right?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29312: Change microphoneindicator for reporting audio monitors

[Nathaniel Graham]

ngraham added reviewers: VDG, Plasma, drosca, broulik.
ngraham added a comment.


  This is more accurate given the technical constraints, yeah.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29312: Change microphoneindicator for reporting audio monitors

[Giusy Margarita]

kurmikon created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kurmikon requested review of this revision.

REVISION SUMMARY
  Microphone indicator was introduced to report applications using a microphone.
  
  That wasn't a bad idea, but due to a lack in qt libraries, we can't discern 
microphone input devices from pulseaudio monitor sinks. The latter are used by 
applications such as PulseEffects. They record the stream from a source (i.e. 
the audio from Firefox playing a YouTube video, in order to add some effects). 
Since they record something, they act like a microphone, even if they **are 
not** and **do not** use a microphone.
  
  I filed this bug report  months 
ago, but nothing was resolved after months.
  
  An initial workaround was this revision , 
that simply did nothing since PulseEffects keeps showing and the tooltip 
reports it's using a microphone when that's not true.
  
  So a solution to this issue is renaming the tooltip reporting **Monitor 
audio**, informing the user that //something is monitoring an audio stream//. 
That includes both cases, applications that are really using a microphone and 
applications like PulseEffects that are using an audio stream to record it and 
redirect the stream inside its input pipeline to apply some changes.
  
  If you will accept the revision, I will also help to translate it in my 
language.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: kurmikon
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29311: Emit low battery notification immediately when plugging out AC

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Hmm, odd, will have to do further testing then

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29311

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

masonm updated this revision to Diff 81619.
masonm marked an inline comment as not done.
masonm added a comment.


  Add _private QtObject back and comment why

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29294?vs=81610=81619

BRANCH
  add-pagepool-layer-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29294

AFFECTED FILES
  .gitignore
  autotests/CMakeLists.txt
  autotests/pagepool/tst_layers.qml
  src/controls/PagePoolAction.qml
  src/controls/PageRow.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D29311: Emit low battery notification immediately when plugging out AC

[Nathaniel Graham]

ngraham added a comment.


  Yep I get the sound, and the display brightness falls immediately. It's just 
thew low battery notification that doesn't appear immediately.
  
  (nice catch, BTW)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29311

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

masonm marked an inline comment as not done.
masonm added inline comments.

INLINE COMMENTS

> cblack wrote in PagePoolAction.qml:161
> this isn't how you do private objects, drop `property QtObject _private` and 
> access by ID

Actually I realized why I did this now: the Action type does not allow 
assignment to default property so it is required to create a property here. I 
will put a comment on this but I need to add that back into the code, unless 
there is another pattern for this. If I were to create another "default" 
property, it would still be exposed to the public. It will likely have to be 
one of those things people just don't touch unless they want to break something.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29294

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D29311: Emit low battery notification immediately when plugging out AC

[Kai Uwe Broulik]

broulik added a comment.


  Do you get the sound that you unplugged? For me it sometimes took quite a 
while for it to actually recognize I unplugged

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29311

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29311: Emit low battery notification immediately when plugging out AC

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this isn't working for me, or else I'm not testing it correctly.
  
  I set the "low battery threshold" to 99% while my battery is only 93% charged 
and, unplug my cord. I should see a notification, right? But I don't.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29311

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29307: Implement smallFont in Kirigami plugin

[Nathaniel Graham]

ngraham added a comment.


  It would be good to explain why we need to use DBus for this, when it wasn't 
already implemented for the normal font size.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D29307

To: cblack, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.14 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.14/7/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 18:05:14 +
 Build duration:
1 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 118 lines...][Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-04-30T18:05:48.597Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T18:05:48.600Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T18:05:48.613Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T18:05:48.623Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-04-30T18:05:48.624Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T18:05:48.795Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T18:05:48.801Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T18:05:48.804Z]  > git checkout -f de1e2fd97aae301bf39e4015b456a247721a155c # timeout=10[2020-04-30T18:05:49.864Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project powerdevil --branchGroup kf5-qt5 --environment production --platform SUSEQt5.14 --installTo /home/jenkins//install-prefix/[2020-04-30T18:05:56.534Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T18:05:56.534Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T18:05:56.534Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T18:05:56.534Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T18:05:56.534Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T18:05:57.134Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2020-04-30T18:05:57.400Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T18:05:57.679Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T18:05:58.264Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T18:05:58.853Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T18:05:59.127Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T18:06:00.093Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T18:06:00.677Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T18:06:00.677Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T18:06:01.656Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T18:06:01.656Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T18:06:02.235Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T18:06:02.235Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T18:06:02.502Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T18:06:03.469Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T18:06:03.739Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T18:06:04.310Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T18:06:04.310Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T18:06:04.888Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T18:06:05.467Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T18:06:06.058Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T18:06:06.330Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T18:06:14.578Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T18:06:14.856Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T18:06:15.811Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T18:06:16.070Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T18:06:16.328Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T18:06:16.907Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T18:06:21.132Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T18:06:21.701Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T18:06:21.964Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T18:06:22.228Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T18:06:22.487Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T18:06:23.066Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T18:06:23.639Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T18:06:23.899Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T18:06:24.161Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T18:06:25.115Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T18:06:25.378Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T18:06:25.647Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T18:06:27.059Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T18:06:29.698Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T18:06:33.041Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T18:06:35.013Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T18:06:35.013Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T18:06:35.287Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T18:06:35.287Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T18:06:36.251Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T18:06:36.522Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T18:06:39.090Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T18:06:39.362Z] Retrieving: 

D29309: Make low battery notification critical

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:45dd7bbfe18b: Make low battery notification critical 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29309?vs=81615=81618#toc

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29309?vs=81615=81618

REVISION DETAIL
  https://phabricator.kde.org/D29309

AFFECTED FILES
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h

To: broulik, #plasma, #vdg, ngraham, apol
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 30 Apr 2020 18:05:13 +
 Build duration:
20 sec and counting
   CONSOLE OUTPUT
  [...truncated 79 lines...][2020-04-30T18:05:20.388Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2020-04-30T18:05:20.388Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T18:05:20.574Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T18:05:21.046Z] Checking out Revision cd85c753bbf4a0f43710f104496e54c88f23bd97 (origin/master)[2020-04-30T18:05:21.067Z] Commit message: "plasma-wayland-protocol: Fix repository location"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-04-30T18:05:20.581Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T18:05:20.585Z]  > git checkout -f cd85c753bbf4a0f43710f104496e54c88f23bd97 # timeout=10[2020-04-30T18:05:22.297Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project powerdevil --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.14 --installTo /home/jenkins/install-prefix/[2020-04-30T18:05:26.479Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T18:05:26.479Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T18:05:26.479Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T18:05:26.479Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T18:05:26.479Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T18:05:26.479Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T18:05:26.480Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T18:05:26.738Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T18:05:26.738Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T18:05:26.738Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T18:05:29.259Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T18:05:29.517Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T18:05:29.517Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T18:05:29.517Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T18:05:29.517Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T18:05:29.774Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T18:05:30.030Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T18:05:30.293Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T18:05:30.293Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T18:05:30.293Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T18:05:30.293Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T18:05:30.293Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T18:05:30.554Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T18:05:31.926Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T18:05:32.184Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T18:05:32.184Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T18:05:32.184Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T18:05:32.184Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T18:05:32.442Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T18:05:32.442Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T18:05:32.442Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T18:05:32.442Z] Retrieving: Plasma-baloo-kf5-qt5[2020-04-30T18:05:32.700Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2020-04-30T18:05:32.700Z] Retrieving: 

Re: Information regarding upcoming Gitlab Migration: clarifications

[Ivan Čukić]

> We have made a big fuss in the past about having different projects
> that do the same thing and now we'll have that but also we'll have
> several projects with the same name?
> It really feels off to me and I wonder if this is related to the move to
> gitlab.

+1 to both sentiments - that projects should have different names and that 
this is a bit off topic for the gitlab migration.

Cheers,
Ivan



-- 
dr Ivan Čukić
i...@cukic.co, https://cukic.co/
gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12

D29311: Emit low battery notification immediately when plugging out AC

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When plugging out AC, emit a low battery notification immediately, so one is 
notified of the fact that AC was unplugged with low battery.

TEST PLAN
  - Unplugged AC, got notification right away tha tbattery was low
  - Unplugged AC with enoguh percentage, did not get a notification

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29311

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29309: Make low battery notification critical

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29309

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29309: Make low battery notification critical

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This ensures you have to acknowledge it and be aware that the battery is 
running low.
  Otherwise you'll only be notified during a presentation when it's critical.
  
  CCBUG: 420541

TEST PLAN
  - Battery went low, got notification, was ontop of everything and didnt time 
out
  - Plugged AC back in, notification was revoked

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29309

AFFECTED FILES
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29308: Fix excessive right padding in scrollable page

[Nicolas Fella]

nicolasfella added a comment.


  Mobile before:
  F8274015: Screenshot_20200430_195955.png 

  
  Mobile after:
  F8274019: Screenshot_20200430_200111.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29308

To: nicolasfella, #kirigami, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

Re: Information regarding upcoming Gitlab Migration: clarifications

[Nate Graham]

On 4/30/20 11:43 AM, Aleix Pol wrote:

IMHO needing tools ad-hoc to KDE development can be a barrier of entrance.
I feel like these things make us look distant, it's important that
people's skills translate automatically when they want to get started.


True, but if you're a new contributor, presumably our infrastructure 
would do the right thing the first time and you wouldn't need to use any 
migration script, right?


Nate

Re: repo freeze tomorrow

[Rik Mills]

On 30/04/2020 18:33, Aleix Pol wrote:
> Yes, in practice.

In practice? What other way is there? Now I check some more they seem
very non-optional.

D29308: Fix excessive right padding in scrollable page

[Nathaniel Graham]

ngraham added a comment.


  Probably a legacy of the now-removed overlay scrollbars on the desktop. Does 
this still work when overlay scrollbars are being used on mobile?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29308

To: nicolasfella, #kirigami, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29308: Fix excessive right padding in scrollable page

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  In this example
  
import QtQuick 2.5
import QtQuick.Layouts 1.1
import org.kde.kirigami 2.4 as Kirigami

Kirigami.ScrollablePage {

Rectangle {
width: parent.width
height: 1000
color: "red"
}
}
  
  the gap between the rectangle and the scrollbar was larger than the distance 
between the left edge of the rectangle and the window. This was caused by the 
extra rightPadding of the RefreshableScrollView. It also seems unnecessary to 
me since the ScrollView itself takes care of dodging the scroll bar 
(ScrollView.qml:21).

REPOSITORY
  R169 Kirigami

BRANCH
  margin

REVISION DETAIL
  https://phabricator.kde.org/D29308

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: nicolasfella, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29301: [applets/mediacontroller] Elide text

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better, thanks.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/layout-fixeroni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29301

To: cblack, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration: clarifications

[Aleix Pol]

On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah  wrote:
>
> Good afternoon,
>
> [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> replies]
>
> I want to clarify some bits for which we have gotten a questions about,
>
> - Non unique naming: There's some teams which prefer if we dropped the
>   namespace- part from their name which we have added. While currently
>   this does not result in the naming conflict right away, we realize
>   this will cause it at one point, for example,
>
>   maui-dialer -> maui/dialer
>   plasma-dialer -> plasma-mobile/dialer
>
>   To minimize the impact of the Gitlab move we won't be doing such
>   renames which introduce non-unique names right away. But we would
>   prefer if the existing tooling or infrastructure is ready for this
>   kind of cases at later point. Only way to enforce non-unique naming is
>   one big KDE/ subgroup which we want to avoid.
>
>   Current naming in the repo-metadata branch[1] I've pointed does not
>   reflect those renames, as we are not planning to do those renames
>   right away during gitlab move, but at a later stage.

We have made a big fuss in the past about having different projects
that do the same thing and now we'll have that but also we'll have
several projects with the same name?
It really feels off to me and I wonder if this is related to the move to gitlab.

> - Existing configurations: we want to reduce impact on existing release
>   schedule, and existing developer workflow,  therefore we will continue
>   to privide the existing anongit.kde.org and git.kde.org (although this
>   will be read-only) with current flat structuring for 3 weeks after
>   actual migration, which will keep the existing scripts/clones working
>   enough to give developers time to change to the new structure.
>
>   We will also try to provide a script which allows you to migrate your
>   existing clones to new repo paths and as mentioned by Ben in other
>   message, potentially a git-kde script which would allow you to clone
>   individual repository without knowing it's namespace (provided that
>   there is no conflict of it's name). like "git kde karchive"

IMHO needing tools ad-hoc to KDE development can be a barrier of entrance.
I feel like these things make us look distant, it's important that
people's skills translate automatically when they want to get started.

> - Translations: we will co-ordinate with the translations team to let
>   them adapt their tooling to updated structure as this requires changes
>   on their side how translations are stored in svn repository

Thanks! :)

Re: repo freeze tomorrow

[Aleix Pol]

Yes, in practice.

Aleix

On Thu, Apr 30, 2020 at 6:19 PM Rik Mills  wrote:
>
> On 29/04/2020 22:04, David Edmundson wrote:
> > We have something announced that I'm not sure is on the list.
> >
> > Plasma will gain a new repo called kwayland-server.
> > This is a split of half the code currently in framework.
> >
> > Aleix has things prepared, but we haven't done all the steps to making
> > it part of Plasma.
> >
> > David
> >
>
> So this is 2 new repos for 5.19? plasma-wayland-protocols and
> kwayland-server
>

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

masonm updated this revision to Diff 81610.
masonm added a comment.


  Code review changes 1

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29294?vs=81606=81610

BRANCH
  add-pagepool-layer-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29294

AFFECTED FILES
  .gitignore
  autotests/CMakeLists.txt
  autotests/pagepool/tst_layers.qml
  src/controls/PagePoolAction.qml
  src/controls/PageRow.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

TEST PLAN
  F8273961: image.png  F8273893: font.qml 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  cblack/smallfont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29307

AFFECTED FILES
  CMakeLists.txt
  kirigami-plasmadesktop-integration/CMakeLists.txt
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> tst_layers.qml:19-25
> +function initTestCase() {
> +mainWindow.show()
> +}
> +
> +function cleanupTestCase() {
> +mainWindow.close()
> +}

You want to use `when: windowShown`

> tst_layers.qml:27
> +
> +function applicationWindow() { return mainWindow; }
> +

Unused.

> PagePoolAction.qml:63
> +  * This is intended for use with PageRow layers to allow 
> PagePoolActions to
> +  * push context-specific pages onto the layers stack. 
> +  */

@since 5.70
  @since org.kde.kirigami 2.12

> PagePoolAction.qml:161
> +
> +property QtObject _private: QtObject {
> +id: _private

this isn't how you do private objects, drop `property QtObject _private` and 
access by ID

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29294

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 60 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/60/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 30 Apr 2020 16:51:23 +
 Build duration:
1 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 79 lines...][2020-04-30T16:49:29.642Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2020-04-30T16:49:29.650Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2020-04-30T16:49:29.650Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T16:49:29.768Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T16:49:29.774Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T16:49:29.780Z]  > git checkout -f cd85c753bbf4a0f43710f104496e54c88f23bd97 # timeout=10[2020-04-30T16:51:36.885Z] Commit message: "plasma-wayland-protocol: Fix repository location"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-04-30T16:51:41.954Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.14 --installTo /home/jenkins/install-prefix/[2020-04-30T16:51:46.328Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T16:51:46.328Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T16:51:46.590Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T16:51:46.590Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T16:51:46.854Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T16:51:47.120Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T16:51:47.386Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T16:51:48.149Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T16:51:49.091Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T16:51:49.091Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T16:51:50.050Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T16:51:50.050Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T16:51:50.316Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T16:51:50.884Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T16:51:50.884Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T16:51:51.447Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T16:51:51.447Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T16:51:52.047Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T16:51:52.620Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T16:51:52.620Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T16:51:53.198Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T16:51:53.198Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T16:51:53.458Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T16:51:54.038Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T16:51:54.298Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T16:51:54.560Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T16:52:01.167Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T16:52:01.741Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T16:52:02.721Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T16:52:02.721Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T16:52:03.822Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T16:52:04.398Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T16:52:08.642Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T16:52:08.642Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T16:52:08.642Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T16:52:08.934Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T16:52:09.516Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T16:52:10.090Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T16:52:11.048Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T16:52:11.314Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T16:52:11.580Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T16:52:12.538Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T16:52:13.113Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T16:52:13.817Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T16:52:15.218Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T16:52:18.758Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T16:52:22.172Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T16:52:24.946Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T16:52:24.946Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T16:52:25.228Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T16:52:25.493Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T16:52:26.439Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T16:52:26.702Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T16:52:27.963Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T16:52:28.542Z] Retrieving: Plasma-baloo-kf5-qt5[2020-04-30T16:52:29.934Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2020-04-30T16:52:30.513Z] Retrieving: 

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.14 - Build # 47 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.14/47/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 16:51:23 +
 Build duration:
1 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 118 lines...][2020-04-30T16:51:56.830Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T16:51:56.834Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-04-30T16:51:56.834Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T16:51:56.992Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T16:51:56.998Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T16:51:56.999Z]  > git checkout -f de1e2fd97aae301bf39e4015b456a247721a155c # timeout=10[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-04-30T16:51:59.187Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup kf5-qt5 --environment production --platform SUSEQt5.14 --installTo /home/jenkins//install-prefix/[2020-04-30T16:52:01.717Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T16:52:01.978Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T16:52:02.545Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T16:52:02.806Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T16:52:03.380Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T16:52:04.329Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2020-04-30T16:52:04.592Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T16:52:05.172Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T16:52:06.127Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T16:52:06.708Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T16:52:06.971Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T16:52:08.361Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T16:52:08.361Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T16:52:08.624Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T16:52:09.200Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T16:52:09.464Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T16:52:09.724Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T16:52:09.988Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T16:52:09.988Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T16:52:10.936Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T16:52:11.513Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T16:52:12.465Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T16:52:12.466Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T16:52:13.044Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T16:52:13.622Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T16:52:13.887Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T16:52:14.152Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T16:52:20.758Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T16:52:20.758Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T16:52:21.330Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T16:52:21.330Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T16:52:21.593Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T16:52:21.857Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T16:52:27.175Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T16:52:27.175Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T16:52:27.437Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T16:52:27.699Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T16:52:27.963Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T16:52:28.227Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T16:52:29.625Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T16:52:29.625Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T16:52:29.887Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T16:52:31.274Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T16:52:31.274Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T16:52:31.538Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T16:52:33.463Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T16:52:36.028Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T16:52:38.581Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T16:52:40.502Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T16:52:40.502Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T16:52:40.503Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T16:52:40.764Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T16:52:41.337Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T16:52:41.337Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T16:52:42.289Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T16:52:42.554Z] Retrieving: Plasma-baloo-kf5-qt5[2020-04-30T16:52:43.947Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2020-04-30T16:52:44.512Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2020-04-30T16:52:44.512Z] Retrieving: 

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1ee6660ceb62: Rewrite of the global shortcuts kcm 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81441=81607

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

masonm updated this revision to Diff 81606.
masonm added a comment.


  Handle checked status with exclusive groups

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29294?vs=81588=81606

BRANCH
  add-pagepool-layer-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29294

AFFECTED FILES
  .gitignore
  autotests/CMakeLists.txt
  autotests/pagepool/tst_layers.qml
  src/controls/PagePoolAction.qml
  src/controls/PageRow.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9368dcc28f66: Introduce Theme::smallFont (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29304?vs=81603=81604

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami, mart
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> basictheme.cpp:74
> +setDefaultFont(qApp->font());
> +setSmallFont([]() {
> +auto smallFont = qApp->font();

you can just do a temp smallfont and then setFont with it without the lambda

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29304

To: cblack, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

[Carson Black]

cblack updated this revision to Diff 81603.
cblack added a comment.


  Drop Rust-ism

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29304?vs=81601=81603

BRANCH
  cblack/smallFont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29304: Introduce Theme::smallFont

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Like defaultFont, but smaller.

TEST PLAN
  F8273893: font.qml 

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/smallFont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

Re: repo freeze tomorrow

[Rik Mills]

On 29/04/2020 22:04, David Edmundson wrote:
> We have something announced that I'm not sure is on the list.
> 
> Plasma will gain a new repo called kwayland-server.
> This is a split of half the code currently in framework.
> 
> Aleix has things prepared, but we haven't done all the steps to making
> it part of Plasma.
> 
> David
> 

So this is 2 new repos for 5.19? plasma-wayland-protocols and
kwayland-server

D29301: [applets/mediacontroller] Elide text

[Carson Black]

cblack updated this revision to Diff 81598.
cblack retitled this revision from "[applets/mediacontroller] Drop maximum 
height on songTitle" to "[applets/mediacontroller] Elide text".
cblack edited the test plan for this revision.
cblack added a comment.


  Elide text

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29301?vs=81593=81598

BRANCH
  cblack/layout-fixeroni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29301

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29074: Make BasicListItem more useful by giving it a subtitle property

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:432b5d3d456c: Make BasicListItem more useful by giving it 
a subtitle property (authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29074?vs=81592=81596

REVISION DETAIL
  https://phabricator.kde.org/D29074

AFFECTED FILES
  src/controls/BasicListItem.qml
  src/controls/plugins.qmltypes

To: ngraham, #vdg, #kirigami, mart
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Instead of using KF5 which is wrong since KSysGuard isn't part of
  frameworks.
  
  This needs a follow up patch to the ksysguard repo to make it use the new
  namespace.

TEST PLAN
  Still builds

REPOSITORY
  R111 KSysguard Library

BRANCH
  lib_namespace

REVISION DETAIL
  https://phabricator.kde.org/D29302

AFFECTED FILES
  CMakeLists.txt
  KF5SysGuardConfig.cmake.in
  KSysGuardConfig.cmake.in
  autotests/CMakeLists.txt
  ksgrd/CMakeLists.txt
  lsofui/CMakeLists.txt
  processcore/CMakeLists.txt
  processui/CMakeLists.txt
  signalplotter/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Kai Uwe Broulik]

broulik added a subscriber: dfaure.
broulik added inline comments.

INLINE COMMENTS

> DeviceItem.qml:32
>  
> -MouseArea {
> +// TODO: fix expanding when a new device is connected; done in 
> devicenotifier.qml
> +// TODO: clean up list item expanding code in devicenotifier.qml

There's an `expandedDevice` property in devicenotifier.qml which is supposed to 
decide which device is expanded. You either want to wire up this properly with 
the new delegate or nuke it.
For example in `DeviceItem` do

  Connections {
  target: devicenotifier
  onExpandedDeviceChanged: {
  if (devicenotifier.expandedDevice === udi) {
  deviceItem.expand();
  } else {
  deviceItem.collapse();
  }
  }
  }

However, it resets the `expandedDevice` right away for whatever reason. But 
this should maybe give you an idea. Alternatively, since expanded state is now 
in the delegate, you could just emit a signal when a source is added to have 
the device expand.

> DeviceItem.qml:34
> +// TODO: clean up list item expanding code in devicenotifier.qml
> +// TODO: make the free space calculation/display work again for 
> newly-mounted volumes
> +// TODO: make sure message display works

This is all over the place for me. All the free space jobs in the dataengine 
get the root size back. Not sure if a local issue or KIO? @dfaure

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29301: [applets/mediacontroller] Drop maximum height on songTitle

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  That ain't gonna work
  
  F8273712: Screenshot_20200430_090409.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29301

To: cblack, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29301: [applets/mediacontroller] Drop maximum height on songTitle

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

TEST PLAN
  Before: F8273701: image.png 
  After: F8273704: image.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/layout-fixeroni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29301

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29074: Make BasicListItem more useful by giving it a subtitle property

[Nathaniel Graham]

ngraham updated this revision to Diff 81592.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29074?vs=80815=81592

BRANCH
  more-capable-BasicListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29074

AFFECTED FILES
  src/controls/BasicListItem.qml
  src/controls/plugins.qmltypes

To: ngraham, #vdg, #kirigami, mart
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29074: Make BasicListItem more useful by giving it a subtitle property

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> BasicListItem.qml:31
> + * Optional; if not defined, the list item will only have a main label
> + * @since 2.12
> + */

@since 5.70
  @since org.kde.kirigami 2.12

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29074

To: ngraham, #vdg, #kirigami, mart
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29074: Make BasicListItem more useful by giving it a subtitle property

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> BasicListItem.qml:120
> +elide: Text.ElideRight
> +font.pointSize: theme.smallestFont.pointSize
> +opacity: 0.6

from plasma style, can't be used

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29074

To: ngraham, #vdg, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

Re: Information regarding upcoming Gitlab Migration

[Nate Graham]

If I'm understanding things, we have solutions to most or all of the 
objections raised so far:


- Projects will be allowed to live in--or at least appear in--multiple 
top-level groups (e.g. plasma-framework could appear in both the 
Frameworks top-level group and also the Plasma top-level group)


- kdesrc-build and other scripts can be updated to allow people to 
easily check out repos using git prefixes (e.g. so that something like 
`git clone kde:dolphin` will still work regardlyss of a project's 
underlying group)


- cgit will continue to exist for three weeks to provide some transition 
time


- Each repo can have its own workboard in addition to the single 
group-level workboard


If the above are accurate, then I firmly support the proposal.

As for the actual grouping, I think it makes sense to have top-level 
groups for Frameworks, Plasma, PIM, etc. as originally proposed. I can 
support putting apps into category-specific groups (e.g. Multimedia, 
Office, Graphics, Games, etc) as long as apps could appear in multiple 
groups if needed for the case of apps that logically span boundaries 
(e.g. repos for PlaMo apps could appear in both the Plasma Mobile 
top-level group and also the relevant app group).



Nate

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  My spacebar shortcut issue will be fixed with D29292 
. I think this deserves to get into Plasma 
5.19, and the sooner the better so there's no rush before the deadline.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

masonm updated this revision to Diff 81588.
masonm added a comment.


  Honor checkable state of Action

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29294?vs=81562=81588

BRANCH
  add-pagepool-layer-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29294

AFFECTED FILES
  .gitignore
  autotests/CMakeLists.txt
  autotests/pagepool/tst_layers.qml
  src/controls/PagePoolAction.qml
  src/controls/PageRow.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

Re: repo freeze tomorrow

[Aleix Pol]

Are there any specific steps needed?
I tried to make it so the cmake variables on the /CMakeLists.txt are
named like in Plasma.

We will also need plasma-wayland-protocols released as kdesupport soon.
Right now I'm trying to make sure all is well on the CI side.

Aleix

On Wed, Apr 29, 2020 at 11:04 PM David Edmundson
 wrote:
>
> We have something announced that I'm not sure is on the list.
>
> Plasma will gain a new repo called kwayland-server.
> This is a split of half the code currently in framework.
>
> Aleix has things prepared, but we haven't done all the steps to making it 
> part of Plasma.
>
> David
>

D29297: [Notifications] Have checkIndex check if the index is valid

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Apparently by default it only considers "out of range" indices invalid but an 
invalid one as valid.

TEST PLAN
  5.18?
  
  - Closing notifications still works
  - Pausing, aborting jobs still works
  
  Possibly fixes Bug 418347 or some other unexpected crashers?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29297

AFFECTED FILES
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/notificationsmodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29279: Don't play volume feedback if max volume is reached

[Nathaniel Graham]

ngraham added a comment.


  In D29279#660153 , @broulik wrote:
  
  > If any, we should block repeated feedback sounds when pressing and holding 
the key without the volume changing but pressing the key once should always 
play the respective sound.
  
  
  That makes sense to me.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vol

REVISION DETAIL
  https://phabricator.kde.org/D29279

To: nicolasfella, #plasma, drosca, ngraham
Cc: broulik, cblack, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29296: [KCMs/Notifications] Port placeholder message to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

TEST PLAN
  F8273471: Screenshot_20200430_071412.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  port-notifications-KCM-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29296

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 81577.
ahiemstra added a comment.


  Don't eat the lib Arc

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=81576=81577

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 81576.
ahiemstra added a comment.


  - Don't expose private SensorInfo in public interface of SensorQuery

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=80758=81576

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorQuery.h
  sensors/declarative/CMakeLists.txt

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 58 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/58/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 11:28:47 +
 Build duration:
1 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 117 lines...][Pipeline] stage[Pipeline] { (Setup Dependencies)[2020-04-30T11:29:34.158Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T11:29:34.166Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T11:29:34.183Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T11:29:34.204Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-04-30T11:29:34.205Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T11:29:34.436Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T11:29:34.451Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T11:29:34.456Z]  > git checkout -f de1e2fd97aae301bf39e4015b456a247721a155c # timeout=10[Pipeline] sh[2020-04-30T11:29:35.655Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kwin --branchGroup kf5-qt5 --environment production --platform SUSEQt5.14 --installTo /home/jenkins//install-prefix/[2020-04-30T11:29:39.274Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T11:29:39.274Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T11:29:39.549Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T11:29:39.549Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T11:29:39.549Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T11:29:39.549Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T11:29:39.812Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T11:29:40.074Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T11:29:40.074Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T11:29:40.074Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T11:29:40.074Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T11:29:40.074Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T11:29:43.363Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T11:29:43.363Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T11:29:43.363Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T11:29:43.363Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T11:29:43.363Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T11:29:43.622Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T11:29:43.881Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T11:29:44.146Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T11:29:44.146Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T11:29:44.146Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T11:29:44.146Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T11:29:44.404Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T11:29:45.778Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T11:29:45.778Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T11:29:45.778Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T11:29:45.778Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T11:29:45.778Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T11:29:46.036Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T11:29:46.036Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T11:29:46.036Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T11:29:46.036Z] Retrieving: 

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 69 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/69/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 30 Apr 2020 10:56:33 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 78 lines...][Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-04-30T10:54:47.146Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2020-04-30T10:54:47.152Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T10:54:47.164Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2020-04-30T10:54:47.174Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2020-04-30T10:54:47.174Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T10:54:47.309Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T10:54:47.319Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T10:54:47.321Z]  > git checkout -f b10ce9d05b17176b9d2cd390e10ed6abf2759791 # timeout=10[2020-04-30T10:56:55.532Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kwin --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.14 --installTo /home/jenkins/install-prefix/[2020-04-30T10:56:59.724Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T10:56:59.724Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T10:57:00.289Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T10:57:00.679Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T10:57:00.679Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T10:57:00.679Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T10:57:00.679Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T10:57:00.679Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T10:57:00.938Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T10:57:00.938Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T10:57:01.195Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T10:57:01.195Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T10:57:01.195Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T10:57:01.195Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T10:57:08.011Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T10:57:08.416Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T10:57:08.416Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T10:57:08.416Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T10:57:08.984Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T10:57:12.515Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T10:57:12.515Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T10:57:12.515Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T10:57:12.515Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T10:57:12.515Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T10:57:12.856Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T10:57:12.856Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T10:57:12.856Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T10:57:12.856Z] Retrieving: Plasma-baloo-kf5-qt5[2020-04-30T10:57:13.113Z] 

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 57 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/57/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 30 Apr 2020 10:56:33 +
 Build duration:
48 sec and counting
   CONSOLE OUTPUT
  [...truncated 117 lines...][2020-04-30T10:57:07.714Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T10:57:07.715Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T10:57:07.721Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2020-04-30T10:57:07.726Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2020-04-30T10:57:07.726Z]  > git fetch --tags --force --progress -- https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2020-04-30T10:57:07.934Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-04-30T10:57:07.938Z]  > git config core.sparsecheckout # timeout=10[2020-04-30T10:57:07.940Z]  > git checkout -f de1e2fd97aae301bf39e4015b456a247721a155c # timeout=10[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-04-30T10:57:10.235Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kwin --branchGroup kf5-qt5 --environment production --platform SUSEQt5.14 --installTo /home/jenkins//install-prefix/[2020-04-30T10:57:12.750Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-kcodecs-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-karchive-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-ki18n-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-kauth-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-kconfig-kf5-qt5[2020-04-30T10:57:13.005Z] Retrieving: Plasma-kdoctools-kf5-qt5[2020-04-30T10:57:13.261Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2020-04-30T10:57:13.261Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2020-04-30T10:57:13.261Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2020-04-30T10:57:13.261Z] Retrieving: Plasma-kitemviews-kf5-qt5[2020-04-30T10:57:13.261Z] Retrieving: Plasma-kirigami-kf5-qt5[2020-04-30T10:57:13.516Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2020-04-30T10:57:13.516Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2020-04-30T10:57:13.516Z] Retrieving: Plasma-kcrash-kf5-qt5[2020-04-30T10:57:13.516Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2020-04-30T10:57:13.516Z] Retrieving: Plasma-phonon-kf5-qt5[2020-04-30T10:57:13.771Z] Retrieving: Plasma-knotifications-kf5-qt5[2020-04-30T10:57:13.771Z] Retrieving: Plasma-kservice-kf5-qt5[2020-04-30T10:57:13.771Z] Retrieving: Plasma-kcompletion-kf5-qt5[2020-04-30T10:57:13.771Z] Retrieving: Plasma-sonnet-kf5-qt5[2020-04-30T10:57:14.028Z] Retrieving: Plasma-attica-kf5-qt5[2020-04-30T10:57:14.028Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2020-04-30T10:57:14.028Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2020-04-30T10:57:14.028Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2020-04-30T10:57:16.546Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2020-04-30T10:57:16.546Z] Retrieving: Plasma-solid-kf5-qt5[2020-04-30T10:57:16.546Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2020-04-30T10:57:16.546Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2020-04-30T10:57:16.546Z] Retrieving: Plasma-kwallet-kf5-qt5[2020-04-30T10:57:16.546Z] Retrieving: Plasma-kio-kf5-qt5[2020-04-30T10:57:16.800Z] Retrieving: Plasma-kparts-kf5-qt5[2020-04-30T10:57:16.800Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2020-04-30T10:57:16.800Z] Retrieving: Plasma-kpackage-kf5-qt5[2020-04-30T10:57:16.800Z] Retrieving: Plasma-kactivities-kf5-qt5[2020-04-30T10:57:16.800Z] Retrieving: Plasma-kdnssd-kf5-qt5[2020-04-30T10:57:16.800Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-kidletime-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-kross-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-threadweaver-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-kwayland-kf5-qt5[2020-04-30T10:57:17.055Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2020-04-30T10:57:17.310Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2020-04-30T10:57:18.674Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2020-04-30T10:57:18.674Z] Retrieving: Plasma-kpty-kf5-qt5[2020-04-30T10:57:18.674Z] Retrieving: Plasma-kinit-kf5-qt5[2020-04-30T10:57:18.674Z] Retrieving: Plasma-kded-kf5-qt5[2020-04-30T10:57:18.674Z] Retrieving: Plasma-kemoticons-kf5-qt5[2020-04-30T10:57:18.931Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2020-04-30T10:57:18.931Z] Retrieving: Plasma-knewstuff-kf5-qt5[2020-04-30T10:57:18.931Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2020-04-30T10:57:18.931Z] Retrieving: 

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> SensorFaceController.h:42
> +
> +class FACES_EXPORT SensorFaceController : public QObject
> +{

Can you place this class (and related classes) in the KSysGuard namespace? Then 
it would match the rest of the libraries.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> CMakeLists.txt:52
>  KF5::I18n
> +KF5::Package
> +KF5::ConfigCore

This is no longer needed.

> CMakeLists.txt:5
>  
> -target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors 
> KF5::ProcessCore)
> +target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors 
> KF5::ProcessCore KF5::Package KF5::ConfigCore KF5::ConfigGui)
>  

This is no longer needed.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis added a comment.


  It seems to me that this revision does not have the required momentum to move 
forward. I'll keep it open for another week in case someone else wants to chime 
in, but unless something changes I'll abandon it and maintain it off tree for 
personal use.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() 
instead of deprecated newIconLoader() (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29285?vs=81567=81569

REVISION DETAIL
  https://phabricator.kde.org/D29285

AFFECTED FILES
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/main.cpp

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Kai Uwe Broulik]

broulik added a comment.


  shipit

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29285

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

crossi updated this revision to Diff 81567.
crossi added a comment.


  consider Kai's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29285?vs=81536=81567

REVISION DETAIL
  https://phabricator.kde.org/D29285

AFFECTED FILES
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/main.cpp

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

crossi added a comment.


  In D29285#660158 , @broulik wrote:
  
  > Can this go into 5.18?
  
  
  Sure.

INLINE COMMENTS

> broulik wrote in main.cpp:307
> Isn't this redundant? i.e. doesn't `emitChange` emit do exactly this?

This one sends a `notifyChange` signal.

`KIconLoader::emitChange()` sends a `iconChanged()` signal.

From KIconLoader :

  QDBusMessage message = 
QDBusMessage::createSignal(QStringLiteral("/KIconLoader"), 
QStringLiteral("org.kde.KIconLoader"), QStringLiteral("iconChanged"));

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29285

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks
  
  Can this go into 5.18?

INLINE COMMENTS

> main.cpp:147
> +const QModelIndex index = m_iconSizeCategoryModel->index(i, 0);
> +if (!index.isValid()) {
> +continue;

I think this check isn't necessary

> main.cpp:150
> +}
> +const QString key = m_iconSizeCategoryModel->data(index, 
> IconSizeCategoryModel::ConfigKeyRole).toString();
> +if (m_settings->findItem(key)->isSaveNeeded()) {

You can also do `index.data(role)`

> main.cpp:307
>  for (int i = 0; i < KIconLoader::LastGroup; i++) {
> -KIconLoader::emitChange(KIconLoader::Group(i));
> -
>  QDBusMessage message = 
> QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"),
>
> QStringLiteral("org.kde.KGlobalSettings"),

Isn't this redundant? i.e. doesn't `emitChange` emit do exactly this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29285

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29279: Don't play volume feedback if max volume is reached

[Kai Uwe Broulik]

broulik added a comment.


  I'm with @cblack here. When I press the button i expect a feedback. If any, 
we should block repeated feedback sounds when pressing and holding the key 
without the volume changing but pressing the key once should always play the 
respective sound.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vol

REVISION DETAIL
  https://phabricator.kde.org/D29279

To: nicolasfella, #plasma, drosca, ngraham
Cc: broulik, cblack, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart