Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 26, 2016, 12:17 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Klapetek. Changes --- Submitted with commit c974341fe3502c46d275ff56ae36477ed7cc573d by Armin K to branch master. Repository: kwallet-pam Description --- Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script. Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket. v2: Incorporate changes mentioned by Martin, remove CMake version requirement increase. I tried using feature summary, but it wouldn't fail when I remove the executable. v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for extra-cmake-modules, which is now being used by this package. v4: Removed OnlyShownIn line from the desktop file as suggested by Xuetian and Martin. Diffs - CMakeLists.txt 8bd526e pam_kwallet_init PRE-CREATION pam_kwallet_init.desktop.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 25, 2016, 7:48 p.m.) Review request for Plasma and Martin Klapetek. Repository: kwallet-pam Description (updated) --- Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script. Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket. v2: Incorporate changes mentioned by Martin, remove CMake version requirement increase. I tried using feature summary, but it wouldn't fail when I remove the executable. v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for extra-cmake-modules, which is now being used by this package. v4: Removed OnlyShownIn line from the desktop file as suggested by Xuetian and Martin. Diffs (updated) - CMakeLists.txt 8bd526e pam_kwallet_init PRE-CREATION pam_kwallet_init.desktop.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 19-23
> > <https://git.reviewboard.kde.org/r/126843/diff/1/?file=435230#file435230line19>
> >
> > on syntax: else and endif don't need to repeat the condition any more.
> > Also we tend to use the lower case variants nowadays.
> >
> > on the feature: maybe better use add_feature_info and add it to the
> > feature list as a required one.
>
> Armin K. wrote:
> I was getting a syntax error without the conditional in else and endif
> statements. I'll try with lowercase ones. Thanks.
Still the same if I leave (SOCAT_EXECUTABLE) in else and endif statements (now
lowercase) =>
Parse error. Expected "(", got newline with text "
This is cmake-3.4.2
- Armin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/#review91445
---
On Jan. 22, 2016, 2:58 p.m., Armin K. wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126843/
> ---
>
> (Updated Jan. 22, 2016, 2:58 p.m.)
>
>
> Review request for Plasma and Martin Klapetek.
>
>
> Repository: kwallet-pam
>
>
> Description
> ---
>
> Currently, kwallet-pam is only usable when used in combination with plasma5,
> becaue the code that connects PAM created socket to kwalletd is in startkde
> script.
>
> Move that code into kwallet-pam itself and add an autostart desktop file so
> it can be used in plasma and outside of plasma (ie, gnome). Also add a check
> for socat executable, which is required to connect to the socket.
>
>
> Diffs
> -
>
> CMakeLists.txt 8bd526e
> pam_kwallet_init PRE-CREATION
> pam_kwallet_init.desktop.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126843/diff/
>
>
> Testing
> ---
>
> Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma,
> I was still asked for password in GNOME.
>
>
> Thanks,
>
> Armin K.
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 22, 2016, 7:02 p.m.) Review request for Plasma and Martin Klapetek. Repository: kwallet-pam Description (updated) --- Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script. Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket. v2: Incorporate changes mentioned by Martin, remove CMake version requirement increase. I tried using feature summary, but it wouldn't fail when I remove the executable. Diffs (updated) - CMakeLists.txt 8bd526e pam_kwallet_init PRE-CREATION pam_kwallet_init.desktop.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 22, 2016, 7:08 p.m.) Review request for Plasma and Martin Klapetek. Repository: kwallet-pam Description (updated) --- Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script. Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket. v2: Incorporate changes mentioned by Martin, remove CMake version requirement increase. I tried using feature summary, but it wouldn't fail when I remove the executable. v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for extra-cmake-modules, which is now being used by this package. Diffs (updated) - CMakeLists.txt 8bd526e pam_kwallet_init PRE-CREATION pam_kwallet_init.desktop.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 2 > > <https://git.reviewboard.kde.org/r/126843/diff/1/?file=435230#file435230line2> > > > > out of interest: why is the version raise required? I see all the packages that use extra-cmake-modules use that version. I thought it was a requirement. > On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > <https://git.reviewboard.kde.org/r/126843/diff/1/?file=435230#file435230line19> > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case variants nowadays. > > > > on the feature: maybe better use add_feature_info and add it to the > > feature list as a required one. I was getting a syntax error without the conditional in else and endif statements. I'll try with lowercase ones. Thanks. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91445 ------- On Jan. 22, 2016, 2:58 p.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126843/ > --- > > (Updated Jan. 22, 2016, 2:58 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: kwallet-pam > > > Description > --- > > Currently, kwallet-pam is only usable when used in combination with plasma5, > becaue the code that connects PAM created socket to kwalletd is in startkde > script. > > Move that code into kwallet-pam itself and add an autostart desktop file so > it can be used in plasma and outside of plasma (ie, gnome). Also add a check > for socat executable, which is required to connect to the socket. > > > Diffs > - > > CMakeLists.txt 8bd526e > pam_kwallet_init PRE-CREATION > pam_kwallet_init.desktop.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126843/diff/ > > > Testing > --- > > Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, > I was still asked for password in GNOME. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 19-23
> > <https://git.reviewboard.kde.org/r/126843/diff/1/?file=435230#file435230line19>
> >
> > on syntax: else and endif don't need to repeat the condition any more.
> > Also we tend to use the lower case variants nowadays.
> >
> > on the feature: maybe better use add_feature_info and add it to the
> > feature list as a required one.
>
> Armin K. wrote:
> I was getting a syntax error without the conditional in else and endif
> statements. I'll try with lowercase ones. Thanks.
>
> Armin K. wrote:
> Still the same if I leave (SOCAT_EXECUTABLE) in else and endif statements
> (now lowercase) =>
>
> Parse error. Expected "(", got newline with text "
>
> This is cmake-3.4.2
>
> Xuetian Weng wrote:
> it should looks like
>
> if (SOCAT_EXECUTABLE)
> message (STATUS "Found socat executable: ${SOCAT_EXECUTABLE}")
> else ()
> message (FATAL_ERROR "socat is required for pam_kwallet to work")
> endif ()
That seems to work, thanks.
- Armin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/#review91445
---
On Jan. 22, 2016, 2:58 p.m., Armin K. wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126843/
> ---
>
> (Updated Jan. 22, 2016, 2:58 p.m.)
>
>
> Review request for Plasma and Martin Klapetek.
>
>
> Repository: kwallet-pam
>
>
> Description
> ---
>
> Currently, kwallet-pam is only usable when used in combination with plasma5,
> becaue the code that connects PAM created socket to kwalletd is in startkde
> script.
>
> Move that code into kwallet-pam itself and add an autostart desktop file so
> it can be used in plasma and outside of plasma (ie, gnome). Also add a check
> for socat executable, which is required to connect to the socket.
>
>
> Diffs
> -
>
> CMakeLists.txt 8bd526e
> pam_kwallet_init PRE-CREATION
> pam_kwallet_init.desktop.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126843/diff/
>
>
> Testing
> ---
>
> Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma,
> I was still asked for password in GNOME.
>
>
> Thanks,
>
> Armin K.
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
> On Jan. 22, 2016, 9:33 p.m., Xuetian Weng wrote: > > pam_kwallet_init.desktop.cmake, line 7 > > <https://git.reviewboard.kde.org/r/126843/diff/3/?file=435311#file435311line7> > > > > Why limit to these desktop anyway? I don't see why this is necessary. > > (e.g. why not lxqt?) Hmm, I copied that line from baloo_file.desktop. I suppose it should be safe to remove it entirely, no? - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91457 --- On Jan. 22, 2016, 7:08 p.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126843/ > --- > > (Updated Jan. 22, 2016, 7:08 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: kwallet-pam > > > Description > --- > > Currently, kwallet-pam is only usable when used in combination with plasma5, > becaue the code that connects PAM created socket to kwalletd is in startkde > script. > > Move that code into kwallet-pam itself and add an autostart desktop file so > it can be used in plasma and outside of plasma (ie, gnome). Also add a check > for socat executable, which is required to connect to the socket. > > v2: Incorporate changes mentioned by Martin, remove CMake version requirement > increase. > > I tried using feature summary, but it wouldn't fail when I remove the > executable. > > v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for > extra-cmake-modules, which is now being used by this package. > > > Diffs > - > > CMakeLists.txt 8bd526e > pam_kwallet_init PRE-CREATION > pam_kwallet_init.desktop.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126843/diff/ > > > Testing > --- > > Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, > I was still asked for password in GNOME. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 126843: Make kwallet-pam usable outside of Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- Review request for Plasma and Martin Klapetek. Repository: kwallet-pam Description --- Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script. Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket. Diffs - CMakeLists.txt 8bd526e pam_kwallet_init PRE-CREATION pam_kwallet_init.desktop.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/ --- (Updated Sept. 22, 2015, 8:23 a.m.) Status -- This change has been discarded. Review request for Plasma and David Faure. Repository: plasma-workspace Description --- KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing plasma-workspace git master to depend on yet unreleased version of KDE Frameworks to build. David Faure has suggested to use fix like this one until at least Frameworks 5.15 have been released. I don't have commit access, so someone needs to commit this for me. Diffs - applets/icon/plugin/icon_p.cpp 97af67a Diff: https://git.reviewboard.kde.org/r/125187/diff/ Testing --- It builds. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. > > Aleix Pol Gonzalez wrote: > @Ben: Really? Why? Where was this discussed? > > Martin Gräßlin wrote: > @Ben: where should libraries like kwayland and kdecoration go then? They > do not fit requirements of frameworks but might be useable to applications > (kwayland is a must have library for any wayland integration). > > Ben Cooksley wrote: > That has yet to be resolved. Likely another layer which will be released > as needed by Applications / Plasma which sits in between Frameworks and them > will be added I suspect. No binary compatibility commitments, same licensing > rules as Applications / Plasma, just a logically separate product so it > doesn't cause dependency problems. I don't expect too many libraries or > runtime components to end up there (Dr Konqi might perhaps?). > > Martin Gräßlin wrote: > Honestly: I don't see the point in that except of making everything more > complicated (yet another product which has a dedicated release cycle). If > applications want to depend on workspace libraries: that's fine. They know > what it means. We shouldn't prevent "stupid things" in the CI system. If this patch is to be discarded, kde frameworks dep should be raised to 5.15, because it won't compile with 5.14 (which it currently requires) without this change. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 12, 2015, 10:14 a.m., David Edmundson wrote: > > We depend on git master of frameworks in Plasma master quite often, and our > > build instructions for Plasma include frameworks. > > > > Is this causing a problem somewhere? Well, I just upgraded to newly released frameworks 5.14, which is the required dependency for plasma-workspace and the build failed. At that time, frameworks weren't bumped to 5.15 and the dep couldn't be increased. I wanted to backport the method to my local kconfig build, but David Faure advised me against doing so and instead writing this patch since the class is one liner, so the dep doesn't need to be bumped again. The patch is trivial, and can be reverted once frameworks 5.15 have been released. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85240 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125187: Stop requiring Frameworks 5.15
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/ --- Review request for Plasma and David Faure. Repository: plasma-workspace Description --- KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing plasma-workspace git master to depend on yet unreleased version of KDE Frameworks to build. David Faure has suggested to use fix like this one until at least Frameworks 5.15 have been released. I don't have commit access, so someone needs to commit this for me. Diffs - applets/icon/plugin/icon_p.cpp 97af67a Diff: https://git.reviewboard.kde.org/r/125187/diff/ Testing --- It builds. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/ --- (Updated April 19, 2015, 7:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- Simply add 5 as a suffix to avoid conflicts with KDE 4 version which is shipped in KDE-Runtime which isn't going away any time now. Diffs - thumbnail/CMakeLists.txt e9ab79b thumbnail/jpegcreator.cpp de4902b thumbnail/jpegcreatorsettings.kcfg 8f68f46 thumbnail/jpegcreatorsettings.kcfgc 3f6cdab thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121086/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4
On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: do you have commit access? No, I don't. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572 --- On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- (Updated Nov. 9, 2014, 4:10 p.m.) Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- KDE-Runtime already provides libmolletnetwork, so lets rename this one to include 5 as a suffix since many apps outside of KDE still depend on KDE-Runtime. Diffs - network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/ --- Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- Simply add 5 as a suffix to avoid conflicts with KDE 4 version which is shipped in KDE-Runtime which isn't going away any time now. Diffs - thumbnail/CMakeLists.txt e9ab79b thumbnail/jpegcreator.cpp de4902b thumbnail/jpegcreatorsettings.kcfg 8f68f46 thumbnail/jpegcreatorsettings.kcfgc 3f6cdab thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121086/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- KDE-Runtime already provides libmolletnetwork, so lets rename this one to include 5 as a suffix since many apps outside of KDE still depend on KDE-Runtime. Diffs - network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
