Re: Use user wallpaper for dm, splashscreen and locksreen
Hello, Quoting Martin Graesslin mgraess...@kde.org: The idea to use the configured wallpaper falls short in a few ways: * It can only work with image, but not with animated, marble or whatever wallpaper plugin Image plugin probably is the most used wallpaper plugin, so it would cover a lot of cases. Moreover we can save a static screenshot of it that can be displayed. * it cannot handle the multi screen case. We can save a wallpaper for each screen. * we would need to know the activity before kactivity manager is started. Especially the login manager cannot know which user will log in, before the user logged in. Everytime the activity is switched we can save the wallpaper path to a configuration file. The login manager already knows the last user that logged in so it can display the right wallpaper. As soon a user is clicked or typed the wallpaper can be changed. In the worst case a default image should be displayed. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Moving screen locking away from krunner
Hello, I think that screen locking should be moved away from krunner for some reasons: 1) When krunner crashes screen locking stops to work, an always working screen locking is really important for security and privacy reasons. 2) it seems that screen locking doesn't work while running plasma netbook shell (krunner is not running in plasma netbook). 3) I don't see any logical reason about why screen locking should be there. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving screen locking away from krunner
Hello, Quoting Marco Martin notm...@gmail.com: in 4.10 is moved in ksmserver Nice, I missed that change. Is it possible to backport any fix for plasma-netbook? Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: How to access calendar using javascript?
Hello, Quoting Kevin Krammer kram...@kde.org: Would be great if you could CCMAIL kde-...@kde.org in the commit? Please tell me if you have any requirement for kde pim :) Anyway I will CC as son as I commit. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: How to access calendar using javascript?
Hello, Quoting John Layt jl...@kde.org: Please note that kdelibs is closed for new features, bugfixes only are allowed. Any new widgets will need to be Plasma only until Frameworks 5. It will be a plasma QML component so it will go to kde-runtime. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Events via Plasma Clock/Calendar
Hello, Quoting Daniel Kreuter daniel.kreute...@googlemail.com: John Layt mentioned on planet.kde.org in his blog post about Fake Academy, that the users would like to see the PIM events in the plasma calendar / clock. I would like to work on that feature. I will read more about it in wiki this evening when I come from work. Be aware that calendar will be subject to several changes, please contact me if you want to discuss about it. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: mailing list disclaimer in every source file
Hello, Quoting Martin Graesslin mgraess...@kde.org: On Monday 02 July 2012 18:16:53 Davide Bettio wrote: Hello, Sometimes it happens that somone writes to me to ask something releated to plasma development. As a reply I usually point him to the plasma mailing list, that's not a problem for me but there are some plasma contributors that are not reachable anymore. That might be a problem on the communication side so I think that we should add a notice to every source file after the copyright disclaimer that states that the best thing to ask anything related to plasma should be to send a mail to the plasma mailing list. what gives you the feeling that people send you the mail because of the license header in the source code? They tell me that or they send me an email on something that I've not been contributing to for a long time (so they probably didn't take a look to the git history) and that's the most likely reason. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: How to access calendar using javascript?
Hello, I've created the current calendar widget, my initial intention was to review it and to move it to kdelibs but I didn't so the API isn't meant to be used by anyone. If you don't mind to wait few days I will commit the QML implementation that I'm writing. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: About Krunner code
Hello, Quoting Mylena Reis rmyl...@ufpa.br: Good morning, I am a student of computer engineering, and I want to add a voice synthesizer in the KRunner code, but can not find the user input could help me find? It sounds to be a great project to me, anyway I think you should ask this to the plasma mailing list that is the best place for any plasma related question. Anyway if you need some help you can find me on IRC during the weekend or after 9 PM CET. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: libplasma2 and QtSvg
Hi, On 05/17/11 04:09, todd rme wrote: On Mon, May 16, 2011 at 7:19 PM, Alexis Ménard men...@kde.org wrote: On Fri, May 13, 2011 at 9:18 PM, Davide Bettio bet...@kde.org wrote: Hi, What about performances? Well unless we start hacking it, we can't really tell. But in the web context, SVG renders pretty fast. I think the concern is more the overhead from loading all of webkit just for rendering SVGs, rather than the speed of the rendering. webkit is already a libplasma dependency and it will replace everywhere (or almost everywhere) KHTML soon or later. so the point is still about performances. Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Deprecate KLineEdit::clickMessage
On May 14, 2011, 4:01 a.m., Shaun Reich wrote: Are you sure the behaviour for the Qt method 100% equivalent to the current? I ask this because now that the deprecated method forwards to it, naturally it's quite important to make sure nothing gets fscked up. Nicolas Alvarez wrote: Someone in #kde-devel tried it a little ago. Apparently one of them renders the placeholder text in italics and the other doesn't (don't remember which). (Also, using *both* causes both to draw, one unreadably over the other) Aaron J. Seigo wrote: the KDE one does it in italics. and this really should be rendered by the style as it is platform dependent: iirc Mac and KDE does it italics, Windows doesn't. Christoph Feck wrote: Right now, the decision whether to use italics is made by the language. The reason is given in the source code. The other issue that I see is that QTextEdit does not support it yet, so there would be an inconsistency if we don't make sure both use the same italics decision and color choice. I think that we should mark clickMessage as deprecated since now, the italic issue can be fixed in Qt in the meantime. - Davide --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101360/#review3308 --- On May 14, 2011, 12:59 a.m., Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101360/ --- (Updated May 14, 2011, 12:59 a.m.) Review request for kdelibs and Plasma. Summary --- Since Qt 4.7 QLineEdit::setPlaceholderText is available so KLineEdit::clickMessage should be deprecated. I kept clickMessage as not deprecated in plasma/widgets/lineedit but now is using placeholderText. Diffs - kdeui/widgets/klineedit.h 909d1f7 kdeui/widgets/klineedit.cpp 0dd3690 plasma/widgets/lineedit.cpp 09c0c66 Diff: http://git.reviewboard.kde.org/r/101360/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: libplasma2 and QtSvg
Hi, On 05/13/11 15:39, Alexis Ménard wrote: To me the solution lies in WebKit, I asked if the API was stable and it seems that yes it's pretty good. So if we have an interest (which I believe we do a lot), then we should make the QtSvg on top of WebKit API happens. :D. What about performances? Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Deprecate KLineEdit::clickMessage
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101360/ --- Review request for kdelibs and Plasma. Summary --- Since Qt 4.7 QLineEdit::setPlaceholderText is available so KLineEdit::clickMessage should be deprecated. I kept clickMessage as not deprecated in plasma/widgets/lineedit but now is using placeholderText. Diffs - kdeui/widgets/klineedit.h 909d1f7 kdeui/widgets/klineedit.cpp 0dd3690 plasma/widgets/lineedit.cpp 09c0c66 Diff: http://git.reviewboard.kde.org/r/101360/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
libplasma2 and QtSvg
Hi, As you can see here [1] QtSvg has been marked as deprecated. Do we have any plan about it? [1] http://labs.qt.nokia.com/2011/05/12/qt-modules-maturity-level-the-list Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Mobile and GSOC
Hi, This mail is about two topics: gsoc and mobile. Firstly, I am going to explain to you what I've been doing recently and what goals I have reached. I've started to work on the mobile stack since I've written a QML demo application called mobile dolphin, since that day I've been working on several mobile apps including: * phonebook application (that stores contacts on akonadi) * phone dialer * phone management application (which works as PIN requester/active calls management, etc...) * signal strength applet * mobile operator name applet Actually all the code is working with ofono/ofono-qt and phonesim but it should work on real hardware without any change. All the code is available on plasma-mobile (mobilephone and apps branches). I would like to continue to work on this project as a gsoc project. During the gsoc I plan to improve existing applications and to write other required applications (sms, calls register, etc...) Any comment or advice is welcome :) Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Mobile and GSOC
Hi, On 03/27/11 21:24, Marco Martin wrote: to me, as i explained before what is important is not much the applications per se, but how are written and how they use said mobile stack, i'm still not sure how many of those pieces should be plasmoids, how many separate applications 99% of phone management, *maybe* except the contact list should be managed by plasmoids, c++ ones is ok for what uses stuff that isn't worth doing a qml export., any needed custom window managementcan be given at the proper level Phone managment, dialing and messaging will require to link to several libraries, so I'm not sure if using only QML is a good idea but I'm rather sure that it's not a good idea to make bindings for each library. Anyway I'm currently using a QML view and a C++ logic approach and what I really need is a clean way to do that. for applications, i would like to see an unique way to do kapplications, that can access to kxmlguy kactions and uses only Package to access/load qml files. it's a bit a rant, but what i don't want to see other quick and dirty mobile applications. Currently all the quick and dirty stuff is kept in two different (and unmerged branches) and not in master, so we can remove all the apps without polluting the history. The quick and dirty approach has been useful to experiment and to explore how to implement things correctly. Anyway it's not clear to me how to implement apps correctly and we should define it as soon as possible. I think a good discussion on this point should be started. * phonebook application (that stores contacts on akonadi) * phone dialer * phone management application (which works as PIN requester/active calls management, etc...) why 3? (remember also the there you want as less running process as possible) The first and the second one can be merged for sure, I've divided the thing into 2 pieces because I've been experimenting with 2 different things. The phonebook view will be moved into a QML library and the dialer will use it. The phone managment application should start as soon as possible so the shell can start while the user is typing sim PIN. The phone managment application usually has no open window and it should be light weight. If the shell stop to work the user can answer to phone calls in any case. Anyway it can be merged easily into the shell if required. * signal strength applet * mobile operator name applet i think for the base case, it should be only a single applet that shows both, then if a distribution/vendor/someone wants to split it in two, that's fine I've decided to use two different applets because the signal strength usually is always displayed while the operator name sometimes is displayed on the desktop. I don't think we have enough space in the panel for both. Anyway I've forgot to mention that we have also a DataEngine called mobilenetworkengine. You can find it in the main branch as a fake DataEngine or in the mobilephone branch as a ofono based DataEngine. Actually all the code is working with ofono/ofono-qt and phonesim but it should work on real hardware without any change. All the code is available on plasma-mobile (mobilephone and apps branches). I would like to continue to work on this project as a gsoc project. During the gsoc I plan to improve existing applications and to write other required applications (sms, calls register, etc...) Any comment or advice is welcome :) this I think is really good, can you try to write an elaborate proposal, at least ~2 pages rather soon (you have until 8th april) Ok, sure I will. Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
tokamak V flights
Hi, The 2nd of may seems to be the best departure date. Is anybody leaving on the 2nd of may? Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Timer: one click to pause/resume, blinks when paused.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100521/#review1584 --- Please, revert this patch or fix it: * Currently single click doesn't seem to work * I don't think double click for reset is a good idea. - Davide On Feb. 2, 2011, 9:39 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100521/ --- (Updated Feb. 2, 2011, 9:39 a.m.) Review request for Plasma. Summary --- This patch does some little changes to Timer plasmoid: - Now it takes only one click to start, resume and pause it - It now blinks when paused, making it quicker to determine if it's paused or running - Double-click resets timer Diffs - applets/timer/timer.h d191fa3 applets/timer/timer.cpp a09aa4c Diff: http://git.reviewboard.kde.org/r/100521/diff Testing --- As it's a simple modification, I think that it brings no bugs (except by the fact that it says timeout when reseted with double-click). Thanks, Romário ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [RFC] Enforcing Compositing
Hi, On 02/20/11 13:38, Martin Gräßlin wrote: Hi all, sending this to both Plasma and KWin as the idea affects the complete workspace. Since 4.2 we have enabled OpenGL based compositing by default and I was wondering if in 4.7 we should go the next step: disabling the possibility to turn compositing off if supported. With Mesa 7.10 it seems that the driver problems (Mesa 7.8) which hit us in 4.5 are finally gone and our new compositor is performing much, much better than the one we have in 4.6. This means from a performance perspective I am optimistic that we can go such a way. This would imply the following changes * Remove the enable checkbox in the compositing KCM * Remove the suspend/resume compositing button in the same KCM * Remove the functionality checks - the heuristic is rather useless anyway * Disable unredirect fullscreen windows by default I can't see your pros about removing it. Is it your goal to improve effects KCM usability? Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [RFC] Enforcing Compositing
Hi, On 02/20/11 22:06, Martin Gräßlin wrote: I can't understand the point about removing enable/disable options. if we don't want to give the user the possibility to disable, we don't need an option to enable/disable. I don't see anything bad about having enable/disable options on the KCM. The only con that I'm aware of is that we have more checkboxes. Let's turn the question around: why should the user be able to enable or disable compositing? What would be a valid reason to do so? And keep in mind: with Wayland it will be impossible to turn off compositing, same in GNOME Shell, Unity and Mac OS X (don't know about Windows). The main reason is that buggy software is still around. Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [RFC] Enforcing Compositing
Hi, On 02/20/11 21:57, Martin Gräßlin wrote: No, while the KCM sucks it will still suck after those three options have been removed. It needs a proper redesign, but that is out of the scope of this thread ;-) I can't understand the point about removing enable/disable options. Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [RFC] Enforcing Compositing
Hi, On 02/20/11 22:25, Martin Gräßlin wrote: On Sunday 20 February 2011 22:18:16 Davide Bettio wrote: Hi, On 02/20/11 22:06, Martin Gräßlin wrote: I can't understand the point about removing enable/disable options. if we don't want to give the user the possibility to disable, we don't need an option to enable/disable. I don't see anything bad about having enable/disable options on the KCM. The only con that I'm aware of is that we have more checkboxes. Consider the button would not be there: would you see pro arguments to add one? Yes, currently at the computer lab in my university for an unknown reason I can't work with compositing enabled, so I had to disable it. The main reason is that buggy software is still around. And how do we get the buggy software fixed if we allow workarounds? We can't ask users to wait while the software gets fixed, they need to work so they may have to disable it while in the meantime someone is fixing the bug. Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: The Plasma team in Bilbao
Hi, It would be interesting if we plan to discuss about plasma in the education environment. If we are not going to do that I think that it might a bit useless. Anyway for me both places are good. Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: tokamak five
Hi, I've been busy recently with university and I'll continue to be away until the end of this semester in march. Anyway I would like to participate to the next tokamak. I think that the 17th week would be ok for me too. Netherlands is ok for me: it can be easily reached with a cheap ryanair flight (BGY - EIN is less than 60 €). Bye, Davide Bettio. signature.asc Description: OpenPGP digital signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Display applet context menu when the label hasn't any context menu to show.
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6009/ --- Review request for Plasma. Summary --- If there isn't any label context menu to show the event is ignored. It makes sense to show a context menu only when the text can be selected or when there is a link. This patch improves usability of applets which they have a lot of labels (like the weather plasmoid) or applets with huge labels (like the calculator). Diffs - trunk/KDE/kdelibs/plasma/widgets/label.cpp 1202069 Diff: http://svn.reviewboard.kde.org/r/6009/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9050 --- Should we apply this patch while waiting someone who fix this bug in Qt? - Davide On 2010-11-28 20:23:45, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/ --- (Updated 2010-11-28 20:23:45) Review request for Plasma and Stephen Kelly. Summary --- Text format of the note can't be changed while the note is empty, so I add a space and I change the text format. This work around is rather stupid but I don't have any nicer idea. Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire. Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 Diff: http://svn.reviewboard.kde.org/r/6005/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/ --- Review request for Plasma and Stephen Kelly. Summary --- Text format of the note can't be changed while the note is empty, so I add a space and I change the text format. This work around is rather stupid but I don't have any nicer idea. Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire. Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 Diff: http://svn.reviewboard.kde.org/r/6005/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4501 --- Nothing has happened recently, so can I assume that I can ship this patch? - Davide On 2010-03-09 13:00:26, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-09 13:00:26) Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- I've been using the frame plasmoid with this patch and everything works correctly and X11 doesn't freeze anymore while scaling huge pictures. There was only one regression on the resize size which now it's less realtime than before but it can be fixed with another patch (I think that I can get it working better than before). Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: merging screen edges settings.
On 2010-03-10 07:28:38, Martin Gräßlin wrote: Why do we still need prevent screen locking? It seems to do nothing, so I would say it can be removed completely. If you keep the mouse in a corner the screensaver will not start and the screen will not be locked. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/#review4441 --- On 2010-03-10 00:05:27, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/ --- (Updated 2010-03-10 00:05:27) Review request for Plasma, Martin Gräßlin and Lubos Lunak. Summary --- 1) Removed Advanced Button from screensaver kcm. 2) Screensaver screen edges settings have been merged with kwin screen edges settings. 3) Removed screensaver priority configuration: we assume that users don't need to change screensaver priority. Diffs - /trunk/KDE/kdebase/workspace/kcontrol/screensaver/CMakeLists.txt 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.h 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.cpp 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialogimpl.ui 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/screensaver.ui 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinscreenedges/main.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/lib/kwinglobals.h 1101220 /trunk/KDE/kdebase/workspace/kwin/options.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1101220 Diff: http://reviewboard.kde.org/r/3240/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: merging screen edges settings.
On 2010-03-10 19:44:48, Lubos Lunak wrote: Looks ok to me. One small nitpick: Please do not do Foo* foo = new Foo; foo-doSomething(); delete foo; The object can be normally allocated on the stack without risking a leak or requiring the extra work of dynamic allocation. right, we have the dpointer that points internally to the heap. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/#review4458 --- On 2010-03-10 00:05:27, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/ --- (Updated 2010-03-10 00:05:27) Review request for Plasma, Martin Gräßlin and Lubos Lunak. Summary --- 1) Removed Advanced Button from screensaver kcm. 2) Screensaver screen edges settings have been merged with kwin screen edges settings. 3) Removed screensaver priority configuration: we assume that users don't need to change screensaver priority. Diffs - /trunk/KDE/kdebase/workspace/kcontrol/screensaver/CMakeLists.txt 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.h 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.cpp 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialogimpl.ui 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/screensaver.ui 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinscreenedges/main.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/lib/kwinglobals.h 1101220 /trunk/KDE/kdebase/workspace/kwin/options.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1101220 Diff: http://reviewboard.kde.org/r/3240/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: merging screen edges settings.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/ --- Review request for Plasma, Martin Gräßlin and Lubos Lunak. Summary --- 1) Removed Advanced Button from screensaver kcm. 2) Screensaver screen edges settings have been merged with kwin screen edges settings. 3) Removed screensaver priority configuration: we assume that users don't need to change screensaver priority. Diffs - /trunk/KDE/kdebase/workspace/kcontrol/screensaver/CMakeLists.txt 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.h 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.cpp 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialogimpl.ui 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/screensaver.ui 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h 1101220 /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinscreenedges/main.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/lib/kwinglobals.h 1101220 /trunk/KDE/kdebase/workspace/kwin/options.cpp 1101220 /trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1101220 Diff: http://reviewboard.kde.org/r/3240/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
On 2010-03-08 11:47:49, Sebastian Kügler wrote: I'm not sure about this patch: - The loading of images in a thread is nice - The loads huge picture and keeps them in mem is not changed (in fact, it's worse now since QImage forces you to keep them in system memory, whereas QPixmaps can be stored on the graphics card) - It basically disables hardware acceleration of the image scaling, QImage vs. QPixmap With QPixmaps, we can blit into a smaller rect which is very fast, with QImage, we have to do the scaling in software and then convert it to a QPixmap to draw it. This happens on every resize, so it's a hot path and blocks direct user interaction. In my tests on different hardware (ATI, Intel, NVidia), the QPixmap based approach felt faster (smoother, more frames per second while resizing). The performance here depends on the painting backend used (image vs raster vs native) though, and thus per driver. Maybe we can only do the image loading in a thread (since that can potentially take quite long for large images), and keep a smaller copy (screen resolution?) stored in a QPixmap which is then used to resize. (If a size larger than our screen resolution is required, we can on-demand load the full image (4x3px if you wish ;)) and scale from that. (Rationale upscaling == bad, downscaling == OK, saving mem == good) The patch as it's now is not good enough IMO. We must do software scaling because loading a 4000x3000 pixmap into X11 and asking X11 to scale the pixmap is a bad idea and it freezes the whole X11 environment including plasma and kwin for at least a couple of seconds (that happpens on a recent nvidia quadro, and I wonder what happens on an ATI video card powered with buggy drivers). With this patch during resize paintInterface is called and the cached QPixmap is used, in the meantime another thread with a completely async behaviour scales the image. The loads huge picture and keeps them in mem is not changed (in fact, it's worse now since QImage forces you to keep them in system memory, whereas QPixmaps can be stored on the graphics card) Do you know how to load our image on graphics card memory without blocking everything? (don't forget that 4000x3000 px images are about 45 mb of raw ARGB data) And moreover what's the point of using video card memory since system memory is larger (think about laptops too) when moreover we don't need to use any video card feature? I can try anyway to reduce the huge in memory image footprint, but honestly I think that I should commit this patch before and then I can solve that problem. Anyway a solution might be to start after N seconds a thread with really low priority that replaces the huge in memory image with a screen-resolution-one (doing this task during image load and display process might be a bad idea). Maybe we can only do the image loading in a thread (since that can potentially take quite long for large images). This will prevent to freeze plasma during image loading but then X11 will be freezed anyway. I might try to improve also the behaviour using a thread with a bit lower priority than the default priority. Anyway don't forget that we are using software scaling also for wallpapers since KDE 4.0 and it works nicely. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4411 --- On 2010-03-08 02:27:47, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:27:47) Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION
Re: Review Request: frame plasmoid: image load and scaling with threads
On 2010-03-08 11:47:41, Sebastian Kügler wrote: /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 488 http://reviewboard.kde.org/r/3162/diff/3/?file=20458#file20458line488 Why is this disabled now? oh, sorry, I've forgot it. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4410 --- On 2010-03-08 02:27:47, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:27:47) Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
On 2010-03-08 11:47:49, Sebastian Kügler wrote: /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 255 http://reviewboard.kde.org/r/3162/diff/3/?file=20458#file20458line255 This is a hot path (it gets called whenever the applet resizes, which can be quite often during drags). Doing a QImage - QPixmap conversion here is not a good idea. The QPixmap-based version would just blit the pixmap into a smaller rect which is fast (it can be hw-accelerated) We have to convert the QImage to QPixmap somewhere and we can't do that in a different thread. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4411 --- On 2010-03-08 02:27:47, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:27:47) Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
On 2010-03-08 11:47:49, Sebastian Kügler wrote: I'm not sure about this patch: - The loading of images in a thread is nice - The loads huge picture and keeps them in mem is not changed (in fact, it's worse now since QImage forces you to keep them in system memory, whereas QPixmaps can be stored on the graphics card) - It basically disables hardware acceleration of the image scaling, QImage vs. QPixmap With QPixmaps, we can blit into a smaller rect which is very fast, with QImage, we have to do the scaling in software and then convert it to a QPixmap to draw it. This happens on every resize, so it's a hot path and blocks direct user interaction. In my tests on different hardware (ATI, Intel, NVidia), the QPixmap based approach felt faster (smoother, more frames per second while resizing). The performance here depends on the painting backend used (image vs raster vs native) though, and thus per driver. Maybe we can only do the image loading in a thread (since that can potentially take quite long for large images), and keep a smaller copy (screen resolution?) stored in a QPixmap which is then used to resize. (If a size larger than our screen resolution is required, we can on-demand load the full image (4x3px if you wish ;)) and scale from that. (Rationale upscaling == bad, downscaling == OK, saving mem == good) The patch as it's now is not good enough IMO. Davide Bettio wrote: We must do software scaling because loading a 4000x3000 pixmap into X11 and asking X11 to scale the pixmap is a bad idea and it freezes the whole X11 environment including plasma and kwin for at least a couple of seconds (that happpens on a recent nvidia quadro, and I wonder what happens on an ATI video card powered with buggy drivers). With this patch during resize paintInterface is called and the cached QPixmap is used, in the meantime another thread with a completely async behaviour scales the image. The loads huge picture and keeps them in mem is not changed (in fact, it's worse now since QImage forces you to keep them in system memory, whereas QPixmaps can be stored on the graphics card) Do you know how to load our image on graphics card memory without blocking everything? (don't forget that 4000x3000 px images are about 45 mb of raw ARGB data) And moreover what's the point of using video card memory since system memory is larger (think about laptops too) when moreover we don't need to use any video card feature? I can try anyway to reduce the huge in memory image footprint, but honestly I think that I should commit this patch before and then I can solve that problem. Anyway a solution might be to start after N seconds a thread with really low priority that replaces the huge in memory image with a screen-resolution-one (doing this task during image load and display process might be a bad idea). Maybe we can only do the image loading in a thread (since that can potentially take quite long for large images). This will prevent to freeze plasma during image loading but then X11 will be freezed anyway. I might try to improve also the behaviour using a thread with a bit lower priority than the default priority. Anyway don't forget that we are using software scaling also for wallpapers since KDE 4.0 and it works nicely. anyway the frame behaviour during resize can be improved a lot but honestly I would prefer to split my work in several small pieces, I don't like huge patches. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4411 --- On 2010-03-08 02:27:47, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:27:47) Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE
Re: Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 14:35:28.993575) Review request for Plasma. Changes --- The preview monitor in the configuration UI is enabled again. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
On 2010-03-08 18:50:47, Aaron Seigo wrote: /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp, lines 186-190 http://reviewboard.kde.org/r/3162/diff/4/?file=20476#file20476line186 as far as i can see, the loader is never deleted. it emits its signal, pictureLoaded is called, and then the object is dropped and just sits there in memory. QThreadPool deletes the QRunnable automatically if autoDelete() returns true (the default). Use setAutoDelete() to change the auto-deletion flag. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4423 --- On 2010-03-08 14:35:28, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 14:35:28) Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 20:02:58.196250) Review request for Plasma. Changes --- * Changed as requested by aseigo. * Added missing connect. * Added compatibility with old dataengines. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 20:19:25.175491) Review request for Plasma. Changes --- * Fixed a little mistake with svn ;) * Removed some kate generated garbage spaces Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:24:36.633893) Review request for Plasma. Changes --- this should be the last version of the patch. I removed smooth scaling from the configuration ui. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:27:47.528025) Review request for Plasma. Changes --- sorry, I've forgot to remove m_smoothScaling. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: frame plasmoid: image load and scaling with threads
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- Review request for Plasma. Summary --- First of all: **This is a preview of the patch** I'm still working on it but I need some advices. Picture Frame does 2 really bad things (when used with huge images): * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps * plasma is blocked while the image is scaled As side effect also X11 freezes. This patch solves both issues using threads. I think that we should remove smooth scaling option from our configuration UI. what do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 Diff: http://reviewboard.kde.org/r/3162/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Plasma::Wallpaper: use a QRunnable thread to save the image in the cache.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3123/ --- Review request for Plasma. Summary --- This patch avoid to block plasma while the image is compressed to png and saved on disk. Diffs - /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1098954 Diff: http://reviewboard.kde.org/r/3123/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Added support to multiple render threads to Plasma::Wallpaper.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/ --- Review request for Plasma. Summary --- This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. Diffs - /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1097236 /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1097236 Diff: http://reviewboard.kde.org/r/3092/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added support to multiple render threads to Plasma::Wallpaper.
On 2010-03-03 17:05:34, Aaron Seigo wrote: This patch adds support to multiple render threads in Plasma::Wallpaper sounds like it could be useful; is there a use case in particular that you were working on that this improves? and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. what was the fix? (i didn't notice it in the patch :) Davide Bettio wrote: The case is when plasma has to render more than one image in the same time (when rendering N wallpaper for N activities when the cache is empty), multithreading is here for free with few changes. The bug has been happening with cache on tmpfs, so the cache is erased during every reboot. The old code doesn't work when there are more than one render request (the previous request was always replaced with the new one), the fix is the queue. Beat Wolf wrote: does this potentialy fix the black wallpaper bug on multiscreen setups? just wondering I don't know, buy me another monitor and I can tell you... or just try the patch ;) - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/#review4348 --- On 2010-03-03 15:47:34, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/ --- (Updated 2010-03-03 15:47:34) Review request for Plasma. Summary --- This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. Diffs - /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1097236 /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1097236 Diff: http://reviewboard.kde.org/r/3092/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added support to multiple render threads to Plasma::Wallpaper.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/ --- (Updated 2010-03-03 23:51:38.984773) Review request for Plasma. Changes --- changed everything as requested by aaron. Summary --- This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. Diffs (updated) - /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1098381 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp 1098381 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread_p.h 1098381 /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1098381 Diff: http://reviewboard.kde.org/r/3092/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added support to multiple render threads to Plasma::Wallpaper.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/ --- (Updated 2010-03-03 23:55:34.353109) Review request for Plasma. Changes --- removed some useless spaces... Summary --- This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. Diffs (updated) - /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1098381 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp 1098381 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread_p.h 1098381 /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1098381 Diff: http://reviewboard.kde.org/r/3092/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added support to multiple render threads to Plasma::Wallpaper.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/ --- (Updated 2010-03-04 00:54:48.317782) Review request for Plasma. Changes --- Now it should be ok. Summary --- This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. Diffs (updated) - /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1098620 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp 1098620 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread_p.h 1098620 /trunk/KDE/kdelibs/plasma/wallpaper.h 1098620 /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1098620 Diff: http://reviewboard.kde.org/r/3092/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added support to multiple render threads to Plasma::Wallpaper.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3092/ --- (Updated 2010-03-04 00:56:26.290142) Review request for Plasma. Changes --- kate helps me to put garbage spaces around... Summary --- This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache. Diffs (updated) - /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1098620 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp 1098620 /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread_p.h 1098620 /trunk/KDE/kdelibs/plasma/wallpaper.h 1098620 /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1098620 Diff: http://reviewboard.kde.org/r/3092/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Ported Plasma::WebView to KGraphicsWebView
On 2010-02-17 12:54:30, Marco Martin wrote: /trunk/KDE/kdelibs/plasma/widgets/webview.cpp, line 174 http://reviewboard.kde.org/r/2990/diff/1/?file=19582#file19582line174 thing that we were talking about the other day: are you sure nw that page() and mainFrame() are always valid? yes, I've checked QtWebKit code and they are always valid. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2990/#review4192 --- On 2010-02-17 02:46:46, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2990/ --- (Updated 2010-02-17 02:46:46) Review request for Plasma. Summary --- This patch replaces all the old code that uses directly KWebPage with new code that uses KGraphicsWebView. Diffs - /trunk/KDE/kdelibs/plasma/widgets/webview.h 1090797 /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1090803 /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview_p.h PRE-CREATION /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1090803 /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/2990/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: New: Plasma::ToolButton::setDown(bool)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2645/ --- Review request for Plasma. Summary --- This patch adds setDown to ToolButton. Diffs - /trunk/KDE/kdelibs/plasma/widgets/toolbutton.h 1073246 /trunk/KDE/kdelibs/plasma/widgets/toolbutton.cpp 1074900 Diff: http://reviewboard.kde.org/r/2645/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: New: Plasma::ToolButton::setDown(bool)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2645/ --- (Updated 2010-01-18 22:39:23.687257) Review request for Plasma. Changes --- Removed useless spaces... Summary --- This patch adds setDown to ToolButton. Diffs (updated) - /trunk/KDE/kdelibs/plasma/widgets/toolbutton.h 1073246 /trunk/KDE/kdelibs/plasma/widgets/toolbutton.cpp 1074900 Diff: http://reviewboard.kde.org/r/2645/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Ported KTimeTracker to KNotification
On 2009-09-21 13:41:29, Thorsten Staerk wrote: Good to see you working on my baby ktimetracker. Let's have a discussion on irc. Davide Bettio wrote: ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find me in #plasma. Thorsten Staerk wrote: Did not work - most important question: What does your patch do? What issues do you have? Which are fixed? Thorsten Staerk wrote: In bug 208099 https://bugs.kde.org/show_bug.cgi?id=208099 I recommend to test your patch, but it does not build cleanly. Can you write a clean patch please? This patch replaces KSysTrayIcon (that is deprecated) with KNotificationItem. For more information you should read Aaaron and Notmart blogs about it. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2411 --- On 2009-09-19 20:16:41, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/ --- (Updated 2009-09-19 20:16:41) Review request for KDE PIM and Plasma. Summary --- KTimeTracker has been ported to KNotificationItem but I still have few issues that I've corrected with #if 0. It's not really clear to me how the notification works when KTimeTracker is a KPart. Anyway please don't use XPM pixmaps, use icons. Diffs - /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122 /trunk/KDE/kdepim/ktimetracker/tray.h 1024122 /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122 Diff: http://reviewboard.kde.org/r/1653/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
On 2009-09-22 05:12:41, David Jarvie wrote: As you say, these changes are incomplete. The way that quitting is handled (whether to quit or not, depending on which windows are open) is a very important feature in KAlarm, and looking at the patch, I'm not convinced that it handles this properly. I don't have time currently to look at this in detail, but please don't commit yet until everything has been fixed and tested. I will not commit anything until I get your ship it. :) On 2009-09-22 05:12:41, David Jarvie wrote: /trunk/KDE/kdepim/kalarm/kalarmapp.cpp, line 753 http://reviewboard.kde.org/r/1655/diff/1/?file=11686#file11686line753 This line shouldn't be removed unless there's some alternative mechanism for showing the window. you can't show()/hide() it. you can only change the status from passive to active or needsattention. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/#review2414 --- On 2009-09-19 21:43:30, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-19 21:43:30) Review request for KDE PIM and Plasma. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:23:39.660245) Review request for KDE PIM and Plasma. Changes --- it seems that show() and hide() methods are required... Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Attempt to port KAlarm to KNotificationIcon
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:24:27.885530) Review request for KDE PIM, Plasma and Marco Martin. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Ported KTimeTracker to KNotification
On 2009-09-21 13:41:29, Thorsten Staerk wrote: Good to see you working on my baby ktimetracker. Let's have a discussion on irc. ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find me in #plasma. - Davide --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2411 --- On 2009-09-19 20:16:41, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/ --- (Updated 2009-09-19 20:16:41) Review request for KDE PIM and Plasma. Summary --- KTimeTracker has been ported to KNotificationItem but I still have few issues that I've corrected with #if 0. It's not really clear to me how the notification works when KTimeTracker is a KPart. Anyway please don't use XPM pixmaps, use icons. Diffs - /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122 /trunk/KDE/kdepim/ktimetracker/tray.h 1024122 /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122 Diff: http://reviewboard.kde.org/r/1653/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Ported KTimeTracker to KNotification
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/ --- Review request for KDE PIM and Plasma. Summary --- KTimeTracker has been ported to KNotificationItem but I still have few issues that I've corrected with #if 0. It's not really clear to me how the notification works when KTimeTracker is a KPart. Anyway please don't use XPM pixmaps, use icons. Diffs - /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122 /trunk/KDE/kdepim/ktimetracker/tray.h 1024122 /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122 Diff: http://reviewboard.kde.org/r/1653/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Attempt to port KAlarm to KNotificationIcon
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- Review request for KDE PIM and Plasma. Summary --- I've attempted to port KAlarm to KNotificationItem. I don't know how to port some pieces of code. Probably I will post a new patch soon. Diffs - /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 Diff: http://reviewboard.kde.org/r/1655/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Replaced kopete systray with NotificationItem
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1635/ --- Review request for Kopete and Plasma. Summary --- This patch replaces KSysTray with KNotificationItem. Diffs - /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1025366 /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 1025366 /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 1025366 Diff: http://reviewboard.kde.org/r/1635/diff Testing --- I've been using kopete with this patch for some hours... Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Moving desktop theme to system settings (phase 2)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1427/ --- Review request for Plasma. Summary --- Added plasma desktop theme selector to style module. Diffs - /trunk/KDE/kdebase/workspace/kcontrol/style/CMakeLists.txt 1016378 /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.h 1016378 /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1016378 Diff: http://reviewboard.kde.org/r/1427/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Moving theme configuration to system settings.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1404/ --- Review request for Plasma. Summary --- This patch removes theme configuration from backround dialog. Diffs - /trunk/KDE/kdebase/workspace/plasma/shells/desktop/BackgroundDialog.ui 999195 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.h 999195 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp 999195 Diff: http://reviewboard.kde.org/r/1404/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Ported akonaditray to KNotificationAreaItem
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/618/ --- Review request for KDE PIM, Plasma and Tom Albers. Summary --- Ported akonaditray to KNotificationAreaItem. Diffs - /trunk/KDE/kdepim/akonadi/tray/CMakeLists.txt 957204 /trunk/KDE/kdepim/akonadi/tray/dock.h 957204 /trunk/KDE/kdepim/akonadi/tray/dock.cpp 957204 /trunk/KDE/kdepim/akonadi/tray/main.cpp 957204 Diff: http://reviewboard.kde.org/r/618/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: moved moonphase code to time dataengine.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/633/ --- (Updated 2009-04-26 16:31:48.500327) Review request for Plasma, Aaron Seigo and Petri Damstén. Summary (updated) --- moved moonphase code to time dataengine from luna plasmoid/moonphase kicker applet (as requested by petri). phases.cpp is missing but it comes from the plasmoid. I will to remove all that useless kDebug messages. Diffs - /trunk/KDE/kdebase/workspace/plasma/dataengines/time/moonphase.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/dataengines/time/moonphase.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 959712 /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 959712 Diff: http://reviewboard.kde.org/r/633/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmoïd Notes: Solution for the bug 171795. Possibility to format the text.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/567/#review966 --- Screenshot: Screenshot2 http://reviewboard.kde.org//r/567/#scomment30 it looks ugly. Screenshot: Screenshot1 http://reviewboard.kde.org//r/567/#scomment31 it looks ugly. Screenshot: Screenshot3 http://reviewboard.kde.org//r/567/#scomment32 I think that it is the right way to implement this thing. - Davide On 2009-04-19 02:21:49, Madlyn MERCK wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/567/ --- (Updated 2009-04-19 02:21:49) Review request for Plasma. Summary --- This patch offers the possibility to format the text of the note. It's a solution of the bug 171795 (https://bugs.kde.org/show_bug.cgi?id=171795). You can make your text bold, italic, strike-through... You can show format options with the button '+' or with the text's popupmenu. If you notice any problem with this new option just tell me. This addresses bug 171795. https://bugs.kde.org/show_bug.cgi?id=171795 Diffs - trunk/KDE/kdeplasma-addons/applets/notes/notes.h 951942 trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 951942 Diff: http://reviewboard.kde.org/r/567/diff Testing --- Screenshots --- Screenshot1 http://reviewboard.kde.org/r/567/s/104/ Screenshot2 http://reviewboard.kde.org/r/567/s/105/ Screenshot3 http://reviewboard.kde.org/r/567/s/106/ Thanks, Madlyn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Ported strigi service tray icon to KNotificationAreaItem.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/599/ --- Review request for Plasma. Summary --- Ported strigi service tray icon to KNotificationAreaItem. Diffs - /trunk/KDE/kdebase/runtime/nepomuk/services/strigi/CMakeLists.txt 955378 /trunk/KDE/kdebase/runtime/nepomuk/services/strigi/strigiservice.cpp 955378 /trunk/KDE/kdebase/runtime/nepomuk/services/strigi/systray.h 955378 /trunk/KDE/kdebase/runtime/nepomuk/services/strigi/systray.cpp 955378 Diff: http://reviewboard.kde.org/r/599/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Ported kwalletmanager tray icon to KNotificationAreaItem.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/600/ --- Review request for Plasma. Summary --- Ported kwalletmanager tray icon to KNotificationAreaItem. Diffs - /trunk/KDE/kdeutils/kwallet/CMakeLists.txt 955378 /trunk/KDE/kdeutils/kwallet/kwalletmanager.h 955378 /trunk/KDE/kdeutils/kwallet/kwalletmanager.cpp 955378 Diff: http://reviewboard.kde.org/r/600/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Ported korgac systray to KNotificationAreaItem
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/601/ --- Review request for KDE PIM and Plasma. Summary --- Ported korgac systray to KNotificationAreaItem Diffs - /trunk/KDE/kdepim/korganizer/korgac/CMakeLists.txt 955378 /trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.h 955378 /trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.cpp 955378 /trunk/KDE/kdepim/korganizer/korgac/koalarmclient.cpp 955378 Diff: http://reviewboard.kde.org/r/601/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Ported kopete systray icon to KNotificationAreaItem.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/603/ --- Review request for Kopete and Plasma. Summary --- Ported kopete systray icon to KNotificationAreaItem. Diffs - /trunk/KDE/kdenetwork/kopete/kopete/CMakeLists.txt 955509 /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 955509 /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 955509 /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 955509 Diff: http://reviewboard.kde.org/r/603/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop settings dialog ideas
Hi, On Sunday 05 April 2009 12:51:48 Emdek wrote: Yes of course, this is mainly for users that were already using it in the past. But also for users who want to perform some actions connected to the desktop in one central place but without launching additional application. No, they aren't connected to the desktop. they are more connected to the concept of display and plasma isn't connected to the concept of display. Maybe this is not perfect solution and like everything it has drawbacks but fighting with users habits is often very hard. but you can get long term benefits. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: solarposition dataengine moved to kdereview
Hi, On Tuesday 07 April 2009 08:55:19 Petri Damstén wrote: I'll add this to feature plan for 4.3. I think moon phase and position would be nice here too. I agree with you, I can move from luna to that dataengine moonphase code too. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop settings dialog ideas
Hi, On Saturday 04 April 2009 22:51:54 Emdek wrote: First idea, easier to do, is to add back to dialog pages with settings of screensaver and power saving (maybe there were also other, I don't remember) like in KDE3. This location was logical and they were easier to reach in few clicks. This idea is described in wish #185153. The main advantage of your idea is that users are used to a similar UI so it might be more usable for users that are already used to Windows or KDE 4. On the other hand this paradigm was introduced by microsoft a lot of time ago and it isn't logical for us. We are just used to it. Plasma team is working hard to push innovation to the desktop, and breaking with the (broken) past is part of our evolution. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: IconWidget DragDrop visual feedback.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/507/ --- Review request for Plasma. Summary --- Use the hover background also for the dragdrop. This addresses bug 110952. https://bugs.kde.org/show_bug.cgi?id=110952 Diffs - trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 948167 trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 948167 Diff: http://reviewboard.kde.org/r/507/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Makes the configuration of the comic plasmoid easier to use
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/#review800 --- Screenshot: http://reviewboard.kde.org//r/461/#scomment25 You should move it on top of the list. Screenshot: http://reviewboard.kde.org//r/461/#scomment26 I think that you may try to add a checkbox to enable autoswitch. - Davide On 2009-03-29 04:33:47, Matthias Fuchs wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/ --- (Updated 2009-03-29 04:33:47) Review request for Plasma and Davide Bettio. Summary --- Whenever the user ticks Use Tabs the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation. I'm not sure if I should add Select All-, Deselect All-Buttons. What do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 946187 Diff: http://reviewboard.kde.org/r/461/diff Testing --- Screenshots --- http://reviewboard.kde.org/r/461/s/82/ http://reviewboard.kde.org/r/461/s/83/ Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: weather: adds a space between value and unit. (100.20KPa - 100.20 KPa)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/465/ --- Review request for Plasma. Summary --- Space between value and unit improves plasmoid usability. (100.20KPa - 100.20 KPa) Diffs - KDE/kdeplasma-addons/applets/weather/weatherapplet.cpp 946357 Diff: http://reviewboard.kde.org/r/465/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: simple animation of tabbar icons everytime kickoff is launched by pressing the KDE start button
Hi, Can you revert this patch? I think that your patch doesn't fulfill user and plasma requirements. IMHO it is too slow and weird. I think that users may get annoyed by that animation after a couple of times. I remember that Zack Rusin has wrote an interesting post about animations on his blog. I suggest you to look for that post. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Don't use applet
Hi, We used that word 2 times in the announce: http://www.kde.org/announcements/4.2/index.php I think that we must stop to use that word. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
crystal... few things about that name
Hi, I think you should try to find a better name: 1) Crystal was used for a long period as an icon theme name (that Isn't used anymore), so when I read that name I think about the old Crystal SVG theme. 2) That name doesn't suggest anything about what that plasmoid does. A name that suggest what the plasmoid is, isn't needed but it helps a lot. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: My progress
Hi, Il Tuesday 13 January 2009 20:54:25 Henk te Sligte ha scritto: After that, I'm not really sure what to do next. I have seen some tasklists (e.g. http://techbase.kde.org/Projects/Plasma/Tasks), maybe it's a good idea to pick one of those and see how far I get. But I'm not really sure about all of this. That page seems outdated... :/ I have a couple of questions: Is the process which I have in mind a good idea? Am I too optimistic, because Plasma is too hard (as far as I've seen, it's quite readable, and it just makes sense). Plasma is designed to be simple powerful. :) I know there are some mentors for KDE, is there also a mentor for Plasma, or can I do the learning process on my own? I'm not an official mentor but I can help you if you want :) #plasma is always a good place to start... Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Welcome to 4.3.
Hi, Il Friday 09 January 2009 21:32:23 Zbigniew Braniecki ha scritto: Regarding plans for 4.3. I just wanted to try to refresh the idea of Virtual Folders that were first crafted as a concept somewhere during 2004 KDE4 brainstorming. Indeed virtual folders are cool but I don't think that they are really plasma-related... I think that you should be able to implement virtual folders using KIO stuffs. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
testing incomingmsg xchat support
Hi, Can anyone test incomingmsg xchat support? It seems to don't work. Moreover we don't know how that code works: // do not really understand how this interface works // got this working code from http://arstechnica.com/reviews/hardware/tux-droid-review.ars/3 // we need to hook it up first. this first call is not only for interface testing but also for // setup. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving plasma themes to kdeartworks
Hi, Il Monday 22 December 2008 19:49:01 Sean ha scritto: I'm being way to picky on this I'll admit but just thought I'd highlight some issues. Except you it seems that everyone agrees about moving themes to kdeartwork. So I think that we should proceed before it's too late (artwork freeze is coming soon). I think that today in the late evening or tomorrow I'll do svn mv. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
plasma checkerboard background
Hi, Does we have any plan to use something different? Like a gradient, an image or a solid color? Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving plasma themes to kdeartworks
Hi, Il Tuesday 23 December 2008 14:00:05 Davide Bettio ha scritto: I think that today in the late evening or tomorrow I'll do svn mv. done. KDE/kdeartwork/desktopthemes is the new path. Why we don't call it plasmathemes? Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Moving plasma themes to kdeartworks
Hi, I think that kdeartworks is the right place for plasma themes: 1) themes are artworks 2) we'll be able to add more themes without increasing the size of kdeplasma-addons. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving plasma themes to kdeartworks
Hi, Il Tuesday 16 December 2008 20:34:27 Sean ha scritto: 1. Just because it's artwork dont mean they should go into kdeartwork unless you have a big plan to move everything to it. everything = ? 2. Stuff already in kdeartwork is not even classed as artwork(unless you plan to move it elsewhere). uh? what? 4. What about people who dont want whats in there already?, crystal icons, screensavers, ect.., they just want a few plasma themes not the whole lot, yes any seasoned cmake dude can install what they want but thats not the point. 5 Packagers, yes they do split them up already but this means even more split up(we may well make even more work for them) ,surely a factor to consider. Packagers already split everything... Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving plasma themes to kdeartworks
Hi, Il Tuesday 16 December 2008 21:48:48 Sean ha scritto: Looked in kdeartwork?, it's got styles in there, no artwork it's code, screensavers, not artwork, kwin styles which only one I can see actually has artwork in. Sounds?, erm nope thats not artwork either. Colour schemes, no not artwork. Yes, they are. If you think that they aren't you should ask to release team to rename kdeartwork. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Panel colors, background and compositing...
Hi, Il Monday 24 November 2008 23:30:52 Jud Craft ha scritto: I believe it has been expressed that the overall philosophy with Plasma is that if you have 3d-compositing capability, you get compositing features. If you do not, then you don't. There will be no clever hacks to enable such effects in a non-composited environment. It's just a matter of using things with an alpha channel over a backround and Qt is able to do that in a fast manner. Probably it isn't the best solution, but it allows us to get a great result wihtout 3D capabilities and in a quite fast way. I do wish that there were non-composited ways to add a touch of flare to your KDE desktop, however; the current plasma theme (similar to what Vista does for the Aero interface's taskbar) would be nice, as opposed to merely having one color hardcoded in a plasma theme. I'm not sure if using tint is faster thant the background-alpha-workaround. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Panel colors, background and compositing...
Hi, Il Monday 24 November 2008 23:52:48 Aaron J. Seigo ha scritto: Yes, my opinion is that this is so wrong in so many ways. If we copy the desktop background it will: * end up looking stupid because with compositing it will be wallaper over windows over wallpaper we could disable it, if composite is enabled. * be routing around the technology that is actually there for this exact purpose: compositing well, if compositing isn't available for any reason things should look ok. (Kicker used a similiar workaround for a lot of time). in which case, you can have kicker back. work on it for a year or so then get back to me on it ;) I will never work on it (everyone knows that plasma is the future) :P there are so many other hacks kicker did that result in a poor user experience that we avoid even though it means without compositing you lose some features. I'm not saying that we shouldn't use composite, I'm just saying that we need something nice just in case we can't use composite. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KDE/kdebase/workspace/plasma/applets
SVN commit 884372 by bettio: Updated version numbers (most of version numbers were about 0.1). If you think that your plasmoid has got a different version number, feel free to change it. CCMAIL:plasma-devel@kde.org M +1 -1 activitybar/plasma-applet-activitybar.desktop M +1 -1 analog-clock/plasma-applet-analogclock.desktop M +1 -1 battery/plasma-battery-default.desktop M +1 -1 calendar/plasma-applet-calendar.desktop M +1 -1 devicenotifier/plasma-applet-devicenotifier.desktop M +1 -1 digital-clock/plasma-applet-digitalclock.desktop M +1 -1 icon/plasma-applet-icon.desktop M +1 -1 kickoff/applet/plasma-applet-launcher.desktop M +1 -1 kickoff/simpleapplet/plasma-applet-simplelauncher.desktop M +1 -1 lock_logout/plasma-applet-lockout.desktop M +1 -1 pager/plasma-pager-default.desktop M +1 -1 system-monitor/plasma-applet-sm_cpu.desktop M +1 -1 system-monitor/plasma-applet-sm_hdd.desktop M +1 -1 system-monitor/plasma-applet-sm_hwinfo.desktop M +1 -1 system-monitor/plasma-applet-sm_net.desktop M +1 -1 system-monitor/plasma-applet-sm_temperature.desktop M +1 -1 system-monitor/plasma-applet-system-monitor.desktop M +1 -1 systemtray/plasma-applet-systemtray.desktop M +1 -1 tasks/plasma-tasks-default.desktop M +1 -1 trash/plasma-applet-trash.desktop M +1 -1 webbrowser/plasma-applet-webbrowser.desktop --- trunk/KDE/kdebase/workspace/plasma/applets/activitybar/plasma-applet-activitybar.desktop #884371:884372 @@ -43,7 +43,7 @@ X-KDE-PluginInfo-Author=Marco Martin [EMAIL PROTECTED] X-KDE-PluginInfo-Name=activitybar -X-KDE-PluginInfo-Version=0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=Windows and Tasks X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/plasma-applet-analogclock.desktop #884371:884372 @@ -136,7 +136,7 @@ X-KDE-PluginInfo-Author=The Plasma Team [EMAIL PROTECTED] X-KDE-PluginInfo-Name=clock -X-KDE-PluginInfo-Version=pre0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=Date and Time X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/battery/plasma-battery-default.desktop #884371:884372 @@ -99,7 +99,7 @@ X-KDE-PluginInfo-Author=Sebastian Kügler [EMAIL PROTECTED] X-KDE-PluginInfo-Name=battery -X-KDE-PluginInfo-Version=pre0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=System Information X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/calendar/plasma-applet-calendar.desktop #884371:884372 @@ -44,7 +44,7 @@ X-KDE-PluginInfo-Author=Marco Martin [EMAIL PROTECTED] X-KDE-PluginInfo-Name=calendar -X-KDE-PluginInfo-Version=pre0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=Date and Time X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/plasma-applet-devicenotifier.desktop #884371:884372 @@ -57,7 +57,7 @@ X-KDE-PluginInfo-Author=The Plasma Team [EMAIL PROTECTED] X-KDE-PluginInfo-Name=notifier -X-KDE-PluginInfo-Version=pre0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=System Information X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/plasma-applet-digitalclock.desktop #884371:884372 @@ -102,7 +102,7 @@ X-KDE-PluginInfo-Author=Riccardo Iaconelli [EMAIL PROTECTED] X-KDE-PluginInfo-Name=digital-clock -X-KDE-PluginInfo-Version=0.0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://www.ruphy.org/ X-KDE-PluginInfo-Category=Date and Time X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/icon/plasma-applet-icon.desktop #884371:884372 @@ -100,7 +100,7 @@ X-KDE-PluginInfo-Author=The Plasma Team [EMAIL PROTECTED] X-KDE-PluginInfo-Name=icon -X-KDE-PluginInfo-Version=pre0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=File System X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/plasma-applet-launcher.desktop #884371:884372 @@ -130,7 +130,7 @@ X-KDE-PluginInfo-Author=Robert Knight [EMAIL PROTECTED] X-KDE-PluginInfo-Name=launcher -X-KDE-PluginInfo-Version=0.1 +X-KDE-PluginInfo-Version=1.0 X-KDE-PluginInfo-Website=http://plasma.kde.org/ X-KDE-PluginInfo-Category=Application Launchers X-KDE-PluginInfo-Depends= --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/plasma-applet-simplelauncher.desktop #884371:884372 @@ -118,7 +118,7 @@ X-KDE-PluginInfo-Author=Robert Knight [EMAIL PROTECTED] X-KDE-PluginInfo-Name=simplelauncher -X-KDE-PluginInfo-Version=0.1
GPL/LGPL licensing issues
Hi, I think that these files need to be relicensed to LGPL: favicons filebrowserengine sensoragent.h sensorclient.h sensorshellagent sensormanager sensorsocketagent (These files are located in kdebase/workspace/plasma/dataengines/) Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: GPL/LGPL licensing issues
Hi, We need to relicense to LGPL these files too: * kdebase/workspace/plasma/runners/ PowerDevilRunner shell_config *kdebase/workspace/libs/libplasmaclock clocknumber (I think that we can kill this one, it seems almost unuseful) clockapplet Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: GPL/LGPL licensing issues
Hi, Il Friday 14 November 2008 22:01:23 Aaron J. Seigo ha scritto: yes, i don't see any need to change the license on them. why we used LGPL for all our runners/dataengines? Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma, panels, colours
Hi, Il Wednesday 12 November 2008 20:17:41 Nuno Pinheiro ha scritto: FIVE PROPOSALS please have a look http://www.nuno-icons.com/images/test/ How they looks if we use a different wallpaper like red leaf? We can't assume that the wallpaper will be always blue. And we can't assume to use composite. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
missing ungroup and other issues
Hi, 1) I noticed (when I have Only when the taskbar is full enabled) that the taskbar does only the grouping and it doesn't ungroup tasks when it gets free again. 2) Only when the taskbar is full option doesn't seems to behave as expected when rows are more than 1 (if we have 2 rows for example, we should start to use the 2nd row). 3) Is Only when the taskbar is full the default behaviour for KDE 4.2? Should we have as default only 1 row? Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma, panels, colours
Hi Actualy I have a blackdark electric blue panel and I'm already tired to use it. It started to hurt my eyes since the first look at it. (moreover It looks worse if you use the read leaf wallpaper) Are we going to put use it as default for KDE 4.2? I hope no. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Some possible improvements for Lancelot
Hi, I have a list of improvements for lancelot that I like to see for KDE 4.2. 1) I think that lancelot part should be hidden: allowing users to add lancelot part to the desktop doesn't seems a good idea. 2) I think that lancelot should use (like kickoff and other applets) Plasma::PopupApplet. 3) Rounded squares are nice (I'm talking about selection squares on the left). 4) Config UI needs to follow plasma HIG. 5) It shouldn't use its own scrollbar style: it should use plasma scrollbar style. 6) Resize needs to be fixed, lancelot doesn't behave correctly when it is resized. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KDE/kdebase/workspace/plasma
SVN commit 874115 by bettio: Added libs directory which is meant to be the right place where I can put libs like libplasmaclock. If you don't like this commit feel free to revert it or to mail me. CCMAIL: plasma-devel@kde.org A libs (directory) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop configuration interface
Hi, 1) I tried to sort groups ( Desktop Activity, Desktop Theme, Wallpaper = Wallpaper, Desktop Theme, Desktop Activity), the result IMHO is nice. Oh, I've forgot the UI file. Bye, Davide Bettio. BackgroundDialog.ui Description: application/designer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: calendar widget in kdereview
Ciao, Il Friday 03 October 2008 04:41:12 Aaron J. Seigo ha scritto: * Calendar needs to follow the API pattern for widgets[1] * the hover painting is wicked inneficient right now +OK * we need a glow radius hint for the hover painting; though perhaps in this case i wonder if we should be doing it with an svg or using the same style that we are for, e.g., buttons? I think that using a SVG is a good idea * year jumps? ability to in-line edit the year/month? I was trying to do something cool using a spinbox, but I need to do more hacking on it If I want to get a good result. * think about whether we actually want two separate classes, or if we should merge the two into one and have some methods to control whether or not the top navigation gets created/shown I'll maintain anyway a private class in that case, splitting the calendar in 2 classes make things simplier... also, what's that fancy spinbox thing referenced in the code? =) xD see the answer to year jumps? ability to in-line edit the year/month? monday I'll start to fix everything. :) Have a nice weekend. Bye, Davide Bettio. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
