D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was present in the old `SourcesModel` but not ported to the new one.

TEST PLAN
  5.17
  Noticed that changing runner settings didn't update krunner live.
  The KCM still doesn't enable Apply properly but that is separate. When I hit 
OK things work immediately as expected now.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D26444

AFFECTED FILES
  lib/runnerresultsmodel.cpp
  lib/runnerresultsmodel.h

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26434: [Battery Monitor] Don't blink when battery is critical

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:222b407454f7: [Battery Monitor] Dont blink when 
battery is critical (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26434?vs=72794=72806

REVISION DETAIL
  https://phabricator.kde.org/D26434

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma, anthonyfieroni, ngraham
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26434: [Battery Monitor] Don't blink when battery is critical

[Kai Uwe Broulik]

broulik added a comment.


  Works here. `notify-send foo bar -u critical` will show on top of everything.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26434

To: broulik, #plasma, anthonyfieroni
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26434: [Battery Monitor] Don't blink when battery is critical

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Especially when you're almost out of juice you don't want to be wasting it 
blinking an icon causing excess repaints.
  Also considering the critical percentage is hardcoded to 5% here and doesn't 
follow PowerDevil's setting.
  Given battery critical notification is persistent and always on top of 
everything these days, you can't really miss the fact that you're almost ouf of 
power.

TEST PLAN
  - Fully charged: was hidden still
  - Not fully charged: was active now, never blinked, even when low

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26434

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26086: Don't fetch pixmap if we have it already

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08f02266c922: Dont fetch pixmap if we have it 
already (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26086?vs=71794=72785

REVISION DETAIL
  https://phabricator.kde.org/D26086

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26425: [Notifications KCM] Fixup current item syncing logic

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of relying on `currentIndex` and some massively complicated logic to 
track when the index didn't change but the item behind that index, just use 
`currentItem`.
  The `updateCurrentIndex` being called during model changes massively confused 
`ListView` leading to inconsistent view state.
  
  BUG: 410842
  FIXED-IN: 5.18.0

TEST PLAN
  - Selecting apps by clicking and arrow keys still works
  - Filtering keeps the view on the right in sync with whatever happens to be 
selected in the list on the left
  - I didn't notice any broken or missing entries in the list anymore

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26425

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

[Kai Uwe Broulik]

broulik added a comment.


  hmm, I wanted to have it more obvious than being the first "System Service"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26423

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes it obvious that it's not an application or "service" but more of an 
overall category of general stuff, since this is where warning sounds, 
login/logout sounds, etc are located in.

TEST PLAN
  Should it perhaps get an explanatory text? Something like "Configure general 
information and warning messages as well as startup and shutdown sounds."?
  F7860974: Screenshot_20200104_235112.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26423

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26422: [Notifications] Fix ListView attached property

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is only attached to the delegate item itself.
  Broke when it got shuffled around when swiping got added.

TEST PLAN
  - The "show n more" button shows up again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26422

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26378: [Download Plugin] Register downloaded files as recent documents

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ddea25bf47f1: [Download Plugin] Register downloaded files 
as recent documents (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26378?vs=72737=72765

REVISION DETAIL
  https://phabricator.kde.org/D26378

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/constants.js
  extension/options.html
  host/CMakeLists.txt
  host/downloadjob.cpp
  host/downloadjob.h
  host/downloadplugin.cpp

To: broulik, #plasma, hein, #vdg, fvogt, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26378: [Download Plugin] Register downloaded files as recent documents

[Kai Uwe Broulik]

broulik updated this revision to Diff 72737.
broulik edited the test plan for this revision.
broulik added a comment.


  - Make configurable

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26378?vs=72656=72737

REVISION DETAIL
  https://phabricator.kde.org/D26378

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/constants.js
  extension/options.html
  host/CMakeLists.txt
  host/downloadjob.cpp
  host/downloadjob.h
  host/downloadplugin.cpp

To: broulik, #plasma, hein, #vdg, fvogt, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme 
check for devices (authored by broulik).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25991?vs=71522=72708#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25991?vs=71522=72708

REVISION DETAIL
  https://phabricator.kde.org/D25991

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: kde-frameworks-devel, bruns, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26403: [ToolTip] Round position

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:415683af956c: [ToolTip] Round position (authored by 
broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26403?vs=72705=72706

REVISION DETAIL
  https://phabricator.kde.org/D26403

AFFECTED FILES
  org.kde.desktop/ToolTip.qml

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26403: [ToolTip] Round position

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise screws up font rendering

TEST PLAN
  Before
  F7858341: Screenshot_20200103_192446.png 

  After
  F7858342: Screenshot_20200103_192811.png 

  
  If accepted, will do the same patch to plasmacomponents3

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26403

AFFECTED FILES
  org.kde.desktop/ToolTip.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26077: [kcms/ksmserver] Swap shutdown options

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c4dc4bd45238: [kcms/ksmserver] Swap shutdown options 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26077?vs=71761=72681

REVISION DETAIL
  https://phabricator.kde.org/D26077

AFFECTED FILES
  kcms/ksmserver/smserverconfigdlg.ui

To: broulik, #plasma, ervin
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26378: [Download Plugin] Register downloaded files as recent documents

[Kai Uwe Broulik]

broulik added a comment.


  Should it purge the entry from kactivities stats when you manually remove the 
download from the download list in the browser?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D26378

To: broulik, #plasma, hein, #vdg, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

[Kai Uwe Broulik]

broulik added a comment.


  > by disabling the display of critical notifications.
  
  It doesn't disable them. Merely keeps them behind full screen windows. I 
think the option is fine as it is. (You know, if we had some kuserfeedback data 
to prove that nobody disables this option... :p)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  section-grouping-in-notifications-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26379

To: ngraham, broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26378: [Download Plugin] Register downloaded files as recent documents

[Kai Uwe Broulik]

broulik updated this revision to Diff 72656.
broulik added a comment.


  - Ignore incognito downloads

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26378?vs=72655=72656

REVISION DETAIL
  https://phabricator.kde.org/D26378

AFFECTED FILES
  host/CMakeLists.txt
  host/downloadjob.cpp

To: broulik, #plasma, hein, #vdg, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26378: [Download Plugin] Register downloaded files as recent documents

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein, VDG, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes them more easily accessible throughout the shell.

TEST PLAN
  I'm a bit torn on this UX-wise ... probably best to use it in production for 
a (ch)while and see if it gets annoying.
  F7856405: Screenshot_20200102_225225.png 

  (Or we do the oldfashioned KDE way of not committing to anything and adding 
an option :p)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D26378

AFFECTED FILES
  host/CMakeLists.txt
  host/downloadjob.cpp

To: broulik, #plasma, hein, #vdg, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26183: Fix build with Qt 5.14

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Please use `qmlRegisterAnonymousType`

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D26183

To: tcanabrava, davidedmundson
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The multiplexer is responsible for global media control shortcuts which won't 
work with a player that isn't controllable.

TEST PLAN
  master-only, as last time I tampered with mpris in .5 minor update it broke 
some other non-standard compliant player...
  
  - Chrome's broken mpris impl doesn't steal keys from p-b-i anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26330

AFFECTED FILES
  dataengines/mpris2/multiplexer.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23676: [Folder View] Only install watch on .directory file if actually used

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23676

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26297: [Notifications] Don't show DrKonqi notifications in history

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e7e747b9bea1: [Notifications] Dont show DrKonqi 
notifications in history (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26297?vs=72401=72421#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26297?vs=72401=72421

REVISION DETAIL
  https://phabricator.kde.org/D26297

AFFECTED FILES
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26035: battery: Improve the brightness responsiveness

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Seems to work well, thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26035

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26297: [Notifications] Don't show DrKonqi notifications in history

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It creates a tray icon, so having a history entry is just annoying 
duplication.

TEST PLAN
  5.17?
  
  - Ran kate, kill -6 `pidof kate, got a drkonqi tray icon and notification, 
let notification expire, it didn't end up in history
  
  DrKonqi's tray icon is smart enough already to stay there for max 1 minute 
unless the computer is idle, so that when a process dies in the middle of the 
night, you'll see it next time you come around, whicih is imho perfect and 
does't need any form of history.
  
  You can't change this behavior in the UI as DrKonqi's desktop entry is 
NoDisplay and we don't have per-event history config yet

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26297

AFFECTED FILES
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26296: Add Opera Extension ID

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, leinir.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I submitted it to the Opera Add-ons store and despite having been signed with 
the same key as Chrome, the extension ID appears to have changed. Opera also 
seems to look in the same file as Chrome, so just add the ID there.

TEST PLAN
  Chrome still works. Untested as the extension still hasn't passed review... 
When loading the extension through dev mode the ID is the same as Chrome and 
the extension just works

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D26296

AFFECTED FILES
  CMakeLists.txt
  org.kde.plasma.chrome_integration.json.in

To: broulik, #plasma, leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25851: [Notifications] Add quick reply feature

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:73a3222c6dd1: Merge branch broulik/quickreply 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25851?vs=71197=72391#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25851?vs=71197=72391

REVISION DETAIL
  https://phabricator.kde.org/D25851

AFFECTED FILES
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/NotificationReplyField.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/dbus/org.freedesktop.Notifications.xml
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notifications.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h

To: broulik, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25762: Only serialize window pixmap if we're using it

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b49d5cfde098: Only serialize window pixmap if were 
using it (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25762?vs=71789=72347

REVISION DETAIL
  https://phabricator.kde.org/D25762

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26219: Check DPMS extension being present

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:18e53dbaaea2: Check for DPMS extension being present 
(authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26219?vs=72160=72234

REVISION DETAIL
  https://phabricator.kde.org/D26219

AFFECTED FILES
  daemon/actions/dpms/xcbdpmshelper.cpp

To: broulik, #plasma, anthonyfieroni, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26219: Check DPMS extension being present

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It might be disabled. Don't die in this case.
  
  BUG: 414921
  FIXED-IN: 5.17.5

TEST PLAN
  5.12? 5.17? master?
  
  - just tested what happens if isn't supported, haven't tested yet disabling 
it in xrandr.conf

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D26219

AFFECTED FILES
  daemon/actions/dpms/xcbdpmshelper.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26160: [Notifications] For non-configurable applications use fake "@other" category

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4280515eebb0: [Notifications] For non-configurable 
applications use fake @other category (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26160?vs=72012=72061

REVISION DETAIL
  https://phabricator.kde.org/D26160

AFFECTED FILES
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26161: [Notifications KCM] Add "Other Applications" category

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:41e27fa56cd8: [Notifications KCM] Add Other 
Applications category (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26161?vs=72013=72062

REVISION DETAIL
  https://phabricator.kde.org/D26161

AFFECTED FILES
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/sourcesmodel.cpp

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26162: [Notifications KCM] Force re-evaluation of position radio buttons

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The Settings object is kind of a write-only state and doesn't signal property 
changes unless "live" (where it would listen to other settings changing which 
we don't want inside the KCM) or only upon save().
  This is arguably a questionable design decision on my side :-) but usually 
it's not a problem as the KCM controls will have whatever state the user will 
put them in but it falls apart in case we switch to another page and back 
without saving. This hack is good enough for stable branch anyway imho.
  
  BUG: 414098
  FIXED-IN: 5.17.5

TEST PLAN
  - Went to position selector, chose a position, went back. Radio button moved 
to the bottom position. Before that it would only do it when I hit save

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26162

AFFECTED FILES
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26161: [Notifications KCM] Add "Other Applications" category

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Settings in there will influence all non-identifyable applications.

TEST PLAN
  See aso D26160 
  
  - Can have shell scripts show up in history again
  - And can even suppress popups for them now, so win-win, and doesn't require 
adding a checkbox to the main page, so I really like this approach
  
  F7831287: Screenshot_20191222_205500.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26161

AFFECTED FILES
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/sourcesmodel.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26160: [Notifications] For non-configurable applications use fake "@other" category

[Kai Uwe Broulik]

broulik updated this revision to Diff 72012.
broulik added a comment.


  - Ship `plasmanotifyrc` file with them disabled by default

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26160?vs=72011=72012

REVISION DETAIL
  https://phabricator.kde.org/D26160

AFFECTED FILES
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26160: [Notifications] For non-configurable applications use fake "@other" category

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to control the behavior of those applications rather than flat-out 
ignoring them.

TEST PLAN
  - Can have shell scripts and other things without desktop entry show in 
history again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26160

AFFECTED FILES
  libnotificationmanager/notificationfilterproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26125: [Notifications] Release all cookies when service unregisters

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1967dc08e3db: [Notifications] Release all cookies when 
service unregisters (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26125?vs=71905=71906#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26125?vs=71905=71906

REVISION DETAIL
  https://phabricator.kde.org/D26125

AFFECTED FILES
  libnotificationmanager/server_p.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26125: [Notifications] Release all cookies when service unregisters

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  An application could have multiple inhibitions. Release all of them when the 
service unregisters (process dies).

TEST PLAN
  - Made a test app which called Inhibit twice, killed it, do not disturb mode 
was properly quit

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26125

AFFECTED FILES
  libnotificationmanager/server_p.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26121: Kicker/RecentDocument display file path as decoration

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> recentusagemodel.cpp:269
> +QString desc = fileItem.localPath();
> +desc.truncate(desc.lastIndexOf(QChar('/')));
> +return desc;

Can you use the "~" for HOME like the runners do please

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26121

To: meven, #vdg, #plasma, ngraham, ervin
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

[Kai Uwe Broulik]

broulik updated this revision to Diff 71887.
broulik added a comment.


  - Use renamed hint

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26120?vs=71879=71887

REVISION DETAIL
  https://phabricator.kde.org/D26120

AFFECTED FILES
  src/bluedevil.notifyrc
  src/wizard/CMakeLists.txt
  src/wizard/bluewizard.cpp
  src/wizard/pages/success.cpp

To: broulik, #vdg, drosca, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8dc1db04b9be: [Notifications] Add hint for a notification 
being response to explicit user… (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25935?vs=71877=71882#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25935?vs=71877=71882

REVISION DETAIL
  https://phabricator.kde.org/D25935

AFFECTED FILES
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

[Kai Uwe Broulik]

broulik added a comment.


  In D25935#580527 , @davidedmundson 
wrote:
  
  > I thought you were going to call it UserActionFeedback?
  
  
  You said "user-action works"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: VDG, drosca, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Saves the user from having to close the dialog when pairing succeeded.

TEST PLAN
  - Not too happy about this approach, but `done` is `protected`, just closing 
the dialog from the page doesn't properly dismiss it. Maybe I should add a 
signal on the page instead?
  
  F7826564: Screenshot_20191220_120611.png 


REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D26120

AFFECTED FILES
  src/bluedevil.notifyrc
  src/wizard/CMakeLists.txt
  src/wizard/bluewizard.cpp
  src/wizard/pages/success.cpp

To: broulik, #vdg, drosca, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

[Kai Uwe Broulik]

broulik updated this revision to Diff 71877.
broulik retitled this revision from "[Notifications] Add hint for showing a 
notification even in do not disturb mode" to "[Notifications] Add hint for a 
notification being response to explicit user interaction".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Make more generic and implicit

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25935?vs=71398=71877

REVISION DETAIL
  https://phabricator.kde.org/D25935

AFFECTED FILES
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25916: [Notifications] Provide better feedback when copying a single file

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I forgot why this was needed - KDE Connect works fine after I fixed the job...

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D25916

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25951: Show peripheral low battery notification for NoCharge

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:14212f78de5f: Show peripheral low battery notification 
for NoCharge (authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25951?vs=71440=71874

REVISION DETAIL
  https://phabricator.kde.org/D25951

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26091: [Notifications] Improve self-closing behavior

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:90a69a7b508a: [Notifications] Improve self-closing 
behavior (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26091?vs=71821=71873#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26091?vs=71821=71873

REVISION DETAIL
  https://phabricator.kde.org/D26091

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26093: Use a fixed icon size for the notification popup close button

[Kai Uwe Broulik]

broulik added a comment.


  F7826451: Screenshot_20191220_095532.png 

  The icon looks pretty big here now - wouldn't it be `small` for normal 
`ToolButton` icon?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26093

To: ahiemstra, #plasma, #vdg, ndavis, ngraham
Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26111: KRunner add a recentlyused runner accessing KActivityStats data

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Why not change the recentdocuments runner? We have various places where we 
whitelist recentdocuments as a runner and if a user disabled it, this would not 
be carried over without a confi update script.
  
  Also, you might want to look at the old runner code for some of its behavior 
(e.g. the subtext and mimetype handling) to keep it consistent.

INLINE COMMENTS

> recentlyused.cpp:93
> +}
> +match.setIconName(KIO::iconNameForUrl(url));
> +match.setRelevance(relevance);

I think plain mime type icon would be sufficient?

> recentlyused.cpp:95
> +match.setRelevance(relevance);
> +match.setData(url);
> +match.setText(name);

`setData` takes `QVariant`, so you can just store the `QUrl` in here, saves you 
the string to URL dances below

> recentlyused.cpp:97
> +match.setText(name);
> +match.setSubtext(i18n("In %1", 
> url.adjusted(QUrl::RemoveFilename).path()));
> +

We typically just show the folder path and use `~` for home, cf. existing runner

> recentlyused.cpp:109
> +
> +if (match.selectedAction() && match.selectedAction() == 
> action(s_openParentDirId)) {
> +KIO::highlightInFileManager({QUrl(url)});

the first part isn't needed, the comparison is enough

> recentlyused.cpp:125
> +
> +if (url.isLocalFile() && !QFileInfo(url.toLocalFile()).isDir()) {
> +actions << action(s_openParentDirId);

I think it's perfectly fine trying to show where a folder is inside another 
folder

> recentlyused.cpp:135
> +QMimeData *result = new QMimeData();
> +result->setText(match.data().toString());
> +return result;

`setUrls`

> recentlyused.h:25
> +
> +#include 
> +

Unused in the header

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25874: [Task Manager] Consider parent PID for audio stream

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:09a258a22ed4: [Task Manager] Consider parent PID for 
audio stream (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25874?vs=71251=71844

REVISION DETAIL
  https://phabricator.kde.org/D25874

AFFECTED FILES
  CMakeLists.txt
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/ui/PulseAudio.qml
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25780: [Notifications] Set total amount to processed amount if no total and no error

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Given the trash issue and the fact that fixing KDE Connect was easy, let's 
abandon this: https://invent.kde.org/kde/kdeconnect-kde/merge_requests/188/diffs

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25780

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25851: [Notifications] Add quick reply feature

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> notification.cpp:637
>  
> +if (!d->hasReplyAction && name == QLatin1String("reply")) {
> +d->hasReplyAction = true;

I'll change that to "inline-reply" to avoid potential clashes

> server_p.cpp:234
>  QStringLiteral("actions"),
> +QStringLiteral("reply-action"),
>  

Will rename to "inline-reply"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25851

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26091: [Notifications] Improve self-closing behavior

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a plasmoid collapses in Active state, the popup is hidden. In Passive 
state, however, one is returned to the hidden items list, as it cannot tell 
whether the plasmoid collapsed on its own or because the user clicked the same 
one in the hidden items list again.
  When we clear notifications, plasmoid state updates immediately as a result 
of model signals, and when we then try to collapse the plasmoid we're already 
hidden and just returned to the hidden items list.
  This patch addresses this by delaying the state change slightly. Futhermore, 
don't collapse the plasmoid when already hidden as that would just return the 
user to the hidden items list.

TEST PLAN
  I tried fixing that in System Tray but as I said there's no way for it to 
tell whether the plasmoid hid "on its own" or because the user clicked it again 
as the compact rep entirely governs this behavior when expanded. :/ It's ugly 
but I don't really see a better way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26091

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26086: Don't fetch pixmap if we have it already

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `AppData` contains a `QIcon` with pixmap data gathered from 
`KWindowSystem::icon` which we can just use.
  Only if, for some reason, the icon is really null, try getting it from 
`KWindowSystem` on demand.

TEST PLAN
  Pinned my xcalc to the task bar, got the same pixmap serialized as before, 
without a roundtrip to the x server

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26086

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25762: Only serialize window pixmap if we're using it

[Kai Uwe Broulik]

broulik updated this revision to Diff 71789.
broulik retitled this revision from "Don't bother serializing window icon 
pixmap for known services" to "Only serialize window pixmap if we're using it".
broulik edited the summary of this revision.
broulik added a comment.


  - Use `usingFallbackIcon`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25762?vs=70955=71789

REVISION DETAIL
  https://phabricator.kde.org/D25762

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:35e8cb70c0c0: [Notifications KCM] Add KeySequenceItem for 
do not disturb shortcut (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26018?vs=71599=71787#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26018?vs=71599=71787

REVISION DETAIL
  https://phabricator.kde.org/D26018

AFFECTED FILES
  kcms/notifications/CMakeLists.txt
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25782: [Notifications] Add draggable file icon when single file job finishes

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a22c44dafc6b: [Notifications] Add draggable file icon 
when single file job finishes (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25782?vs=71006=71773#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25782?vs=71006=71773

REVISION DETAIL
  https://phabricator.kde.org/D25782

AFFECTED FILES
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/contents/ui/JobItem.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:0fd34f0497cc: [Wizard] Allow choosing device by double 
click (authored by broulik).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25992?vs=71525=71770

REVISION DETAIL
  https://phabricator.kde.org/D25992

AFFECTED FILES
  src/wizard/pages/discover.cpp
  src/wizard/pages/discover.h

To: broulik, #plasma, drosca, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25634: Add kconf update script for ksmserver

[Kai Uwe Broulik]

broulik added a comment.


  -1 I'd prefer if the config value was kept

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25634

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26077: [kcms/ksmserver] Swap shutdown options

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  With kcfg magic the order of the radio buttons determines the enum value. 
Just swap them so they're correct again.
  
  BUG: 415308

TEST PLAN
  - Configured shutdown, hit power button, got shutdown pre-selected

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26077

AFFECTED FILES
  kcms/ksmserver/smserverconfigdlg.ui

To: broulik, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26065: [KCM/Access] Port to use KConfigXT

[Kai Uwe Broulik]

broulik added a comment.


  I read kaccess.cpp and commented on where the defaults diverge, there could 
be more. There's also some keys that have typos and/or don't match.
  This shows quite impressively why having this stuff in a central place is 
useful :)
  Given kaccess.cpp is what does the handling, ultimately its defaults will be 
what is being used, not the ones in the KCM.

INLINE COMMENTS

> kaccess_settings.kcfg:13
> +
> +
> +  Whether or not to use a custom bell

lol

Can you give this a better name, like "customBell"

(Arts was the KDE 3 sound server)

> kaccess_settings.kcfg:17
> +
> +
> +  The custom bell sound file

Likewise, customBellFile

> kaccess_settings.kcfg:46
> +
> +  Lock sticked keys
> +  true

"stickied" is not a word but I can see that "stuck" implies something else

> kaccess_settings.kcfg:55
> +  Send a system bell notification when sticky keys are enabled or 
> disabled
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:61
> +
> +
> +  Send a plasma notification when a lock key or sticky keys state 
> changes

"key" or whatever that k stands for?

> kaccess_settings.kcfg:76
> +  Use system bell when a key is pressed
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:80
> +  Use system bell when a key is accepted
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:84
> +  Use system bell when a key is rejected
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:97
> +  Use system bell when a bounced key is rejected
> +  true
> +

BounceKeysRejectBeep

> kaccess_settings.kcfg:121
> +
> +
> +  Send a plasma notification when a keyboard accessbility feature 
> is enabled or disabled

There is only `kNotifyAccessX` (note the X)

> kaccess_settings.kcfg:142
> +
> +  1000
> +

This is actually being calculated referencing "interal" in kaccess code:

  mouseGroup.readEntry("MKTimeToMax", (5000 + interval / 2) / interval);

> kaccess_settings.kcfg:144
> +
> +
> +  5000

The key is `MKTimeToMax`

> kaccess_settings.kcfg:148
> +
> +  1000
> +

Defaults to `interval`

> kaccess_settings.kcfg:155
> +
> +  Acceleration profil
> +  0

profil*e*

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26065

To: meven, ervin, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25874: [Task Manager] Consider parent PID for audio stream

[Kai Uwe Broulik]

broulik added a comment.


  I have not. Given a browser window typically has dozens of children whereas 
you typically have few audio streams, I think if any it will be slower.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25762: Don't bother serializing window icon pixmap for known services

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  > That means you can limit serializing to cases where the window is in 
usingFallbackIcon.
  
  Good idea, I'll give it a try.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25539: feat(kcm): add revert timer

[Kai Uwe Broulik]

broulik added a comment.


  > With direct-apply having a revert window/overlay/inline message only shown 
when certain critical options were changed could be a good compromise.
  
  It needs to be made absolute sure, though, that the keyboard focus is 
correct, so hitting e.g. Return will undo it, which iirc is the main point of 
having a modal dialog instead of an inline thing.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25762: Don't bother serializing window icon pixmap for known services

[Kai Uwe Broulik]

broulik added a comment.


  > why don't we just change the check to QIcon::isNull?
  
  We still want to serialize custom pixmap data icons which won't be null.
  What we want to do is tell between "icon on disk" and "icon from pixmap data" 
which we can't really at the moment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> settings.h:343
>  
> +QList configSkeletons() const;
> +

Not a fan of this becoming public API

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:38
>  view.currentIndex: kcm.pluginIndex(kcm.iconsSettings.theme)
> -enabled: !kcm.downloadingFile
>  

Why this change?

> main.qml:55
>  
> +enabled: !kcm.iconsSettings.isImmutable("Theme") // don't allow to 
> change theme if immutable, but allow to change icon sizes
> +

Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff 
Marco fixed a while back?

> main.qml:230
>  QtControls.Button {
> +enabled: true
>  id: iconSizesButton

This is the default

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26035: battery: Improve the brightness responsiveness

[Kai Uwe Broulik]

broulik added a comment.


  `PlasmaComponents` 3 `Slider` doesn't react to wheel events, which must be 
fixed before this can go in.

INLINE COMMENTS

> PopupDialog.qml:48
> -
> -keyboardBrightnessSlider.valueChanged.connect(function() {
> -batterymonitor.keyboardBrightness = 
> keyboardBrightnessSlider.value

What about this?

> batterymonitor.qml:109
> +property QtObject updateScreenBrightnessJob
>  onScreenBrightnessChanged: {
>  if (disableBrightnessUpdate) {

Should we not forward the notion of "moved" here, too?

> logic.js:53
>  function updateBrightness(rootItem, source) {
> +if (rootItem.updateScreenBrightnessJob || 
> rootItem.updateKeyboardBrightnessJob)
> +return;

Wouldn't that cause subsequent calls to fail if the previous hasn't finished 
yet? Wouldn't that be annoying if you drag the slider quickly?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26035

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  I guess it builds the QML tree and evaluates the `qsTr` calls and then finds 
it needs an item from a plugin and loads the import and only then translates 
it. Subsequent controls are translated, only the ones on the initial item are 
not. Perhaps if we shoehorn a `QQmlEngine::retranslate()` call in the ecm qm 
loader thing (or rather have a ecm qm loader for qml plugin) it should force 
re-evaluation of those things. Not pretty either :/

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Ok, so turns out, it does call it when the plugin is loaded, but the 
translations are only installed *after* the QML has loaded and processed.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Well, whatever it is, it doesn't work. My search field isn't translated and I 
put breakpoints and I only get it load translations for kcoreaddons and 
kjobwidgets.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  We don't link against Kirigami, so the startup routine stuff doesn't apply? 
And we're way after the QCoreApp constructor at this point.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Qt docs say "Adds a global function that will be called from the 
QCoreApplication constructor. " but when we at runtime somewhere load a QML 
plugin we're too late with that.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Not a huge fan of the code duplication there..
  
  Needs D26013  and D26016 
 to fully work
  F7819575: Screenshot_20191215_143457.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26018

AFFECTED FILES
  kcms/notifications/CMakeLists.txt
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26012: Restore circular progress bar in compact notification applet

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Lovely!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  circular_progress

REVISION DETAIL
  https://phabricator.kde.org/D26012

To: ahiemstra, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25950: Add specialized notification for Bluetooth battery

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:ef856e3598ec: Add specialized notification for Bluetooth 
battery (authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25950?vs=71439=71581

REVISION DETAIL
  https://phabricator.kde.org/D25950

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:943ca2072a80: [Notifications] Show hint if notifications 
arent available or provided by… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25917?vs=71413=71580

REVISION DETAIL
  https://phabricator.kde.org/D25917

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25983: Update size hint when font changes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:51871406787d: Update size hint when font changes 
(authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25983?vs=71498=71578

REVISION DETAIL
  https://phabricator.kde.org/D25983

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26012: Restore circular progress bar in compact notification applet

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CompactRepresentation.qml:103
>  running: visible
> +opacity: compactRoot.jobsPercentage == 0 ? 1 : 0
>  }

You might want to stop and hide the `BusyIndicator` altogether (cf. the `State` 
below) rather than just making it fully transparent

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26012

To: ahiemstra, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

[Kai Uwe Broulik]

broulik added a comment.


  I agree. The tooltips get in the way far too often as they are, so making 
them stay unnecessarily would be annoying.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25952

To: ngraham, #plasma, #vdg, hein, ndavis
Cc: broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25967: Emit panelTakesFocus for other plamsashell types

[Kai Uwe Broulik]

broulik added a comment.


  No! But it allows them to get it if they want to, e.g. when you hit inline 
reply

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25967

To: davidedmundson, #plasma
Cc: broulik, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Lovely

REPOSITORY
  R120 Plasma Workspace

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

To: ahiemstra, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> bruns wrote in kfileplacesmodel.cpp:758
> you have dropped the `allowedHere` check. Probably just `if (!allowedHere) 
> continue`.
> 
> And for reasons unknown to me, `tags:` is not filtered per app - move the 
> allowedHere check to the very beginning of the `while(...)` loop.

Devices are always allowed. The old check was

  if (isSupportedScheme && ((isSupportedUrl && ... && allowedHere) || 
deviceAvailable)) 

so `deviceAvailable` trumps `allowedHere`

> bruns wrote in kfileplacesmodel.cpp:759
> Does KFilePlacesItem have a move constructor? You can do the heap allocation 
> then only if necessary.

It does not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Kai Uwe Broulik]

broulik added a comment.


  I think you can't. It is potentially a long list, so not sure if just 
clicking it should advance the list, since it is clearly a "wizard" pattern 
page. If it were a bunch of "command links" it would be obvious that clicking a 
single item would advance the wizard.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D25992

To: broulik, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of having to select one and clicking "Next"

TEST PLAN
  Clicked New device, double clicked some device and got it paired

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D25992

AFFECTED FILES
  src/wizard/pages/discover.cpp
  src/wizard/pages/discover.h

To: broulik, #plasma, drosca, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A device doesn't usually have a URL so we need to actutally check the 
underlying device (e.g. StorageAccess or NetworkShare) for whether it is 
supported.

TEST PLAN
  - `kdialog --getopenfilename ~` now has my mounted ISOs and external storage 
now
  - didn't test with CD drives or network shares
  - KFilePlaces tests stil pass

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Sounds good to me lol

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Kirigami, Frameworks, kossebau, aacid.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't work for 
things loaded as plugins like QML modules.
  This copies the logic over to the plugin so the translations are loaded when 
the QML plugin is loaded.
  Not really like it, so I'm open to suggestions how to do that better in ECM 
or I don't know?

TEST PLAN
  - The Search field in Kirigami is translated now
  - The AboutPage in Kirigami is translated now

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25983: Update size hint when font changes

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures controls update their size when font changes.
  The Labels inside would but the control around them not, leading to broken 
rendering until causing it to update by interacting with it.
  It has to be queued for some reason or else by the time the signal is 
invoked, the style hasn't caught up yet.

TEST PLAN
  *Changed from 10pt to 12pt
  Before:
  The one I hovered updated half-way
  F7817652: Screenshot_20191214_114627.png 

  After:
  All controls update immediately
  F7817653: Screenshot_20191214_114546.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25983

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Kai Uwe Broulik]

broulik added a comment.


  It was suggested to make it more semantic, i.e. be about "this is feedback 
for user-initiated task" which will then imply showing in dnd mode. Suggestions 
on how to phrase that as a key name?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Kai Uwe Broulik]

broulik added a comment.


  Make sure that whatever you decide on is also applied to Bluetooth plasmoid

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25970

To: ngraham, #vdg, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25936: [Desktop Containment] Hide tooltip while rotating the widget

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:115a3e1aeede: [Desktop Containment] Hide tooltip while 
rotating the widget (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25936?vs=71400=71456

REVISION DETAIL
  https://phabricator.kde.org/D25936

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml

To: broulik, #plasma, mart, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25932: [Task Manager] Better align badge in tooltip

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:67d86068d7f2: [Task Manager] Better align badge in 
tooltip (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25932?vs=71384=71455#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25932?vs=71384=71455

REVISION DETAIL
  https://phabricator.kde.org/D25932

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, #vdg, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25951: Show peripheral low battery notification for NoCharge

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BlueZ doesn't report charge state, only percentage, so it is unfortunately 
always `NoCharge` for them.
  Add an additional guard to check for "0%" charge explicitly just in case.

TEST PLAN
  - Got a notificaton about my headphones running low

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D25951

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25950: Add specialized notification for Bluetooth battery

[Kai Uwe Broulik]

broulik updated this revision to Diff 71439.
broulik added a comment.


  - Drop odd parentheses

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25950?vs=71437=71439

REVISION DETAIL
  https://phabricator.kde.org/D25950

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25950: Add specialized notification for Bluetooth battery

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since we have a type for generic Bluetooth devices now, add a specialized 
notification for it.

TEST PLAN
  Needs another patch to actually work as Bluetooth reports no charge state
  F7816444: Screenshot_20191213_144643.png 


REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D25950

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25942: Instead of just delaying, compress calls to update

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:110
> +
> +onWidthChanged: { delayUpdate.start = true }
> +Component.onCompleted: { delayUpdate.start = true }

How can this even work? `start` is a method. You probably meant `running = 
true`? or `start()` which, in contrast to a `QTimer` will *not* restart the 
timer if already running.

So apparently this isn't necessary at all, if it not doing anything actually 
works?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik updated this revision to Diff 71413.
broulik added a comment.


  - Restore condition

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25917?vs=71412=71413

REVISION DETAIL
  https://phabricator.kde.org/D25917

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik updated this revision to Diff 71412.
broulik added a comment.


  - Cleanup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25917?vs=71350=71412

REVISION DETAIL
  https://phabricator.kde.org/D25917

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart