D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  What color is the area on the inside of the cursor? I'm not sure, but it 
looks like it has a gradient, which doesn't really match the other Breeze 
cursors.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  In D16861#359066 , @ngraham wrote:
  
  > It is indeed a weird gradient. I was just trying to make the minimum 
required number of changes to fix the bug, but I can fix that too if you'd like.
  
  
  Yes, if you're going to add an outline like the other breeze cursor states, 
you might as well make the inside match. I think it wold probably look better 
too.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  You should probably do Breeze Snow as well since it has the exact same issue. 
In fact, it's probably even worse since a majority of websites use a white 
background.F6421382: Screenshot_20181113_135123.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  Those crosshair outlines seem to be a bit jagged, unlike the other breeze 
crosshairs.
  F6421397: Screenshot_20181113_135510.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  In D16861#359106 , @ngraham wrote:
  
  > Yeah, they currently have hard edges. I'm sadly pretty abysmal with this 
kind of pixel art, but hopefully I'll muddle through...
  
  
  Maybe the original cursors were made with SVG sources? Could those be found 
somewhere?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  Turns out there already is an outline, but it's at 10% opacity instead of 
100% and the crosshair doesn't have a blurred shadow around it like the other 
breeze cursors. I think we should do our best to try to keep the crosshair 
feeling precise while also improving the contrast around it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  In D16861#359124 , @ngraham wrote:
  
  > Would you like to take over? I have a feeling that you can do a better job 
than I can, and you also know what you're doing with the tools, too. :)
  
  
  Sure. I've basically already completed it from fooling around.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  I find the Breeze Snow cursors to bee generally lacking in contrast because 
of the 60% opacity outline. Should I expand this commit to improve the contrast 
for all Breeze Snow cursors as well?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  What's the best way to update this diff? What I'm doing completely discards 
your changes. Should I get this diff with `arc patch D16861` and then update 
the diff from that branch or can I make my own branch and do `arc diff --update 
D16861` to overwrite your changes?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  Why do we have the cursor theme pre-built in the repo? It's making Arcanist 
take forever.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis updated this revision to Diff 45434.
ndavis added a comment.


  Improve contrast for Breeze Snow and Breeze crosshair

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16861?vs=45429&id=45434

BRANCH
  better-crosshair-cursor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16861

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/alias
  cursors/Breeze/Breeze/cursors/all-scroll
  cursors/Breeze/Breeze/cursors/bottom_left_corner
  cursors/Breeze/Breeze/cursors/bottom_right_corner
  cursors/Breeze/Breeze/cursors/bottom_side
  cursors/Breeze/Breeze/cursors/cell
  cursors/Breeze/Breeze/cursors/center_ptr
  cursors/Breeze/Breeze/cursors/col-resize
  cursors/Breeze/Breeze/cursors/color-picker
  cursors/Breeze/Breeze/cursors/context-menu
  cursors/Breeze/Breeze/cursors/copy
  cursors/Breeze/Breeze/cursors/crosshair
  cursors/Breeze/Breeze/cursors/default
  cursors/Breeze/Breeze/cursors/dnd-move
  cursors/Breeze/Breeze/cursors/dnd-no-drop
  cursors/Breeze/Breeze/cursors/down-arrow
  cursors/Breeze/Breeze/cursors/draft
  cursors/Breeze/Breeze/cursors/fleur
  cursors/Breeze/Breeze/cursors/help
  cursors/Breeze/Breeze/cursors/left-arrow
  cursors/Breeze/Breeze/cursors/left_side
  cursors/Breeze/Breeze/cursors/no-drop
  cursors/Breeze/Breeze/cursors/not-allowed
  cursors/Breeze/Breeze/cursors/openhand
  cursors/Breeze/Breeze/cursors/pencil
  cursors/Breeze/Breeze/cursors/pirate
  cursors/Breeze/Breeze/cursors/pointer
  cursors/Breeze/Breeze/cursors/progress
  cursors/Breeze/Breeze/cursors/right-arrow
  cursors/Breeze/Breeze/cursors/right_ptr
  cursors/Breeze/Breeze/cursors/right_side
  cursors/Breeze/Breeze/cursors/row-resize
  cursors/Breeze/Breeze/cursors/size_bdiag
  cursors/Breeze/Breeze/cursors/size_fdiag
  cursors/Breeze/Breeze/cursors/size_hor
  cursors/Breeze/Breeze/cursors/size_ver
  cursors/Breeze/Breeze/cursors/text
  cursors/Breeze/Breeze/cursors/top_left_corner
  cursors/Breeze/Breeze/cursors/top_right_corner
  cursors/Breeze/Breeze/cursors/top_side
  cursors/Breeze/Breeze/cursors/up-arrow
  cursors/Breeze/Breeze/cursors/vertical-text
  cursors/Breeze/Breeze/cursors/wait
  cursors/Breeze/Breeze/cursors/wayland-cursor
  cursors/Breeze/Breeze/cursors/x-cursor
  cursors/Breeze/Breeze/cursors/zoom-in
  cursors/Breeze/Breeze/cursors/zoom-out
  cursors/Breeze/build/x1/alias.png
  cursors/Breeze/build/x1/all-scroll.png
  cursors/Breeze/build/x1/bottom_left_corner.png
  cursors/Breeze/build/x1/bottom_right_corner.png
  cursors/Breeze/build/x1/bottom_side.png
  cursors/Breeze/build/x1/cell.png
  cursors/Breeze/build/x1/center_ptr.png
  cursors/Breeze/build/x1/col-resize.png
  cursors/Breeze/build/x1/color-picker.png
  cursors/Breeze/build/x1/context-menu.png
  cursors/Breeze/build/x1/copy.png
  cursors/Breeze/build/x1/crosshair.png
  cursors/Breeze/build/x1/default.png
  cursors/Breeze/build/x1/dnd-move.png
  cursors/Breeze/build/x1/dnd-no-drop.png
  cursors/Breeze/build/x1/down-arrow.png
  cursors/Breeze/build/x1/draft.png
  cursors/Breeze/build/x1/fleur.png
  cursors/Breeze/build/x1/help.png
  cursors/Breeze/build/x1/left-arrow.png
  cursors/Breeze/build/x1/left_side.png
  cursors/Breeze/build/x1/no-drop.png
  cursors/Breeze/build/x1/not-allowed.png
  cursors/Breeze/build/x1/openhand.png
  cursors/Breeze/build/x1/pencil.png
  cursors/Breeze/build/x1/pirate.png
  cursors/Breeze/build/x1/pointer.png
  cursors/Breeze/build/x1/progress-01.png
  cursors/Breeze/build/x1/progress-02.png
  cursors/Breeze/build/x1/progress-03.png
  cursors/Breeze/build/x1/progress-04.png
  cursors/Breeze/build/x1/progress-05.png
  cursors/Breeze/build/x1/progress-06.png
  cursors/Breeze/build/x1/progress-07.png
  cursors/Breeze/build/x1/progress-08.png
  cursors/Breeze/build/x1/progress-09.png
  cursors/Breeze/build/x1/progress-10.png
  cursors/Breeze/build/x1/progress-11.png
  cursors/Breeze/build/x1/progress-12.png
  cursors/Breeze/build/x1/progress-13.png
  cursors/Breeze/build/x1/progress-14.png
  cursors/Breeze/build/x1/progress-15.png
  cursors/Breeze/build/x1/progress-16.png
  cursors/Breeze/build/x1/progress-17.png
  cursors/Breeze/build/x1/progress-18.png
  cursors/Breeze/build/x1/progress-19.png
  cursors/Breeze/build/x1/progress-20.png
  cursors/Breeze/build/x1/progress-21.png
  cursors/Breeze/build/x1/progress-22.png
  cursors/Breeze/build/x1/progress-23.png
  cursors/Breeze/build/x1/progress.png
  cursors/Breeze/build/x1/right-arrow.png
  cursors/Breeze/build/x1/right_ptr.png
  cursors/Breeze/build/x1/right_side.png
  cursors/Breeze/build/x1/row-resize.png
  cursors/Breeze/build/x1/size_bdiag.png
  cursors/Breeze/build/x1/size_fdiag.png
  cursors/Breeze/build/x1/size_hor.png
  cursors/Breeze/build/x1/size_ver.png
  cursors/Breeze/build/x1/text.png
  cursors/Breeze/build/x1/top_left_corner.png
  cursors/Breeze/build/x1/top_right_corner.png
  cursors/Breeze/build/x1/top_side.png
  cursors/Breeze/build/x1/up-arrow.png
  cursors/Breeze/build/x1/vertical-text.png
  curso

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  I'd like to remove the extra junk, but I don't want to break anything either.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Noah Davis]

ndavis added a comment.


  In D16861#359170 , @ngraham wrote:
  
  > So is there a script that regenerates all the X11 cursor files from the SVG 
whenever it's changed or something? Because I'm willing to bet you didn't 
change all 654 cursors...
  
  
  There's a `build.sh` file that uses `xcursorgen`. I used that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Noah Davis]

ndavis added a comment.


  I think I found the reason why the prebuilt cursor themes are included in the 
repo in the README:
  
  > No trimming will have been done to the cursors, and X11 *may* give you 
split-second glitches when switching cursors making them appear to 'jump' for 
an instant. To remedy this, you will need to open any auto-generated in gimp 
and re-export when with the “trim whitespace” option checked. I do not beleive 
it impacts all versions of X, or Wayland.
  
  
  
  > You will need the “X11 Mouse Cursor (XMC)” plugin for GIMP installed to 
trim the cursors if you choose to do so.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Noah Davis]

ndavis planned changes to this revision.
ndavis added a comment.


  Hmm some of the cursors seem blurrier than they used to be and I have no idea 
why.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for crosshair cursors

[Noah Davis]

ndavis added a comment.


  In D16861#359193 , @ngraham wrote:
  
  > Imagine that, reading the README. :) If manual work is required for each 
image, that seems like all the more reason to only include the two changed ones 
in the diff.
  
  
  Yep. This is a terrible workflow. I hope all of this is simpler in Wayland. 
One SVG for each cursor and just using the SVGs as cursor files would be ideal.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for crosshair cursors

[Noah Davis]

ndavis updated this revision to Diff 45482.
ndavis added a comment.


  Only change crosshair cursors and source SVG

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16861?vs=45434&id=45482

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16861

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/crosshair
  cursors/Breeze/build/x1/crosshair.png
  cursors/Breeze/build/x1_5/crosshair.png
  cursors/Breeze/build/x2/crosshair.png
  cursors/Breeze/src/cursors.svg
  cursors/Breeze_Snow/Breeze_Snow/cursors/crosshair
  cursors/Breeze_Snow/build/x1/crosshair.png
  cursors/Breeze_Snow/build/x1_5/crosshair.png
  cursors/Breeze_Snow/build/x2/crosshair.png
  cursors/Breeze_Snow/src/cursors.svg

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17038: Fix uncentered crosshairs

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For some reason, the centers of the generated PNGs are not the centers of the 
crosshairs. I had to move the 1x crosshairs down and to the left by 2px, the 
1.5x crosshairs by 3px and the 2x crosshairs by 3px (it's more centered than 
4px).

REPOSITORY
  R31 Breeze

BRANCH
  center-crosshair (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17038

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/crosshair
  cursors/Breeze/build/x1/crosshair.png
  cursors/Breeze/build/x1_5/crosshair.png
  cursors/Breeze/build/x2/crosshair.png
  cursors/Breeze/src/cursors.svg
  cursors/Breeze_Snow/Breeze_Snow/cursors/crosshair
  cursors/Breeze_Snow/build/x1/crosshair.png
  cursors/Breeze_Snow/build/x1_5/crosshair.png
  cursors/Breeze_Snow/build/x2/crosshair.png
  cursors/Breeze_Snow/src/cursors.svg

To: ndavis, #vdg, #breeze, #plasma
Cc: plasma-devel, #plasma, #breeze, #vdg, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17038: Fix uncentered crosshairs

[Noah Davis]

ndavis added a comment.


  In D17038#363375 , @ngraham wrote:
  
  > Whoops! Nice find, and nice fix. Since the other crosshair patch went into 
the `Plasma/5.12` stable branch, let's do the same thing here. You wanna have 
another go at 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22?
  
  
  Sure. I'll let you know if I have trouble again.

REPOSITORY
  R31 Breeze

BRANCH
  center-crosshair (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17038

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: ngraham, plasma-devel, #plasma, #breeze, #vdg, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  In D17073#364003 , @trmdi wrote:
  
  > How about this ?
  >  F6436415: test.png 
  
  
  I think this version works much better than the other 2. It shows the entire 
image and it fills up the space while maintaining the consistent thumbnail size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  If you want to try adding blur to the background, check out the code here: 
https://cgit.kde.org/elisa.git/tree/src/qml/HeaderBar.qml#n53

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  That blur looks nice, but I think the background should be more opaque like 
the Elisa header background.F6437066: Screenshot_20181122_005432.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  In D17073#364541 , @trmdi wrote:
  
  > In D17073#364393 , @ndavis wrote:
  >
  > > That blur looks nice, but I think the background should be more opaque 
like the Elisa header background.F6437066: Screenshot_20181122_005432.png 

  >
  >
  > Do you want to suggest some numbers ?
  
  
  100%. I think having the same look as Elisa's header would look nice. If you 
think something else looks better go with that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17152: Hide the badge if number too big

[Noah Davis]

ndavis added a comment.


  Why not abbreviate the number and round the abbreviated number instead? 
Instead of using "9,999+" for 11000, use "11K".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17152

To: svuorela, #plasma, hein, broulik, #vdg, ngraham
Cc: ndavis, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Noah Davis]

ndavis added a comment.


  I think we should be using a monochrome icon here. An equivalent monochrome 
icon would be `favorite`, but I don't think "favorite" is a good symbol for 
"alternatives". Maybe `preferences-other`/`application-menu` (same icon) would 
be good? It might be outside the scope of this patch anyway since this means 
the alternatives icon needs to be changed outside the edit mode as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17440: Rotate busy indicator clockwise

[Noah Davis]

ndavis added a comment.


  Makes sense to me. Time moves clockwise on a clock.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D17440

To: GB_2, #breeze, #vdg
Cc: ndavis, #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17346: Support Bluetooth batteries

[Noah Davis]

ndavis added a comment.


  Does it have to be in the Plasma theme? I want to move all icons into 
breeze-icons eventually.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17346

To: broulik, #plasma, bruns, #vdg
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

[Noah Davis]

ndavis added a comment.


  +1 to making the menus the same.
  
  In D17393#373155 , @hein wrote:
  
  > Can we patch Dolphin instead? I think the order there is pretty bad, with 
weird random dividers etc. (From the screenshots in the original user bug.) I 
prefer FV's.
  
  
  To me, the folder view menu is the one with seemingly random dividers, and a 
lack of dividers. In the dolphin menu, I see a clear progression:
  
  1. Open section
  2. Clipboard section
  3. options that can affect other programs (missing files due to removal or 
name change)
- It can be argued that Cut would belong here and I don't think it would be 
bad if clipboard actions, rename and delete were in the same section.
  4. Misc actions
- Better organization might be a good idea, but that's out of scope here
  5. Properties
- this option is always kind of special

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein, #vdg
Cc: ndavis, mart, janpr, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17751: Add shadow to Hour's hand

[Noah Davis]

ndavis added a comment.


  In D17751#381431 , @shubham wrote:
  
  > How could the shadow appearance be fixed? In breeze icons?
  
  
  No, the SVG that the analog clock uses is in plasma-framework

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17751: Add shadow to Hour's hand

[Noah Davis]

ndavis added a comment.


  In D17751#382113 , @shubham wrote:
  
  > In D17751#381435 , @ndavis wrote:
  >
  > > No, the SVG that the analog clock uses is in plasma-framework
  >
  >
  > Can you tell me how to fix it in plasma framework svg? I dont know about 
svg.
  
  
  Well, you open it up in Inkscape and fix it in there. I know that's not 
particularly helpful, but I can't tell you exactly what you need to do unless 
you ask me a specific question about how to do something. This might be the 
wrong approach though. If your goal is simply to make the shadow move with the 
hand in a way that has a consistent light direction, you'll need to rotate and 
move the object depending on the time in the code here. I think the light 
source should be in the top left coming down diagonally to the bottom right 
since that's how it is for most Breeze icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1
  It works for the majority of wallpapers much better than just scaling.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  scaled-and-cropped-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18004

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Noah Davis]

ndavis added a comment.


  What happens if my wallpaper is set to the 1080p version of the default 
wallpaper and then that version is removed with only the highest resolution 
version left?

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Noah Davis]

ndavis added a comment.


  In D18005#387324 , @ngraham wrote:
  
  > However, just removing files from the repo doesn't actually remove them 
from users' machines; their packaging system does that. Perhaps we should alert 
packagers that for the 5.15 release, they shouldn't remove these files from 
users' machines when they disappear from the repo.
  
  
  Sounds reasonable.

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Noah Davis]

ndavis added a comment.


  Should I accept now or should I wait until that gets sorted out?

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Noah Davis]

ndavis added a comment.


  > Should I add presets like Event Calendar?
  
  I'm leaning towards no, but an example of the custom time formatting and 
another of HTML styling would be a good idea.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Noah Davis]

ndavis added a comment.


  In D18019#388819 , @Zren wrote:
  
  > In D18019#388811 , @ndavis wrote:
  >
  > > I'm leaning towards no, but a second link to text formatting 
documentation might be a good idea.
  >
  >
  > Adding a second link is pretty easy, though I wrote this before I noticed 
your edit. A second link would look better + simpler to maintain though. Though 
without a RichText example, the user might not understand the need to escape 
using apostrophes without an example (`''ddd''` ).
  >
  > > I'm leaning towards no, but an example of the custom time formatting and 
another of Rich Text formatting would be a good idea.
  >
  > Here's an example table, using an unconventional method of drawing a grid.
  >
  > F6533733: 2019-01-08___00-40-47.png 
  
  
  Shouldn't the documentation explain that apostrophes need to be used or is 
the fact that they need to be used unusual and specific to this clock widget?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Noah Davis]

ndavis added a comment.


  In D18019#388876 , @mart wrote:
  
  > is this the right place for it? (a text field to enter the "magic" date 
format letters is a very geeky ui, and i would prefer to not go there) 
shouldn't be a generic localization/date format setting? (and with also a 
graphical ui to generate this)
  
  
  That already exists as other combo box options. You can pick "Long Date" 
(localized), "Short Date" (localized) or ISO. This adds the ability to do 
anything you want as an extra option.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: mart, ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Noah Davis]

ndavis added a comment.


  I think some users may want to have a separate date format for their clock 
than the rest of the system. A user might prefer to use ISO date format with 
only the last 2 digits of the year in their clock because it saves space, but 
they might prefer to use regular ISO date format everywhere else. They may also 
not want a system wide date format with hardcoded custom text colors.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: abetts, cfeck, ngraham, mart, ndavis, rooty, plasma-devel, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D18381: Add tooltip to configure panel button

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I think this is a good idea. We've always done a rather poor job of telling 
new users how to modify the panel and this helps a bit. Now let's wait for 
input from #plasma  people.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-configure-panel-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18381

To: GB_2, #plasma, #vdg, ndavis
Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18530: Change Activities KCM icon

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  KCMs should have color icons while widgets should have monochrome icons, so I 
have changed the name of the KCM icon.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  preferences-desktop-activities (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18530

AFFECTED FILES
  kcms/activities/kcm_activities.desktop

To: ndavis, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18531: Change icon for Activities config

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  KCMs should have color icons while widgets should have monochrome icons, so I 
have changed the name of the KCM icon.

REPOSITORY
  R122 Powerdevil

BRANCH
  preferences-desktop-activities (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18531

AFFECTED FILES
  kcmodule/activities/powerdevilactivitiesconfig.desktop

To: ndavis, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18532: Change icons for Activities dataengine and runner

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  KCMs should have color icons while widgets should have monochrome icons, so I 
have changed the name of the KCM icon.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  preferences-desktop-activities (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18532

AFFECTED FILES
  dataengines/activities/plasma-dataengine-activities.desktop
  runners/activities/plasma-runner-activityrunner.desktop

To: ndavis, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18530: Change Activities KCM icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6d5be4517b74: Change Activities KCM icon (authored by 
ndavis).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18530?vs=50274&id=50283

REVISION DETAIL
  https://phabricator.kde.org/D18530

AFFECTED FILES
  kcms/activities/kcm_activities.desktop

To: ndavis, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18531: Change icon for Activities config

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:fc25c7f468bd: Change icon for Activities config (authored 
by ndavis).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18531?vs=50275&id=50284

REVISION DETAIL
  https://phabricator.kde.org/D18531

AFFECTED FILES
  kcmodule/activities/powerdevilactivitiesconfig.desktop

To: ndavis, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18532: Change icons for Activities dataengine and runner

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ffc47c6e226e: Change icons for Activities dataengine and 
runner (authored by ndavis).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18532?vs=50276&id=50285

REVISION DETAIL
  https://phabricator.kde.org/D18532

AFFECTED FILES
  dataengines/activities/plasma-dataengine-activities.desktop
  runners/activities/plasma-runner-activityrunner.desktop

To: ndavis, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Noah Davis]

ndavis added a comment.


  I'm not sure if the `tools` icon is actually appropriate here. I know it's 
called the Desktop Toolbox, but it doesn't work at all like the tools menus in 
Spectacle or KSysGuard. It's almost like a button to open the desktop context 
menu, except it also shows the controls for widgets. It doesn't seem like a 
menu for a set of tools.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Noah Davis]

ndavis added a comment.


  In D18546#400325 , @Codezela wrote:
  
  > In D18546#400256 , @GB_2 wrote:
  >
  > > In D18546#400253 , @hein wrote:
  > >
  > > > How about we actually rename it "Desktop Menu".
  > >
  > >
  > > +1, good idea!
  >
  >
  > or we can remove it completely
  >  it looks strange no one doing it except kde
  >  what do u think
  >  mac windows gnome cinnamon mate budgie
  >  xfce lxqt
  >  we can make this tools show with shortucut like
  >  ctrl+ mouse click on the desktop for example
  >  i think without it the desktop will look much simple and clean
  
  
  I'm mostly for removing it. A common question new users ask is how to remove 
it.
  However, the way we expose desktop widget controls is not the most intuitive 
or ergonomic for mouse & keyboard users. Long click is a mobile thing that 
isn't intuitive in the first place. We need a way to quickly expose the 
controls for desktop widgets in a way that is fairly discoverable. This is off 
topic though and this discussion should probably happen somewhere more 
permanent like a task.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Noah Davis]

ndavis added a comment.


  If we are going to change the name, I would suggest changing it to something 
that has a similar meaning to "edit the desktop" and change the icon to 
something that means "edit". That's the primary use for this widget anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18571: Add "apply on double-click" feature to most other recent ported KCMs

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1 to this. It's nice when you already know what you're doing and want to 
change a setting quickly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-kcms-apply-on-double-click (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18571

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18571: Add "apply on double-click" feature to most other recent ported KCMs

[Noah Davis]

ndavis added a comment.


  In D18571#401553 , @ngraham wrote:
  
  > One of the things I loved about macOS when I was a user was how many little 
hidden accelerators like this were sprinkled throughout the OS. You don't find 
them unless you go looking, but once you've found them, they're indispensable. 
There was a whole website I used to follow back in the day to learn about even 
more of them: https://hints.macworld.com/
  >
  > I don't think this would be too non-discoverable anyway; I was actually 
surprised that a double-click //didn't// function this way the first time I 
tried it. Double-click on a grid element to select + apply seems fairly natural 
to me at least.
  
  
  I think having some hidden, non-essential features that speed things up here 
and there is not a bad idea. It's not an objective reason, but I think a lot of 
people enjoy finding features like these. It turns the software into something 
to be mastered while still appearing simple at first. One of my favorite pieces 
of software, FL Studio, is absolutely littered with these kinds of features 
(perhaps going too far with it) and everyone who uses it loves sharing tips and 
tricks and finding new ones. It helps bring FL Studio users together and makes 
them more proud of being FL Studio users.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-kcms-apply-on-double-click (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18571

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: davidedmundson, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18651: [Task Manager] Sort manually by default

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  I agree with this.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  allow-task-re-ordering-by-default (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18651

To: ngraham, #vdg, #plasma, hein, ndavis
Cc: ndavis, alexeymin, broulik, mart, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Noah Davis]

ndavis added a comment.


  I thought we primarily used 22px and not 24px? While it does make the icons 
look more consistent as long as there are no monochrome 24px versions (there 
are some) should there be an exception to the norm? If so, we would have to 
remove all 24px monochrome icons. That might not be such a big deal anymore and 
I'm not aware of any apps that require 24px icons. I think 32px scaled down to 
24px also looks better than 32px scaled down to 22px, so I would be in favor of 
that solution.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Noah Davis]

ndavis added a comment.


  In D18797#406739 , @ngraham wrote:
  
  > In D18797#406733 , @ndavis wrote:
  >
  > > I thought we primarily used 22px and not 24px? While it does make the 
icons look more consistent as long as there are no monochrome 24px versions 
(there are some) should there be an exception to the norm? If so, we would have 
to remove all 24px monochrome icons.
  >
  >
  > No, just all monochrome 24px versions of color `preferences-*` icons, of 
which there are only two:
  >
  >   /usr/share/icons/breeze$  find */24/ | grep -i preferences-
  >   actions/24/preferences-activities.svg
  >   actions/24/preferences-other.svg
  >
  >
  > None of these are currently used by any KCMs (Activities uses your nice new 
`preferences-desktop-activities` icon).
  
  
  Alright, that sounds reasonable.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Noah Davis]

ndavis added a comment.


  In D18797#406754 , @ngraham wrote:
  
  > Next question: KInfoCenter's version of this tooltip currently hardcodes 
32x32 for the size of the parent icon above it rather than using the 
`KIconLoader::Dialog` size (which defaults to 32x32).. Should we do that here 
too so that there's never a case where the parent icon could be smaller than 
the child icon for the corner case of a user who has set the 
`KIconLoader::Dialog` size to something smaller than its default?
  
  
  Is hardcoding a good idea? What if a new size was added to KIconLoader with a 
default size of 24px? Then we could reuse the same thing in Plasma's Kicker 
menu to make the icons more colorful and make the 32 and 48 px icons scale down 
better.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Noah Davis]

ndavis added a comment.


  The idea would be that 16 and 22px are for monochrome and 24px and above 
could be for color.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Noah Davis]

ndavis added a comment.


  Oh I understand now. These sizes are user configurable. In that case, I 
suppose it doesn't make sense to add a 24px option and hardcoding is probably 
fine as long as it's compatible with UI scaling for HiDPI screens.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Noah Davis]

ndavis added a comment.


  I don't like the look of the `|` character between the font name and the font 
size. I think the existing "Noto Sans 10" format looked better, but I'm not 
going to formally request changes.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Noah Davis]

ndavis added a comment.


  In D18861#408286 , @ngraham wrote:
  
  > Personally my preference would be for the strings to be like this: `10 pt 
Noto Sans`
  
  
  That would be fine too since it reads like English. The `|` character makes 
it seem like we're mixing TUI with GUI.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The current shadow color is Shade Black, which is also used as the 
ViewBackground color in Breeze dark. This makes the shadow invisible when 2 
windows without borders overlap with touching View areas. It also makes color 
banding worse on cheap displays. Changing the color to black makes the shadow 
visible on most backgrounds and slightly improves the look of the shadow on 
cheap displays.

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19124

AFFECTED FILES
  kdecoration/breezesettingsdata.kcfg

To: ndavis, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:dce32ce1e0ed: Change shadow color to 0,0,0 (authored by 
ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19124?vs=51989&id=51991

REVISION DETAIL
  https://phabricator.kde.org/D19124

AFFECTED FILES
  kdecoration/breezesettingsdata.kcfg

To: ndavis, #vdg, ngraham, filipf
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Noah Davis]

ndavis added a comment.


  alright

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19124

To: ndavis, #vdg, ngraham, filipf
Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Continuation of D19124 

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

AFFECTED FILES
  kstyle/breeze.kcfg

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

ndavis added a comment.


  In D19125#414786 , @zzag wrote:
  
  > Should we adjust opacity as well?
  
  
  That's the strength value, right? I don't think so.

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

ndavis added a comment.


  In D19125#414788 , @ngraham wrote:
  
  > Nah, I think that would begin to re-introduce the bug we're trying to solve 
(shadows not being visible in Breeze Dark).
  
  
  Also, worse color banding on cheap displays

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle 
(authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19125?vs=51995&id=51998

REVISION DETAIL
  https://phabricator.kde.org/D19125

AFFECTED FILES
  kstyle/breeze.kcfg

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Fix TODO to follow w3.org standard for shadow-blur

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19134

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp

To: ndavis, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Noah Davis]

ndavis added a comment.


  TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. 
Here's how it looks with Breeze Dark.F6622189: Screenshot_20190218_172518.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: ndavis, mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:cd04f42432a6: Multiply radius by 0.5 in 
calculateBlurStdDev() (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19134?vs=52016&id=52020

REVISION DETAIL
  https://phabricator.kde.org/D19134

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp

To: ndavis, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Before, shadow size doubled with each new size until Very Large and the 
smaller shadows were more transparent than the larger shadows. Now shadow size 
increases linearly and smaller shadows start with more opacity so that they 
don't become nearly invisible. The Very Small size was added to allow users to 
continue using big shadows and preserve the original size of Small.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/ui/breezeconfigurationui.ui

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis updated this revision to Diff 52036.
ndavis added a comment.


  Change default shadow size to medium

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19148?vs=52035&id=52036

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/ui/breezeconfigurationui.ui

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis added a comment.


  In D19148#415123 , @rooty wrote:
  
  > I like this idea, more variety
  >  Especially considering that the default setting doesn't really change, 
just gets renamed essentially?
  
  
  Not quite. Very Small is about the same size as the current Small (git 
master), but I did adjust the opacity to make it more visible. Small is now the 
same size as the current Medium, but with different opacity values. Medium is a 
new size that is between the current size and Large. Large is the same size 
with different opacity. Very Large is a bit smaller with different opacity. 
Smaller sizes start with more opacity than larger sizes to keep smaller sizes 
visible and to keep large sizes from being visually overpowering.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis updated this revision to Diff 52107.
ndavis added a comment.


  Remove ShadowVerySmall

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19148?vs=52036&id=52107

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp

To: ndavis, #vdg, #breeze
Cc: ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  Small and Medium are  the same sizes they originally were, Large is 1.5x 
Medium and Very large is now the same size that Large was. I've also adjusted 
the starting opacity of the shadows a bit more.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze
Cc: ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Noah Davis]

ndavis added a comment.


  +1 from me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  In D19148#415929 , @zzag wrote:
  
  > What about kstyle? Is it okay?
  
  
  kstyle uses entirely different shadows, even more so compared to the original 
values for kdecoration. Should it not be that way?

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  In D19148#416749 , @zzag wrote:
  
  > In D19148#416006 , @ndavis wrote:
  >
  > > kstyle uses entirely different shadows, even more so compared to the 
original values for kdecoration. Should it not be that way?
  >
  >
  > Well, my concern was that now decoration shadows are way too black in 
comparison to kstyle shadows.
  >
  > Also, I have a question about shadow that comes from directional light, why 
opacity decreases as size increases? Shouldn't it be vice versa?
  
  
  I'm not an expert on this kind of thing, so I'm open to doing more 
modifications. I still don't really get how the ambient shadow works vs the 
directional one.
  However, if an object casting a shadow is closer to the object in the shadow, 
the shadow will be darker than if the object casting the shadow is farther away.
  Try it right now with two pieces of paper under a ceiling light.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  In D19148#417251 , @zzag wrote:
  
  > Well, I guess that depends on the light. After all we don't try to model 
"physically correct" shadows.
  >
  > Anyway, I've asked that question about opacity because most folks do the 
same thing. Also, this is what I did in kstyle. Even though kstyle and 
kdecoration shadows look different, I'd like to have the same "model" behind 
them. In general, I like the idea of decreasing shadow sizes to more saner 
values, but I'm not quite sure about new opacity values.
  >
  > My thinking behind increasing opacity values was to keep darkness at some 
"constant" level, e.g. if you increase the blur radius, the darkness will be 
spreaded more, so to compensate that the opacity is increased.
  
  
  But then we run into a problem where small shadows aren't visible enough to 
serve their purpose. How about we just get rid of different opacity for 
different shadows and let the user control that with strength? Then we set the 
default strength to a value that we think is appropriate for the default shadow 
size.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  @zzag Is the only difference between the ambient and directional shadow the Y 
axis offset?

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  In D19148#418158 , @zzag wrote:
  
  > In D19148#418083 , @ndavis wrote:
  >
  > > @zzag Is the only difference between the ambient and directional shadow 
the Y axis offset? If so, why do we have two shadows if they don't work 
differently?
  >
  >
  > Well, no, that's not that easy, we need them both. On its own, the 
directional shadow is a little bit harsh/sharp, so the ambient shadow is used 
to make it softer. Generally speaking, I took inspiration from material shadows 
. Pay close 
attention to pictures in "light and shadows" section.
  
  
  I've looked and while it helped me a little understand what it was meant to 
achieve, it didn't help me understand how it actually works. I'm not even sure 
if I can see a difference with and without ambient shadow.
  
  This is Very Large with 100% directional and 0% ambient F6632103: 
Screenshot_20190223_190524.png 
  This is Very Large with 100% directional and 100% ambient F6632107: 
Screenshot_20190223_190427.png 
  
  If the ambient shadow actually did anything, wouldn't the inner areas of the 
shadow be significantly different in the second screenshot?

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  This is directional (64 size, 100% opacity) and ambient (1000 size, 100% 
opacity).
  F6632129: Screenshot_20190223_194638.png 

  F6632131: Screenshot_20190223_194651.png 


REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis updated this revision to Diff 52421.
ndavis added a comment.


  Update kstyle and increase size of kdecoration ambient shadows to 1/2 of 
directional shadows.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19148?vs=52107&id=52421

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kstyle/breezeshadowhelper.cpp

To: ndavis, #vdg, #breeze, ngraham, rooty
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  TBH, I can't tell a difference between the old KStyle shadows and the new 
ones. Maybe I should have just left them as they were or maybe I should 
increase the opacity, but at least the numbers look pretty. ¯\_(ツ)_/¯

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham, rooty
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:8bfe474ac585: Make shadow sizes linear (authored by 
ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19148?vs=52421&id=52424

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kstyle/breezeshadowhelper.cpp

To: ndavis, #vdg, #breeze, ngraham, rooty
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19379: [sddm-theme] Add a bottom panel

[Noah Davis]

ndavis added a comment.


  -1
  
  I don't think it looks very nice. If you're worried about those UI elements 
not being visible, wouldn't it be better to move them towards the center? Then, 
if it's necessary, you can add a background to all the floating UI elements so 
that they're all visible.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19379

To: filipf, #vdg, #plasma, ngraham, rooty
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19379: [sddm-theme] Add a bottom panel

[Noah Davis]

ndavis added a comment.


  In D19379#421001 , @rooty wrote:
  
  > Center how? Vertically?
  >  Where would the elements be placed (with respect to the Clock / user 
names/avatars / action buttons)?
  
  
  Horizontally and maybe vertically. They could fit in the area above or below 
the Suspend, Reset, Shut Down, Other buttons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19379

To: filipf, #vdg, #plasma, ngraham, rooty
Cc: broulik, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  +1
  
  This is a much more usable design and more in line with our HIG.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis added a comment.


  In D19230#421215 , @abetts wrote:
  
  > Do you think that "locale" is a very specific term? Could it be different?
  
  
  The alternative would be "region", which is the term we use in the related 
settings KCM.F6643106: Screenshot_20190227_104128.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19392: shannon entropy to guess monochrome icon

[Noah Davis]

ndavis added a comment.


  In D19392#421903 , @ngraham wrote:
  
  > Actually we're discussing in VDG-land whether or not this is something we 
should do anyway, because right now we have no way of forcing the use of a 
monochrome icon for a >22px size when a larger colorful version exists. Using 
`-symbolic` to suffix the monochrome versions would allow us to do this. Adding 
some VDG folks for comment.
  
  
  The problem with using `-symbolic` for all monochrome icons is that we'd have 
to create color icons without `-symbolic` to replace the old monochrome icons 
without `-symbolic`. That means we'd be effectively reworking a great deal of 
Breeze icons. Outside of a few instances in System Settings, Plasmashell and 
KWin titlebars, where we want to use color icons at small sizes, Breeze looks 
pretty consistent already, even with 3rd party applications. In places like the 
Digital Clock widget, where a monochrome icon is used when a color icon should 
be used, that can be fixed in breeze-icons just by making a new color icon at 
the appropriate size. If all of our monochrome icons had to have `-symbolic`, 
then we'd have to depend on 3rd party applications using `-symbolic` to keep a 
consistent look as well.
  
  In short, we'd have to create a ton of new icons just to fix an issue that 
mainly exists in only a few pieces of our own software if we went the route 
with `-symbolic`. Maybe with a future icon theme, we can plan things out 
better, but I don't think we should do anything that greatly changes the look 
of breeze-icons.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19392

To: mart, #kirigami
Cc: ngraham, GB_2, ndavis, #vdg, cfeck, davidedmundson, plasma-devel, domson, 
dkardarakos, apol, mart, hein

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis added a comment.


  In D19230#421924 , @ngraham wrote:
  
  > I mean, what do you think about the specific string "Use region's default 
setting". Too wordy? Just right?
  
  
  You could use use "Default" and maybe have a button to open the Formats KCM 
nearby.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  I think so

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis added a comment.


  Can you hide the button to open the Formats KCM when "Use Region Defaults" is 
not selected?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis added a comment.


  In D19230#422088 , @ngraham wrote:
  
  > We could, but is that really necessary? In general we try to avoid having 
UI elements dynamically show and hide themselves outside of the 
narrowly-defined exception of when a UI element is inapplicable to the 
currently active hardware. That condition doesn't apply here, so what we would 
do instead is enable and disable the button, which I think would be a bit weird.
  
  
  Fair point. I just think it's not necessary to show the button if you're not 
using the setting that uses the settings behind the button.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19444: Make long menus scrollable instead of expanding horizontally

[Noah Davis]

ndavis added a comment.


  Horizontal menus are fast, but unusable or hard to read if they get too 
large. Scrollable menus with the arrows that you hover over are annoyingly slow 
if you don't use a scroll wheel to scroll, but don't block the entire screen if 
you have a large number of items. In both cases, the best solution from the 
user's end is to make more folders so that the list doesn't overflow.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Plasma Sprint 2019 in València

[Noah Davis]

What is the address of the place we will meet?

On 3/4/19, Aleix Pol  wrote:
> Does that mean you can't on those days? How does this change the
> prospect sprint?
>
> Aleix
>
> On Mon, Mar 4, 2019 at 11:08 AM Marco Martin  wrote:
>>
>> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
>> > Hi,
>> >
>> > > Sounds like we have some critical mass, Alejandro tells me that
>> > > there's space so let's settle for the 23rd June week.
>> >
>> > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual
>> > sprint days?
>>
>> oh, i tought that option was 23rd arrival :/
>>
>>
>> --
>> Marco Martin
>>
>>
>

Re: Plasma Sprint 2019 in València

[Noah Davis]

Not immediately, but I've never traveled outside the US and I'd like to be 
prepared.

On March 4, 2019 9:34:16 PM EST, Aleix Pol  wrote:
>I don't have it at hand, but does that really matter?
>
>Aleix
>
>On Mon, Mar 4, 2019 at 6:54 PM Noah Davis  wrote:
>>
>> What is the address of the place we will meet?
>>
>> On 3/4/19, Aleix Pol  wrote:
>> > Does that mean you can't on those days? How does this change the
>> > prospect sprint?
>> >
>> > Aleix
>> >
>> > On Mon, Mar 4, 2019 at 11:08 AM Marco Martin 
>wrote:
>> >>
>> >> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
>> >> > Hi,
>> >> >
>> >> > > Sounds like we have some critical mass, Alejandro tells me
>that
>> >> > > there's space so let's settle for the 23rd June week.
>> >> >
>> >> > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or
>actual
>> >> > sprint days?
>> >>
>> >> oh, i tought that option was 23rd arrival :/
>> >>
>> >>
>> >> --
>> >> Marco Martin
>> >>
>> >>
>> >

Re: Plasma Sprint 2019 in València

[Noah Davis]

I will, thank you.

On 3/5/19, Aleix Pol  wrote:
> Please, remember to submit your reimbursement request here:
> https://reimbursements.kde.org/events/88
>
> Aleix
>
> On Tue, Mar 5, 2019 at 1:12 PM Noah Davis  wrote:
>>
>> Not immediately, but I've never traveled outside the US and I'd like to be
>> prepared.
>>
>> On March 4, 2019 9:34:16 PM EST, Aleix Pol  wrote:
>> >I don't have it at hand, but does that really matter?
>> >
>> >Aleix
>> >
>> >On Mon, Mar 4, 2019 at 6:54 PM Noah Davis  wrote:
>> >>
>> >> What is the address of the place we will meet?
>> >>
>> >> On 3/4/19, Aleix Pol  wrote:
>> >> > Does that mean you can't on those days? How does this change the
>> >> > prospect sprint?
>> >> >
>> >> > Aleix
>> >> >
>> >> > On Mon, Mar 4, 2019 at 11:08 AM Marco Martin 
>> >wrote:
>> >> >>
>> >> >> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
>> >> >> > Hi,
>> >> >> >
>> >> >> > > Sounds like we have some critical mass, Alejandro tells me
>> >that
>> >> >> > > there's space so let's settle for the 23rd June week.
>> >> >> >
>> >> >> > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or
>> >actual
>> >> >> > sprint days?
>> >> >>
>> >> >> oh, i tought that option was 23rd arrival :/
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Marco Martin
>> >> >>
>> >> >>
>> >> >
>

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Parts of these icons did not line up well with the pixel grid making them 
seem blurry or faded. This has been fixed.

REPOSITORY
  R31 Breeze

BRANCH
  fix-titlebar-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19605

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Noah Davis]

ndavis updated this revision to Diff 53405.
ndavis added a comment.


  Fix formatting on line parameters for Shade button

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19605?vs=53403&id=53405

BRANCH
  fix-titlebar-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19605

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Noah Davis]

ndavis added subscribers: trickyricky26, ndavis.
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I like it overall, but some of those icons need changing. Not just here, but 
in breeze-icons as well.
  
  Resize: I don't like how busy that icon looks, but I"m not sure if it's worth 
it to make a new icon just for resizing windows.
  Maximize: The maximize icon is more like a "Maximized" icon because we 
normally use the up arrow for "Maximize".
  
  @trickyricky26 is already working on the shade icon and I know you requested 
keep-above and keep-below icons, so I'll ignore those for now.

INLINE COMMENTS

> ContextMenu.qml:569
> +text: i18n("&Fullscreen")
> +icon: "window-keep-above"
> +

Why was this changed from `view-fullscreen`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis
Cc: ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Noah Davis]

ndavis added a comment.


  In D19605#427037 , @zzag wrote:
  
  > This patch makes buttons sharp only for one particular button size and font 
size.
  
  
  You're right, but this makes it sharper at the default button+font size. 
Smaller sizes suffer, but larger sizes are OK for the most part. Considering 
how the lowest common display resolution right now is 1366x768 and the most 
common display size is 1920x1080, I think that's a fair trade off.
  
  Ideally, it should be sharp at all sizes, but I don't know how to do that and 
our window buttons don't seem to be setup in a way that would allow that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19605

To: ndavis, #vdg, #breeze, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart