[plasmashell] [Bug 447389] Notifications widget in the system tray shows items that are not clickable

[Nicolas Fella]

https://bugs.kde.org/show_bug.cgi?id=447389

Nicolas Fella  changed:

   What|Removed |Added

  Component|general |Notifications
Product|kwrited |plasmashell
   Assignee|plasma-devel@kde.org|k...@privat.broulik.de
   Target Milestone|--- |1.0
 CC||nicolas.fe...@gmx.de,
   ||plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kwrited] [Bug 447389] New: Notifications widget in the system tray shows items that are not clickable

[Benyamin]

https://bugs.kde.org/show_bug.cgi?id=447389

Bug ID: 447389
   Summary: Notifications widget in the system tray shows items
that are not clickable
   Product: kwrited
   Version: 5.23.4
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: benyamin.du...@gmail.com
  Target Milestone: ---

SUMMARY
***
Notifications widget in the system tray shows notification items that are not
clickable.
Single notification that is shown briefly (for 3-5seconds) is clickable (it
bring the corresponding app to the foreground)
***


STEPS TO REPRODUCE
1. Enable desktop notifications in Chrome/Gmail
2. Recieve email
3. Click notification popup, Chrome/Gmail is open with email content
4. Recieve another email
5. Wait for notification to disappear in the systray
3. Click Notifications widget. It shows Gmail notification in the list, but
it's not clickable

OBSERVED RESULT
Notifications widget in the system tray shows notification items that are not
clickable.

EXPECTED RESULT
Notification items in the Notifications widget are clickable.

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 21.10
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Port system tray away from SNI dataengine

[Marco Martin]

On domenica 2 maggio 2021 13:48:06 CEST Konrad Materka wrote:
> Hi,
> 
> I think I'm finally ready to take https://phabricator.kde.org/T13319 :)
> What is the best approach to DataEngine migration? It was/is a singleton,
> but System Tray can be instanced several times. In addition the SNI model
> can be quite heavy, it will use DBus a lot and will cache values (including
> images).Is it OK to put it in SystemTrayModel or should I create a
> singleton/plugin?
> 
> Is there any example (similar migration) that I can check?

So, we already have StatusNotifierModel, which at the moment is a 
DataEngineConsumer, but what you can do, is to keep that class, and instead of 
consuming a dataengine, it can consume a singleton qobject that will keep all 
the dbus operation and caching there. that thing would have signals of item 
added/removed/datachanged so it becomes easy to directly map this to a model.

-- 
Marco Martin

Port system tray away from SNI dataengine

[Konrad Materka]

Hi,

I think I'm finally ready to take https://phabricator.kde.org/T13319 :)
What is the best approach to DataEngine migration? It was/is a singleton,
but System Tray can be instanced several times. In addition the SNI model
can be quite heavy, it will use DBus a lot and will cache values (including
images).Is it OK to put it in SystemTrayModel or should I create a
singleton/plugin?

Is there any example (similar migration) that I can check?

-- 
Regards,
Konrad Materka

D29824: Avoid system tray resizing

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Currently, there was some code to avoid system tray resizing. However, being 
the properties not set to the root element, this was not having any effect. 
This fixes it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_resize_systray (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29824

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29824: Avoid system tray resizing

[Niccolò Venerandi]

niccolove added a comment.


  whops, this created a diff, not a MR

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29824

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks
  please phrase the commit message the opposite way. State what the commit 
changes, not what the state was before the commit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

[Eugene Popov]

epopov created this revision.
epopov added reviewers: ngraham, plasma-devel.
Herald added a project: Plasma.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Notifications applet and then remove all notifications, the 
Notifications applet closes itself.
  
  BUG: 421344

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29469: Icon in system tray missing when WireGuard connection active on startup

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:040a5c8ce9b0: Icon in system tray missing when WireGuard 
connection active on startup (authored by andersonbruce, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29469?vs=82052=82053

REVISION DETAIL
  https://phabricator.kde.org/D29469

AFFECTED FILES
  libs/declarative/connectionicon.cpp

To: andersonbruce, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight 
behind the icon (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29380?vs=81796=81809

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Konrad Materka]

kmaterka accepted this revision.
kmaterka added a comment.
This revision is now accepted and ready to land.


  OK, accepted

REPOSITORY
  R120 Plasma Workspace

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

filipf updated this revision to Diff 81796.
filipf added a comment.


  move the code change to CurrentItemHighlight.qml

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29380?vs=81785=81796

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  The same treatment is needed in `HiddenItemsView` to. Just move `z: -1` to 
`CurrentItemHighLight` component so that your fix will cover both cases.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29380

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  There was a slight issue introduced with D28109 
: the systray highlight can now cover up 
the icons it's highlighting.
  
  This isn't really an issue with Breeze because it uses a line for a 
highlight, but it is for themes that use a filled-style highlight.
  
  I set a z value for the highlight that should ensure it's now drawn only 
behind the icon.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis added a comment.


  It seems to me that this revision does not have the required momentum to move 
forward. I'll keep it open for another week in case someone else wants to chime 
in, but unless something changes I'll abandon it and maintain it off tree for 
personal use.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Ivan Čukić]

ivan added a comment.


  And I'l just be using my keyboard shortcut ;)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Nathaniel Graham]

ngraham added a comment.


  (If this patch lands, I'll set it to "Always visible" because I use my vault 
a lot)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Ivan Čukić]

ivan added a comment.


  I'm not fond of this change, but I agree with Nate's comment about the 
possibility of setting 'always visible' for users that wish to keep the current 
behaviour, so I'm not going to give this a -1.
  
  I'd still like the current behaviour kept, maybe with a different icon to 
show when there is a vault that is currently open to remedy one of the reasons 
behind this patch.
  
  But, again, this is a personal preference and I'm not going to block the 
patch if everybody else decides it is a good idea.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konrad Materka]

kmaterka added a comment.


  IMO it is the best **not** to add new status in System Tray - it is already 
quite confusing with "Disabled" state, the 3 other (Always hidden, Shown when 
relevant and Always shown) are OK and self-explanatory.
  "Shown when relevant" might be tricky and we will never please everyone. As 
stated in previous comment, this is tricky.
  
  Currently the decision is in the developer's hand only. There can be a 
configuration option, but too many options is also confusing. For configuration 
option, there additional questions: how to describe it with simple label? will 
users understand the purpose? what if applet is standalone (not in systemtray)? 
will user ever use it? is it easily discoverable? etc. If someone doesn't like 
default behavior it is always possible to force Shown/Hidden state. After all, 
it is not that users delete all vaults and creates new one on everyday basis.
  
  Personally I like the idea to hide Vaults icon when no vault is opened. I 
have one configured, but I use it very rarely, so for **me** it is better :) 
From the other side, Bluetooth and Network icons are visible not only when 
something is connected but also when connection is possible 
(Bluetooth/networking  is enabled). So maybe it would be more consistent if we 
leave it as it is now, wouldn't it? For someone who is using vaults often 
hiding Vaults icon might be really annoying. I don't know what's the best...
  
  BTW. For reference, MS Windows tries to hide as much as possible. But they 
are trying to kill system tray, so sometimes it is taken to the extreme and 
annoying.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> vaultsmodel.h:36
>  Q_PROPERTY(bool hasError READ hasError NOTIFY hasErrorChanged)
> +Q_PROPERTY(bool hasOpen READ hasOpen NOTIFY hasOpenChanged)
>  Q_PROPERTY(int count READ rowCount NOTIFY rowCountChanged)

I think this should be `openCount` to match `count`.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis added a comment.


  I gave it some thought and I would be reluctant to introduce one more fuzzy 
(as in ambiguous) state.
  
  More specifically, right now, we have four states: "Shown when relevant", 
"Always shown", "Always hidden", and "Disabled". Without having gone through 
the source code, I can guess what the latter three mean, but "Shown when 
relevant" is context-specific (and the reason this patch came to be). If we 
introduce another state, let's call it "Show when configured", we will just 
exacerbate the problem, because it is not immediately clear what it means. For 
instance, for the Bluetooth applet, does "configured" mean that I powered my 
adapter or maybe that I configured at least one device? As a user, both of them 
make sense to me, but again they are context-specific. Therefore, if we want to 
move in this direction of pleasing everyone, I suggest we delegate this 
responsibility to the applet itself where the context is clear. In this way, 
the Bluetooth applet could define relevance (in "Shown when relevant") as: 
"Show when adapter is powered", "Show when devices are configured", or "Show 
when devices are connected". This could be done in the applet's config dialog 
without breaking the current "interface" (i.e., the four current states).
  
  If we want to keep things simple, I suggest we make the status quo consistent 
by defining relevance as a dynamic event that requires the user's attention. In 
the context of the Bluetooth applet, that would mean a device was connected. In 
the context of vaults, that would mean I opened one of them. Having configured 
a Bluetooth device or having created a vault is pretty much a steady state for 
most users (as in you only do it once); I don't think anyone goes around 
setting up things over and over again. In that case, we are pretty much in the 
"Always shown" domain.
  
  **tl;dr**:
  
  - Do you want to keep things simple? Maintain the status quo but iron out any 
inconsistencies.
  - Do you want to accommodate all needs? Delegate to the applets where the 
context is clear.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Nathaniel Graham]

ngraham added a comment.


  Yeah. Thinking about it more, your proposal makes some sense because people 
like you can currently not get what you want at all, while if we integrate this 
change, people like me can just change the visibility setting to "Always 
visible". So I'm leaning in the direction of approving.
  
  However if we really want to overthink things, we could go deeper and add 
more visibility states to satisfy everyone. We could have the following five 
states for visibility:
  
  1. Disabled
  2. Always hidden in pop-up
  3. Shown when there are any devices/services (as appropriate for the applet) 
configured
  4. Shown when in use
  5. Always shown
  
  #3 would only be visible for applets which can have devices/services/etc 
added and configured: Bluetooth, KDE, Printers, Vaults Connect
  
  Thoughts?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis added a comment.


  Accurate analysis. If I might add, as an infrequent user of Plasma Vaults, I 
am stuck between an (almost) always visible applet (whether I select "Always 
shown" or "Shown when relevant") and an always hidden applet. A "currently 
active" relevance would cater for both frequent and infrequent users, with the 
drawback that frequent users would have to select "Always shown". I'm not 
particularly ecstatic about the Bluetooth applet taking up unnecessary space 
95% of the time, either.
  
  Imho, in KDE's configurable spirit, I would prefer it if systray relevance 
was configurable, but to my knowledge no plasmoid provides such an option; the 
creator is always in charge of making this decision with potential inconsistent 
results, as mentioned.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Nathaniel Graham]

ngraham added a reviewer: ivan.
ngraham added a comment.


  With this change, a person who creates a Vault they will be regularly using 
and wants the system tray icon to be always visible now has to go out of their 
way to use the "always visible" setting in the system tray settings; the "Shown 
when relevant" setting will make the tray icon hidden when they want to go and 
access the vault.
  
  I guess it depends on whether your definition of "relevant" means "the user 
has created at least one vault" or "the user is actively using a Vault right 
now".
  
  The latter definition is more consistent with the visibility status of the 
Printers applet, which shows itself only when a printer is in use, not when a 
printer is simply connected. However it would be inconsistent with the 
Bluetooth applet, which currently behaves in the same way as the Vaults applet 
does (the tray icon is visible when Bluetooth is on, not only when a device is 
connected). And I worry that it will be a bit annoying for people who regularly 
use Vaults, as it means they will have to access the item in the System Tray's 
expanded pop-up or change the default settings. I use Vaults quite frequently; 
if this change lands, I would change the default visibility setting to "Always 
visible"
  
  Thoughts from #VDG <https://phabricator.kde.org/tag/vdg/> and #consistency 
<https://phabricator.kde.org/tag/goal_consistency/> people?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis created this revision.
ksmanis added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ksmanis requested review of this revision.

REVISION SUMMARY
  Currently, the "Shown when relevant" visibility option in the system
  tray shows an icon iff at least one vault exists, regardless of open
  status (i.e., if it is open or closed). Change this behavior to show an
  icon iff at least one *open* vault exists, allowing the user to be more
  mindful of potentially sensitive information being accessible.
  
  The previous behavior can be emulated by selecting the "Always shown"
  visibility option, assuming that the user does not create and delete
  Plasma Vaults for recreation.

TEST PLAN
  Compiles and runs as expected both on master (commit 4d11dcf 
<https://phabricator.kde.org/R845:4d11dcffd65c5b98e10678fe904baa789f89bc2f>) and
  Plasma/5.18 (commit 1f546c1 
<https://phabricator.kde.org/R845:1f546c1d6c3f20fcab8ee4b9d2d4090ecf17dc75>).

REPOSITORY
  R845 Plasma Vault

BRANCH
  applet-systray-relevance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29130

AFFECTED FILES
  plasma/package/contents/ui/main.qml
  plasma/vaultsmodel.cpp
  plasma/vaultsmodel.h
  plasma/vaultsmodel_p.h

To: ksmanis, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:96ad51cde0ea: Remove Icons from system tray item tooltips 
(authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28631?vs=79545=79573

REVISION DETAIL
  https://phabricator.kde.org/D28631

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Konrad Materka]

kmaterka accepted this revision.
kmaterka added a comment.
This revision is now accepted and ready to land.


  In D28631#643325 , @ngraham wrote:
  
  > Remove no-longer-relevant reference to icon in `AbstractItem.qml`
  
  
  Thanks, accepted.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  remove-systemtray-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28631

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Nathaniel Graham]

ngraham updated this revision to Diff 79545.
ngraham added a comment.


  Remove no-longer-relevant reference to icon in `AbstractItem.qml`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28631?vs=79511=79545

BRANCH
  remove-systemtray-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28631

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  In D28631#643116 , @davidre wrote:
  
  > I would argue that the implementation is free to ignore it 
  >  `Data structure that describes extra information associated to this item, 
that can be visualized for instance by a tooltip (or by any other mean the 
visualization consider appropriate.`
  >  The appropriate one being not at all in this case ;)
  
  
  OK, makes sense.
  
  @ngraham Only one little detail: please remove **`icon` ** from comment `/* 
subclasses need to assign to this tooltip properties` in `AbstractItem.qml`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28631

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[David Redondo]

davidre added a comment.


  
  
  In D28631#643111 , @kmaterka wrote:
  
  > For SNI, maybe we should consider showing an icon, but only if it is 
explicitly set? It is part of the specification 

 after all. From the other side it will be inconsistent...
  
  
  I would argue that the implementation is free to ignore it 
  `Data structure that describes extra information associated to this item, 
that can be visualized for instance by a tooltip (or by any other mean the 
visualization consider appropriate.`
  The appropriate one being not at all in this case ;)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28631

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Konrad Materka]

kmaterka added a comment.


  For SNI, maybe we should consider showing an icon, but only if it is 
explicitly set? It is part of the specification 

 after all. From the other side it will be inconsistent...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28631

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Nathaniel Graham]

ngraham updated this revision to Diff 79511.
ngraham marked an inline comment as done.
ngraham added a comment.


  Revert change to remove code from the Data Engine

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28631?vs=79510=79511

BRANCH
  remove-systemtray-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28631

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[David Redondo]

davidre added a reviewer: kmaterka.
davidre added inline comments.

INLINE COMMENTS

> statusnotifieritemsource.cpp:342
>  setData(QStringLiteral("ToolTipSubTitle"), QString());
> -setData(QStringLiteral("ToolTipIcon"), QString());
> -} else {

we consider the data engine public api, so we would have  to keep this for now. 
also the tooltipicon is part of the spec so maybe we should expose it in the 
engine regardless if someone else (not the systray apple) wants to do something 
with statusnotifieritems

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28631

To: ngraham, #plasma, davidre, broulik, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28631: Remove Icons from system tray item tooltips

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, davidre, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  It was decided in T12778 <https://phabricator.kde.org/T12778> to remove icons 
from tooltips for panel widgets and system tray
  items. This patch implements that for system tray items, and removes the 
supporting code
  from the backend.

TEST PLAN
  Apply patch
  Hover the cursor over system tray items, either in the compat applet or the 
expanded
  representation
  No more redundant or inconsistent icons visible

REPOSITORY
  R120 Plasma Workspace

BRANCH
  remove-systemtray-tooltip-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28631

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: ngraham, #plasma, davidre, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28435: [System Tray] Update effective status on model insertion

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1d3b6e8f0a18: [System Tray] Update effective status on 
model insertion (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28435?vs=78895=78953

REVISION DETAIL
  https://phabricator.kde.org/D28435

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: broulik, #plasma, kmaterka, davidre, ahmadsamir, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28435: [System Tray] Update effective status on model insertion

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This fixes the same issue affecting Vaults too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28435

To: broulik, #plasma, kmaterka, davidre, ahmadsamir, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28435: [System Tray] Update effective status on model insertion

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, kmaterka, davidre, ahmadsamir.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Started Konversation, has proper effective status of passive again. Before 
it was empty

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28435

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: broulik, #plasma, kmaterka, davidre, ahmadsamir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[Eugene Popov]

epopov updated this revision to Diff 78827.
epopov added a comment.


  Use `hideOnWindowDeactivate` property instead of `configuration.pin`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78805=78827

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[Eugene Popov]

epopov added a comment.


  In D28408#637476 <https://phabricator.kde.org/D28408#637476>, @davidedmundson 
wrote:
  
  > As a question, rather than a researched proposal, is it better to check for 
the pin in?
  >
  > systemtray / PlasmoidItem.qml
  >
  >   Connections {
  >   target: applet
  >   onExpandedChanged: {
  >   
  
  
  We should be able to hide the pinned applet by clicking in the system tray 
(at least this can be done now).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[David Edmundson]

davidedmundson added a comment.


  As a question, rather than a researched proposal, is it better to check for 
the pin in?
  
  systemtray / PlasmoidItem.qml
  
Connections {
target: applet
onExpandedChanged: {

INLINE COMMENTS

> main.qml:158
> +
> +applet.configuration.pin = Qt.binding(function() { return 
> plasmoid.configuration.pin; });
>  

What happens when this is set with some other applet that doesn't have a pin 
config option?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[Eugene Popov]

epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Klipper widget and then click on a history item, the Klipper 
widget closes.
  
  To fix this bug, we need to check if Klipped is pinned, but to be able to do 
this, we also need to "forward" the pinned state from the SystemTray applet to 
the Klipper applet.
  
  BUG 416510

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28211: Make Pin buttons consistently sized in System Tray and Clock pop-ups

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3a44e360e01e: Make Pin buttons consistently sized in 
System Tray and Clock pop-ups (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28211?vs=78300=78325

REVISION DETAIL
  https://phabricator.kde.org/D28211

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: ngraham, #vdg, #plasma, ognarb, mart
Cc: mart, ndavis, broulik, ognarb, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

Re: Drag and drop to system tray

[Martin Bammer]

"Also, since most System Tray icons are applets which hardly ever
handle any files."

You forgot about applications like Telegram, Skype, etc. These
applications indeed accept files for sending.
Currently if I want to send a file via drag and drop I have to open the
window (e.g. Telegram) first (if it is minimized to the system tray),
then I can drag and drop it.
Wouldn't it be more convenient for the user to have DnD support in the
system tray?

I think Apple has exactly this feature.

Best regards,

Martin

Re: Drag and drop to system tray

[Kai Uwe Broulik]

Hi,

I think Martin means a behavior similar to the task manager where 
dragging a file over a window and waiting a little will raise that 
window so you can drag that file into the corresponding window.


There's no plans to implement this and I personally think apps don't 
belong in System Tray to begin with so, I'll leave it to someone else to 
decide whether that's a good idea or not.


There's no way to "raise" the corresponding window, though, we can just 
send a "left clicked" signal which then usually brings the window to the 
front but it might not. And also while you're dragging, focus stealing 
prevention might be in effect? Implementation sounds trivial to me but I 
don't think it'll work reliable enough to be useful. Also, since most 
System Tray icons are applets which hardly ever handle any files.


Cheers
Kai Uwe

Re: Drag and drop to system tray

[David Edmundson]

When you say system tray, what specifically are you referring to?

There are definitely no plans to support dropping files onto the
org.kde.plasma.systemtray containment.

Drag and drop to system tray

[Martin Bammer]

Hi,

are there any plans to implement drap and drop support to system tray?
So that it is possible to drag any file to an icon in the system tray,
then the window of the corresponding app opens and then the file can be
dropped in the right destination.

Best regards,

Martin

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  Fix for narrow panel in D27958 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham added a comment.


  In D27466#624639 , @kmaterka wrote:
  
  > I guess it needs to be reworked... I can do that, just need few days for 
investigation.
  
  
  Thanks, much appreciated!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  In D27466#624574 , @broulik wrote:
  
  > > I believe that D26992 , moves the 
icons down.
  >
  > It looks like with that patch the icon sizes differ between plasmoids and 
SNIs
  
  
  That was my work, definitely that should not be the outcome. :) I will check 
it.
  
  The main problem here is that itemSize (regardless if it is plasmoid or SNI) 
is calculated in a very complicated and tricky way. If I remember correctly, 
firstly icon size is calculated, then margin is added but it is not a real 
margin - simply SNI icons are rounded to closes icon size and then by happy 
coincident we get margin. I guess it needs to be reworked... I can do that, 
just need few days for investigation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  > I believe that D26992 , moves the icons 
down.
  
  It looks like with that patch the icon sizes differ between plasmoids and SNIs

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[George Vogiatzis]

gvgeo added a comment.


  I believe that D26992 , moves the icons 
down. And this patch, by adding an extra smallSpacing/2 makes it more 
noticeable.
  
  Baking magic numbers is always questionable. Either the 1 smallspacing 
before, or the current 3/2, or 2 for tablet. IMO icons size should never be 
bigger than available space.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  In D27466#624447 , @broulik wrote:
  
  > This causes layouting issues in narrow panels:
  >  F8167100: Screenshot_20200309_085328.PNG 

  >  The icons are also too far apart
  
  
  For small icons this does not look nice. BaseSize is increased by the same 
`units.smallSpacing /2` regardless of the icon size, which is a great 
proportion for small icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  This causes layouting issues in narrow panels:
  F8167100: Screenshot_20200309_085328.PNG 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d1d769841d53: Increase the size of system tray icon 
hitboxes on the System Tray Plasmoid (authored by The-Feren-OS-Dev, committed 
by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77210=77213

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77210.
The-Feren-OS-Dev added a comment.


  Redone, again.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77209=77210

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77209.
The-Feren-OS-Dev added a comment.


  One more diff tweak to make it normal-er.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77208=77209

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77208.
The-Feren-OS-Dev added a comment.


  Rebased on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75913=77208

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Konrad Materka]

kmaterka added a comment.


  In D27466#620470 , @gvgeo wrote:
  
  > IMO this is the wrong way to do these changes.
  >
  > 1. I don't see "itemSize" to be used anywhere else(didn't check) than 
"tasksRow" where we already add a smallSpacing. It would be best to increase 
the size in one place.
  > 2. For tablets already allow to use  bigger size icons. There is no need to 
artificially increase the size this way, if they need bigger size can increase 
the panel height.
  > 3. Can expose plasmoid.configuration.iconSize to the user. Otherwise can be 
removed.
  
  
  SystemTray is quite messy in a lot of places. How conveniently, there is a 
change with some refactoring and cleanup (D26992 
) waiting for a review :)

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[George Vogiatzis]

gvgeo added a comment.


  IMO this is the wrong way to do these changes.
  
  1. I don't see "itemSize" to be used anywhere else(didn't check) than 
"tasksRow" where we already add a smallSpacing. It would be best to increase 
the size in one place.
  2. For tablets already allow to use  bigger size icons. There is no need to 
artificially increase the size this way, if they need bigger size can increase 
the panel height.
  3. Can make use of plasmoid.configuration.iconSize, which is not exposed to 
the user. Otherwise can be removed.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Well, if dedoimedo likes it this way, then it's probably the right thing to 
do ;)
  
  Since no one else complains about this change, I'll assume I just was lucky 
to have proper scaling on my machine without "magic number" spacings.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Niccolò Venerandi]

niccolove added a comment.


  E.g.: dedoimedo complained about this in both the .18 and .17 review.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  The main point of this patch is the spacing increase between tray icons that 
this hitbox size increase gives, which makes the tray look less cramped as a 
result.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  It's hard to measure this in pixels, but on the screenshot, it's a 10% 
increase in size.
  I use default font settings btw, with a global scaling factor of 1.25.
  
  I'm not strongly against this, but I don't really see a point in this either. 
In, like, 4 years of Plasma on my machines, I haven't missed a systray item a 
single time; probably because they're quite big already, compared to other 
elements like checkboxes and dropdown list arrows.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham added a comment.


  I mean, it's only one more pixel. :) But yes, for some people with certain 
fonts maybe it will be too much. But then again, could a single pixel really be 
enough to make it too much?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27466#620191 , @ngraham wrote:
  
  > It is (already) font-dependent, yes. A higher font size will result in 
larger spacing.
  >
  > IMO this is not super sensible, but, there is it. :p
  
  
  Ok, so I guess for the group of users who currently have the right spacing 
it's going to become excessive then :/

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham added a comment.


  It is (already) font-dependent, yes. A higher font size will result in larger 
spacing.
  
  IMO this is not super sensible, but, there is it. :p

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Went to check on different DPIs again to be sure it's fine and it definitely 
looks fine to me, scaling up the hitbox padding additions (and therefore the 
icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an 
issue.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#620052 <https://phabricator.kde.org/D27466#620052>, @IlyaBizyaev 
wrote:
  
  > In D27466#620050 <https://phabricator.kde.org/D27466#620050>, 
@The-Feren-OS-Dev wrote:
  >
  > > This patch only affects the System Tray widget itself, not anything else 
on the panel. Only the spacing around the icons that are part of the System 
Tray applet itself will be changed by this patch.
  >
  >
  > I understand, but, as I mentioned, for me it already looks like what you 
expect to achieve with this.
  >  Is it maybe DPI or font dependent, causing the spacing to be smaller in 
your local setup?
  
  
  I have 1.0 DPI scaling, though the system tray icon spacing is indeed 
controlled by DPI scaling due to the 'units.smallSpacing' size unit.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27466#620050 <https://phabricator.kde.org/D27466#620050>, 
@The-Feren-OS-Dev wrote:
  
  > This patch only affects the System Tray widget itself, not anything else on 
the panel. Only the spacing around the icons that are part of the System Tray 
applet itself will be changed by this patch.
  
  
  I understand, but, as I mentioned, for me it already looks like what you 
expect to achieve with this.
  Is it maybe DPI or font dependent, causing the spacing to be smaller in your 
local setup?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#620037 <https://phabricator.kde.org/D27466#620037>, @IlyaBizyaev 
wrote:
  
  > Repeating my comment on the previous diff for this change: on my machine, 
the current spacing for systray elements already looks like your "after" 
screenshot. With normal usage, my systray area (icons + clock + a note widget) 
takes up 1/4 of the panel. Does it mean that after this change, it's going to 
be even larger?
  
  
  This patch only affects the System Tray widget itself, not anything else on 
the panel. Only the spacing around the icons that are part of the System Tray 
applet itself will be changed by this patch.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Repeating my comment on the previous diff for this change: on my machine, the 
current spacing for systray elements already looks like your "after" 
screenshot. With normal usage, my systray takes up 1/4 of the panel. Does it 
mean that after this change, it's going to be even larger?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#619931 , @ngraham wrote:
  
  > So at this point it's just one pixel, and I don't see the huge harm. :) 
However the last patch to adjust this (D27438 
) proved quite controversial, so we should 
wait for more opinions to avoid unduly ruffling feathers. :)
  
  
  To be fair, part of the issue with the previous patch was that it didn't 
increase hitbox size while increasing spacing, while this one does, so 
hopefully there won't be too many issues with this.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  So at this point it's just one pixel, and I don't see the huge harm. :) 
However the last patch to adjust this (D27438 
) proved quite controversial, so we should 
wait for more opinions to avoid unduly ruffling feathers. :)

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9e0711ac408d: Make the icon hitboxes for the System Tray 
Plasmoid larger when Kirigami Tablet… (authored by The-Feren-OS-Dev, committed 
by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75911=76686

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg, #plasma, niccolove
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Niccolò Venerandi]

niccolove added a comment.


  +1

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: Plasma.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. #plasma  folks, is this all 
technically correct?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75913.
The-Feren-OS-Dev added a comment.


  Updated diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75912=75913

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75912.
The-Feren-OS-Dev added a comment.


  Updated diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75873=75912

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75911.
The-Feren-OS-Dev marked an inline comment as done.
The-Feren-OS-Dev added a comment.


  Moved baseSize declaration and changed it to a standard variable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75869=75911

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:44
>  property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical
> -readonly property int itemSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]]))
> +readonly property int baseSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]]))
> +readonly property int itemSize: {

this doesn't need to be a property; just make it a variable (`var baseSize = 
...`) inside the new inline function itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75873.
The-Feren-OS-Dev added a comment.


  You gotta love arc/git sometimes...

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75872=75873

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75872.
The-Feren-OS-Dev added a comment.


  Arcanist please

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75871=75872

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75871.
The-Feren-OS-Dev added a comment.


  Hopefully fixed the diff again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75870=75871

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75870.
The-Feren-OS-Dev added a comment.


  Updated diff to be in line with parent patch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75864=75870

BRANCH
  arcpatch-D27465_1

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75869.
The-Feren-OS-Dev added a comment.


  Tidied up code a bit and introduced new baseSize variable  - Slightly 
increase system tray icon hitboxes in Non Tablet Mode Plasma

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75863=75869

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:47
> +// Set the tray items' clickable areas on the panel to be bigger 
> than normal to allow for easier touchability
> +return units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]])) + 
> units.smallSpacing;
> +} else {

Rather than repeating this long calculation twice, assign it to a variable 
called `baseSize` or something and then vary it in the return statements:

  if (Kirigami.Settings.tabletMode) {
  return baseSize + units.smallSpacing;
  } else {
  return baseSize;
  }

Also keep in mind that adding `units.smallSpacing` once will result in half 
that value amount being added to all sides. If you want to add 
`units.smallSpacing` to all sides, you'll need to add `units.smallSpacing * 2`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  ...and now the split is complete.
  https://phabricator.kde.org/D27466

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75863.
The-Feren-OS-Dev added a comment.


  Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode 
padding addition

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75862=75863

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  The initial patch of the three, now I've thought up a suitable way of doing 
this, has been made:
  https://phabricator.kde.org/D27465

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Actually, on second thought, @ngraham I'm not even sure if step 2 would even 
be worth it on its own, if possible.
  
  On your suggestion you have it adjusted to have step 3's tablet mode checker 
in step 2. If I don't have that check in place, for step 2, then it'd just be 
how it currently is anyway on master, effectively resulting in nothing to edit 
for a patch. I'll definitely do Step 3 as a patch, though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613097 , @ngraham wrote:
  
  > ...one to increase the spacing when in tablet mode, and another one to 
increase the spacing when in desktop mode. At this point each patch will be 
changing a different line in the function
  
  
  Due to how the current patch handles it, I'll probably have to all of step 3 
one patch since they change the same line as each other, but for sure I can 
split steps 2 and 3(1)+3(2) of your post into individual patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev abandoned this revision.
The-Feren-OS-Dev added a comment.


  Alright, I'll start splitting the patches up now. Marking this one as 
Abandoned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613104 , @IlyaBizyaev 
wrote:
  
  > I agree with @broulik in that the spacing already feels quite excessive, or 
at least doesn't need to be increased (:
  >
  > Does this depend on DPI/panel size maybe?
  
  
  Units.smallSpacing should change depending on the DPI, from what I've heard.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I agree with @broulik in that the spacing already feels quite excessive, or 
at least doesn't need to be increased (:
  
  Does this depend on DPI/panel size maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Nathaniel Graham]

ngraham added a comment.


  
https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches
  
  It would probably be simplest do just do this though:
  
  1. Abandon this patch
  2. Submit a patch to refactor that logic to use a nested multi-line function 
for readability, as proposed in my comment
  3. After that patch lands, submit two more patches, one to increase the 
spacing when in tablet mode, and another one to increase the spacing when in 
desktop mode. At this point each patch will be changing a different line in the 
function
  
  Clear as mud? :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  How would I split it into two patches? Both patches would edit the exact same 
line.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Nathaniel Graham]

ngraham added a comment.


  This should probably be two patches at this point: one to increase the 
spacing when using tablet mode (which IMO is an uncontroversial no-brainer) and 
another to increase the spacing when in desktop mode.

INLINE COMMENTS

> main.qml:45
> +// If Kirigami.Settings.tabletMode is true, double the amount of space 
> added around the tray icons to make them easier to tap on
> +readonly property int itemSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]])) + 
> (Kirigami.Settings.tabletMode ? Math.round(units.smallSpacing) : 
> Math.round(units.smallSpacing/2))
>  property int hiddenItemSize: units.iconSizes.smallMedium

This should probably be rewritten as an inline function as it's now very 
difficult to read. e.g.:

  readonly property int itemSize {
  if (Kirigami.Settings.tabletMode) {
  return foo;
  } else {
  [put other logic here etc]
  return bar;
  }
  }

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75851.
The-Feren-OS-Dev added a comment.


  Tweaked an added comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75850=75851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613051 , @davidre wrote:
  
  > In D27438#613050 , 
@The-Feren-OS-Dev wrote:
  >
  > > In D27438#612719 , @davidre 
wrote:
  > >
  > > > There is now not clickable space between items:
  > > >  F8108239: grafik.png  F8108241: 
grafik.png 
  > > >  At least it should be clickable
  > >
  > >
  > > For future reference, how do you get that size examining mode in Plasma 
Desktop Workspace?
  >
  >
  > That's inside gammaray
  
  
  For some reason I couldn't get gammaray to do that over here, but I did come 
up with a new method for the patch that should increase hitboxes as well as 
icon spacing. Could you check if it does so, just to be sure?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75850.
The-Feren-OS-Dev added a comment.


  Changed method used for increasing spacing between tray icons to something 
that increases hitbox sizes as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75804=75850

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart