D22896: Port System Settings sidebar to QQC2

[Björn Feber]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:b42479962795: Port System Settings sidebar to QQC2 
(authored by GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=64057=64059

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart, broulik
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 64057.
GB_2 added a comment.


  Move `setActionMenuVisible` to the `Private` class

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63968=64057

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart, broulik
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Fix it, then shipit!

INLINE COMMENTS

> broulik wrote in SidebarMode.h:107
> Move this to the `Private` class

This isnt addressed

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart, broulik
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63968.
GB_2 added a comment.


  Add tooltip to menu button

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63872=63968

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63872.
GB_2 added a comment.


  Address comments

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63827=63872

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Kai Uwe Broulik]

broulik added a comment.


  Working very nice now! Just some minor nitpicks then this can go in

INLINE COMMENTS

> SidebarMode.h:54
>  Q_PROPERTY(int width READ width NOTIFY widthChanged)
> +Q_PROPERTY(bool actionMenuVisible READ actionMenuVisible WRITE 
> setActionMenuVisible NOTIFY actionMenuVisibleChanged)
>  

Doesn't need a `WRITE` as it is internal

> SidebarMode.h:77
> +bool actionMenuVisible() const;
> +void setActionMenuVisible(const bool );
> +

Make the setter `private`

> SidebarMode.h:107
>  Private *const d;
> +bool m_actionMenuVisible = false;
>  };

Move this to the `Private` class

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63827.
GB_2 added a comment.


  Use standard shortcut for "Configure System Settings..." action

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63799=63827

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> SettingsBase.cpp:143
>  configureAction = actionCollection()->addAction( 
> KStandardAction::Preferences, QStringLiteral("configure"), this, 
> SLOT(configShow()) );
>  actionCollection()->setDefaultShortcut(configureAction, 
> QKeySequence(Qt::CTRL + Qt::Key_M));
> +configureAction->setText( i18n("Configure...") );

lolwut

The default shortcut for "Configure" is [Ctrl] + [⇧] + [comma] these days!

I never even new this had a shortcut because only with your patch does it 
become visible. :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63799.
GB_2 added a comment.


  Bind checked property directly

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63614=63799

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63614.
GB_2 marked 7 inline comments as done.
GB_2 added a comment.


  Address comments

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63611=63614

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> SidebarMode.cpp:402
> +{
> +QMenu *menu = new QMenu();
> +QStringList actionList { QStringLiteral("configure"), 
> QStringLiteral("help_contents"), QStringLiteral("help_about_app"), 
> QStringLiteral("help_about_kde") };

This leaks.
`menu->setAttribute(Qt::WA_DeleteOnClose);`

> SidebarMode.cpp:403
> +QMenu *menu = new QMenu();
> +QStringList actionList { QStringLiteral("configure"), 
> QStringLiteral("help_contents"), QStringLiteral("help_about_app"), 
> QStringLiteral("help_about_kde") };
> +for (QAction *a : d->collection->actions()) {

`const`

> SidebarMode.cpp:404
> +QStringList actionList { QStringLiteral("configure"), 
> QStringLiteral("help_contents"), QStringLiteral("help_about_app"), 
> QStringLiteral("help_about_kde") };
> +for (QAction *a : d->collection->actions()) {
> +if (actionList.contains(a->objectName())) {

I think it's better to iterate the list of actions and then get them from the 
collection. This way the order is also preserved correctly:

  for (const QString  : actionList) {
  menu->addAction(d->collection->action(actionName);
  }

> SidebarMode.cpp:410
> +connect(menu, ::aboutToHide, this, [this] () { 
> QMetaObject::invokeMethod(d->quickWidget->rootObject(), "closeMenu"); } );
> +menu->exec(position);
> +}

Don't `exec()` in conjunction with QML, this is just asking for trouble. Use 
`popup()` instead

> main.qml:44
> +function closeMenu() {
> +mainColumn.actionMenuButton.checked = false;
> +}

Can you instead do a `Q_PROPERTY(bool actionMenuVisible ...)` in 
`systemsettings` which you set `true` before the menu opens and set `false` in 
`aboutToHide`. Then bind the `checked` of the button to it.
This way everything is in a predictable space and not called all over the place.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 updated this revision to Diff 63458.
GB_2 added a comment.


  Add a "Show Most Used Page" button

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63404=63458

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 updated this revision to Diff 63404.
GB_2 added a comment.


  Rebase

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63403=63404

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 updated this revision to Diff 63403.
GB_2 added a comment.


  Use Qt Labs Platform menu (need to wait until 
https://bugreports.qt.io/browse/QTBUG-77404 is fixed)

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63338=63403

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  categories/CMakeLists.txt
  categories/old/settings-desktop-appearance.desktop
  categories/old/settings-system-administration.desktop
  categories/old/settings-workspace-appearance-and-behavior.desktop
  categories/old/settings-workspace-behavior.desktop
  categories/settings-network-connectivity.desktop
  categories/settings-system-administration.desktop
  categories/settings-workspace-desktopbehavior.desktop
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> broulik wrote in SidebarMode.cpp:570
> Not a huge fan of this.
> Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and 
> `ComboBox` popup?

Not really, seems like the KQuickStyleItem only has access to the QML window of 
the menu control and also can't detect events on the rest of the QWidget window 
:(

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> SidebarMode.cpp:570
>  emit changeToolBarItems(BaseMode::NoItems);
> +} else if (watched->inherits("QWidgetWindow") && event->type() == 
> QEvent::MouseButtonPress) {
> +QMetaObject::invokeMethod(d->quickWidget->rootObject(), "closeMenu");

Not a huge fan of this.
Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and 
`ComboBox` popup?

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 updated this revision to Diff 63338.
GB_2 added a comment.


  Rebase on master

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63180=63338

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham added a comment.


  Hey, that works great!

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 updated this revision to Diff 63180.
GB_2 added a comment.


  Close menu when clicking anywhere in the window. Most likely not the best 
solution.

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=62976=63180

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Me too, but please wait for a #plasma 
 person to approve or reject. :)

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 added a comment.


  That is good enough IMO, but if anyone knows how to fix this, then please do 
:-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham added a comment.


  Ah so it does. I think that's the most important case to cover, so tentative 
+1 from me.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Filip Fila]

filipf added a comment.


  If it would be draining to do now, we can leave that menu at QQC1 and add a 
note pointing to a bug report?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 added a comment.


  In D22896#505835 , @ngraham wrote:
  
  > Yeah that's pretty bad. I think we need to fix that first--or at the very 
least, make it close when clicking on the button.
  
  
  It does that. Making it close when clicking anywhere would need some C++ code 
though.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham added a comment.


  Yeah that's pretty bad. I think we need to fix that first--or at the very 
least, make it close when clicking on the button.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Kai Uwe Broulik]

broulik added a comment.


  "Only issue", I think that's quite a severe regression?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  F7141216: System Settings Sidebar QQC2 Port.png 

  Only issue is that the menu can only be closed if you click somewhere in the 
sidebar.

TEST PLAN
  Open the System Settings. Everything should still work.

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart