Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review102460 --- if this patch is still relevant, please repost it to phabricator.kde.org as is new features for baloo, that are not even planned to be used anymore, it's safer to just discard it. feel free to resurrect it on phabricator - Marco Martin On Dec. 2, 2014, 12:18 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120777/ > --- > > (Updated Dec. 2, 2014, 12:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > --- > > At the moment, Baloo doesn't provide a timeline, which is something that we > need for the activefilebrowser. > So this new component, is introducing support for the timeline. > > Notes > === > > * Baloocloud component contains the org.kde.baloo component inside it.The > reason behind that, is that the implementation for the timeline is kind of > terible because of its perfomance. > * I have put the new component inside the plasma-mobile repository, for the > above reason. But if the Baloo team, wants it inside the baloo repo then i > can move it. I am fine with both approaches (keep it here or in the baloo > repository. > * If someone has a better idea about the implementation, the pls shoot :) > > > > Diffs > - > > CMakeLists.txt 9466447 > components/CMakeLists.txt 536b60e > components/timelinemodel/CMakeLists.txt PRE-CREATION > components/timelinemodel/qmldir PRE-CREATION > components/timelinemodel/timelinemodel.h PRE-CREATION > components/timelinemodel/timelinemodel.cpp PRE-CREATION > components/timelinemodel/timelineplugin.h PRE-CREATION > components/timelinemodel/timelineplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120777/diff/ > > > Testing > --- > > Everything looks ok. The performance is not bad, except from the fact that > the implementation is a bit of hackish... > > > Thanks, > > Antonis Tsiapaliokas > >
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Feb. 8, 2017, 12:49 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
On Nov. 28, 2014, 11:26 a.m., Vishesh Handa wrote: components/timelinemodel/timelinemodel.cpp, line 136 https://git.reviewboard.kde.org/r/120777/diff/3/?file=330748#file330748line136 Has this been tested? This assert would be true when m_level is Month or Day. Yeap, i missed this one. On Nov. 28, 2014, 11:26 a.m., Vishesh Handa wrote: components/timelinemodel/timelinemodel.h, line 32 https://git.reviewboard.kde.org/r/120777/diff/3/?file=330747#file330747line32 I also just realized that the start and end date are QStrings, and not QDates. Is it easier to work with strings in QML? I used strings because with dates i think that we making our component more complicated without any reason (based on this page http://qt-project.org/doc/qt-5/qml-qtqml-date.html). Also we will have to convert the QDate into a QString, in order to use it inside the searchString. But if you want prefer the QDate, its fine for me. I can change it :) - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71055 --- On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 26, 2014, 6:11 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Dec. 2, 2014, 12:18 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs (updated) - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71054 --- Ship it! It's not ideal, but ship it. I'll improve the Baloo documentation and submit a patch later. - Vishesh Handa On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 26, 2014, 6:11 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71055 --- components/timelinemodel/timelinemodel.h https://git.reviewboard.kde.org/r/120777/#comment49627 I also just realized that the start and end date are QStrings, and not QDates. Is it easier to work with strings in QML? components/timelinemodel/timelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment49626 Has this been tested? This assert would be true when m_level is Month or Day. - Vishesh Handa On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 26, 2014, 6:11 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 26, 2014, 6:11 p.m.) Review request for Plasma. Changes --- I have fix all the issues. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs (updated) - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review70975 --- Ship it! looks better to me - Marco Martin On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 26, 2014, 6:11 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 25, 2014, 3:11 p.m.) Review request for Plasma. Changes --- I have updated the review request. As it has been discussed, the timeline will get its data from the QueryResultsModel (which lives inside the Baloo repo.) and it will generate the timeline. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs (updated) - components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION CMakeLists.txt 9466447 Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review70926 --- components/timelinemodel/qmldir https://git.reviewboard.kde.org/r/120777/#comment49572 I would prefer the module not having the word baloo in it. components/timelinemodel/timelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment49570 How about makinng generateTimeLine a SLOT as well. This way you can just hook it up directly? components/timelinemodel/timelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment49573 I'm a little confused. Where is this value being used? components/timelinemodel/timelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment49571 Just my opinion - An assert would be better since m_level is an enum and should NEVER be any other value apart from those 3. - Vishesh Handa On Nov. 25, 2014, 3:11 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 25, 2014, 3:11 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION CMakeLists.txt 9466447 Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote: components/timelinemodel/timelinemodel.cpp, line 144 https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line144 Just my opinion - An assert would be better since m_level is an enum and should NEVER be any other value apart from those 3. +1 On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote: components/timelinemodel/timelinemodel.cpp, line 103 https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line103 I'm a little confused. Where is this value being used? yeah, this doesn't look right. the query should be constructed in a way that only results within dates between startDate and endDate are considered. right now those values don't seem used at all? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review70926 --- On Nov. 25, 2014, 3:11 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 25, 2014, 3:11 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION CMakeLists.txt 9466447 Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - components/baloocloudmodel/balootimelinemodel.h PRE-CREATION components/baloocloudmodel/balootimelinemodel.cpp PRE-CREATION components/baloocloudmodel/qmldir PRE-CREATION CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/baloocloudmodel/CMakeLists.txt PRE-CREATION components/baloocloudmodel/baloocloudmodel.h PRE-CREATION components/baloocloudmodel/baloocloudmodel.cpp PRE-CREATION components/baloocloudmodel/baloocloudplugin.h PRE-CREATION components/baloocloudmodel/baloocloudplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review69092 --- I'm very confused about this whole patch. Can you explain what each of the models is supposed to be doing? Also, why is this called Cloud? Finally, do you really want to call everything BalooSomething. It's using Baloo internally, but that's doesn't mean the users of these models need to explicitly be told that. They are more concerned with the features the model is providing, not the technology that it is using internally. CMakeLists.txt https://git.reviewboard.kde.org/r/120777/#comment48309 You aren't really using FileMetaData components/baloocloudmodel/balootimelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment48306 One generally just adds such thing in Baloo if there are not there. I've added the operator != in Query components/baloocloudmodel/balootimelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment48307 This is incredibly inefficient. Could you please use Query::setDateFilter please. You should do the same for the month and days as well. - Vishesh Handa On Oct. 24, 2014, 12:21 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Oct. 24, 2014, 12:21 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - components/baloocloudmodel/balootimelinemodel.h PRE-CREATION components/baloocloudmodel/balootimelinemodel.cpp PRE-CREATION components/baloocloudmodel/qmldir PRE-CREATION CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/baloocloudmodel/CMakeLists.txt PRE-CREATION components/baloocloudmodel/baloocloudmodel.h PRE-CREATION components/baloocloudmodel/baloocloudmodel.cpp PRE-CREATION components/baloocloudmodel/baloocloudplugin.h PRE-CREATION components/baloocloudmodel/baloocloudplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review69091 --- I would prefer CloudModel (with a better name) and timelinemodel sharing the same instance of Query, instead of encapsulating a timelinemodel inside of a cloudmodel components/baloocloudmodel/balootimelinemodel.cpp https://git.reviewboard.kde.org/r/120777/#comment48305 assuming months have 31 days - Marco Martin On Oct. 24, 2014, 12:21 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Oct. 24, 2014, 12:21 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - components/baloocloudmodel/balootimelinemodel.h PRE-CREATION components/baloocloudmodel/balootimelinemodel.cpp PRE-CREATION components/baloocloudmodel/qmldir PRE-CREATION CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/baloocloudmodel/CMakeLists.txt PRE-CREATION components/baloocloudmodel/baloocloudmodel.h PRE-CREATION components/baloocloudmodel/baloocloudmodel.cpp PRE-CREATION components/baloocloudmodel/baloocloudplugin.h PRE-CREATION components/baloocloudmodel/baloocloudplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
