Re: Review Request 122488: Improved calendar navigation

2015-07-27 Thread Sebastian Kügler 


> On July 27, 2015, 9:55 a.m., John Layt wrote:
> > Fantastic to see this :-) Pretty much as I documented it at 
> > https://community.kde.org/Plasma/Clock#Zooming_Calendar (which was a 
> > serious crib from Windows anyway :-) ). The thing to add for the future 
> > will be clicking on the day takes you to an Agenda view with your calendar 
> > and holidays and even weather forecast for that day :-)

That's within reach with KDEPIM joining the applications in 15.08. We've put 
that features on the plan for Plasma 5.5.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review83024
---


On July 27, 2015, 9:43 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated July 27, 2015, 9:43 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/daysmodel.h e1285f6 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/calendar.h 5dc3081 
>   src/declarativeimports/calendar/calendar.cpp c462dbd 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-27 Thread John Layt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review83024
---


Fantastic to see this :-) Pretty much as I documented it at 
https://community.kde.org/Plasma/Clock#Zooming_Calendar (which was a serious 
crib from Windows anyway :-) ). The thing to add for the future will be 
clicking on the day takes you to an Agenda view with your calendar and holidays 
and even weather forecast for that day :-)

- John Layt


On July 27, 2015, 10:43 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated July 27, 2015, 10:43 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/daysmodel.h e1285f6 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/calendar.h 5dc3081 
>   src/declarativeimports/calendar/calendar.cpp c462dbd 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-27 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---

(Updated July 27, 2015, 9:43 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 11e5ff10ae993dd2078c6019623e60d7e12f8ff1 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

This improves the calendar navigation by providing a "Year overview" showing 
all 12 months in a grid, and a "Decade overview" showing the current decade in 
a grid.

A lot of code has just been moved around. The overviews use a QML ListModel 
owing to laziness.

See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
mouse click effect!)


Diffs
-

  src/declarativeimports/calendar/qml/MonthView.qml 601755f 
  src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
  src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
  src/declarativeimports/calendar/daysmodel.h e1285f6 
  src/declarativeimports/calendar/daydata.h 39ac086 
  src/declarativeimports/calendar/calendar.h 5dc3081 
  src/declarativeimports/calendar/calendar.cpp c462dbd 

Diff: https://git.reviewboard.kde.org/r/122488/diff/


Testing
---

I changed the selection to be persistent during navigation; other than that, 
should work as before, with the new overviews.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-24 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---

(Updated Juli 24, 2015, 1:15 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

Address issues
Fix horizontal alignment
Didn't add i18n stuff because we're after string freeze


Repository: plasma-framework


Description
---

This improves the calendar navigation by providing a "Year overview" showing 
all 12 months in a grid, and a "Decade overview" showing the current decade in 
a grid.

A lot of code has just been moved around. The overviews use a QML ListModel 
owing to laziness.

See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
mouse click effect!)


Diffs (updated)
-

  src/declarativeimports/calendar/qml/MonthView.qml 601755f 
  src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
  src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
  src/declarativeimports/calendar/daysmodel.h e1285f6 
  src/declarativeimports/calendar/daydata.h 39ac086 
  src/declarativeimports/calendar/calendar.h 5dc3081 
  src/declarativeimports/calendar/calendar.cpp c462dbd 

Diff: https://git.reviewboard.kde.org/r/122488/diff/


Testing
---

I changed the selection to be persistent during navigation; other than that, 
should work as before, with the new overviews.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-22 Thread Martin Klapetek 


> On July 22, 2015, 5:10 p.m., Martin Klapetek wrote:
> > Ship It already!

Actually hold with the shipping, I've just noticed that the calendar popup with 
digital clock has all wrong margins around the grid, this would need fixing.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review82804
---


On July 18, 2015, 10:28 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated July 18, 2015, 10:28 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 5dc3081 
>   src/declarativeimports/calendar/calendar.cpp c462dbd 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h e1285f6 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-22 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review82804
---

Ship it!


Ship It already!


src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 36 - 37)


This is unused



src/declarativeimports/calendar/qml/DaysCalendar.qml (line 49)


I find this name confusing. Could you make the name more precise like eg. 
dateMatchingPrecision and this looks like a perfect candidate for an enum ;)



src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 56 - 57)


Can you put the comments back here from MonthView.qml please



src/declarativeimports/calendar/qml/MonthView.qml (line 115)


The cells seems to be large enough to go with Locale.LongFormat

...the short format is rarely (if at all) used in Czech, eg. I imagine it 
might be the same for other langs.



src/declarativeimports/calendar/qml/MonthView.qml (line 192)


This should maybe be i18nc as well?



src/declarativeimports/calendar/qml/MonthView.qml (line 249)


This should be i18nc (cause, you know, RTL and stuff)


- Martin Klapetek


On July 18, 2015, 10:28 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated July 18, 2015, 10:28 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 5dc3081 
>   src/declarativeimports/calendar/calendar.cpp c462dbd 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h e1285f6 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-21 Thread Bernhard Friedreich 


> On Mai 21, 2015, 5:24 nachm., Martin Klapetek wrote:
> > Bump. Can we get this in for 5.4?
> 
> Marco Martin wrote:
> ugh, i almost forgot about this...
> yes please

Just tested the patch. Working beautifully for me from a user perspective :)


- Bernhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review80706
---


On Juli 18, 2015, 8:28 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Juli 18, 2015, 8:28 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 5dc3081 
>   src/declarativeimports/calendar/calendar.cpp c462dbd 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h e1285f6 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-07-18 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---

(Updated Juli 18, 2015, 8:28 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

Rebase to current master


Repository: plasma-framework


Description
---

This improves the calendar navigation by providing a "Year overview" showing 
all 12 months in a grid, and a "Decade overview" showing the current decade in 
a grid.

A lot of code has just been moved around. The overviews use a QML ListModel 
owing to laziness.

See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
mouse click effect!)


Diffs (updated)
-

  src/declarativeimports/calendar/calendar.h 5dc3081 
  src/declarativeimports/calendar/calendar.cpp c462dbd 
  src/declarativeimports/calendar/daydata.h 39ac086 
  src/declarativeimports/calendar/daysmodel.h e1285f6 
  src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
  src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 
  src/declarativeimports/calendar/qml/MonthView.qml 601755f 

Diff: https://git.reviewboard.kde.org/r/122488/diff/


Testing
---

I changed the selection to be persistent during navigation; other than that, 
should work as before, with the new overviews.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-05-22 Thread Marco Martin 


> On May 21, 2015, 5:24 p.m., Martin Klapetek wrote:
> > Bump. Can we get this in for 5.4?

ugh, i almost forgot about this...
yes please


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review80706
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-05-21 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review80706
---


Bump. Can we get this in for 5.4?

- Martin Klapetek


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Sebastian Kügler 


> On Feb. 9, 2015, 3:20 a.m., Aleix Pol Gonzalez wrote:
> > +1 I like it.
> > 
> > Why is it even possible to select a day though? It doesn't do anything at 
> > the moment...
> > 
> > Maybe it would be food that when hovering a day, the weekday was 
> > highlighted, it's useful to know what day is it.
> 
> Martin Klapetek wrote:
> Can be quite useful as sort of temporary bookmarking (like line 
> highliting in kate). You're doing something on the webs like trip planning, 
> calendar open, you need to remember a date, click, it gets highlighted, then 
> checking other pages you don't need to remember dates or something. And 
> similar. I actually found myself using it quite often (even when planning 
> things with multiple people, that allows me to pin the date I want and 
> creates a viewing anchor for others).

I initially added it assuming we'd get calendaring integration one day. I agree 
that it's less useful right now, but as long as it doesn't really bother the 
user, I think it's OK to keep it (or of course make it more useful).


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Sebastian Kügler 


> On Feb. 9, 2015, 2:51 p.m., Sebastian Kügler wrote:
> > The one thing I'm missing is an indicator for the currently selected year 
> > and month, should be exactly the same tinting as the selected day.
> > 
> > Otherwise, very nice work. When I implemented the combo-like behaviour, it 
> > was really resorting to that solution, yours is much, much nicer indeed.

Aaaand ... ignore my remark about the current-indicator. I see it's already 
there. I'll have my visual brain checked out one of these days. ;)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75695
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75695
---

Ship it!


The one thing I'm missing is an indicator for the currently selected year and 
month, should be exactly the same tinting as the selected day.

Otherwise, very nice work. When I implemented the combo-like behaviour, it was 
really resorting to that solution, yours is much, much nicer indeed.

- Sebastian Kügler


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Martin Klapetek 


> On Feb. 9, 2015, 4:20 a.m., Aleix Pol Gonzalez wrote:
> > +1 I like it.
> > 
> > Why is it even possible to select a day though? It doesn't do anything at 
> > the moment...
> > 
> > Maybe it would be food that when hovering a day, the weekday was 
> > highlighted, it's useful to know what day is it.

Can be quite useful as sort of temporary bookmarking (like line highliting in 
kate). You're doing something on the webs like trip planning, calendar open, 
you need to remember a date, click, it gets highlighted, then checking other 
pages you don't need to remember dates or something. And similar. I actually 
found myself using it quite often (even when planning things with multiple 
people, that allows me to pin the date I want and creates a viewing anchor for 
others).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
---


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Martin Klapetek 


> On Feb. 9, 2015, 2:40 a.m., Lukáš Tinkl wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, line 61
> > 
> >
> > I know this is not your code but still... we must absolutely not make 
> > any asumptions about how the strings should be rendered. In some languages 
> > it's just plain wrong to display month names capitalized.
> 
> Lukáš Tinkl wrote:
> For the rationale: 
> http://meta.wikimedia.org/wiki/Capitalization_of_Wiktionary_pages#Capitalization_of_month_names
> 
> Most languages DO NOT capitalize month names

This is used in as a title however. Most languages do capitalize titles. And 
this one should be too.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Martin Klapetek 


On Feb. 9, 2015, 2:21 a.m., Kai Uwe Broulik wrote:
> > I'd advice against the new C++ functions. You can use setDisplayDate (even 
> > in QML with the displayedDate property) to accomplish the exact same thing 
> > and it keeps the C++ API clean.
> > If you really want to have the "helper functions" on the C++ side then you 
> > should call setDisplayDate(...) within those helper functions.
> > 
> > But i like your change from a visual perspective :) I actually think John 
> > Layt had this on his wish lish for the calendar!
> > Also, did you notice your bottom border in the month view is missing? It's 
> > like that in plasma 5.2 as well.
> 
> Kai Uwe Broulik wrote:
> I added them because the others were there and I didn't figure out how to 
> work with displayedDate, given JS Date is super horrible to work with but 
> I'll take a look.

> Kai: ...that's been that way for some time for me, though.
> Mark: Also, did you notice your bottom border in the month view is missing? 
> It's like that in plasma 5.2 as well.

Guys, please do report these at bko, kinda sucks if we released it like this 
and nobody shouted about this kinda huge visual bug :S


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75649
---


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [KDE Usability] Review Request 122488: Improved calendar navigation

2015-02-09 Thread kainz.a 
would it be useful to see the events of the day (in an agenda) when you
select the day

2015-02-09 4:20 GMT+01:00 Aleix Pol Gonzalez :

>This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
>
> +1 I like it.
>
> Why is it even possible to select a day though? It doesn't do anything at the 
> moment...
>
> Maybe it would be food that when hovering a day, the weekday was highlighted, 
> it's useful to know what day is it.
>
>
> - Aleix Pol Gonzalez
>
> On February 8th, 2015, 9:52 p.m. CET, Kai Uwe Broulik wrote:
>   Review request for Plasma and KDE Usability.
> By Kai Uwe Broulik.
>
> *Updated Feb. 8, 2015, 9:52 p.m.*
>  *Repository: * plasma-framework
> Description
>
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
>
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
>
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
>
>   Testing
>
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
>
>   Diffs
>
>- src/declarativeimports/calendar/calendar.cpp (a766acb)
>- src/declarativeimports/calendar/daydata.h (39ac086)
>- src/declarativeimports/calendar/daysmodel.h (ec88837)
>- src/declarativeimports/calendar/daysmodel.cpp (1a6f454)
>- src/declarativeimports/calendar/qml/DayDelegate.qml (6a3747e)
>- src/declarativeimports/calendar/qml/DaysCalendar.qml (67b3a2e)
>- src/declarativeimports/calendar/qml/MonthView.qml (6eaa8db)
>- src/declarativeimports/calendar/calendar.h (ea20bf5)
>
> View Diff 
>
> ___
> kde-usability mailing list
> kde-usabil...@kde.org
> https://mail.kde.org/mailman/listinfo/kde-usability
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75677
---

Ship it!


I like it. It reminds me an old demo Aza Raskin did on a ZUI ui for 
calendars/organizers i seen in an old video of a talk, looks very natural.
one supercool thing would be to bind to it things traditionally used for zoom, 
so ctrl+mousewheel and pinch for touchscreen/mac touchpad

- Marco Martin


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Marco Martin 


> On Feb. 9, 2015, 1:40 a.m., Lukáš Tinkl wrote:
> > src/declarativeimports/calendar/qml/DaysCalendar.qml, line 125
> > 
> >
> > I know this is nitpicking but... how is an arrow pointing to the left 
> > implemented as previous() meant to work for RTL languages? :)

this was already there, so unrelate,.. it should use the "go-previous" icon 
tough


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-09 Thread Kai Uwe Broulik 


On Feb. 9, 2015, 1:21 vorm., Kai Uwe Broulik wrote:
> > I'd advice against the new C++ functions. You can use setDisplayDate (even 
> > in QML with the displayedDate property) to accomplish the exact same thing 
> > and it keeps the C++ API clean.
> > If you really want to have the "helper functions" on the C++ side then you 
> > should call setDisplayDate(...) within those helper functions.
> > 
> > But i like your change from a visual perspective :) I actually think John 
> > Layt had this on his wish lish for the calendar!
> > Also, did you notice your bottom border in the month view is missing? It's 
> > like that in plasma 5.2 as well.

I added them because the others were there and I didn't figure out how to work 
with displayedDate, given JS Date is super horrible to work with but I'll take 
a look.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75649
---


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
---


+1 I like it.

Why is it even possible to select a day though? It doesn't do anything at the 
moment...

Maybe it would be food that when hovering a day, the weekday was highlighted, 
it's useful to know what day is it.

- Aleix Pol Gonzalez


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Lukáš Tinkl 


> On Úno. 9, 2015, 2:40 dop., Lukáš Tinkl wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, line 61
> > 
> >
> > I know this is not your code but still... we must absolutely not make 
> > any asumptions about how the strings should be rendered. In some languages 
> > it's just plain wrong to display month names capitalized.

For the rationale: 
http://meta.wikimedia.org/wiki/Capitalization_of_Wiktionary_pages#Capitalization_of_month_names

Most languages DO NOT capitalize month names


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---


On Úno. 8, 2015, 9:52 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Úno. 8, 2015, 9:52 odp.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---



src/declarativeimports/calendar/daysmodel.cpp


You should override roleNames() instead



src/declarativeimports/calendar/qml/DaysCalendar.qml


I know this is nitpicking but... how is an arrow pointing to the left 
implemented as previous() meant to work for RTL languages? :)



src/declarativeimports/calendar/qml/MonthView.qml


I know this is not your code but still... we must absolutely not make any 
asumptions about how the strings should be rendered. In some languages it's 
just plain wrong to display month names capitalized.


- Lukáš Tinkl


On Úno. 8, 2015, 9:52 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Úno. 8, 2015, 9:52 odp.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75649
---



src/declarativeimports/calendar/calendar.cpp


replace with:
setDisplayDate(QDate(m_displayedDate.year(), month, m_displayedDate.day()));



src/declarativeimports/calendar/calendar.cpp


replace with:
setDisplayDate(QDate(year, m_displayedDate.month(), m_displayedDate.day()));



src/declarativeimports/calendar/calendar.cpp


setDisplayDate...



src/declarativeimports/calendar/calendar.cpp


setDisplayDate...


I'd advice against the new C++ functions. You can use setDisplayDate (even in 
QML with the displayedDate property) to accomplish the exact same thing and it 
keeps the C++ API clean.
If you really want to have the "helper functions" on the C++ side then you 
should call setDisplayDate(...) within those helper functions.

But i like your change from a visual perspective :) I actually think John Layt 
had this on his wish lish for the calendar!
Also, did you notice your bottom border in the month view is missing? It's like 
that in plasma 5.2 as well.

- Mark Gaiser


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Thomas Pfeiffer 


> On Feb. 8, 2015, 10:59 p.m., Heiko Tietze wrote:
> > Awesome! But please take care of alternative access (keyboard, mouse wheel) 
> > and accessibilty.
> 
> Kai Uwe Broulik wrote:
> The calendar lacks any keyboard input and accessibility support 
> whatsoever, so this should be added separately later.
> 
> Heiko Tietze wrote:
> It would be easy to solve when every control gets a label (as the HIG 
> demands). Like "&Year: 2012" or "&Month: January", and the dropdown expands 
> on focus or when the hotkey is pressed with access by cursor up/down.

That would do the trick in the QWidget world, but we're in the QtQuick world 
here, where everything is... different. When Kai Uwe says there is no 
accessibility support yet then trust him: If it were easy to fix, he'd already 
have done it ;)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75641
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Heiko Tietze 


> On Feb. 8, 2015, 10:59 nachm., Heiko Tietze wrote:
> > Awesome! But please take care of alternative access (keyboard, mouse wheel) 
> > and accessibilty.
> 
> Kai Uwe Broulik wrote:
> The calendar lacks any keyboard input and accessibility support 
> whatsoever, so this should be added separately later.

It would be easy to solve when every control gets a label (as the HIG demands). 
Like "&Year: 2012" or "&Month: January", and the dropdown expands on focus or 
when the hotkey is pressed with access by cursor up/down.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75641
---


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Kai Uwe Broulik 


> On Feb. 8, 2015, 10:59 nachm., Heiko Tietze wrote:
> > Awesome! But please take care of alternative access (keyboard, mouse wheel) 
> > and accessibilty.

The calendar lacks any keyboard input and accessibility support whatsoever, so 
this should be added separately later.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75641
---


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Heiko Tietze 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75641
---


Awesome! But please take care of alternative access (keyboard, mouse wheel) and 
accessibilty.

- Heiko Tietze


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Kai Uwe Broulik 


> On Feb. 8, 2015, 10:07 nachm., Martin Klapetek wrote:
> > That's some seriously cool stuff. One thing I noticed in the video - what 
> > happened with the bottom frame of the calendar? Seems missing.
> > 
> > I'll do proper review tomorrow.

That's a rounding error in the height calculation of the grid, the bottom 
border gets drawn outside the canvas, that's been that way for some time for 
me, though.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75635
---


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75635
---


That's some seriously cool stuff. One thing I noticed in the video - what 
happened with the bottom frame of the calendar? Seems missing.

I'll do proper review tomorrow.

- Martin Klapetek


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Kai Uwe Broulik 


> On Feb. 8, 2015, 9:54 nachm., Andrew Lake wrote:
> > Good stuff!
> > 
> > Perhaps add some visual hover feedback on the month/year so it's evident 
> > that it's "live" compared to hovering on other text.
> > 
> > Nothing other than that. Very nice!

Yes, I thought the same, I wanted to turn it into a ToolButton so it gets both 
hover feedback and a tooltip but not sure how to get the same text alignment 
that way.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75633
---


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75633
---


Good stuff!

Perhaps add some visual hover feedback on the month/year so it's evident that 
it's "live" compared to hovering on other text.

Nothing other than that. Very nice!

- Andrew Lake


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

2015-02-08 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---

(Updated Feb. 8, 2015, 8:52 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

Add usability group


Repository: plasma-framework


Description (updated)
---

This improves the calendar navigation by providing a "Year overview" showing 
all 12 months in a grid, and a "Decade overview" showing the current decade in 
a grid.

A lot of code has just been moved around. The overviews use a QML ListModel 
owing to laziness.

See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
mouse click effect!)


Diffs
-

  src/declarativeimports/calendar/calendar.cpp a766acb 
  src/declarativeimports/calendar/daydata.h 39ac086 
  src/declarativeimports/calendar/daysmodel.h ec88837 
  src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
  src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
  src/declarativeimports/calendar/calendar.h ea20bf5 

Diff: https://git.reviewboard.kde.org/r/122488/diff/


Testing
---

I changed the selection to be persistent during navigation; other than that, 
should work as before, with the new overviews.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122488: Improved calendar navigation

2015-02-08 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

This improves the calendar navigation by providing a "Year overview" showing 
all 12 months in a grid, and a "Decade overview" showing the current decade in 
a grid.

A lot of code has just been moved around.

See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
mouse click effect!)


Diffs
-

  src/declarativeimports/calendar/calendar.cpp a766acb 
  src/declarativeimports/calendar/daydata.h 39ac086 
  src/declarativeimports/calendar/daysmodel.h ec88837 
  src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
  src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
  src/declarativeimports/calendar/calendar.h ea20bf5 

Diff: https://git.reviewboard.kde.org/r/122488/diff/


Testing
---

I changed the selection to be persistent during navigation; other than that, 
should work as before, with the new overviews.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel