subject:"Review Request 123473\: Port mouse theme kcm to QML"

Re: Review Request 123473: Port mouse theme kcm to QML

2015-05-06 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79996
---


Wait, what happened to no regressions?
Your combo box patch isn't released; and it still has a bug with backgrounds?

- David Edmundson


On May 6, 2015, 4:57 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated May 6, 2015, 4:57 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>   kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
>   kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
>   kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
>   kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
>   kcms/useraccount/kcm_useraccount.desktop 46ef110 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 
> 89d7fc3 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-05-06 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
---

(Updated May 6, 2015, 4:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit f9fe76cbade454ea05b7975b401dd946610864b1 by Marco Martin 
to branch master.


Repository: plasma-desktop


Description
---

This is more an experiment on how much modules can be closely ported (and in 
how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the 
QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs
-

  applets/icontasks/metadata.desktop f0b237c 
  containments/folder/metadata.desktop a6d08a7 
  kcms/access/kcmaccess.desktop 825b6d7 
  kcms/baloo/kcm_baloofile.desktop 2eee6fc 
  kcms/cursortheme/CMakeLists.txt 83f3ba2 
  kcms/cursortheme/Messages.sh 79450c7 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 
  kcms/desktoppaths/desktoppath.desktop eb2fad5 
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
  kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
  kcms/lookandfeel/package/metadata.desktop 6595d6e 
  kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
  kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
  kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
  kcms/useraccount/kcm_useraccount.desktop 46ef110 
  layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
---


File Attachments


cursorskcm.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-28 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
---

(Updated April 28, 2015, 1:16 p.m.)


Review request for Plasma and KDE Usability.


Changes
---

this latest version should be ok enough, tested cursor change, 
download/install/uninstall, all seems to work well


Repository: plasma-desktop


Description
---

This is more an experiment on how much modules can be closely ported (and in 
how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the 
QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs (updated)
-

  applets/icontasks/metadata.desktop f0b237c 
  containments/folder/metadata.desktop a6d08a7 
  kcms/access/kcmaccess.desktop 825b6d7 
  kcms/baloo/kcm_baloofile.desktop 2eee6fc 
  kcms/cursortheme/CMakeLists.txt 83f3ba2 
  kcms/cursortheme/Messages.sh 79450c7 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 
  kcms/desktoppaths/desktoppath.desktop eb2fad5 
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
  kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
  kcms/lookandfeel/package/metadata.desktop 6595d6e 
  kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
  kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
  kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
  kcms/useraccount/kcm_useraccount.desktop 46ef110 
  layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
---


File Attachments


cursorskcm.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-28 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79620
---


We get many crashes since porting KCM modules to QML, see bug 346634, bug 
345882, bug 344651, bug 345675 and duplicates.

- Christoph Feck


On April 27, 2015, 4:57 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 27, 2015, 4:57 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>   kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
>   kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
>   kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
>   kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
>   kcms/useraccount/kcm_useraccount.desktop 46ef110 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 
> 89d7fc3 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-27 Thread Andrew Lake



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-27 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-27 Thread Martin Gräßlin



> On April 23, 2015, 1:31 p.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image o

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-27 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-27 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-26 Thread David Edmundson



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-26 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-26 Thread David Edmundson



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-26 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes
> 
> Fredrik Höglund wrote:
> > For example I always wondered why there is this "strange" preview area 
> on the top, instead of just previewing all cursors in the list directly. With 
> QQC that becomes quite easier and removes the "it's probably because it would 
> be a nightmare with delegates".
> 
> * So that the appearance and behavior of the KCM is consistent with that 
> of the icon theme KCM.
> * So that the listview looks and behaves identically to other listviews.
> * To enable the user to get a quick overview of the installed themes 
> without having to scroll.
> * Each item in the listview provides three key points of data so as to 
> not overwhelm the user with information;
>   a single large image

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Fredrik Höglund



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough
> 
> Martin Gräßlin wrote:
> > so that may have to be made inline as well, not sure if it would work 
> well tough
> 
> Given that it already has this "Available size", I think it could be a 
> neat idea to morph it into the delegate.
> 
> (o) Resolution Dependent
> (o) |Dropdown| available sizes

> For example I always wondered why there is this "strange" preview area on the 
> top, instead of just previewing all cursors in the list directly. With QQC 
> that becomes quite easier and removes the "it's probably because it would be 
> a nightmare with delegates".

* So that the appearance and behavior of the KCM is consistent with that of the 
icon theme KCM.
* So that the listview looks and behaves identically to other listviews.
* To enable the user to get a quick overview of the installed themes without 
having to scroll.
* Each item in the listview provides three key points of data so as to not 
overwhelm the user with information;
  a single large image of the most important cursor, the name of the theme, and 
finally a short d

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Martin Gräßlin



> On April 23, 2015, 1:31 p.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.
> 
> Marco Martin wrote:
> this is with a better layout:
> http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
> there is still one thing that doesn't logically work too much, that is 
> the size combo box, since it depends from the theme selected (not all themes 
> have all the same sizes available) so that may have to be made inline as 
> well, not sure if it would work well tough

> so that may have to be made inline as well, not sure if it would work well 
> tough

Given that it already has this "Available size", I think it could be a neat 
idea to morph it into the delegate.

(o) Resolution Dependent
(o) |Dropdown| available sizes


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 24, 2015, 5:10 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 24, 2015, 5:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty m

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
---

(Updated April 24, 2015, 3:10 p.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

This is more an experiment on how much modules can be closely ported (and in 
how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the 
QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs (updated)
-

  applets/icontasks/metadata.desktop f0b237c 
  containments/folder/metadata.desktop a6d08a7 
  kcms/access/kcmaccess.desktop 825b6d7 
  kcms/baloo/kcm_baloofile.desktop 2eee6fc 
  kcms/cursortheme/CMakeLists.txt 83f3ba2 
  kcms/cursortheme/Messages.sh 79450c7 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 
  kcms/desktoppaths/desktoppath.desktop eb2fad5 
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
  kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
  kcms/lookandfeel/package/metadata.desktop 6595d6e 
  kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
  kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
  kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
  kcms/useraccount/kcm_useraccount.desktop 46ef110 
  layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
---


File Attachments


cursorskcm.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)
> 
> Sebastian Kügler wrote:
> I quite like it. Also, it's really not necessary to be able to view 5 or 
> more themes at the same time, this makes comparison already a lot easier.

this is with a better layout:
http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
there is still one thing that doesn't logically work too much, that is the size 
combo box, since it depends from the theme selected (not all themes have all 
the same sizes available) so that may have to be made inline as well, not sure 
if it would work well tough


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metad

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Sebastian Kügler



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?
> 
> Marco Martin wrote:
> this is very quick and dirty:
> http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
> 
> with very big delegates, it almost looks nice :)

I quite like it. Also, it's really not necessary to be able to view 5 or more 
themes at the same time, this makes comparison already a lot easier.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcurso

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?
> 
> Martin Gräßlin wrote:
> maybe only show them for the selected or on hover?

this is very quick and dirty:
http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png

with very big delegates, it almost looks nice :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Martin Gräßlin



> On April 23, 2015, 1:31 p.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".
> 
> Marco Martin wrote:
> having all the previews inline could probably be simpler since i could 
> perhaps avoid a custom qquickpainteditem.. however, it would look very 
> crowded i think?

maybe only show them for the selected or on hover?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 4:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 4:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.
> 
> Martin Gräßlin wrote:
> I agree with David that we also should see this as a chance. For example 
> I always wondered why there is this "strange" preview area on the top, 
> instead of just previewing all cursors in the list directly. With QQC that 
> becomes quite easier and removes the "it's probably because it would be a 
> nightmare with delegates".

having all the previews inline could probably be simpler since i could perhaps 
avoid a custom qquickpainteditem.. however, it would look very crowded i think?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previe

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Martin Gräßlin



> On April 23, 2015, 1:31 p.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.
> 
> David Edmundson wrote:
> > It's true of course that using it builds greater pressure to get it 
> fixed, but are we certain that actively hurting the quality of our releases 
> is the only path available?
> 
> It's not as simple as saying using new stuff /will/ hurt the quality 
> compared to the current state.
> 
> This KCM wouldn't use form layouts, or any special widgets that we don't 
> have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
> the time we finish with this, I think we can make it just as perfect /and/ 
> progress our QQC integration at the same time.
> 
> Also it's not like these KCMs are truly perfect as-is. There are 8 open 
> bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
> will fix some of them.
> 
> I do completely agree with you that users shouldn't be hurt by porting 
> efforts and we should have an absolutely no regressions at all policy before 
> merging, with no excuses about limitations in QQC.

I agree with David that we also should see this as a chance. For example I 
always wondered why there is this "strange" preview area on the top, instead of 
just previewing all cursors in the list directly. With QQC that becomes quite 
easier and removes the "it's probably because it would be a nightmare with 
delegates".


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 4:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 4:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursorth

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread David Edmundson



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?
> 
> Marco Martin wrote:
> bah, right now accelerators and tab focus kinda works in that module..
> still kinda, but again, if the decision is to go in that direction, of 
> which i remeber it was talked about and decided, otherwise I wouldn't have 
> wasted two days on it ;)
> Now, I'm fine if now we decide to not port modules, but most of them 
> kindof have to be redone anyways, and I would prefer reding them once rather 
> than twice.

> It's true of course that using it builds greater pressure to get it fixed, 
> but are we certain that actively hurting the quality of our releases is the 
> only path available?

It's not as simple as saying using new stuff /will/ hurt the quality compared 
to the current state.

This KCM wouldn't use form layouts, or any special widgets that we don't have 
anyway. Keyboard accelorators and tab keys /should/ work in QQC so by the time 
we finish with this, I think we can make it just as perfect /and/ progress our 
QQC integration at the same time.

Also it's not like these KCMs are truly perfect as-is. There are 8 open bugs on 
the cursor KCM. I'd like to think paying some attention to these KCMs will fix 
some of them.

I do completely agree with you that users shouldn't be hurt by porting efforts 
and we should have an absolutely no regressions at all policy before merging, 
with no excuses about limitations in QQC.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin



> On April 23, 2015, 10:59 p.m., Luigi Toscano wrote:
> > Apart from more technical issues, the patch includes changes to:
> > applets/icontasks/metadata.desktop 
> > containments/folder/metadata.desktop 
> > kcms/access/kcmaccess.desktop 
> > kcms/baloo/kcm_baloofile.desktop 
> > 
> > which I think are unrelated.

yes, that just comes from a git dif master


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79413
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>   kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
>   kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
>   kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
>   kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
>   kcms/useraccount/kcm_useraccount.desktop 46ef110 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 
> 89d7fc3 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79413
---


Apart from more technical issues, the patch includes changes to:
applets/icontasks/metadata.desktop 
containments/folder/metadata.desktop 
kcms/access/kcmaccess.desktop 
kcms/baloo/kcm_baloofile.desktop 

which I think are unrelated.

- Luigi Toscano


On April 23, 2015, 4:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 4:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>   kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
>   kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
>   kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
>   kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
>   kcms/useraccount/kcm_useraccount.desktop 46ef110 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 
> 89d7fc3 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
> 
> I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?

bah, right now accelerators and tab focus kinda works in that module..
still kinda, but again, if the decision is to go in that direction, of which i 
remeber it was talked about and decided, otherwise I wouldn't have wasted two 
days on it ;)
Now, I'm fine if now we decide to not port modules, but most of them kindof 
have to be redone anyways, and I would prefer reding them once rather than 
twice.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>   kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
>   kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
>   kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
>   kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
>   kcms/useraccount/kcm_useraccount.desktop 46ef110 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 
> 89d7fc3 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
---

(Updated April 23, 2015, 2:08 p.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

This is more an experiment on how much modules can be closely ported (and in 
how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the 
QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs (updated)
-

  applets/icontasks/metadata.desktop f0b237c 
  containments/folder/metadata.desktop a6d08a7 
  kcms/access/kcmaccess.desktop 825b6d7 
  kcms/baloo/kcm_baloofile.desktop 2eee6fc 
  kcms/cursortheme/CMakeLists.txt 83f3ba2 
  kcms/cursortheme/Messages.sh 79450c7 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 
  kcms/desktoppaths/desktoppath.desktop eb2fad5 
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
  kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
  kcms/lookandfeel/package/metadata.desktop 6595d6e 
  kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
  kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
  kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
  kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
  kcms/useraccount/kcm_useraccount.desktop 46ef110 
  layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
---


File Attachments


cursorskcm.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Eike Hein



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it

> all of them have to eventually be ported tough and in order to get done, one 
> has to.. do it

I'm just not a big fan of putting transitional pain (worse UI from a weaker 
toolkit) on the user when there's an opportunity to avoid it, I guess ... right 
now, Qt Quick has worse performance, no keyboard accelerator management, no 
form layouts, limited widgets, some visual problems, etc. - It's true of course 
that using it builds greater pressure to get it fixed, but are we *certain* 
that actively hurting the quality of our releases is the only path available?


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 11 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


> This is more an experiment on how much modules can be closely ported (and in 
> how much time).

What's the benefit to the user of merging this version now?

- Eike Hein


On April 23, 2015, 11 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin



> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?

none.
not too much pain as well tough.
all of them have to eventually be ported tough and in order to get done, one 
has to.. do it


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
---


On April 23, 2015, 11 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
---

(Updated April 23, 2015, 11 a.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

This is more an experiment on how much modules can be closely ported (and in 
how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the 
QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs (updated)
-

  kcms/cursortheme/CMakeLists.txt 13ed816 
  kcms/cursortheme/Messages.sh 79450c7 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
---


File Attachments


cursorskcm.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Lasse Liehu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79373
---


Messages.sh needs to be adjusted for translations in .qml files. For example:

```shell
$XGETTEXT `find . -name *.cpp -o -name *.qml` -o $podir/kcmmousetheme.pot
```

- Lasse Liehu


On huhti 23, 2015, 8:39 ap, Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated huhti 23, 2015, 8:39 ap)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread David Edmundson



> On April 23, 2015, 9:56 a.m., David Edmundson wrote:
> > kcms/cursortheme/package/contents/ui/Delegate.qml, line 32
> > 
> >
> > This isn't a suitable long term substitute for the QStyle highlights.
> > 
> > run Oxygen and it will look wrong.
> 
> Marco Martin wrote:
> what would you propose for this?
> we would need to either make a new element that paints with qstyle or 
> getting that in qtcontrols (which i guess are a frozen since are being 
> replaced?)

QQC would be best as ideally this all needs to come via the theming API...but 
it's too late for Qt5.5.

A new element in kdeclarative that paints the style would definitely be an 
option; code wise it wouldn't be very difficult.
some sort of kquickcontrols.DelegateBase

To make it clear I don't think we need to block merging on this, kwin KCMs and 
a few other places already do it "wrong". I just wanted to start the discussion 
of making things better.


On April 23, 2015, 9:56 a.m., Marco Martin wrote:
> > I have a cmake issue since you moved some stuff.
> > 
> > -- The following OPTIONAL packages have not been found:
> >  * USB , User level access to USB devices , 
> >Provides Logitech mouse support in KControl.
> > 
> > CMake Error: The following variables are used in this project, but they are 
> > set to NOTFOUND.
> > Please set them or make sure they are set and tested correctly in the CMake 
> > files:
> > LIBUSB_INCLUDE_DIR (ADVANCED)
> >used as include directory in directory 
> > /home/david/projects/kde5/src/kde/workspace/plasma-desktop/kcms/cursortheme
> 
> Marco Martin wrote:
> does this happens in master for you?

yes, but not 5.3 branch


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79369
---


On April 23, 2015, 8:39 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 8:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79369
---



kcms/cursortheme/kcmcursortheme.cpp (lines 589 - 590)


Not a review comment, but I love this line

if you don't press continue, continue.



kcms/cursortheme/package/contents/ui/Delegate.qml (line 32)


This isn't a suitable long term substitute for the QStyle highlights.

run Oxygen and it will look wrong.



kcms/cursortheme/package/contents/ui/Delegate.qml (line 59)


there's an attached

isCurrentItem 

for delegates.



kcms/cursortheme/package/contents/ui/main.qml (line 41)


you can make this the top level item.



kcms/cursortheme/package/contents/ui/main.qml (line 66)


I'm possibly missing something but we don't set the initial index on load.


I have a cmake issue since you moved some stuff.

-- The following OPTIONAL packages have not been found:
 * USB , User level access to USB devices , 
   Provides Logitech mouse support in KControl.

CMake Error: The following variables are used in this project, but they are set 
to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake 
files:
LIBUSB_INCLUDE_DIR (ADVANCED)
   used as include directory in directory 
/home/david/projects/kde5/src/kde/workspace/plasma-desktop/kcms/cursortheme

- David Edmundson


On April 23, 2015, 8:39 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 8:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin



On April 23, 2015, 9:56 a.m., Marco Martin wrote:
> > I have a cmake issue since you moved some stuff.
> > 
> > -- The following OPTIONAL packages have not been found:
> >  * USB , User level access to USB devices , 
> >Provides Logitech mouse support in KControl.
> > 
> > CMake Error: The following variables are used in this project, but they are 
> > set to NOTFOUND.
> > Please set them or make sure they are set and tested correctly in the CMake 
> > files:
> > LIBUSB_INCLUDE_DIR (ADVANCED)
> >used as include directory in directory 
> > /home/david/projects/kde5/src/kde/workspace/plasma-desktop/kcms/cursortheme

does this happens in master for you?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79369
---


On April 23, 2015, 8:39 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 8:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin



> On April 23, 2015, 9:56 a.m., David Edmundson wrote:
> > kcms/cursortheme/package/contents/ui/Delegate.qml, line 32
> > 
> >
> > This isn't a suitable long term substitute for the QStyle highlights.
> > 
> > run Oxygen and it will look wrong.

what would you propose for this?
we would need to either make a new element that paints with qstyle or getting 
that in qtcontrols (which i guess are a frozen since are being replaced?)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79369
---


On April 23, 2015, 8:39 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> ---
> 
> (Updated April 23, 2015, 8:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/CMakeLists.txt 13ed816 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This is more an experiment on how much modules can be closely ported (and in 
how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the 
QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well


Diffs
-

  kcms/cursortheme/CMakeLists.txt 13ed816 
  kcms/cursortheme/cursortheme.desktop f443208 
  kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
  kcms/cursortheme/kcmcursortheme.h d9e32b2 
  kcms/cursortheme/kcmcursortheme.cpp 44576ff 
  kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
  kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
  kcms/cursortheme/package/metadata.desktop PRE-CREATION 
  kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
  kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
  kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
  kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
  kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
  kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
  kcms/cursortheme/xcursor/thememodel.h bcf046a 
  kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
  kcms/cursortheme/xcursor/themepage.h 98c69fd 
  kcms/cursortheme/xcursor/themepage.cpp 687bd65 
  kcms/cursortheme/xcursor/themepage.ui 6efe60b 

Diff: https://git.reviewboard.kde.org/r/123473/diff/


Testing
---


File Attachments


cursorskcm.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

37 matches

Mail list logo