Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
---

Review request for Plasma and Jan Grulich.


Repository: plasma-nm


Description
---

It's quite natural that the connection goes away when we're about to suspend :) 
Watch for this and then don't emit the notification.


Diffs
-

  kded/notification.h 9b8b51a 
  kded/notification.cpp 231d69e 

Diff: https://git.reviewboard.kde.org/r/126748/diff/


Testing
---

While I still think Plasma-NM is waay too verbose about everything, at 
least it doesn't tell me that I just disconnected when I suspend.

I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after 
resuming.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


It should probably still show when you get disconnected and *not* reconnected 
(to any network) on resume?

- Martin Klapetek


On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 7:19 p.m.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Kai Uwe Broulik 


> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?

Doesn't it tell you that anyway? At least when I try to connect to something 
and it fails I get like 3 notifications about different failures.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 6:19 nachm.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Martin Klapetek 


> On Jan. 14, 2016, 7:22 p.m., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.

What I mean is when you suspend your laptop at home, connected to your home 
network, you go out and resume your laptop say at your friend where you didn't 
connect to the wifi before, so it's unknown and your laptop will not connect to 
anything and will not even try. At that point, it should show a "disconnected" 
notification, maybe?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 7:19 p.m.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-14 Thread Kai Uwe Broulik 


> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?

Ah, I see. How should I do that? If it disconnected on suspend and didn't 
attempt to reconnect within 5 seconds show a notification that you're no longer 
connected?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 6:19 nachm.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Jan Grulich 


> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?
> 
> Kai Uwe Broulik wrote:
> Ah, I see. How should I do that? If it disconnected on suspend and didn't 
> attempt to reconnect within 5 seconds show a notification that you're no 
> longer connected?

The patch looks good and makes sense. Do I get it right that once you resume 
your computer then PrepareForSleep signal is emitted with false value to 
re-enable showing notifications? What Martin suggests is also a good idea, 
maybe not showing a notification that you got disconnected, but just make you 
aware you are no longer connected. What would be also useful to store all 
connections which got disconnected before suspend and on resume do not show 
notification about their activation if they were active before suspend, just 
with an exception if you activate them manually (which will be case mostly for 
VPN connections).


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Led. 14, 2016, 6:19 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Led. 14, 2016, 6:19 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Kai Uwe Broulik 


> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?
> 
> Kai Uwe Broulik wrote:
> Ah, I see. How should I do that? If it disconnected on suspend and didn't 
> attempt to reconnect within 5 seconds show a notification that you're no 
> longer connected?
> 
> Jan Grulich wrote:
> The patch looks good and makes sense. Do I get it right that once you 
> resume your computer then PrepareForSleep signal is emitted with false value 
> to re-enable showing notifications? What Martin suggests is also a good idea, 
> maybe not showing a notification that you got disconnected, but just make you 
> aware you are no longer connected. What would be also useful to store all 
> connections which got disconnected before suspend and on resume do not show 
> notification about their activation if they were active before suspend, just 
> with an exception if you activate them manually (which will be case mostly 
> for VPN connections).

Yes, prepareForSleep is emitted again on resume with the parameter being false.

So, I'll store the connections that were active at the time of suspend in a 
vector, when I resume:
- I don't show a connect notification about a connection that was active prior 
to suspend
- I show a notification "You are no longer connected" when after like 5 seconds 
up no connection is active or connecting


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 6:19 nachm.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Kai Uwe Broulik 


> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?
> 
> Kai Uwe Broulik wrote:
> Ah, I see. How should I do that? If it disconnected on suspend and didn't 
> attempt to reconnect within 5 seconds show a notification that you're no 
> longer connected?
> 
> Jan Grulich wrote:
> The patch looks good and makes sense. Do I get it right that once you 
> resume your computer then PrepareForSleep signal is emitted with false value 
> to re-enable showing notifications? What Martin suggests is also a good idea, 
> maybe not showing a notification that you got disconnected, but just make you 
> aware you are no longer connected. What would be also useful to store all 
> connections which got disconnected before suspend and on resume do not show 
> notification about their activation if they were active before suspend, just 
> with an exception if you activate them manually (which will be case mostly 
> for VPN connections).
> 
> Kai Uwe Broulik wrote:
> Yes, prepareForSleep is emitted again on resume with the parameter being 
> false.
> 
> So, I'll store the connections that were active at the time of suspend in 
> a vector, when I resume:
> - I don't show a connect notification about a connection that was active 
> prior to suspend
> - I show a notification "You are no longer connected" when after like 5 
> seconds up no connection is active or connecting

When I store the notification it is for example /activeconnection/2 but on 
resume I have /activeconnection/3, how can I map the new connection to the old 
one? Or do I need to do that manually, like look at Access Point and stuff like 
that, but how would that scale with all the other types we have?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 6:19 nachm.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Jan Grulich 


> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?
> 
> Kai Uwe Broulik wrote:
> Ah, I see. How should I do that? If it disconnected on suspend and didn't 
> attempt to reconnect within 5 seconds show a notification that you're no 
> longer connected?
> 
> Jan Grulich wrote:
> The patch looks good and makes sense. Do I get it right that once you 
> resume your computer then PrepareForSleep signal is emitted with false value 
> to re-enable showing notifications? What Martin suggests is also a good idea, 
> maybe not showing a notification that you got disconnected, but just make you 
> aware you are no longer connected. What would be also useful to store all 
> connections which got disconnected before suspend and on resume do not show 
> notification about their activation if they were active before suspend, just 
> with an exception if you activate them manually (which will be case mostly 
> for VPN connections).
> 
> Kai Uwe Broulik wrote:
> Yes, prepareForSleep is emitted again on resume with the parameter being 
> false.
> 
> So, I'll store the connections that were active at the time of suspend in 
> a vector, when I resume:
> - I don't show a connect notification about a connection that was active 
> prior to suspend
> - I show a notification "You are no longer connected" when after like 5 
> seconds up no connection is active or connecting
> 
> Kai Uwe Broulik wrote:
> When I store the notification it is for example /activeconnection/2 but 
> on resume I have /activeconnection/3, how can I map the new connection to the 
> old one? Or do I need to do that manually, like look at Access Point and 
> stuff like that, but how would that scale with all the other types we have?

1) Be aware that not all connections can be auto-activated again (I can think 
of VPN connections) and those that are not auto-activated need manuall 
intervention. I would ignore those as it is sure that they were manually 
activated and thus users should be notified about succesful activation. 
2) Sounds good

+ please add Lamarque to the review, maybe he can think of another possible use 
case


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Led. 14, 2016, 6:19 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Led. 14, 2016, 6:19 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Jan Grulich 


> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?
> 
> Kai Uwe Broulik wrote:
> Ah, I see. How should I do that? If it disconnected on suspend and didn't 
> attempt to reconnect within 5 seconds show a notification that you're no 
> longer connected?
> 
> Jan Grulich wrote:
> The patch looks good and makes sense. Do I get it right that once you 
> resume your computer then PrepareForSleep signal is emitted with false value 
> to re-enable showing notifications? What Martin suggests is also a good idea, 
> maybe not showing a notification that you got disconnected, but just make you 
> aware you are no longer connected. What would be also useful to store all 
> connections which got disconnected before suspend and on resume do not show 
> notification about their activation if they were active before suspend, just 
> with an exception if you activate them manually (which will be case mostly 
> for VPN connections).
> 
> Kai Uwe Broulik wrote:
> Yes, prepareForSleep is emitted again on resume with the parameter being 
> false.
> 
> So, I'll store the connections that were active at the time of suspend in 
> a vector, when I resume:
> - I don't show a connect notification about a connection that was active 
> prior to suspend
> - I show a notification "You are no longer connected" when after like 5 
> seconds up no connection is active or connecting
> 
> Kai Uwe Broulik wrote:
> When I store the notification it is for example /activeconnection/2 but 
> on resume I have /activeconnection/3, how can I map the new connection to the 
> old one? Or do I need to do that manually, like look at Access Point and 
> stuff like that, but how would that scale with all the other types we have?
> 
> Jan Grulich wrote:
> 1) Be aware that not all connections can be auto-activated again (I can 
> think of VPN connections) and those that are not auto-activated need manuall 
> intervention. I would ignore those as it is sure that they were manually 
> activated and thus users should be notified about succesful activation. 
> 2) Sounds good
> 
> + please add Lamarque to the review, maybe he can think of another 
> possible use case

Each active connection should have UUID of "connection/connection setting" it 
represents, which is still the same.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Led. 14, 2016, 6:19 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Led. 14, 2016, 6:19 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
---

(Updated Jan. 15, 2016, 3:03 nachm.)


Review request for Plasma, Jan Grulich and Lamarque Souza.


Changes
---

- Remember which connections were active before suspending and don't show a 
"notification activated" message for those
- If there is no active or activating connection 5s after resuming, show a 
message that you're no longer connected to a network

I connected to a Wifi, suspended (no disconnect notification), resumed (no 
connect notification)
I enabled a hotspot on my phone and connected to it, suspended (no disconnect 
notification), turned the hotspot off, resumed, it connected to my regular Wifi 
and showed a notification that I'm now connected to this one instead

I couldn't test the "you are not connected" notification as when I remove my 
regular Wifi connection it tries to activate the hotspot (ie. there's an 
activating connection) I disabled in the meantime and is stuck at "configuring 
interface" until it times out. We could only look for active connections but 
that might take longer than 5 seconds?


Repository: plasma-nm


Description
---

It's quite natural that the connection goes away when we're about to suspend :) 
Watch for this and then don't emit the notification.


Diffs (updated)
-

  kded/networkmanagement.notifyrc 7ce437c 
  kded/notification.h 9b8b51a 
  kded/notification.cpp 231d69e 

Diff: https://git.reviewboard.kde.org/r/126748/diff/


Testing
---

While I still think Plasma-NM is waay too verbose about everything, at 
least it doesn't tell me that I just disconnected when I suspend.

I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after 
resuming.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91149
---




kded/notification.h (line 60)


Maybe you can just store UUIDs as that's all you need to know.


- Jan Grulich


On Led. 15, 2016, 3:03 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Led. 15, 2016, 3:03 odp.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91150
---


Ship it!




Looks good to me, maybe just change what I pointed out (storing just UUIDs as 
strings instead active connections). I don't have time right now to test it, 
but I trust you that it works.

Looking only for active connections would probably require increasing the time 
at least to 10 seconds, just leave it as it is for now.

- Jan Grulich


On Led. 15, 2016, 3:03 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Led. 15, 2016, 3:03 odp.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Kai Uwe Broulik 


> On Jan. 15, 2016, 3:20 nachm., Jan Grulich wrote:
> > Looks good to me, maybe just change what I pointed out (storing just UUIDs 
> > as strings instead active connections). I don't have time right now to test 
> > it, but I trust you that it works.
> > 
> > Looking only for active connections would probably require increasing the 
> > time at least to 10 seconds, just leave it as it is for now.

Okay, given when activating a connection fails it will tell you, it's not ad 
bad if we don't show the not connected notification then.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91150
---


On Jan. 15, 2016, 3:03 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 nachm.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-15 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91153
---




kded/notification.cpp (line 56)


It would be safer to add an inhibit to guarantee onPrepareForSleep() has 
finished before letting NetworkManager to continue to sleep. On the other hand, 
onPrepareForSleep() is simple code and can finish very fast, maybe an inhibit 
is a bit overkill, who knows?


- Lamarque Souza


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-25 Thread Kai Uwe Broulik 


> On Jan. 15, 2016, 4:04 nachm., Lamarque Souza wrote:
> > kded/notification.cpp, line 56
> > 
> >
> > It would be safer to add an inhibit to guarantee onPrepareForSleep() 
> > has finished before letting NetworkManager to continue to sleep. On the 
> > other hand, onPrepareForSleep() is simple code and can finish very fast, 
> > maybe an inhibit is a bit overkill, who knows?

I think it's a bit of an overkill to have this. Also I don't want to 
unneccessarily delay suspending just because of a convenience feature like this.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91153
---


On Jan. 15, 2016, 3:03 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 nachm.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-25 Thread Lamarque Souza 


> On Jan. 15, 2016, 4:04 p.m., Lamarque Souza wrote:
> > kded/notification.cpp, line 56
> > 
> >
> > It would be safer to add an inhibit to guarantee onPrepareForSleep() 
> > has finished before letting NetworkManager to continue to sleep. On the 
> > other hand, onPrepareForSleep() is simple code and can finish very fast, 
> > maybe an inhibit is a bit overkill, who knows?
> 
> Kai Uwe Broulik wrote:
> I think it's a bit of an overkill to have this. Also I don't want to 
> unneccessarily delay suspending just because of a convenience feature like 
> this.

Ok then. Ship it.


- Lamarque


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91153
---


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-25 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91598
---


Ship it!




Ship It!

- Lamarque Souza


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

2016-01-26 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
---

(Updated Jan. 26, 2016, 5:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Jan Grulich and Lamarque Souza.


Changes
---

Submitted with commit d8edcc6ab77836127f3cef5833bcd9e8a88a6e9f by Kai Uwe 
Broulik to branch master.


Repository: plasma-nm


Description
---

It's quite natural that the connection goes away when we're about to suspend :) 
Watch for this and then don't emit the notification.


Diffs
-

  kded/networkmanagement.notifyrc 7ce437c 
  kded/notification.h 9b8b51a 
  kded/notification.cpp 231d69e 

Diff: https://git.reviewboard.kde.org/r/126748/diff/


Testing
---

While I still think Plasma-NM is waay too verbose about everything, at 
least it doesn't tell me that I just disconnected when I suspend.

I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after 
resuming.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel