Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-19 Thread Michael Herger

I'm not an LMS developer (yet), but for this issue with NPR Radio
plugin, is this simply a matter of updating
https://github.com/LMS-Community/lms-plugin-repository/blob/master/extensions.xml,
with maxTarget set to something correct? Like maxTarget="7.9", or
whatever that may correctly be?


That file is created automatically from the developers' own file. It's 
the plugin developer who has to fix that value.

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-19 Thread rootee


bpa wrote: 
> Good. That avoids one possible source.
> 
> 
> Yes but in this case they don't install - they are on the list to be
> installed but never get installed as they fail validation but LMS will
> probably try to install at next startup.
> 
> If developer had made a mistake or omitted something (plugin updates are
> rarely done at leisure) - plugin install may fail at one of many points
> or may partially succeed (e.g. wrong name in URL, bad checksum, error in
> code).
> 
> The main point is that LMS hasn't crashed or broken anything else so
> current methods are adequate.  If you feel LMS must be improved - just
> write the code and submit the pull request.

I'm not an LMS developer (yet), but for this issue with NPR Radio
plugin, is this simply a matter of updating
https://github.com/LMS-Community/lms-plugin-repository/blob/master/extensions.xml,
with maxTarget set to something correct? Like maxTarget="7.9", or
whatever that may correctly be?

Thanks again, for the info.



rootee's Profile: http://forums.slimdevices.com/member.php?userid=70728
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-19 Thread bpa


rootee wrote: 
> "Use unsupported extensions" is _un_checked for me...
Good. That avoids one possible source.

> Ok, so you're saying that there can still remain rogue, incompatible
> plugins (E.g. NPR Radio) users can install, even if "Use unsupported
> extensions" is _un_checked, unless developers fix their repo XML's?
Yes but in this case they don't install - they are on the list to be
installed but never get installed as they fail validation but LMS will
probably try to install at next startup.

If developer had made a mistake or omitted something (plugin updates are
rarely done at leisure) - plugin install may fail at one of many points
or may partially succeed (e.g. wrong name in URL, bad checksum, error in
code).

The main point is that LMS hasn't crashed or broken anything else so
current methods are adequate.  If you feel LMS must be improved - just
write the code and submit the pull request.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-19 Thread rootee


bpa wrote: 
> The 3rd party Plugins are listed in the extensions repo xml which is
> downloaded as required by LMS from here
> https://github.com/LMS-Community/lms-plugin-repository/blob/master/extensions.xml
> 
> The NPR plugin is listed as Maxversion of *"* which means no LMS version
> restricitions.
> 
> 
> 
> Except keeping "Use unsupported extensions" setting unchecked, you can't
> anything more - it is up to plugin developer to keep the data correct. 
> 
> What happened was 8.* released and my plugins had a max version then of
> 7.9.*
> I hadn't tested the older plugin whether they worked with 8.* so it was
> safeer to keep restrictions.
> Usually there isn't a great takeup of 8.0.0 release - a lot of user wait
> until 8.0.1 so it seemed like no pressure.
> However 8.0.0 had a lot of on-line integration features and Tidal
> support that meant there was a rush of "non-technical" users to update
> followed by a rush of "complaint" about plugins not loading.
> 
> So with lots of caveats - I made a blanket change to all my plugins. I
> removed what I thought were all the "old" plugin but NPR slipped by.
> 
> For those users who still wanted to use incompatible plugins whose
> developer didn't update their repo xml - the Plugin "Use unsupported
> extensions" setting was added to LMS.

Ok, so you're saying that there can still remain rogue, incompatible
plugins (E.g. NPR Radio) users can install, even if "Use unsupported
extensions" is _un_checked, unless developers fix their repo XML's?



rootee's Profile: http://forums.slimdevices.com/member.php?userid=70728
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-19 Thread bpa


rootee wrote: 
> It's not clear to me what you're referring to here...

The 3rd party Plugins are listed in the extensions repo xml which is
downloaded as required by LMS from here
https://github.com/LMS-Community/lms-plugin-repository/blob/master/extensions.xml

The NPR plugin is listed as Maxversion of *"* which means no LMS version
restricitions.

> And, what, if anything, I should manually do to prevent incompatible
> plugins from showing up as installable?

Except keeping "Use unsupported extensions" setting unchecked, you can't
anything more - it is up to plugin developer to keep the data correct. 

What happened was 8.* released and my plugins had a max version then of
7.9.*
I hadn't tested the older plugin whether they worked with 8.* so it was
safeer to keep restrictions.
Usually there isn't a great takeup of 8.0.0 release - a lot of user wait
until 8.0.1 so it seemed like no pressure.
However 8.0.0 had a lot of on-line integration features and Tidal
support that meant there was a rush of "non-technical" users to update
followed by a rush of "complaint" about plugins not loading.

So with lots of caveats - I made a blanket change to all my plugins. I
removed what I thought were all the "old" plugin but NPR slipped by.

For those users who still wanted to use incompatible plugins whose
developer didn't update their repo xml - the Plugin "Use unsupported
extensions" setting was added to LMS.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-18 Thread rootee


bpa wrote: 
> There are LMS versions in two places: repo XML (controls listing in
> 3rdpaty list)  and Plugin install.xml (controls installation in LMS)
> Must be something left behind in a repo XML - because incompatible
> version shouldn't even appear on the 3rd party list.
> I thought I had cleared it out with the V8.* updates.

It's not clear to me what you're referring to here...

The only install.xml files I see are in for each installed plugin, E.g.
"./cache/InstalledPlugins/Plugins/Qobuz/install.xml".  I don't see any
repo.xml files, which don't live in the main "/var/lib/squeezeboxserver"
(?).

Can you be a little more specific about files/paths?  And, what, if
anything, I should manually do to prevent incompatible plugins from
showing up as installable?



rootee's Profile: http://forums.slimdevices.com/member.php?userid=70728
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-18 Thread bpa


rootee wrote: 
> Seems like LMS should remove incompatible plugins from the 3rd party
> listing entirely, or list them and disallow install.
There are LMS versions in two places: repo XML (controls listing in
3rdpaty list)  and Plugin install.xml (controls installation in LMS)
Must be something left behind in a repo XML - because incompatible
version shouldn't even appear on the 3rd party list.
I thought I had cleared it out with the V8.* updates.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-18 Thread rootee


bpa wrote: 
> The NPR plugin no longer works as NPR changed their API and there is no
> update.  What probably happened is you upgraded LMS and the old NPR
> plugin (now incompatible) got carried along but cannot be updated so
> left in limbo.  I thought LMS would delete it.
> 
> I think the way to delete it is to stop LMS and edit the
> prefs/extension.prefs file and delete the line with "NPR:1 " and also
> delete the NPR directory in Cache/InstalledPlugins/Plugins.  Then
> restart LMS.

I'd never installed the NPR Radio plugin until today, so it doesn't seem
that it carried over from a previous LMS version :confused:.

Also, enabling the "Update plugins automatically" option has
auto-magically removed the traces from both
"../prefs/plugin/extension.prefs" and
"../cache/InstalledPlugins/Plugins".

Seems like LMS should remove incompatible plugins from the 3rd party
listing entirely, or list them and disallow install.

Thank again.



rootee's Profile: http://forums.slimdevices.com/member.php?userid=70728
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-18 Thread bpa


rootee wrote: 
> I've tried installing the NPR Radio plugin, and get "Plugin is
> incompatible with this version of Logitech Media Server. Please update."
> In "Server Settings"->Plugins I see no option to update, nor a way to
> remove from the active plugins section (see attached).  Enabling "Update
> plugins automatically" doesn't seem to be updating this plugin; actually
> "Update plugins automatically" is the only way I've managed to *remove*
> the unchecked/non-updateable NPR Radio from active plugins, I.e.
> Enabling "Update plugins automatically" removes the un-checked NPR Radio
> from active plugins.  Should I just avoid NPR Radio plugin?  Is this a
> bug with the LMS plugin manager?

The NPR plugin no longer works as NPR changed their API and there is no
update.  What probably happened is you upgraded LMS and the old NPR
plugin (now incompatible) got carried along but cannot be updated so
left in limbo.  I thought LMS would delete it.

I think the way to delete it is to stop LMS and edit the
prefs/extension.prefs file and delete the line with "NPR:1 " and also
delete the NPR directory in Cache/InstalledPlugins/Plugins.  Then
restart LMS.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-18 Thread Paul Webster


The last status I see on that one is
https://forums.slimdevices.com/showthread.php?51002-Announce-NPR-Radio-plugin=889307=1#post889307



Paul Webster
http://dabdig.blogspot.com
author of \"now playing\" plugins covering radio france (fip etc), kcrw,
supla finland, abc australia, cbc/radio-canada and rte ireland

Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


[SlimDevices: Plugins] How to Remove Incompatible Plugins

2021-02-18 Thread rootee


I've tried installing the NPR Radio plugin, and get "Plugin is
incompatible with this version of Logitech Media Server. Please update."
In "Server Settings"->Plugins I see no option to update, nor a way to
remove from the active plugins section (see attached).  The only way
I've found to remove the unchecked/non-updateable NPR Radio from active
plugins is to enable "Update plugins automatically".  Should I just
avoid NPR Radio plugin?  Is this a bug with the LMS plugin manager?

Server Version: 8.2.0 - 1613284924 @ Sun Feb 14 08:12:26 CET 2021


+---+
|Filename: server-plugins.png   |
|Download: http://forums.slimdevices.com/attachment.php?attachmentid=33432|
+---+


rootee's Profile: http://forums.slimdevices.com/member.php?userid=70728
View this thread: http://forums.slimdevices.com/showthread.php?t=113975

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins