Re: PoCo-SOAP and PoCo-Server-TCP buffer flushing

2002-08-21 Thread Peter Chen

On Tue, 2002-08-20 at 16:34, Rocco Caputo wrote:
 On Mon, Jul 15, 2002 at 04:27:26PM -0400, Peter Chen wrote:
  Thank you for confirming this, and fixing it.  Please let me know when
  you have a release, and I will roll out another RPM.
 
 I seem to have fixed it, but I don't remember when.  The fix isn't the
 same as your code, but it seems equivalent.  Could you test it to make
 sure that it fixes your SOAP server and doesn't break anything else?

Will do.

Is there going to be another release?  I probably ought to make another
rpm with the fix.  Mandrake has accepted quite a few of the POE related
rpm's that I contributed.  So far there are perl-POE,
perl-POE-Component-Logger, perl-Log-Dispatch, perl-Log-Dispatch-Config,
etc.

Pete





Re: PoCo-SOAP and PoCo-Server-TCP buffer flushing

2002-08-21 Thread Rocco Caputo

On Wed, Aug 21, 2002 at 01:52:59PM -0400, Peter Chen wrote:
 On Tue, 2002-08-20 at 16:34, Rocco Caputo wrote:
  On Mon, Jul 15, 2002 at 04:27:26PM -0400, Peter Chen wrote:
   Thank you for confirming this, and fixing it.  Please let me know when
   you have a release, and I will roll out another RPM.
  
  I seem to have fixed it, but I don't remember when.  The fix isn't the
  same as your code, but it seems equivalent.  Could you test it to make
  sure that it fixes your SOAP server and doesn't break anything else?
 
 Will do.
 
 Is there going to be another release?  I probably ought to make another
 rpm with the fix.  Mandrake has accepted quite a few of the POE related
 rpm's that I contributed.  So far there are perl-POE,
 perl-POE-Component-Logger, perl-Log-Dispatch, perl-Log-Dispatch-Config,
 etc.

Thanks.  Not quite yet.  I'd like to at least nail down Cristiano's
latest Cygwin problem.

Has anyone else noticed socket weirdness on Cygwin?  Specifically, a
socket's not being closed until a session completely goes away.  We
were able to track it down through POE::Kernel to where the sockets
are destroyed.  We even close()'d the sockets manually, but the client
connection still does not break.

-- Rocco Caputo / [EMAIL PROTECTED] / poe.perl.org / poe.sf.net



Re: PoCo-SOAP and PoCo-Server-TCP buffer flushing

2002-08-21 Thread Peter Chen

On Wed, 2002-08-21 at 13:52, Peter Chen wrote:
 On Tue, 2002-08-20 at 16:34, Rocco Caputo wrote:
  I seem to have fixed it, but I don't remember when.  The fix isn't the
  same as your code, but it seems equivalent.  Could you test it to make
  sure that it fixes your SOAP server and doesn't break anything else?
 
 Will do.

I just tested this with some of the simplest cases.  After 6 clients
connecting to the PoCo::SOAP server concurrently making a total of 2000
requests, every thing seems to work.  The next step is to test this in a
bigger application.

I do have a question regarding the change in PoCo::Server::TCP (revision
1.24 from CVS server) though.  It appears that if it gets a read error 0
(the client stops writing to the socket), it will shut down the handler
session.  I am not sure whether this is the desired behavior.

I can imagine situations where the user may want to have more control
over when the handler session is shutdown.  For example, what happens
when a read error 0 is received by the server before the server
completes handling the request?  In several instances, upon ClientInput,
I use POE::Wheel::Run to handle some long running commands.  If the
server shuts down the handler session upon a read error 0, it will never
have a chance to send back a response.

If this a behavior that we wish to preserve for backward compatibility,
perhaps it can be achieved by adding an additional option to indicate
whether the handler session should automatically shutdown upon a read
error?

Pete