Re: [NEW/Update] net/nicotine-plus-3.2.2 port
On 2023/01/26 22:39:14 +, Ricardo Mestre wrote: > And sure enough attachment was not sent, here it is PLIST changed (there are translations for a few more languages) so needs an `make update-plist'. otherwise it builds and the gui pops up, can't properly runtest but it's ok op@ to import (finally! :)
Re: [NEW/Update] net/nicotine-plus-3.2.2 port
And sure enough attachment was not sent, here it is On 21:33 Thu 26 Jan , Ricardo Mestre wrote: > This seems to have been forgotten and fell through the cracks, attached is a > new > version (3.2.8) based on port provided in this email thread. Additionally it > now > uses a proper patch instead of calling sed directly. > > Tested on amd64, OK to import? > > On 11:50 Tue 26 Jul , Stuart Henderson wrote: > > On 2022/07/25 09:48, Omar Polo wrote: > > > some nits: > > > > > > - we've dropped the RCS Ids (the $OpenBSD$ line) in ports > > > - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per > > >Makefile.template > > > - no need to set MODPY_VERSION, that's already the default > > > > agreed on these > > > > > Personally, I'd go with a patch instead of sed -i for setup.py, but even > > > using sed -i should be fine in this case. (patches are more robust than > > > sed for updates; they break sometimes, but at least you get the chance > > > to see what's going on instead of blindling substituting.) > > > > +1 for this > > > nicotine-plus.tar.gz Description: application/tar-gz
Re: [NEW/Update] net/nicotine-plus-3.2.2 port
This seems to have been forgotten and fell through the cracks, attached is a new version (3.2.8) based on port provided in this email thread. Additionally it now uses a proper patch instead of calling sed directly. Tested on amd64, OK to import? On 11:50 Tue 26 Jul , Stuart Henderson wrote: > On 2022/07/25 09:48, Omar Polo wrote: > > some nits: > > > > - we've dropped the RCS Ids (the $OpenBSD$ line) in ports > > - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per > >Makefile.template > > - no need to set MODPY_VERSION, that's already the default > > agreed on these > > > Personally, I'd go with a patch instead of sed -i for setup.py, but even > > using sed -i should be fine in this case. (patches are more robust than > > sed for updates; they break sometimes, but at least you get the chance > > to see what's going on instead of blindling substituting.) > > +1 for this >
Re: [NEW/Update] net/nicotine-plus-3.2.2 port
On 2022/07/25 09:48, Omar Polo wrote: > some nits: > > - we've dropped the RCS Ids (the $OpenBSD$ line) in ports > - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per >Makefile.template > - no need to set MODPY_VERSION, that's already the default agreed on these > Personally, I'd go with a patch instead of sed -i for setup.py, but even > using sed -i should be fine in this case. (patches are more robust than > sed for updates; they break sometimes, but at least you get the chance > to see what's going on instead of blindling substituting.) +1 for this
Re: [NEW/Update] net/nicotine-plus-3.2.2 port
Omar Polo wrote: > Hello, > > "mdw" wrote: > > Hi, > > > > Nicotine+ is a graphical client for the Soulseek peer-to-peer network. > > https://github.com/nicotine-plus/nicotine-plus > > > > Over a year ago v3.0.0 was submitted to ports@, but didn't get any response > > https://marc.info/?l=openbsd-ports=161310210623977=2 > > > > Here is an updated version 3.2.2, apologies if anything looks funny it is > > my first time working with ports. > > it's not bad, there are just a couple of things to adjust but it's a > solid first submission :) > > > I tested briefly search/chat rooms/transfers on my system running -current > > and it seems to work fine. All of the hard work was done with the original > > submission I just updated a few things. > > > > Thanks, > > Matthew > > some nits: > > - we've dropped the RCS Ids (the $OpenBSD$ line) in ports > - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per >Makefile.template > - no need to set MODPY_VERSION, that's already the default > > Personally, I'd go with a patch instead of sed -i for setup.py, but even > using sed -i should be fine in this case. (patches are more robust than > sed for updates; they break sometimes, but at least you get the chance > to see what's going on instead of blindling substituting.) > > I'm attaching a diff against your Makefile with those nit fixed and an > updated tarball. I haven't really run-tested it more than clicking > around in the GUI (didn't want to mess around with the firewall atm) but > the port looks good and (assuming it works) it's OK op@ to import if > someone wants to. > > (+cc Han, the previous submitter) > > #application/x-gzip: /tmp/nicotine-plus.tar.gz wops, forgot to actually attach the updated port... while here i've dropped Han as maintainer, feel free to add yourself :) nicotine-plus.tar.gz Description: GNU Zip compressed data
Re: [NEW/Update] net/nicotine-plus-3.2.2 port
Hello,
"mdw" wrote:
> Hi,
>
> Nicotine+ is a graphical client for the Soulseek peer-to-peer network.
> https://github.com/nicotine-plus/nicotine-plus
>
> Over a year ago v3.0.0 was submitted to ports@, but didn't get any response
> https://marc.info/?l=openbsd-ports=161310210623977=2
>
> Here is an updated version 3.2.2, apologies if anything looks funny it is
> my first time working with ports.
it's not bad, there are just a couple of things to adjust but it's a
solid first submission :)
> I tested briefly search/chat rooms/transfers on my system running -current
> and it seems to work fine. All of the hard work was done with the original
> submission I just updated a few things.
>
> Thanks,
> Matthew
some nits:
- we've dropped the RCS Ids (the $OpenBSD$ line) in ports
- i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per
Makefile.template
- no need to set MODPY_VERSION, that's already the default
Personally, I'd go with a patch instead of sed -i for setup.py, but even
using sed -i should be fine in this case. (patches are more robust than
sed for updates; they break sometimes, but at least you get the chance
to see what's going on instead of blindling substituting.)
I'm attaching a diff against your Makefile with those nit fixed and an
updated tarball. I haven't really run-tested it more than clicking
around in the GUI (didn't want to mess around with the firewall atm) but
the port looks good and (assuming it works) it's OK op@ to import if
someone wants to.
(+cc Han, the previous submitter)
Cheers,
Omar Polo
--- Makefile.orig Mon Jul 25 09:25:22 2022
+++ MakefileMon Jul 25 09:42:05 2022
@@ -1,18 +1,19 @@
-# $OpenBSD$
COMMENT = graphical client for the SoulSeek peer-to-peer system
-CATEGORIES = net
-HOMEPAGE = https://nicotine-plus.github.io/nicotine-plus/
-MAINTAINER = Han Boetes
GH_ACCOUNT = Nicotine-Plus
GH_PROJECT = nicotine-plus
GH_TAGNAME = 3.2.2
-# GPLv3
+CATEGORIES = net
+
+HOMEPAGE = https://nicotine-plus.github.io/nicotine-plus/
+
+MAINTAINER = Han Boetes
+
+# GPLv3+
PERMIT_PACKAGE = Yes
MODULES = lang/python
-MODPY_VERSION =${MODPY_DEFAULT_VERSION_3}
MODPY_SETUPTOOLS = Yes
BUILD_DEPENDS =devel/gettext,-tools
RUN_DEPENDS = devel/desktop-file-utils \
@@ -22,6 +23,5 @@
pre-configure:
sed -i 's|share/man|man|' ${WRKSRC}/setup.py
-
.include
#application/x-gzip: /tmp/nicotine-plus.tar.gz
Re: [NEW/Update] net/nicotine-plus-3.2.2 port
On Sun, Jul 24, 2022 at 05:13:43PM +0300, mdw wrote: > Hi, > > Nicotine+ is a graphical client for the Soulseek peer-to-peer network. > https://github.com/nicotine-plus/nicotine-plus > > Over a year ago v3.0.0 was submitted to ports@, but didn't get any response > https://marc.info/?l=openbsd-ports=161310210623977=2 > > Here is an updated version 3.2.2, apologies if anything looks funny it is > my first time working with ports. > > I tested briefly search/chat rooms/transfers on my system running -current > and it seems to work fine. All of the hard work was done with the original > submission I just updated a few things. > > Thanks, > Matthew Tested on amd64 (July 11th snapshot) and seems to be working fine. Incidentally I've also been using the mentioned v3.0 port since it came on the list, without issues. I'm not experienced enough to formally check the port, so can't comment on that. It looks ok on a first look, although I think pkg/PLIST.orig is a leftover and shouldn't be there. Thanks for the port Zé --
