Re: NEW: audio/moc

[Dmitrij D. Czarkoff]

Dmitrij D. Czarkoff said:
> Dmitrij D. Czarkoff said:
> > This version uses fork+execl.  FWIW I am getting convinced that just
> > disabling this functionality is the best approach: it is basically used
> > for detecting music files with wrong filename suffixes.  Very few
> > legitimate use cases for this are better handled through renaming files.
> 
> Updated version with feedback from espie@.  As Michael Seyfert
> mentioned, this code path is not enabled by default.
> 
> Comments?  OKs?

Ping.

-- 
Dmitrij D. Czarkoff

Re: NEW: audio/moc

[Dmitrij D. Czarkoff]

Dmitrij D. Czarkoff said:
> This version uses fork+execl.  FWIW I am getting convinced that just
> disabling this functionality is the best approach: it is basically used
> for detecting music files with wrong filename suffixes.  Very few
> legitimate use cases for this are better handled through renaming files.

Updated version with feedback from espie@.  As Michael Seyfert
mentioned, this code path is not enabled by default.

Comments?  OKs?

For ease of review the added code follows (between #else and #endif):

|/* Given a file name, return the mime type or NULL. */
|char *file_mime_type (const char *file)
|{
|   char *result = NULL;
|
|   assert (file != NULL);
|
|#ifdef HAVE_LIBMAGIC
[...]
|#else
|   int std_out[2];
|   int status;
|   pid_t pid;
|   FILE *stream;
|   char *out;
|   size_t len;
|
|   if (pipe (std_out) == -1) {
|   logit ("Error interrogating file: %s", strerror (errno));
|   return result;
|   }
|
|   pid = fork();
|   if (pid == -1) {
|   logit ("Error interrogating file: %s", strerror (errno));
|   return result;
|   } else if (pid == 0) {
|   close (std_out[0]);
|   if (dup2 (std_out[1], STDOUT_FILENO) == -1)
|   _exit(1);
|   close(std_out[1]);
|
|   execlp ("/usr/bin/file", "file", "-bi", file, NULL);
|   logit ("Error interrogating file: %s", strerror (errno));
|   _exit(1);
|   }
|
|   close (std_out[1]);
|
|   if ((stream = fdopen (std_out[0], "r")) == NULL) {
|   logit ("Error interrogating file: %s", strerror (errno));
|   close(std_out[0]);
|   return result;
|   }
|
|   if ((out = fgetln (stream, )) == NULL) {
|   logit ("Error interrogating file: %s", strerror (errno));
|   fclose(stream);
|   return result;
|   }
|
|   if (len == 0) {
|   logit ("Error interrogating file: file(1) failed");
|   return result;
|   }
|   out[len - 1] = '\0';
|   result = xstrdup (out);
|
|   fclose (stream);
|
|   waitpid (pid, , 0);
|#endif
|
|   return result;
|}

-- 
Dmitrij D. Czarkoff


moc-2.5.0.tgz
Description: application/tar-gz

Re: NEW: audio/moc

[Dmitrij D. Czarkoff]

Marc Espie said:
> On Fri, Feb 05, 2016 at 02:14:54AM +0300, Vadim Zhukov wrote:
> > 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> > > Michael Seyfert said:
> > >> I'm trying to get this into the ports tree yet again.
> > >>
> > >> MOC is a console audio player with simple ncurses interface.  It
> > >> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> > >> directory using the menu and press enter to start playing the file.
> > >> The program will automatically play the rest of the files in the
> > >> directory.
> > >
> > > I added a patch to use file(1) instead of libmagic and marked this port
> > > as SHARED_ONLY.
> > >
> > > Comments?  OKs?
> > 
> > Why not just use fork+exec, without need to care about escaping anymore?
> > 
> > --
> >   WBR,
> >   Vadim Zhukov
> 
> Yep, definitely NOT OKAY.
> popen is a *broken* interface.
> 
> Do not ever use it;

Good to know.  Maybe manual for popen should explain the reasons?

-- 
Dmitrij D. Czarkoff

Re: NEW: audio/moc

[Michael Seyfert]

On Fri, Feb 05, 2016 at 12:55:49PM +0100, Dmitrij D. Czarkoff wrote:
> Vadim Zhukov said:
> > 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> > > Michael Seyfert said:
> > >> I'm trying to get this into the ports tree yet again.
> > >>
> > >> MOC is a console audio player with simple ncurses interface.  It
> > >> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> > >> directory using the menu and press enter to start playing the file.
> > >> The program will automatically play the rest of the files in the
> > >> directory.
> > >
> > > I added a patch to use file(1) instead of libmagic and marked this port
> > > as SHARED_ONLY.
> > >
> > > Comments?  OKs?
> > 
> > Why not just use fork+exec, without need to care about escaping anymore?
> 
> This version uses fork+execl.  FWIW I am getting convinced that just
> disabling this functionality is the best approach: it is basically used
> for detecting music files with wrong filename suffixes.  Very few
> legitimate use cases for this are better handled through renaming files.
> 
> P.S.:  As is pretty obvious from previous messages in this thread, I
> have little experience with exec and friends in C.  I'd appreciate
> feedback.
> 
> -- 
> Dmitrij D. Czarkoff

You can compile with configure option --without-magic. If this is a
common source of exploits then it should be removed.

-- 
Michael Seyfert 

Re: NEW: audio/moc

[Marc Espie]

On Fri, Feb 05, 2016 at 09:22:43AM +0100, Dmitrij D. Czarkoff wrote:
> Marc Espie said:
> > On Fri, Feb 05, 2016 at 02:14:54AM +0300, Vadim Zhukov wrote:
> > > 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> > > > Michael Seyfert said:
> > > >> I'm trying to get this into the ports tree yet again.
> > > >>
> > > >> MOC is a console audio player with simple ncurses interface.  It
> > > >> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> > > >> directory using the menu and press enter to start playing the file.
> > > >> The program will automatically play the rest of the files in the
> > > >> directory.
> > > >
> > > > I added a patch to use file(1) instead of libmagic and marked this port
> > > > as SHARED_ONLY.
> > > >
> > > > Comments?  OKs?
> > > 
> > > Why not just use fork+exec, without need to care about escaping anymore?
> > > 
> > > --
> > >   WBR,
> > >   Vadim Zhukov
> > 
> > Yep, definitely NOT OKAY.
> > popen is a *broken* interface.
> > 
> > Do not ever use it;
> 
> Good to know.  Maybe manual for popen should explain the reasons?

It does. In BUGS.

The popen() argument always calls sh(1).

so you have to jump thru hoops to try to sanitize stuff coming from outside,
ultimately failing.

Admittedly, system(3) does a better job of explaining it.

Re: NEW: audio/moc

[Dmitrij D. Czarkoff]

Vadim Zhukov said:
> 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> > Michael Seyfert said:
> >> I'm trying to get this into the ports tree yet again.
> >>
> >> MOC is a console audio player with simple ncurses interface.  It
> >> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> >> directory using the menu and press enter to start playing the file.
> >> The program will automatically play the rest of the files in the
> >> directory.
> >
> > I added a patch to use file(1) instead of libmagic and marked this port
> > as SHARED_ONLY.
> >
> > Comments?  OKs?
> 
> Why not just use fork+exec, without need to care about escaping anymore?

This version uses fork+execl.  FWIW I am getting convinced that just
disabling this functionality is the best approach: it is basically used
for detecting music files with wrong filename suffixes.  Very few
legitimate use cases for this are better handled through renaming files.

P.S.:  As is pretty obvious from previous messages in this thread, I
have little experience with exec and friends in C.  I'd appreciate
feedback.

-- 
Dmitrij D. Czarkoff


moc-2.5.0.tgz
Description: application/tar-gz

Re: NEW: audio/moc

[Michael Seyfert]

On Fri, Feb 05, 2016 at 12:55:49PM +0100, Dmitrij D. Czarkoff wrote:
> Vadim Zhukov said:
> > 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> > > Michael Seyfert said:
> > >> I'm trying to get this into the ports tree yet again.
> > >>
> > >> MOC is a console audio player with simple ncurses interface.  It
> > >> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> > >> directory using the menu and press enter to start playing the file.
> > >> The program will automatically play the rest of the files in the
> > >> directory.
> > >
> > > I added a patch to use file(1) instead of libmagic and marked this port
> > > as SHARED_ONLY.
> > >
> > > Comments?  OKs?
> > 
> > Why not just use fork+exec, without need to care about escaping anymore?
> 
> This version uses fork+execl.  FWIW I am getting convinced that just
> disabling this functionality is the best approach: it is basically used
> for detecting music files with wrong filename suffixes.  Very few
> legitimate use cases for this are better handled through renaming files.
> 
> P.S.:  As is pretty obvious from previous messages in this thread, I
> have little experience with exec and friends in C.  I'd appreciate
> feedback.
> 
> -- 
> Dmitrij D. Czarkoff

The option UseMimeMagic is false by default so that code is not
 used unless the user specifies it.
libmagic / file is not needed.

-- 
Michael Seyfert 

Re: NEW: audio/moc

[Vadim Zhukov]

2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> Michael Seyfert said:
>> I'm trying to get this into the ports tree yet again.
>>
>> MOC is a console audio player with simple ncurses interface.  It
>> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
>> directory using the menu and press enter to start playing the file.
>> The program will automatically play the rest of the files in the
>> directory.
>
> I added a patch to use file(1) instead of libmagic and marked this port
> as SHARED_ONLY.
>
> Comments?  OKs?

Why not just use fork+exec, without need to care about escaping anymore?

--
  WBR,
  Vadim Zhukov

Re: NEW: audio/moc

[Dmitrij D. Czarkoff]

Michael Seyfert said:
> I'm trying to get this into the ports tree yet again.
> 
> MOC is a console audio player with simple ncurses interface.  It
> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> directory using the menu and press enter to start playing the file.
> The program will automatically play the rest of the files in the
> directory.

I added a patch to use file(1) instead of libmagic and marked this port
as SHARED_ONLY.

Comments?  OKs?

-- 
Dmitrij D. Czarkoff


moc-2.5.0.tgz
Description: application/tar-gz

Re: NEW: audio/moc

[Marc Espie]

On Fri, Feb 05, 2016 at 02:14:54AM +0300, Vadim Zhukov wrote:
> 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff :
> > Michael Seyfert said:
> >> I'm trying to get this into the ports tree yet again.
> >>
> >> MOC is a console audio player with simple ncurses interface.  It
> >> supports OGG, WAV, MP3 and other formats.  Just run mocp, go to some
> >> directory using the menu and press enter to start playing the file.
> >> The program will automatically play the rest of the files in the
> >> directory.
> >
> > I added a patch to use file(1) instead of libmagic and marked this port
> > as SHARED_ONLY.
> >
> > Comments?  OKs?
> 
> Why not just use fork+exec, without need to care about escaping anymore?
> 
> --
>   WBR,
>   Vadim Zhukov

Yep, definitely NOT OKAY.
popen is a *broken* interface.

Do not ever use it;

Re: [NEW] audio/moc

[Michael Seyfert]

Sorry this is a late reply (20 days). I still want to get this port
finished. I've done all the changes below except SHARED_ONLY=Yes.
This port will probably only work with shared libraries support,
but it can be compiled without them with some tweaking.

I removed @sample ..., I don't think sample files should be in /etc/
for this software.

I wasn't sure on the tab width for field aligning, I'm guessing it
should be 8?

Please see the new port attached.

On Thu, Nov 19, 2015 at 01:15:16PM +, Stuart Henderson wrote:
> On 2015/11/19 12:59, Michael Seyfert wrote:
> > I'll try again getting this application in ports.
> > 
> > Description:
> > MOC (music on console) is a console audio player for LINUX/UNIX designed to 
> > be
> > powerful and easy to use.
> > 
> > The port is attached.
> > 
> > -- 
> > Michael Seyfert 
> 
> manpage patch:
> 
> | for in \fB${LOCALBASE}/share/moc/themes/\fP (depends on installation 
> prefix),
> 
> TRUEPREFIX not LOCALBASE
> 
> PLIST:
> 
> | share/examples/moc/
> | @sample ${SYSCONFDIR}/moc/
> | share/examples/moc/config.example
> | @sample ${SYSCONFDIR}/config.example
> | share/examples/moc/keymap.example
> | @sample ${SYSCONFDIR}/keymap.example
> 
> shouldn't the files go into ${SYSCONFDIR}/moc/ rather than just ${SYSCONFDIR}?
> 
> | %%SHARED%%
> 
> should probably just be marked SHARED_ONLY=Yes, remove PFRAG.shared and
> the %%SHARED%% marker and regen PLUST.
> 
> | COMMENT = console audio player
> | 
> | DISTNAME = moc-2.5.0
> | CATEGORIES = audio
> | 
> | HOMEPAGE = http://moc.daper.net/
> (etc)
> 
> please line things up like other ports do. some things can be a bit
> out of whack if having them completely lined up would involve excessive
> whitespace but try to be a bit neater e.g.
> 
> COMMENT = console audio player
> 
> DISTNAME =moc-2.5.0
> CATEGORIES =  audio
> 
> HOMEPAGE =http://moc.daper.net/
> 
> (same for the rest of the Makefile)
> 
> | # License: GPLv3+
> 
> no need to write "License: "
> 
> | LIB_DEPENDS = \
> | audio/faad \
> | audio/flac \
> 
> LIB_DEPENDS = audio/faad \
>   audio/flac \
> ...
> 
> | AUTOCONF_VERSION =  2.65
> | CONFIGURE_STYLE = gnu
> 
> you don't have anything that uses AUTOCONF_VERSION in this Makefile
> 

-- 
Michael Seyfert 


moc_port_2015_dec_10.tgz
Description: application/tar-gz

Re: [NEW] audio/moc

[Stuart Henderson]

On 2015/11/19 12:59, Michael Seyfert wrote:
> I'll try again getting this application in ports.
> 
> Description:
> MOC (music on console) is a console audio player for LINUX/UNIX designed to be
> powerful and easy to use.
> 
> The port is attached.
> 
> -- 
> Michael Seyfert 

manpage patch:

| for in \fB${LOCALBASE}/share/moc/themes/\fP (depends on installation prefix),

TRUEPREFIX not LOCALBASE

PLIST:

| share/examples/moc/
| @sample ${SYSCONFDIR}/moc/
| share/examples/moc/config.example
| @sample ${SYSCONFDIR}/config.example
| share/examples/moc/keymap.example
| @sample ${SYSCONFDIR}/keymap.example

shouldn't the files go into ${SYSCONFDIR}/moc/ rather than just ${SYSCONFDIR}?

| %%SHARED%%

should probably just be marked SHARED_ONLY=Yes, remove PFRAG.shared and
the %%SHARED%% marker and regen PLUST.

| COMMENT = console audio player
| 
| DISTNAME = moc-2.5.0
| CATEGORIES = audio
| 
| HOMEPAGE = http://moc.daper.net/
(etc)

please line things up like other ports do. some things can be a bit
out of whack if having them completely lined up would involve excessive
whitespace but try to be a bit neater e.g.

COMMENT =   console audio player

DISTNAME =  moc-2.5.0
CATEGORIES =audio

HOMEPAGE =  http://moc.daper.net/

(same for the rest of the Makefile)

| # License: GPLv3+

no need to write "License: "

| LIB_DEPENDS = \
| audio/faad \
| audio/flac \

LIB_DEPENDS =   audio/faad \
audio/flac \
...

| AUTOCONF_VERSION =  2.65
| CONFIGURE_STYLE = gnu

you don't have anything that uses AUTOCONF_VERSION in this Makefile

Re: NEW: audio/moc

[Michael Seyfert]

> On Mon, Oct 19, 2015 at 12:57:39PM +0200, Dmitrij D. Czarkoff wrote:
> > Michael Seyfert said:
> > > This is a port for the music on console (moc) music player.
> > > I have tested it on amd64, using it as my primary music player.
> > > 
> > > I patched out most of the strcpy and scanf.
> > > Please let me know what you think of it.
> > 
> > Several comments follow.  I didn't try building this port, and didn't
> > look closely into patches.
> > 
> > In moc/Makefile:
> > 
> > | # License: GPLv3+
> > | PERMIT_PACKAGE_CDROM = Yes
> > | PERMIT_PACKAGE_FTP = Yes
> > | PERMIT_DISTFILES_FTP = Yes
> > 
> > PERMIT_PACKAGE_CDROM=Yes implies PERMIT_PACKAGE_FTP=Yes and
> > PERMIT_DISTFILES_FTP=Yes.

> OK, fixed this.

> > 
> > | CONFIGURE_STYLE = gnu autoconf
> > 
> > autoconf implies gnu.
> > 

> changed to just 'gnu'.

> > | CONFIGURE_ENV = \
> > |   CFLAGS="-I${LOCALBASE}/include 
> > -I${LOCALBASE}/include/db4" \
> > |   LDFLAGS=-L${LOCALBASE}/lib
> > 
> > You should use
> > 
> >   CFLAGS += -I${LOCALBASE}/include -I${LOCALBASE}/include/db4
> >   LDFLAGS +=-L${LOCALBASE}/lib
> > 
> > The way you do it shadows user settings.
> >

> Looking at the other ports they all modify LDFLAGS the way Stuart
> said, so I changed it following his suggestion:
> CONFIGURE_ENV = \
> CPPFLAGS="-I${LOCALBASE}/include -I${LOCALBASE}/include/db4" \
> LDFLAGS="-L${LOCALBASE}/lib"


> > In moc/patches/patch-mocp_1 you should use ${LOCALBASE} here and add
> > something like this to makefile:
> > 
> >   post-build:
> > ${SUBST_CMD} ${WRKSRC}/mocp.1
> > 

> Fixed.


> Attached is another try at this port. I patched every strcpy / sprintf
> that was warned about by the compiler regardless of triviality. Is
> this a bad idea?
> It probably doesn't hurt anything, but gives extra complexity to the
> patches/ folder. This should go upstream to the official code for the
> next moc release.

Can I get this port submitted? Is anyone interested in this?

-- 
Michael Seyfert 


moc_port_try3.tgz
Description: application/tar-gz

Re: NEW: audio/moc

[Michael Seyfert]

On Mon, Oct 19, 2015 at 12:57:39PM +0200, Dmitrij D. Czarkoff wrote:
> Michael Seyfert said:
> > This is a port for the music on console (moc) music player.
> > I have tested it on amd64, using it as my primary music player.
> > 
> > I patched out most of the strcpy and scanf.
> > Please let me know what you think of it.
> 
> Several comments follow.  I didn't try building this port, and didn't
> look closely into patches.
> 
> In moc/Makefile:
> 
> | # License: GPLv3+
> | PERMIT_PACKAGE_CDROM = Yes
> | PERMIT_PACKAGE_FTP = Yes
> | PERMIT_DISTFILES_FTP = Yes
> 
> PERMIT_PACKAGE_CDROM=Yes implies PERMIT_PACKAGE_FTP=Yes and
> PERMIT_DISTFILES_FTP=Yes.

OK, fixed this.

> 
> | CONFIGURE_STYLE = gnu autoconf
> 
> autoconf implies gnu.
> 

changed to just 'gnu'.

> | CONFIGURE_ENV = \
> | CFLAGS="-I${LOCALBASE}/include 
> -I${LOCALBASE}/include/db4" \
> | LDFLAGS=-L${LOCALBASE}/lib
> 
> You should use
> 
>   CFLAGS +=   -I${LOCALBASE}/include -I${LOCALBASE}/include/db4
>   LDFLAGS +=  -L${LOCALBASE}/lib
> 
> The way you do it shadows user settings.
>

Looking at the other ports they all modify LDFLAGS the way Stuart
said, so I changed it following his suggestion:
CONFIGURE_ENV = \
CPPFLAGS="-I${LOCALBASE}/include -I${LOCALBASE}/include/db4" \
LDFLAGS="-L${LOCALBASE}/lib"


> In moc/patches/patch-mocp_1 you should use ${LOCALBASE} here and add
> something like this to makefile:
> 
>   post-build:
>   ${SUBST_CMD} ${WRKSRC}/mocp.1
> 

Fixed.

> -- 
> Dmitrij D. Czarkoff
> 

Attached is another try at this port. I patched every strcpy / sprintf
that was warned about by the compiler regardless of triviality. Is
this a bad idea?
It probably doesn't hurt anything, but gives extra complexity to the
patches/ folder. This should go upstream to the official code for the
next moc release.

-- 
Michael Seyfert 


moc-openbsd-port-try2-2.5.0.tgz
Description: application/tar-gz

Re: NEW: audio/moc

[Stuart Henderson]

On 2015/10/19 12:57, Dmitrij D. Czarkoff wrote:
> Michael Seyfert said:
> > This is a port for the music on console (moc) music player.
> > I have tested it on amd64, using it as my primary music player.
> > 
> > I patched out most of the strcpy and scanf.
> > Please let me know what you think of it.
> 
> Several comments follow.  I didn't try building this port, and didn't
> look closely into patches.
> 
> In moc/Makefile:
> 
> | # License: GPLv3+
> | PERMIT_PACKAGE_CDROM = Yes
> | PERMIT_PACKAGE_FTP = Yes
> | PERMIT_DISTFILES_FTP = Yes
> 
> PERMIT_PACKAGE_CDROM=Yes implies PERMIT_PACKAGE_FTP=Yes and
> PERMIT_DISTFILES_FTP=Yes.

portcheck(1) would warn about this.

I add /usr/ports/infrastructure/bin to my PATH and have this in
/etc/man.conf so I can use the ports tools easily:

manpath /usr/share/man
manpath /usr/X11R6/man
manpath /usr/local/man
manpath /usr/ports/infrastructure/man

> | CONFIGURE_STYLE = gnu autoconf
> 
> autoconf implies gnu.
> 
> | CONFIGURE_ENV = \
> | CFLAGS="-I${LOCALBASE}/include 
> -I${LOCALBASE}/include/db4" \
> | LDFLAGS=-L${LOCALBASE}/lib
> 
> You should use
> 
>   CFLAGS +=   -I${LOCALBASE}/include -I${LOCALBASE}/include/db4
>   LDFLAGS +=  -L${LOCALBASE}/lib
> 
> The way you do it shadows user settings.

Correct for CFLAGS, but ports doesn't have any particular handling
for LDFLAGS, it's not a documented user setting in bsd.port.mk(5)
and isn't automatically passed to autoconf, so that still needs
passing via CONFIGURE_ENV.

Also, if upstream's build scaffolding works correctly, you should
be able to pass -I in CPPFLAGS instead (which is a more correct
place than CFLAGS).

So, if it works, I'd go for

CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include -I${LOCALBASE}/include/db4" \
LDFLAGS="-L${LOCALBASE}/lib"

Re: NEW: audio/moc

[Dmitrij D. Czarkoff]

Michael Seyfert said:
> This is a port for the music on console (moc) music player.
> I have tested it on amd64, using it as my primary music player.
> 
> I patched out most of the strcpy and scanf.
> Please let me know what you think of it.

Several comments follow.  I didn't try building this port, and didn't
look closely into patches.

In moc/Makefile:

| # License: GPLv3+
| PERMIT_PACKAGE_CDROM = Yes
| PERMIT_PACKAGE_FTP = Yes
| PERMIT_DISTFILES_FTP = Yes

PERMIT_PACKAGE_CDROM=Yes implies PERMIT_PACKAGE_FTP=Yes and
PERMIT_DISTFILES_FTP=Yes.

| CONFIGURE_STYLE = gnu autoconf

autoconf implies gnu.

| CONFIGURE_ENV = \
|   CFLAGS="-I${LOCALBASE}/include 
-I${LOCALBASE}/include/db4" \
|   LDFLAGS=-L${LOCALBASE}/lib

You should use

  CFLAGS += -I${LOCALBASE}/include -I${LOCALBASE}/include/db4
  LDFLAGS +=-L${LOCALBASE}/lib

The way you do it shadows user settings.

In moc/patches/patch-mocp_1 you should use ${LOCALBASE} here and add
something like this to makefile:

  post-build:
${SUBST_CMD} ${WRKSRC}/mocp.1

-- 
Dmitrij D. Czarkoff

Re: new audio/moc

[Sébastien Morand]

 you are welcome,
 please, use openbsd-wip github repository to put your work-in-progress
 stuff.
 Have a look to openbsd-wip instructions to request your write access
 to repository and be careful to look all use instructions.


Got it, thanks for your help.

Re: new audio/moc

[Sébastien Morand]

 already there a work in progress[1][2] to this port

 [1] https://github.com/jasperla/openbsd-wip/tree/master/audio/moc
 [2] http://marc.info/?t=14287365141r=1w=2 (related thread)



Thanks for this, I didn't know about openbsd-wip. Ok for me, this one looks
like better, I have other ports to propose.

rgds,
Sébastien

Re: new audio/moc

[Gleydson Soares]

 [...] I have other ports to propose.

you are welcome,
please, use openbsd-wip github repository to put your work-in-progress stuff.
Have a look to openbsd-wip instructions to request your write access
to repository and be careful to look all use instructions.

cheers,
gsoares

Re: new audio/moc

[Gleydson Soares]

Sébastien Morand seb.mor...@gmail.com writes:

 Hi,

 First of all, this is my first submission for a new port, so sorry if big
 mistakes. I create port for audio/moc which is a music on console player
 based on ncurse.

 Tell me if ok,
 Sebastien

already there a work in progress[1][2] to this port

[1] https://github.com/jasperla/openbsd-wip/tree/master/audio/moc
[2] http://marc.info/?t=14287365141r=1w=2 (related thread)

cheers,
gsoares

Re: new audio/moc

[Dmitrij D. Czarkoff]

Hi, Sébastien!

Sébastien Morand said:
 First of all, this is my first submission for a new port, so sorry if big
 mistakes. I create port for audio/moc which is a music on console player
 based on ncurse.

Why do you need PKG_ARCH=*?

FWIW the difference between your port and the one in openbsd-wip
(https://github.com/jasperla/openbsd-wip/tree/master/audio/moc) is
suspicious.

-- 
Dmitrij D. Czarkoff

Re: NEW: audio/moc

[Simon Kuhnle]

On Fri, May 18, 2007 at 08:20:06AM +0200, Giovanni Bechis wrote:
 The port is available at:
 http://bigio.snb.it/openbsd/moc-2.4.1.tgz
  Ok? Comments ?
   Giovanni

I get the following error on make install:
===  Installing moc-2.4.1 from /usr/ports/packages/i386/all/
Can't install /usr/ports/packages/i386/all/moc-2.4.1.tgz: lib not found
idn.16.15
Even by looking in the dependency tree:
libid3tag-0.15.1bp0, libmad-0.15.1bp1, libsndfile-1.0.11p0,
libsamplerate-0.1.2p0, libogg-1.1.3, curl-7.16.0, libiconv-1.9.2p3,
flac-1.1.2p1
*** Error code 1

Stop in /usr/ports/mystuff/moc (line 1402 of
/usr/ports/infrastructure/mk/bsd.port.mk).

Perhaps you need libidn as dependency?
Or am I doing something wrong?

-- 
simon

Re: NEW: audio/moc

[Stuart Henderson]

On 2007/05/18 16:45, Simon Kuhnle wrote:
 
 I get the following error on make install:
 ===  Installing moc-2.4.1 from /usr/ports/packages/i386/all/
 Can't install /usr/ports/packages/i386/all/moc-2.4.1.tgz: lib not found
 idn.16.15
 Even by looking in the dependency tree:
 libid3tag-0.15.1bp0, libmad-0.15.1bp1, libsndfile-1.0.11p0,
 libsamplerate-0.1.2p0, libogg-1.1.3, curl-7.16.0, libiconv-1.9.2p3,
 flac-1.1.2p1
 *** Error code 1

 Stop in /usr/ports/mystuff/moc (line 1402 of
 /usr/ports/infrastructure/mk/bsd.port.mk).
 
 Perhaps you need libidn as dependency?
 Or am I doing something wrong?

You need to update curl to 7.16.2.

I was scratching my head over this earlier with a different
port. It's to do with the recent curl update. I'm not convinced
things are quite right as they stand - I wonder if the curl-
using ports which have been updated to list idn in wantlib
actually need LIB_DEPENDS=curl:curl-=7.16.2:net/curl

Re: NEW: audio/moc

[steven mestdagh]

On Fri, May 18, 2007 at 04:45:27PM +0200, Simon Kuhnle wrote:
 On Fri, May 18, 2007 at 08:20:06AM +0200, Giovanni Bechis wrote:
  The port is available at:
  http://bigio.snb.it/openbsd/moc-2.4.1.tgz
   Ok? Comments ?
Giovanni
 
 I get the following error on make install:
 ===  Installing moc-2.4.1 from /usr/ports/packages/i386/all/
 Can't install /usr/ports/packages/i386/all/moc-2.4.1.tgz: lib not found
 idn.16.15
 Even by looking in the dependency tree:
 libid3tag-0.15.1bp0, libmad-0.15.1bp1, libsndfile-1.0.11p0,
 libsamplerate-0.1.2p0, libogg-1.1.3, curl-7.16.0, libiconv-1.9.2p3,
 flac-1.1.2p1
 *** Error code 1
 
 Stop in /usr/ports/mystuff/moc (line 1402 of
 /usr/ports/infrastructure/mk/bsd.port.mk).
 
 Perhaps you need libidn as dependency?
 Or am I doing something wrong?

yes, you need to update, more specifically curl.

a port of moc has been submitted before, but not imported yet due to
problems on some archs, i'll try to take another look.

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

Re: NEW: audio/moc

[Giovanni Bechis]

On Fri, May 18, 2007 at 04:11:34PM +0100, Stuart Henderson wrote:
 You need to update curl to 7.16.2.
 
 I was scratching my head over this earlier with a different
 port. It's to do with the recent curl update. I'm not convinced
 things are quite right as they stand - I wonder if the curl-
 using ports which have been updated to list idn in wantlib
 actually need LIB_DEPENDS=curl:curl-=7.16.2:net/curl
 
Port updated, the new port is available at:
http://bigio.snb.it/openbsd/moc-2.4.1.tgz
 Cheers
  Giovanni

Re: NEW: audio/moc

[Simon Kuhnle]

On Fri, May 18, 2007 at 05:26:15PM +0200, Giovanni Bechis wrote:
 Port updated, the new port is available at:
 http://bigio.snb.it/openbsd/moc-2.4.1.tgz

Now it compiles and installs fine.
Works for me (read: it plays the selected files :) on i386.
-- 
simon