Re: [Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations ---+ Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: enhancement | Status: closed Priority: minor | Milestone: Component: potlatch2 | Version: Resolution: fixed |Keywords: ---+ Comment(by Petr Dlouhý): Thanks -- Ticket URL: https://trac.openstreetmap.org/ticket/3777#comment:10 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations --+- Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor | Milestone: Component: potlatch2 | Version: Keywords:| --+- Comment(by Petr Dlouhý): Sorry for my overreaction, but I really think, it is serious problem. Here is another damaging edit from different user: http://www.openstreetmap.org/browse/changeset/8093999 -- Ticket URL: https://trac.openstreetmap.org/ticket/3777#comment:8 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
[Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations --+- Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: defect| Status: new Priority: critical | Milestone: Component: potlatch2 | Version: Keywords:| --+- When merging two ways, which one of them is part of a relation and the second isn't, Potlach doesn't warn user. This leads to corruption of the relations -- Ticket URL: https://trac.openstreetmap.org/ticket/3777 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations --+- Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor | Milestone: Component: potlatch2 | Version: Keywords:| --+- Comment(by woodpeck): Could either of you, for the benefit of others reading this, explain *what* exactly Potlatch does in the case discusssed? Will the new, combined way be part of the relation or will it not? Or does it depend on whichever way was selected first? Properly documenting this would go a long way to avoiding problems, even without any change to the code, I should think. As for popping up warnings, I think Potlatch has on a number of other occasions already gone a different way - instead of are you sure you want to delete 12345 nodes, Potlatch would say deleted 12345 nodes - hit Ctrl-Z to undo or something. Maybe it is possible to do something similar with way merges in the situation that Peter described. -- Ticket URL: https://trac.openstreetmap.org/ticket/3777#comment:2 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations --+- Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor | Milestone: Component: potlatch2 | Version: Keywords:| --+- Comment(by Richard): Potlatch 2 renders route relations such as that. It has always done so, without any need for a plugin or alternative stylesheet or whatever. I don't see any evidence that this is an editor issue. It simply looks like a mapper who made a mistake. We can't completely stop that happening, you know. :) -- Ticket URL: https://trac.openstreetmap.org/ticket/3777#comment:5 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations --+- Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor | Milestone: Component: potlatch2 | Version: Keywords:| --+- Comment(by Petr Dlouhý): He doesn't made a mistake because he was distracted. He made a mistake, because he doesn't know, what he was doing and the editor didn't gave him an advice even if it could. Why does Potlatch warn if merging two ways with different tags, but does not when merging two ways with different relation membership? Isn't the situation identical? -- Ticket URL: https://trac.openstreetmap.org/ticket/3777#comment:6 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #3777: Potlach 2 doesn't warn, when corrupting relations
#3777: Potlach 2 doesn't warn, when corrupting relations --+- Reporter: petr.dlouhy@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor | Milestone: Component: potlatch2 | Version: Keywords:| --+- Comment(by Richard): Sure. Like I said above, it could do. The reason why it doesn't yet, I guess, is because neither you nor I nor anyone has fixed it to do so. I'll do that at some point but my willingness to do so is not best helped by trac tickets screaming critical and ZOMG CORRUPTION THIS MUST BE FIXED. But as I keep saying: Potlatch _does_ make the user aware that they have extended the relation membership to a part of the way that was not previously a member. It does this by clearly rendering the way differently. The user is looking at the map so will see this. After all, should Potlatch pop up an alert saying You changed the highway type from trunk to primary every time you do that? Even though the change is reflected in a different rendering? And so on. -- Ticket URL: https://trac.openstreetmap.org/ticket/3777#comment:7 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
