[issue20332] Argument Clinic docs do not list support for the 'l' format
Tal Einat added the comment: See documentation patch for this issue attached to issue20346 (a duplicate of this). -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20332 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: I thought AC was how all new modules were supposed to be written. If so, the example modules should definitely use AC! Also note that once the generated code is in separate files, the code in the origin files will be simpler and clearer. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: Thanks, Stefan. I hadn't realized that the xx files were targeted mainly a third-party developers. In this case, I can see the sense in not converting them. I only wish someone had said something *before* I went ahead and converted them... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20341] Argument Clinic: add nullable ints
Tal Einat added the comment: The new patch still uses NULLABLE_PY_SSIZE_T_INITIALIZE instead of NULLABLE_INT_T_INITIALIZE in one place in int_converter.converter_init. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20341 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20325] Argument Clinic: self converters are not preserved when clonig functions
New submission from Tal Einat: In Objects/bytes.c, the strip methods need a self converter so that they get a PyBytesObject* instead of PyObject*. However, having set this in bytes.strip and cloning that clinic definition for bytes.lstrip and bytes.rstrip, it appears that the self converter wasn't set on lstrip and rstrip. Removing the cloning and copying the argument definitions resolved the issue. Is this a bug? -- components: Build, Demos and Tools messages: 208633 nosy: larry, taleinat priority: normal severity: normal status: open title: Argument Clinic: self converters are not preserved when clonig functions type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20325 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20327] Argument Clinic: setting internal variable names for parsed arguments
New submission from Tal Einat: It would be useful for conversion of existing function to be able to set the name of the C variable for arguments which is different than the Python argument name. For example, not being able to do so makes converting bytes.translate much harder. In the existing code, the first argument is called 'table' in the docs but 'tableobj' in the code. Furthermore, a different variable named 'table' is used rather extensively in the function. If clinic could be told to name the C variable 'tableobj', then that would be that. Otherwise renaming two variables in the code is unaviodable. -- components: Build, Demos and Tools messages: 208641 nosy: taleinat priority: normal severity: normal status: open title: Argument Clinic: setting internal variable names for parsed arguments type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20327 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20187] The Great Argument Clinic Conversion Derby Meta-Issue
Tal Einat added the comment: Never mind my previous comment; I realize it would create to much of a mess. Sorry for the noise. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20187 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files
Tal Einat added the comment: While converting Objects/stringlib/transmogrify.h as part of issue20180 (Derby #11), some changes to Objects/bytesobject.c and Objects/bytearrayobject.c were required. Those changes are included in the relevant patch attached to that issue. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20181 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20187] The Great Argument Clinic Conversion Derby Meta-Issue
Tal Einat added the comment: I've been working on converting unicode, bytes and bytearray, but their files are separated into Derby groups #10, #11 and #12. Could we create a new issue and move the relevant files to it? The files I'd like to move: From Derby #10 (issue20179): Objects/bytes_methods.c Objects/bytesobject.c From Derby #11 (issue20180): Objects/unicodeobject.c Objects/stringlib/find.h Objects/stringlib/transmogrify.h From Derby #12 (issue 20181): Objects/bytearrayobject.c: 13 sites -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20187 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files
Tal Einat added the comment: Attached patch for AC conversion of Objects/bytesobject.c and Objects/bytearrayobject.c. This is one patch because there are changes that must be done in bytes_methods.h and bytes_methods.c that affect both of bytesobject.c and bytearrayobject.c. Those changes are in this patch as well. All methods were converted except for two groups: 1) the various find methods which use the common argument parsing function 'stringlib_parse_args_finds_byte' 2) 'new' and 'init' methods Also note that both of these classes use some common function implementations found under 'stringlib'. However, since that code is in separate files, I'll upload the conversion patches to the relevant issue (and write an appropriate comment here). -- keywords: +patch Added file: http://bugs.python.org/file33599/bytes_and_bytearray.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files
Tal Einat added the comment: See nearly complete conversion of Objects/bytearrayobject.c in patch attached to issue20179. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20181 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20227] Argument Clinic: rename arguments in generated C?
Tal Einat added the comment: +1 for this. It would save a bit of manual conversion work, and would significantly reduce the size and complexity of the resulting patches. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20227 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files
Tal Einat added the comment: Attached updated patch for bytes and bytearray. In the previous patch I missed the 'clear' and 'copy' bytearray methods. This patch is a replacement for the previous one, with the additional conversion of these two methods. -- Added file: http://bugs.python.org/file33601/bytes_and_bytearray_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: Attaching a new patch for complete conversion of Objects/unicodeobject.c. This is to replace the previous patch for this file. This new patch also converts all other possible unicode methods, including those not using PyArg_* functions. This includes various methods with no arguments or with one PyObject* argument. Unicode methods still not converted, probably impossible to convert: 1) The various find methods (index, count, startswith, rfind, etc.), because they use a special function 'stringlib_parse_args_finds_unicode' to parse their arguments 2) format and format_map, since they are defined elsewhere 3) _decimal2ascii, since it is just for debugging -- Added file: http://bugs.python.org/file33604/unicodeobject.c_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: Attaching patch for complete conversion of Objects/unicodeobject.c. Notes: * maketrans() was already converted * converting the lstrip, rstrip and strip methods required a small, non-trivial change to the code, since they used a common function for argument parsing * the documentation for replace() now correctly reflects the actual function signature * I rephrased some doc-strings where it was required, and in several places moved some of the text into parameter descriptions -- Added file: http://bugs.python.org/file33578/unicodeobject.c.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: Attached patch for AC conversion of Objects/stringlib/transmogrify.h. Converting the functions in this file required changes to Objects/bytesobject.c and Objects/bytearrayobject.c. Those changes are in the patch as well. The conversion of those files is part of issue20179 (Derby #10). I'm adding a comment on that issue as well with a reference to this. -- Added file: http://bugs.python.org/file33579/transmogrify.h.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files
Tal Einat added the comment: While converting Objects/stringlib/transmogrify.h as part of issue20180 (Derby #11), some changes to Objects/bytesobject.c and Objects/bytearrayobject.c were required. Those changes are included in the relevant patch attached to that issue. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20179 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20304] Argument Clinic: char convertor should use default values of type bytes
New submission from Tal Einat: For example, in `Object/stringlib/transmogrify.h`, the methods `ljust` and `rjust` have an argument named `fillchar` of type char. It's Python default value should be b' ', but the only way I've found to do that is by setting `py_default = b' '`. -- components: Build, Demos and Tools messages: 208481 nosy: larry, taleinat priority: normal severity: normal status: open title: Argument Clinic: char convertor should use default values of type bytes type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20304] Argument Clinic: char convertor should use default values of type bytes
Tal Einat added the comment: Additionally, the char converter doesn't create valid c defaults. For example, I got instead of ' ' for fillchar, which has type char, so I had to manually set c_default = ' '. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: I'm attaching my conversion of deque.rotate and _count_elements in Modules/_collectionsmodule.c. There remain 3 other functions in that module to be converted. One is deque_init which returns int; Larry said (on IRC) to hold off with that for now. The other two are dequeiter_new and dequereviter_new, which use the O! format, which I am unsure how to handle. -- keywords: +patch nosy: +taleinat Added file: http://bugs.python.org/file33535/_collectionsmodule.c.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18771] Reduce the cost of hash collisions for set objects
Tal Einat added the comment: The following benchmarks were run with the second version of the patch (so2.diff), once before and once after. OSX 10.8 on a Macbook Pro, 2.5 GHz Core i5, two cores each with 256kb L2 cache, 3MB L3 cache: 1.32% less time for first benchmark (7.07 before, 6.98 after) 1.31% less time for second benchmark (9.81 before, 9.68 after) Ubuntu 12.10 64-bit, AMD Athlon II X2 250 Processor (3.0 GHz, 2MB L2 cache, 256KB total L1 per processor): 5% less time for first benchmark (13.6 before, 12.9 after) 11% less time for second benchmark (18.3 before, 16.3 after) Win7 64-bit, Intel Xeon E3-1230 V2 (quad-core, 3.30GHz, 256kb L2 cache per core, 8MB L3 cache): 1.8% less time for first benchmark (3.90 before, 3.83 after) 3.5% less time for second benchmark (7.27 before, 7.02 after) However, this processor has Intel SmartCache, which as far as I can tell means one processor can use other processors' caches if they are inactive. So I ran the benchmarks again with 4x larger data sets (revised benchmark script attached): 3.8% less time for first benchmark (19.3 before, 18.6 after) 7.5% less time for second benchmark (33.1 before, 30.6 after) -- nosy: +taleinat Added file: http://bugs.python.org/file31372/set_bench_smartcache.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18771 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18771] Reduce the cost of hash collisions for set objects
Tal Einat added the comment: Because of the unusually low differences, I tried running the benchmarks again on the MacBook (OSX 10.8). The first time was actually with so.diff, this time was with so2.diff. 0.69% less time for first benchmark (7.30 before, 7.25 after) 8.08% less time for second benchmark (10.85 before, 9.97 after) Strange... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18771 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18771] Reduce the cost of hash collisions for set objects
Tal Einat added the comment: Sorry to be pedantic, but while 19.67sec is about 11.2% less than 22.16sec, it is actually about 12.6% faster (22.16/19.67 - 1). Regardless, that's a good result! And I'm happy that the modified benchmark is useful. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18771 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8285] IDLE not smart indenting correctly in nested statements
Changes by Tal Einat talei...@gmail.com: -- nosy: -taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8285 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.__new__
Tal Einat talei...@gmail.com added the comment: I'd just like to weigh in and say that this is a major issue for me at the moment. Not being able to indiscriminately pickle/unpickle exceptions is making my parallel-processing work very painful, because of problematic stdlib exceptions. I'm surprised this hasn't been fixed way back in 2.x. FWIW, for my project having this fixed in 3.x could be a significant incentive to finally ditch 2.x. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1692335 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12590] First line and cursor not visible when opening files
Changes by Tal Einat talei...@gmail.com: -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12590 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12411] cgi.parse_multipart is broken on 3.x
Tal Einat talei...@gmail.com added the comment: The patch seems broken to me. In cgi.parse_multipart(), the 'boundary' variable can be a string even though it is concatenated to bytes. Its default value is a string, and a string can be given via the pdict argument. There is no validity check other than valid_boundary(), which allows both string and bytes. Most of the changes to test_cgi.py are entirely unrelated. The one test added which tests cgi.parse_multipart() should fail since it uses a string (not bytes) boundary, while the correct boundary for the test is commented out. I short this patch seems half-baked. IMO reject this patch and fix just the bytes/strings issue with cgi.parse_multipart. Or, as mentioned in the comments, use FieldStorage to implement it and be done with it. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12411] cgi.parse_multipart is broken on 3.x
Tal Einat talei...@gmail.com added the comment: Yes, please submit the other additional tests in a separate issue. The default value for boundary should surely be b. A simple test should be added where cgi.parse_multipart() uses the default boundary. If valid_boundary() is used only for cgi.parse_multipart() then it should be changed to validate that the boundary is a bytes instance (which would also make it simpler). Otherwise (if vaild_boundary() is also used elsewhere) cgi.parse_multipart() should itself check that the boundary is indeed a bytes instance, throwing a TypeError otherwise. Tip: You should run the relevant tests, making sure they all pass, before submitting a patch. That way you really know that the patch actually works (as far as passing all of the tests). Thanks for adding more stdlib tests :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10107] Quitting IDLE on Mac doesn't save unsaved code
Tal Einat talei...@gmail.com added the comment:
Note that some discussion about this issue is taking place on the idle-dev
mailing list.
Bruce Sherwood found the line root.bind('close-all-windows',
flist.close_all_callback), which seems to be an unsuccessful attempt to
achieve the wanted behavior.
Kevin Walzer mentioned that a grep on the idlelib code doesn't turn up any
references to tk::mac::Quit.
I don't have access to OSX for testing. Could someone please replace the
root.bind call with what Kevin suggested, and see if it solves the problem?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10107
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6858] This is a python file, apply syntax highlighting
Tal Einat talei...@gmail.com added the comment: I think we are in agreement :) Regarding the warning message, I was referring only to the case that the syntax highlighter fails completely and raises an exception. I'm not even sure if that can happen, but in case it does an informative message would be better than just not highlighting, and much better than IDLE dying. I'm bringing this up in this context because IMO if we allow highlighting of arbitrary files, we should at least ensure that this doesn't crash IDLE if the highlighting does fail. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6858 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6858] This is a python file, apply syntax highlighting
Tal Einat talei...@gmail.com added the comment: I'm +1 on adding such an option to the menu, if only to be able to highlight files including only Python code which don't happen to have the .py extension. If support for files including not only Python code is important to anyone, some examples of such files would be very helpful. I've never seen such files and I don't know how common such uses are. Supporting files with some Python code in between other stuff is a different matter. Non-Python code being wrongly highlighted may be fine, but we'll need to make sure that the syntax highlighting is robust enough to be able to withstand going through a lot of invalid syntax, and still correctly highlight most of the Python code found in between. If IDLE fails to highlight a file it could of course fail gracefully, give an error message and not highlight, so I don't foresee this causing any stability issues. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6858 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5817] Right-click behavior from Windows Explorer
Tal Einat talei...@gmail.com added the comment: That makes sense. I think this issue can be closed. For future reference, the original feature request has a benefit beyond not having a shell window open for every editor window. Opening different files in the same instance of IDLE allows running them in the same shell easily via Run Module. However, IMO this would be much too small a benefit compared to the effort required to achieve it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5817 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1253] IDLE - Percolator overhaul
Tal Einat talei...@gmail.com added the comment: Note that at one point discussion of this issue was continued on the tracker page for issue1252. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1253 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6698] IDLE no longer opens only an edit window when configured to do so
Tal Einat talei...@gmail.com added the comment: After looking through the code and experimenting a bit, I propose the following: The editor-on-startup config option should be removed. Running IDLE without arguments should open a shell. If IDLE is asked to open any files for editing, it should open just editor windows. IDLE should open both a shell window and one or more editor windows only when explicitly asked to do so on the command line. If this is done, the -e option (open an editor) would tell IDLE to open an empty editor window if no files are asked to be opened for editing. If no other arguments are given, IDLE will open just an editor window (no shell window). The -i option (open a shell) would tell IDLE to open a shell window even if asked to open files for editing. I think this is more obvious and easier to work with. It will also make the command line argument processing code simpler. And as a bonus we remove a config option :) Thoughts? Comments? If there is agreements I will work up a patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6698 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6698] IDLE no longer opens only an edit window when configured to do so
Tal Einat talei...@gmail.com added the comment: My question is, when IDLE is run without arguments (as is the case for IDLE.app), what is the benefit opening an empty editor window as opposed to a shell window? In both cases if you just want to edit a file you must open it via the menus (e.g. File-Open or File-Recent Files), and an unused window is left open. On the other hand, if you do want a shell, having an empty editor window is useless. Therefore I think in this case it is always better to open a shell window. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6698 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface
Tal Einat talei...@gmail.com added the comment: IDLE should be accessible and easy to use for beginners who have never used a command line. Therefore I don't think up/down should scroll through the history by default. Since IDLE looks like a text editor (even the shell window) it is more intuitive that the arrows should move the cursor around the window. Note that a user can configure up/down to scroll through the history quite easily using the configuration dialog. I agree that as it stands it is hard to discover how to scroll through the history, and that Return can be used to bring previous code into the current command line. I think we can find a better way to make these features known to new users, without making the interface less intuitive. For example, we could have a Welcome to IDLE! screen that appears the first time IDLE is run by a user, which outlines a few basic features such as these. This should of course be complemented by better documentation, including a section on various commands (a separate issue). -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2704 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface
Tal Einat talei...@gmail.com added the comment: Regarding passing on letter/number key-presses to the command line, I'm -0 on this. Note that not only letter/number keys should be passed on. I've often found myself wanting to type in the command line after looking at previous code, to see that my key presses are being ignored, and having to Ctrl+End to return the cursor to the command line. However, if I was scrolling through the history and by accident hist a letter or number, having the cursor jump to the command line and the window scroll back to the end would be annoying. Personally, I would prefer avoiding this and having to use Ctrl+End to return to the command line. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2704 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524639] Fix Tkinter Tcl-commands memory-leaks
Changes by Tal Einat talei...@gmail.com: -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1524639 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] Right Click Context Menu
Tal Einat talei...@gmail.com added the comment:
I agree with Guilherme: shortcuts don't need to appear in the context menu.
Guilherme's patch looks pretty good overall, but I have a few remarks:
1) Pasting should be disabled in the Shell window when the cursor is before the
I/O mark. (the behavior for cutting is correct)
2) Code relevant to the Shell window should be in PyShell, not in EditorWindow
with a getattr(self, 'interp', None) check.
3) Tk.Text.compare can receive names of tags to compare (don't have to do
Tk.Text.index('tag name'))
So I made these changes. Attached are patches against current trunk (2.x) and
py3k branch.
My testing on Windows7 with both 2.7 and 3.1.2 showed this change works well.
This should be tested on OSX and Linux since it interacts with the clipboard,
which works differently on these platforms.
--
nosy: +taleinat
Added file: http://bugs.python.org/file18089/IDLE_rmenu_trunk.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] Right Click Context Menu
Changes by Tal Einat talei...@gmail.com: Added file: http://bugs.python.org/file18090/IDLE_rmenu_py3k.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1207589 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9290] IDLE and Command line present different behavior for sys.stdin
Tal Einat talei...@gmail.com added the comment: I agree that the wrapping of these in IDLE should be as transparent as possible. It would be helpful if you could specify what other quirks you have found regarding sys.stdin, sys.stdout and sys.stderr, preferably describing use cases where these are problematic. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9290 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9262] IDLE: Use tabbed shell and edit windows
Tal Einat talei...@gmail.com added the comment: (Note: there has recently been some discussion of this on idle-dev and python-dev.) This may be nice to have but has complications. I think there are currently more pressing issues regarding IDLE that require our attention. Also, just adding tabs isn't necessarily enough. Having several separate windows should still be an option. And if you can have several windows, each with several tabs, drag-n-drop moving of tabs between windows is really nice to have, not to mention drag-n-drop reordering of tabs. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9262 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9222] IDLE: Fix open/saveas 'Files of type' choices
Tal Einat talei...@gmail.com added the comment:
On Windows, I can't think of any common reason to want to save a file edited in
IDLE without the .py extension. On the other hand, accidentally forgetting the
.py extension is annoying, and users have come to expect a default extension
being added by applications (e.g. MS Office).
Guilherme's patch (applied manually) works fine here on Windows7. I'm all for
committing this if it has been tested to work as expected on Linux and OSX.
(minor nit-pick: could use sys.platform.startswith('win') instead of slicing)
--
nosy: +taleinat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9222
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6378] Patch to make 'idle.bat' run idle.pyw using appropriate Python interpreter (so 3.1's idle.bat does not accidently use python26.exe)
Changes by Tal Einat talei...@gmail.com: -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6378 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7676] IDLE shell shouldn't use TABs
Changes by Tal Einat talei...@gmail.com: -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7676 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5817] Right-click behavior from Windows Explorer
Tal Einat talei...@gmail.com added the comment: Just to get this on the table: What is the benefit of having it opened in the same instance of IDLE rather than a new instance? -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5817 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7136] Idle File Menu Option Improvement
Tal Einat talei...@gmail.com added the comment: +1 on renaming it New File. Patch attached for py3k. -- keywords: +patch nosy: +taleinat Added file: http://bugs.python.org/file18092/IDLE_new_file_py3k.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7136 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9222] IDLE: Fix open/saveas 'Files of type' choices
Tal Einat talei...@gmail.com added the comment: You're right Terry, my bad, I got the issues mixed up. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4832] idle filename extension
Tal Einat talei...@gmail.com added the comment:
On Windows, I can't think of any common reason to want to save a file edited in
IDLE without the .py extension. On the other hand, accidentally forgetting the
.py extension is annoying, and users have come to expect a default extension
being added by applications (e.g. MS Office).
Guilherme's patch (applied manually) works fine here on Windows7. I'm +1 for
committing this if it has been tested to work as expected on Linux and OSX.
(minor nit-pick: could use sys.platform.startswith('win') instead of slicing)
--
nosy: +taleinat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4832
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5817] Right-click behavior from Windows Explorer
Tal Einat talei...@gmail.com added the comment: I'm quite sure that issue has already been addressed. Specifically r71126 made it so that running IDLE with -e always opens just an editor window. Edit with IDLE runs IDLE with -e. With which version of Python do you see this happening, Michael? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5817 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6698] IDLE no longer opens only an edit window when configured to do so
Tal Einat talei...@gmail.com added the comment: I agree on this. Unfortunately that change in r71126 wasn't commented on or documented in any way. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6698 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Tal Einat talei...@gmail.com added the comment: Because of the method of implementation, a dialog can be created without specifying a parent. There was at least one instance of this in IDLE before my patch. This is a bug, since the behavior of the dialog in this instance is obviously incorrect (the user can switch focus back to the parent while the dialog is still open). I found that making the EditorWindow the default parent was the best way to both fix the bug, make the code more readable, and avoid replicating this bug in the future. Feel free to write up a different patch or change mine if you feel so strongly about the default parent. The process of discussing this patch has taken far, far too long. I can't stand such discussions spanning months (and years!). Please just accept this patch or close it. I'm fed up with this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Tal Einat talei...@gmail.com added the comment: At this point I would prefer that this patch just be rejected rather than continue discussing it. I can understand IDLE being a low priority, but someone could have just stated that to begin with and I wouldn't have bothered working for hours to work up a patch and discuss its merits. Guilherme, I appreciate your taking an interest in this and obviously you have only helped move this forward. My frustration is with the devs allowing me to waste hours of my time, while requesting that I spend even more time testing and consolidating patches before submission, and then proceeding to ignore my work completely. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9016] IDLE won't launch (Win XP)
Tal Einat talei...@users.sourceforge.net added the comment: Let's focus on the problem you're having with Python 2.6, with which you said IDLE won't launch. Please try to run IDLE using Python 2.6.5: 1) Install Python 2.6.5, say to C:\Python26 2) Rename/move your .idlerc directory so there isn't any such directory under C:\Documents and Settings\username 3) Then go to that directory and run: C:\Python26 .\python.exe Lib\idlelib\idle.py Post the output of that here, so that we can help diagnose the problem. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9016 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9016] IDLE won't launch (Win XP)
Tal Einat talei...@users.sourceforge.net added the comment: Also, try renaming/moving the directory C:\Documents and Settings\username\.idlerc, and then try to start IDLE. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9016 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue459007] Document sys.path on Windows
Tal Einat talei...@users.sourceforge.net added the comment: Wow, this has been on hold for ages! I know I could have used this information in the past, and several people have asked me about this. Perhaps there should be a place in the documentations which explains how sys.path is populated, with detailed explanations for different platforms? With some guidance as per the right place in the docs for this, I'll gladly work on this. Note that I'm not an expert on this issue, I just plan to gather information form several places and write up a single nice documentation page. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue459007 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8904] quick example how to fix docs
Tal Einat talei...@users.sourceforge.net added the comment: Apparently so. Those instructions are thorough and to the point, just what I was looking for. Adding a mention of this somewhere obvious, such as the links I mentioned earlier, would be very helpful (this would have save me 30 minutes of futile searching). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8904 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8820] IDLE not launching correctly
Tal Einat talei...@users.sourceforge.net added the comment: Joseph, please mention which version of Python you are trying this with. If 2.6.4, please try with 2.6.5 to see if it still happens. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8820 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8515] idle Run Module (F5) does not set __file__ variable
Tal Einat talei...@users.sourceforge.net added the comment: Why doesn't execfile() set __file__? I would be surprised if this is due to an oversight by the Python devs. In both execfile and IDLE's Run Module I can't think of a reason not to set __file__, but perhaps this was intentional? Googling a bit hasn't brought up much. I am currently of the opinion that both IDLE and execfile() should set __file__ (with execfile() perhaps requiring more thinking about edge-cases, since it can be passes locals and globals dictionaries). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8515 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8904] quick example how to fix docs
Tal Einat talei...@users.sourceforge.net added the comment: AFAIK submitting patches in general is covered well enough in several places. What I'm missing specifically regarding patches for documentation is instructions on how to preview them before submitting them. Editing reST is easy, but making sure you've done it correctly without knowing how to run it through Sphinx is impossible. I spent quite some time and couldn't figure this one out, and ended up submitting a doc patch without previewing it. To be specific, http://www.python.org/dev/contributing/ points to http://docs.python.org/dev/documenting/index.html which has quite a bit of information on reST but no information on Sphinx, despite the main page clearly stating: This document describes the style guide for our documentation, the custom reStructuredText markup introduced to support Python documentation and how it should be used, as well as the Sphinx build system. Finally, a simple how-to with concrete, technical steps on how to write, preview and submit a doc patch would really help, especially for those who have never before submitted a patch. A simple video example (e.g. on ShowMeDo) would be fantastic, but even just updated detailed textual instructions would be a great step forward. -- nosy: +taleinat status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8904 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8641] IDLE 3 doesn't highlights b, but u
Tal Einat talei...@users.sourceforge.net added the comment: Attaching patch against current py3k branch. I simply replaced the occurrences of [rRuU] in the relevant regexps to [rRbB]. -- keywords: +patch nosy: +taleinat Added file: http://bugs.python.org/file17568/IDLE_py3k_string_highlighting.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8641 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7166] IDLE (python 3.1.1) syntax coloring for b'bytestring' and u'unicode' string literal
Changes by Tal Einat talei...@users.sourceforge.net: -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7166 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4785] json.JSONDecoder() strict argument undocumented and potentially confusing
Tal Einat talei...@users.sourceforge.net added the comment: Documentation patch attached against py3k branch. Changes are: * Added to documentation of JSONDecoder: If *strict* is ``False`` (``True`` is the default), then control characters will be allowed inside strings. Control characters in this context are those with character codes in the 0-31 range, including ``'\t'`` (tab), ``'\n'``, ``'\r'`` and ``'\0'``. * Added clarification in documentation of json.load and json.dump that unless the cls kwarg is specified, the JSONEncoder/JSONDecoder class will be used. * Mirrored these additions in the relevant doc-strings (JSONDecoder.__init__, json.load, json.loads, json.dump, json.dumps). * Copied description of the object_pairs_hook kwargs from the documentation to the relevant doc-strings, which otherwise fully mirrored the documentation. (json.load, json.loads, JSONDecoder.__init__) -- keywords: +patch versions: +Python 3.2 -Python 2.6, Python 3.0 Added file: http://bugs.python.org/file17560/json_docs_py3k.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4785 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4785] json.JSONDecoder() strict argument undocumented and potentially confusing
Tal Einat talei...@users.sourceforge.net added the comment: Similar patch against trunk; same changes as for the py3k branch. -- Added file: http://bugs.python.org/file17561/json_docs_trunk.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4785 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4785] json.JSONDecoder() strict argument undocumented and potentially confusing
Changes by Tal Einat talei...@users.sourceforge.net: -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4785 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8900] IDLE crashes if Preference set to At Startup - Open Edit Window
Tal Einat talei...@users.sourceforge.net added the comment: I can consistently reproduce this with Python 3.0.1 by setting IDLE to start in editing mode and using Ctrl+o to open the Open dialog. Doesn't happen when using the menu item in the File menu. This leads me to believe it has something to do with keypress event processing. Also, the event for which the unbind call is failing is Control-KeyPress-slash. Continuing to investigate. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8900 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4785] json.JSONDecoder() strict argument undocumented and potentially confusing
Tal Einat talei...@users.sourceforge.net added the comment: This goes down into _json.scanstring. Looking at the C code for scanstring_unicode, the strict parameter allow control characters inside strings: if strict is zero then literal control characters are allowed. From the code itself (current py3k head, r81032), it seems this means any character = 0x1f. See scanstring_unicode in http://svn.python.org/view/python/branches/py3k/Modules/_json.c?revision=81032view=markup for details. Documentation should be updated accordingly. -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4785 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4785] json.JSONDecoder() strict argument undocumented and potentially confusing
Tal Einat talei...@users.sourceforge.net added the comment: This goes down into _json.scanstring. Looking at the C code for scanstring_unicode, strict=False allows control characters inside strings: if strict is zero then literal control characters are allowed. From the code itself (current py3k head, r81032), it seems this means any character = 0x1f. See scanstring_unicode in http://svn.python.org/view/python/branches/py3k/Modules/_json.c?revision=81032view=markup for details. Documentation should be updated accordingly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4785 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1766304] improve xrange.__contains__
Tal Einat talei...@users.sourceforge.net added the comment: In my mind, the reason for this patch is that xrange/range can be thought of as a lazy list of integers. However without this patch, membership checking was done trivially instead of in a smart/lazy manner, which is unexpected for users. Finally, conditions such as num in xrange(3, 1000, 5) are not trivial to express correctly otherwise, and even more so for negative steps. This patch is already implemented and accepted for 3.2, I just wish to back-port it to 2.7 which should be fairly straightforward. I'll just have a patch ready by tomorrow, and hope that someone finds the time to review it and possibly commit it in time for rc1. I realize that this is a minor change at the last minute. I will certainly understand if the people responsible for preparing rc1 are too busy for this. -- versions: +Python 2.7 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1766304 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1766304] improve xrange.__contains__
Tal Einat talei...@users.sourceforge.net added the comment: I'd like to implement this for 2.x, if there's any chance of this being accepted. Is there still a chance of getting this into 2.7? This will be my first patch for the Python core, so please tell me if I'm missing something. Currently I'm thinking of: 1. starting with the original patch 2. applying the required changes as mentioned Mark Dickinson, looking at the the accepted 3.x patch for guidance 3. back-porting the tests 4. checking for later additional changes in the source history, and back-porting any such relevant changes -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1766304 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1766304] improve xrange.__contains__
Tal Einat talei...@users.sourceforge.net added the comment: I'd really like to have this in 2.7. Is there no chance of getting it into 2.7 after rc1 is released? If so, I can have the patch ready by Friday 14:00 GMT, but if nobody will have time to review (and possibly commit) in time for RC1 I guess I'll take my time with this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1766304 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Tal Einat talei...@users.sourceforge.net added the comment: The whole point of this patch is to make the EditorWindow's Text widget the default master/parent for its dialogs! IMO this makes sense, since this is a reasonable and intuitive default for such methods of the EditorWindow object. I understand the explicit is better than implicit argument, but that doesn't mean that having a reasonable default value is always wrong. In this case having a default value both simplifies the code considerably and makes sense, so IMO it is justified. Also, please note that the patch actually reduces the size of EditorWindow.py (both character and line counts) and cleans up the code in many places. Yes, the definition of the relevant methods is not trivial, but it is in just one area of the code. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6143] IDLE - an extension to clear the shell window
Tal Einat talei...@users.sourceforge.net added the comment: First of all I think that the Squeezer (issue #1529353) extension is more useful and solves most of the problems that this proposed feature is set to solve, e.g. issue #1442493. IMO the second method you offer - temporarily moving iomark - is preferable. One reason is that it will allow using the undo feature to undo deleting the entire shell history. I think this is important since deleting the history by accident without a way to retrieve it would be very annoying. I propose going with the clear_window2 method, wrapping it with undo_block_start() and undo_block_stop(). -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6143 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1529353] Squeezer - squeeze large output in the interpreter
Tal Einat talei...@users.sourceforge.net added the comment: Test needed? I'll need a bit of guidance on this. Has there been a change of policy of which I'm not aware, that patches to IDLE not going to be accepted unless comprehensive tests are included? Much of IDLE doesn't include tests, e.g. the RPC code. There's a comment by K.B.K. in the end of rpc.py from September '03 saying we need a proper test suite for it, and testing that should be simple compared to testing GUI related functionality. In any case, if someone can suggest a simple approach to test Squeezer I'll gladly work it up. As it is, I can think of ways to test certain functions, but I'm not sure how to approach testing GUI related functionality (or if I should approach this at all). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1529353] Squeezer - squeeze large output in the interpreter
Tal Einat talei...@users.sourceforge.net added the comment: Daniel, Thanks for clearing that up :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1757057] IDLE + BeautifulSoup = Error
Tal Einat talei...@users.sourceforge.net added the comment:
To recreate use BeautifulSoup 3.0.4 and run the following:
from BeautifulSoup import BeautifulSoup
soup = BeautifulSoup(htmlaa/html)
x = soup.find('html').contents[0]
x
u'aa'
print x
Traceback (most recent call last):
File pyshell#4, line 1, in module
print x
RuntimeError: maximum recursion depth exceeded
This is caused by a bug in BeautifulSoup which was fixed in version
3.0.5. The bug manifests when trying to pickle an instance of the
NavigableString class.
In the above scenario, IDLE has the subprocess pickle the object and
send it to the parent process. Since the problem is with the pickling,
turning the object into a string in the subprocess (instead of sending
it as-is to the parent process) avoids generating the error:
print str(x)
aa
print repr(x)
u'aa'
To verify that pickle is the culprit:
import pickle
pickle.dumps(x)
(very long traceback...)
RuntimeError: maximum recursion depth exceeded
Like I said in my first post, IMO IDLE should check for any exception
(not just pickle.PicklingError) when trying to pickle an object for
sending to the parent process. If pickle doesn't work, for whatever
reason, IDLE can still try to work around it with str() and/or repr().
(I tried this with Python 2.5 but I've tested this in the past with 2.6
as well. I haven't tried it with 3.0 or 2.7 yet.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1757057
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1757057] IDLE + BeautifulSoup = Error
Tal Einat talei...@users.sourceforge.net added the comment: Sending a code object back to the parent process and having it deal with the situation sounds very unpleasant indeed! I think a completely different type of solution may be possible. In general, I can't think of any reason for IDLE to pickle user objects from the subprocess and send them to the parent process; it should merely send back the output (as strings), with special cases for exceptions and such. By user objects I mean objects inside the interpreter, as opposed to those used by IDLE itself. I'll have to unwind the spaghetti in rpc.py, run.py and PyShell.py a bit more to propose a specific set of changes; I hope to get to that tomorrow. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1757057 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1201569] allow running multiple instances of IDLE
Tal Einat talei...@users.sourceforge.net added the comment: This should be dropped in favor of issue #1529142, which proposes a simpler and better solution. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1201569 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1529142] Allowing multiple instances of IDLE with sub-processes
Tal Einat [EMAIL PROTECTED] added the comment: First of all, the multiprocessing module doesn't work fully in an interactive shell. From the Python2.6 docs: Note Functionality within this package requires that the __main__ method be importable by the children. This is covered in Programming guidelines however it is worth pointing out here. This means that some examples, such as the multiprocessing.Pool examples will not work in the interactive interpreter. And later on that same page (under Programming Guidelines - Windows): Make sure that the main module can be safely imported by a new Python interpreter without causing unintended side effects (such a starting a new process). This is probably why IDLE is acting up for you. I would be surprised if using the multiprocessing module will work well in IDLE either with or without a sub-process. As per the patch, someone should just work up an updated one with all of the insight gained in the last several years (!) regarding this. It should just do two things: 1) remove the use of the SO_REUSEADDR flag in the sub-process spawning code -- see http://bugs.python.org/issue1201569 2) pass zero as the argument for the port number, which instructs the underlying socket library to select an available port, and later retrieve the selected port from the socket object -- see http://mail.python.org/pipermail/idle-dev/2008-June/002687.html The other changes in my original patch, while they do work, are unnecessarily complex and make it much harder to get the patch accepted. They should also not be significant if the spawning delays are fixed. If you'd like to work up such a patch and get it reviewed and committed, please be my guest! I will help you in any way I can if you take this up. Otherwise I guess it will wait until I find the time and energy... ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1529142 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Tal Einat [EMAIL PROTECTED] added the comment: Attaching a new patch against a more recent revision (resolved minor conflict). Only 3 extremely minor changes from previous patch: fixed two more places where the parent was being passed explicitly (no longer required) and changed two tabs - spaces. I've done some fairly thorough manual testing of this, and have been using it without any issues for almost six months. Added file: http://bugs.python.org/file12161/IDLE_standardize_dialogs.081129.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3640] test_cpickle crash on AMD64 Windows build
Tal Einat [EMAIL PROTECTED] added the comment: Will this be back-ported to 2.5.3? (please say yes...) -- nosy: +taleinat ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3640 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1529018] Move firewall warning to about menu
Tal Einat [EMAIL PROTECTED] added the comment: What if this message was made part of the error message which is displayed when the connection to the subprocess fails? This way only users in situations where it is likely that the warning is relevant will see it. I suggest this since the original problem for which the warning was added has become very uncommon, so bugging all of our users with such a warning (even if it has a don't show this again check-box) seems unnecessary. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1529018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3344] IDLE - use enumerate instead of zip(count(), ...)
New submission from Tal Einat [EMAIL PROTECTED]: Just minor code cleanup. Only one instance of zip(count(), ...) in EditorWindow.py, where I also changed 'file' to 'file_name' to avoid overriding the built-in 'file' class. -- files: IDLE_EditorWindow_minor.patch keywords: patch messages: 69571 nosy: kbk, taleinat severity: normal status: open title: IDLE - use enumerate instead of zip(count(), ...) Added file: http://bugs.python.org/file10878/IDLE_EditorWindow_minor.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3344 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3068] IDLE - Add an extension configuration dialog
New submission from Tal Einat [EMAIL PROTECTED]: Attaching a patch for a straightforward extension config dialog, largely based on configDialog.py. This uses the multiple-tab-rows feature of the TabbedPageSet widget from the tabbedPages module, as well as the included VerticalScrolledFrame widget. Other than that there's nothing really new here. -- components: IDLE files: IDLE_configExtensionsDialog.080609.patch keywords: patch messages: 67872 nosy: kbk, taleinat severity: normal status: open title: IDLE - Add an extension configuration dialog type: behavior versions: Python 2.6 Added file: http://bugs.python.org/file10560/IDLE_configExtensionsDialog.080609.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3068 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3068] IDLE - Add an extension configuration dialog
Changes by Tal Einat [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file10560/IDLE_configExtensionsDialog.080609.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3068 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3068] IDLE - Add an extension configuration dialog
Tal Einat [EMAIL PROTECTED] added the comment: I forgot to mention: This patch also removes the paragraph width option from the General tab in the normal IDLE config, since that configures a parameter of the FormatParagraph extension, which can now be done in the extension config dialog. Added file: http://bugs.python.org/file10561/IDLE_configExtensionsDialog.080609.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3068 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1350] IDLE - CallTips enhancement - show full doc-string in new window
Changes by Tal Einat [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file8641/IDLE_CallTips.071028.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1350] IDLE - CallTips enhancement - show full doc-string in new window
Changes by Tal Einat [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file8960/IDLE_CallTips.071214.incremental.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1350 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Tal Einat [EMAIL PROTECTED] added the comment: After more testing, I discovered a bug which broke Goto Line. Attaching a fixed patch. Added file: http://bugs.python.org/file10555/IDLE_standardize_dialogs.080609.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Changes by Tal Einat [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file10555/IDLE_standardize_dialogs.080609.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Tal Einat [EMAIL PROTECTED] added the comment: uploaded a single comprehensive patch file Added file: http://bugs.python.org/file10140/IDLE_standardize_dialogs.080429.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1529142] Allowing multiple instances of IDLE with sub-processes
Tal Einat [EMAIL PROTECTED] added the comment: Thanks for taking the time to review this patch, Guilherme. For the record, on which OS+Python have you tested this? _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1529142 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1529142] Allowing multiple instances of IDLE with sub-processes
Tal Einat [EMAIL PROTECTED] added the comment: I really, really wish we could get this in for Python2.6 - this issue is a major drawback for beginners, for whom IDLE is mostly intended. Perhaps not this specific patch; I am willing to work on cleaning up the code and getting it tested by users on different platforms. Is there any chance of this happening? What can I do to get this moving again? _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1529142 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2061] IDLE - autocompletion to support alternate path separators
Tal Einat added the comment: Umm, that's me being silly and forgetting to remove some backwards compatibility stuff. Revised (simpler) version attached. Added file: http://bugs.python.org/file9439/IDLE_AutoComplete_path_separators.080216.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2061 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2062] IDLE - autocompletion logic optimization
Tal Einat added the comment: After fixing the aforementioned bug and testing as thoroughly as I can, here is a revised patch. Added file: http://bugs.python.org/file9426/IDLE_AutoComplete_complete_string_optimization.080214.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2062 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2049] IDLE - Restart Shell Run Module
Tal Einat added the comment: First of all, installing Python on Windows creates a 'Edit with IDLE' context-menu item whenever you right-click a .py file, which opens IDLE without a subprocess. The reason for this is that there is still a problem regarding having several instances of IDLE, each with a subprocess, open in parallel on Windows. The result is that many users on Windows are often running IDLE without a subprocess; we can't treat it as an 'expert' mode. IMHO if you really feel strongly about this, then the Windows issue must be resolved, and the 'Edit with IDLE' context-menu item should run IDLE with a subprocess. I understand your point that having the shell be restarted every time helps teach good programming practices. But IDLE is used not only as a learning environment; it's also a great Python shell for other purposes, such as testing debugging or scientific uses. I agree that these are more advanced uses, so perhaps restarting the shell could be the default, and the option to not have it restarted available when needed. Thinking about it, I like the idea of an extension which is disabled by default. I'll think about it some more, and then perhaps implement it. Just a thought: It would be important to mention such an extension in a prominent place in the documentation. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2049 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2062] IDLE - autocompletion logic optimization
Tal Einat added the comment: Well, I admit, I haven't tested this enough. Specifically, there is a bug in this patch (both versions); please delete it. I accept your criticism of my latest patches, they truly are of inferior quality. I deeply apologize for having taken up more of your time than I should have. Allow me to explain my situation: I work with a highly modified version of IDLE to which I have added many features, and which is also used daily by ~10 friends and colleagues. Many of these patches are my attempt to contribute the more mature and successful changes/features back to CPython. However, the completion code differs greatly from the CPython version, making porting changes a large effort, requiring me to re-implement many things, as well as go once more through the process of testing and debugging. This is really a great deal of work and I have been eager to contribute some of the better features. While I have tried to be methodical, thorough and test everything, I seem to still have been too hasty. I must tell you that I spent many hours preparing the last few patches, but I realize that doing half a job is worse than not doing it at all. In the future I will test every change much more thoroughly before posting it as a patch. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2062 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2049] IDLE - Restart Shell Run Module
Tal Einat added the comment: I agree that the interface should be kept as simple as possible, but this is a meaningful and important addition, which will help clarify to the users how to work with the subprocess. The point of this change is avoid surprising the user, while also making the interface more straightforward and consistent. The major usage issues that this patch addresses, as I see them, are: 1. New users are surprised and aggravated when they first use 'Run Module', because they weren't expecting the shell to be restarted, causing them to lose a lot of work done before the restart. This also happens to experienced users sometimes (accidents happen) and can be very frustrating. I don't think the 'normal state' should be to restart the shell, rather this should always be explicitly requested by the user. 2. When working with a subprocess, there is no (simple) way to just run the module in the shell without restarting it. 3. Inconsistency in the functionality of 'Run Module' depending on whether you have a subprocess. The problem with the configuration option approach is that if you configure 'Run Module' to not restart, then restarting requires: switching to the Shell window, restarting, switching back to the editor window, and running the module: 4 actions instead of one. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2049 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2061] IDLE - autocompletion to support alternate patch separators
New submission from Tal Einat: This patch makes the auto-completion of file names support possible alternate separator characters (e.g. '/' in windows). -- components: IDLE files: IDLE_AutoComplete_path_separators.080211.patch messages: 62263 nosy: kbk, taleinat severity: minor status: open title: IDLE - autocompletion to support alternate patch separators type: rfe versions: Python 2.6 Added file: http://bugs.python.org/file9400/IDLE_AutoComplete_path_separators.080211.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2061 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2062] IDLE - autocompletion logic optimization
New submission from Tal Einat: Improve the code in AutoCompleteWindow._complete_string to be more efficient. (this is to be followed up by a more extensive patch, which builds on this change to support case-insensitive completion) -- components: IDLE files: IDLE_AutoComplete_complete_string_optimization.080211.patch messages: 62265 nosy: kbk, taleinat severity: minor status: open title: IDLE - autocompletion logic optimization type: behavior versions: Python 2.6 Added file: http://bugs.python.org/file9402/IDLE_AutoComplete_complete_string_optimization.080211.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2062 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
