Re: [RFC] block/mirror: fix file-system went to read-only after block-mirror

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210624120635.54573-1-caojinh...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210624120635.54573-1-caojinh...@huawei.com
Subject: [RFC] block/mirror: fix file-system went to read-only after 
block-mirror

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210624120635.54573-1-caojinh...@huawei.com -> 
patchew/20210624120635.54573-1-caojinh...@huawei.com
Switched to a new branch 'test'
6e2ba54 block/mirror: fix file-system went to read-only after block-mirror

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 19 lines checked

Commit 6e2ba547f042 (block/mirror: fix file-system went to read-only after 
block-mirror) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210624120635.54573-1-caojinh...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] block/rbd: Add support for rbd image encryption

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210621142103.1417408-1-...@il.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210621142103.1417408-1-...@il.ibm.com
Subject: [PATCH] block/rbd: Add support for rbd image encryption

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  
patchew/20210614083800.1166166-1-richard.hender...@linaro.org -> 
patchew/20210614083800.1166166-1-richard.hender...@linaro.org
 * [new tag] patchew/20210621142103.1417408-1-...@il.ibm.com -> 
patchew/20210621142103.1417408-1-...@il.ibm.com
Switched to a new branch 'test'
19faaee block/rbd: Add support for rbd image encryption

=== OUTPUT BEGIN ===
ERROR: "(foo**)" should be "(foo **)"
#60: FILE: block/rbd.c:374:
+luks_opts->key_secret, (uint8_t**)passphrase, passphrase_len, 
errp);

total: 1 errors, 0 warnings, 601 lines checked

Commit 19faaee12b6d (block/rbd: Add support for rbd image encryption) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210621142103.1417408-1-...@il.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210511073511.32511-1-h...@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210511073511.32511-1-h...@suse.de
Subject: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   e58c7a3..e4f3ede  master -> master
 * [new tag] patchew/20210511073511.32511-1-h...@suse.de -> 
patchew/20210511073511.32511-1-h...@suse.de
Switched to a new branch 'test'
1d24622 hw/block/nvme: re-enable NVMe PCI hotplug

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#101: FILE: hw/block/nvme-subsys.c:50:
+if (!n->subsys)
[...]

total: 1 errors, 0 warnings, 182 lines checked

Commit 1d24622c5d19 (hw/block/nvme: re-enable NVMe PCI hotplug) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210511073511.32511-1-h...@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v5 00/11] 64bit block-layer: part II

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210505075001.45041-1-vsement...@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210505075001.45041-1-vsement...@virtuozzo.com
Subject: [PATCH v5 00/11] 64bit block-layer: part II

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20210505045824.33880-1-liq...@163.com -> 
patchew/20210505045824.33880-1-liq...@163.com
 * [new tag] patchew/20210505075001.45041-1-vsement...@virtuozzo.com -> 
patchew/20210505075001.45041-1-vsement...@virtuozzo.com
Switched to a new branch 'test'
3700aaf block/io: allow 64bit discard requests
54ba548 block: use int64_t instead of int in driver discard handlers
7a3aaa5 block: make BlockLimits::max_pdiscard 64bit
f80faf7 block/io: allow 64bit write-zeroes requests
4cc3310 block: use int64_t instead of int in driver write_zeroes handlers
136dd63 block: make BlockLimits::max_pwrite_zeroes 64bit
03a7c45 block: use int64_t instead of uint64_t in copy_range driver handlers
496fe8b block: use int64_t instead of uint64_t in driver write handlers
eefb31d block: use int64_t instead of uint64_t in driver read handlers
fb7a119 qcow2: check request on vmstate save/load path
23ba0f4 block/io: bring request check to bdrv_co_(read, write)v_vmstate

=== OUTPUT BEGIN ===
1/11 Checking commit 23ba0f4a09c1 (block/io: bring request check to 
bdrv_co_(read, write)v_vmstate)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via 

total: 1 errors, 0 warnings, 42 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/11 Checking commit fb7a119cd9aa (qcow2: check request on vmstate save/load 
path)
3/11 Checking commit eefb31d480b4 (block: use int64_t instead of uint64_t in 
driver read handlers)
4/11 Checking commit 496fe8b2e7ce (block: use int64_t instead of uint64_t in 
driver write handlers)
5/11 Checking commit 03a7c4534a58 (block: use int64_t instead of uint64_t in 
copy_range driver handlers)
6/11 Checking commit 136dd63cc723 (block: make BlockLimits::max_pwrite_zeroes 
64bit)
7/11 Checking commit 4cc3310d243e (block: use int64_t instead of int in driver 
write_zeroes handlers)
8/11 Checking commit f80faf73a84a (block/io: allow 64bit write-zeroes requests)
9/11 Checking commit 7a3aaa587314 (block: make BlockLimits::max_pdiscard 64bit)
10/11 Checking commit 54ba54860b4a (block: use int64_t instead of int in driver 
discard handlers)
11/11 Checking commit 3700aafec1ff (block/io: allow 64bit discard requests)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210505075001.45041-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] block/rbd: Add support for rbd image encryption

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210502073617.2978836-1-...@il.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210502073617.2978836-1-...@il.ibm.com
Subject: [PATCH] block/rbd: Add support for rbd image encryption

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   8f860d2..53c5433  master -> master
 * [new tag] patchew/20210502073617.2978836-1-...@il.ibm.com -> 
patchew/20210502073617.2978836-1-...@il.ibm.com
Switched to a new branch 'test'
11af1d7 block/rbd: Add support for rbd image encryption

=== OUTPUT BEGIN ===
ERROR: "foo** bar" should be "foo **bar"
#51: FILE: block/rbd.c:355:
+char** passphrase,

ERROR: "foo* bar" should be "foo *bar"
#94: FILE: block/rbd.c:398:
+  RbdEncryptionSpec* spec,

total: 2 errors, 0 warnings, 385 lines checked

Commit 11af1d704fbe (block/rbd: Add support for rbd image encryption) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210502073617.2978836-1-...@il.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v4 00/36] block: update graph permissions update

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210428151804.439460-1-vsement...@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210428151804.439460-1-vsement...@virtuozzo.com
Subject: [PATCH v4 00/36] block: update graph permissions update

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20210428141655.387430-1-f4...@amsat.org -> 
patchew/20210428141655.387430-1-f4...@amsat.org
 * [new tag] patchew/20210428151804.439460-1-vsement...@virtuozzo.com 
-> patchew/20210428151804.439460-1-vsement...@virtuozzo.com
Switched to a new branch 'test'
a0ef51a block: refactor bdrv_node_check_perm()
7429fe1 block: rename bdrv_replace_child_safe() to bdrv_replace_child()
370a34f block: refactor bdrv_child_set_perm_safe() transaction action
d1a11c5 block: inline bdrv_replace_child()
ab4725c block: inline bdrv_check_perm_common()
1e87dc2 block: drop unused permission update functions
7f7c03c block: bdrv_reopen_multiple: refresh permissions on updated graph
dae8ccf block: bdrv_reopen_multiple(): move bdrv_flush to separate pre-prepare
3882433 block: add bdrv_set_backing_noperm() transaction action
4dbfab2 block: make bdrv_refresh_limits() to be a transaction action
0cf05c0 block: make bdrv_unset_inherits_from to be a transaction action
1268c27 block: drop ignore_children for permission update functions
3b2ce34 block/backup-top: drop .active
f8d8895 block: introduce bdrv_drop_filter()
5bf1218 block: add bdrv_remove_filter_or_cow transaction action
00b761a block: adapt bdrv_append() for inserting filters
dd27bfe block: split out bdrv_replace_node_noperm()
2b2d8e4 block: add bdrv_attach_child_noperm() transaction action
3c44761 block: add bdrv_attach_child_common() transaction action
3f07f35 block: fix bdrv_replace_node_common
e2a0ea6 block: add bdrv_replace_child_safe() transaction action
92f4628 block: add bdrv_list_* permission update functions
84a955c block: add bdrv_drv_set_perm transaction action
769127d block: use topological sort for permission update
1a3293c block: inline bdrv_child_*() permission functions calls
0eafad8 block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms()
02b7d94 block: refactor bdrv_child* permission functions
081d242 block: bdrv_refresh_perms: check for parents permissions conflict
e7d5541 util: add transactions.c
a5835ab block: make bdrv_reopen_{prepare, commit, abort} private
eebe328 block: drop ctx argument from bdrv_root_attach_child
6bfb813 block: BdrvChildClass: add .get_parent_aio_context handler
faf9f5a block: bdrv_append(): don't consume reference
09a714e tests/test-bdrv-graph-mod: add test_append_greedy_filter
a2e5008 tests/test-bdrv-graph-mod: add test_parallel_perm_update
7e9a7a4 tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

=== OUTPUT BEGIN ===
1/36 Checking commit 7e9a7a4d740a (tests/test-bdrv-graph-mod: add 
test_parallel_exclusive_write)
2/36 Checking commit a2e500832942 (tests/test-bdrv-graph-mod: add 
test_parallel_perm_update)
3/36 Checking commit 09a714e2f77d (tests/test-bdrv-graph-mod: add 
test_append_greedy_filter)
4/36 Checking commit faf9f5a35e07 (block: bdrv_append(): don't consume 
reference)
5/36 Checking commit 6bfb813f671d (block: BdrvChildClass: add 
.get_parent_aio_context handler)
6/36 Checking commit eebe328485c7 (block: drop ctx argument from 
bdrv_root_attach_child)
7/36 Checking commit a5835ab099b6 (block: make bdrv_reopen_{prepare, commit, 
abort} private)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via 

total: 1 errors, 0 warnings, 47 lines checked

Patch 7/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/36 Checking commit e7d55412e1a6 (util: add transactions.c)
9/36 Checking commit 081d242cc6c7 (block: bdrv_refresh_perms: check for parents 
permissions conflict)
10/36 Checking commit 02b7d94ba496 (block: refactor bdrv_child* permission 
functions)
11/36 Checking commit 0eafad8a0bdb (block: rewrite bdrv_child_try_set_perm() 
using bdrv_refresh_perms())
12/36 Checking commit 1a3293c8af87 (block: inline bdrv_child_*() permission 
functions calls)
13/36 Checking commit 769127da032f (block: use topological sort for permission 
update)
14/36 Checking commit 84a955ce7cdd (block: add bdrv_drv_set_perm transaction 
action)
15/36 Checking commit 92f46287bd3e (block: add bdrv_list_* permission update 
functions)
16/36 Checking commit e2a0ea66e2c7 (block: add bdrv_replace_child_safe() 
transaction action)
17/36 Checking commit 3f07f3545be4 (block: fix 

Re: [PATCH 0/3] file-posix: fix refresh_limits for SCSI devices

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210415124307.428203-1-pbonz...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210415124307.428203-1-pbonz...@redhat.com
Subject: [PATCH 0/3] file-posix: fix refresh_limits for SCSI devices

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210415124307.428203-1-pbonz...@redhat.com -> 
patchew/20210415124307.428203-1-pbonz...@redhat.com
Switched to a new branch 'test'
37feb25 file-posix: fix max_iov for /dev/sg devices
eec0521 file-posix: try BLKSECTGET on block devices too, do not round to power 
of 2
c44bc38 scsi-generic: pass max_segments via max_iov field in BlockLimits

=== OUTPUT BEGIN ===
1/3 Checking commit c44bc386ba20 (scsi-generic: pass max_segments via max_iov 
field in BlockLimits)
WARNING: line over 80 characters
#51: FILE: hw/scsi/scsi-generic.c:186:
+max_transfer = MIN_NON_ZERO(max_transfer, max_iov * 
qemu_real_host_page_size)

total: 0 errors, 1 warnings, 23 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit eec052142154 (file-posix: try BLKSECTGET on block devices 
too, do not round to power of 2)
3/3 Checking commit 37feb259bbc4 (file-posix: fix max_iov for /dev/sg devices)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 17 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210415124307.428203-1-pbonz...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2] hw/block/nvme: add device self test command support

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210331083306.12461-1-anaidu.go...@samsung.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210331083306.12461-1-anaidu.go...@samsung.com
Subject: [PATCH v2] hw/block/nvme: add device self test command support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210331083306.12461-1-anaidu.go...@samsung.com -> 
patchew/20210331083306.12461-1-anaidu.go...@samsung.com
Switched to a new branch 'test'
018f869 hw/block/nvme: add device self test command support

=== OUTPUT BEGIN ===
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#337: 
new file mode 100644

ERROR: trailing whitespace
#369: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:28:
+ $

ERROR: trailing whitespace
#374: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:33:
+ $

ERROR: trailing whitespace
#418: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:77:
+ $

ERROR: trailing whitespace
#512: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:171:
+ $

ERROR: trailing whitespace
#515: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:174:
+ $

ERROR: trailing whitespace
#522: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:181:
+ $

ERROR: trailing whitespace
#535: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:194:
+ $

ERROR: trailing whitespace
#544: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:203:
+ $

ERROR: trailing whitespace
#566: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:225:
+ $

ERROR: trailing whitespace
#602: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:261:
+ $

ERROR: trailing whitespace
#657: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:316:
+ $

ERROR: trailing whitespace
#665: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:324:
+ $

ERROR: trailing whitespace
#674: FILE: 
outgoing/0001-hw-block-nvme-add-device-self-test-command-support.patch:333:
+-- $

total: 13 errors, 1 warnings, 617 lines checked

Commit 018f869ec2d4 (hw/block/nvme: add device self test command support) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210331083306.12461-1-anaidu.go...@samsung.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] hw/block/nvme: add device self test command support

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210331073233.11198-1-anaidu.go...@samsung.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210331073233.11198-1-anaidu.go...@samsung.com
Subject: [PATCH] hw/block/nvme: add device self test command support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210331073233.11198-1-anaidu.go...@samsung.com -> 
patchew/20210331073233.11198-1-anaidu.go...@samsung.com
Switched to a new branch 'test'
d2f401d hw/block/nvme: add device self test command support

=== OUTPUT BEGIN ===
ERROR: named QTAILQ_HEAD should be typedefed separately
#210: FILE: hw/block/nvme.h:165:
+QTAILQ_HEAD(dst_list, NvmeDstEntry)  dst_list;

total: 1 errors, 0 warnings, 282 lines checked

Commit d2f401dadafe (hw/block/nvme: add device self test command support) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210331073233.11198-1-anaidu.go...@samsung.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v4 00/11] 64bit block-layer: part II

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210324205132.464899-1-vsement...@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210324205132.464899-1-vsement...@virtuozzo.com
Subject: [PATCH v4 00/11] 64bit block-layer: part II

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20210323221539.3532660-1-cr...@redhat.com -> 
patchew/20210323221539.3532660-1-cr...@redhat.com
 * [new tag] patchew/20210324205132.464899-1-vsement...@virtuozzo.com 
-> patchew/20210324205132.464899-1-vsement...@virtuozzo.com
Switched to a new branch 'test'
bed608a block/io: allow 64bit discard requests
9b3b5c7 block: use int64_t instead of int in driver discard handlers
9d5776f block: make BlockLimits::max_pdiscard 64bit
1dc4bab block/io: allow 64bit write-zeroes requests
05ca540 block: use int64_t instead of int in driver write_zeroes handlers
5864b0d block: make BlockLimits::max_pwrite_zeroes 64bit
9698c13 block: use int64_t instead of uint64_t in copy_range driver handlers
4e60566 block: use int64_t instead of uint64_t in driver write handlers
8aa3af1 block: use int64_t instead of uint64_t in driver read handlers
fc695f9 qcow2: check request on vmstate save/load path
a13a9ef block/io: bring request check to bdrv_co_{read, write}v_vmstate

=== OUTPUT BEGIN ===
1/11 Checking commit a13a9efd128c (block/io: bring request check to 
bdrv_co_{read, write}v_vmstate)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via 

total: 1 errors, 0 warnings, 42 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/11 Checking commit fc695f91df62 (qcow2: check request on vmstate save/load 
path)
3/11 Checking commit 8aa3af15763f (block: use int64_t instead of uint64_t in 
driver read handlers)
4/11 Checking commit 4e60566f8a2c (block: use int64_t instead of uint64_t in 
driver write handlers)
WARNING: line over 80 characters
#379: FILE: block/nvme.c:1233:
+QEMUIOVector *qiov, BdrvRequestFlags 
flags)

total: 0 errors, 1 warnings, 440 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit 9698c13fe02d (block: use int64_t instead of uint64_t in 
copy_range driver handlers)
6/11 Checking commit 5864b0dfbf2d (block: make BlockLimits::max_pwrite_zeroes 
64bit)
WARNING: Block comments use a leading /* on a separate line
#56: FILE: include/block/block_int.h:679:
+/* Maximum number of bytes that can zeroized at once. Must be multiple of

WARNING: Block comments use a trailing */ on a separate line
#57: FILE: include/block/block_int.h:680:
+ * pwrite_zeroes_alignment. May be 0 if no inherent 64-bit limit */

total: 0 errors, 2 warnings, 21 lines checked

Patch 6/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/11 Checking commit 05ca54013452 (block: use int64_t instead of int in driver 
write_zeroes handlers)
8/11 Checking commit 1dc4bab7ab4e (block/io: allow 64bit write-zeroes requests)
9/11 Checking commit 9d5776fcbb03 (block: make BlockLimits::max_pdiscard 64bit)
WARNING: Block comments use a leading /* on a separate line
#55: FILE: include/block/block_int.h:667:
+/* Maximum number of bytes that can be discarded at once. Must be multiple

WARNING: Block comments use a trailing */ on a separate line
#57: FILE: include/block/block_int.h:669:
+ * inherent 64-bit limit */

total: 0 errors, 2 warnings, 24 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 9b3b5c7f1465 (block: use int64_t instead of int in driver 
discard handlers)
11/11 Checking commit bed608a58181 (block/io: allow 64bit discard requests)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210324205132.464899-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [RFC v5 0/6] hmp, qmp: Add some commands to introspect virtio deices

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1616084984-11263-1-git-send-email-jonah.pal...@oracle.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1616084984-11263-1-git-send-email-jonah.pal...@oracle.com
Subject: [RFC v5 0/6] hmp,qmp: Add some commands to introspect virtio deices

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1616084984-11263-1-git-send-email-jonah.pal...@oracle.com -> 
patchew/1616084984-11263-1-git-send-email-jonah.pal...@oracle.com
Switched to a new branch 'test'
be70546 hmp: add virtio commands
e4f8190 qmp: add QMP command x-debug-virtio-queue-element
3313968 qmp: add QMP command x-debug-virtio-queue-status
8e1517f qmp: decode feature bits in virtio-status
e8c80fb qmp: add QMP command x-debug-virtio-status
8b46cdd qmp: add QMP command x-debug-query-virtio

=== OUTPUT BEGIN ===
1/6 Checking commit 8b46cdd9037d (qmp: add QMP command x-debug-query-virtio)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 183 lines checked

Patch 1/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/6 Checking commit e8c80fb0056a (qmp: add QMP command x-debug-virtio-status)
3/6 Checking commit 8e1517f2abd7 (qmp: decode feature bits in virtio-status)
4/6 Checking commit 3313968494d6 (qmp: add QMP command 
x-debug-virtio-queue-status)
5/6 Checking commit e4f8190e9a24 (qmp: add QMP command 
x-debug-virtio-queue-element)
6/6 Checking commit be705468685f (hmp: add virtio commands)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

WARNING: line over 80 characters
#306: FILE: hw/virtio/virtio.c:4016:
+monitor_printf(mon, "  signalled_used_valid: %d\n", 
s->signalled_used_valid);

ERROR: "foo * bar" should be "foo *bar"
#330: FILE: hw/virtio/virtio.c:4164:
+type##FeatureList * list = features->u.field.features;  \

total: 1 errors, 2 warnings, 473 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1616084984-11263-1-git-send-email-jonah.pal...@oracle.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v3 00/36] block: update graph permissions update

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210317143529.615584-1-vsement...@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210317143529.615584-1-vsement...@virtuozzo.com
Subject: [PATCH v3 00/36] block: update graph permissions update

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210317143529.615584-1-vsement...@virtuozzo.com 
-> patchew/20210317143529.615584-1-vsement...@virtuozzo.com
Switched to a new branch 'test'
ac26c21 block: refactor bdrv_node_check_perm()
7171293 block: rename bdrv_replace_child_safe() to bdrv_replace_child()
9430fba block: refactor bdrv_child_set_perm_safe() transaction action
2386ee1 block: inline bdrv_replace_child()
41c9fc1 block: inline bdrv_check_perm_common()
0d06ade block: drop unused permission update functions
72e8fe6 block: bdrv_reopen_multiple: refresh permissions on updated graph
b7f3a63 block: bdrv_reopen_multiple(): move bdrv_flush to separate pre-prepare
b9278b8 block: add bdrv_set_backing_noperm() transaction action
44f6e69 block: make bdrv_refresh_limits() to be a transaction action
a671d58 block: make bdrv_unset_inherits_from to be a transaction action
aa9e316 block: drop ignore_children for permission update functions
6e17bb7 block/backup-top: drop .active
7292e37 block: introduce bdrv_drop_filter()
9e7ce4f block: add bdrv_remove_filter_or_cow transaction action
a5f3a81 block: adapt bdrv_append() for inserting filters
ba82bea block: split out bdrv_replace_node_noperm()
4c97817 block: add bdrv_attach_child_noperm() transaction action
4a4e038 block: add bdrv_attach_child_common() transaction action
a864516 block: fix bdrv_replace_node_common
ce2b5ee block: add bdrv_replace_child_safe() transaction action
0b5ce80 block: add bdrv_list_* permission update functions
5380bbb block: add bdrv_drv_set_perm transaction action
965e80a block: use topological sort for permission update
35d94b7 block: inline bdrv_child_*() permission functions calls
84f3087 block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms()
9eb28b7 block: refactor bdrv_child* permission functions
0c068cb block: bdrv_refresh_perms: check for parents permissions conflict
23d55e7 util: add transactions.c
68189c0 block: make bdrv_reopen_{prepare, commit, abort} private
5780b80 block: drop ctx argument from bdrv_root_attach_child
34f4c11 block: BdrvChildClass: add .get_parent_aio_context handler
e79d608 block: bdrv_append(): don't consume reference
87c292c tests/test-bdrv-graph-mod: add test_append_greedy_filter
381fa0c tests/test-bdrv-graph-mod: add test_parallel_perm_update
6df2206 tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

=== OUTPUT BEGIN ===
1/36 Checking commit 6df2206946ee (tests/test-bdrv-graph-mod: add 
test_parallel_exclusive_write)
2/36 Checking commit 381fa0c5db90 (tests/test-bdrv-graph-mod: add 
test_parallel_perm_update)
3/36 Checking commit 87c292ca6696 (tests/test-bdrv-graph-mod: add 
test_append_greedy_filter)
4/36 Checking commit e79d608e8fad (block: bdrv_append(): don't consume 
reference)
5/36 Checking commit 34f4c11ddd7e (block: BdrvChildClass: add 
.get_parent_aio_context handler)
6/36 Checking commit 5780b805277e (block: drop ctx argument from 
bdrv_root_attach_child)
7/36 Checking commit 68189c099a3a (block: make bdrv_reopen_{prepare, commit, 
abort} private)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via 

total: 1 errors, 0 warnings, 47 lines checked

Patch 7/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/36 Checking commit 23d55e73e0fa (util: add transactions.c)
9/36 Checking commit 0c068cb2d8be (block: bdrv_refresh_perms: check for parents 
permissions conflict)
10/36 Checking commit 9eb28b73ad7b (block: refactor bdrv_child* permission 
functions)
11/36 Checking commit 84f3087f8300 (block: rewrite bdrv_child_try_set_perm() 
using bdrv_refresh_perms())
12/36 Checking commit 35d94b79e054 (block: inline bdrv_child_*() permission 
functions calls)
13/36 Checking commit 965e80af7b29 (block: use topological sort for permission 
update)
14/36 Checking commit 538008b6 (block: add bdrv_drv_set_perm transaction 
action)
15/36 Checking commit 0b5ce8030a8f (block: add bdrv_list_* permission update 
functions)
16/36 Checking commit ce2b5ee8b20f (block: add bdrv_replace_child_safe() 
transaction action)
17/36 Checking commit a864516ae0f0 (block: fix bdrv_replace_node_common)
18/36 Checking commit 4a4e0386113f (block: add bdrv_attach_child_common() 
transaction action)
19/36 

Re: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210316224412.11609-1-o...@aepfle.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210316224412.11609-1-o...@aepfle.de
Subject: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  
patchew/20210311143958.562625-1-richard.hender...@linaro.org -> 
patchew/20210311143958.562625-1-richard.hender...@linaro.org
 * [new tag] patchew/20210316224412.11609-1-o...@aepfle.de -> 
patchew/20210316224412.11609-1-o...@aepfle.de
Switched to a new branch 'test'
9b7ec0f piix: fix regression during unplug in Xen HVM domUs

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#41: FILE: hw/ide/piix.c:113:
+if (pci_piix3_xen_ide_unplug_done == true)
[...]

total: 1 errors, 0 warnings, 29 lines checked

Commit 9b7ec0fe5d7c (piix: fix regression during unplug in Xen HVM domUs) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210316224412.11609-1-o...@aepfle.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2] block/file-posix: Optimize for macOS

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210305121748.65173-1-akihiko.od...@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210305121748.65173-1-akihiko.od...@gmail.com
Subject: [PATCH v2] block/file-posix: Optimize for macOS

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210305121748.65173-1-akihiko.od...@gmail.com -> 
patchew/20210305121748.65173-1-akihiko.od...@gmail.com
Switched to a new branch 'test'
16b639a block/file-posix: Optimize for macOS

=== OUTPUT BEGIN ===
WARNING: architecture specific defines should be avoided
#95: FILE: block/file-posix.c:2133:
+#if defined(__APPLE__) && (__MACH__)

ERROR: suspect code indent for conditional statements (8, 11)
#168: FILE: hw/block/block.c:73:
+if (!backend_ret && blocksizes.phys) {
conf->physical_block_size = blocksizes.phys;

total: 1 errors, 1 warnings, 145 lines checked

Commit 16b639a81c45 (block/file-posix: Optimize for macOS) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210305121748.65173-1-akihiko.od...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] block/file-posix: Optimize for macOS

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210219085148.90545-1-akihiko.od...@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210219085148.90545-1-akihiko.od...@gmail.com
Subject: [PATCH] block/file-posix: Optimize for macOS

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210219085148.90545-1-akihiko.od...@gmail.com -> 
patchew/20210219085148.90545-1-akihiko.od...@gmail.com
Switched to a new branch 'test'
455b4a3 block/file-posix: Optimize for macOS

=== OUTPUT BEGIN ===
WARNING: architecture specific defines should be avoided
#90: FILE: block/file-posix.c:2133:
+#if defined(__APPLE__) && (__MACH__)

ERROR: suspect code indent for conditional statements (8, 11)
#141: FILE: hw/block/block.c:73:
+if (!backend_ret && blocksizes.phys) {
conf->physical_block_size = blocksizes.phys;

total: 1 errors, 1 warnings, 129 lines checked

Commit 455b4a328821 (block/file-posix: Optimize for macOS) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210219085148.90545-1-akihiko.od...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v3 0/3] migration: dirty-bitmap: Allow control of bitmap persistence

[no-reply]

Patchew URL: https://patchew.org/QEMU/cover.1613150869.git.pkre...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: cover.1613150869.git.pkre...@redhat.com
Subject: [PATCH v3 0/3] migration: dirty-bitmap: Allow control of bitmap 
persistence

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20210205163720.887197-1-vsement...@virtuozzo.com 
-> patchew/20210205163720.887197-1-vsement...@virtuozzo.com
 * [new tag] patchew/cover.1613150869.git.pkre...@redhat.com -> 
patchew/cover.1613150869.git.pkre...@redhat.com
Switched to a new branch 'test'
497cda7 qemu-iotests: 300: Add test case for modifying persistence of bitmap
a575a6e migration: dirty-bitmap: Allow control of bitmap persistence
51195fa migration: dirty-bitmap: Convert alias map inner members to 
BitmapMigrationBitmapAlias

=== OUTPUT BEGIN ===
1/3 Checking commit 51195faba445 (migration: dirty-bitmap: Convert alias map 
inner members to BitmapMigrationBitmapAlias)
ERROR: line over 90 characters
#38: FILE: migration/block-dirty-bitmap.c:269:
+(GDestroyNotify) 
qapi_free_BitmapMigrationBitmapAlias);

total: 1 errors, 0 warnings, 85 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit a575a6e16810 (migration: dirty-bitmap: Allow control of 
bitmap persistence)
3/3 Checking commit 497cda72b44c (qemu-iotests: 300: Add test case for 
modifying persistence of bitmap)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1613150869.git.pkre...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL v2 0/3] emulated nvme fixes

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210211152139.1004257-1-...@irrelevant.dk/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210211152139.1004257-1-...@irrelevant.dk
Subject: [PULL v2 0/3] emulated nvme fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210211152139.1004257-1-...@irrelevant.dk -> 
patchew/20210211152139.1004257-1-...@irrelevant.dk
Switched to a new branch 'test'

=== OUTPUT BEGIN ===
checkpatch.pl: no revisions returned for revlist 'base..'
=== OUTPUT END ===

Test command exited with code: 255


The full log is available at
http://patchew.org/logs/20210211152139.1004257-1-...@irrelevant.dk/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/7] qcow2: compressed write cache

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210129165030.640169-1-vsement...@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210129165030.640169-1-vsement...@virtuozzo.com
Subject: [PATCH 0/7] qcow2: compressed write cache

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   5101d00..3701c07  master -> master
 - [tag update]  patchew/20210129110012.8660-1-peter.mayd...@linaro.org -> 
patchew/20210129110012.8660-1-peter.mayd...@linaro.org
 * [new tag] patchew/20210129165030.640169-1-vsement...@virtuozzo.com 
-> patchew/20210129165030.640169-1-vsement...@virtuozzo.com
Switched to a new branch 'test'
d7783a4 simplebench/bench-backup: add target-cache argument
ddf4442 simplebench/bench-backup: add --compressed option
47ee627 simplebench: bench_one(): support count=1
2b80e33 simplebench: bench_one(): add slow_limit argument
acf2fb6 block/qcow2: use compressed write cache
d96e35f block/qcow2: introduce cache for compressed writes
0d009e1 qemu/queue: add some useful QLIST_ and QTAILQ_ macros

=== OUTPUT BEGIN ===
1/7 Checking commit 0d009e16280d (qemu/queue: add some useful QLIST_ and 
QTAILQ_ macros)
ERROR: spaces required around that '*' (ctx:WxV)
#25: FILE: include/qemu/queue.h:177:
+typeof(*QLIST_FIRST(head)) *qffs_var, *qffs_next_var;   \
^

WARNING: Block comments use a leading /* on a separate line
#29: FILE: include/qemu/queue.h:181:
+} while (/*CONSTCOND*/0)

ERROR: spaces required around that '*' (ctx:WxV)
#39: FILE: include/qemu/queue.h:501:
+typeof(*QTAILQ_FIRST(head)) *qffs_var, *qffs_next_var;  \
 ^

WARNING: Block comments use a leading /* on a separate line
#43: FILE: include/qemu/queue.h:505:
+} while (/*CONSTCOND*/0)

total: 2 errors, 2 warnings, 26 lines checked

Patch 1/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/7 Checking commit d96e35f1544f (block/qcow2: introduce cache for compressed 
writes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 816 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/7 Checking commit acf2fb60d5c2 (block/qcow2: use compressed write cache)
4/7 Checking commit 2b80e334b300 (simplebench: bench_one(): add slow_limit 
argument)
5/7 Checking commit 47ee62768317 (simplebench: bench_one(): support count=1)
6/7 Checking commit ddf44420a9e8 (simplebench/bench-backup: add --compressed 
option)
7/7 Checking commit d7783a45ee7b (simplebench/bench-backup: add target-cache 
argument)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210129165030.640169-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL 00/13] Misc patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210129171102.4109641-1-berra...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210129171102.4109641-1-berra...@redhat.com
Subject: [PULL 00/13] Misc patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210129171102.4109641-1-berra...@redhat.com -> 
patchew/20210129171102.4109641-1-berra...@redhat.com
Switched to a new branch 'test'
d1a54cc tests: Replace deprecated ASN1 code
fa7ea70 tests: Fix runtime error in test-authz-pam
085f233 ui: update keycodemapdb submodule commit
60edf69 crypto: Add spaces around operator
b9680cd configure: replace --enable/disable-git-update with 
--with-git-submodules
6db8348 docs: fix missing backslash in certtool shell example
4a5ba18 docs: simplify and clarify the platform support rules
89433ae Prefer 'on' | 'off' over 'yes' | 'no' for bool options
de66ba1 os: deprecate the -enable-fips option and QEMU's FIPS enforcement
aadd818 crypto: Fix memory leaks in set_loaded for tls-*
e5056b8 crypto: Forbid broken unloading of secrets
96f48a1 crypto: Move USER_CREATABLE to secret_common base class
0a666a6 crypto: Fix some code style problems, add spaces around operator

=== OUTPUT BEGIN ===
1/13 Checking commit 0a666a653a56 (crypto: Fix some code style problems, add 
spaces around operator)
2/13 Checking commit 96f48a1f4123 (crypto: Move USER_CREATABLE to secret_common 
base class)
3/13 Checking commit e5056b897b03 (crypto: Forbid broken unloading of secrets)
4/13 Checking commit aadd818a731a (crypto: Fix memory leaks in set_loaded for 
tls-*)
5/13 Checking commit de66ba1527d2 (os: deprecate the -enable-fips option and 
QEMU's FIPS enforcement)
6/13 Checking commit 89433ae1e17b (Prefer 'on' | 'off' over 'yes' | 'no' for 
bool options)
7/13 Checking commit 4a5ba182d293 (docs: simplify and clarify the platform 
support rules)
8/13 Checking commit 6db83486e869 (docs: fix missing backslash in certtool 
shell example)
9/13 Checking commit b9680cded03f (configure: replace 
--enable/disable-git-update with --with-git-submodules)
10/13 Checking commit 60edf69c0fbf (crypto: Add spaces around operator)
ERROR: braces {} are necessary for all arms of this statement
#28: FILE: crypto/aes.c:1083:
+if (bits == 128)
[...]
-else if (bits==192)
[...]
 key->rounds = 12;
[...]

ERROR: braces {} are necessary for all arms of this statement
#31: FILE: crypto/aes.c:1085:
+else if (bits == 192)
[...]
 else
[...]

ERROR: space prohibited after that open parenthesis '('
#44: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: space prohibited before that close parenthesis ')'
#44: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: space required before the open parenthesis '('
#44: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: trailing statements should be on next line
#44: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: braces {} are necessary for all arms of this statement
#44: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];
[...]

total: 7 errors, 0 warnings, 19 lines checked

Patch 10/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/13 Checking commit 085f2338c909 (ui: update keycodemapdb submodule commit)
12/13 Checking commit fa7ea706d673 (tests: Fix runtime error in test-authz-pam)
13/13 Checking commit d1a54cc3e1b1 (tests: Replace deprecated ASN1 code)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210129171102.4109641-1-berra...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210118063808.12471-1-jiaxun.y...@flygoat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210118063808.12471-1-jiaxun.y...@flygoat.com
Subject: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210118063808.12471-1-jiaxun.y...@flygoat.com -> 
patchew/20210118063808.12471-1-jiaxun.y...@flygoat.com
 * [new tag] patchew/20210118065627.79903-1-ganqi...@huawei.com -> 
patchew/20210118065627.79903-1-ganqi...@huawei.com
Switched to a new branch 'test'
eeef33a gitlab-ci: Add alpine to pipeline
85ea588 tests/docker: Add dockerfile for Alpine Linux
9f5e3ca accel/kvm: avoid using predefined PAGE_SIZE
0292db5 tests: Rename PAGE_SIZE definitions
fdcacb9 elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE
9ff36c5 hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE
b096605 osdep.h: Remove  include
9e5e67d libvhost-user: Include poll.h instead of sys/poll.h
c20bc72 configure: Add sys/timex.h to probe clock_adjtime

=== OUTPUT BEGIN ===
1/9 Checking commit c20bc7253f10 (configure: Add sys/timex.h to probe 
clock_adjtime)
2/9 Checking commit 9e5e67d01f91 (libvhost-user: Include poll.h instead of 
sys/poll.h)
3/9 Checking commit b0966056d77e (osdep.h: Remove  include)
4/9 Checking commit 9ff36c58081b (hw/block/nand: Rename PAGE_SIZE to 
NAND_PAGE_SIZE)
ERROR: code indent should never use tabs
#27: FILE: hw/block/nand.c:118:
+# define PAGE_START(page)^I(PAGE(page) * (NAND_PAGE_SIZE + OOB_SIZE))$

ERROR: code indent should never use tabs
#47: FILE: hw/block/nand.c:135:
+# define NAND_PAGE_SIZE^I^I2048$

WARNING: line over 80 characters
#66: FILE: hw/block/nand.c:675:
+mem_and(iobuf + (soff | off), s->io, MIN(s->iolen, NAND_PAGE_SIZE - 
off));

WARNING: line over 80 characters
#71: FILE: hw/block/nand.c:678:
+mem_and(s->storage + (page << OOB_SHIFT), s->io + NAND_PAGE_SIZE - 
off,

total: 2 errors, 2 warnings, 120 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit fdcacb94e921 (elf2dmp: Rename PAGE_SIZE to 
ELF2DMP_PAGE_SIZE)
WARNING: line over 80 characters
#70: FILE: contrib/elf2dmp/main.c:284:
+h.PhysicalMemoryBlock.NumberOfPages += ps->block[i].size / 
ELF2DMP_PAGE_SIZE;

WARNING: line over 80 characters
#80: FILE: contrib/elf2dmp/main.c:291:
+h.RequiredDumpSpace += h.PhysicalMemoryBlock.NumberOfPages << 
ELF2DMP_PAGE_BITS;

total: 0 errors, 2 warnings, 70 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 0292db5a571a (tests: Rename PAGE_SIZE definitions)
7/9 Checking commit 9f5e3ca96943 (accel/kvm: avoid using predefined PAGE_SIZE)
8/9 Checking commit 85ea5884f78d (tests/docker: Add dockerfile for Alpine Linux)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit eeef33a77edf (gitlab-ci: Add alpine to pipeline)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210118063808.12471-1-jiaxun.y...@flygoat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210114150902.11515-1-bmeng...@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210114150902.11515-1-bmeng...@gmail.com
Subject: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for 
fast read commands

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20210114013147.92962-1-jiaxun.y...@flygoat.com -> 
patchew/20210114013147.92962-1-jiaxun.y...@flygoat.com
 * [new tag] patchew/20210114150902.11515-1-bmeng...@gmail.com -> 
patchew/20210114150902.11515-1-bmeng...@gmail.com
Switched to a new branch 'test'
b87aded hw/ssi: npcm7xx_fiu: Correct the dummy cycle emulation logic
4518be2 Revert "aspeed/smc: snoop SPI transfers to fake dummy cycles"
6a4067a Revert "aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command"
e5ea744 hw/ssi: xilinx_spips: Fix generic fifo dummy cycle handling
3294942 hw/block: m25p80: Support fast read for SST flashes
50a7f9f hw/block: m25p80: Fix the number of dummy bytes needed for Spansion 
flashes
cf6f8e1 hw/block: m25p80: Fix the number of dummy bytes needed for Macronix 
flashes
3925fcf hw/block: m25p80: Fix the number of dummy bytes needed for 
Numonyx/Micron flashes
5344168 hw/block: m25p80: Fix the number of dummy bytes needed for Windbond 
flashes

=== OUTPUT BEGIN ===
1/9 Checking commit 5344168de433 (hw/block: m25p80: Fix the number of dummy 
bytes needed for Windbond flashes)
2/9 Checking commit 3925fcf79dbc (hw/block: m25p80: Fix the number of dummy 
bytes needed for Numonyx/Micron flashes)
3/9 Checking commit cf6f8e145faa (hw/block: m25p80: Fix the number of dummy 
bytes needed for Macronix flashes)
4/9 Checking commit 50a7f9fb909b (hw/block: m25p80: Fix the number of dummy 
bytes needed for Spansion flashes)
5/9 Checking commit 3294942ca3a1 (hw/block: m25p80: Support fast read for SST 
flashes)
6/9 Checking commit e5ea74473d87 (hw/ssi: xilinx_spips: Fix generic fifo dummy 
cycle handling)
ERROR: line over 90 characters
#63: FILE: hw/ssi/xilinx_spips.c:510:
+uint8_t spi_mode = ARRAY_FIELD_EX32(s->regs, 
GQSPI_GF_SNAPSHOT, SPI_MODE);

ERROR: line over 90 characters
#71: FILE: hw/ssi/xilinx_spips.c:518:
+qemu_log_mask(LOG_GUEST_ERROR, "Unknown SPI MODE: 0x%x 
", spi_mode);

total: 2 errors, 0 warnings, 41 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 6a4067a6a9fc (Revert "aspeed/smc: Fix number of dummy 
cycles for FAST_READ_4 command")
8/9 Checking commit 4518be22e1c9 (Revert "aspeed/smc: snoop SPI transfers to 
fake dummy cycles")
9/9 Checking commit b87aded6dc2a (hw/ssi: npcm7xx_fiu: Correct the dummy cycle 
emulation logic)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210114150902.11515-1-bmeng...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL 0/5] Tracing patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20210104143154.462212-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210104143154.462212-1-stefa...@redhat.com
Subject: [PULL 0/5] Tracing patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210104143154.462212-1-stefa...@redhat.com -> 
patchew/20210104143154.462212-1-stefa...@redhat.com
Switched to a new branch 'test'
6b1738f tracetool: show trace-events filename/lineno in fmt string errors
d66a9fc tracetool: add input filename and line number to Event
0262a28 tracetool: add out_lineno and out_next_lineno to out()
95bd058 tracetool: add output filename command-line argument
f8cfb47 trace: Send "-d trace:help" output to stdout

=== OUTPUT BEGIN ===
1/5 Checking commit f8cfb47e3ae2 (trace: Send "-d trace:help" output to stdout)
2/5 Checking commit 95bd058cef88 (tracetool: add output filename command-line 
argument)
ERROR: line over 90 characters
#73: FILE: scripts/tracetool.py:35:
+Usage: %(script)s --format= --backends= [] 
 ... 

total: 1 errors, 0 warnings, 144 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 0262a28e87d0 (tracetool: add out_lineno and out_next_lineno 
to out())
4/5 Checking commit d66a9fc4e62f (tracetool: add input filename and line number 
to Event)
5/5 Checking commit 6b1738f508ad (tracetool: show trace-events filename/lineno 
in fmt string errors)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210104143154.462212-1-stefa...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/9] Alpine Linux build fix and CI pipeline

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201221005318.11866-1-jiaxun.y...@flygoat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201221005318.11866-1-jiaxun.y...@flygoat.com
Subject: [PATCH 0/9] Alpine Linux build fix and CI pipeline

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201221005318.11866-1-jiaxun.y...@flygoat.com -> 
patchew/20201221005318.11866-1-jiaxun.y...@flygoat.com
Switched to a new branch 'test'
10095a9 gitlab-ci: Add alpine to pipeline
a177af3 tests: Rename PAGE_SIZE definitions
5fcb0ed accel/kvm: avoid using predefined PAGE_SIZE
e7febdf hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE
ba307d5 elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE
0ccf92b libvhost-user: Include poll.h instead of sys/poll.h
41a10db configure/meson: Only check sys/signal.h on non-Linux
0bcd2f2 configure: Add sys/timex.h to probe clk_adjtime
a16c7ff tests/docker: Add dockerfile for Alpine Linux

=== OUTPUT BEGIN ===
1/9 Checking commit a16c7ff7d859 (tests/docker: Add dockerfile for Alpine Linux)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 56 lines checked

Patch 1/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/9 Checking commit 0bcd2f2eae84 (configure: Add sys/timex.h to probe 
clk_adjtime)
3/9 Checking commit 41a10dbdc8da (configure/meson: Only check sys/signal.h on 
non-Linux)
4/9 Checking commit 0ccf92b8ec37 (libvhost-user: Include poll.h instead of 
sys/poll.h)
5/9 Checking commit ba307d5a51aa (elf2dmp: Rename PAGE_SIZE to 
ELF2DMP_PAGE_SIZE)
WARNING: line over 80 characters
#69: FILE: contrib/elf2dmp/main.c:284:
+h.PhysicalMemoryBlock.NumberOfPages += ps->block[i].size / 
ELF2DMP_PAGE_SIZE;

WARNING: line over 80 characters
#79: FILE: contrib/elf2dmp/main.c:291:
+h.RequiredDumpSpace += h.PhysicalMemoryBlock.NumberOfPages << 
ELF2DMP_PAGE_BITS;

total: 0 errors, 2 warnings, 70 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit e7febdf0b056 (hw/block/nand: Rename PAGE_SIZE to 
NAND_PAGE_SIZE)
ERROR: code indent should never use tabs
#26: FILE: hw/block/nand.c:117:
+# define PAGE_START(page)^I(PAGE(page) * (NAND_PAGE_SIZE + OOB_SIZE))$

ERROR: code indent should never use tabs
#46: FILE: hw/block/nand.c:134:
+# define NAND_PAGE_SIZE^I^I2048$

WARNING: line over 80 characters
#65: FILE: hw/block/nand.c:684:
+mem_and(iobuf + (soff | off), s->io, MIN(s->iolen, NAND_PAGE_SIZE - 
off));

WARNING: line over 80 characters
#70: FILE: hw/block/nand.c:687:
+mem_and(s->storage + (page << OOB_SHIFT), s->io + NAND_PAGE_SIZE - 
off,

total: 2 errors, 2 warnings, 120 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 5fcb0ed1331a (accel/kvm: avoid using predefined PAGE_SIZE)
8/9 Checking commit a177af33938d (tests: Rename PAGE_SIZE definitions)
9/9 Checking commit 10095a92643d (gitlab-ci: Add alpine to pipeline)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201221005318.11866-1-jiaxun.y...@flygoat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/5] SCSI: fix transfer limits for SCSI passthrough

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201209135355.561745-1-mlevi...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201209135355.561745-1-mlevi...@redhat.com
Subject: [PATCH v2 0/5] SCSI: fix transfer limits for SCSI passthrough

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201209135355.561745-1-mlevi...@redhat.com -> 
patchew/20201209135355.561745-1-mlevi...@redhat.com
Switched to a new branch 'test'
77c9000 block/scsi: correctly emulate the VPD block limits page
61f49e1 block: use blk_get_max_ioctl_transfer for SCSI passthrough
35c66d6 block: add max_ioctl_transfer to BlockLimits
08ba263 file-posix: add sg_get_max_segments that actually works with sg
e9fd749 file-posix: split hdev_refresh_limits from raw_refresh_limits

=== OUTPUT BEGIN ===
1/5 Checking commit e9fd7498060c (file-posix: split hdev_refresh_limits from 
raw_refresh_limits)
2/5 Checking commit 08ba263f565d (file-posix: add sg_get_max_segments that 
actually works with sg)
3/5 Checking commit 35c66d636d83 (block: add max_ioctl_transfer to BlockLimits)
4/5 Checking commit 61f49e1c953b (block: use blk_get_max_ioctl_transfer for 
SCSI passthrough)
5/5 Checking commit 77c9000b7c30 (block/scsi: correctly emulate the VPD block 
limits page)
ERROR: braces {} are necessary for all arms of this statement
#39: FILE: hw/scsi/scsi-generic.c:204:
+if (len < r->buflen)
[...]

total: 1 errors, 0 warnings, 28 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201209135355.561745-1-mlevi...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201120161622.1537-1-vsement...@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201120161622.1537-1-vsement...@virtuozzo.com
Subject: [PATCH RFC 0/5] Fix accidental crash in iotest 30

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201120161622.1537-1-vsement...@virtuozzo.com -> 
patchew/20201120161622.1537-1-vsement...@virtuozzo.com
Switched to a new branch 'test'
9aed580 block: protect some graph-modifyng things by mutex
74c4557 block: move some mirror and stream handlers to coroutine
fae70bd scripts/block-coroutine-wrapper.py: allow more function types
7bccf2c iotest-30-shorten: concentrate on failing test case
1c79f08 abort-on-set-to-true

=== OUTPUT BEGIN ===
1/5 Checking commit 1c79f086eae8 (abort-on-set-to-true)
ERROR: do not initialise globals to 0 or NULL
#18: FILE: block.c:87:
+bool abort_on_set_to_true = false;

ERROR: line over 90 characters
#27: FILE: block.c:2007:
+if ((added_perms || removed_shared_perms) && tighten_restrictions == 
_on_set_to_true) {

WARNING: line over 80 characters
#44: FILE: block.c:2075:
+ret = bdrv_child_check_perm(c, q, cur_perm, cur_shared, 
ignore_children,

WARNING: line over 80 characters
#47: FILE: block.c:2078:
+ret = bdrv_child_check_perm(c, q, cur_perm, cur_shared, 
ignore_children,

WARNING: line over 80 characters
#48: FILE: block.c:2079:
+tighten_restrictions ? 
_tighten_restr

total: 2 errors, 3 warnings, 74 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/5 Checking commit 7bccf2cf8bff (iotest-30-shorten: concentrate on failing 
test case)
3/5 Checking commit fae70bd3851a (scripts/block-coroutine-wrapper.py: allow 
more function types)
WARNING: line over 80 characters
#35: FILE: scripts/block-coroutine-wrapper.py:82:
+func_decl_re = 
re.compile(r'^(?P(void|int))\s*generated_co_wrapper\s*'

total: 0 errors, 1 warnings, 80 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 74c4557e6dea (block: move some mirror and stream handlers 
to coroutine)
5/5 Checking commit 9aed58093018 (block: protect some graph-modifyng things by 
mutex)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201120161622.1537-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/5] SCSI: fix transfer limits for SCSI passthrough

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201104173217.417538-1-mlevi...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201104173217.417538-1-mlevi...@redhat.com
Subject: [PATCH 0/5] SCSI: fix transfer limits for SCSI passthrough

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   b1266b6..3c8c36c  master -> master
 - [tag update]  patchew/20201104160021.2342108-1-ehabk...@redhat.com -> 
patchew/20201104160021.2342108-1-ehabk...@redhat.com
 * [new tag] patchew/20201104173217.417538-1-mlevi...@redhat.com -> 
patchew/20201104173217.417538-1-mlevi...@redhat.com
Switched to a new branch 'test'
bde6371 block/scsi: correctly emulate the VPD block limits page
c4180d6 block: use blk_get_max_ioctl_transfer for SCSI passthrough
9ff7edc block: add max_ioctl_transfer to BlockLimits
dd2f1f7 file-posix: add sg_get_max_segments that actually works with sg
f9ad940 file-posix: split hdev_refresh_limits from raw_refresh_limits

=== OUTPUT BEGIN ===
1/5 Checking commit f9ad9400e011 (file-posix: split hdev_refresh_limits from 
raw_refresh_limits)
2/5 Checking commit dd2f1f77a5d2 (file-posix: add sg_get_max_segments that 
actually works with sg)
3/5 Checking commit 9ff7edc31002 (block: add max_ioctl_transfer to BlockLimits)
4/5 Checking commit c4180d6accff (block: use blk_get_max_ioctl_transfer for 
SCSI passthrough)
5/5 Checking commit bde637139536 (block/scsi: correctly emulate the VPD block 
limits page)
ERROR: braces {} are necessary for all arms of this statement
#51: FILE: hw/scsi/scsi-generic.c:196:
+if (page_idx >= r->buflen)
[...]

total: 1 errors, 0 warnings, 53 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201104173217.417538-1-mlevi...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] crypto: Add spaces around operator

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com
Subject: [PATCH] crypto: Add spaces around operator

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com -> 
patchew/bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com
Switched to a new branch 'test'
53a011e crypto: Add spaces around operator

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#24: FILE: crypto/aes.c:1083:
+if (bits == 128)
[...]
-else if (bits==192)
[...]
 key->rounds = 12;
[...]

ERROR: braces {} are necessary for all arms of this statement
#27: FILE: crypto/aes.c:1085:
+else if (bits == 192)
[...]
 else
[...]

ERROR: space prohibited after that open parenthesis '('
#49: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: space prohibited before that close parenthesis ')'
#49: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: space required before the open parenthesis '('
#49: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: trailing statements should be on next line
#49: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];

ERROR: braces {} are necessary for all arms of this statement
#49: FILE: crypto/desrfb.c:96:
+if( pcr[pc2[j + 24]] ) kn[n] |= bigbyte[j];
[...]

total: 7 errors, 0 warnings, 35 lines checked

Commit 53a011edf848 (crypto: Add spaces around operator) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL v3 00/28] Block patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201023152147.1016281-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201023152147.1016281-1-stefa...@redhat.com
Subject: [PULL v3 00/28] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201023152147.1016281-1-stefa...@redhat.com -> 
patchew/20201023152147.1016281-1-stefa...@redhat.com
Switched to a new branch 'test'
38310db iotests: add commit top->base cases to 274
f0671dd block/io: fix bdrv_is_allocated_above
d9c08b8 block/io: bdrv_common_block_status_above: support bs == base
c837bb3 block/io: bdrv_common_block_status_above: support include_base
6451e449 block/io: fix bdrv_co_block_status_above
b1b2eaa block/export: add vhost-user-blk multi-queue support
4cfdc0f block/export: add iothread and fixed-iothread options
21b0ebf block: move block exports to libblockdev
8e28b19 qemu-storage-daemon: avoid compiling blockdev_ss twice
d78e439 util/vhost-user-server: use static library in meson.build
5ed1b1e util/vhost-user-server: move header to include/
4fdb4dc block/export: convert vhost-user-blk server to block export API
1d7b5ba block/export: report flush errors
70c003e util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
6b44703 util/vhost-user-server: check EOF when reading payload
2712e58 util/vhost-user-server: fix memory leak in vu_message_read()
0e740c0 util/vhost-user-server: drop unused DevicePanicNotifier
4f37c8e block/export: consolidate request structs into VuBlockReq
326d4b4 util/vhost-user-server: drop unnecessary watch deletion
f072aef util/vhost-user-server: drop unnecessary QOM cast
dfd5a40 util/vhost-user-server: s/fileds/fields/ typo fix
106a79f MAINTAINERS: Add vhost-user block device backend server maintainer
bcb59a3 block/export: vhost-user block device backend server
c5e218a block: move logical block size check function to a common utility 
function
c4829fd util/vhost-user-server: generic vhost user server
b7acac2 libvhost-user: remove watch for kick_fd when de-initialize vu-dev
d236c9a libvhost-user: Allow vu_message_read to be replaced
098c6e0 block/nvme: Add driver statistics for access alignment and hw errors

=== OUTPUT BEGIN ===
1/28 Checking commit 098c6e074f94 (block/nvme: Add driver statistics for access 
alignment and hw errors)
2/28 Checking commit d236c9abc147 (libvhost-user: Allow vu_message_read to be 
replaced)
WARNING: Block comments use a leading /* on a separate line
#130: FILE: contrib/libvhost-user/libvhost-user.h:395:
+/* @read_msg: custom method to read vhost-user message

total: 0 errors, 1 warnings, 139 lines checked

Patch 2/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/28 Checking commit b7acac2640e0 (libvhost-user: remove watch for kick_fd when 
de-initialize vu-dev)
4/28 Checking commit c4829fd6b453 (util/vhost-user-server: generic vhost user 
server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#87: FILE: util/vhost-user-server.c:48:
+/* When this is set vu_client_trip will stop new processing vhost-user 
message */

total: 0 errors, 2 warnings, 500 lines checked

Patch 4/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/28 Checking commit c5e218aa5fc3 (block: move logical block size check 
function to a common utility function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 5/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/28 Checking commit bcb59a3a37a8 (block/export: vhost-user block device 
backend server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

WARNING: line over 80 characters
#476: FILE: block/export/vhost-user-blk-server.c:442:
+blk_remove_aio_context_notifier(vu_block_device->backend, 
blk_aio_attached,

ERROR: g_free(NULL) is safe this check is probably not required
#536: FILE: block/export/vhost-user-blk-server.c:502:
+if (vus->node_name) {
+g_free(vus->node_name);

total: 1 errors, 2 warnings, 714 lines checked

Patch 6/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/28 

Re: [PATCH] block: End quiescent sections when a BDS is deleted

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/160344969243.4091343.14371338409686732879.st...@bahia.lan/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 160344969243.4091343.14371338409686732879.st...@bahia.lan
Subject: [PATCH] block: End quiescent sections when a BDS is deleted

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/160344969243.4091343.14371338409686732879.st...@bahia.lan -> 
patchew/160344969243.4091343.14371338409686732879.st...@bahia.lan
 - [tag update]  patchew/20201023101222.250147-1-kw...@redhat.com -> 
patchew/20201023101222.250147-1-kw...@redhat.com
Switched to a new branch 'test'
f9501f8 block: End quiescent sections when a BDS is deleted

=== OUTPUT BEGIN ===
ERROR: Use g_assert or g_assert_not_reached
#73: FILE: block/io.c:640:
+g_assert_cmpint(bs->quiesce_counter, >, 0);

ERROR: Use g_assert or g_assert_not_reached
#74: FILE: block/io.c:641:
+g_assert_cmpint(bs->refcnt, ==, 0);

total: 2 errors, 0 warnings, 53 lines checked

Commit f9501f846de1 (block: End quiescent sections when a BDS is deleted) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/160344969243.4091343.14371338409686732879.st...@bahia.lan/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL v2 00/28] Block patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201022112726.736757-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201022112726.736757-1-stefa...@redhat.com
Subject: [PULL v2 00/28] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201022112726.736757-1-stefa...@redhat.com -> 
patchew/20201022112726.736757-1-stefa...@redhat.com
Switched to a new branch 'test'
070cb87 iotests: add commit top->base cases to 274
2381a9d block/io: fix bdrv_is_allocated_above
5314155 block/io: bdrv_common_block_status_above: support bs == base
824d6f6 block/io: bdrv_common_block_status_above: support include_base
8f13830 block/io: fix bdrv_co_block_status_above
384ba22 block/export: add vhost-user-blk multi-queue support
e10972d block/export: add iothread and fixed-iothread options
531d73b block: move block exports to libblockdev
13e8546 qemu-storage-daemon: avoid compiling blockdev_ss twice
9144c2b util/vhost-user-server: use static library in meson.build
9afaa76 util/vhost-user-server: move header to include/
1ded925 block/export: convert vhost-user-blk server to block export API
5bfa726 block/export: report flush errors
4565966 util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
7d3e499 util/vhost-user-server: check EOF when reading payload
719ab6d util/vhost-user-server: fix memory leak in vu_message_read()
0afbb2c util/vhost-user-server: drop unused DevicePanicNotifier
9c3a1b30 block/export: consolidate request structs into VuBlockReq
d7f9068 util/vhost-user-server: drop unnecessary watch deletion
eb038288 util/vhost-user-server: drop unnecessary QOM cast
b6a8c41 util/vhost-user-server: s/fileds/fields/ typo fix
ef06bf4 MAINTAINERS: Add vhost-user block device backend server maintainer
3fed4d9 block/export: vhost-user block device backend server
5570b61 block: move logical block size check function to a common utility 
function
b03a5d2 util/vhost-user-server: generic vhost user server
a940b88 libvhost-user: remove watch for kick_fd when de-initialize vu-dev
b367b3a libvhost-user: Allow vu_message_read to be replaced
d61af88 block/nvme: Add driver statistics for access alignment and hw errors

=== OUTPUT BEGIN ===
1/28 Checking commit d61af8856e1d (block/nvme: Add driver statistics for access 
alignment and hw errors)
2/28 Checking commit b367b3a0c954 (libvhost-user: Allow vu_message_read to be 
replaced)
WARNING: Block comments use a leading /* on a separate line
#130: FILE: contrib/libvhost-user/libvhost-user.h:395:
+/* @read_msg: custom method to read vhost-user message

total: 0 errors, 1 warnings, 139 lines checked

Patch 2/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/28 Checking commit a940b885ebfc (libvhost-user: remove watch for kick_fd when 
de-initialize vu-dev)
4/28 Checking commit b03a5d2b5417 (util/vhost-user-server: generic vhost user 
server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#87: FILE: util/vhost-user-server.c:48:
+/* When this is set vu_client_trip will stop new processing vhost-user 
message */

total: 0 errors, 2 warnings, 500 lines checked

Patch 4/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/28 Checking commit 5570b616e366 (block: move logical block size check 
function to a common utility function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 5/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/28 Checking commit 3fed4d90a1a6 (block/export: vhost-user block device 
backend server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

WARNING: line over 80 characters
#476: FILE: block/export/vhost-user-blk-server.c:442:
+blk_remove_aio_context_notifier(vu_block_device->backend, 
blk_aio_attached,

ERROR: g_free(NULL) is safe this check is probably not required
#536: FILE: block/export/vhost-user-blk-server.c:502:
+if (vus->node_name) {
+g_free(vus->node_name);

total: 1 errors, 2 warnings, 714 lines checked

Patch 6/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/28 

Re: [PATCH] virtio-gpu: fix incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114292-10332-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114292-10332-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] virtio-gpu: fix incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ddfd443 virtio-gpu: fix incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 122 lines checked

Commit ddfd4437fd4d (virtio-gpu: fix incorrect print type) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114292-10332-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] vfio: fix incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114337-28056-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114337-28056-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] vfio: fix incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   ba2a9a9..000f5b8  master -> master
 * [new tag] 
patchew/1603114337-28056-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114337-28056-1-git-send-email-lizhen...@huawei.com
Switched to a new branch 'test'
c84a69c vfio: fix incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 16 lines checked

Commit c84a69c621bd (vfio: fix incorrect print type) has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114337-28056-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] vhost-user-scsi: fix incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114225-22628-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114225-22628-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] vhost-user-scsi: fix incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2de1f5c vhost-user-scsi: fix incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 8 lines checked

Commit 2de1f5c5b85d (vhost-user-scsi: fix incorrect print type) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114225-22628-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] vhost-user: fix incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114272-25004-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114272-25004-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] vhost-user: fix incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1603114225-22628-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114225-22628-1-git-send-email-lizhen...@huawei.com
 * [new tag] 
patchew/1603114272-25004-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114272-25004-1-git-send-email-lizhen...@huawei.com
Switched to a new branch 'test'
778c5c6 vhost-user: fix incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 40 lines checked

Commit 778c5c6502be (vhost-user: fix incorrect print type) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114272-25004-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] virtio-iommu: fix incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114311-7392-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114311-7392-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] virtio-iommu: fix incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1603114292-10332-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114292-10332-1-git-send-email-lizhen...@huawei.com
 * [new tag] 
patchew/1603114311-7392-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114311-7392-1-git-send-email-lizhen...@huawei.com
Switched to a new branch 'test'
c61a848 virtio-iommu: fix incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 24 lines checked

Commit c61a8487f435 (virtio-iommu: fix incorrect print type) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114311-7392-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] vhost-user-gpu: incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114196-22776-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114196-22776-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] vhost-user-gpu: incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1603114196-22776-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114196-22776-1-git-send-email-lizhen...@huawei.com
 - [tag update]  patchew/20200928160402.7961-1-peter.mayd...@linaro.org -> 
patchew/20200928160402.7961-1-peter.mayd...@linaro.org
Switched to a new branch 'test'
9b2dfcb vhost-user-gpu: incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 130 lines checked

Commit 9b2dfcb979e6 (vhost-user-gpu: incorrect print type) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114196-22776-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1602999390-21324-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1602999390-21324-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] qemu-img: add support for rate limit in qemu-img convert

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1602999390-21324-1-git-send-email-lizhen...@huawei.com -> 
patchew/1602999390-21324-1-git-send-email-lizhen...@huawei.com
Switched to a new branch 'test'
c39672c qemu-img: add support for rate limit in qemu-img convert

=== OUTPUT BEGIN ===
ERROR: consider using qemu_strtoull in preference to strtoull
#94: FILE: qemu-img.c:2336:
+unsigned long long sval = strtoull(optarg, , 10);

total: 1 errors, 0 warnings, 94 lines checked

Commit c39672c23e5d (qemu-img: add support for rate limit in qemu-img convert) 
has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1602999390-21324-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1602999097-24744-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1602999097-24744-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1602999097-24744-1-git-send-email-lizhen...@huawei.com -> 
patchew/1602999097-24744-1-git-send-email-lizhen...@huawei.com
Switched to a new branch 'test'
ffdac92 qemu-img: add support for offline rate limit in qemu-img commit

=== OUTPUT BEGIN ===
ERROR: consider using qemu_strtoull in preference to strtoull
#59: FILE: qemu-img.c:1032:
+unsigned long long sval = strtoull(optarg, , 10);

total: 1 errors, 0 warnings, 49 lines checked

Commit ffdac92f0f39 (qemu-img: add support for offline rate limit in qemu-img 
commit) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1602999097-24744-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL v2 00/30] Block patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201012182800.157697-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201012182800.157697-1-stefa...@redhat.com
Subject: [PULL v2 00/30] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201012182800.157697-1-stefa...@redhat.com -> 
patchew/20201012182800.157697-1-stefa...@redhat.com
Switched to a new branch 'test'
0a960f8 iotests: add commit top->base cases to 274
2904098 block/io: fix bdrv_is_allocated_above
d4a7d3e block/io: bdrv_common_block_status_above: support bs == base
b49dc55 block/io: bdrv_common_block_status_above: support include_base
d855c38 block/io: fix bdrv_co_block_status_above
617ab32 tests/qtest: add multi-queue test case to vhost-user-blk-test
1ba3da8 block/export: add vhost-user-blk multi-queue support
c9cda63 block/export: add iothread and fixed-iothread options
8d7ed6c block: move block exports to libblockdev
c68e244 qemu-storage-daemon: avoid compiling blockdev_ss twice
05df47a util/vhost-user-server: use static library in meson.build
55e251f util/vhost-user-server: move header to include/
b1d101e block/export: convert vhost-user-blk server to block export API
21c3c13 block/export: report flush errors
559e3b3 util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
c4ccc02 util/vhost-user-server: check EOF when reading payload
db49ac1 util/vhost-user-server: fix memory leak in vu_message_read()
5b01ca0 util/vhost-user-server: drop unused DevicePanicNotifier
1aab372 block/export: consolidate request structs into VuBlockReq
1df6ecd util/vhost-user-server: drop unnecessary watch deletion
a8933a8 util/vhost-user-server: drop unnecessary QOM cast
bd4edb0 util/vhost-user-server: s/fileds/fields/ typo fix
bec8cbf MAINTAINERS: Add vhost-user block device backend server maintainer
de2268c test: new qTest case to test the vhost-user-blk-server
ec6d467 block/export: vhost-user block device backend server
6ac349d block: move logical block size check function to a common utility 
function
9036dfc util/vhost-user-server: generic vhost user server
a70c2f0 libvhost-user: remove watch for kick_fd when de-initialize vu-dev
cea6c96 libvhost-user: Allow vu_message_read to be replaced
5023e8a block/nvme: Add driver statistics for access alignment and hw errors

=== OUTPUT BEGIN ===
1/30 Checking commit 5023e8a8bf04 (block/nvme: Add driver statistics for access 
alignment and hw errors)
2/30 Checking commit cea6c96deb4e (libvhost-user: Allow vu_message_read to be 
replaced)
WARNING: Block comments use a leading /* on a separate line
#130: FILE: contrib/libvhost-user/libvhost-user.h:395:
+/* @read_msg: custom method to read vhost-user message

total: 0 errors, 1 warnings, 139 lines checked

Patch 2/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/30 Checking commit a70c2f01bb3f (libvhost-user: remove watch for kick_fd when 
de-initialize vu-dev)
4/30 Checking commit 9036dfc2c475 (util/vhost-user-server: generic vhost user 
server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

WARNING: line over 80 characters
#85: FILE: util/vhost-user-server.c:48:
+/* When this is set vu_client_trip will stop new processing vhost-user 
message */

total: 0 errors, 2 warnings, 500 lines checked

Patch 4/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/30 Checking commit 6ac349dc1fbf (block: move logical block size check 
function to a common utility function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 5/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/30 Checking commit ec6d467efa05 (block/export: vhost-user block device 
backend server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

WARNING: line over 80 characters
#474: FILE: block/export/vhost-user-blk-server.c:442:
+blk_remove_aio_context_notifier(vu_block_device->backend, 
blk_aio_attached,

ERROR: g_free(NULL) is safe this check is probably not required
#534: FILE: block/export/vhost-user-blk-server.c:502:
+if (vus->node_name) {
+g_free(vus->node_name);

total: 1 errors, 2 warnings, 714 lines checked

Patch 6/30 has style problems, 

Re: [PULL 00/30] Block patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201009193529.322822-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201009193529.322822-1-stefa...@redhat.com
Subject: [PULL 00/30] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201009193529.322822-1-stefa...@redhat.com -> 
patchew/20201009193529.322822-1-stefa...@redhat.com
Switched to a new branch 'test'
558aeb6 iotests: add commit top->base cases to 274
416e0aa block/io: fix bdrv_is_allocated_above
f7d6e64 block/io: bdrv_common_block_status_above: support bs == base
c44816a block/io: bdrv_common_block_status_above: support include_base
2be1d39 block/io: fix bdrv_co_block_status_above
e5ce70f tests/qtest: add multi-queue test case to vhost-user-blk-test
49bc904 block/export: add vhost-user-blk multi-queue support
9762d3d block/export: add iothread and fixed-iothread options
5d7df87 block: move block exports to libblockdev
ad289b0 qemu-storage-daemon: avoid compiling blockdev_ss twice
3c12eda util/vhost-user-server: use static library in meson.build
d2632bb util/vhost-user-server: move header to include/
65df69a block/export: convert vhost-user-blk server to block export API
063d99d block/export: report flush errors
f8dc04d util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
b4f0a4f util/vhost-user-server: check EOF when reading payload
c670f8a util/vhost-user-server: fix memory leak in vu_message_read()
1c0215a util/vhost-user-server: drop unused DevicePanicNotifier
95c5f38 block/export: consolidate request structs into VuBlockReq
12be4d6 util/vhost-user-server: drop unnecessary watch deletion
fb07eed util/vhost-user-server: drop unnecessary QOM cast
f4c201a util/vhost-user-server: s/fileds/fields/ typo fix
183b447 MAINTAINERS: Add vhost-user block device backend server maintainer
9037906 test: new qTest case to test the vhost-user-blk-server
709e271 block/export: vhost-user block device backend server
7098edb block: move logical block size check function to a common utility 
function
6116f4b util/vhost-user-server: generic vhost user server
a8a3fa5 libvhost-user: remove watch for kick_fd when de-initialize vu-dev
4f6e808 libvhost-user: Allow vu_message_read to be replaced
f4f9ed3 block/nvme: Add driver statistics for access alignment and hw errors

=== OUTPUT BEGIN ===
1/30 Checking commit f4f9ed389d75 (block/nvme: Add driver statistics for access 
alignment and hw errors)
2/30 Checking commit 4f6e8088ba93 (libvhost-user: Allow vu_message_read to be 
replaced)
WARNING: Block comments use a leading /* on a separate line
#130: FILE: contrib/libvhost-user/libvhost-user.h:395:
+/* @read_msg: custom method to read vhost-user message

total: 0 errors, 1 warnings, 139 lines checked

Patch 2/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/30 Checking commit a8a3fa52af0e (libvhost-user: remove watch for kick_fd when 
de-initialize vu-dev)
4/30 Checking commit 6116f4b2b35e (util/vhost-user-server: generic vhost user 
server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

WARNING: line over 80 characters
#85: FILE: util/vhost-user-server.c:48:
+/* When this is set vu_client_trip will stop new processing vhost-user 
message */

total: 0 errors, 2 warnings, 500 lines checked

Patch 4/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/30 Checking commit 7098edb0bce9 (block: move logical block size check 
function to a common utility function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 5/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/30 Checking commit 709e271eb771 (block/export: vhost-user block device 
backend server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

WARNING: line over 80 characters
#474: FILE: block/export/vhost-user-blk-server.c:442:
+blk_remove_aio_context_notifier(vu_block_device->backend, 
blk_aio_attached,

ERROR: g_free(NULL) is safe this check is probably not required
#534: FILE: block/export/vhost-user-blk-server.c:502:
+if (vus->node_name) {
+g_free(vus->node_name);

total: 1 errors, 2 warnings, 714 lines checked

Patch 6/30 has style problems, 

Re: [PATCH v8 00/17] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201007115700.707938-1-pbonz...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201007115700.707938-1-pbonz...@redhat.com
Subject: [PATCH v8 00/17] Fix scsi devices plug/unplug races w.r.t virtio-scsi 
iothread

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20201007115700.707938-1-pbonz...@redhat.com -> 
patchew/20201007115700.707938-1-pbonz...@redhat.com
Switched to a new branch 'test'
7e51a35 scsi/scsi_bus: fix races in REPORT LUNS
3ba554c virtio-scsi: use scsi_device_get
caa2894 scsi/scsi_bus: Add scsi_device_get
8d7483b scsi/scsi-bus: scsi_device_find: don't return unrealized devices
8002737 device-core: use atomic_set on .realized property
d91937f scsi: switch to bus->check_address
562a123 device-core: use RCU for list of children of a bus
6bc4617 device_core: use drain_call_rcu in in qmp_device_add
97fbf85 scsi/scsi_bus: switch search direction in scsi_device_find
bb3b68e qdev: add "check if address free" callback for buses
adf9e3e qemu-iotests, qtest: rewrite test 067 as a qtest
093627d qtest: check that drives are really appearing and disappearing
80856de qtest: switch users back to qtest_qmp_receive
c96d5f0 device-plug-test: use qtest_qmp to send the device_del command
f1f04d9 qtest: remove qtest_qmp_receive_success
1148ec4 qtest: Reintroduce qtest_qmp_receive
20e3183 qtest: rename qtest_qmp_receive to qtest_qmp_receive_dict

=== OUTPUT BEGIN ===
1/17 Checking commit 20e3183ecbd8 (qtest: rename qtest_qmp_receive to 
qtest_qmp_receive_dict)
2/17 Checking commit 1148ec4900a6 (qtest: Reintroduce qtest_qmp_receive)
3/17 Checking commit f1f04d9c2320 (qtest: remove qtest_qmp_receive_success)
4/17 Checking commit c96d5f0aa32b (device-plug-test: use qtest_qmp to send the 
device_del command)
WARNING: line over 80 characters
#33: FILE: tests/qtest/device-plug-test.c:23:
+ "{'execute': 'device_del', 'arguments': { 'id': %s } }", 
id);

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/17 Checking commit 80856deb548d (qtest: switch users back to 
qtest_qmp_receive)
6/17 Checking commit 093627d21203 (qtest: check that drives are really 
appearing and disappearing)
7/17 Checking commit adf9e3ea2b0c (qemu-iotests, qtest: rewrite test 067 as a 
qtest)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
deleted file mode 100755

WARNING: line over 80 characters
#646: FILE: tests/qtest/drive_del-test.c:19:
+static bool look_for_drive0(QTestState *qts, const char *command, const char 
*key)

total: 0 errors, 2 warnings, 308 lines checked

Patch 7/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/17 Checking commit bb3b68e3507e (qdev: add "check if address free" callback 
for buses)
9/17 Checking commit 97fbf857acae (scsi/scsi_bus: switch search direction in 
scsi_device_find)
10/17 Checking commit 6bc461779d34 (device_core: use drain_call_rcu in in 
qmp_device_add)
11/17 Checking commit 562a12390903 (device-core: use RCU for list of children 
of a bus)
12/17 Checking commit d91937ffcb2f (scsi: switch to bus->check_address)
ERROR: code indent should never use tabs
#55: FILE: hw/scsi/scsi-bus.c:137:
+^I^I^I^I int channel, int target, int lun,$

ERROR: code indent should never use tabs
#56: FILE: hw/scsi/scsi-bus.c:138:
+^I^I^I^I SCSIDevice **p_dev)$

WARNING: line over 80 characters
#71: FILE: hw/scsi/scsi-bus.c:153:
+static bool scsi_bus_check_address(BusState *qbus, DeviceState *qdev, Error 
**errp)

WARNING: line over 80 characters
#91: FILE: hw/scsi/scsi-bus.c:173:
+if (!scsi_bus_is_address_free(bus, dev->channel, dev->id, dev->lun, 
)) {

WARNING: line over 80 characters
#130: FILE: hw/scsi/scsi-bus.c:195:
+is_free = scsi_bus_is_address_free(bus, dev->channel, ++id, 
dev->lun, NULL);

WARNING: line over 80 characters
#143: FILE: hw/scsi/scsi-bus.c:205:
+is_free = scsi_bus_is_address_free(bus, dev->channel, dev->id, 
++lun, NULL);

total: 2 errors, 4 warnings, 182 lines checked

Patch 12/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/17 Checking commit 8002737303c9 (device-core: use atomic_set on .realized 
property)
14/17 Checking commit 8d7483be0fd9 (scsi/scsi-bus: scsi_device_find: don't 
return unrealized devices)

Re: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201006153636.2383248-1-phi...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201006153636.2383248-1-phi...@redhat.com
Subject: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20201006153636.2383248-1-phi...@redhat.com -> 
patchew/20201006153636.2383248-1-phi...@redhat.com
fatal: failed to write ref-pack file
fatal: The remote end hung up unexpectedly
Traceback (most recent call last):
  File "patchew-tester2/src/patchew-cli", line 531, in test_one
git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester2/src/patchew-cli", line 62, in git_clone_repo
subprocess.check_call(clone_cmd, stderr=logf, stdout=logf)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, 
in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'clone', '-q', 
'/home/patchew2/.cache/patchew-git-cache/httpsgithubcompatchewprojectqemu-3c8cf5a9c21ff8782164d1def7f44bd888713384',
 '/var/tmp/patchew-tester-tmp-ttyqifjv/src']' returned non-zero exit status 128.



The full log is available at
http://patchew.org/logs/20201006153636.2383248-1-phi...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v7 00/13] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201006123904.610658-1-mlevi...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20201006123904.610658-1-mlevi...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [RFC PATCH 0/3] qom: Fix missing interface in qemu-storage-daemon

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20201005105442.2093105-1-phi...@redhat.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20201005105442.2093105-1-phi...@redhat.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/4] assorted gcc 10/fedora32 compile warning fixes

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200930155859.303148-1-borntrae...@de.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200930155859.303148-1-borntrae...@de.ibm.com
Subject: [PATCH 0/4] assorted gcc 10/fedora32 compile warning fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20200930043150.1454766-1-js...@redhat.com -> 
patchew/20200930043150.1454766-1-js...@redhat.com
 - [tag update]  patchew/20200930095321.2006-1-zhaolich...@huawei.com -> 
patchew/20200930095321.2006-1-zhaolich...@huawei.com
 - [tag update]  patchew/20200930151616.3588165-1-mky...@tachyum.com -> 
patchew/20200930151616.3588165-1-mky...@tachyum.com
 - [tag update]  patchew/20200930155859.303148-1-borntrae...@de.ibm.com -> 
patchew/20200930155859.303148-1-borntrae...@de.ibm.com
 * [new tag] patchew/20200930164949.1425294-1-phi...@redhat.com -> 
patchew/20200930164949.1425294-1-phi...@redhat.com
fatal: failed to write ref-pack file
fatal: The remote end hung up unexpectedly
Traceback (most recent call last):
  File "patchew-tester/src/patchew-cli", line 521, in test_one
git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester/src/patchew-cli", line 53, in git_clone_repo
subprocess.check_call(clone_cmd, stderr=logf, stdout=logf)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, 
in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'clone', '-q', 
'/home/patchew/.cache/patchew-git-cache/httpsgithubcompatchewprojectqemu-3c8cf5a9c21ff8782164d1def7f44bd888713384',
 '/var/tmp/patchew-tester-tmp-529h9bha/src']' returned non-zero exit status 128.



The full log is available at
http://patchew.org/logs/20200930155859.303148-1-borntrae...@de.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/2] hw/block/m25p80: Fix Numonyx flash dummy cycle register behavior

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1601425716-204629-1-git-send-email-koml...@xilinx.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/1601425716-204629-1-git-send-email-koml...@xilinx.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v9 0/9] Apply COR-filter to the block-stream permanently

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1601298001-774096-1-git-send-email-andrey.shinkev...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C linker for the host machine: cc ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:10: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
Compiling C object libblock.fa.p/block_dmg-bz2.c.o
Compiling C object libblock.fa.p/block_amend.c.o
Compiling C object libblock.fa.p/block_qcow2-snapshot.c.o
../src/block/copy-on-read.c:29:32: fatal error: block/copy-on-read.h: No such 
file or directory
 #include "block/copy-on-read.h"
^
compilation terminated.
---
Compiling C object libblock.fa.p/block_throttle-groups.c.o
Compiling C object libblock.fa.p/block_accounting.c.o
Compiling C object libblock.fa.p/block_nbd.c.o
make: *** [libblock.fa.p/block_copy-on-read.c.o] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--rm', 
'--label', 'com.qemu.instance.uuid=b2dcb88c84fa430991604513a90c8435', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '-e', 'TARGET_LIST=', '-e', 
'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-8zvp7iz2/src/docker-src.2020-09-28-16.33.58.15775:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=b2dcb88c84fa430991604513a90c8435
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-8zvp7iz2/src'
make: *** [docker-run-test-quick@centos7] Error 2

real3m24.503s
user0m18.816s


The full log is available at
http://patchew.org/logs/1601298001-774096-1-git-send-email-andrey.shinkev...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v9 0/9] Apply COR-filter to the block-stream permanently

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1601298001-774096-1-git-send-email-andrey.shinkev...@virtuozzo.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

Host machine cpu: x86_64
Target machine cpu family: x86
Target machine cpu: x86_64
../src/meson.build:10: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
Compiling C object libblock.fa.p/block_bochs.c.obj
Compiling C object libblock.fa.p/block_filter-compress.c.obj
Compiling C object libblock.fa.p/block_qcow2.c.obj
../src/block/copy-on-read.c:29:10: fatal error: block/copy-on-read.h: No such 
file or directory
   29 | #include "block/copy-on-read.h"
  |  ^~
compilation terminated.
make: *** [Makefile.ninja:887: libblock.fa.p/block_copy-on-read.c.obj] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--rm', 
'--label', 'com.qemu.instance.uuid=026d51a22d8649ff831a9ab8a970', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '-e', 'TARGET_LIST=', '-e', 
'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-_5yio3yh/src/docker-src.2020-09-28-16.28.55.8469:/var/tmp/qemu:z,ro',
 'qemu/fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=026d51a22d8649ff831a9ab8a970
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-_5yio3yh/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real4m33.430s
user0m18.970s


The full log is available at
http://patchew.org/logs/1601298001-774096-1-git-send-email-andrey.shinkev...@virtuozzo.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200924204516.1881843-1-...@irrelevant.dk/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200924204516.1881843-1-...@irrelevant.dk
Subject: [PATCH 00/16] hw/block/nvme: zoned namespace command set

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a59b4bb hw/block/nvme: support reset/finish recommended limits
83d78bf hw/block/nvme: support zone active excursions
eb9852e hw/block/nvme: allow open to close transitions by controller
4018228 hw/block/nvme: track and enforce zone resources
3f934e8 hw/block/nvme: add the zone append command
6343d89 hw/block/nvme: add the zone management send command
a527eef hw/block/nvme: add the zone management receive command
fd032f9 hw/block/nvme: add basic read/write for zoned namespaces
aef6511 hw/block/nvme: support namespace types
ab4c119 hw/block/nvme: add commands supported and effects log page
3eb56a0 hw/block/nvme: add support for dulbe and block utilization tracking
b532fe0 hw/block/nvme: consolidate read, write and write zeroes
e992082 hw/block/nvme: reject io commands if only admin command set selected
8a19e08 hw/block/nvme: make lba data size configurable
3edfb11 hw/block/nvme: add trace event for requests with non-zero status code
8de0031 hw/block/nvme: add nsid to get/setfeat trace events

=== OUTPUT BEGIN ===
1/16 Checking commit 8de00318317d (hw/block/nvme: add nsid to get/setfeat trace 
events)
2/16 Checking commit 3edfb1110713 (hw/block/nvme: add trace event for requests 
with non-zero status code)
3/16 Checking commit 8a19e08afeb7 (hw/block/nvme: make lba data size 
configurable)
4/16 Checking commit e992082bb9bf (hw/block/nvme: reject io commands if only 
admin command set selected)
5/16 Checking commit b532fe07a157 (hw/block/nvme: consolidate read, write and 
write zeroes)
6/16 Checking commit 3eb56a0748fb (hw/block/nvme: add support for dulbe and 
block utilization tracking)
7/16 Checking commit ab4c119d9d68 (hw/block/nvme: add commands supported and 
effects log page)
ERROR: Macros with complex values should be enclosed in parenthesis
#46: FILE: hw/block/nvme.c:131:
+#define NVME_EFFECTS_NVM_INITIALIZER   \
+[NVME_CMD_FLUSH]= NVME_EFFECTS_CSUPP | \
+  NVME_EFFECTS_LBCC,   \
+[NVME_CMD_WRITE]= NVME_EFFECTS_CSUPP | \
+  NVME_EFFECTS_LBCC,   \
+[NVME_CMD_READ] = NVME_EFFECTS_CSUPP,  \
+[NVME_CMD_WRITE_ZEROES] = NVME_EFFECTS_CSUPP | \
+  NVME_EFFECTS_LBCC

total: 1 errors, 0 warnings, 149 lines checked

Patch 7/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/16 Checking commit aef6511be82b (hw/block/nvme: support namespace types)
9/16 Checking commit fd032f918b37 (hw/block/nvme: add basic read/write for 
zoned namespaces)
10/16 Checking commit a527eef9b9fe (hw/block/nvme: add the zone management 
receive command)
11/16 Checking commit 6343d89bf734 (hw/block/nvme: add the zone management send 
command)
WARNING: Block comments use a leading /* on a separate line
#66: FILE: hw/block/nvme.c:1118:
+return __nvme_allocate(ns, slba, nlb, false /* deallocate */);

WARNING: Block comments use a leading /* on a separate line
#77: FILE: hw/block/nvme.c:1129:
+return __nvme_allocate(ns, slba, nlb, true /* deallocate */);

total: 0 errors, 2 warnings, 704 lines checked

Patch 11/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/16 Checking commit 3f934e89564a (hw/block/nvme: add the zone append command)
13/16 Checking commit 40182287d15e (hw/block/nvme: track and enforce zone 
resources)
14/16 Checking commit eb9852ee9c0f (hw/block/nvme: allow open to close 
transitions by controller)
15/16 Checking commit 83d78bf53392 (hw/block/nvme: support zone active 
excursions)
16/16 Checking commit a59b4bb2c855 (hw/block/nvme: support reset/finish 
recommended limits)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200924204516.1881843-1-...@irrelevant.dk/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v7 0/5] fix & merge block_status_above and is_allocated_above

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200924194003.22080-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C linker for the host machine: cc ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:10: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11406: 
ordinal not in range(128)
Generating 'libqemu-aarch64-softmmu.fa.p/decode-neon-shared.c.inc'.
make: *** [block/block-gen.c.stamp] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--rm', 
'--label', 'com.qemu.instance.uuid=528b329e049d459c994676e3ba6dc69a', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '-e', 'TARGET_LIST=', '-e', 
'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-e72243g9/src/docker-src.2020-09-24-17.42.11.20907:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=528b329e049d459c994676e3ba6dc69a
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-e72243g9/src'
make: *** [docker-run-test-quick@centos7] Error 2

real3m12.373s
user0m16.084s


The full log is available at
http://patchew.org/logs/20200924194003.22080-1-vsement...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v9 0/7] coroutines: generate wrapper code

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200924185414.28642-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C linker for the host machine: cc ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:10: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11406: 
ordinal not in range(128)
Generating 'libqemu-aarch64-softmmu.fa.p/decode-vfp-uncond.c.inc'.
make: *** [block/block-gen.c.stamp] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--rm', 
'--label', 'com.qemu.instance.uuid=ea922a0a6ce34dfc90f59bf1b059b9d5', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '-e', 'TARGET_LIST=', '-e', 
'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-rctf_xsm/src/docker-src.2020-09-24-16.29.53.14429:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=ea922a0a6ce34dfc90f59bf1b059b9d5
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-rctf_xsm/src'
make: *** [docker-run-test-quick@centos7] Error 2

real3m4.047s
user0m21.648s


The full log is available at
http://patchew.org/logs/20200924185414.28642-1-vsement...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block exports

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200924152717.287415-1-kw...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200924152717.287415-1-kw...@redhat.com
Subject: [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block 
exports

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   c122bca..f7f1d91  master -> master
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200924152717.287415-1-kw...@redhat.com -> 
patchew/20200924152717.287415-1-kw...@redhat.com
Switched to a new branch 'test'
772bb89 iotests: Test block-export-* QMP interface
a89a8b7 iotests: Allow supported and unsupported formats at the same time
fd15df6 iotests: Introduce qemu_nbd_list_log()
7fe6af5 iotests: Factor out qemu_tool_pipe_and_status()
67144d8 nbd: Deprecate nbd-server-add/remove
81170eb nbd: Merge nbd_export_new() and nbd_export_create()
2c8869b block/export: Move writable to BlockExportOptions
63951c4 block/export: Add query-block-exports
7f1940a block/export: Create BlockBackend in blk_exp_add()
c20f5f0 block/export: Move blk to BlockExport
46c45ed block/export: Add BLOCK_EXPORT_DELETED event
549525b block/export: Add block-export-del
deb98e0 block/export: Move strong user reference to block_exports
ad75b22 block/export: Add 'id' option to block-export-add
ffadf38 block/export: Add blk_exp_close_all(_type)
1da2124 block/export: Allocate BlockExport in blk_exp_add()
602df28 block/export: Add node-name to BlockExportOptions
b1fc3ff block/export: Move AioContext from NBDExport to BlockExport
a5d275f block/export: Move refcount from NBDExport to BlockExport
650f2eb nbd/server: Simplify export shutdown
634dc2f qemu-nbd: Use blk_exp_add() to create the export
3e1f7cf nbd: Remove NBDExport.close callback
3a41880 nbd: Add writethrough to block-export-add
f990833 nbd: Add max-connections to nbd-server-start
de1c397 block/export: Remove magic from block-export-add
9bc13b8 qemu-nbd: Use raw block driver for --offset
8eb933e qemu-storage-daemon: Use qmp_block_export_add()
38a4b01 block/export: Add BlockExport infrastructure and block-export-add
66aff14 qapi: Rename BlockExport to BlockExportOptions
026ac5d qapi: Create block-export module
b1715f6 nbd: Remove unused nbd_export_get_blockdev()

=== OUTPUT BEGIN ===
1/31 Checking commit b1715f628199 (nbd: Remove unused nbd_export_get_blockdev())
2/31 Checking commit 026ac5dda678 (qapi: Create block-export module)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#231: 
new file mode 100644

total: 0 errors, 1 warnings, 410 lines checked

Patch 2/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/31 Checking commit 66aff14308cb (qapi: Rename BlockExport to 
BlockExportOptions)
4/31 Checking commit 38a4b017ec72 (block/export: Add BlockExport infrastructure 
and block-export-add)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

ERROR: "(foo*)" should be "(foo *)"
#156: FILE: blockdev-nbd.c:224:
+return (BlockExport*) exp;

total: 1 errors, 1 warnings, 247 lines checked

Patch 4/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/31 Checking commit 8eb933e1e3f7 (qemu-storage-daemon: Use 
qmp_block_export_add())
6/31 Checking commit 9bc13b8dba46 (qemu-nbd: Use raw block driver for --offset)
7/31 Checking commit de1c39724d9e (block/export: Remove magic from 
block-export-add)
8/31 Checking commit f99083319892 (nbd: Add max-connections to nbd-server-start)
9/31 Checking commit 3a418807fc14 (nbd: Add writethrough to block-export-add)
10/31 Checking commit 3e1f7cf80488 (nbd: Remove NBDExport.close callback)
11/31 Checking commit 634dc2f6f2ec (qemu-nbd: Use blk_exp_add() to create the 
export)
12/31 Checking commit 650f2eba0db8 (nbd/server: Simplify export shutdown)
13/31 Checking commit a5d275f4c538 (block/export: Move refcount from NBDExport 
to BlockExport)
ERROR: "(foo*)" should be "(foo *)"
#49: FILE: blockdev-nbd.c:239:
+blk_exp_unref((BlockExport*) exp);

total: 1 errors, 0 warnings, 214 lines checked

Patch 13/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/31 Checking commit b1fc3ffc0ccd (block/export: Move AioContext from 
NBDExport to BlockExport)
15/31 Checking commit 602df286881c (block/export: Add node-name to 
BlockExportOptions)
16/31 Checking commit 1da2124e164e (block/export: Allocate BlockExport in 
blk_exp_add())
17/31 Checking 

Re: [PULL 00/13] Block patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200923161031.69474-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200923161031.69474-1-stefa...@redhat.com
Subject: [PULL 00/13] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200923161031.69474-1-stefa...@redhat.com -> 
patchew/20200923161031.69474-1-stefa...@redhat.com
Switched to a new branch 'test'
4bf3742 qemu/atomic.h: rename atomic_ to qatomic_
8cecbb3 tests: add test-fdmon-epoll
8df4df8 fdmon-poll: reset npfd when upgrading to fdmon-epoll
825386c gitmodules: add qemu.org vbootrom submodule
5cae6f8 gitmodules: switch to qemu.org meson mirror
98349d3 gitmodules: switch to qemu.org qboot mirror
5f9d298 docs/system: clarify deprecation schedule
b431c3a virtio-crypto: don't modify elem->in/out_sg
c1f9691 virtio-blk: undo destructive iov_discard_*() operations
4182d4f util/iov: add iov_discard_undo()
a59a839 virtio: add vhost-user-fs-ccw device
0d23a8c libvhost-user: handle endianness as mandated by the spec
3167d81 MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer

=== OUTPUT BEGIN ===
1/13 Checking commit 3167d818e62a (MAINTAINERS: add Stefan Hajnoczi as 
block/nvme.c maintainer)
2/13 Checking commit 0d23a8ccd2a9 (libvhost-user: handle endianness as mandated 
by the spec)
WARNING: line over 80 characters
#53: FILE: contrib/libvhost-user/libvhost-user.c:548:
+vu_panic(dev, "virtio legacy devices aren't supported by 
libvhost-user");

total: 0 errors, 1 warnings, 217 lines checked

Patch 2/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/13 Checking commit a59a839e1d76 (virtio: add vhost-user-fs-ccw device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 82 lines checked

Patch 3/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit 4182d4f76678 (util/iov: add iov_discard_undo())
5/13 Checking commit c1f96917a3f1 (virtio-blk: undo destructive iov_discard_*() 
operations)
6/13 Checking commit b431c3a4b415 (virtio-crypto: don't modify elem->in/out_sg)
7/13 Checking commit 5f9d298c71ad (docs/system: clarify deprecation schedule)
8/13 Checking commit 98349d316498 (gitmodules: switch to qemu.org qboot mirror)
9/13 Checking commit 5cae6f86bb22 (gitmodules: switch to qemu.org meson mirror)
10/13 Checking commit 825386c4f0f2 (gitmodules: add qemu.org vbootrom submodule)
11/13 Checking commit 8df4df890bf1 (fdmon-poll: reset npfd when upgrading to 
fdmon-epoll)
12/13 Checking commit 8cecbb39509f (tests: add test-fdmon-epoll)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 89 lines checked

Patch 12/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/13 Checking commit 4bf37426ff03 (qemu/atomic.h: rename atomic_ to qatomic_)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#2800: FILE: include/qemu/atomic.h:152:
+#define qatomic_rcu_read__nocheck(ptr, valptr)   \
+__atomic_load(ptr, valptr, __ATOMIC_RELAXED);\
 smp_read_barrier_depends();

ERROR: space required before that '*' (ctx:VxB)
#2945: FILE: include/qemu/atomic.h:333:
+#define qatomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile*) (p))
^

ERROR: Use of volatile is usually wrong, please add a comment
#2945: FILE: include/qemu/atomic.h:333:
+#define qatomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile*) (p))

ERROR: space required before that '*' (ctx:VxB)
#2946: FILE: include/qemu/atomic.h:334:
+#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile*) (p)) = (i))
 ^

ERROR: Use of volatile is usually wrong, please add a comment
#2946: FILE: include/qemu/atomic.h:334:
+#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile*) (p)) = (i))

ERROR: space required after that ',' (ctx:VxV)
#2951: FILE: include/qemu/atomic.h:337:
+#define qatomic_set(ptr, i) qatomic_set__nocheck(ptr,i)
 ^

ERROR: memory barrier without comment
#3023: FILE: include/qemu/atomic.h:395:
+#define qatomic_xchg(ptr, i)(smp_mb(), __sync_lock_test_and_set(ptr, i))

WARNING: Block comments use a 

Re: [PATCH v3] qemu/atomic.h: rename atomic_ to qatomic_

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200923105646.47864-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200923105646.47864-1-stefa...@redhat.com
Subject: [PATCH v3] qemu/atomic.h: rename atomic_ to qatomic_

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20200922210101.4081073-1-js...@redhat.com -> 
patchew/20200922210101.4081073-1-js...@redhat.com
 * [new tag] patchew/20200923113900.72718-1-da...@redhat.com -> 
patchew/20200923113900.72718-1-da...@redhat.com
 * [new tag] patchew/20200923131829.3849-1-erich.mcmil...@hp.com -> 
patchew/20200923131829.3849-1-erich.mcmil...@hp.com
Switched to a new branch 'test'
07abb8e qemu/atomic.h: rename atomic_ to qatomic_

=== OUTPUT BEGIN ===
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#2797: FILE: include/qemu/atomic.h:152:
+#define qatomic_rcu_read__nocheck(ptr, valptr)   \
+__atomic_load(ptr, valptr, __ATOMIC_RELAXED);\
 smp_read_barrier_depends();

ERROR: space required before that '*' (ctx:VxB)
#2942: FILE: include/qemu/atomic.h:333:
+#define qatomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile*) (p))
^

ERROR: Use of volatile is usually wrong, please add a comment
#2942: FILE: include/qemu/atomic.h:333:
+#define qatomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile*) (p))

ERROR: space required before that '*' (ctx:VxB)
#2943: FILE: include/qemu/atomic.h:334:
+#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile*) (p)) = (i))
 ^

ERROR: Use of volatile is usually wrong, please add a comment
#2943: FILE: include/qemu/atomic.h:334:
+#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile*) (p)) = (i))

ERROR: space required after that ',' (ctx:VxV)
#2948: FILE: include/qemu/atomic.h:337:
+#define qatomic_set(ptr, i) qatomic_set__nocheck(ptr,i)
 ^

ERROR: memory barrier without comment
#3020: FILE: include/qemu/atomic.h:395:
+#define qatomic_xchg(ptr, i)(smp_mb(), __sync_lock_test_and_set(ptr, i))

WARNING: Block comments use a leading /* on a separate line
#3094: FILE: include/qemu/atomic.h:447:
+/* qatomic_mb_read/set semantics map Java volatile variables. They are

WARNING: Block comments use a leading /* on a separate line
#6177: FILE: util/bitmap.c:214:
+/* If we avoided the full barrier in qatomic_or(), issue a

WARNING: Block comments use a leading /* on a separate line
#7192: FILE: util/rcu.c:85:
+/* Instead of using qatomic_mb_set for index->waiting, and

WARNING: Block comments use a leading /* on a separate line
#7218: FILE: util/rcu.c:154:
+/* In either case, the qatomic_mb_set below blocks stores that free

total: 7 errors, 4 warnings, 6267 lines checked

Commit 07abb8e79dbe (qemu/atomic.h: rename atomic_ to qatomic_) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200923105646.47864-1-stefa...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/2] block: deprecate the sheepdog driver

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200922161611.2049616-1-berra...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200922161611.2049616-1-berra...@redhat.com
Subject: [PATCH v2 0/2] block: deprecate the sheepdog driver

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
2c11635 block: deprecate the sheepdog block driver
aa3d54c block: drop moderated sheepdog mailing list from MAINTAINERS file

=== OUTPUT BEGIN ===
1/2 Checking commit aa3d54cfa28f (block: drop moderated sheepdog mailing list 
from MAINTAINERS file)
2/2 Checking commit 2c1163558579 (block: deprecate the sheepdog block driver)
ERROR: do not initialise statics to 0 or NULL
#54: FILE: block/sheepdog.c:247:
+static bool warned = false;

total: 1 errors, 0 warnings, 71 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200922161611.2049616-1-berra...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2] qemu/atomic.h: prefix qemu_ to solve collisions

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200922085838.230505-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200922085838.230505-1-stefa...@redhat.com
Subject: [PATCH v2] qemu/atomic.h: prefix qemu_ to solve  
collisions

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200922085838.230505-1-stefa...@redhat.com -> 
patchew/20200922085838.230505-1-stefa...@redhat.com
Switched to a new branch 'test'
1e6457d qemu/atomic.h: prefix qemu_ to solve  collisions

=== OUTPUT BEGIN ===
WARNING: Block comments use a trailing */ on a separate line
#2501: FILE: hw/virtio/vhost.c:92:
+ * but it's easier to use qemu_atomic_* than roll our own. */

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#2973: FILE: include/qemu/atomic.h:152:
+#define qemu_atomic_rcu_read__nocheck(ptr, valptr)  \
 __atomic_load(ptr, valptr, __ATOMIC_RELAXED);   \
 smp_read_barrier_depends();

ERROR: space required before that '*' (ctx:VxB)
#3128: FILE: include/qemu/atomic.h:347:
+#define qemu_atomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p))
  ^

ERROR: Use of volatile is usually wrong, please add a comment
#3128: FILE: include/qemu/atomic.h:347:
+#define qemu_atomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p))

ERROR: space required before that '*' (ctx:VxB)
#3130: FILE: include/qemu/atomic.h:349:
+((*(__typeof__(*(p)) volatile*) (p)) = (i))
  ^

ERROR: Use of volatile is usually wrong, please add a comment
#3130: FILE: include/qemu/atomic.h:349:
+((*(__typeof__(*(p)) volatile*) (p)) = (i))

ERROR: space required after that ',' (ctx:VxV)
#3135: FILE: include/qemu/atomic.h:352:
+#define qemu_atomic_set(ptr, i) qemu_atomic_set__nocheck(ptr,i)
 ^

ERROR: memory barrier without comment
#3210: FILE: include/qemu/atomic.h:410:
+#define qemu_atomic_xchg(ptr, i) (smp_mb(), __sync_lock_test_and_set(ptr, i))

WARNING: Block comments use a leading /* on a separate line
#3285: FILE: include/qemu/atomic.h:462:
+/* qemu_atomic_mb_read/set semantics map Java volatile variables. They are

WARNING: Block comments use a leading /* on a separate line
#6402: FILE: util/bitmap.c:214:
+/* If we avoided the full barrier in qemu_atomic_or(), issue a

WARNING: Block comments use a leading /* on a separate line
#7438: FILE: util/rcu.c:85:
+/* Instead of using qemu_atomic_mb_set for index->waiting, and

WARNING: Block comments use a leading /* on a separate line
#7464: FILE: util/rcu.c:154:
+/* In either case, the qemu_atomic_mb_set below blocks stores that free

total: 7 errors, 5 warnings, 6520 lines checked

Commit 1e6457dfb499 (qemu/atomic.h: prefix qemu_ to solve  
collisions) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200922085838.230505-1-stefa...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200922083821.578519-1-phi...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200922083821.578519-1-phi...@redhat.com
Subject: [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove 
magic from nvme_init

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  
patchew/1600485023-263643-1-git-send-email-lei@intel.com -> 
patchew/1600485023-263643-1-git-send-email-lei@intel.com
 - [tag update]  patchew/20200918092203.20384-1-chen.zh...@intel.com -> 
patchew/20200918092203.20384-1-chen.zh...@intel.com
 - [tag update]  patchew/20200921144957.979989-1-lviv...@redhat.com -> 
patchew/20200921144957.979989-1-lviv...@redhat.com
 - [tag update]  patchew/20200921174320.46062-1-th...@redhat.com -> 
patchew/20200921174320.46062-1-th...@redhat.com
 - [tag update]  patchew/20200921221045.699690-1-ehabk...@redhat.com -> 
patchew/20200921221045.699690-1-ehabk...@redhat.com
 * [new tag] patchew/20200922083821.578519-1-phi...@redhat.com -> 
patchew/20200922083821.578519-1-phi...@redhat.com
Switched to a new branch 'test'
ba5ba7b block/nvme: Replace magic value by SCALE_MS definition
7975c85 block/nvme: Use register definitions from 'block/nvme.h'
0ce328b block/nvme: Drop NVMeRegs structure, directly use NvmeBar
554f68e block/nvme: Reduce I/O registers scope
5cfb159 block/nvme: Map doorbells pages write-only
2064703 util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar()

=== OUTPUT BEGIN ===
1/6 Checking commit 2064703ff8dc (util/vfio-helpers: Pass page protections to 
qemu_vfio_pci_map_bar())
2/6 Checking commit 5cfb15932539 (block/nvme: Map doorbells pages write-only)
3/6 Checking commit 554f68e25abc (block/nvme: Reduce I/O registers scope)
4/6 Checking commit 0ce328b78083 (block/nvme: Drop NVMeRegs structure, directly 
use NvmeBar)
ERROR: Use of volatile is usually wrong, please add a comment
#43: FILE: block/nvme.c:692:
+volatile NvmeBar *regs = NULL;

total: 1 errors, 0 warnings, 62 lines checked

Patch 4/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/6 Checking commit 7975c85b3904 (block/nvme: Use register definitions from 
'block/nvme.h')
6/6 Checking commit ba5ba7b65742 (block/nvme: Replace magic value by SCALE_MS 
definition)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200922083821.578519-1-phi...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200921162949.553863-1-phi...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C linker for the host machine: cc ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:10: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
Compiling C object authz/libauthz.fa.p/listfile.c.o
Compiling C object authz/libauthz.fa.p/list.c.o
../src/block/nvme.c: In function 'nvme_file_open':
../src/block/nvme.c:807:8: error: 'regs' may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
 if (regs) {
^
../src/block/nvme.c:692:23: note: 'regs' was declared here
 volatile NvmeBar *regs;
   ^
cc1: all warnings being treated as errors
make: *** [libblock.fa.p/block_nvme.c.o] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--rm', 
'--label', 'com.qemu.instance.uuid=99233811d86a42b1b27aa376bb85979d', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '-e', 'TARGET_LIST=', '-e', 
'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-wu686lwl/src/docker-src.2020-09-21-17.52.21.21740:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=99233811d86a42b1b27aa376bb85979d
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-wu686lwl/src'
make: *** [docker-run-test-quick@centos7] Error 2

real3m46.350s
user0m15.940s


The full log is available at
http://patchew.org/logs/20200921162949.553863-1-phi...@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200921162949.553863-1-phi...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200921162949.553863-1-phi...@redhat.com
Subject: [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic 
from nvme_init

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b0ef8b7 block/nvme: Replace magic value by SCALE_MS definition
1792c4d block/nvme: Use register definitions from 'block/nvme.h'
352be0c block/nvme: Drop NVMeRegs structure, directly use NvmeBar
7aa184a block/nvme: Reduce I/O registers scope
4b1effc block/nvme: Map doorbells pages write-only
7ae4653 util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar()

=== OUTPUT BEGIN ===
1/6 Checking commit 7ae46536369a (util/vfio-helpers: Pass page protections to 
qemu_vfio_pci_map_bar())
2/6 Checking commit 4b1effcfcd2b (block/nvme: Map doorbells pages write-only)
3/6 Checking commit 7aa184a756dc (block/nvme: Reduce I/O registers scope)
4/6 Checking commit 352be0c97869 (block/nvme: Drop NVMeRegs structure, directly 
use NvmeBar)
ERROR: Use of volatile is usually wrong, please add a comment
#43: FILE: block/nvme.c:692:
+volatile NvmeBar *regs;

total: 1 errors, 0 warnings, 62 lines checked

Patch 4/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/6 Checking commit 1792c4da4bc2 (block/nvme: Use register definitions from 
'block/nvme.h')
6/6 Checking commit b0ef8b776eb1 (block/nvme: Replace magic value by SCALE_MS 
definition)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200921162949.553863-1-phi...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200921162346.188997-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200921162346.188997-1-stefa...@redhat.com
Subject: [PATCH] qemu/atomic.h: prefix qemu_ to solve  collisions

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]  patchew/20200918103430.297167-1-th...@redhat.com -> 
patchew/20200918103430.297167-1-th...@redhat.com
Switched to a new branch 'test'
25ca702 qemu/atomic.h: prefix qemu_ to solve  collisions

=== OUTPUT BEGIN ===
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#2968: FILE: include/qemu/atomic.h:152:
+#define qemu_atomic_rcu_read__nocheck(ptr, valptr)  \
 __atomic_load(ptr, valptr, __ATOMIC_RELAXED);   \
 smp_read_barrier_depends();

ERROR: space required before that '*' (ctx:VxB)
#3123: FILE: include/qemu/atomic.h:347:
+#define qemu_atomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p))
  ^

ERROR: Use of volatile is usually wrong, please add a comment
#3123: FILE: include/qemu/atomic.h:347:
+#define qemu_atomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p))

ERROR: space required before that '*' (ctx:VxB)
#3125: FILE: include/qemu/atomic.h:349:
+((*(__typeof__(*(p)) volatile*) (p)) = (i))
  ^

ERROR: Use of volatile is usually wrong, please add a comment
#3125: FILE: include/qemu/atomic.h:349:
+((*(__typeof__(*(p)) volatile*) (p)) = (i))

ERROR: space required after that ',' (ctx:VxV)
#3130: FILE: include/qemu/atomic.h:352:
+#define qemu_atomic_set(ptr, i) qemu_atomic_set__nocheck(ptr,i)
 ^

ERROR: memory barrier without comment
#3205: FILE: include/qemu/atomic.h:410:
+#define qemu_atomic_xchg(ptr, i) (smp_mb(), __sync_lock_test_and_set(ptr, i))

WARNING: Block comments use a leading /* on a separate line
#3280: FILE: include/qemu/atomic.h:462:
+/* qemu_atomic_mb_read/set semantics map Java volatile variables. They are

WARNING: Block comments use a leading /* on a separate line
#6394: FILE: util/bitmap.c:214:
+/* If we avoided the full barrier in qemu_atomic_or(), issue a

WARNING: Block comments use a leading /* on a separate line
#7430: FILE: util/rcu.c:85:
+/* Instead of using qemu_atomic_mb_set for index->waiting, and

WARNING: Block comments use a leading /* on a separate line
#7456: FILE: util/rcu.c:154:
+/* In either case, the qemu_atomic_mb_set below blocks stores that free

total: 7 errors, 4 warnings, 6507 lines checked

Commit 25ca7029b2f2 (qemu/atomic.h: prefix qemu_ to solve  
collisions) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200921162346.188997-1-stefa...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200918153514.330705-1-th...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20200918153514.330705-1-th...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] xen: rework pci_piix3_xen_ide_unplug

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200918145256.1886250-1-anthony.per...@citrix.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20200918145256.1886250-1-anthony.per...@citrix.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 00/13] block: deal with errp: part I

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200917195519.19589-1-vsement...@virtuozzo.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.






The full log is available at
http://patchew.org/logs/20200917195519.19589-1-vsement...@virtuozzo.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v9 00/26] W32, W64 msys2/mingw patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200915121318.247-1-luoyongg...@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200915121318.247-1-luoyongg...@gmail.com
Subject: [PATCH v9 00/26] W32, W64 msys2/mingw patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200915121318.247-1-luoyongg...@gmail.com -> 
patchew/20200915121318.247-1-luoyongg...@gmail.com
Switched to a new branch 'test'
0b113c6 block: enable libnfs on msys2/mingw in cirrus.yml
948c78c block: Fixes nfs compiling error on msys2/mingw
083ce32 ci: Enable msys2 ci in cirrus
bc69278 meson: upgrade meson for execute custom ninjatool under msys2 properly
fef8a0c rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full
58f2e78 tests: Fixes test-qdev-global-props.c
4a17a57 tests: fix test-util-sockets.c
6d2b926 tests: Fixes test-io-channel-file by mask only owner file state mask 
bits
e170301 tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence 
with aio-posix.c
95d2579 tests: Fixes test-io-channel-socket.c tests under msys2/mingw
7e27f27 tests: Convert g_free to g_autofree macro in test-logging.c
07bddec cirrus: Building freebsd in a single short
ae61ebd vmstate: Fixes test-vmstate.c on msys2/mingw
787eeb4 meson: remove empty else and duplicated gio deps
ad29b42 tests: Enable crypto tests under msys2/mingw
eb97064 gcrypt: test_tls_psk_init should write binary file instead text file.
7ebfac6 meson: Use -b to ignore CR vs. CR-LF issues on Windows
6c6166c osdep: file locking functions are not available on Win32
5ae548a tests: test-replication disable /replication/secondary/* on msys2/mingw.
74a6589 tests: Fixes test-replication.c on msys2/mingw.
4a06ce7 tests: disable /char/stdio/* tests in test-char.c on win32
1c1fb53 curses: Fixes curses compiling errors.
bbfe966 win32: Simplify gmtime_r detection direct base on 
_POSIX_THREAD_SAFE_FUNCTIONS.
588c2f6 configure: Fixes ncursesw detection under msys2/mingw and enable curses
44ed485 ci: fixes msys2 build by upgrading capstone to 4.0.2
2f25baf rcu: Implement drain_call_rcu

=== OUTPUT BEGIN ===
1/26 Checking commit 2f25baf35413 (rcu: Implement drain_call_rcu)
2/26 Checking commit 44ed4856e1ef (ci: fixes msys2 build by upgrading capstone 
to 4.0.2)
3/26 Checking commit 588c2f6c1827 (configure: Fixes ncursesw detection under 
msys2/mingw and enable curses)
4/26 Checking commit bbfe966b472f (win32: Simplify gmtime_r detection direct 
base on _POSIX_THREAD_SAFE_FUNCTIONS.)
5/26 Checking commit 1c1fb5366733 (curses: Fixes curses compiling errors.)
6/26 Checking commit 4a06ce772c82 (tests: disable /char/stdio/* tests in 
test-char.c on win32)
WARNING: line over 80 characters
#60: FILE: tests/test-char.c:1474:
+g_test_add_func("/char/console/subprocess", 
char_console_test_subprocess);

total: 0 errors, 1 warnings, 56 lines checked

Patch 6/26 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/26 Checking commit 74a6589a34e0 (tests: Fixes test-replication.c on 
msys2/mingw.)
8/26 Checking commit 5ae548ac2ff9 (tests: test-replication disable 
/replication/secondary/* on msys2/mingw.)
9/26 Checking commit 6c6166c50138 (osdep: file locking functions are not 
available on Win32)
10/26 Checking commit 7ebfac6615e0 (meson: Use -b to ignore CR vs. CR-LF issues 
on Windows)
11/26 Checking commit eb97064abc00 (gcrypt: test_tls_psk_init should write 
binary file instead text file.)
12/26 Checking commit ad29b4253ac2 (tests: Enable crypto tests under 
msys2/mingw)
WARNING: line over 80 characters
#77: FILE: tests/crypto-tls-x509-helpers.c:514:
+g_autofree gchar *full_path = g_build_filename(current_dir, exist_path1, 
NULL);

WARNING: line over 80 characters
#79: FILE: tests/crypto-tls-x509-helpers.c:516:
+new_path2, full_path, 0 | 
SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE) ? 0 : -1;

WARNING: line over 80 characters
#108: FILE: tests/crypto-tls-x509-helpers.c:545:
+sock_listener = socket(addr->ai_family, addr->ai_socktype, 
addr->ai_protocol);

ERROR: line over 90 characters
#113: FILE: tests/crypto-tls-x509-helpers.c:550:
+if (-1 == setsockopt(sock_listener, SOL_SOCKET, SO_REUSEADDR, (const char 
*), sizeof(one))) {

WARNING: line over 80 characters
#119: FILE: tests/crypto-tls-x509-helpers.c:556:
+if (-1 == getsockname(sock_listener, addr->ai_addr, (int 
*)&(addr->ai_addrlen))) {

ERROR: space prohibited between function name and open parenthesis '('
#223: FILE: tests/test-crypto-tlscredsx509.c:85:
+g_remove (CERT_DIR QCRYPTO_TLS_CREDS_X509_CA_CERT);

ERROR: space prohibited 

Re: [PATCH v2 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200912225430.1772-1-dmitry.fomic...@wdc.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20200912225430.1772-1-dmitry.fomic...@wdc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200912224431.1428-1-luoyongg...@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20200912224431.1428-1-luoyongg...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200910152225.524322-1-phi...@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200910152225.524322-1-phi...@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v7 00/13] monitor: Optionally run handlers in coroutines

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200909151149.490589-1-kw...@redhat.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200909151149.490589-1-kw...@redhat.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/4] nbd reconnect new fixes

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200903190301.367620-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.






The full log is available at
http://patchew.org/logs/20200903190301.367620-1-vsement...@virtuozzo.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/4] nbd reconnect new fixes

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200903190301.367620-1-vsement...@virtuozzo.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.






The full log is available at
http://patchew.org/logs/20200903190301.367620-1-vsement...@virtuozzo.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200902080552.159806-1-phi...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Clone of 'https://git.qemu.org/git/dtc.git' into submodule path 'dtc' failed
failed to update submodule dtc
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) unregistered for path 'dtc'
make[1]: *** 
[/var/tmp/patchew-tester-tmp-rwu0f67e/src/docker-src.2020-09-03-10.37.46.30048] 
Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-rwu0f67e/src'
make: *** [docker-run-test-quick@centos7] Error 2

real0m30.996s
user0m2.113s


The full log is available at
http://patchew.org/logs/20200902080552.159806-1-phi...@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/2] Replace posix_fallocate() with falloate()

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200831140127.657134-1-nsof...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200831140127.657134-1-nsof...@redhat.com
Subject: [PATCH 0/2] Replace posix_fallocate() with falloate()

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200831140127.657134-1-nsof...@redhat.com -> 
patchew/20200831140127.657134-1-nsof...@redhat.com
Switched to a new branch 'test'
70e35ed block: file-posix: Replace posix_fallocate with fallocate
35d89d1 block: file-posix: Extract preallocate helpers

=== OUTPUT BEGIN ===
1/2 Checking commit 35d89d1300e4 (block: file-posix: Extract preallocate 
helpers)
ERROR: braces {} are necessary for all arms of this statement
#33: FILE: block/file-posix.c:1841:
+if (offset == current_length)
[...]

total: 1 errors, 0 warnings, 234 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 70e35eda5bc9 (block: file-posix: Replace posix_fallocate 
with fallocate)
ERROR: braces {} are necessary for all arms of this statement
#110: FILE: block/file-posix.c:1967:
+if (result != -ENOTSUP)
[...]

total: 1 errors, 0 warnings, 108 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200831140127.657134-1-nsof...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] qcow2: Use macros for the L1, refcount and bitmap table entry sizes

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200828110828.13833-1-be...@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200828110828.13833-1-be...@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/7] vhost-user-blk: fix the migration issue and enhance qtests

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/cover.1598257838.git.dimas...@yandex-team.ru/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C linker for the host machine: cc ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:9: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
C++ compiler for the host machine: c++ (gcc 4.8.5 "c++ (GCC) 4.8.5 20150623 
(Red Hat 4.8.5-39)")
---
 Linux keyring: YES

Found ninjatool-1.8 at /tmp/qemu-test/build/ninjatool
WARNING: custom_target 'shared QAPI source files' has more than one output! 
Using the first one.
WARNING: custom_target 'QGA QAPI files' has more than one output! Using the 
first one.
WARNING: custom_target 'QAPI files for qemu-storage-daemon' has more than one 
output! Using the first one.
WARNING: custom_target 'QAPI doc' has more than one output! Using the first one.
WARNING: custom_target 'dbus-vmstate description' has more than one output! 
Using the first one.
Command line for building ['libcommon.fa'] is long, using a response file
Command line for building ['libqemu-aarch64-softmmu.fa'] is long, using a 
response file
Command line for building ['qemu-system-aarch64'] is long, using a response file
---
Linking static target hw/core/libhwcore.fa
Linking static target chardev/libchardev.fa
../src/tests/qtest/vhost-user-test.c: In function 'test_reconnect':
../src/tests/qtest/vhost-user-test.c:935:9: error: 'nq' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
 int nq;
 ^
cc1: all warnings being treated as errors
make: *** [tests/qtest/qos-test.p/vhost-user-test.c.o] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=b3addb190ca74c36acdbb7205792264a', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-b6ixlpeu/src/docker-src.2020-08-24-09.41.48.11658:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=b3addb190ca74c36acdbb7205792264a
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-b6ixlpeu/src'
make: *** [docker-run-test-quick@centos7] Error 2

real4m29.821s
user0m21.159s


The full log is available at
http://patchew.org/logs/cover.1598257838.git.dimas...@yandex-team.ru/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v4 00/10] preallocate filter

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200820183950.13109-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-unit: tests/test-char
Unexpected error in object_property_try_add() at 
/tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
  TESTiotest-qcow2: 018
  TESTiotest-qcow2: 019
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=a80f0516394e4d83b19a19e329899c17', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-n_a2v5bj/src/docker-src.2020-08-20-15.00.31.12987:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=a80f0516394e4d83b19a19e329899c17
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-n_a2v5bj/src'
make: *** [docker-run-test-quick@centos7] Error 2

real16m13.105s
user0m8.886s


The full log is available at
http://patchew.org/logs/20200820183950.13109-1-vsement...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v3 00/12] preallocate filter

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200817091553.283155-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  block/nvme.o
  CC  block/nbd.o
/tmp/qemu-test/src/block/file-posix.c: In function 'is_fuse':
/tmp/qemu-test/src/block/file-posix.c:334:35: error: 'FUSE_SUPER_MAGIC' 
undeclared (first use in this function)
 if (ret == 0 && buf.f_type == FUSE_SUPER_MAGIC) {
   ^
/tmp/qemu-test/src/block/file-posix.c:334:35: note: each undeclared identifier 
is reported only once for each function it appears in
  CC  block/sheepdog.o
make: *** [block/file-posix.o] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=ee7ebe61e5fd4a018bbb2a16ec4a5a54', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-o73ap74n/src/docker-src.2020-08-17-05.46.38.25129:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=ee7ebe61e5fd4a018bbb2a16ec4a5a54
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-o73ap74n/src'
make: *** [docker-run-test-quick@centos7] Error 2

real1m49.146s
user0m8.506s


The full log is available at
http://patchew.org/logs/20200817091553.283155-1-vsement...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v3 00/12] preallocate filter

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200817091553.283155-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  LINKqemu-edid.exe
/usr/lib/gcc/x86_64-w64-mingw32/9.2.1/../../../../x86_64-w64-mingw32/bin/ld: 
block/qcow2.o: in function `qcow2_vz_insert_prealloc_filter':
/tmp/qemu-test/src/block/qcow2.c:1878: undefined reference to 
`bdrv_is_file_on_fuse'
collect2: error: ld returned 1 exit status
make: *** [/tmp/qemu-test/src/rules.mak:124: qemu-io.exe] Error 1
make: *** Waiting for unfinished jobs
  GEN x86_64-softmmu/hmp-commands.h
  GEN x86_64-softmmu/hmp-commands-info.h
---
  CC  aarch64-softmmu/hw/arm/xlnx-zynqmp.o
/usr/lib/gcc/x86_64-w64-mingw32/9.2.1/../../../../x86_64-w64-mingw32/bin/ld: 
../block/qcow2.o: in function `qcow2_vz_insert_prealloc_filter':
/tmp/qemu-test/src/block/qcow2.c:1878: undefined reference to 
`bdrv_is_file_on_fuse'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:219: qemu-system-x86_64w.exe] Error 1
make: *** [Makefile:527: x86_64-softmmu/all] Error 2
  CC  aarch64-softmmu/hw/arm/xlnx-zcu102.o
  CC  aarch64-softmmu/hw/arm/xlnx-versal.o
  CC  aarch64-softmmu/hw/arm/xlnx-versal-virt.o
---
  LINKaarch64-softmmu/qemu-system-aarch64w.exe
/usr/lib/gcc/x86_64-w64-mingw32/9.2.1/../../../../x86_64-w64-mingw32/bin/ld: 
../block/qcow2.o: in function `qcow2_vz_insert_prealloc_filter':
/tmp/qemu-test/src/block/qcow2.c:1878: undefined reference to 
`bdrv_is_file_on_fuse'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:219: qemu-system-aarch64w.exe] Error 1
make: *** [Makefile:527: aarch64-softmmu/all] Error 2
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
sys.exit(main())
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=46c939bfc42848c6bf98acc32e769fb0', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-v9t81w9y/src/docker-src.2020-08-17-05.40.50.16028:/var/tmp/qemu:z,ro',
 'qemu/fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=46c939bfc42848c6bf98acc32e769fb0
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-v9t81w9y/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real4m43.217s
user0m8.945s


The full log is available at
http://patchew.org/logs/20200817091553.283155-1-vsement...@virtuozzo.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1597423256-14847-1-git-send-email-bmeng...@gmail.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-unit: tests/test-char
Unexpected error in object_property_try_add() at 
/tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
  TESTcheck-qtest-x86_64: tests/qtest/hd-geo-test
qemu-system-aarch64: -accel kvm: invalid accelerator kvm
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=5d87ed4b32104d3fa300f89248e59809', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-okrr9kbl/src/docker-src.2020-08-14-13.56.55.12251:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=5d87ed4b32104d3fa300f89248e59809
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-okrr9kbl/src'
make: *** [docker-run-test-quick@centos7] Error 2

real13m35.300s
user0m8.266s


The full log is available at
http://patchew.org/logs/1597423256-14847-1-git-send-email-bmeng...@gmail.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/9] preallocate filter

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200814130348.20625-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-unit: tests/test-char
Unexpected error in object_property_try_add() at 
/tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
  TESTiotest-qcow2: 029
  TESTcheck-qtest-x86_64: tests/qtest/hd-geo-test
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=933e39134d33428cb91c95a7f1ece9e6', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-u8odh47c/src/docker-src.2020-08-14-12.16.21.29250:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=933e39134d33428cb91c95a7f1ece9e6
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-u8odh47c/src'
make: *** [docker-run-test-quick@centos7] Error 2

real13m58.743s
user0m8.567s


The full log is available at
http://patchew.org/logs/20200814130348.20625-1-vsement...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2 0/9] preallocate filter

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200814130348.20625-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  nbd/trace.o
  CC  scsi/trace.o

Warning, treated as error:
../src/docs/system/qemu-block-drivers.rst.inc:980:Duplicate explicit target 
name: "cmdoption-preallocate-arg-prealloc-align".
  CC  audio/trace.o
  CC  chardev/trace.o
---
  CC  hw/ide/trace.o
  CC  hw/input/trace.o
  CC  hw/intc/trace.o
make: *** [Makefile:: 
.docs_system_qemu.1_docs_system_qemu-block-drivers.7_docs_system_qemu-cpu-models.7.sentinel.]
 Error 2
make: *** Deleting file 
'.docs_system_qemu.1_docs_system_qemu-block-drivers.7_docs_system_qemu-cpu-models.7.sentinel.'
make: *** Waiting for unfinished jobs

Warning, treated as error:
../src/docs/system/qemu-block-drivers.rst.inc:980:Duplicate explicit target 
name: "cmdoption-preallocate-arg-prealloc-align".
make: *** [Makefile:1100: docs/system/index.html] Error 2
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 709, in 
sys.exit(main())
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=2b8332eeb0c84671bf5f795b37073245', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-msztbvd9/src/docker-src.2020-08-14-12.13.08.24140:/var/tmp/qemu:z,ro',
 'qemu/fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=2b8332eeb0c84671bf5f795b37073245
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-msztbvd9/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real2m29.643s
user0m7.966s


The full log is available at
http://patchew.org/logs/20200814130348.20625-1-vsement...@virtuozzo.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] ide:do nothing for identify cmd if no any device attached

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200814043657.5815-1-rockcui...@zhaoxin.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-unit: tests/test-char
Unexpected error in object_property_try_add() at 
/tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
  TESTiotest-qcow2: 024
  TESTiotest-qcow2: 025
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=3d9b744ea9784590902f0fd1b1c1cc94', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-uf3g3t43/src/docker-src.2020-08-14-11.29.38.3773:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=3d9b744ea9784590902f0fd1b1c1cc94
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-uf3g3t43/src'
make: *** [docker-run-test-quick@centos7] Error 2

real13m29.699s
user0m8.487s


The full log is available at
http://patchew.org/logs/20200814043657.5815-1-rockcui...@zhaoxin.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] ide:do nothing for identify cmd if no any device attached

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200814043657.5815-1-rockcui...@zhaoxin.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200814043657.5815-1-rockcui...@zhaoxin.com
Subject: [PATCH] ide:do nothing for identify cmd if no any device attached

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c0ee2f5 ide:do nothing for identify cmd if no any device attached

=== OUTPUT BEGIN ===
ERROR: trailing whitespace
#27: FILE: hw/ide/core.c:2077:
+if ((!bus->ifs[0].blk && !bus->ifs[1].blk) || $

ERROR: code indent should never use tabs
#28: FILE: hw/ide/core.c:2078:
+^I(s != bus->ifs && !s->blk)) {$

total: 2 errors, 0 warnings, 11 lines checked

Commit c0ee2f5abbf3 (ide:do nothing for identify cmd if no any device attached) 
has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200814043657.5815-1-rockcui...@zhaoxin.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] hw/block/nand: Decommission the NAND museum

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200814132118.12450-1-f4...@amsat.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-unit: tests/test-char
Unexpected error in object_property_try_add() at 
/tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
  TESTiotest-qcow2: 024
  TESTiotest-qcow2: 025
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=fcbf9aaa3378436e89b400e6696ede90', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-2_l66xc7/src/docker-src.2020-08-14-10.10.03.16071:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=fcbf9aaa3378436e89b400e6696ede90
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-2_l66xc7/src'
make: *** [docker-run-test-quick@centos7] Error 2

real12m35.484s
user0m9.445s


The full log is available at
http://patchew.org/logs/20200814132118.12450-1-f4...@amsat.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] hw/sd/allwinner-sdhost: Use AddressSpace for DMA transfers

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200814110057.307-1-f4...@amsat.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  x86_64-softmmu/target/i386/smm_helper.o
  CC  x86_64-softmmu/target/i386/svm_helper.o
/tmp/qemu-test/src/hw/arm/allwinner-a10.c: In function 'aw_a10_realize':
/tmp/qemu-test/src/hw/arm/allwinner-a10.c:170:30: error: passing argument 2 of 
'object_property_set_link' from incompatible pointer type [-Werror]
  OBJECT(get_system_memory()), _fatal);
  ^
In file included from /tmp/qemu-test/src/include/exec/memory.h:28:0,
---
/tmp/qemu-test/src/include/qom/object.h:1243:6: note: expected 'struct Object 
*' but argument is of type 'const char *'
 void object_property_set_link(Object *obj, Object *value,
  ^
/tmp/qemu-test/src/hw/arm/allwinner-a10.c:170:30: error: passing argument 3 of 
'object_property_set_link' from incompatible pointer type [-Werror]
  OBJECT(get_system_memory()), _fatal);
  ^
In file included from /tmp/qemu-test/src/include/exec/memory.h:28:0,
---
 void object_property_set_link(Object *obj, Object *value,
  ^
cc1: all warnings being treated as errors
make[1]: *** [hw/arm/allwinner-a10.o] Error 1
make[1]: *** Waiting for unfinished jobs
  CC  x86_64-softmmu/target/i386/machine.o
  CC  x86_64-softmmu/target/i386/arch_memory_mapping.o
/tmp/qemu-test/src/hw/arm/allwinner-h3.c: In function 'allwinner_h3_realize':
/tmp/qemu-test/src/hw/arm/allwinner-h3.c:353:30: error: passing argument 2 of 
'object_property_set_link' from incompatible pointer type [-Werror]
  OBJECT(get_system_memory()), _fatal);
  ^
In file included from /tmp/qemu-test/src/include/exec/memory.h:28:0,
---
/tmp/qemu-test/src/include/qom/object.h:1243:6: note: expected 'struct Object 
*' but argument is of type 'const char *'
 void object_property_set_link(Object *obj, Object *value,
  ^
/tmp/qemu-test/src/hw/arm/allwinner-h3.c:353:30: error: passing argument 3 of 
'object_property_set_link' from incompatible pointer type [-Werror]
  OBJECT(get_system_memory()), _fatal);
  ^
In file included from /tmp/qemu-test/src/include/exec/memory.h:28:0,
---
 void object_property_set_link(Object *obj, Object *value,
  ^
cc1: all warnings being treated as errors
make[1]: *** [hw/arm/allwinner-h3.o] Error 1
  CC  x86_64-softmmu/target/i386/arch_dump.o
  CC  x86_64-softmmu/target/i386/monitor.o
  CC  x86_64-softmmu/target/i386/kvm.o
---
  CC  x86_64-softmmu/softmmu/main.o
  CC  x86_64-softmmu/gdbstub-xml.o
  CC  x86_64-softmmu/trace/generated-helpers.o
make: *** [aarch64-softmmu/all] Error 2
make: *** Waiting for unfinished jobs
  LINKx86_64-softmmu/qemu-system-x86_64
Traceback (most recent call last):
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=db66dd82f40243898ca5fc5874340ff2', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-_2_0qwhh/src/docker-src.2020-08-14-08.01.24.10929:/var/tmp/qemu:z,ro',
 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=db66dd82f40243898ca5fc5874340ff2
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-_2_0qwhh/src'
make: *** [docker-run-test-quick@centos7] Error 2

real3m37.968s
user0m8.605s


The full log is available at
http://patchew.org/logs/20200814110057.307-1-f4...@amsat.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] hw/sd/allwinner-sdhost: Use AddressSpace for DMA transfers

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200814110057.307-1-f4...@amsat.org/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  aarch64-softmmu/trace/generated-helpers.o
  CC  aarch64-softmmu/target/arm/translate-sve.o
/tmp/qemu-test/src/hw/arm/allwinner-a10.c: In function 'aw_a10_realize':
/tmp/qemu-test/src/hw/arm/allwinner-a10.c:169:48: error: passing argument 2 of 
'object_property_set_link' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
  169 | object_property_set_link(OBJECT(>mmc0), "dma-memory",
  |^~~~
  ||
---
/tmp/qemu-test/src/include/qom/object.h:1243:52: note: expected 'Object *' {aka 
'struct Object *'} but argument is of type 'const char *'
 1243 | void object_property_set_link(Object *obj, Object *value,
  |^
/tmp/qemu-test/src/include/qom/object.h:509:6: error: passing argument 3 of 
'object_property_set_link' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
  509 | ((Object *)(obj))
  | ~^~~~
  |  |
---
  170 |  OBJECT(get_system_memory()), _fatal);
  |  ^~
/tmp/qemu-test/src/include/qom/object.h:1244:43: note: expected 'const char *' 
but argument is of type 'Object *' {aka 'struct Object *'}
 1244 |   const char *name, Error **errp);
  |   ^~~~
cc1: all warnings being treated as errors
make[1]: *** [/tmp/qemu-test/src/rules.mak:69: hw/arm/allwinner-a10.o] Error 1
make[1]: *** Waiting for unfinished jobs
/tmp/qemu-test/src/hw/arm/allwinner-h3.c: In function 'allwinner_h3_realize':
/tmp/qemu-test/src/hw/arm/allwinner-h3.c:352:48: error: passing argument 2 of 
'object_property_set_link' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
  352 | object_property_set_link(OBJECT(>mmc0), "dma-memory",
  |^~~~
  ||
---
/tmp/qemu-test/src/include/qom/object.h:1243:52: note: expected 'Object *' {aka 
'struct Object *'} but argument is of type 'const char *'
 1243 | void object_property_set_link(Object *obj, Object *value,
  |^
/tmp/qemu-test/src/include/qom/object.h:509:6: error: passing argument 3 of 
'object_property_set_link' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
  509 | ((Object *)(obj))
  | ~^~~~
  |  |
---
  353 |  OBJECT(get_system_memory()), _fatal);
  |  ^~
/tmp/qemu-test/src/include/qom/object.h:1244:43: note: expected 'const char *' 
but argument is of type 'Object *' {aka 'struct Object *'}
 1244 |   const char *name, Error **errp);
  |   ^~~~
cc1: all warnings being treated as errors
make[1]: *** [/tmp/qemu-test/src/rules.mak:69: hw/arm/allwinner-h3.o] Error 1
make: *** [Makefile:527: aarch64-softmmu/all] Error 2
make: *** Waiting for unfinished jobs
  GEN x86_64-softmmu/qemu-system-x86_64.exe
Traceback (most recent call last):
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=90cc61fdf8a54dfb83e2aee788b81fec', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-o9b1ibdl/src/docker-src.2020-08-14-07.57.27.32200:/var/tmp/qemu:z,ro',
 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=90cc61fdf8a54dfb83e2aee788b81fec
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-o9b1ibdl/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real3m17.833s
user0m8.465s


The full log is available at
http://patchew.org/logs/20200814110057.307-1-f4...@amsat.org/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL 0/9] Tracing patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200813052257.226142-1-stefa...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-unit: tests/test-char
Unexpected error in object_property_try_add() at 
/tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
qemu-system-aarch64: -accel kvm: invalid accelerator kvm
qemu-system-aarch64: falling back to tcg
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=5808c97c711e485db979e5289207613b', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-wo4v6nnp/src/docker-src.2020-08-13-06.32.42.31813:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=5808c97c711e485db979e5289207613b
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-wo4v6nnp/src'
make: *** [docker-run-test-quick@centos7] Error 2

real14m32.450s
user0m8.381s


The full log is available at
http://patchew.org/logs/20200813052257.226142-1-stefa...@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PULL 0/9] Tracing patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200813052257.226142-1-stefa...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200813052257.226142-1-stefa...@redhat.com
Subject: [PULL 0/9] Tracing patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ab1e0e0 trace-events: Fix attribution of trace points to source
b4e6c94 trace-events: Delete unused trace points
967b100 scripts/cleanup-trace-events: Emit files in alphabetical order
a3b5483 scripts/cleanup-trace-events: Fix for vcpu property
c846bf7 softmmu: Add missing trace-events file
63d5982 net/colo: Match is-enabled probe to tracepoint
75eab42 build: Don't make object files for dtrace on macOS
28b2951 scripts/tracetool: Use void pointer for vcpu
dc44f9f scripts/tracetool: Fix dtrace generation for macOS

=== OUTPUT BEGIN ===
1/9 Checking commit dc44f9f395ff (scripts/tracetool: Fix dtrace generation for 
macOS)
2/9 Checking commit 28b2951555cd (scripts/tracetool: Use void pointer for vcpu)
3/9 Checking commit 75eab42de18c (build: Don't make object files for dtrace on 
macOS)
4/9 Checking commit 63d598213058 (net/colo: Match is-enabled probe to 
tracepoint)
5/9 Checking commit c846bf7afef4 (softmmu: Add missing trace-events file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#76: 
new file mode 100644

total: 0 errors, 1 warnings, 111 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit a3b5483d4283 (scripts/cleanup-trace-events: Fix for vcpu 
property)
ERROR: code indent should never use tabs
#33: FILE: scripts/cleanup-trace-events.pl:38:
+^Idefined $3 ? () : ('--max-depth', '1'),$

ERROR: code indent should never use tabs
#34: FILE: scripts/cleanup-trace-events.pl:39:
+^I$pat$

total: 2 errors, 0 warnings, 16 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 967b100f8520 (scripts/cleanup-trace-events: Emit files in 
alphabetical order)
8/9 Checking commit b4e6c94dad64 (trace-events: Delete unused trace points)
9/9 Checking commit ab1e0e0ff43d (trace-events: Fix attribution of trace points 
to source)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200813052257.226142-1-stefa...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v2] block/vhdx: Support vhdx image only with 512 bytes logical sector size

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1596794594-44531-1-git-send-email-swapnil.in...@nutanix.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/1596794594-44531-1-git-send-email-swapnil.in...@nutanix.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200805023826.184-1-fangyi...@huawei.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.






The full log is available at
http://patchew.org/logs/20200805023826.184-1-fangyi...@huawei.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH 0/2] Fix for write sharing on luks raw images

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200719122059.59843-1-mlevi...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200719122059.59843-1-mlevi...@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [RFC PATCH-for-5.1] hw/ide: Do not block for AIO while resetting a drive

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200717171938.1249-1-f4...@amsat.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  aarch64-softmmu/target/arm/translate-sve.o
  CC  aarch64-softmmu/trace/generated-helpers.o
  LINKaarch64-softmmu/qemu-system-aarch64
collect2: error: ld returned 1 exit status
collect2: error: ld returned 1 exit status
make[1]: *** [qemu-system-aarch64] Error 1
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [aarch64-softmmu/all] Error 2
make: *** Waiting for unfinished jobs
make: *** [x86_64-softmmu/all] Error 2
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 708, in 
sys.exit(main())
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=3bb1a90ba07d44f8a68428ba8cc1aac8', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-s7o9muvt/src/docker-src.2020-07-17-13.24.31.3740:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=3bb1a90ba07d44f8a68428ba8cc1aac8
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-s7o9muvt/src'
make: *** [docker-run-test-quick@centos7] Error 2

real2m44.977s
user0m8.984s


The full log is available at
http://patchew.org/logs/20200717171938.1249-1-f4...@amsat.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH for-5.1 0/3] file-posix: Fix check_hdev_writable() with auto-read-only

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200717105426.51134-1-kw...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTcheck-qtest-x86_64: tests/qtest/qmp-test
  TESTcheck-qtest-x86_64: tests/qtest/qmp-cmd-test
**
ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:97:init_socket: assertion 
failed (ret != -1): (-1 != -1)
ERROR qmp-cmd-test - Bail out! 
ERROR:/tmp/qemu-test/src/tests/qtest/libqtest.c:97:init_socket: assertion 
failed (ret != -1): (-1 != -1)
make: *** [check-qtest-x86_64] Error 1
make: *** Waiting for unfinished jobs
  TESTiotest-qcow2: 080
  TESTiotest-qcow2: 086
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=fc3463a17cea454c9a0fcd472358db4f', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-c3bzzbt8/src/docker-src.2020-07-17-07.34.41.28182:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=fc3463a17cea454c9a0fcd472358db4f
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-c3bzzbt8/src'
make: *** [docker-run-test-quick@centos7] Error 2

real14m51.065s
user0m8.978s


The full log is available at
http://patchew.org/logs/20200717105426.51134-1-kw...@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200714162234.13113-1-vsement...@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TESTiotest-qcow2: 022
  TESTcheck-unit: tests/test-char
**
ERROR:/tmp/qemu-test/src/tests/test-char.c:1204:char_serial_test: 'chr' should 
not be NULL
ERROR test-char - Bail out! 
ERROR:/tmp/qemu-test/src/tests/test-char.c:1204:char_serial_test: 'chr' should 
not be NULL
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs
  TESTiotest-qcow2: 024
  TESTiotest-qcow2: 025
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=9dc2c7a6e3eb458c88fdd6be6a03c6eb', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-fzvixkio/src/docker-src.2020-07-14-12.32.53.19697:/var/tmp/qemu:z,ro',
 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=9dc2c7a6e3eb458c88fdd6be6a03c6eb
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-fzvixkio/src'
make: *** [docker-run-test-quick@centos7] Error 2

real16m48.396s
user0m8.741s


The full log is available at
http://patchew.org/logs/20200714162234.13113-1-vsement...@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v11 00/34] Add subcluster allocation to qcow2

[no-reply]

Patchew URL: https://patchew.org/QEMU/cover.1594396418.git.be...@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  block/blkverify.o
  CC  block/blkreplay.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be 
used uninitialized in this function [-Werror=maybe-uninitialized]
 } else if (type != expected_type) {
   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was 
declared here
 QCow2SubclusterType expected_type, type;
 ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 669, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=21da7e0fdd084eea8b00971953a3ff2a', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-yoa6xyt4/src/docker-src.2020-07-10-13.26.25.25621:/var/tmp/qemu:z,ro',
 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=21da7e0fdd084eea8b00971953a3ff2a
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-yoa6xyt4/src'
make: *** [docker-run-test-quick@centos7] Error 2

real2m27.189s
user0m8.691s


The full log is available at
http://patchew.org/logs/cover.1594396418.git.be...@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v11 00/34] Add subcluster allocation to qcow2

[no-reply]

Patchew URL: https://patchew.org/QEMU/cover.1594396418.git.be...@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  block/snapshot.o
  CC  block/qapi.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be 
used uninitialized in this function [-Werror=maybe-uninitialized]
 } else if (type != expected_type) {
   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was 
declared here
 QCow2SubclusterType expected_type, type;
 ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 669, in 
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=10623143eef0416b9c3b987efa6621a1', '-u', 
'1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-zd6p1e8g/src/docker-src.2020-07-10-12.40.45.27056:/var/tmp/qemu:z,ro',
 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=10623143eef0416b9c3b987efa6621a1
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-zd6p1e8g/src'
make: *** [docker-run-test-quick@centos7] Error 2

real3m13.395s
user0m8.778s


The full log is available at
http://patchew.org/logs/cover.1594396418.git.be...@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH for-5.1 0/2] qemu-img convert: Fix abort with unaligned image size

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200710142149.40962-1-kw...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Not run: 259
Failures: 268
Failed 1 of 119 iotests
make: *** [check-tests/check-block.sh] Error 1
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 669, in 
sys.exit(main())
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=7dd2224f6d7b4c79a604d33021e80c19', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-vz0tbkd6/src/docker-src.2020-07-10-10.27.42.8932:/var/tmp/qemu:z,ro',
 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=7dd2224f6d7b4c79a604d33021e80c19
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-vz0tbkd6/src'
make: *** [docker-run-test-quick@centos7] Error 2

real16m16.326s
user0m9.052s


The full log is available at
http://patchew.org/logs/20200710142149.40962-1-kw...@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v1] qmp: don't hold ctx lock while querying blockstats

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200710085400.343-1-yezhen...@huawei.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Not run: 259
Failures: 192
Failed 1 of 119 iotests
make: *** [check-tests/check-block.sh] Error 1
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 669, in 
sys.exit(main())
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=c086654c8b434de29ab30387058535ba', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-0xv6b4b9/src/docker-src.2020-07-10-05.11.36.18650:/var/tmp/qemu:z,ro',
 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=c086654c8b434de29ab30387058535ba
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-0xv6b4b9/src'
make: *** [docker-run-test-quick@centos7] Error 2

real15m29.715s
user0m9.321s


The full log is available at
http://patchew.org/logs/20200710085400.343-1-yezhen...@huawei.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH v4 00/45] Less clumsy error checking

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200707160613.848843-1-arm...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200707160613.848843-1-arm...@redhat.com
Subject: [PATCH v4 00/45] Less clumsy error checking

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/159413975752.169116.5808968580649255382.st...@bahia.lan -> 
patchew/159413975752.169116.5808968580649255382.st...@bahia.lan
 * [new tag] 
patchew/1594140062-23522-1-git-send-email-aleksandar.qemu.de...@gmail.com -> 
patchew/1594140062-23522-1-git-send-email-aleksandar.qemu.de...@gmail.com
 * [new tag] patchew/20200707163504.194740-1-kw...@redhat.com -> 
patchew/20200707163504.194740-1-kw...@redhat.com
Switched to a new branch 'test'
5dad863 hmp: Ignore Error objects where the return value suffices
99fa3f2 qdev: Ignore Error objects where the return value suffices
6ee97c0 qemu-img: Ignore Error objects where the return value suffices
677256f error: Avoid error_propagate() after migrate_add_blocker()
974c52b qapi: Purge error_propagate() from QAPI core
b664ca1 qapi: Smooth visitor error checking in generated code
58529e8 qapi: Smooth another visitor error checking pattern
8761cbd block/parallels: Simplify parallels_open() after previous commit
6821adb error: Reduce unnecessary error propagation
8ed0efc error: Eliminate error_propagate() manually
9f8cd51 error: Eliminate error_propagate() with Coccinelle, part 2
4516a2b error: Eliminate error_propagate() with Coccinelle, part 1
e776a9c error: Avoid unnecessary error_propagate() after error_setg()
97a8ae7 qdev: Use returned bool to check for failure, Coccinelle part
b489fef qdev: Make functions taking Error ** return bool, not void
c5651e9 qom: Make functions taking Error ** return bool, not 0/-1
1e9a1c3 qom: Use returned bool to check for failure, manual part
b158de6 qom: Use returned bool to check for failure, Coccinelle part
911dbb4 qom: Make functions taking Error ** return bool, not void
94c4ad1 qom: Put name parameter before value / visitor parameter
a65eadc qom: Use return values to check for error where that's simpler
aff3f41 qom: Don't handle impossible object_property_get_link() failure
f171d59 qom: Crash more nicely on object_property_get_link() failure
d1d7b14 qom: Rename qdev_get_type() to object_get_type()
54e907c qom: Use error_reportf_err() instead of g_printerr() in examples
aa402c4 s390x/pci: Fix harmless mistake in zpci's property fid's setter
e3a01f0 qapi: Use returned bool to check for failure, manual part
ee2a4a7 qapi: Use returned bool to check for failure, Coccinelle part
d78fd21 qapi: Make visitor functions taking Error ** return bool, not void
45cc0d8 hmp: Eliminate a variable in hmp_migrate_set_parameter()
18fa30f block: Avoid error accumulation in bdrv_img_create()
d5fa417 qemu-option: Use returned bool to check for failure
35a4f99 qemu-option: Make functions taking Error ** return bool, not void
9fcbf0b qemu-option: Replace opt_set() by cleaner opt_validate()
09fdc0e qemu-option: Factor out helper opt_create()
f2370fc qemu-option: Simplify around find_default_by_name()
e8d48f4 qemu-option: Factor out helper find_default_by_name()
d9cd2e4 qemu-option: Make uses of find_desc_by_name() more similar
30d78ea qemu-option: Check return value instead of @err where convenient
c670e7c virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()
22252c6 macio: Tidy up error handling in macio_newworld_realize()
8c1b98a qdev: Use returned bool to check for qdev_realize() etc. failure
0ce error: Document Error API usage rules
2ae4ce8 error: Improve error.h's big comment
8d27f64 error: Fix examples in error.h's big comment

=== OUTPUT BEGIN ===
1/45 Checking commit 8d27f64734f9 (error: Fix examples in error.h's big comment)
ERROR: Error messages should not contain newlines
#25: FILE: include/qapi/error.h:27:
+ * error_setg(, "invalid quark\n" // WRONG!

total: 1 errors, 0 warnings, 40 lines checked

Patch 1/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/45 Checking commit 2ae4ce84c712 (error: Improve error.h's big comment)
3/45 Checking commit 0ce2abc0 (error: Document Error API usage rules)
4/45 Checking commit 8c1b98ac618a (qdev: Use returned bool to check for 
qdev_realize() etc. failure)
5/45 Checking commit 22252c6387fd (macio: Tidy up error handling in 
macio_newworld_realize())
6/45 Checking commit c670e7c4698a (virtio-crypto-pci: Tidy up 
virtio_crypto_pci_realize())
7/45 Checking commit 30d78eae64ac (qemu-option: Check return value 

Re: [PATCH] trivial: Remove trailing whitespaces

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200706162300.1084753-1-dinec...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] trivial: Remove trailing whitespaces
Type: series
Message-id: 20200706162300.1084753-1-dinec...@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200706162300.1084753-1-dinec...@redhat.com -> 
patchew/20200706162300.1084753-1-dinec...@redhat.com
Switched to a new branch 'test'
9af3e90 trivial: Remove trailing whitespaces

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#121: FILE: disas/microblaze.c:112:
+   fcmp_lt, fcmp_eq, fcmp_le, fcmp_gt, fcmp_ne, fcmp_ge, fcmp_un, flt, fint, 
fsqrt,

ERROR: line over 90 characters
#148: FILE: disas/microblaze.c:280:
+  unsigned long bit_sequence; /* all the fixed bits for the op are set and all 
the variable bits (reg names, imm vals) are set to 0 */

ERROR: space prohibited between function name and open parenthesis '('
#289: FILE: disas/microblaze.c:728:
+read_insn_microblaze (bfd_vma memaddr,

ERROR: suspect code indent for conditional statements (2, 6)
#298: FILE: disas/microblaze.c:739:
+  if (status != 0)
 {

ERROR: code indent should never use tabs
#334: FILE: disas/microblaze.c:854:
+^I  /* The non-pc relative instructions are returns, which shouldn't$

WARNING: Block comments use a leading /* on a separate line
#334: FILE: disas/microblaze.c:854:
+ /* The non-pc relative instructions are returns, which shouldn't

ERROR: code indent should never use tabs
#343: FILE: disas/microblaze.c:889:
+^I}$

WARNING: Block comments use a leading /* on a separate line
#365: FILE: disas/nios2.c:99:
+/* This structure holds information for a particular instruction.

ERROR: code indent should never use tabs
#374: FILE: disas/nios2.c:155:
+  const char *args;^I^I/* A string describing the arguments for this$

WARNING: Block comments use a leading /* on a separate line
#374: FILE: disas/nios2.c:155:
+  const char *args;/* A string describing the arguments for this

ERROR: code indent should never use tabs
#377: FILE: disas/nios2.c:157:
+  const char *args_test;^I/* Like args, but with an extra argument for$

WARNING: Block comments use a leading /* on a separate line
#377: FILE: disas/nios2.c:157:
+  const char *args_test;   /* Like args, but with an extra argument for

ERROR: code indent should never use tabs
#380: FILE: disas/nios2.c:159:
+  unsigned long num_args;^I/* The number of arguments the instruction$

WARNING: Block comments use a leading /* on a separate line
#380: FILE: disas/nios2.c:159:
+  unsigned long num_args;  /* The number of arguments the instruction

ERROR: code indent should never use tabs
#386: FILE: disas/nios2.c:164:
+  unsigned long mask;^I^I/* Mask for the opcode field of the$

WARNING: Block comments use a leading /* on a separate line
#386: FILE: disas/nios2.c:164:
+  unsigned long mask;  /* Mask for the opcode field of the

ERROR: code indent should never use tabs
#389: FILE: disas/nios2.c:166:
+  unsigned long pinfo;^I^I/* Is this a real instruction or instruction$

WARNING: Block comments use a leading /* on a separate line
#389: FILE: disas/nios2.c:166:
+  unsigned long pinfo; /* Is this a real instruction or instruction

WARNING: Block comments use a leading /* on a separate line
#392: FILE: disas/nios2.c:168:
+  enum overflow_type overflow_msg;  /* Used to generate informative

WARNING: Block comments use a leading /* on a separate line
#399: FILE: disas/nios2.c:172:
+/* This value is used in the nios2_opcode.pinfo field to indicate that the

WARNING: Block comments use * on subsequent lines
#400: FILE: disas/nios2.c:173:
+/* This value is used in the nios2_opcode.pinfo field to indicate that the
+   instruction is a macro or pseudo-op.  This requires special treatment by

WARNING: line over 80 characters
#549: FILE: disas/nios2.c:284:
+#define GET_IW_CUSTOM_A(W) (((W) >> IW_CUSTOM_A_LSB) & 
IW_CUSTOM_A_UNSHIFTED_MASK)

WARNING: line over 80 characters
#550: FILE: disas/nios2.c:285:
+#define SET_IW_CUSTOM_A(V) (((V) & IW_CUSTOM_A_UNSHIFTED_MASK) << 
IW_CUSTOM_A_LSB)

WARNING: line over 80 characters
#562: FILE: disas/nios2.c:291:
+#define GET_IW_CUSTOM_B(W) (((W) >> IW_CUSTOM_B_LSB) & 
IW_CUSTOM_B_UNSHIFTED_MASK)

WARNING: line over 80 characters
#563: FILE: disas/nios2.c:292:
+#define SET_IW_CUSTOM_B(V) (((V) & IW_CUSTOM_B_UNSHIFTED_MASK) << 
IW_CUSTOM_B_LSB)

WARNING: line over 80 characters
#575: FILE: disas/nios2.c:298:
+#define GET_IW_CUSTOM_C(W) (((W) >> IW_CUSTOM_C_LSB) & 
IW_CUSTOM_C_UNSHIFTED_MASK)

WARNING: line over 80 characters
#576: FILE: disas/nios2.c:299:
+#define 

Re: [PULL 00/31] Block patches

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200706100432.2301919-1-mre...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/31] Block patches
Type: series
Message-id: 20200706100432.2301919-1-mre...@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag] patchew/20200706100432.2301919-1-mre...@redhat.com -> 
patchew/20200706100432.2301919-1-mre...@redhat.com
Switched to a new branch 'test'
61a6805 qed: Simplify backing reads
8160191 block: drop unallocated_blocks_are_zero
d59b973 block/vhdx: drop unallocated_blocks_are_zero
fc425f8 block/file-posix: drop unallocated_blocks_are_zero
ee4e5f6 block/iscsi: drop unallocated_blocks_are_zero
9aacd22 block/crypto: drop unallocated_blocks_are_zero
4d6c6ad block/vpc: return ZERO block-status when appropriate
42d9c04 block/vdi: return ZERO block-status when appropriate
f73a13e block: inline bdrv_unallocated_blocks_are_zero()
d5d6d75 qemu-img: convert: don't use unallocated_blocks_are_zero
ecc887e iotests: add tests for blockdev-amend
ee66938 block/qcow2: implement blockdev-amend
9254299 block/crypto: implement blockdev-amend
f905f40 block/core: add generic infrastructure for x-blockdev-amend qmp command
5737d94 iotests: qemu-img tests for luks key management
1981eea block/qcow2: extend qemu-img amend interface with crypto options
75ebd25 block/crypto: implement the encryption key management
381affe block/crypto: rename two functions
37d5645 block/amend: refactor qcow2 amend options
2057114 block/amend: separate amend and create options for qemu-img
01ead3a block/amend: add 'force' option
23c67be qcrypto/luks: implement encryption key management
255ed50 qcrypto/core: add generic infrastructure for crypto options amendment
2267d63 iotests: Check whether luks works
a28c683 iotests.py: Add (verify|has)_working_luks()
e4821d5 iotests.py: Add qemu_img_pipe_and_status()
e9500aa iotests/common.rc: Add _require_working_luks
b3b46b5 iotests: filter few more luks specific create options
f872aeb iotests: Make _filter_img_create more active
d327a4c qcow2: Fix preallocation on images with unaligned sizes
9e289b8 block/block-copy: block_copy_dirty_clusters: fix failure check

=== OUTPUT BEGIN ===
1/31 Checking commit 9e289b8e0d77 (block/block-copy: block_copy_dirty_clusters: 
fix failure check)
2/31 Checking commit d327a4c43167 (qcow2: Fix preallocation on images with 
unaligned sizes)
3/31 Checking commit f872aebcf148 (iotests: Make _filter_img_create more active)
4/31 Checking commit b3b46b52bfec (iotests: filter few more luks specific 
create options)
5/31 Checking commit e9500aa71b58 (iotests/common.rc: Add _require_working_luks)
6/31 Checking commit e4821d5b92da (iotests.py: Add qemu_img_pipe_and_status())
7/31 Checking commit a28c683849bf (iotests.py: Add (verify|has)_working_luks())
8/31 Checking commit 2267d63fda82 (iotests: Check whether luks works)
9/31 Checking commit 255ed5095c89 (qcrypto/core: add generic infrastructure for 
crypto options amendment)
10/31 Checking commit 23c67bedd6e4 (qcrypto/luks: implement encryption key 
management)
11/31 Checking commit 01ead3a1b6b0 (block/amend: add 'force' option)
12/31 Checking commit 2057114b7a98 (block/amend: separate amend and create 
options for qemu-img)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#34: FILE: block/qcow2.c:5663:
+#define QCOW_COMMON_OPTIONS \
+{   \
+.name = BLOCK_OPT_SIZE, \
+.type = QEMU_OPT_SIZE,  \
+.help = "Virtual disk size" \
+},  \
+{   \
+.name = BLOCK_OPT_COMPAT_LEVEL, \
+.type = QEMU_OPT_STRING,\
+.help = "Compatibility level (v2 [0.10] or v3 [1.1])"   \
+},  \
+{   \
+.name = BLOCK_OPT_BACKING_FILE, \
+.type = QEMU_OPT_STRING,\
+.help = "File name of a base image" \
+},  \
+{   \
+.name = BLOCK_OPT_BACKING_FMT,  \
+.type = QEMU_OPT_STRING,