Re: [PULL 0/5] target/alpha patch queue
Patchew URL: https://patchew.org/QEMU/20210628143551.2870006-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210628143551.2870006-1-richard.hender...@linaro.org Subject: [PULL 0/5] target/alpha patch queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210626063631.2411938-1-richard.hender...@linaro.org -> patchew/20210626063631.2411938-1-richard.hender...@linaro.org * [new tag] patchew/20210628143551.2870006-1-richard.hender...@linaro.org -> patchew/20210628143551.2870006-1-richard.hender...@linaro.org Switched to a new branch 'test' ed4257d target/alpha: Honor the FEN bit 3ac025b pc-bios: Update the palcode-clipper image 7e1e351 hw/alpha: Provide a PCI-ISA bridge device node 3eef833 hw/alpha: Provide console information to the PALcode at start-up a8c7129 hw/alpha: Set minimum PCI device ID to 1 to match Clipper IRQ mappings === OUTPUT BEGIN === 1/5 Checking commit a8c712990763 (hw/alpha: Set minimum PCI device ID to 1 to match Clipper IRQ mappings) 2/5 Checking commit 3eef83314e10 (hw/alpha: Provide console information to the PALcode at start-up) 3/5 Checking commit 7e1e351547ea (hw/alpha: Provide a PCI-ISA bridge device node) ERROR: spaces required around that '*' (ctx:WxV) #54: FILE: hw/alpha/alpha_sys.h:13: +PCIBus *typhoon_init(MemoryRegion *, qemu_irq *, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 125 lines checked Patch 3/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/5 Checking commit 3ac025b1abb7 (pc-bios: Update the palcode-clipper image) 5/5 Checking commit ed4257d84084 (target/alpha: Honor the FEN bit) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210628143551.2870006-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/18] target/arm: Second slice of MVE implementation
Patchew URL: https://patchew.org/QEMU/20210628135835.6690-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210628135835.6690-1-peter.mayd...@linaro.org Subject: [PATCH 00/18] target/arm: Second slice of MVE implementation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210628113047.462498-1-berra...@redhat.com -> patchew/20210628113047.462498-1-berra...@redhat.com * [new tag] patchew/20210628135835.6690-1-peter.mayd...@linaro.org -> patchew/20210628135835.6690-1-peter.mayd...@linaro.org Switched to a new branch 'test' 85b5d3e target/arm: Implement MVE shifts by register 33b8434 target/arm: Implement MVE shifts by immediate e28665d target/arm: Implement MVE long shifts by register bfa1b65 target/arm: Implement MVE long shifts by immediate 03ce1de target/arm: Implement MVE VADDLV 9131ded target/arm: Implement MVE VSHLC 37a01d1 target/arm: Implement MVE saturating narrowing shifts 86f6ee0 target/arm: Implement MVE VSHRN, VRSHRN 05463f1 target/arm: Implement MVE VSRI, VSLI 25969c7 target/arm: Implement MVE VSHLL 644c6a3 target/arm: Implement MVE vector shift right by immediate insns c9d27a6 target/arm: Implement MVE vector shift left by immediate insns 96cef79 target/arm: Implement MVE logical immediate insns 829b634 target/arm: Use dup_const() instead of bitfield_replicate() 56573af target/arm: Use asimd_imm_const for A64 decode a7f15a0 target/arm: Make asimd_imm_const() public 908a1ae target/arm: Fix bugs in MVE VRMLALDAVH, VRMLSLDAVH 60ff08a target/arm: Fix MVE widening/narrowing VLDR/VSTR offset calculation === OUTPUT BEGIN === 1/18 Checking commit 60ff08a2237f (target/arm: Fix MVE widening/narrowing VLDR/VSTR offset calculation) 2/18 Checking commit 908a1ae70d47 (target/arm: Fix bugs in MVE VRMLALDAVH, VRMLSLDAVH) 3/18 Checking commit a7f15a071127 (target/arm: Make asimd_imm_const() public) 4/18 Checking commit 56573af7e364 (target/arm: Use asimd_imm_const for A64 decode) 5/18 Checking commit 829b634182f9 (target/arm: Use dup_const() instead of bitfield_replicate()) 6/18 Checking commit 96cef793eb97 (target/arm: Implement MVE logical immediate insns) 7/18 Checking commit c9d27a6b4f36 (target/arm: Implement MVE vector shift left by immediate insns) 8/18 Checking commit 644c6a3a67b6 (target/arm: Implement MVE vector shift right by immediate insns) 9/18 Checking commit 25969c777287 (target/arm: Implement MVE VSHLL) 10/18 Checking commit 05463f17e19b (target/arm: Implement MVE VSRI, VSLI) WARNING: Block comments use a leading /* on a separate line #70: FILE: target/arm/mve_helper.c:1264: +/* \ WARNING: Block comments use a leading /* on a separate line #79: FILE: target/arm/mve_helper.c:1273: +/* ESIZE / 2 gives the MO_* value if ESIZE is in [1,2,4] */ \ total: 0 errors, 2 warnings, 80 lines checked Patch 10/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/18 Checking commit 86f6ee0dc542 (target/arm: Implement MVE VSHRN, VRSHRN) 12/18 Checking commit 37a01d116824 (target/arm: Implement MVE saturating narrowing shifts) 13/18 Checking commit 9131dedb2193 (target/arm: Implement MVE VSHLC) ERROR: spaces required around that '*' (ctx:WxV) #95: FILE: target/arm/translate-mve.c:942: +static bool trans_VSHLC(DisasContext *s, arg_VSHLC *a) ^ total: 1 errors, 0 warnings, 84 lines checked Patch 13/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/18 Checking commit 03ce1decda5e (target/arm: Implement MVE VADDLV) 15/18 Checking commit bfa1b652a800 (target/arm: Implement MVE long shifts by immediate) 16/18 Checking commit e28665d91923 (target/arm: Implement MVE long shifts by register) 17/18 Checking commit 33b8434e3743 (target/arm: Implement MVE shifts by immediate) 18/18 Checking commit 85b5d3e63387 (target/arm: Implement MVE shifts by register) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210628135835.6690-1-peter.mayd...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v3 00/29] tcg: bswap improvements
Patchew URL:
https://patchew.org/QEMU/20210626063631.2411938-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210626063631.2411938-1-richard.hender...@linaro.org
Subject: [PATCH v3 00/29] tcg: bswap improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210625112741.12566-1-alex.ben...@linaro.org ->
patchew/20210625112741.12566-1-alex.ben...@linaro.org
* [new tag]
patchew/20210626063631.2411938-1-richard.hender...@linaro.org ->
patchew/20210626063631.2411938-1-richard.hender...@linaro.org
Switched to a new branch 'test'
e51efe0 tcg/riscv: Remove MO_BSWAP handling
4041b9f tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP
f136558 tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP
bcdc1b2 target/mips: Fix gen_mxu_s32ldd_s32lddr
6a4cd59 target/sh4: Improve swap.b translation
8477587 target/i386: Improve bswap translation
26ccc66 target/arm: Improve REVSH
da8e43e target/arm: Improve vector REV
fa6d277 target/arm: Improve REV32
88f5dcd tcg: Make use of bswap flags in tcg_gen_qemu_st_*
b0a635f tcg: Make use of bswap flags in tcg_gen_qemu_ld_*
3d607ce tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64
5357a0f tcg: Handle new bswap flags during optimize
bdb935c tcg/tci: Support bswap flags
af073d6 tcg/mips: Support bswap flags in tcg_out_bswap32
175d16f tcg/mips: Support bswap flags in tcg_out_bswap16
44fa033 tcg/s390: Support bswap flags
4399baa tcg/ppc: Use power10 byte-reverse instructions
54fe3bc tcg/ppc: Support bswap flags
44cc7ec tcg/ppc: Split out tcg_out_bswap64
012d7ff tcg/ppc: Split out tcg_out_bswap32
c10c9c8 tcg/ppc: Split out tcg_out_bswap16
1a8ab31 tcg/ppc: Split out tcg_out_sari{32,64}
70c6864 tcg/ppc: Split out tcg_out_ext{8,16,32}s
ec5717b tcg/arm: Support bswap flags
935c80a tcg/aarch64: Support bswap flags
d4e209d tcg/aarch64: Merge tcg_out_rev{16,32,64}
6697c42 tcg/i386: Support bswap flags
0b04ca4 tcg: Add flags argument to bswap opcodes
=== OUTPUT BEGIN ===
1/29 Checking commit 0b04ca4453f6 (tcg: Add flags argument to bswap opcodes)
2/29 Checking commit 6697c42f1198 (tcg/i386: Support bswap flags)
3/29 Checking commit d4e209dd23d4 (tcg/aarch64: Merge tcg_out_rev{16,32,64})
4/29 Checking commit 935c80acf207 (tcg/aarch64: Support bswap flags)
5/29 Checking commit ec5717bed008 (tcg/arm: Support bswap flags)
6/29 Checking commit 70c6864db927 (tcg/ppc: Split out tcg_out_ext{8,16,32}s)
7/29 Checking commit 1a8ab31694c7 (tcg/ppc: Split out tcg_out_sari{32,64})
8/29 Checking commit c10c9c82f0ce (tcg/ppc: Split out tcg_out_bswap16)
9/29 Checking commit 012d7ff11df3 (tcg/ppc: Split out tcg_out_bswap32)
10/29 Checking commit 44cc7ec9595f (tcg/ppc: Split out tcg_out_bswap64)
11/29 Checking commit 54fe3bceabce (tcg/ppc: Support bswap flags)
12/29 Checking commit 4399baae7d7f (tcg/ppc: Use power10 byte-reverse
instructions)
13/29 Checking commit 44fa033dda86 (tcg/s390: Support bswap flags)
14/29 Checking commit 175d16f1fd15 (tcg/mips: Support bswap flags in
tcg_out_bswap16)
15/29 Checking commit af073d696654 (tcg/mips: Support bswap flags in
tcg_out_bswap32)
16/29 Checking commit bdb935c7d39b (tcg/tci: Support bswap flags)
17/29 Checking commit 5357a0ff6ff5 (tcg: Handle new bswap flags during optimize)
ERROR: spaces required around that ':' (ctx:VxE)
#41: FILE: tcg/optimize.c:1034:
+CASE_OP_32_64(bswap16):
^
ERROR: spaces required around that ':' (ctx:VxE)
#94: FILE: tcg/optimize.c:1189:
+CASE_OP_32_64(bswap16):
^
ERROR: spaces required around that ':' (ctx:VxE)
#95: FILE: tcg/optimize.c:1190:
+CASE_OP_32_64(bswap32):
^
total: 3 errors, 0 warnings, 82 lines checked
Patch 17/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/29 Checking commit 3d607ce1c6ac (tcg: Add flags argument to
tcg_gen_bswap16_*, tcg_gen_bswap32_i64)
ERROR: code indent should never use tabs
#165: FILE: target/sh4/translate.c:680:
+^Itcg_gen_bswap16_i32(low, low, TCG_BSWAP_IZ | TCG_BSWAP_OZ);$
total: 1 errors, 0 warnings, 296 lines checked
Patch 18/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/29 Checking commit b0a635f9e25a (tcg: Make use of bswap flags in
tcg_gen_qemu_ld_*)
20/29 Checking commit 88f5dcdc4280 (tcg: Make use of bswap flags in
tcg_gen_qemu_st_*)
21/29 Checking commit fa6d27781f5f (target/arm: Improve REV32)
22/29 Checking
Re: [PATCH v4 00/16] tcg/s390x: host vector support
Patchew URL:
https://patchew.org/QEMU/20210626050307.2408505-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210626050307.2408505-1-richard.hender...@linaro.org
Subject: [PATCH v4 00/16] tcg/s390x: host vector support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update]
patchew/1624662174-175828-1-git-send-email-joe.koml...@xilinx.com ->
patchew/1624662174-175828-1-git-send-email-joe.koml...@xilinx.com
* [new tag]
patchew/20210626050307.2408505-1-richard.hender...@linaro.org ->
patchew/20210626050307.2408505-1-richard.hender...@linaro.org
Switched to a new branch 'test'
450f369 tcg/s390x: Implement TCG_TARGET_HAS_cmpsel_vec
8e21c6d tcg/s390x: Implement TCG_TARGET_HAS_bitsel_vec
08ee9ea tcg/s390x: Implement TCG_TARGET_HAS_sat_vec
d8965f5 tcg: Expand usadd/ussub with umin/umax
c0e682e tcg/s390x: Implement TCG_TARGET_HAS_minmax_vec
0da72da tcg/s390x: Implement vector shift operations
74cabba tcg/s390x: Implement TCG_TARGET_HAS_mul_vec
6802563 tcg/s390x: Implement andc, orc, abs, neg, not vector operations
2e6a1d1 tcg/s390x: Implement minimal vector operations
79d9159 tcg/s390x: Implement tcg_out_dup*_vec
bea702b tcg/s390x: Implement tcg_out_mov for vector types
0f3391a tcg/s390x: Implement tcg_out_ld/st for vector types
f42d835 tcg/s390x: Add host vector framework
9177ed4 tcg/s390x: Merge TCG_AREG0 and TCG_REG_CALL_STACK into TCGReg
2a4f62a tcg/s390x: Change FACILITY representation
a658bf1 tcg/s390x: Rename from tcg/s390
=== OUTPUT BEGIN ===
1/16 Checking commit a658bf1e830e (tcg/s390x: Rename from tcg/s390)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
tcg/{s390 => s390x}/tcg-target-con-set.h | 0
total: 0 errors, 1 warnings, 8 lines checked
Patch 1/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/16 Checking commit 2a4f62a50f8b (tcg/s390x: Change FACILITY representation)
3/16 Checking commit 9177ed47e299 (tcg/s390x: Merge TCG_AREG0 and
TCG_REG_CALL_STACK into TCGReg)
4/16 Checking commit f42d8359719e (tcg/s390x: Add host vector framework)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#332:
new file mode 100644
total: 0 errors, 1 warnings, 290 lines checked
Patch 4/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/16 Checking commit 0f3391aaa2cd (tcg/s390x: Implement tcg_out_ld/st for
vector types)
6/16 Checking commit bea702b5073d (tcg/s390x: Implement tcg_out_mov for vector
types)
7/16 Checking commit 79d91599ec9d (tcg/s390x: Implement tcg_out_dup*_vec)
8/16 Checking commit 2e6a1d1cabb0 (tcg/s390x: Implement minimal vector
operations)
9/16 Checking commit 6802563e3047 (tcg/s390x: Implement andc, orc, abs, neg,
not vector operations)
10/16 Checking commit 74cabba13647 (tcg/s390x: Implement TCG_TARGET_HAS_mul_vec)
11/16 Checking commit 0da72da189bc (tcg/s390x: Implement vector shift
operations)
12/16 Checking commit c0e682e2f209 (tcg/s390x: Implement
TCG_TARGET_HAS_minmax_vec)
13/16 Checking commit d8965f562f5c (tcg: Expand usadd/ussub with umin/umax)
14/16 Checking commit 08ee9eacc1e8 (tcg/s390x: Implement TCG_TARGET_HAS_sat_vec)
ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: tcg/s390x/tcg-target.c.inc:2892:
+tcg_debug_assert (vece < MO_64);
total: 1 errors, 0 warnings, 112 lines checked
Patch 14/16 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/16 Checking commit 8e21c6dcca74 (tcg/s390x: Implement
TCG_TARGET_HAS_bitsel_vec)
16/16 Checking commit 450f369a36f2 (tcg/s390x: Implement
TCG_TARGET_HAS_cmpsel_vec)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210626050307.2408505-1-richard.hender...@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [RFC] block/mirror: fix file-system went to read-only after block-mirror
Patchew URL: https://patchew.org/QEMU/20210624120635.54573-1-caojinh...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210624120635.54573-1-caojinh...@huawei.com Subject: [RFC] block/mirror: fix file-system went to read-only after block-mirror === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210624120635.54573-1-caojinh...@huawei.com -> patchew/20210624120635.54573-1-caojinh...@huawei.com Switched to a new branch 'test' 6e2ba54 block/mirror: fix file-system went to read-only after block-mirror === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 19 lines checked Commit 6e2ba547f042 (block/mirror: fix file-system went to read-only after block-mirror) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210624120635.54573-1-caojinh...@huawei.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/2] Audio 20210624 patches
Patchew URL:
https://patchew.org/QEMU/20210624121639.2422367-1-kra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210624121639.2422367-1-kra...@redhat.com
Subject: [PULL 0/2] Audio 20210624 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210624121639.2422367-1-kra...@redhat.com ->
patchew/20210624121639.2422367-1-kra...@redhat.com
Switched to a new branch 'test'
b397205 hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h
8b66bf4 coreaudio: Lock only the buffer
=== OUTPUT BEGIN ===
1/2 Checking commit 8b66bf451269 (coreaudio: Lock only the buffer)
ERROR: space prohibited between function name and open parenthesis '('
#61: FILE: audio/coreaudio.c:245:
+static int coreaudio_buf_lock (coreaudioVoiceOut *core, const char *fn_name)
ERROR: space prohibited between function name and open parenthesis '('
#66: FILE: audio/coreaudio.c:249:
+err = pthread_mutex_lock (>buf_mutex);
ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: audio/coreaudio.c:258:
+static int coreaudio_buf_unlock (coreaudioVoiceOut *core, const char *fn_name)
ERROR: space prohibited between function name and open parenthesis '('
#80: FILE: audio/coreaudio.c:262:
+err = pthread_mutex_unlock (>buf_mutex);
ERROR: space prohibited between function name and open parenthesis '('
#117: FILE: audio/coreaudio.c:314:
+if (coreaudio_buf_lock (core, "audioDeviceIOProc")) {
ERROR: space prohibited between function name and open parenthesis '('
#124: FILE: audio/coreaudio.c:320:
+coreaudio_buf_unlock (core, "audioDeviceIOProc(old device)");
ERROR: space prohibited between function name and open parenthesis '('
#133: FILE: audio/coreaudio.c:330:
+coreaudio_buf_unlock (core, "audioDeviceIOProc(empty)");
ERROR: space prohibited between function name and open parenthesis '('
#142: FILE: audio/coreaudio.c:352:
+coreaudio_buf_unlock (core, "audioDeviceIOProc");
total: 8 errors, 0 warnings, 237 lines checked
Patch 1/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/2 Checking commit b39720569bf6 (hw/audio/sb16: Restrict I/O sampling rate
range for command 41h/42h)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210624121639.2422367-1-kra...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v3 00/37] target/riscv: support packed extension v0.9.4
Patchew URL: https://patchew.org/QEMU/20210624105521.3964-1-zhiwei_...@c-sky.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210624105521.3964-1-zhiwei_...@c-sky.com Subject: [PATCH v3 00/37] target/riscv: support packed extension v0.9.4 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210624105521.3964-1-zhiwei_...@c-sky.com -> patchew/20210624105521.3964-1-zhiwei_...@c-sky.com - [tag update] patchew/20210624110057.2398779-1-kra...@redhat.com -> patchew/20210624110057.2398779-1-kra...@redhat.com Switched to a new branch 'test' 9b8479a target/riscv: configure and turn on packed extension from command line a45d6c5 target/riscv: RV64 Only 32-bit Packing Instructions 407cee3 target/riscv: RV64 Only Non-SIMD 32-bit Shift Instructions fc3b523 target/riscv: RV64 Only 32-bit Parallel Multiply & Add Instructions edcd5eb target/riscv: RV64 Only 32-bit Multiply & Add Instructions b6cfe0b target/riscv: RV64 Only 32-bit Multiply Instructions 64f89a9 target/riscv: RV64 Only SIMD Q15 saturating Multiply Instructions 530eb0d target/riscv: RV64 Only SIMD 32-bit Miscellaneous Instructions a2cf3f0 target/riscv: RV64 Only SIMD 32-bit Shift Instructions 3c17d19 target/riscv: RV64 Only SIMD 32-bit Add/Subtract Instructions 7c1677e target/riscv: Non-SIMD Miscellaneous Instructions 0f7c4bc target/riscv: 32-bit Computation Instructions 261a6cd target/riscv: Non-SIMD Q31 saturation ALU Instructions 9ad5f0e target/riscv: Non-SIMD Q15 saturation ALU Instructions c431031 target/riscv: Signed 16-bit Multiply with 64-bit Add/Subtract Instructions 6c54d3f target/riscv: 32-bit Multiply 64-bit Add/Subtract Instructions 2146a16 target/riscv: 64-bit Add/Subtract Instructions e9714d0 target/riscv: 8-bit Multiply with 32-bit Add Instructions cbdec32 target/riscv: Partial-SIMD Miscellaneous Instructions 50cc545 target/riscv: Signed 16-bit Multiply 64-bit Add/Subtract Instructions 4ae4970 target/riscv: Signed 16-bit Multiply 32-bit Add/Subtract Instructions 5b89c3e target/riscv: Signed MSW 32x16 Multiply and Add Instructions e22fe8e target/riscv: Signed MSW 32x32 Multiply and Add Instructions debaecc target/riscv: 16-bit Packing Instructions 2fd15e5 target/riscv: 8-bit Unpacking Instructions 794a74f target/riscv: SIMD 8-bit Miscellaneous Instructions c2335b3 target/riscv: SIMD 16-bit Miscellaneous Instructions ee1ae43 target/riscv: SIMD 8-bit Multiply Instructions 9e59b92 target/riscv: SIMD 16-bit Multiply Instructions 115514d target/riscv: SIMD 8-bit Compare Instructions cc55d93 target/riscv: SIMD 16-bit Compare Instructions e757496 target/riscv: SIMD 8-bit Shift Instructions 2b52ff7 target/riscv: SIMD 16-bit Shift Instructions e56faaa target/riscv: 8-bit Addition & Subtraction Instruction 2c34bbb target/riscv: 16-bit Addition & Subtraction Instructions 7bb9dfe target/riscv: Make the vector helper functions public c3692b9 target/riscv: implementation-defined constant parameters === OUTPUT BEGIN === 1/37 Checking commit c3692b9f2f20 (target/riscv: implementation-defined constant parameters) 2/37 Checking commit 7bb9dfe4b2a0 (target/riscv: Make the vector helper functions public) 3/37 Checking commit 2c34bbbccfb0 (target/riscv: 16-bit Addition & Subtraction Instructions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #100: new file mode 100644 ERROR: space prohibited after that '*' (ctx:BxW) #140: FILE: target/riscv/insn_trans/trans_rvp.c.inc:36: + void (* vecop)(TCGv, TCGv, TCGv), ^ ERROR: space prohibited after that '*' (ctx:BxW) #141: FILE: target/riscv/insn_trans/trans_rvp.c.inc:37: + void (* op)(TCGv, TCGv, TCGv)) ^ ERROR: space prohibited after that '*' (ctx:BxW) #166: FILE: target/riscv/insn_trans/trans_rvp.c.inc:62: +r_ool(DisasContext *ctx, arg_r *a, void (* fn)(TCGv, TCGv_ptr, TCGv, TCGv)) ^ total: 3 errors, 1 warnings, 553 lines checked Patch 3/37 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/37 Checking commit e56faaada505 (target/riscv: 8-bit Addition & Subtraction Instruction) 5/37 Checking commit 2b52ff7cb72a (target/riscv: SIMD 16-bit Shift Instructions) ERROR: space prohibited after that '*' (ctx:BxW) #100: FILE: target/riscv/insn_trans/trans_rvp.c.inc:144: + void (* fn)(TCGv, TCGv_ptr, TCGv, TCGv)) ^ ERROR: space prohibited after that '*' (ctx:BxW) #120: FILE: target/riscv/insn_trans/trans_rvp.c.inc:164: + void (* vecop)(TCGv,
Re: [RFC v1 0/1] ui: Add a Wayland backend for Qemu UI
Patchew URL:
https://patchew.org/QEMU/20210624041040.1250631-1-vivek.kasire...@intel.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210624041040.1250631-1-vivek.kasire...@intel.com
Subject: [RFC v1 0/1] ui: Add a Wayland backend for Qemu UI
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210624041040.1250631-1-vivek.kasire...@intel.com
-> patchew/20210624041040.1250631-1-vivek.kasire...@intel.com
Switched to a new branch 'test'
547ce45 ui: Add a plain Wayland backend for Qemu UI
=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#260:
new file mode 100644
WARNING: line over 80 characters
#266: FILE: ui/wayland.c:2:
+ * Wayland UI -- A simple Qemu UI backend to share buffers with Wayland
compositors
ERROR: use QEMU instead of Qemu or QEmu
#266: FILE: ui/wayland.c:2:
+ * Wayland UI -- A simple Qemu UI backend to share buffers with Wayland
compositors
ERROR: line over 90 characters
#271: FILE: ui/wayland.c:7:
+ * Mostly (boilerplate) based on
cgit.freedesktop.org/wayland/weston/tree/clients/simple-dmabuf-egl.c
ERROR: code indent should never use tabs
#318: FILE: ui/wayland.c:54:
+^I^I^I uint32_t serial)$
ERROR: code indent should never use tabs
#329: FILE: ui/wayland.c:65:
+^I^I^I int32_t width, int32_t height,$
ERROR: code indent should never use tabs
#330: FILE: ui/wayland.c:66:
+^I^I^I struct wl_array *states)$
ERROR: code indent should never use tabs
#459: FILE: ui/wayland.c:195:
+^Ierror_report("Can't find free buffer\n");$
ERROR: Error messages should not contain newlines
#459: FILE: ui/wayland.c:195:
+ error_report("Can't find free buffer\n");
ERROR: code indent should never use tabs
#519: FILE: ui/wayland.c:255:
+^I^I uint32_t format, uint32_t modifier_hi, uint32_t modifier_lo)$
ERROR: code indent should never use tabs
#552: FILE: ui/wayland.c:288:
+^I^I^I id, _compositor_interface, 1);$
ERROR: code indent should never use tabs
#554: FILE: ui/wayland.c:290:
+^Id->wm_base = wl_registry_bind(registry,$
ERROR: code indent should never use tabs
#555: FILE: ui/wayland.c:291:
+^I^I^I^I id, _wm_base_interface, 1);$
ERROR: code indent should never use tabs
#556: FILE: ui/wayland.c:292:
+^Ixdg_wm_base_add_listener(d->wm_base, _base_listener, d);$
ERROR: code indent should never use tabs
#558: FILE: ui/wayland.c:294:
+^Id->fshell = wl_registry_bind(registry,$
ERROR: code indent should never use tabs
#559: FILE: ui/wayland.c:295:
+^I id, _fullscreen_shell_v1_interface,$
ERROR: code indent should never use tabs
#560: FILE: ui/wayland.c:296:
+^I 1);$
ERROR: code indent should never use tabs
#562: FILE: ui/wayland.c:298:
+^Id->dmabuf = wl_registry_bind(registry,$
ERROR: code indent should never use tabs
#563: FILE: ui/wayland.c:299:
+^I id, _linux_dmabuf_v1_interface, 3);$
ERROR: code indent should never use tabs
#564: FILE: ui/wayland.c:300:
+^Izwp_linux_dmabuf_v1_add_listener(d->dmabuf, _listener,$
ERROR: code indent should never use tabs
#565: FILE: ui/wayland.c:301:
+^I d);$
ERROR: code indent should never use tabs
#593: FILE: ui/wayland.c:329:
+^Ierror_report("No zwp_linux_dmabuf global\n");$
ERROR: Error messages should not contain newlines
#593: FILE: ui/wayland.c:329:
+ error_report("No zwp_linux_dmabuf global\n");
ERROR: code indent should never use tabs
#594: FILE: ui/wayland.c:330:
+^Iexit(1);$
ERROR: code indent should never use tabs
#609: FILE: ui/wayland.c:345:
+^I window->surface);$
ERROR: code indent should never use tabs
#621: FILE: ui/wayland.c:357:
+^Iwindow->surface,$
ERROR: line over 90 characters
#622: FILE: ui/wayland.c:358:
+
ZWP_FULLSCREEN_SHELL_V1_PRESENT_METHOD_DEFAULT,
ERROR: code indent should never use tabs
#622: FILE: ui/wayland.c:358:
+^I^I
ZWP_FULLSCREEN_SHELL_V1_PRESENT_METHOD_DEFAULT,$
ERROR: code indent should never use tabs
#623: FILE: ui/wayland.c:359:
+^I^INULL);$
total: 27 errors, 2 warnings, 607 lines checked
Commit 547ce45b800d (ui: Add a plain Wayland backend for Qemu UI) has style
problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
Re: [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles
Patchew URL: https://patchew.org/QEMU/20210623142245.307776-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210623142245.307776-1-berra...@redhat.com Subject: [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210622154820.1978982-1-richard.hender...@linaro.org -> patchew/20210622154820.1978982-1-richard.hender...@linaro.org * [new tag] patchew/20210623142245.307776-1-berra...@redhat.com -> patchew/20210623142245.307776-1-berra...@redhat.com Switched to a new branch 'test' 9758826 tests/docker: remove ubuntu container ef3ef4e tests/docker: auto-generate opensuse-leap with lcitool 895aed9 tests/docker: auto-generate ubuntu2004 with lcitool 2119de5 tests/docker: auto-generate ubuntu1804 with lcitool 03e1cd3 tests/docker: auto-generate fedora with lcitool c62c731 tests/docker: auto-generate centos8 with lcitool d64ab33 tests/docker: add script for automating container refresh c2baddd tests/docker: expand opensuse-leap package list 3dd08f6 tests/docker: expand ubuntu2004 package list 0b1a6dd tests/docker: expand ubuntu1804 package list e518827 tests/docker: expand fedora package list d19b072 tests/docker: expand centos8 package list e281ae9 tests/docker: remove mingw packages from Fedora 574be70 tests/docker: fix mistakes in ubuntu package lists 88cd410 tests/docker: fix mistakes in fedora package list bfc10c9 tests/docker: fix mistakes in centos package lists 4c6b851 tests/docker: fix sorting in package lists f923bf8 tests/docker: remove FEATURES env var from templates 6ba5000 tests/docker: use explicit docker.io registry c579052 tests/docker: use project specific container registries 7bd0b09 tests/docker: don't use BUILDKIT in GitLab either 155fe73 hw/usb/ccid: remove references to NSS === OUTPUT BEGIN === 1/22 Checking commit 155fe7320a76 (hw/usb/ccid: remove references to NSS) 2/22 Checking commit 7bd0b09da0eb (tests/docker: don't use BUILDKIT in GitLab either) 3/22 Checking commit c5790521a51c (tests/docker: use project specific container registries) 4/22 Checking commit 6ba5000cb228 (tests/docker: use explicit docker.io registry) 5/22 Checking commit f923bf8c6a02 (tests/docker: remove FEATURES env var from templates) 6/22 Checking commit 4c6b85101644 (tests/docker: fix sorting in package lists) 7/22 Checking commit bfc10c97c4b9 (tests/docker: fix mistakes in centos package lists) 8/22 Checking commit 88cd410064a6 (tests/docker: fix mistakes in fedora package list) 9/22 Checking commit 574be70f0bbe (tests/docker: fix mistakes in ubuntu package lists) 10/22 Checking commit e281ae966f35 (tests/docker: remove mingw packages from Fedora) 11/22 Checking commit d19b07286aaa (tests/docker: expand centos8 package list) 12/22 Checking commit e518827eb832 (tests/docker: expand fedora package list) 13/22 Checking commit 0b1a6dd81adf (tests/docker: expand ubuntu1804 package list) 14/22 Checking commit 3dd08f63b4f6 (tests/docker: expand ubuntu2004 package list) 15/22 Checking commit c2baddde6702 (tests/docker: expand opensuse-leap package list) 16/22 Checking commit d64ab332097d (tests/docker: add script for automating container refresh) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #114: new file mode 100755 total: 0 errors, 1 warnings, 123 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit c62c7311eed8 (tests/docker: auto-generate centos8 with lcitool) 18/22 Checking commit 03e1cd3c038c (tests/docker: auto-generate fedora with lcitool) 19/22 Checking commit 2119de590b58 (tests/docker: auto-generate ubuntu1804 with lcitool) 20/22 Checking commit 895aed9013c2 (tests/docker: auto-generate ubuntu2004 with lcitool) ERROR: line over 90 characters #28: FILE: tests/docker/dockerfiles-refresh.py:65: + "RUN sed -i 's/^const/static const/g' /usr/lib/llvm-10/lib/clang/10.0.0/include/sanitizer/tsan_interface.h\n"] total: 1 errors, 0 warnings, 270 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit ef3ef4e88131 (tests/docker: auto-generate opensuse-leap with lcitool) 22/22 Checking commit 975882640606 (tests/docker: remove ubuntu container) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: deleted file mode 100644 total: 0 errors, 1
Re: [PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting
Patchew URL: https://patchew.org/QEMU/20210623023250.3667563-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210623023250.3667563-1-...@linux.ibm.com Subject: [PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com -> patchew/20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com * [new tag] patchew/20210623023250.3667563-1-...@linux.ibm.com -> patchew/20210623023250.3667563-1-...@linux.ibm.com Switched to a new branch 'test' 56bc4f3 tests/tcg/s390x: Test SIGILL and SIGSEGV handling b6b6d39 target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting === OUTPUT BEGIN === 1/2 Checking commit b6b6d3978456 (target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting) 2/2 Checking commit 56bc4f3bb893 (tests/tcg/s390x: Test SIGILL and SIGSEGV handling) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: externs should be avoided in .c files #44: FILE: tests/tcg/s390x/signal.c:14: +void illegal_op(void); ERROR: externs should be avoided in .c files #45: FILE: tests/tcg/s390x/signal.c:15: +void after_illegal_op(void); ERROR: externs should be avoided in .c files #51: FILE: tests/tcg/s390x/signal.c:21: +void stg(void *dst, unsigned long src); ERROR: externs should be avoided in .c files #56: FILE: tests/tcg/s390x/signal.c:26: +void mvc_8(void *dst, void *src); total: 4 errors, 1 warnings, 169 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210623023250.3667563-1-...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/1] Add features and cpu models
Patchew URL:
https://patchew.org/QEMU/20210622201923.150205-1-borntrae...@de.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210622201923.150205-1-borntrae...@de.ibm.com
Subject: [PATCH 0/1] Add features and cpu models
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b71b2c5 s390x/cpumodel: add 3931 and 3932
=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#35: FILE: target/s390x/cpu_features_def.h.inc:113:
+DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH2, "vxpdeh2", STFL, 192,
"Vector-Packed-Decimal-Enhancement facility 2")
WARNING: line over 80 characters
#38: FILE: target/s390x/cpu_features_def.h.inc:116:
+DEF_FEAT(ACTIVITY, "activity", STFL, 196, "Processor-Activity-Instrumentation
facility")
WARNING: line over 80 characters
#59: FILE: target/s390x/cpu_models.c:817:
+{ S390_FEAT_VECTOR_PACKED_DECIMAL_ENH, S390_FEAT_VECTOR_PACKED_DECIMAL
},
WARNING: line over 80 characters
#60: FILE: target/s390x/cpu_models.c:818:
+{ S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2,
S390_FEAT_VECTOR_PACKED_DECIMAL_ENH },
total: 1 errors, 3 warnings, 73 lines checked
Commit b71b2c5056b7 (s390x/cpumodel: add 3931 and 3932) has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210622201923.150205-1-borntrae...@de.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v2] coreaudio: Lock only the buffer
Patchew URL:
https://patchew.org/QEMU/20210622201740.38005-1-akihiko.od...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210622201740.38005-1-akihiko.od...@gmail.com
Subject: [PATCH v2] coreaudio: Lock only the buffer
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210608040532.56449-1-ma.mando...@gmail.com ->
patchew/20210608040532.56449-1-ma.mando...@gmail.com
- [tag update] patchew/20210621103337.36637-1-eespo...@redhat.com ->
patchew/20210621103337.36637-1-eespo...@redhat.com
* [new tag] patchew/20210622201740.38005-1-akihiko.od...@gmail.com ->
patchew/20210622201740.38005-1-akihiko.od...@gmail.com
* [new tag] patchew/20210622201923.150205-1-borntrae...@de.ibm.com ->
patchew/20210622201923.150205-1-borntrae...@de.ibm.com
Switched to a new branch 'test'
6c7537d coreaudio: Lock only the buffer
=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#58: FILE: audio/coreaudio.c:245:
+static int coreaudio_buf_lock (coreaudioVoiceOut *core, const char *fn_name)
ERROR: space prohibited between function name and open parenthesis '('
#63: FILE: audio/coreaudio.c:249:
+err = pthread_mutex_lock (>buf_mutex);
ERROR: space prohibited between function name and open parenthesis '('
#72: FILE: audio/coreaudio.c:258:
+static int coreaudio_buf_unlock (coreaudioVoiceOut *core, const char *fn_name)
ERROR: space prohibited between function name and open parenthesis '('
#77: FILE: audio/coreaudio.c:262:
+err = pthread_mutex_unlock (>buf_mutex);
ERROR: space prohibited between function name and open parenthesis '('
#114: FILE: audio/coreaudio.c:314:
+if (coreaudio_buf_lock (core, "audioDeviceIOProc")) {
ERROR: space prohibited between function name and open parenthesis '('
#121: FILE: audio/coreaudio.c:320:
+coreaudio_buf_unlock (core, "audioDeviceIOProc(old device)");
ERROR: space prohibited between function name and open parenthesis '('
#130: FILE: audio/coreaudio.c:330:
+coreaudio_buf_unlock (core, "audioDeviceIOProc(empty)");
ERROR: space prohibited between function name and open parenthesis '('
#139: FILE: audio/coreaudio.c:352:
+coreaudio_buf_unlock (core, "audioDeviceIOProc");
total: 8 errors, 0 warnings, 237 lines checked
Commit 6c7537d704dd (coreaudio: Lock only the buffer) has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210622201740.38005-1-akihiko.od...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v2 00/29] tcg: bswap improvements
Patchew URL:
https://patchew.org/QEMU/20210621231849.1871164-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210621231849.1871164-1-richard.hender...@linaro.org
Subject: [PATCH v2 00/29] tcg: bswap improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20210621231849.1871164-1-richard.hender...@linaro.org ->
patchew/20210621231849.1871164-1-richard.hender...@linaro.org
Switched to a new branch 'test'
8a1ce95 tcg/riscv: Remove MO_BSWAP handling
042d928 tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP
b12d261 tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP
a72e94c target/mips: Fix gen_mxu_s32ldd_s32lddr
8c44e92 target/sh4: Improve swap.b translation
5def832 target/i386: Improve bswap translation
c558d58 target/arm: Improve REVSH
465157c target/arm: Improve vector REV
1fbd37e target/arm: Improve REV32
c0a1731 tcg: Make use of bswap flags in tcg_gen_qemu_st_*
446bceb tcg: Make use of bswap flags in tcg_gen_qemu_ld_*
6001384 tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64
a38add9 tcg: Handle new bswap flags during optimize
8152e2f tcg/tci: Support bswap flags
ed16867 tcg/mips: Support bswap flags in tcg_out_bswap32
1c402bf tcg/mips: Support bswap flags in tcg_out_bswap16
a21ddba tcg/s390: Support bswap flags
4c9ee2c tcg/ppc: Use power10 byte-reverse instructions
258cd29 tcg/ppc: Support bswap flags
dda8631 tcg/ppc: Split out tcg_out_bswap64
cced49b tcg/ppc: Split out tcg_out_bswap32
248ebec tcg/ppc: Split out tcg_out_bswap16
7d61b03 tcg/ppc: Split out tcg_out_sari{32,64}
69f510f tcg/ppc: Split out tcg_out_ext{8,16,32}s
fd998ad tcg/arm: Support bswap flags
2bf67ce tcg/aarch64: Support bswap flags
b14d4b1 tcg/aarch64: Merge tcg_out_rev{16,32,64}
47f04bc tcg/i386: Support bswap flags
a013bcf tcg: Add flags argument to bswap opcodes
=== OUTPUT BEGIN ===
1/29 Checking commit a013bcf9920f (tcg: Add flags argument to bswap opcodes)
2/29 Checking commit 47f04bcfbd3c (tcg/i386: Support bswap flags)
3/29 Checking commit b14d4b1a15d3 (tcg/aarch64: Merge tcg_out_rev{16,32,64})
4/29 Checking commit 2bf67ce46f28 (tcg/aarch64: Support bswap flags)
5/29 Checking commit fd998ad55098 (tcg/arm: Support bswap flags)
6/29 Checking commit 69f510fc9ccf (tcg/ppc: Split out tcg_out_ext{8,16,32}s)
7/29 Checking commit 7d61b03fe7f7 (tcg/ppc: Split out tcg_out_sari{32,64})
8/29 Checking commit 248ebecd716e (tcg/ppc: Split out tcg_out_bswap16)
9/29 Checking commit cced49b22079 (tcg/ppc: Split out tcg_out_bswap32)
10/29 Checking commit dda86314b2df (tcg/ppc: Split out tcg_out_bswap64)
11/29 Checking commit 258cd29045b2 (tcg/ppc: Support bswap flags)
12/29 Checking commit 4c9ee2ce7bfe (tcg/ppc: Use power10 byte-reverse
instructions)
13/29 Checking commit a21ddba7adfd (tcg/s390: Support bswap flags)
14/29 Checking commit 1c402bf4ea32 (tcg/mips: Support bswap flags in
tcg_out_bswap16)
15/29 Checking commit ed16867a8514 (tcg/mips: Support bswap flags in
tcg_out_bswap32)
16/29 Checking commit 8152e2fbe20b (tcg/tci: Support bswap flags)
17/29 Checking commit a38add98a8cd (tcg: Handle new bswap flags during optimize)
ERROR: spaces required around that ':' (ctx:VxE)
#41: FILE: tcg/optimize.c:1033:
+CASE_OP_32_64(bswap16):
^
ERROR: spaces required around that ':' (ctx:VxE)
#94: FILE: tcg/optimize.c:1188:
+CASE_OP_32_64(bswap16):
^
ERROR: spaces required around that ':' (ctx:VxE)
#95: FILE: tcg/optimize.c:1189:
+CASE_OP_32_64(bswap32):
^
total: 3 errors, 0 warnings, 82 lines checked
Patch 17/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/29 Checking commit 6001384c5d55 (tcg: Add flags argument to
tcg_gen_bswap16_*, tcg_gen_bswap32_i64)
ERROR: code indent should never use tabs
#165: FILE: target/sh4/translate.c:680:
+^Itcg_gen_bswap16_i32(low, low, TCG_BSWAP_IZ | TCG_BSWAP_OZ);$
total: 1 errors, 0 warnings, 296 lines checked
Patch 18/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/29 Checking commit 446bcebe129b (tcg: Make use of bswap flags in
tcg_gen_qemu_ld_*)
20/29 Checking commit c0a1731ecfa5 (tcg: Make use of bswap flags in
tcg_gen_qemu_st_*)
21/29 Checking commit 1fbd37ebe67c (target/arm: Improve REV32)
22/29 Checking commit 465157cd1fae (target/arm: Improve vector REV)
23/29 Checking commit c558d5861f46 (target/arm: Improve REVSH)
24/29 Checking
Re: [PATCH v4 0/2] target/s390x: Fix SIGILL psw.addr reporting
Patchew URL: https://patchew.org/QEMU/20210621223217.3642303-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621223217.3642303-1-...@linux.ibm.com Subject: [PATCH v4 0/2] target/s390x: Fix SIGILL psw.addr reporting === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210614083800.1166166-1-richard.hender...@linaro.org -> patchew/20210614083800.1166166-1-richard.hender...@linaro.org - [tag update] patchew/20210620213249.1494274-1-richard.hender...@linaro.org -> patchew/20210620213249.1494274-1-richard.hender...@linaro.org - [tag update] patchew/20210621152120.4465-1-alex.ben...@linaro.org -> patchew/20210621152120.4465-1-alex.ben...@linaro.org * [new tag] patchew/20210621223217.3642303-1-...@linux.ibm.com -> patchew/20210621223217.3642303-1-...@linux.ibm.com Switched to a new branch 'test' a51bd28 tests/tcg/s390x: Test SIGILL and SIGSEGV handling 78ea9f7 target/s390x: Fix SIGILL psw.addr reporting === OUTPUT BEGIN === 1/2 Checking commit 78ea9f744a64 (target/s390x: Fix SIGILL psw.addr reporting) 2/2 Checking commit a51bd281a9b9 (tests/tcg/s390x: Test SIGILL and SIGSEGV handling) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: externs should be avoided in .c files #44: FILE: tests/tcg/s390x/signal.c:14: +void illegal_op(void); ERROR: externs should be avoided in .c files #45: FILE: tests/tcg/s390x/signal.c:15: +void after_illegal_op(void); ERROR: externs should be avoided in .c files #51: FILE: tests/tcg/s390x/signal.c:21: +void stg(void *dst, unsigned long src); ERROR: externs should be avoided in .c files #56: FILE: tests/tcg/s390x/signal.c:26: +void mvc_8(void *dst, void *src); total: 4 errors, 1 warnings, 169 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210621223217.3642303-1-...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v3 0/5] virtio-gpu: Add a default synchronization mechanism for blobs
Patchew URL: https://patchew.org/QEMU/20210621192425.1188442-1-vivek.kasire...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621192425.1188442-1-vivek.kasire...@intel.com Subject: [PATCH v3 0/5] virtio-gpu: Add a default synchronization mechanism for blobs === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 53f306f..0add99e master -> master - [tag update] patchew/20210621171021.1819881-1-richard.hender...@linaro.org -> patchew/20210621171021.1819881-1-richard.hender...@linaro.org * [new tag] patchew/20210621192425.1188442-1-vivek.kasire...@intel.com -> patchew/20210621192425.1188442-1-vivek.kasire...@intel.com Switched to a new branch 'test' 33105de virtio-gpu: Add gl_flushed callback c253f9f ui/gtk-egl: Wait for the draw signal for dmabuf blobs 5909df4 ui: Create sync objects and fences only for blobs 4f7d4b6 ui/egl: Add egl helpers to help with synchronization a153fed ui/gtk: Create a common release_dmabuf helper === OUTPUT BEGIN === 1/5 Checking commit a153fed2c4e2 (ui/gtk: Create a common release_dmabuf helper) 2/5 Checking commit 4f7d4b6596ae (ui/egl: Add egl helpers to help with synchronization) ERROR: code indent should never use tabs #62: FILE: ui/egl-helpers.c:88: +^I^I^I^IEGL_SYNC_NATIVE_FENCE_ANDROID, NULL);$ total: 1 errors, 0 warnings, 48 lines checked Patch 2/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/5 Checking commit 5909df40fbc8 (ui: Create sync objects and fences only for blobs) 4/5 Checking commit c253f9f281ae (ui/gtk-egl: Wait for the draw signal for dmabuf blobs) 5/5 Checking commit 33105de28a52 (virtio-gpu: Add gl_flushed callback) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210621192425.1188442-1-vivek.kasire...@intel.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/57] target-arm queue
Patchew URL: https://patchew.org/QEMU/20210621162833.32535-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621162833.32535-1-peter.mayd...@linaro.org Subject: [PULL 00/57] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210621162833.32535-1-peter.mayd...@linaro.org -> patchew/20210621162833.32535-1-peter.mayd...@linaro.org Switched to a new branch 'test' d6d069f docs/system: arm: Add nRF boards description b851e6b target/arm: Implement MTE3 fb75a9a target/arm: Make VMOV scalar <-> gpreg beatwise for MVE 172a6d4 target/arm: Implement MVE VADDV acf229a target/arm: Implement MVE VHCADD 04091ff target/arm: Implement MVE VCADD 1deba18 target/arm: Implement MVE VADC, VSBC 68a141c target/arm: Implement MVE VRHADD ee91105 target/arm: Implement MVE VQDMULL (vector) 9a0a95f target/arm: Implement MVE VQDMLSDH and VQRDMLSDH b0346b1 target/arm: Implement MVE VQDMLADH and VQRDMLADH 8ecb102 target/arm: Implement MVE VRSHL 81f1f55 target/arm: Implement MVE VSHL insn b818d12 target/arm: Implement MVE VQRSHL 19eba8b target/arm: Implement MVE VQSHL (vector) c223aa6 target/arm: Implement MVE VQADD, VQSUB (vector) 0634d66 target/arm: Implement MVE VQDMULH, VQRDMULH (vector) f2fbaa6 target/arm: Implement MVE VQDMULL scalar 59fe264 target/arm: Implement MVE VQDMULH and VQRDMULH (scalar) 90bc3ee target/arm: Implement MVE VQADD and VQSUB bb1b4f6 target/arm: Implement MVE VPST 155d238 target/arm: Implement MVE VBRSR 9dca435 target/arm: Implement MVE VHADD, VHSUB (scalar) 397360a target/arm: Implement MVE VSUB, VMUL (scalar) 4607fad target/arm: Implement MVE VADD (scalar) 8b14f90 target/arm: Implement MVE VRMLALDAVH, VRMLSLDAVH bc45e57 target/arm: Implement MVE VMLSLDAV 67721a3 target/arm: Implement MVE VMLALDAV d3b9cb0 target/arm: Implement MVE VMULL 0022b57 target/arm: Implement MVE VHADD, VHSUB 76c9720 target/arm: Implement MVE VABD a82597c target/arm: Implement MVE VMAX, VMIN 61fac1db target/arm: Implement MVE VRMULH aafb1aa target/arm: Implement MVE VMULH b67bdc8 target/arm: Implement MVE VADD, VSUB, VMUL efc73d0 target/arm: Implement MVE VAND, VBIC, VORR, VORN, VEOR 30cabd5 target/arm: Implement MVE VDUP 1cfb396 tcg: Make gen_dup_i32/i64() public as tcg_gen_dup_i32/i64 f0579ce target/arm: Implement MVE VNEG 821be82 target/arm: Implement MVE VABS 2b148e0 target/arm: Implement MVE VMVN (register) 007f410 target/arm: Implement MVE VREV16, VREV32, VREV64 7d691ab target/arm: Implement MVE VCLS 56c40b0 target/arm: Implement MVE VCLZ 45436a4 target/arm: Implement widening/narrowing MVE VLDR/VSTR insns a4905f1 target/arm: Implement MVE VLDR/VSTR (non-widening forms) aaeca5e target/arm: Handle FPU check for FPCXT_NS insns via vfp_access_check_m() 0cb82be target/arm: Split vfp_access_check() into A and M versions 8eac39e target/arm: Factor FP context update code out into helper function cec6284 target/arm: Handle writeback in VLDR/VSTR sysreg with no memory access f4b5448 target/arm: Don't NOCP fault for FPCXT_NS accesses fe3a80f target/arm: Handle FPU being disabled in FPCXT_NS accesses 6e64550 target/arm/translate-vfp.c: Whitespace fixes 167952d docs/system/arm: Document which architecture extensions we emulate c59534f target/arm: Use acpi_ghes_present() to see if we report ACPI memory errors 263a5cc hw/acpi: Provide function acpi_ghes_present() 56b5aea hw/acpi: Provide stub version of acpi_ghes_record_errors() === OUTPUT BEGIN === 1/57 Checking commit 56b5aea2f628 (hw/acpi: Provide stub version of acpi_ghes_record_errors()) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 33 lines checked Patch 1/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/57 Checking commit 263a5cc8a35c (hw/acpi: Provide function acpi_ghes_present()) 3/57 Checking commit c59534fe8316 (target/arm: Use acpi_ghes_present() to see if we report ACPI memory errors) 4/57 Checking commit 167952dc591a (docs/system/arm: Document which architecture extensions we emulate) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 114 lines checked Patch 4/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/57 Checking commit 6e64550786b0 (target/arm/translate-vfp.c: Whitespace fixes) 6/57 Checking commit fe3a80fda9a6 (target/arm: Handle FPU being disabled in
Re: [PATCH] block/rbd: Add support for rbd image encryption
Patchew URL: https://patchew.org/QEMU/20210621142103.1417408-1-...@il.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621142103.1417408-1-...@il.ibm.com Subject: [PATCH] block/rbd: Add support for rbd image encryption === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210614083800.1166166-1-richard.hender...@linaro.org -> patchew/20210614083800.1166166-1-richard.hender...@linaro.org * [new tag] patchew/20210621142103.1417408-1-...@il.ibm.com -> patchew/20210621142103.1417408-1-...@il.ibm.com Switched to a new branch 'test' 19faaee block/rbd: Add support for rbd image encryption === OUTPUT BEGIN === ERROR: "(foo**)" should be "(foo **)" #60: FILE: block/rbd.c:374: +luks_opts->key_secret, (uint8_t**)passphrase, passphrase_len, errp); total: 1 errors, 0 warnings, 601 lines checked Commit 19faaee12b6d (block/rbd: Add support for rbd image encryption) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210621142103.1417408-1-...@il.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Patchew URL: https://patchew.org/QEMU/20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com Subject: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210526142438.281477-1-f4...@amsat.org -> patchew/20210526142438.281477-1-f4...@amsat.org - [tag update] patchew/20210614083800.1166166-1-richard.hender...@linaro.org -> patchew/20210614083800.1166166-1-richard.hender...@linaro.org * [new tag] patchew/20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com -> patchew/20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com Switched to a new branch 'test' c6b3ba6 tests/tcg: Test that compare-and-trap raises SIGFPE 7bab442 linux-user/s390x: signal with SIGFPE on compare-and-trap === OUTPUT BEGIN === 1/2 Checking commit 7bab4427a5e9 (linux-user/s390x: signal with SIGFPE on compare-and-trap) 2/2 Checking commit c6b3ba625805 (tests/tcg: Test that compare-and-trap raises SIGFPE) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 ERROR: do not initialise globals to 0 or NULL #71: FILE: tests/tcg/s390x/trap.c:42: +int sigfpe_count = 0; ERROR: do not initialise globals to 0 or NULL #72: FILE: tests/tcg/s390x/trap.c:43: +int sigill_count = 0; ERROR: trailing whitespace #83: FILE: tests/tcg/s390x/trap.c:54: +$ ERROR: trailing whitespace #116: FILE: tests/tcg/s390x/trap.c:87: +: $ total: 4 errors, 1 warnings, 104 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210621141452.2045-1-jonathan.albre...@linux.vnet.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/37] s390x update
Patchew URL: https://patchew.org/QEMU/20210621095842.335162-1-coh...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210621095842.335162-1-coh...@redhat.com
Subject: [PULL 00/37] s390x update
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
8f52174..e4bfa6c master -> master
* [new tag] patchew/20210621095842.335162-1-coh...@redhat.com ->
patchew/20210621095842.335162-1-coh...@redhat.com
Switched to a new branch 'test'
89df28e s390x/css: Add passthrough IRB
1cbff5a s390x/css: Refactor IRB construction
f8c6120 s390x/css: Split out the IRB sense data
4661ebe s390x/css: Introduce an ESW struct
b54d90b linux-user/s390x: Save and restore psw.mask properly
635ee2f target/s390x: Use s390_cpu_{set_psw, get_psw_mask} in gdbstub
58eccac target/s390x: Improve s390_cpu_dump_state vs cc_op
590d47d target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask
e887639 target/s390x: Expose load_psw and get_psw_mask to cpu.h
f848726 configure: Check whether we can compile the s390-ccw bios with
-msoft-float
2e4e10b s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2
9bf7b55 s390x/tcg: We support Vector enhancements facility
4487ef2 linux-user: elf: s390x: Prepare for Vector enhancements facility
a3a7d21 s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)
7e4827c s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)
a84f6fc s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND
(ADD|SUBTRACT)
794d69a s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE
11ad7c9 s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION
ae6979e s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED
61872e7 s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED
e611b14 s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL)
SCALAR
904505d s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *
c1396b3 s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE
ROOT)
599077a s390x/tcg: Implement 32/128 bit for VECTOR FP
(ADD|DIVIDE|MULTIPLY|SUBTRACT)
073a3b9 s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL
af9ec72 s390x/tcg: Implement VECTOR BIT PERMUTE
cf3be3a s390x/tcg: Simplify wfc64() handling
684c87b s390x/tcg: Simplify vflr64() handling
ae1579c s390x/tcg: Simplify vfll32() handling
8eb5277 s390x/tcg: Simplify vfma64() handling
abe65a0 s390x/tcg: Simplify vftci64() handling
6cd5ded s390x/tcg: Simplify vfc64() handling
75490b3 s390x/tcg: Simplify vop64_2() handling
68333d5 s390x/tcg: Simplify vop64_3() handling
c107a61 s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)
482906e s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling
425b872 s390x/kvm: remove unused gs handling
=== OUTPUT BEGIN ===
1/37 Checking commit 425b8721db83 (s390x/kvm: remove unused gs handling)
2/37 Checking commit 482906ed0f93 (s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED
NaN handling)
3/37 Checking commit c107a6181384 (s390x/tcg: Fix instruction name for VECTOR
FP LOAD (LENGTHENED|ROUNDED))
4/37 Checking commit 68333d543eae (s390x/tcg: Simplify vop64_3() handling)
5/37 Checking commit 75490b366d72 (s390x/tcg: Simplify vop64_2() handling)
6/37 Checking commit 6cd5ded287fa (s390x/tcg: Simplify vfc64() handling)
7/37 Checking commit abe65a0b9194 (s390x/tcg: Simplify vftci64() handling)
8/37 Checking commit 8eb5277b12a8 (s390x/tcg: Simplify vfma64() handling)
9/37 Checking commit ae1579cd608a (s390x/tcg: Simplify vfll32() handling)
10/37 Checking commit 684c87b68e58 (s390x/tcg: Simplify vflr64() handling)
11/37 Checking commit cf3be3aaa7a3 (s390x/tcg: Simplify wfc64() handling)
12/37 Checking commit af9ec72f5918 (s390x/tcg: Implement VECTOR BIT PERMUTE)
13/37 Checking commit 073a3b99cb58 (s390x/tcg: Implement VECTOR MULTIPLY SUM
LOGICAL)
14/37 Checking commit 599077a525f8 (s390x/tcg: Implement 32/128 bit for VECTOR
FP (ADD|DIVIDE|MULTIPLY|SUBTRACT))
15/37 Checking commit c1396b3639dd (s390x/tcg: Implement 32/128 bit for VECTOR
(LOAD FP INTEGER|FP SQUARE ROOT))
16/37 Checking commit 904505d2b4a1 (s390x/tcg: Implement 32/128 bit for VECTOR
FP COMPARE *)
WARNING: line over 80 characters
#33: FILE: target/s390x/helper.h:259:
+DEF_HELPER_FLAGS_5(gvec_vfce128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env,
i32)
WARNING: line over 80 characters
#39: FILE: target/s390x/helper.h:265:
+DEF_HELPER_FLAGS_5(gvec_vfch128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env,
i32)
WARNING: line over 80 characters
#41: FILE: target/s390x/helper.h:267:
+DEF_HELPER_FLAGS_5(gvec_vfche32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env,
i32)
WARNING: line over 80
Re: [PATCH 00/18] vhost-vDPA multiqueue
Patchew URL: https://patchew.org/QEMU/20210621041650.5826-1-jasow...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210621041650.5826-1-jasow...@redhat.com
Subject: [PATCH 00/18] vhost-vDPA multiqueue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210621041650.5826-1-jasow...@redhat.com ->
patchew/20210621041650.5826-1-jasow...@redhat.com
Switched to a new branch 'test'
f8fa9a3 vhost-vdpa: multiqueue support
8f59a43 virtio-net: vhost control virtqueue support
ec75ba0 virito-net: use "qps" instead of "queues" when possible
2bd3467 vhost-net: control virtqueue support
8276601 net: introduce control client
816e0a6 vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *
3033ddd vhost-vdpa: prepare for the multiqueue support
d3460f2 vhost-vdpa: classify one time request
3f6db79 vhost-vdpa: open device fd in net_init_vhost_vdpa()
7596feb vhost-vdpa: remove the unncessary queue_index assignment
ce7d8de vhost-vdpa: fix the wrong assertion in vhost_vdpa_init()
a8bc70a vhost-vdpa: tweak the error label in vhost_vdpa_add()
263c865 vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()
32b4c0e vhost-vdpa: don't cleanup twice in vhost_vdpa_add()
fbc405c vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()
7a12106 vhost_net: do not assume nvqs is always 2
1a9f738 vhost: use unsigned int for nvqs
5dff074 vhost_net: remove the meaningless assignment in vhost_net_start_one()
=== OUTPUT BEGIN ===
1/18 Checking commit 5dff074a8095 (vhost_net: remove the meaningless assignment
in vhost_net_start_one())
2/18 Checking commit 1a9f7380e8f0 (vhost: use unsigned int for nvqs)
3/18 Checking commit 7a12106db152 (vhost_net: do not assume nvqs is always 2)
4/18 Checking commit fbc405c2ccec (vhost-vdpa: remove the unnecessary check in
vhost_vdpa_add())
5/18 Checking commit 32b4c0e1f95c (vhost-vdpa: don't cleanup twice in
vhost_vdpa_add())
6/18 Checking commit 263c8652e706 (vhost-vdpa: fix leaking of vhost_net in
vhost_vdpa_add())
7/18 Checking commit a8bc70a72c41 (vhost-vdpa: tweak the error label in
vhost_vdpa_add())
8/18 Checking commit ce7d8de36520 (vhost-vdpa: fix the wrong assertion in
vhost_vdpa_init())
9/18 Checking commit 7596feb74e23 (vhost-vdpa: remove the unncessary
queue_index assignment)
10/18 Checking commit 3f6db79bbb54 (vhost-vdpa: open device fd in
net_init_vhost_vdpa())
11/18 Checking commit d3460f2b8886 (vhost-vdpa: classify one time request)
12/18 Checking commit 3033ddd3df9e (vhost-vdpa: prepare for the multiqueue
support)
13/18 Checking commit 816e0a62ed3b (vhost-vdpa: let net_vhost_vdpa_init()
returns NetClientState *)
14/18 Checking commit 8276601ad80d (net: introduce control client)
15/18 Checking commit 2bd3467c7183 (vhost-net: control virtqueue support)
16/18 Checking commit ec75ba0c5758 (virito-net: use "qps" instead of "queues"
when possible)
WARNING: Block comments use a leading /* on a separate line
#294: FILE: hw/net/virtio-net.c:1420:
+/* stop the backend before changing the number of qps to avoid handling a
total: 0 errors, 1 warnings, 457 lines checked
Patch 16/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/18 Checking commit 8f59a439ccf2 (virtio-net: vhost control virtqueue support)
WARNING: Block comments use a leading /* on a separate line
#55: FILE: hw/net/virtio-net.c:3373:
+/* Figure out the datapath queue pairs since the bakcend could
total: 0 errors, 1 warnings, 51 lines checked
Patch 17/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/18 Checking commit f8fa9a3e2c56 (vhost-vdpa: multiqueue support)
ERROR: braces {} are necessary for all arms of this statement
#176: FILE: net/vhost-vdpa.c:284:
+if (!ncs[i])
[...]
ERROR: braces {} are necessary for all arms of this statement
#183: FILE: net/vhost-vdpa.c:291:
+if (!nc)
[...]
total: 2 errors, 0 warnings, 165 lines checked
Patch 18/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210621041650.5826-1-jasow...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] ppc: Replace TAB indentations with spaces
Patchew URL: https://patchew.org/QEMU/20210620180410.10837-1-em...@aabouzied.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210620180410.10837-1-em...@aabouzied.com Subject: [PATCH] ppc: Replace TAB indentations with spaces === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210620180410.10837-1-em...@aabouzied.com -> patchew/20210620180410.10837-1-em...@aabouzied.com Switched to a new branch 'test' 3044710 ppc: Replace TAB indentations with spaces === OUTPUT BEGIN === ERROR: spaces required around that '*' (ctx:VxV) #279: FILE: hw/ppc/spapr.c:924: + ms->smp.max_cpus * sizeof(uint64_t)*2 + sizeof(uint64_t))); ^ total: 1 errors, 0 warnings, 287 lines checked Commit 30447102c566 (ppc: Replace TAB indentations with spaces) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210620180410.10837-1-em...@aabouzied.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] sh4: Replace TAB indentations with spaces
Patchew URL:
https://patchew.org/QEMU/20210620175452.10076-1-em...@aabouzied.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210620175452.10076-1-em...@aabouzied.com
Subject: [PATCH] sh4: Replace TAB indentations with spaces
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210531055019.10149-1-yamam...@midokura.com ->
patchew/20210531055019.10149-1-yamam...@midokura.com
- [tag update] patchew/20210601145600.3131040-1-...@linux.ibm.com ->
patchew/20210601145600.3131040-1-...@linux.ibm.com
- [tag update] patchew/20210614191729.2981488-1-raj.k...@gmail.com ->
patchew/20210614191729.2981488-1-raj.k...@gmail.com
- [tag update] patchew/20210619154253.553446-1...@weilnetz.de ->
patchew/20210619154253.553446-1...@weilnetz.de
* [new tag] patchew/20210620175452.10076-1-em...@aabouzied.com ->
patchew/20210620175452.10076-1-em...@aabouzied.com
Switched to a new branch 'test'
60b0425 sh4: Replace TAB indentations with spaces
=== OUTPUT BEGIN ===
ERROR: braces {} are necessary even for single statement blocks
#106: FILE: hw/intc/sh_intc.c:131:
+else
return INTC_MODE_DUAL_CLR;
ERROR: suspect code indent for conditional statements (8, 8)
#132: FILE: hw/intc/sh_intc.c:154:
for (i = 0; i < desc->nr_mask_regs; i++) {
+struct intc_mask_reg *mr = desc->mask_regs + i;
ERROR: braces {} are necessary for all arms of this statement
#139: FILE: hw/intc/sh_intc.c:158:
+if (mode == INTC_MODE_NONE)
[...]
ERROR: suspect code indent for conditional statements (8, 8)
#159: FILE: hw/intc/sh_intc.c:171:
for (i = 0; i < desc->nr_prio_regs; i++) {
+struct intc_prio_reg *pr = desc->prio_regs + i;
ERROR: braces {} are necessary for all arms of this statement
#166: FILE: hw/intc/sh_intc.c:175:
+if (mode == INTC_MODE_NONE)
[...]
ERROR: suspect code indent for conditional statements (4, 4)
#194: FILE: hw/intc/sh_intc.c:195:
if (!id)
+return;
ERROR: braces {} are necessary for all arms of this statement
#230: FILE: hw/intc/sh_intc.c:273:
+if ((*valuep & mask) == (value & mask))
[...]
ERROR: trailing whitespace
#235: FILE: hw/intc/sh_intc.c:276:
+printf("k = %d, first = %d, enum = %d, mask = 0x%08x\n", $
ERROR: suspect code indent for conditional statements (8, 8)
#255: FILE: hw/intc/sh_intc.c:344:
for (i = 0; i < desc->nr_mask_regs; i++) {
+struct intc_mask_reg *mr = desc->mask_regs + i;
ERROR: braces {} are necessary for all arms of this statement
#267: FILE: hw/intc/sh_intc.c:352:
+if (s)
[...]
ERROR: suspect code indent for conditional statements (8, 8)
#276: FILE: hw/intc/sh_intc.c:359:
for (i = 0; i < desc->nr_prio_regs; i++) {
+struct intc_prio_reg *pr = desc->prio_regs + i;
ERROR: braces {} are necessary for all arms of this statement
#288: FILE: hw/intc/sh_intc.c:367:
+if (s)
[...]
ERROR: suspect code indent for conditional statements (8, 8)
#297: FILE: hw/intc/sh_intc.c:374:
for (i = 0; i < nr_groups; i++) {
+struct intc_group *gr = groups + i;
ERROR: suspect code indent for conditional statements (4, 4)
#332: FILE: hw/intc/sh_intc.c:399:
for (i = 0; i < nr_vectors; i++) {
+struct intc_vect *vect = vectors + i;
ERROR: suspect code indent for conditional statements (8, 8)
#346: FILE: hw/intc/sh_intc.c:415:
for (i = 0; i < nr_groups; i++) {
+struct intc_group *gr = groups + i;
ERROR: suspect code indent for conditional statements (8, 8)
#396: FILE: hw/intc/sh_intc.c:476:
for (i = 0; i < desc->nr_mask_regs; i++) {
+struct intc_mask_reg *mr = desc->mask_regs + i;
ERROR: suspect code indent for conditional statements (8, 8)
#409: FILE: hw/intc/sh_intc.c:487:
for (i = 0; i < desc->nr_prio_regs; i++) {
+struct intc_prio_reg *pr = desc->prio_regs + i;
ERROR: suspect code indent for conditional statements (4, 4)
#425: FILE: hw/intc/sh_intc.c:507:
for (i = 0; (s = sh_intc_source(s->parent, s->next_enum_id)); i++) {
+if (i == irl)
ERROR: spaces required around that '?' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:
+sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
^
ERROR: spaces required around that ':' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:
+sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
^
ERROR: spaces required around that '?' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:
+sh_intc_toggle_source(s,
Re: [PATCH 00/12] linux-user: Load a vdso for x86_64 and hppa
Patchew URL:
https://patchew.org/QEMU/20210619034329.532318-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210619034329.532318-1-richard.hender...@linaro.org
Subject: [PATCH 00/12] linux-user: Load a vdso for x86_64 and hppa
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20210619034329.532318-1-richard.hender...@linaro.org ->
patchew/20210619034329.532318-1-richard.hender...@linaro.org
Switched to a new branch 'test'
eb8d6c9 linux-user/hppa: Add vdso and use it for rt_sigreturn
52cca21 linux-user/x86_64: Add vdso
fd7f59e linux-user: Add gen-vdso tool
5228b92 linux-user: Load vdso image if available
0fc0b1b linux-user: Introduce imgsrc_mmap
e397043 linux-user: Replace bprm->fd with bprm->src.fd
832f702 linux-user: Use ImageSource in load_symbols
9d65bf5 linux-user: Use ImageSource in load_elf_image
b04a74d linux-user: Do not clobber bprm_buf swapping ehdr
acdaddc linux-user: Tidy loader_exec
63442e1 linux-user: Introduce imgsrc_read, imgsrc_read_alloc
a4d2a45 linux-user: Fix style problems in linuxload.c
=== OUTPUT BEGIN ===
1/12 Checking commit a4d2a4511b66 (linux-user: Fix style problems in
linuxload.c)
2/12 Checking commit 63442e15ed05 (linux-user: Introduce imgsrc_read,
imgsrc_read_alloc)
3/12 Checking commit acdaddc5dc89 (linux-user: Tidy loader_exec)
4/12 Checking commit b04a74dee4d8 (linux-user: Do not clobber bprm_buf swapping
ehdr)
5/12 Checking commit 9d65bf56e0c7 (linux-user: Use ImageSource in
load_elf_image)
6/12 Checking commit 832f702ccea5 (linux-user: Use ImageSource in load_symbols)
7/12 Checking commit e3970430bd3b (linux-user: Replace bprm->fd with
bprm->src.fd)
8/12 Checking commit 0fc0b1bd7d79 (linux-user: Introduce imgsrc_mmap)
9/12 Checking commit 5228b920709c (linux-user: Load vdso image if available)
10/12 Checking commit fd7f59e94124 (linux-user: Add gen-vdso tool)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
ERROR: trailing whitespace
#31: FILE: linux-user/gen-vdso-elfn.c.inc:6:
+ * $
ERROR: spaces required around that '*' (ctx:WxV)
#92: FILE: linux-user/gen-vdso-elfn.c.inc:67:
+static void elfN(process)(FILE *outf, void *buf, long total_len,
^
ERROR: trailing whitespace
#184: FILE: linux-user/gen-vdso-elfn.c.inc:159:
+$
ERROR: trailing whitespace
#335: FILE: linux-user/gen-vdso.c:5:
+ * $
ERROR: spaces required around that ':' (ctx:VxW)
#350: FILE: linux-user/gen-vdso.c:20:
+uint16_t: __builtin_bswap16, \
^
ERROR: spaces required around that ':' (ctx:VxW)
#351: FILE: linux-user/gen-vdso.c:21:
+uint32_t: __builtin_bswap32, \
^
ERROR: spaces required around that ':' (ctx:VxW)
#352: FILE: linux-user/gen-vdso.c:22:
+uint64_t: __builtin_bswap64, \
^
ERROR: spaces required around that ':' (ctx:VxW)
#353: FILE: linux-user/gen-vdso.c:23:
+int16_t: __builtin_bswap16,\
^
ERROR: spaces required around that ':' (ctx:VxW)
#354: FILE: linux-user/gen-vdso.c:24:
+int32_t: __builtin_bswap32,\
^
ERROR: spaces required around that ':' (ctx:VxW)
#355: FILE: linux-user/gen-vdso.c:25:
+int64_t: __builtin_bswap64)
^
WARNING: Block comments use a leading /* on a separate line
#436: FILE: linux-user/gen-vdso.c:106:
+fputs("/* Automatically generated from linux-user/gen-vdso.c. */\n"
total: 10 errors, 2 warnings, 481 lines checked
Patch 10/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/12 Checking commit 52cca2161834 (linux-user/x86_64: Add vdso)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
ERROR: trailing whitespace
#70: FILE: linux-user/x86_64/vdso.S:5:
+ * $
ERROR: trailing whitespace
#198: FILE: linux-user/x86_64/vdso.ld:5:
+ * $
total: 2 errors, 1 warnings, 217 lines checked
Patch 11/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit eb8d6c9db1a6 (linux-user/hppa: Add vdso and use it for
rt_sigreturn)
WARNING: added, moved or deleted file(s),
Re: [PATCH v6 0/8] virtiofsd: Add support to enable/disable posix acls
Patchew URL:
https://patchew.org/QEMU/20210617181213.1177835-1-vgo...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210617181213.1177835-1-vgo...@redhat.com
Subject: [PATCH v6 0/8] virtiofsd: Add support to enable/disable posix acls
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210617181213.1177835-1-vgo...@redhat.com ->
patchew/20210617181213.1177835-1-vgo...@redhat.com
Switched to a new branch 'test'
c812c39 virtiofsd: Add an option to enable/disable posix acls
62af00e virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr
e93c53d virtiofsd: Add capability to change/restore umask
5588053 virtiofsd: Add umask to seccom allow list
dc2337e virtiofsd: Add support for extended setxattr
65fc720 virtiofsd: Fix xattr operations overwriting errno
967e28d virtiofsd: Fix fuse setxattr() API change issue
6c3d050 linux-headers: Update linux headers to 5.13.0-rc6
=== OUTPUT BEGIN ===
1/8 Checking commit 6c3d050bd70f (linux-headers: Update linux headers to
5.13.0-rc6)
2/8 Checking commit 967e28d2e22d (virtiofsd: Fix fuse setxattr() API change
issue)
ERROR: braces {} are necessary for all arms of this statement
#50: FILE: tools/virtiofsd/fuse_lowlevel.c:1424:
+if (setxattr_ext)
[...]
+else
[...]
total: 1 errors, 0 warnings, 25 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 65fc720e49ac (virtiofsd: Fix xattr operations overwriting
errno)
4/8 Checking commit dc2337e643fc (virtiofsd: Add support for extended setxattr)
5/8 Checking commit 5588053fd40b (virtiofsd: Add umask to seccom allow list)
6/8 Checking commit e93c53dabdb7 (virtiofsd: Add capability to change/restore
umask)
7/8 Checking commit 62af00ed759e (virtiofsd: Switch creds, drop FSETID for
system.posix_acl_access xattr)
ERROR: suspect code indent for conditional statements (4, 7)
#83: FILE: tools/virtiofsd/passthrough_ll.c:1208:
+if (ret) {
+ if (__cap_dropped) {
ERROR: suspect code indent for conditional statements (7, 10)
#84: FILE: tools/virtiofsd/passthrough_ll.c:1209:
+ if (__cap_dropped) {
+ if (gain_effective_cap(cap_name)) {
ERROR: suspect code indent for conditional statements (10, 14)
#85: FILE: tools/virtiofsd/passthrough_ll.c:1210:
+ if (gain_effective_cap(cap_name)) {
+ fuse_log(FUSE_LOG_ERR, "Failed to gain CAP_%s\n", cap_name);
ERROR: braces {} are necessary for all arms of this statement
#91: FILE: tools/virtiofsd/passthrough_ll.c:1216:
+if (cap_dropped)
[...]
total: 4 errors, 0 warnings, 105 lines checked
Patch 7/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/8 Checking commit c812c393f36a (virtiofsd: Add an option to enable/disable
posix acls)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210617181213.1177835-1-vgo...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v2 00/11] vl: compound properties for machines
Patchew URL:
https://patchew.org/QEMU/20210617155308.928754-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210617155308.928754-1-pbonz...@redhat.com
Subject: [PATCH v2 00/11] vl: compound properties for machines
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210617155308.928754-1-pbonz...@redhat.com ->
patchew/20210617155308.928754-1-pbonz...@redhat.com
Switched to a new branch 'test'
7860c75 machine: add smp compound property
4041654 machine: reject -smp dies!=1 for non-PC machines
9f99606 machine: pass QAPI struct to mc->smp_parse
c40ee9c machine: add error propagation to mc->smp_parse
a25c706 machine: move common smp_parse code to caller
b484366 machine: move dies from X86MachineState to CpuTopology
610f271 qemu-option: remove now-dead code
9fe2b23 vl: switch -M parsing to keyval
49a23ce keyval: introduce keyval_parse_into
d3a4e0d keyval: introduce keyval_merge
2dee6bc qom: export more functions for use with non-UserCreatable objects
=== OUTPUT BEGIN ===
1/11 Checking commit 2dee6bc29821 (qom: export more functions for use with
non-UserCreatable objects)
2/11 Checking commit d3a4e0dd01bb (keyval: introduce keyval_merge)
ERROR: line over 90 characters
#45: FILE: tests/unit/test-keyval.c:756:
+QDict *combined =
keyval_parse("opt1=ABC,opt2.sub1=def,opt2.sub2=GHI,opt2.sub3=JKL,opt3=xyz",
WARNING: line over 80 characters
#119: FILE: util/keyval.c:318:
+static void keyval_do_merge(QDict *dest, const QDict *merged, GString *str,
Error **errp)
ERROR: line over 90 characters
#129: FILE: util/keyval.c:328:
+error_setg(errp, "Parameter '%s%s' used inconsistently",
str->str, ent->key);
WARNING: Block comments use a leading /* on a separate line
#160: FILE: util/keyval.c:359:
+/* Merge the @merged dictionary into @dest. The dictionaries are expected to
be
total: 2 errors, 2 warnings, 153 lines checked
Patch 2/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 49a23ce11213 (keyval: introduce keyval_parse_into)
WARNING: line over 80 characters
#28: FILE: include/qemu/option.h:150:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
WARNING: line over 80 characters
#50: FILE: util/keyval.c:510:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
total: 0 errors, 2 warnings, 78 lines checked
Patch 3/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit 9fe2b23c1acd (vl: switch -M parsing to keyval)
WARNING: line over 80 characters
#206: FILE: softmmu/vl.c:1592:
+error_setg(_err, "No machine specified, and there is no
default");
WARNING: line over 80 characters
#219: FILE: softmmu/vl.c:1598:
+error_append_hint(_err, "Use -machine help to list supported
machines\n");
WARNING: line over 80 characters
#256: FILE: softmmu/vl.c:1639:
+error_setg(errp, "Conflict between '%s' and '%s'", ent->key,
new_key);
WARNING: line over 80 characters
#300: FILE: softmmu/vl.c:1663:
+object_register_sugar_prop(ACCEL_CLASS_NAME("xen"), "igd-passthru",
value,
WARNING: line over 80 characters
#307: FILE: softmmu/vl.c:1670:
+object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kvm-shadow-mem",
value,
WARNING: line over 80 characters
#314: FILE: softmmu/vl.c:1677:
+object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kernel-irqchip",
value,
WARNING: line over 80 characters
#316: FILE: softmmu/vl.c:1679:
+object_register_sugar_prop(ACCEL_CLASS_NAME("whpx"), "kernel-irqchip",
value,
ERROR: line over 90 characters
#338: FILE: softmmu/vl.c:1804:
+object_set_properties_from_keyval(OBJECT(current_machine), qdict, false,
_fatal);
ERROR: line over 90 characters
#350: FILE: softmmu/vl.c:1834:
+semihosting_arg_fallback(current_machine->kernel_filename,
current_machine->kernel_cmdline);
ERROR: code indent should never use tabs
#414: FILE: softmmu/vl.c:2128:
+^I * Cannot merge string-valued and type-safe dictionaries, so JSON$
ERROR: code indent should never use tabs
#415: FILE: softmmu/vl.c:2129:
+^I * is not accepted yet for -M.$
ERROR: code indent should never use tabs
#416: FILE: softmmu/vl.c:2130:
+^I */$
ERROR: line over 90 characters
#526: FILE: softmmu/vl.c:3248:
+keyval_parse_into(machine_opts_dict, optarg, "type",
, _fatal);
total: 6 errors, 7 warnings, 536 lines
Re: [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu
Patchew URL: https://patchew.org/QEMU/cover.1623935540.git.huang...@chinatelecom.cn/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1623935540.git.huang...@chinatelecom.cn Subject: [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/cover.1623935540.git.huang...@chinatelecom.cn -> patchew/cover.1623935540.git.huang...@chinatelecom.cn Switched to a new branch 'test' 505b8c9 migration/dirtyrate: implement dirty-ring dirtyrate calculation fcd9a46 migration/dirtyrate: move init step of calculation to main thread 37cf9a1 migration/dirtyrate: adjust order of registering thread 8b39c90 migration/dirtyrate: introduce struct and adjust DirtyRateStat 8f35a922 memory: make global_dirty_tracking a bitmask baf82d4 memory: rename global_dirty_log to global_dirty_tracking 8c904aa KVM: introduce dirty_pages and kvm_dirty_ring_enabled === OUTPUT BEGIN === 1/7 Checking commit 8c904aa476d5 (KVM: introduce dirty_pages and kvm_dirty_ring_enabled) 2/7 Checking commit baf82d482e40 (memory: rename global_dirty_log to global_dirty_tracking) 3/7 Checking commit 8f35a922eca9 (memory: make global_dirty_tracking a bitmask) 4/7 Checking commit 8b39c90b3ffe (migration/dirtyrate: introduce struct and adjust DirtyRateStat) 5/7 Checking commit 37cf9a13595f (migration/dirtyrate: adjust order of registering thread) 6/7 Checking commit fcd9a4690842 (migration/dirtyrate: move init step of calculation to main thread) 7/7 Checking commit 505b8c99a555 (migration/dirtyrate: implement dirty-ring dirtyrate calculation) ERROR: trailing whitespace #88: FILE: migration/dirtyrate.c:93: + $ WARNING: line over 80 characters #94: FILE: migration/dirtyrate.c:99: +/* set sample_pages with 0 to indicate page sampling isn't enabled */ ERROR: trailing whitespace #106: FILE: migration/dirtyrate.c:111: + $ ERROR: trailing whitespace #325: FILE: migration/dirtyrate.c:658: +qapi_free_DirtyRateVcpuList(info->vcpu_dirty_rate); $ total: 3 errors, 1 warnings, 350 lines checked Patch 7/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1623935540.git.huang...@chinatelecom.cn/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v5 0/6] support dirtyrate at the granualrity of vcpu
Patchew URL: https://patchew.org/QEMU/cover.1623934182.git.huang...@chinatelecom.cn/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1623934182.git.huang...@chinatelecom.cn Subject: [PATCH v5 0/6] support dirtyrate at the granualrity of vcpu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/cover.1623934182.git.huang...@chinatelecom.cn -> patchew/cover.1623934182.git.huang...@chinatelecom.cn Switched to a new branch 'test' 7c3806f migration/dirtyrate: implement dirty-ring dirtyrate calculation de17d86 migration/dirtyrate: move init step of calculation to main thread bcdab9c migration/dirtyrate: adjust order of registering thread 7df987c migration/dirtyrate: introduce struct and adjust DirtyRateStat 4cb2069 memory: make global_dirty_tracking a bitmask 1eaf085 memory: rename global_dirty_log to global_dirty_tracking === OUTPUT BEGIN === 1/6 Checking commit 1eaf085f9a24 (memory: rename global_dirty_log to global_dirty_tracking) 2/6 Checking commit 4cb20690ee05 (memory: make global_dirty_tracking a bitmask) 3/6 Checking commit 7df987cc88c8 (migration/dirtyrate: introduce struct and adjust DirtyRateStat) 4/6 Checking commit bcdab9c720b2 (migration/dirtyrate: adjust order of registering thread) 5/6 Checking commit de17d8630d2f (migration/dirtyrate: move init step of calculation to main thread) 6/6 Checking commit 7c3806f92697 (migration/dirtyrate: implement dirty-ring dirtyrate calculation) ERROR: trailing whitespace #88: FILE: migration/dirtyrate.c:93: + $ WARNING: line over 80 characters #94: FILE: migration/dirtyrate.c:99: +/* set sample_pages with 0 to indicate page sampling isn't enabled */ ERROR: trailing whitespace #106: FILE: migration/dirtyrate.c:111: + $ ERROR: trailing whitespace #325: FILE: migration/dirtyrate.c:658: +qapi_free_DirtyRateVcpuList(info->vcpu_dirty_rate); $ total: 3 errors, 1 warnings, 350 lines checked Patch 6/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1623934182.git.huang...@chinatelecom.cn/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/7] Audio 20210617 patches
Patchew URL:
https://patchew.org/QEMU/20210617124107.2386073-1-kra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210617124107.2386073-1-kra...@redhat.com
Subject: [PULL 0/7] Audio 20210617 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210617121628.20116-1-peter.mayd...@linaro.org ->
patchew/20210617121628.20116-1-peter.mayd...@linaro.org
* [new tag] patchew/20210617124107.2386073-1-kra...@redhat.com ->
patchew/20210617124107.2386073-1-kra...@redhat.com
Switched to a new branch 'test'
a6c9846 coreaudio: Fix output stream format settings
32f3f1e audio: Fix format specifications of debug logs
b51279d hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range
e864a29 jackaudio: avoid that the client name contains the word (NULL)
c4a86a7 audio: move code to audio/audio.c
2800db0 paaudio: remove unused stream flags
0b3fd3c alsaaudio: remove #ifdef DEBUG to avoid bit rot
=== OUTPUT BEGIN ===
1/7 Checking commit 0b3fd3ca5f98 (alsaaudio: remove #ifdef DEBUG to avoid bit
rot)
2/7 Checking commit 2800db079dd3 (paaudio: remove unused stream flags)
3/7 Checking commit c4a86a755701 (audio: move code to audio/audio.c)
4/7 Checking commit e864a29cb0c2 (jackaudio: avoid that the client name
contains the word (NULL))
5/7 Checking commit b51279d277e6 (hw/audio/sb16: Avoid assertion by restricting
I/O sampling rate range)
6/7 Checking commit 32f3f1e7b9c4 (audio: Fix format specifications of debug
logs)
ERROR: space prohibited between function name and open parenthesis '('
#25: FILE: audio/audio.c:708:
+dolog ("%s is full %zu\n", sw->name, live);
ERROR: space prohibited between function name and open parenthesis '('
#43: FILE: audio/audio.c:1025:
+dolog ("%s: get_free live %zu dead %zu ret %" PRId64 "\n",
total: 2 errors, 0 warnings, 24 lines checked
Patch 6/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/7 Checking commit a6c98463e79b (coreaudio: Fix output stream format settings)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210617124107.2386073-1-kra...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [RFC PATCH v2] Add a post for the new TCG cache modelling plugin
Patchew URL: https://patchew.org/QEMU/20210617121707.764126-1-ma.mando...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210617121707.764126-1-ma.mando...@gmail.com Subject: [RFC PATCH v2] Add a post for the new TCG cache modelling plugin === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' aa253ca Add a post for the new TCG cache modelling plugin === OUTPUT BEGIN === WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 ERROR: trailing whitespace #284: FILE: _posts/2021-06-17-tcg-cache-modelling-plugin.md:262: +[[RFC PATCH v3 0/4] Cache TCG plugin & symbol-resolution API](https://patchew.org/QEMU/20210608040532.56449-1-ma.mando...@gmail.com/) $ ERROR: trailing whitespace #285: FILE: _posts/2021-06-17-tcg-cache-modelling-plugin.md:263: +[[RFC PATCH v3 1/4] plugins/api: expose symbol lookup to plugins](https://patchew.org/QEMU/20210608040532.56449-1-ma.mando...@gmail.com/20210608040532.56449-2-ma.mando...@gmail.com/) $ ERROR: trailing whitespace #286: FILE: _posts/2021-06-17-tcg-cache-modelling-plugin.md:264: +[[RFC PATCH v3 2/4] plugins: Added a new cache modelling plugin.](https://patchew.org/QEMU/20210608040532.56449-1-ma.mando...@gmail.com/20210608040532.56449-3-ma.mando...@gmail.com/) $ ERROR: trailing whitespace #287: FILE: _posts/2021-06-17-tcg-cache-modelling-plugin.md:265: +[[RFC PATCH v3 3/4] plugins/cache: Enabled cache parameterization](https://patchew.org/QEMU/20210608040532.56449-1-ma.mando...@gmail.com/20210608040532.56449-4-ma.mando...@gmail.com/) $ total: 4 errors, 1 warnings, 266 lines checked Commit aa253cab1831 (Add a post for the new TCG cache modelling plugin) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210617121707.764126-1-ma.mando...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v3 00/44] target/arm: First slice of MVE implementation
Patchew URL: https://patchew.org/QEMU/20210617121628.20116-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210617121628.20116-1-peter.mayd...@linaro.org Subject: [PATCH v3 00/44] target/arm: First slice of MVE implementation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210617121628.20116-1-peter.mayd...@linaro.org -> patchew/20210617121628.20116-1-peter.mayd...@linaro.org * [new tag] patchew/20210617121707.764126-1-ma.mando...@gmail.com -> patchew/20210617121707.764126-1-ma.mando...@gmail.com Switched to a new branch 'test' 05df1c8 target/arm: Make VMOV scalar <-> gpreg beatwise for MVE 65752fa target/arm: Implement MVE VADDV bf834ec target/arm: Implement MVE VHCADD 93db630 target/arm: Implement MVE VCADD ac96c96 target/arm: Implement MVE VADC, VSBC 8a4ab6f target/arm: Implement MVE VRHADD 82a131d target/arm: Implement MVE VQDMULL (vector) b3077d8 target/arm: Implement MVE VQDMLSDH and VQRDMLSDH 4b7d18e target/arm: Implement MVE VQDMLADH and VQRDMLADH 7362ba8 target/arm: Implmement MVE VRSHL 35ceb3b target/arm: Implement MVE VSHL insn 0b69db0 target/arm: Implement MVE VQRSHL ca1f8f8 target/arm: Implement MVE VQSHL (vector) 3145d27 target/arm: Implement MVE VQADD, VQSUB (vector) c410f56 target/arm: Implement MVE VQDMULH, VQRDMULH (vector) 9ed75aa target/arm: Implement MVE VQDMULL scalar b978ab7 target/arm: Implement MVE VQDMULH and VQRDMULH (scalar) 6152a27 target/arm: Implement MVE VQADD and VQSUB 9b3c980 target/arm: Implement MVE VPST c474543 target/arm: Implement MVE VBRSR f7f3767 target/arm: Implement MVE VHADD, VHSUB (scalar) b3437bd target/arm: Implement MVE VSUB, VMUL (scalar) fc9793a target/arm: Implement MVE VADD (scalar) 80b9d87 target/arm: Implement MVE VRMLALDAVH, VRMLSLDAVH faaf640 target/arm: Implement MVE VMLSLDAV 80faaa9 target/arm: Implement MVE VMLALDAV 3e8af8c target/arm: Implement MVE VMULL abae671 target/arm: Implement MVE VHADD, VHSUB adb7e20b target/arm: Implement MVE VABD bb75c1e target/arm: Implement MVE VMAX, VMIN ff40dea target/arm: Implement MVE VRMULH dc29f67 target/arm: Implement MVE VMULH fa7718c target/arm: Implement MVE VADD, VSUB, VMUL 4dddf39 target/arm: Implement MVE VAND, VBIC, VORR, VORN, VEOR 438a591 target/arm: Implement MVE VDUP 8d7b370 tcg: Make gen_dup_i32/i64() public as tcg_gen_dup_i32/i64 dca2cd3 target/arm: Implement MVE VNEG 052d280 target/arm: Implement MVE VABS 991de50 target/arm: Implement MVE VMVN (register) 0d21b85 target/arm: Implement MVE VREV16, VREV32, VREV64 cdfb89a target/arm: Implement MVE VCLS 276f4bc target/arm: Implement MVE VCLZ 72caa75 target/arm: Implement widening/narrowing MVE VLDR/VSTR insns b0b9cc6 target/arm: Implement MVE VLDR/VSTR (non-widening forms) === OUTPUT BEGIN === 1/44 Checking commit b0b9cc6091e7 (target/arm: Implement MVE VLDR/VSTR (non-widening forms)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #269: FILE: target/arm/mve_helper.c:134: +/* \ total: 0 errors, 2 warnings, 370 lines checked Patch 1/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/44 Checking commit 72caa75f6422 (target/arm: Implement widening/narrowing MVE VLDR/VSTR insns) 3/44 Checking commit 276f4bcceaa3 (target/arm: Implement MVE VCLZ) WARNING: architecture specific defines should be avoided #132: FILE: target/arm/mve_helper.c:241: +#if defined(__OPTIMIZE__) && !defined(__SANITIZE_ADDRESS__) ERROR: externs should be avoided in .c files #133: FILE: target/arm/mve_helper.c:242: +void unknown_mergemask_type(void *d, uint64_t r, uint16_t mask); ERROR: spaces required around that '*' (ctx:WxV) #189: FILE: target/arm/translate-mve.c:165: +static bool do_1op(DisasContext *s, arg_1op *a, MVEGenOneOpFn fn) ^ ERROR: spaces required around that '*' (ctx:WxV) #213: FILE: target/arm/translate-mve.c:189: +static bool trans_##INSN(DisasContext *s, arg_1op *a) \ ^ total: 3 errors, 1 warnings, 178 lines checked Patch 3/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/44 Checking commit cdfb89ab595d (target/arm: Implement MVE VCLS) 5/44 Checking commit 0d21b856208c (target/arm: Implement MVE VREV16, VREV32, VREV64) ERROR:
Re: [PULL 00/45] Memory, i386, compilation, bugfix changes for 2021-06-17
Patchew URL: https://patchew.org/QEMU/20210617093134.900014-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210617093134.900014-1-pbonz...@redhat.com Subject: [PULL 00/45] Memory, i386, compilation, bugfix changes for 2021-06-17 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210617093134.900014-1-pbonz...@redhat.com -> patchew/20210617093134.900014-1-pbonz...@redhat.com Switched to a new branch 'test' 76c1d1c configure: Remove probe for _Static_assert bb7b711 qemu/compiler: Remove QEMU_GENERIC bb5b937 include/qemu/lockable: Use _Generic instead of QEMU_GENERIC f12590d util: Use unique type for QemuRecMutex in thread-posix.h bad1bfa util: Pass file+line to qemu_rec_mutex_unlock_impl cce4c5d util: Use real functions for thread-posix QemuRecMutex bc05aa3 softfloat: Use _Generic instead of QEMU_GENERIC f09e1b8 configure: Use -std=gnu11 e3dddf2 target/i386: Added Intercept CR0 writes check 0d849e8 target/i386: Added consistency checks for CR0 76dcd43 target/i386: Added consistency checks for VMRUN intercept and ASID 567459b target/i386: Refactored intercept checks into cpu_svm_has_intercept b4e527e configure: map x32 to cpu_family x86_64 for meson 8163813 hmp: Print "reserve" property of memory backends with "info memdev" 567770f qmp: Include "reserve" property of memory backends 0512c46 hmp: Print "share" property of memory backends with "info memdev" 11f6aaf qmp: Include "share" property of memory backends f2bf2ce qmp: Clarify memory backend properties returned via query-memdev f4a1776 hostmem: Wire up RAM_NORESERVE via "reserve" property 16cee78 util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE under Linux adf9a93 memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap() 1b69bfd util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap() a527698 softmmu/memory: Pass ram_flags to qemu_ram_alloc() and qemu_ram_alloc_internal() 4f00790 softmmu/memory: Pass ram_flags to memory_region_init_ram_shared_nomigrate() 5289155 softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd() 8edf57d util/mmap-alloc: Factor out activating of memory to mmap_activate() 991926b util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve() c3819fc util/mmap-alloc: Factor out calculation of the pagesize for the guard page 917d149 softmmu/physmem: Fix qemu_ram_remap() to handle shared anonymous memory 9e6a704 softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory 2a1a5ba softmmu/physmem: Mark shared anonymous memory RAM_SHARED f0c8ef8 esp: store lun coming from the MESSAGE OUT phase 689f708 esp: fix migration version check in esp_is_version_5() d2adf20 esp: correctly accumulate extended messages for PDMA 26a1d08 esp: revert 75ef849696 "esp: correctly fill bus id with requested lun" d48286b esp: ensure PDMA write transfers are flushed from the FIFO to the target immediately 195cadb esp: handle non-DMA transfers from the target one byte at a time cbd0dea esp: allow non-DMA callback in esp_transfer_data() initial transfer 6c54d24 esp: only set ESP_RSEQ at the start of the select sequence 1567f98 esp: only assert INTR_DC interrupt flag if selection fails 2bedf0a runstate: Initialize Error * to NULL 51adfa2 block/scsi: correctly emulate the VPD block limits page 72a6110 qemu-config: use qemu_opts_from_qdict 0c0076a vl: Fix an assert failure in error path f427609 vnc: avoid deprecation warnings for SASL on OS X === OUTPUT BEGIN === 1/45 Checking commit f42760961c6d (vnc: avoid deprecation warnings for SASL on OS X) 2/45 Checking commit 0c0076a4935e (vl: Fix an assert failure in error path) 3/45 Checking commit 72a6110a41c2 (qemu-config: use qemu_opts_from_qdict) 4/45 Checking commit 51adfa2fb1de (block/scsi: correctly emulate the VPD block limits page) 5/45 Checking commit 2bedf0a004fd (runstate: Initialize Error * to NULL) 6/45 Checking commit 1567f98b866c (esp: only assert INTR_DC interrupt flag if selection fails) 7/45 Checking commit 6c54d2493304 (esp: only set ESP_RSEQ at the start of the select sequence) 8/45 Checking commit cbd0deae8cff (esp: allow non-DMA callback in esp_transfer_data() initial transfer) 9/45 Checking commit 195cadbab65e (esp: handle non-DMA transfers from the target one byte at a time) 10/45 Checking commit d48286bd0534 (esp: ensure PDMA write transfers are flushed from the FIFO to the target immediately) 11/45 Checking commit 26a1d08d933f (esp: revert 75ef849696 "esp: correctly fill bus id with requested lun") 12/45 Checking commit d2adf20b0668 (esp: correctly accumulate extended messages
Re: [RFC 0/3] qtest: pick tests that require KVM at runtime
Patchew URL: https://patchew.org/QEMU/20210616152455.1270264-1-imamm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210616152455.1270264-1-imamm...@redhat.com Subject: [RFC 0/3] qtest: pick tests that require KVM at runtime === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210616011209.1446045-1-richard.hender...@linaro.org -> patchew/20210616011209.1446045-1-richard.hender...@linaro.org * [new tag] patchew/20210616152455.1270264-1-imamm...@redhat.com -> patchew/20210616152455.1270264-1-imamm...@redhat.com Switched to a new branch 'test' 99b622f tests: acpi: update expected tables blobs 8aad11d tests: acpi: q35: test for x2APIC entries in SRAT 5bab45e tests: qtest: add qtest_has_kvm() to check if tested binary supports KVM === OUTPUT BEGIN === 1/3 Checking commit 5bab45eeb20a (tests: qtest: add qtest_has_kvm() to check if tested binary supports KVM) 2/3 Checking commit 8aad11d7634d (tests: acpi: q35: test for x2APIC entries in SRAT) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/FACP.numamem and tests/qtest/bios-tables-test.c found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/FACP.numamem and tests/qtest/bios-tables-test.c found total: 2 errors, 0 warnings, 39 lines checked Patch 2/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/3 Checking commit 99b622fa110f (tests: acpi: update expected tables blobs) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210616152455.1270264-1-imamm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] audio: Fix format specifications of debug logs
Patchew URL:
https://patchew.org/QEMU/20210616141411.53892-1-akihiko.od...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210616141411.53892-1-akihiko.od...@gmail.com
Subject: [PATCH] audio: Fix format specifications of debug logs
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
1ea06ab..1dd259a master -> master
- [tag update] patchew/2021060911.44437-1-mre...@redhat.com ->
patchew/2021060911.44437-1-mre...@redhat.com
- [tag update] patchew/20210610133538.608390-1-pbonz...@redhat.com ->
patchew/20210610133538.608390-1-pbonz...@redhat.com
- [tag update] patchew/20210614144245.17660-1-alex.ben...@linaro.org ->
patchew/20210614144245.17660-1-alex.ben...@linaro.org
- [tag update] patchew/20210615175523.439830-1-pet...@redhat.com ->
patchew/20210615175523.439830-1-pet...@redhat.com
- [tag update]
patchew/20210616011209.1446045-1-richard.hender...@linaro.org ->
patchew/20210616011209.1446045-1-richard.hender...@linaro.org
* [new tag] patchew/20210616141411.53892-1-akihiko.od...@gmail.com ->
patchew/20210616141411.53892-1-akihiko.od...@gmail.com
Switched to a new branch 'test'
a5aeaae audio: Fix format specifications of debug logs
=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#22: FILE: audio/audio.c:707:
+dolog ("%s is full %zu\n", sw->name, live);
ERROR: space prohibited between function name and open parenthesis '('
#40: FILE: audio/audio.c:1024:
+dolog ("%s: get_free live %zu dead %zu ret %" PRId64 "\n",
total: 2 errors, 0 warnings, 24 lines checked
Commit a5aeaae8bcc1 (audio: Fix format specifications of debug logs) has style
problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210616141411.53892-1-akihiko.od...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/3] renesas_sci update
Patchew URL:
https://patchew.org/QEMU/20210616091244.33049-1-ys...@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210616091244.33049-1-ys...@users.sourceforge.jp
Subject: [PATCH 0/3] renesas_sci update
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210610133538.608390-1-pbonz...@redhat.com ->
patchew/20210610133538.608390-1-pbonz...@redhat.com
- [tag update] patchew/20210615192848.1065297-1-vent...@google.com ->
patchew/20210615192848.1065297-1-vent...@google.com
- [tag update] patchew/20210616064334.53398-1-lukas.juen...@greensocs.com
-> patchew/20210616064334.53398-1-lukas.juen...@greensocs.com
- [tag update] patchew/20210616073358.750472-1-j...@jms.id.au ->
patchew/20210616073358.750472-1-j...@jms.id.au
* [new tag] patchew/20210616091244.33049-1-ys...@users.sourceforge.jp
-> patchew/20210616091244.33049-1-ys...@users.sourceforge.jp
Switched to a new branch 'test'
2aee00f hw/sh4: sh7750 using renesas_sci.
163b17f hw/char: renesas_sci Add SCI and SCIF support.
3a37650 hw/char: renesas_sci: Refactor for merge all SCI variant..
=== OUTPUT BEGIN ===
1/3 Checking commit 3a3765029d7c (hw/char: renesas_sci: Refactor for merge all
SCI variant..)
2/3 Checking commit 163b17f2e78e (hw/char: renesas_sci Add SCI and SCIF
support.)
ERROR: spaces required around that ':' (ctx:VxW)
#24: FILE: hw/char/renesas_sci.c:6:
+ *And SH7751 Group, SH7751R Group User's Manual: Hardware
^
ERROR: space prohibited after that '*' (ctx:ExW)
#25: FILE: hw/char/renesas_sci.c:7:
+ *(Rev.4.01 R01UH0457EJ0401)
^
total: 2 errors, 0 warnings, 715 lines checked
Patch 2/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit 2aee00ffc830 (hw/sh4: sh7750 using renesas_sci.)
ERROR: space required before the open parenthesis '('
#63: FILE: hw/sh4/sh7750.c:770:
+switch(feat) {
ERROR: braces {} are necessary for all arms of this statement
#79: FILE: hw/sh4/sh7750.c:786:
+if (tei_source)
[...]
ERROR: braces {} are necessary for all arms of this statement
#81: FILE: hw/sh4/sh7750.c:788:
+if (bri_source)
[...]
total: 3 errors, 0 warnings, 79 lines checked
Patch 3/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210616091244.33049-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/8] configure: Change to -std=gnu11
Patchew URL: https://patchew.org/QEMU/20210616013629.1458790-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210616013629.1458790-1-richard.hender...@linaro.org Subject: [PULL 0/8] configure: Change to -std=gnu11 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210616013629.1458790-1-richard.hender...@linaro.org -> patchew/20210616013629.1458790-1-richard.hender...@linaro.org Switched to a new branch 'test' 360606f configure: Remove probe for _Static_assert e641e6f qemu/compiler: Remove QEMU_GENERIC 3b4a4b0 include/qemu/lockable: Use _Generic instead of QEMU_GENERIC 01b2566 util: Use unique type for QemuRecMutex in thread-posix.h 24f3e28 util: Pass file+line to qemu_rec_mutex_unlock_impl ce5376c util: Use real functions for thread-posix QemuRecMutex 21c8d81 softfloat: Use _Generic instead of QEMU_GENERIC de2d9e7 configure: Use -std=gnu11 === OUTPUT BEGIN === 1/8 Checking commit de2d9e703f2a (configure: Use -std=gnu11) 2/8 Checking commit 21c8d81506d8 (softfloat: Use _Generic instead of QEMU_GENERIC) ERROR: spaces required around that '*' (ctx:WxO) #25: FILE: fpu/softfloat.c:689: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #25: FILE: fpu/softfloat.c:689: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #26: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #26: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #31: FILE: fpu/softfloat.c:693: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #31: FILE: fpu/softfloat.c:693: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #32: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #32: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #33: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #33: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #42: FILE: fpu/softfloat.c:897: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #42: FILE: fpu/softfloat.c:897: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #43: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #43: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #48: FILE: fpu/softfloat.c:901: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #48: FILE: fpu/softfloat.c:901: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #49: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #49: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #50: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #50: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ total: 20 errors, 0 warnings, 32 lines checked Patch 2/8 has style problems, please review. If any of these errors are
Re: [PATCH v2 0/8] configure: Change to -std=gnu11
Patchew URL: https://patchew.org/QEMU/20210614233143.1221879-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210614233143.1221879-1-richard.hender...@linaro.org Subject: [PATCH v2 0/8] configure: Change to -std=gnu11 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210614233143.1221879-1-richard.hender...@linaro.org -> patchew/20210614233143.1221879-1-richard.hender...@linaro.org Switched to a new branch 'test' 1a974ee configure: Remove probe for _Static_assert 8a8c552 qemu/compiler: Remove QEMU_GENERIC d52ca80 include/qemu/lockable: Use _Generic instead of QEMU_GENERIC d751cc8 util: Use unique type for QemuRecMutex in thread-posix.h aafe079 util: Pass file+line to qemu_rec_mutex_unlock_impl 069b4e3 util: Use real functions for thread-posix QemuRecMutex df9952e softfloat: Use _Generic instead of QEMU_GENERIC 067736a configure: Use -std=gnu11 === OUTPUT BEGIN === 1/8 Checking commit 067736abd82a (configure: Use -std=gnu11) 2/8 Checking commit df9952ebdce3 (softfloat: Use _Generic instead of QEMU_GENERIC) ERROR: spaces required around that '*' (ctx:WxO) #22: FILE: fpu/softfloat.c:689: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #22: FILE: fpu/softfloat.c:689: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #23: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #23: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #28: FILE: fpu/softfloat.c:693: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #28: FILE: fpu/softfloat.c:693: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #29: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #29: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #30: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #30: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #39: FILE: fpu/softfloat.c:897: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #39: FILE: fpu/softfloat.c:897: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #40: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #40: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #45: FILE: fpu/softfloat.c:901: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #45: FILE: fpu/softfloat.c:901: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #46: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #46: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #47: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #47: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ total: 20 errors, 0 warnings, 32 lines checked Patch 2/8 has style problems, please review. If any of these errors
Re: [PATCH 00/11] vl: compound properties for machines
Patchew URL:
https://patchew.org/QEMU/20210610133538.608390-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210610133538.608390-1-pbonz...@redhat.com
Subject: [PATCH 00/11] vl: compound properties for machines
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e17f5c6 machine: add smp compound property
cbf01d3 machine: reject -smp dies!=1 for non-PC machines
8636c7f machine: pass QAPI struct to mc->smp_parse
b648458 machine: add error propagation to mc->smp_parse
5dcfcb8 machine: move common smp_parse code to caller
087b4ce machine: move dies from X86MachineState to CpuTopology
c03d517 qemu-option: remove now-dead code
7f7fb81 vl: switch -M parsing to keyval
60f4b40 keyval: introduce keyval_parse_into
8c619a4 keyval: introduce keyval_merge
cef10f7 qom: export more functions for use with non-UserCreatable objects
=== OUTPUT BEGIN ===
1/11 Checking commit cef10f7fc760 (qom: export more functions for use with
non-UserCreatable objects)
2/11 Checking commit 8c619a4f71c0 (keyval: introduce keyval_merge)
ERROR: line over 90 characters
#45: FILE: tests/unit/test-keyval.c:756:
+QDict *combined =
keyval_parse("opt1=ABC,opt2.sub1=def,opt2.sub2=GHI,opt2.sub3=JKL,opt3=xyz",
WARNING: line over 80 characters
#114: FILE: util/keyval.c:314:
+static void keyval_do_merge(QDict *old, const QDict *new, GString *str, Error
**errp)
ERROR: line over 90 characters
#124: FILE: util/keyval.c:324:
+error_setg(errp, "Parameter '%s%s' used inconsistently",
str->str, ent->key);
total: 2 errors, 1 warnings, 127 lines checked
Patch 2/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 60f4b4022843 (keyval: introduce keyval_parse_into)
WARNING: line over 80 characters
#26: FILE: include/qemu/option.h:150:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
WARNING: line over 80 characters
#48: FILE: util/keyval.c:486:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
total: 0 errors, 2 warnings, 78 lines checked
Patch 3/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit 7f7fb8157001 (vl: switch -M parsing to keyval)
WARNING: line over 80 characters
#206: FILE: softmmu/vl.c:1592:
+error_setg(_err, "No machine specified, and there is no
default");
WARNING: line over 80 characters
#219: FILE: softmmu/vl.c:1598:
+error_append_hint(_err, "Use -machine help to list supported
machines\n");
WARNING: line over 80 characters
#256: FILE: softmmu/vl.c:1639:
+error_setg(errp, "Conflict between '%s' and '%s'", ent->key,
new_key);
WARNING: line over 80 characters
#300: FILE: softmmu/vl.c:1663:
+object_register_sugar_prop(ACCEL_CLASS_NAME("xen"), "igd-passthru",
value,
WARNING: line over 80 characters
#307: FILE: softmmu/vl.c:1670:
+object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kvm-shadow-mem",
value,
WARNING: line over 80 characters
#314: FILE: softmmu/vl.c:1677:
+object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kernel-irqchip",
value,
WARNING: line over 80 characters
#316: FILE: softmmu/vl.c:1679:
+object_register_sugar_prop(ACCEL_CLASS_NAME("whpx"), "kernel-irqchip",
value,
ERROR: line over 90 characters
#338: FILE: softmmu/vl.c:1804:
+object_set_properties_from_keyval(OBJECT(current_machine), qdict, false,
_fatal);
ERROR: line over 90 characters
#350: FILE: softmmu/vl.c:1834:
+semihosting_arg_fallback(current_machine->kernel_filename,
current_machine->kernel_cmdline);
ERROR: code indent should never use tabs
#414: FILE: softmmu/vl.c:2128:
+^I * Cannot merge string-valued and type-safe dictionaries, so JSON$
ERROR: code indent should never use tabs
#415: FILE: softmmu/vl.c:2129:
+^I * is not accepted yet for -M.$
ERROR: code indent should never use tabs
#416: FILE: softmmu/vl.c:2130:
+^I */$
ERROR: line over 90 characters
#526: FILE: softmmu/vl.c:3248:
+keyval_parse_into(machine_opts_dict, optarg, "type",
, _fatal);
total: 6 errors, 7 warnings, 536 lines checked
Patch 4/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit c03d51714eb0 (qemu-option: remove now-dead code)
6/11 Checking commit 087b4ce1fcfb (machine: move dies from X86MachineState to
CpuTopology)
7/11 Checking commit 5dcfcb88130d
Re: [PATCH v2 00/37] target/riscv: support packed extension v0.9.4
Patchew URL: https://patchew.org/QEMU/20210610075908.3305506-1-zhiwei_...@c-sky.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210610075908.3305506-1-zhiwei_...@c-sky.com Subject: [PATCH v2 00/37] target/riscv: support packed extension v0.9.4 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 58bab55 target/riscv: configure and turn on packed extension from command line aaa9443 target/riscv: RV64 Only 32-bit Packing Instructions fd98368 target/riscv: RV64 Only Non-SIMD 32-bit Shift Instructions 13ee829 target/riscv: RV64 Only 32-bit Parallel Multiply & Add Instructions a45bf09 target/riscv: RV64 Only 32-bit Multiply & Add Instructions afa9d9f target/riscv: RV64 Only 32-bit Multiply Instructions 5e47cf9 target/riscv: RV64 Only SIMD Q15 saturating Multiply Instructions 0707fb2 target/riscv: RV64 Only SIMD 32-bit Miscellaneous Instructions 9103b42 target/riscv: RV64 Only SIMD 32-bit Shift Instructions aa8562e target/riscv: RV64 Only SIMD 32-bit Add/Subtract Instructions 4e3c751 target/riscv: Non-SIMD Miscellaneous Instructions 98463d7 target/riscv: 32-bit Computation Instructions a2b5fa4 target/riscv: Non-SIMD Q31 saturation ALU Instructions 5ac11aa target/riscv: Non-SIMD Q15 saturation ALU Instructions 8f8cc98 target/riscv: Signed 16-bit Multiply with 64-bit Add/Subtract Instructions 562fe16 target/riscv: 32-bit Multiply 64-bit Add/Subtract Instructions abd68e9 target/riscv: 64-bit Add/Subtract Instructions 1101a08 target/riscv: 8-bit Multiply with 32-bit Add Instructions cade413 target/riscv: Partial-SIMD Miscellaneous Instructions 868fc8a target/riscv: Signed 16-bit Multiply 64-bit Add/Subtract Instructions 55ea8d5 target/riscv: Signed 16-bit Multiply 32-bit Add/Subtract Instructions fc7375d target/riscv: Signed MSW 32x16 Multiply and Add Instructions 14d0690 target/riscv: Signed MSW 32x32 Multiply and Add Instructions 75852f9 target/riscv: 16-bit Packing Instructions 4c0f92a target/riscv: 8-bit Unpacking Instructions da3eb1d target/riscv: SIMD 8-bit Miscellaneous Instructions cda90fe target/riscv: SIMD 16-bit Miscellaneous Instructions 2c1cebb target/riscv: SIMD 8-bit Multiply Instructions ea6538c target/riscv: SIMD 16-bit Multiply Instructions e6d145d target/riscv: SIMD 8-bit Compare Instructions c7dc098 target/riscv: SIMD 16-bit Compare Instructions 98fdd40 target/riscv: SIMD 8-bit Shift Instructions 161cf36 target/riscv: SIMD 16-bit Shift Instructions 52b81ce target/riscv: 8-bit Addition & Subtraction Instruction 51a264e target/riscv: 16-bit Addition & Subtraction Instructions 9bfdab5 target/riscv: Make the vector helper functions public 8966803 target/riscv: implementation-defined constant parameters === OUTPUT BEGIN === 1/37 Checking commit 896680352f63 (target/riscv: implementation-defined constant parameters) 2/37 Checking commit 9bfdab58457e (target/riscv: Make the vector helper functions public) 3/37 Checking commit 51a264e82cf5 (target/riscv: 16-bit Addition & Subtraction Instructions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #132: new file mode 100644 ERROR: space prohibited after that '*' (ctx:BxW) #172: FILE: target/riscv/insn_trans/trans_rvp.c.inc:36: + void (* vecop)(TCGv, TCGv, TCGv), ^ ERROR: space prohibited after that '*' (ctx:BxW) #173: FILE: target/riscv/insn_trans/trans_rvp.c.inc:37: + void (* op)(TCGv, TCGv, TCGv)) ^ ERROR: space prohibited after that '*' (ctx:BxW) #198: FILE: target/riscv/insn_trans/trans_rvp.c.inc:62: +r_ool(DisasContext *ctx, arg_r *a, void (* fn)(TCGv, TCGv_ptr, TCGv, TCGv)) ^ total: 3 errors, 1 warnings, 617 lines checked Patch 3/37 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/37 Checking commit 52b81cea79fe (target/riscv: 8-bit Addition & Subtraction Instruction) 5/37 Checking commit 161cf360f41e (target/riscv: SIMD 16-bit Shift Instructions) ERROR: space prohibited after that '*' (ctx:BxW) #138: FILE: target/riscv/insn_trans/trans_rvp.c.inc:144: + void (* fn)(TCGv, TCGv_ptr, TCGv, TCGv)) ^ ERROR: space prohibited after that '*' (ctx:BxW) #158: FILE: target/riscv/insn_trans/trans_rvp.c.inc:164: + void (* vecop)(TCGv, TCGv, target_long), ^ ERROR: space prohibited after that '*' (ctx:BxW) #159: FILE: target/riscv/insn_trans/trans_rvp.c.inc:165: + void (* op)(TCGv, TCGv_ptr, TCGv, TCGv)) ^ total: 3 errors, 0 warnings, 289 lines checked Patch 5/37 has style
Re: [RFC PATCH] migration/rdma: Fix out of order wrid
Patchew URL:
https://patchew.org/QEMU/20210610085831.19779-1-lizhij...@cn.fujitsu.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210610085831.19779-1-lizhij...@cn.fujitsu.com
Subject: [RFC PATCH] migration/rdma: Fix out of order wrid
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2d73991 migration/rdma: Fix out of order wrid
=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#76: FILE: migration/rdma.c:1618:
+if (rdma->ooo_wrid >= RDMA_WRID_SEND_CONTROL && rdma->ooo_wrid ==
wrid_requested) {
ERROR: line over 90 characters
#91: FILE: migration/rdma.c:1633:
+error_report("more than one out of order wird(%ld, %ld)",
rdma->ooo_wrid, wr_id);
ERROR: Error messages should not contain newlines
#94: FILE: migration/rdma.c:1636:
+error_report("get out of order wird(%ld)\n", wr_id);
total: 3 errors, 0 warnings, 40 lines checked
Commit 2d739918ecc4 (migration/rdma: Fix out of order wrid) has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210610085831.19779-1-lizhij...@cn.fujitsu.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] Test comment for git-publish
Patchew URL: https://patchew.org/QEMU/20210611162033.437690-1-mcasc...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210611162033.437690-1-mcasc...@redhat.com Subject: [PATCH] Test comment for git-publish === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 65950dc Test comment for git-publish === OUTPUT BEGIN === ERROR: do not use C99 // comments #21: FILE: hw/rdma/vmw/pvrdma_main.c:430: +pvrdma_exec_cmd(dev); // this is a test comment ERROR: Missing Signed-off-by: line(s) total: 2 errors, 0 warnings, 8 lines checked Commit 65950dcea24f (Test comment for git-publish) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210611162033.437690-1-mcasc...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v2 0/8] virtio-gpu: Add a default synchronization mechanism for blobs
Patchew URL: https://patchew.org/QEMU/20210610224837.670192-1-vivek.kasire...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210610224837.670192-1-vivek.kasire...@intel.com Subject: [PATCH v2 0/8] virtio-gpu: Add a default synchronization mechanism for blobs === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' d7ca345 virtio-gpu: Add gl_flushed callback 2a73d47 virtio-gpu: Add dmabuf helpers for synchronization 0d1be46 ui/gtk-egl: Wait for the draw signal for dmabuf blobs 3fd1b59 ui: Create sync objects only for blobs 13095b9 ui/gtk: Implement wait_dmabuf function e2c7ec7 ui: Add a helper to wait on a dmabuf sync object ffbfd82 ui/egl: Add egl helpers to help with synchronization 4612c6a ui/gtk: Create a common release_dmabuf helper === OUTPUT BEGIN === 1/8 Checking commit 4612c6a8e283 (ui/gtk: Create a common release_dmabuf helper) 2/8 Checking commit ffbfd82727d9 (ui/egl: Add egl helpers to help with synchronization) ERROR: code indent should never use tabs #63: FILE: ui/egl-helpers.c:88: +^I^I^I^IEGL_SYNC_NATIVE_FENCE_ANDROID, NULL);$ total: 1 errors, 0 warnings, 67 lines checked Patch 2/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/8 Checking commit e2c7ec781b0c (ui: Add a helper to wait on a dmabuf sync object) 4/8 Checking commit 13095b996f1a (ui/gtk: Implement wait_dmabuf function) 5/8 Checking commit 3fd1b5907cbd (ui: Create sync objects only for blobs) 6/8 Checking commit 0d1be4679e6f (ui/gtk-egl: Wait for the draw signal for dmabuf blobs) 7/8 Checking commit 2a73d47f2458 (virtio-gpu: Add dmabuf helpers for synchronization) 8/8 Checking commit d7ca345c6ce8 (virtio-gpu: Add gl_flushed callback) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210610224837.670192-1-vivek.kasire...@intel.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] net: Replace TAB indentations with spaces
Patchew URL: https://patchew.org/QEMU/20210614183849.20622-1-em...@aabouzied.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210614183849.20622-1-em...@aabouzied.com Subject: [PATCH] net: Replace TAB indentations with spaces === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1cc4a36 net: Replace TAB indentations with spaces === OUTPUT BEGIN === ERROR: spaces prohibited around that ':' (ctx:WxW) #68: FILE: hw/net/can/ctu_can_fd_frame.h:53: +uint32_t dlc : 4; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #69: FILE: hw/net/can/ctu_can_fd_frame.h:54: +uint32_t reserved_4 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #70: FILE: hw/net/can/ctu_can_fd_frame.h:55: +uint32_t rtr : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #71: FILE: hw/net/can/ctu_can_fd_frame.h:56: +uint32_t ide : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #72: FILE: hw/net/can/ctu_can_fd_frame.h:57: +uint32_t fdf : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #73: FILE: hw/net/can/ctu_can_fd_frame.h:58: +uint32_t reserved_8 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #74: FILE: hw/net/can/ctu_can_fd_frame.h:59: +uint32_t brs : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #75: FILE: hw/net/can/ctu_can_fd_frame.h:60: +uint32_t esi_rsv : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #76: FILE: hw/net/can/ctu_can_fd_frame.h:61: +uint32_t rwcnt : 5; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #77: FILE: hw/net/can/ctu_can_fd_frame.h:62: +uint32_t reserved_31_16 : 16; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #89: FILE: hw/net/can/ctu_can_fd_frame.h:64: +uint32_t reserved_31_16 : 16; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #90: FILE: hw/net/can/ctu_can_fd_frame.h:65: +uint32_t rwcnt : 5; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #91: FILE: hw/net/can/ctu_can_fd_frame.h:66: +uint32_t esi_rsv : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #92: FILE: hw/net/can/ctu_can_fd_frame.h:67: +uint32_t brs : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #93: FILE: hw/net/can/ctu_can_fd_frame.h:68: +uint32_t reserved_8 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #94: FILE: hw/net/can/ctu_can_fd_frame.h:69: +uint32_t fdf : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #95: FILE: hw/net/can/ctu_can_fd_frame.h:70: +uint32_t ide : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #96: FILE: hw/net/can/ctu_can_fd_frame.h:71: +uint32_t rtr : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #97: FILE: hw/net/can/ctu_can_fd_frame.h:72: +uint32_t reserved_4 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #98: FILE: hw/net/can/ctu_can_fd_frame.h:73: +uint32_t dlc : 4; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #149: FILE: hw/net/can/ctu_can_fd_frame.h:108: +uint32_t identifier_ext : 18; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #150: FILE: hw/net/can/ctu_can_fd_frame.h:109: +uint32_t identifier_base: 11; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #151: FILE: hw/net/can/ctu_can_fd_frame.h:110: +uint32_t reserved_31_29
Re: [PULL 00/12] Net patches
Patchew URL: https://patchew.org/QEMU/20210611060024.46763-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210611060024.46763-1-jasow...@redhat.com Subject: [PULL 00/12] Net patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210614200940.2056770-1-phi...@redhat.com -> patchew/20210614200940.2056770-1-phi...@redhat.com * [new tag] patchew/20210614202842.581640-1-mathieu.poir...@linaro.org -> patchew/20210614202842.581640-1-mathieu.poir...@linaro.org Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist 'base..' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20210611060024.46763-1-jasow...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/28] tcg: bswap improvements
Patchew URL:
https://patchew.org/QEMU/20210614083800.1166166-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210614083800.1166166-1-richard.hender...@linaro.org
Subject: [PATCH 00/28] tcg: bswap improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fdfe6d3 tcg/riscv: Remove MO_BSWAP handling
fb9c8e1 tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP
75c5607 tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP
a57e516 target/mips: Fix gen_mxu_s32ldd_s32lddr
e4a99d6 target/sh4: Improve swap.b translation
e8b1814 target/i386: Improve bswap translation
129291d target/arm: Improve REVSH
ff11784 target/arm: Improve vector REV
f23fd8e target/arm: Improve REV32
a53eb56 tcg: Make use of bswap flags in tcg_gen_qemu_st_*
ef89c56 tcg: Make use of bswap flags in tcg_gen_qemu_ld_*
13c8b52 tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64
68e5471 tcg: Handle new bswap flags during optimize
17db675 tcg/tci: Support bswap flags
ff37d58 tcg/mips: Support bswap flags in tcg_out_bswap32
718bb99 tcg/mips: Support bswap flags in tcg_out_bswap16
784afc4 tcg/s390: Support bswap flags
2f03527 tcg/ppc: Use power10 byte-reverse instructions
d446243 tcg/ppc: Support bswap flags
7e02157 tcg/ppc: Split out tcg_out_bswap64
17813eb tcg/ppc: Split out tcg_out_bswap32
3316b19 tcg/ppc: Split out tcg_out_bswap16
b075ca8 tcg/ppc: Split out tcg_out_sari{32,64}
3b8cbf1 tcg/ppc: Split out tcg_out_ext{8,16,32}s
8ddb299 tcg/arm: Support bswap flags
22141b0 tcg/aarch64: Support bswap flags
a88e86e tcg/i386: Support bswap flags
7355a7f tcg: Add flags argument to bswap opcodes
=== OUTPUT BEGIN ===
1/28 Checking commit 7355a7f32661 (tcg: Add flags argument to bswap opcodes)
2/28 Checking commit a88e86e6484d (tcg/i386: Support bswap flags)
3/28 Checking commit 22141b0c1f1d (tcg/aarch64: Support bswap flags)
4/28 Checking commit 8ddb299c393e (tcg/arm: Support bswap flags)
5/28 Checking commit 3b8cbf12df69 (tcg/ppc: Split out tcg_out_ext{8,16,32}s)
6/28 Checking commit b075ca8b4504 (tcg/ppc: Split out tcg_out_sari{32,64})
7/28 Checking commit 3316b1902c92 (tcg/ppc: Split out tcg_out_bswap16)
8/28 Checking commit 17813ebc9f38 (tcg/ppc: Split out tcg_out_bswap32)
9/28 Checking commit 7e02157c16ed (tcg/ppc: Split out tcg_out_bswap64)
10/28 Checking commit d44624327aee (tcg/ppc: Support bswap flags)
11/28 Checking commit 2f03527066a7 (tcg/ppc: Use power10 byte-reverse
instructions)
12/28 Checking commit 784afc41c21e (tcg/s390: Support bswap flags)
13/28 Checking commit 718bb99a5724 (tcg/mips: Support bswap flags in
tcg_out_bswap16)
14/28 Checking commit ff37d58c7324 (tcg/mips: Support bswap flags in
tcg_out_bswap32)
15/28 Checking commit 17db67555db3 (tcg/tci: Support bswap flags)
16/28 Checking commit 68e5471a5b41 (tcg: Handle new bswap flags during optimize)
ERROR: spaces required around that ':' (ctx:VxE)
#40: FILE: tcg/optimize.c:1033:
+CASE_OP_32_64(bswap16):
^
ERROR: spaces required around that ':' (ctx:VxE)
#93: FILE: tcg/optimize.c:1188:
+CASE_OP_32_64(bswap16):
^
ERROR: spaces required around that ':' (ctx:VxE)
#94: FILE: tcg/optimize.c:1189:
+CASE_OP_32_64(bswap32):
^
total: 3 errors, 0 warnings, 82 lines checked
Patch 16/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/28 Checking commit 13c8b52b1b7a (tcg: Add flags argument to
tcg_gen_bswap16_*, tcg_gen_bswap32_i64)
ERROR: code indent should never use tabs
#163: FILE: target/sh4/translate.c:680:
+^Itcg_gen_bswap16_i32(low, low, TCG_BSWAP_IZ | TCG_BSWAP_OZ);$
total: 1 errors, 0 warnings, 296 lines checked
Patch 17/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/28 Checking commit ef89c566b6f3 (tcg: Make use of bswap flags in
tcg_gen_qemu_ld_*)
19/28 Checking commit a53eb569d43b (tcg: Make use of bswap flags in
tcg_gen_qemu_st_*)
20/28 Checking commit f23fd8e08da1 (target/arm: Improve REV32)
21/28 Checking commit ff11784030c8 (target/arm: Improve vector REV)
22/28 Checking commit 129291d55edb (target/arm: Improve REVSH)
23/28 Checking commit e8b18140cc85 (target/i386: Improve bswap translation)
24/28 Checking commit e4a99d6a7db1 (target/sh4: Improve swap.b translation)
ERROR: code indent should never use tabs
#26: FILE: target/sh4/translate.c:679:
+^Itcg_gen_bswap16_i32(low, REG(B7_4), 0);$
total: 1 errors, 0 warnings, 9 lines checked
Patch 24/28 has
Re: [PATCH] hw/nvme: be more careful when deasserting IRQs
Patchew URL:
https://patchew.org/QEMU/20210610114624.304681-1-jakub.jer...@kernkonzept.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210610114624.304681-1-jakub.jer...@kernkonzept.com
Subject: [PATCH] hw/nvme: be more careful when deasserting IRQs
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210610132505.5827-1-peter.mayd...@linaro.org ->
patchew/20210610132505.5827-1-peter.mayd...@linaro.org
* [new tag]
patchew/20210614135429.56475-1-jakub.jer...@kernkonzept.com ->
patchew/20210614135429.56475-1-jakub.jer...@kernkonzept.com
Switched to a new branch 'test'
aacc285 hw/nvme: be more careful when deasserting IRQs
=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: hw/nvme/ctrl.c:485:
+if (q && q->vector == cq->vector && q->head != q->tail)
[...]
total: 1 errors, 0 warnings, 39 lines checked
Commit aacc285402f0 (hw/nvme: be more careful when deasserting IRQs) has style
problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210610114624.304681-1-jakub.jer...@kernkonzept.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/8] configure: Change to -std=gnu11
Patchew URL: https://patchew.org/QEMU/20210611233347.653129-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210611233347.653129-1-richard.hender...@linaro.org Subject: [PATCH 0/8] configure: Change to -std=gnu11 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210610100802.5888-1-vsement...@virtuozzo.com -> patchew/20210610100802.5888-1-vsement...@virtuozzo.com * [new tag] patchew/20210610142549.33220-1-zhangjiachen.jay...@bytedance.com -> patchew/20210610142549.33220-1-zhangjiachen.jay...@bytedance.com Switched to a new branch 'test' e40a971 configure: Remove probe for _Static_assert 1d4e941 qemu/compiler: Remove QEMU_GENERIC c6f4654 include/qemu/lockable: Use _Generic instead of QEMU_GENERIC f158a02 util: Use unique type for QemuRecMutex in thread-posix.h a26bcbe util: Pass file+line to qemu_rec_mutex_unlock_impl e1ba627 util: Use real functions for thread-posix QemuRecMutex 096aebf softfloat: Use _Generic instead of QEMU_GENERIC 1781658 configure: Use -std=gnu11 === OUTPUT BEGIN === 1/8 Checking commit 178165898450 (configure: Use -std=gnu11) 2/8 Checking commit 096aebfff18d (softfloat: Use _Generic instead of QEMU_GENERIC) ERROR: spaces required around that '*' (ctx:WxO) #22: FILE: fpu/softfloat.c:689: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #22: FILE: fpu/softfloat.c:689: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #23: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #23: FILE: fpu/softfloat.c:690: + FloatParts128 *: parts128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #28: FILE: fpu/softfloat.c:693: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #28: FILE: fpu/softfloat.c:693: +_Generic((P), FloatParts64 *: parts64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #29: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #29: FILE: fpu/softfloat.c:694: + FloatParts128 *: parts128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #30: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #30: FILE: fpu/softfloat.c:695: + FloatParts256 *: parts256_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #39: FILE: fpu/softfloat.c:897: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #39: FILE: fpu/softfloat.c:897: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #40: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #40: FILE: fpu/softfloat.c:898: + FloatParts128 *: frac128_##NAME) ^ ERROR: spaces required around that '*' (ctx:WxO) #45: FILE: fpu/softfloat.c:901: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #45: FILE: fpu/softfloat.c:901: +_Generic((P), FloatParts64 *: frac64_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #46: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that ':' (ctx:OxW) #46: FILE: fpu/softfloat.c:902: + FloatParts128 *: frac128_##NAME, \ ^ ERROR: spaces required around that '*' (ctx:WxO) #47: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME) ^ ERROR: spaces required around that ':' (ctx:OxW) #47: FILE: fpu/softfloat.c:903: + FloatParts256 *: frac256_##NAME)
Re: [PATCH v2] Test comment for git-publish
Patchew URL: https://patchew.org/QEMU/20210611164305.440633-1-mcasc...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210611164305.440633-1-mcasc...@redhat.com Subject: [PATCH v2] Test comment for git-publish === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' bf784f4 Test comment for git-publish === OUTPUT BEGIN === ERROR: do not use C99 // comments #21: FILE: hw/rdma/vmw/pvrdma_main.c:430: +pvrdma_exec_cmd(dev); // this is a test comment ERROR: Missing Signed-off-by: line(s) total: 2 errors, 0 warnings, 8 lines checked Commit bf784f48ac5f (Test comment for git-publish) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210611164305.440633-1-mcasc...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] tcg/arm: Fix tcg_out_op function signature
Patchew URL: https://patchew.org/QEMU/20210610224450.23425-1-jzivi...@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210610224450.23425-1-jzivi...@suse.de Subject: [PATCH] tcg/arm: Fix tcg_out_op function signature === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210614114357.1146725-1-vinc...@bernat.ch -> patchew/20210614114357.1146725-1-vinc...@bernat.ch * [new tag] patchew/20210614144407.134243-1-mre...@redhat.com -> patchew/20210614144407.134243-1-mre...@redhat.com Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist 'base..' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20210610224450.23425-1-jzivi...@suse.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v2 00/57] target/arm: First slice of MVE implementation
Patchew URL: https://patchew.org/QEMU/20210614151007.4545-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210614151007.4545-1-peter.mayd...@linaro.org Subject: [PATCH v2 00/57] target/arm: First slice of MVE implementation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210614052623.1657103-1-f4...@amsat.org -> patchew/20210614052623.1657103-1-f4...@amsat.org Switched to a new branch 'test' 114fdf4 target/arm: Make VMOV scalar <-> gpreg beatwise for MVE 3aadcfc target/arm: Implement MVE VADDV 6adb32d target/arm: Implement MVE VHCADD 2e99c0a target/arm: Implement MVE VCADD a0493d8 target/arm: Implement MVE VADC, VSBC 977dce5 target/arm: Implement MVE VRHADD ce1ac42 target/arm: Implement MVE VQDMULL (vector) a5c3651 target/arm: Implement MVE VQDMLSDH and VQRDMLSDH 7a6e20d target/arm: Implement MVE VQDMLADH and VQRDMLADH 83b6df5 target/arm: Implmement MVE VRSHL 173b26f target/arm: Implement MVE VSHL insn b48b35a target/arm: Implement MVE VQRSHL b4e1e88 target/arm: Implement MVE VQSHL (vector) c516319 target/arm: Implement MVE VQADD, VQSUB (vector) bd980e5 target/arm: Implement MVE VQDMULH, VQRDMULH (vector) eaa2cb1 target/arm: Implement MVE VQDMULL scalar b6b168b target/arm: Implement MVE VQDMULH and VQRDMULH (scalar) e1dbfde target/arm: Implement MVE VQADD and VQSUB 23f072f target/arm: Implement MVE VPST 9fbabfc target/arm: Implement MVE VBRSR 3ca182e target/arm: Implement MVE VHADD, VHSUB (scalar) c0615d8 target/arm: Implement MVE VSUB, VMUL (scalar) 9646c71 target/arm: Implement MVE VADD (scalar) e091fe1 target/arm: Implement MVE VRMLALDAVH, VRMLSLDAVH 04aee7c include/qemu/int128.h: Add function to create Int128 from int64_t 19f5544 target/arm: Implement MVE VMLSLDAV 7c74a0d target/arm: Implement MVE VMLALDAV 2eed292 target/arm: Implement MVE VMULL 71e60ea target/arm: Implement MVE VHADD, VHSUB 3a11f89 target/arm: Implement MVE VABD 3a95638 target/arm: Implement MVE VMAX, VMIN d537c24 target/arm: Implement MVE VRMULH 35d0181 target/arm: Implement MVE VMULH d3d5dcb target/arm: Implement MVE VADD, VSUB, VMUL e1083b8 target/arm: Implement MVE VAND, VBIC, VORR, VORN, VEOR af20e6a target/arm: Implement MVE VDUP 44b9fa5 tcg: Make gen_dup_i32() public 6acf6cf target/arm: Implement MVE VNEG 201f1e3 target/arm: Implement MVE VABS ebce351 target/arm: Implement MVE VMVN (register) 2bf919a target/arm: Implement MVE VREV16, VREV32, VREV64 7b8105a0 bitops.h: Provide hswap32(), hswap64(), wswap64() swapping operations 111b6a7 target/arm: Implement MVE VCLS 8282e7f target/arm: Implement MVE VCLZ 900481d target/arm: Move expand_pred_b() data to translate.c 3c7f001 target/arm: Implement widening/narrowing MVE VLDR/VSTR insns 356b0df target/arm: Implement MVE VLDR/VSTR (non-widening forms) 5472a37 target/arm: Add framework for MVE decode dd6a572 target/arm: Implement MVE LETP insn d707539 target/arm: Implement MVE DLSTP 2fef29f target/arm: Implement MVE WLSTP insn 9f0aa8b target/arm: Implement MVE LCTP 4958c81 target/arm: Let vfp_access_check() handle late NOCP checks 605a2b4 target/arm: Add handling for PSR.ECI/ICI 82900b2 target/arm: Handle VPR semantics in existing code 9734264 target/arm: Enable FPSCR.QC bit for MVE a6d9eb0 target/arm: Provide and use H8 and H1_8 macros === OUTPUT BEGIN === 1/57 Checking commit a6d9eb077652 (target/arm: Provide and use H8 and H1_8 macros) 2/57 Checking commit 9734264e7ccd (target/arm: Enable FPSCR.QC bit for MVE) 3/57 Checking commit 82900b28d7cd (target/arm: Handle VPR semantics in existing code) 4/57 Checking commit 605a2b46fccc (target/arm: Add handling for PSR.ECI/ICI) 5/57 Checking commit 4958c8116393 (target/arm: Let vfp_access_check() handle late NOCP checks) 6/57 Checking commit 9f0aa8b6738e (target/arm: Implement MVE LCTP) 7/57 Checking commit 2fef29fbfced (target/arm: Implement MVE WLSTP insn) 8/57 Checking commit d707539d6307 (target/arm: Implement MVE DLSTP) 9/57 Checking commit dd6a5724a472 (target/arm: Implement MVE LETP insn) 10/57 Checking commit 5472a374b257 (target/arm: Add framework for MVE decode) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 total: 0 errors, 1 warnings, 77 lines checked Patch 10/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/57 Checking commit 356b0df2f8db (target/arm: Implement MVE VLDR/VSTR (non-widening forms)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 WARNING: Block comments use a
Re: tb_flush() calls causing long Windows XP boot times
Patchew URL: https://patchew.org/QEMU/bcb8773b-fc54-4c25-9b60-92c263165...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: bcb8773b-fc54-4c25-9b60-92c263165...@gmail.com Subject: tb_flush() calls causing long Windows XP boot times === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210610213906.1313440-1-ebl...@redhat.com -> patchew/20210610213906.1313440-1-ebl...@redhat.com * [new tag] patchew/20210614083800.1166166-1-richard.hender...@linaro.org -> patchew/20210614083800.1166166-1-richard.hender...@linaro.org Switched to a new branch 'test' 0c48784 tb_flush() calls causing long Windows XP boot times === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 8 lines checked Commit 0c48784df7c4 (tb_flush() calls causing long Windows XP boot times) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/bcb8773b-fc54-4c25-9b60-92c263165...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/4] Emulator fixes to enable running NetBSD/alpha
Patchew URL: https://patchew.org/QEMU/20210613211549.18094-1-thor...@me.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210613211549.18094-1-thor...@me.com
Subject: [PATCH 0/4] Emulator fixes to enable running NetBSD/alpha
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210610001424.209158-1-jiang.w...@bytedance.com
-> patchew/20210610001424.209158-1-jiang.w...@bytedance.com
* [new tag] patchew/20210612085101.61304-1...@weilnetz.de ->
patchew/20210612085101.61304-1...@weilnetz.de
Switched to a new branch 'test'
ae5541d alpha: Provide console information to the PALcode at start-up.
ed14ccc alpha: Provide a PCI-ISA bridge device node for guest OS's that expect
it
4ab8e91 alpha: Set minimum PCI device ID to 1 to match Clipper IRQ mappings.
8e9fae5 mc146818rtc: Make PF independent of PIE
=== OUTPUT BEGIN ===
1/4 Checking commit 8e9fae55ef15 (mc146818rtc: Make PF independent of PIE)
2/4 Checking commit 4ab8e91bd35e (alpha: Set minimum PCI device ID to 1 to
match Clipper IRQ mappings.)
WARNING: Block comments use a leading /* on a separate line
#46: FILE: hw/alpha/dp264.c:79:
+/* Init the chipset. Because we're using CLIPPER IRQ mappings,
WARNING: Block comments use * on subsequent lines
#47: FILE: hw/alpha/dp264.c:80:
+/* Init the chipset. Because we're using CLIPPER IRQ mappings,
+ the minimum PCI device IdSel is 1. */
WARNING: Block comments use a trailing */ on a separate line
#47: FILE: hw/alpha/dp264.c:80:
+ the minimum PCI device IdSel is 1. */
total: 0 errors, 3 warnings, 37 lines checked
Patch 2/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit ed14ccc6e1b5 (alpha: Provide a PCI-ISA bridge device node
for guest OS's that expect it)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: hw/alpha/typhoon.c:922:
+/* Init the PCI-ISA bridge. Technically, PCI-based Alphas shipped
WARNING: Block comments use * on subsequent lines
#30: FILE: hw/alpha/typhoon.c:923:
+/* Init the PCI-ISA bridge. Technically, PCI-based Alphas shipped
+ with one of three different PCI-ISA bridges:
WARNING: Block comments use a trailing */ on a separate line
#49: FILE: hw/alpha/typhoon.c:942:
+ Tsunami/Typhoon systems. */
WARNING: Block comments use a leading /* on a separate line
#62: FILE: hw/alpha/typhoon.c:978:
+/* The following was copied from hw/isa/i82378.c and modified to provide
WARNING: Block comments use * on subsequent lines
#63: FILE: hw/alpha/typhoon.c:979:
+/* The following was copied from hw/isa/i82378.c and modified to provide
+ only the minimal PCI device node. */
WARNING: Block comments use a trailing */ on a separate line
#63: FILE: hw/alpha/typhoon.c:979:
+ only the minimal PCI device node. */
total: 0 errors, 6 warnings, 130 lines checked
Patch 3/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit ae5541d5739e (alpha: Provide console information to the
PALcode at start-up.)
WARNING: Block comments use a leading /* on a separate line
#25: FILE: hw/alpha/dp264.c:75:
+/* arg0 -> memory size
WARNING: Block comments use * on subsequent lines
#26: FILE: hw/alpha/dp264.c:76:
+/* arg0 -> memory size
+ arg1 -> kernel entry point
WARNING: Block comments use a trailing */ on a separate line
#32: FILE: hw/alpha/dp264.c:82:
+ See init_hwrpb() in the PALcode. */
ERROR: suspect code indent for conditional statements (4, 6)
#37: FILE: hw/alpha/dp264.c:87:
+if (!machine->enable_graphics)
+ cpus[0]->env.trap_arg2 |= (1 << 6);
ERROR: braces {} are necessary for all arms of this statement
#37: FILE: hw/alpha/dp264.c:87:
+if (!machine->enable_graphics)
[...]
total: 2 errors, 3 warnings, 20 lines checked
Patch 4/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210613211549.18094-1-thor...@me.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/9] migration queue
Patchew URL: https://patchew.org/QEMU/20210609144512.211746-1-dgilb...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210609144512.211746-1-dgilb...@redhat.com Subject: [PULL 0/9] migration queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210609184955.1193081-1-phi...@redhat.com -> patchew/20210609184955.1193081-1-phi...@redhat.com * [new tag] patchew/20210611120427.49736-1-berra...@redhat.com -> patchew/20210611120427.49736-1-berra...@redhat.com * [new tag] patchew/20210613141222.548357-1-lukas.juen...@greensocs.com -> patchew/20210613141222.548357-1-lukas.juen...@greensocs.com Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist 'base..' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20210609144512.211746-1-dgilb...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH V2 0/2] vhost-vDPA: vq notification map support
Patchew URL: https://patchew.org/QEMU/20210602084106.43186-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210602084106.43186-1-jasow...@redhat.com Subject: [PATCH V2 0/2] vhost-vDPA: vq notification map support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu a4716fd..1ea06ab master -> master - [tag update] patchew/20210505103702.521457-1-berra...@redhat.com -> patchew/20210505103702.521457-1-berra...@redhat.com - [tag update] patchew/20210510114328.21835-1-da...@redhat.com -> patchew/20210510114328.21835-1-da...@redhat.com - [tag update] patchew/20210526170432.343588-1-phi...@redhat.com -> patchew/20210526170432.343588-1-phi...@redhat.com - [tag update] patchew/20210601141805.206582-1-pet...@redhat.com -> patchew/20210601141805.206582-1-pet...@redhat.com * [new tag] patchew/20210602084106.43186-1-jasow...@redhat.com -> patchew/20210602084106.43186-1-jasow...@redhat.com - [tag update] patchew/20210602191125.525742-1-josemartin...@gmail.com -> patchew/20210602191125.525742-1-josemartin...@gmail.com - [tag update] patchew/20210603171259.27962-1-peter.mayd...@linaro.org -> patchew/20210603171259.27962-1-peter.mayd...@linaro.org Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist 'base..' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20210602084106.43186-1-jasow...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/55] target/arm: First slice of MVE implementation
Patchew URL: https://patchew.org/QEMU/20210607165821.9892-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210607165821.9892-1-peter.mayd...@linaro.org Subject: [PATCH 00/55] target/arm: First slice of MVE implementation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' e6bde0c target/arm: Make VMOV scalar <-> gpreg beatwise for MVE 46ab47a target/arm: Implement MVE VADDV 8c6a715 target/arm: Implement MVE VHCADD ee4a883 target/arm: Implement MVE VCADD d6d031c target/arm: Implement MVE VADC, VSBC f2abf78 target/arm: Implement MVE VRHADD f59e727 target/arm: Implement MVE VQDMULL (vector) b5a1e75 target/arm: Implement MVE VQDMLSDH and VQRDMLSDH 2a85a42 target/arm: Implement MVE VQDMLADH and VQRDMLADH c631126 target/arm: Implement MVE VRSHL 96c9251 target/arm: Implement MVE VSHL insn 6617f9d target/arm: Implement MVE VQRSHL ea1d028 target/arm: Implement MVE VQSHL (vector) 7f5704f target/arm: Implement MVE VQADD, VQSUB (vector) fe87207 target/arm: Implement MVE VQDMULH, VQRDMULH (vector) fae9d05 target/arm: Implement MVE VQDMULL scalar 3dde42e target/arm: Implement MVE VQDMULH and VQRDMULH (scalar) ad46ffc target/arm: Implement MVE VQADD and VQSUB eb22856 target/arm: Implement MVE VPST 110b41d target/arm: Implement MVE VBRSR b92e1c2 target/arm: Implement MVE VHADD, VHSUB (scalar) bd4a331 target/arm: Implement MVE VSUB, VMUL (scalar) ddbfc63 target/arm: Implement MVE VADD (scalar) 1722cbe target/arm: Implement MVE VRMLALDAVH, VRMLSLDAVH 53fa7e7 include/qemu/int128.h: Add function to create Int128 from int64_t 6ba3e6f target/arm: Implement MVE VMLSLDAV 34c471e target/arm: Implement MVE VMLALDAV 5faff7d target/arm: Implement MVE VMULL 7c4e6a2 target/arm: Implement MVE VHADD, VHSUB fe67781 target/arm: Implement MVE VABD 1f8942c target/arm: Implement MVE VMAX, VMIN 0097a91 target/arm: Implement MVE VRMULH 8649950 target/arm: Implement MVE VMULH 7af4e69 target/arm: Implement MVE VADD, VSUB, VMUL ac5934b target/arm: Implement MVE VAND, VBIC, VORR, VORN, VEOR ff0cfd3 target/arm: Implement MVE VDUP 2f66a74 target/arm: Implement MVE VNEG 0482da4 target/arm: Implement MVE VABS 60d8fd8 target/arm: Implement MVE VMVN (register) 1eaba2f target/arm: Implement MVE VREV16, VREV32, VREV64 ace7aae bitops.h: Provide hswap32(), hswap64(), wswap64() swapping operations d6bed53 target/arm: Implement MVE VCLS 22d128d target/arm: Implement MVE VCLZ c1690b6 target/arm: Implement widening/narrowing MVE VLDR/VSTR insns a08b6b5 target/arm: Implement MVE VLDR/VSTR (non-widening forms) 3679c9d target/arm: Add framework for MVE decode 22dd9b5 target/arm: Implement MVE LETP insn b8d39cd target/arm: Implement MVE DLSTP 63e6f6d target/arm: Implement MVE WLSTP insn 8261501 target/arm: Implement MVE LCTP f77f199 target/arm: Let vfp_access_check() handle late NOCP checks 192982d target/arm: Add handling for PSR.ECI/ICI c578a8f target/arm: Handle VPR semantics in existing code 7620752 target/arm: Enable FPSCR.QC bit for MVE df2cbf9 tcg: Introduce tcg_remove_ops_after === OUTPUT BEGIN === 1/55 Checking commit df2cbf927c33 (tcg: Introduce tcg_remove_ops_after) 2/55 Checking commit 7620752e8687 (target/arm: Enable FPSCR.QC bit for MVE) 3/55 Checking commit c578a8fc03b3 (target/arm: Handle VPR semantics in existing code) 4/55 Checking commit 192982d41d0b (target/arm: Add handling for PSR.ECI/ICI) 5/55 Checking commit f77f199bec23 (target/arm: Let vfp_access_check() handle late NOCP checks) 6/55 Checking commit 8261501d3a71 (target/arm: Implement MVE LCTP) 7/55 Checking commit 63e6f6d469dd (target/arm: Implement MVE WLSTP insn) 8/55 Checking commit b8d39cd81fc0 (target/arm: Implement MVE DLSTP) 9/55 Checking commit 22dd9b506bd5 (target/arm: Implement MVE LETP insn) 10/55 Checking commit 3679c9dc0348 (target/arm: Add framework for MVE decode) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 77 lines checked Patch 10/55 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/55 Checking commit a08b6b59eba3 (target/arm: Implement MVE VLDR/VSTR (non-widening forms)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #285: FILE: target/arm/mve_helper.c:150: +/* \ total: 0 errors, 2 warnings, 396 lines checked Patch 11/55 has style problems, please review. If any of these errors are false positives report
Re: [PATCH v1 0/5] virtio-gpu: Add implicit (and default) sync mechanism for blobs
Patchew URL: https://patchew.org/QEMU/20210607232530.454435-1-vivek.kasire...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210607232530.454435-1-vivek.kasire...@intel.com Subject: [PATCH v1 0/5] virtio-gpu: Add implicit (and default) sync mechanism for blobs === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 255bbee virtio-gpu: Make resource_flush wait on the sync object for blobs 60d80bd ui: Create sync objects only for blobs fd4c503 ui/egl: Add egl helpers to help with synchronization faed37e ui: Add a helper to wait on a dmabuf sync object 9f9a6c6 ui/gtk: Create a common release_dmabuf helper === OUTPUT BEGIN === 1/5 Checking commit 9f9a6c6c4593 (ui/gtk: Create a common release_dmabuf helper) 2/5 Checking commit faed37ec89dc (ui: Add a helper to wait on a dmabuf sync object) 3/5 Checking commit fd4c50392fa3 (ui/egl: Add egl helpers to help with synchronization) ERROR: code indent should never use tabs #64: FILE: ui/egl-helpers.c:88: +^I^I^I^IEGL_SYNC_NATIVE_FENCE_ANDROID, NULL);$ total: 1 errors, 0 warnings, 100 lines checked Patch 3/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/5 Checking commit 60d80bd36f23 (ui: Create sync objects only for blobs) 5/5 Checking commit 255bbee81de3 (virtio-gpu: Make resource_flush wait on the sync object for blobs) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210607232530.454435-1-vivek.kasire...@intel.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/12] Machine and OS X changes for 2021-06-08
Patchew URL:
https://patchew.org/QEMU/20210608094017.392673-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210608094017.392673-1-pbonz...@redhat.com
Subject: [PULL 00/12] Machine and OS X changes for 2021-06-08
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2e2607b vnc: avoid deprecation warnings for SASL on OS X
b944e00 machine: add smp compound property
4f6c15b machine: reject -smp dies!=1 for non-PC machines
d72236a machine: pass QAPI struct to mc->smp_parse
a464edf machine: add error propagation to mc->smp_parse
95d7450 machine: move common smp_parse code to caller
411cbbf machine: move dies from X86MachineState to CpuTopology
939528c qemu-option: remove now-dead code
5ade2c0 vl: switch -M parsing to keyval
99fc4e5 keyval: introduce keyval_parse_into
ddae823 keyval: introduce keyval_merge
a602bbd qom: export more functions for use with non-UserCreatable objects
=== OUTPUT BEGIN ===
1/12 Checking commit a602bbd492a8 (qom: export more functions for use with
non-UserCreatable objects)
2/12 Checking commit ddae8230a939 (keyval: introduce keyval_merge)
ERROR: line over 90 characters
#45: FILE: tests/unit/test-keyval.c:756:
+QDict *combined =
keyval_parse("opt1=ABC,opt2.sub1=def,opt2.sub2=GHI,opt2.sub3=JKL,opt3=xyz",
WARNING: line over 80 characters
#114: FILE: util/keyval.c:314:
+static void keyval_do_merge(QDict *old, const QDict *new, GString *str, Error
**errp)
ERROR: line over 90 characters
#124: FILE: util/keyval.c:324:
+error_setg(errp, "Parameter '%s%s' used inconsistently",
str->str, ent->key);
total: 2 errors, 1 warnings, 127 lines checked
Patch 2/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/12 Checking commit 99fc4e57a289 (keyval: introduce keyval_parse_into)
WARNING: line over 80 characters
#26: FILE: include/qemu/option.h:150:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
WARNING: line over 80 characters
#48: FILE: util/keyval.c:486:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
total: 0 errors, 2 warnings, 78 lines checked
Patch 3/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/12 Checking commit 5ade2c0ebb8d (vl: switch -M parsing to keyval)
WARNING: line over 80 characters
#206: FILE: softmmu/vl.c:1592:
+error_setg(_err, "No machine specified, and there is no
default");
WARNING: line over 80 characters
#219: FILE: softmmu/vl.c:1598:
+error_append_hint(_err, "Use -machine help to list supported
machines\n");
WARNING: line over 80 characters
#256: FILE: softmmu/vl.c:1639:
+error_setg(errp, "Conflict between '%s' and '%s'", ent->key,
new_key);
WARNING: line over 80 characters
#300: FILE: softmmu/vl.c:1663:
+object_register_sugar_prop(ACCEL_CLASS_NAME("xen"), "igd-passthru",
value,
WARNING: line over 80 characters
#307: FILE: softmmu/vl.c:1670:
+object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kvm-shadow-mem",
value,
WARNING: line over 80 characters
#314: FILE: softmmu/vl.c:1677:
+object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kernel-irqchip",
value,
WARNING: line over 80 characters
#316: FILE: softmmu/vl.c:1679:
+object_register_sugar_prop(ACCEL_CLASS_NAME("whpx"), "kernel-irqchip",
value,
ERROR: line over 90 characters
#338: FILE: softmmu/vl.c:1804:
+object_set_properties_from_keyval(OBJECT(current_machine), qdict, false,
_fatal);
ERROR: line over 90 characters
#350: FILE: softmmu/vl.c:1834:
+semihosting_arg_fallback(current_machine->kernel_filename,
current_machine->kernel_cmdline);
ERROR: code indent should never use tabs
#414: FILE: softmmu/vl.c:2128:
+^I * Cannot merge string-valued and type-safe dictionaries, so JSON$
ERROR: code indent should never use tabs
#415: FILE: softmmu/vl.c:2129:
+^I * is not accepted yet for -M.$
ERROR: code indent should never use tabs
#416: FILE: softmmu/vl.c:2130:
+^I */$
ERROR: line over 90 characters
#526: FILE: softmmu/vl.c:3248:
+keyval_parse_into(machine_opts_dict, optarg, "type",
, _fatal);
total: 6 errors, 7 warnings, 536 lines checked
Patch 4/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/12 Checking commit 939528c36ff3 (qemu-option: remove now-dead code)
6/12 Checking commit 411cbbfb1dfb (machine: move dies from
Re: [RFC PATCH 0/4] target/ppc: mmu cleanup
Patchew URL: https://patchew.org/QEMU/20210602192604.90846-1-lucas.ara...@eldorado.org.br/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210602192604.90846-1-lucas.ara...@eldorado.org.br Subject: [RFC PATCH 0/4] target/ppc: mmu cleanup === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210609141010.1066750-1-f4...@amsat.org -> patchew/20210609141010.1066750-1-f4...@amsat.org Switched to a new branch 'test' 183d120 target/ppc: Moved helpers to mmu_helper.c c3d77cb target/ppc: moved ppc_store_sdr1 to mmu_common.c 7c84c42 target/ppc: divided mmu_helper.c in 2 files 90a38ae target/ppc: Don't compile ppc_tlb_invalid_all without TCG === OUTPUT BEGIN === 1/4 Checking commit 90a38ae56c59 (target/ppc: Don't compile ppc_tlb_invalid_all without TCG) WARNING: line over 80 characters #30: FILE: target/ppc/cpu_init.c:8915: + cpu_abort(env_cpu(env),"PowerPC not in real mode, invalid in this build\n"); ERROR: code indent should never use tabs #30: FILE: target/ppc/cpu_init.c:8915: +^Icpu_abort(env_cpu(env),"PowerPC not in real mode, invalid in this build\n");$ ERROR: space required after that ',' (ctx:VxV) #30: FILE: target/ppc/cpu_init.c:8915: + cpu_abort(env_cpu(env),"PowerPC not in real mode, invalid in this build\n"); ^ total: 2 errors, 1 warnings, 39 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit 7c84c4276936 (target/ppc: divided mmu_helper.c in 2 files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #125: new file mode 100644 WARNING: line over 80 characters #1538: FILE: target/ppc/mmu_common.c:1409: +env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, MMU_DATA_LOAD); WARNING: line over 80 characters #1625: FILE: target/ppc/mmu_common.c:1496: +booke206_update_mas_tlb_miss(env, address, access_type, mmu_idx); WARNING: line over 80 characters #1631: FILE: target/ppc/mmu_common.c:1502: +env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, access_type); WARNING: line over 80 characters #1655: FILE: target/ppc/mmu_common.c:1526: +env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, access_type); total: 0 errors, 5 warnings, 3351 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit c3d77cbc7606 (target/ppc: moved ppc_store_sdr1 to mmu_common.c) 4/4 Checking commit 183d120bd746 (target/ppc: Moved helpers to mmu_helper.c) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210602192604.90846-1-lucas.ara...@eldorado.org.br/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v3 0/7] support dirtyrate at the granualrity of vcpu
Patchew URL: https://patchew.org/QEMU/cover.1623027729.git.huang...@chinatelecom.cn/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1623027729.git.huang...@chinatelecom.cn Subject: [PATCH v3 0/7] support dirtyrate at the granualrity of vcpu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' db25537 migration/dirtyrate: implement dirty-ring dirtyrate calculation 720f923 memory: make global_dirty_log a bitmask a3323fd migration/dirtyrate: adjust struct DirtyRateStat 04b16bd migration/dirtyrate: add per-vcpu option for calc-dirty-rate 0ec6909 KVM: introduce dirty_pages and kvm_dirty_ring_enabled 8828757 hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds dd4342c migration/dirtyrate: make sample page count configurable === OUTPUT BEGIN === 1/7 Checking commit dd4342c3ec2f (migration/dirtyrate: make sample page count configurable) 2/7 Checking commit 8828757e0b0e (hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds) 3/7 Checking commit 0ec6909b55f6 (KVM: introduce dirty_pages and kvm_dirty_ring_enabled) 4/7 Checking commit 04b16bd9b236 (migration/dirtyrate: add per-vcpu option for calc-dirty-rate) ERROR: Error messages should not contain newlines #42: FILE: migration/dirtyrate.c:427: + "only one of then can be specified!\n"); total: 1 errors, 0 warnings, 158 lines checked Patch 4/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/7 Checking commit a3323fddecd9 (migration/dirtyrate: adjust struct DirtyRateStat) 6/7 Checking commit 720f923fec0d (memory: make global_dirty_log a bitmask) ERROR: spaces required around that '<<' (ctx:VxV) #36: FILE: include/exec/memory.h:58: +#define GLOBAL_DIRTY_MIGRATION (1U<<0) ^ ERROR: spaces required around that '<<' (ctx:VxV) #37: FILE: include/exec/memory.h:59: +#define GLOBAL_DIRTY_DIRTY_RATE (1U<<1) ^ total: 2 errors, 0 warnings, 145 lines checked Patch 6/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/7 Checking commit db255379e746 (migration/dirtyrate: implement dirty-ring dirtyrate calculation) ERROR: do not initialise globals to 0 or NULL #75: FILE: migration/dirtyrate.c:47: +bool register_powerdown_callback = false; WARNING: Block comments use a leading /* on a separate line #208: FILE: migration/dirtyrate.c:437: +/* migration is in process, do not stop dirty logging, WARNING: Block comments use a trailing */ on a separate line #209: FILE: migration/dirtyrate.c:438: + * just clear the GLOBAL_DIRTY_DIRTY_RATE bit */ total: 1 errors, 2 warnings, 322 lines checked Patch 7/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1623027729.git.huang...@chinatelecom.cn/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/7] Net patches
Patchew URL:
https://patchew.org/QEMU/20210604073617.69622-1-jasow...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210604073617.69622-1-jasow...@redhat.com
Subject: [PULL 0/7] Net patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210604073617.69622-1-jasow...@redhat.com ->
patchew/20210604073617.69622-1-jasow...@redhat.com
Switched to a new branch 'test'
f6bfae4 MAINTAINERS: Added eBPF maintainers information.
05cdd37 docs: Added eBPF documentation.
7441daa virtio-net: Added eBPF RSS to virtio-net.
9bde40e ebpf: Added eBPF RSS loader.
25747ec ebpf: Added eBPF RSS program.
7ca188e net: Added SetSteeringEBPF method for NetClientState.
efa2976 net/tap: Added TUNSETSTEERINGEBPF code.
=== OUTPUT BEGIN ===
1/7 Checking commit efa2976a1c3a (net/tap: Added TUNSETSTEERINGEBPF code.)
2/7 Checking commit 7ca188ef6a85 (net: Added SetSteeringEBPF method for
NetClientState.)
3/7 Checking commit 25747ec23b55 (ebpf: Added eBPF RSS program.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100755
total: 0 errors, 1 warnings, 592 lines checked
Patch 3/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit 9bde40ef15a4 (ebpf: Added eBPF RSS loader.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#72:
new file mode 100644
WARNING: architecture specific defines should be avoided
#354: FILE: ebpf/rss.bpf.skeleton.h:4:
+#ifndef __RSS_BPF_SKEL_H__
ERROR: code indent should never use tabs
#361: FILE: ebpf/rss.bpf.skeleton.h:11:
+^Istruct bpf_object_skeleton *skeleton;$
ERROR: code indent should never use tabs
#362: FILE: ebpf/rss.bpf.skeleton.h:12:
+^Istruct bpf_object *obj;$
ERROR: code indent should never use tabs
#363: FILE: ebpf/rss.bpf.skeleton.h:13:
+^Istruct {$
ERROR: code indent should never use tabs
#364: FILE: ebpf/rss.bpf.skeleton.h:14:
+^I^Istruct bpf_map *tap_rss_map_configurations;$
ERROR: code indent should never use tabs
#365: FILE: ebpf/rss.bpf.skeleton.h:15:
+^I^Istruct bpf_map *tap_rss_map_indirection_table;$
ERROR: code indent should never use tabs
#366: FILE: ebpf/rss.bpf.skeleton.h:16:
+^I^Istruct bpf_map *tap_rss_map_toeplitz_key;$
ERROR: code indent should never use tabs
#367: FILE: ebpf/rss.bpf.skeleton.h:17:
+^I} maps;$
ERROR: code indent should never use tabs
#368: FILE: ebpf/rss.bpf.skeleton.h:18:
+^Istruct {$
ERROR: code indent should never use tabs
#369: FILE: ebpf/rss.bpf.skeleton.h:19:
+^I^Istruct bpf_program *tun_rss_steering_prog;$
ERROR: code indent should never use tabs
#370: FILE: ebpf/rss.bpf.skeleton.h:20:
+^I} progs;$
ERROR: code indent should never use tabs
#371: FILE: ebpf/rss.bpf.skeleton.h:21:
+^Istruct {$
ERROR: code indent should never use tabs
#372: FILE: ebpf/rss.bpf.skeleton.h:22:
+^I^Istruct bpf_link *tun_rss_steering_prog;$
ERROR: code indent should never use tabs
#373: FILE: ebpf/rss.bpf.skeleton.h:23:
+^I} links;$
ERROR: code indent should never use tabs
#379: FILE: ebpf/rss.bpf.skeleton.h:29:
+^Iif (!obj)$
ERROR: braces {} are necessary for all arms of this statement
#379: FILE: ebpf/rss.bpf.skeleton.h:29:
+ if (!obj)
[...]
ERROR: code indent should never use tabs
#380: FILE: ebpf/rss.bpf.skeleton.h:30:
+^I^Ireturn;$
ERROR: code indent should never use tabs
#381: FILE: ebpf/rss.bpf.skeleton.h:31:
+^Iif (obj->skeleton)$
ERROR: braces {} are necessary for all arms of this statement
#381: FILE: ebpf/rss.bpf.skeleton.h:31:
+ if (obj->skeleton)
[...]
ERROR: code indent should never use tabs
#382: FILE: ebpf/rss.bpf.skeleton.h:32:
+^I^Ibpf_object__destroy_skeleton(obj->skeleton);$
ERROR: code indent should never use tabs
#383: FILE: ebpf/rss.bpf.skeleton.h:33:
+^Ifree(obj);$
ERROR: code indent should never use tabs
#392: FILE: ebpf/rss.bpf.skeleton.h:42:
+^Istruct rss_bpf *obj;$
ERROR: code indent should never use tabs
#394: FILE: ebpf/rss.bpf.skeleton.h:44:
+^Iobj = (struct rss_bpf *)calloc(1, sizeof(*obj));$
ERROR: code indent should never use tabs
#395: FILE: ebpf/rss.bpf.skeleton.h:45:
+^Iif (!obj)$
ERROR: braces {} are necessary for all arms of this statement
#395: FILE: ebpf/rss.bpf.skeleton.h:45:
+ if (!obj)
[...]
ERROR: code indent should never use tabs
#396: FILE: ebpf/rss.bpf.skeleton.h:46:
+^I^Ireturn NULL;$
ERROR: code indent should never use tabs
#397: FILE: ebpf/rss.bpf.skeleton.h:47:
+^Iif (rss_bpf__create_skeleton(obj))$
ERROR: braces {} are necessary for all arms of this statement
#397: FILE:
Re: [PULL 00/45] target-arm queue
Patchew URL:
https://patchew.org/QEMU/20210603155904.26021-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210603155904.26021-1-peter.mayd...@linaro.org
Subject: [PULL 00/45] target-arm queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update]
patchew/20210525150706.294968-1-richard.hender...@linaro.org ->
patchew/20210525150706.294968-1-richard.hender...@linaro.org
- [tag update] patchew/20210603090310.2749892-1-f4...@amsat.org ->
patchew/20210603090310.2749892-1-f4...@amsat.org
- [tag update] patchew/20210603142714.224210-1-pbonz...@redhat.com ->
patchew/20210603142714.224210-1-pbonz...@redhat.com
* [new tag] patchew/20210603155904.26021-1-peter.mayd...@linaro.org ->
patchew/20210603155904.26021-1-peter.mayd...@linaro.org
Switched to a new branch 'test'
13d1972 tests/unit/test-vmstate: Assert that dup() and mkstemp() succeed
65a9ad3 tests/qtest/tpm-tests: Remove unnecessary NULL checks
2d9717a tests/qtest/pflash-cfi02-test: Avoid potential integer overflow
57adc68 tests/qtest/hd-geo-test: Fix checks on mkstemp() return value
bc92d5e tests/qtest/e1000e-test: Check qemu_recv() succeeded
b9d0072 tests/qtest/bios-tables-test: Check for dup2() failure
85706ed hvf: Simplify post reset/init/loadvm hooks
77e31cc hvf: Introduce hvf vcpu struct
f3e5711 hvf: Remove hvf-accel-ops.h
caee66d hvf: Make synchronize functions static
b2751ab hvf: Use cpu_synchronize_state()
735c1c3 hvf: Split out common code on vcpu init and destroy
24f8e94 hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t
3386f27 hvf: Make hvf_set_phys_mem() static
b8a051b hvf: Move hvf internal definitions into common header
d102c18 hvf: Move cpu functions into common directory
bad2868 hvf: Move vcpu thread functions into common directory
df87953 hvf: Move assert_hvf_ok() into common directory
64989be target/arm: Enable BFloat16 extensions
59eee63 linux-user/aarch64: Enable hwcap bits for bfloat16
5defef1 target/arm: Implement bfloat widening fma (indexed)
1af2781 target/arm: Implement bfloat widening fma (vector)
7414e76 target/arm: Implement bfloat16 matrix multiply accumulate
876c67b target/arm: Implement bfloat16 dot product (indexed)
dff99a9 target/arm: Implement bfloat16 dot product (vector)
0c4c04b softfpu: Add float_round_to_odd_inf
515c4ba target/arm: Implement vector float32 to bfloat16 conversion
e8bc502 target/arm: Implement scalar float32 to bfloat16 conversion
b8639cb target/arm: Unify unallocated path in disas_fp_1src
53a4f1c target/arm: Add isar_feature_{aa32, aa64, aa64_sve}_bf16
dc619c7 target/arm: use raise_exception_ra for stack limit exception
e81ee5b target/arm: use raise_exception_ra for MTE check failure
1b002b8 target/arm: fold do_raise_exception into raise_exception
e586d9b target/arm: fix missing exception class
7883ab2 target/arm: Mark LDS{MIN,MAX} as signed operations
80c56ee docs: Fix installation of man pages with Sphinx 4.x
c51be68 arm: Consistently use "Cortex-Axx", not "Cortex Axx"
50be882 target/arm: Allow board models to specify initial NS VTOR
37b4443 target/arm: Make FPSCR.LTPSIZE writable for MVE
f8f02ff target/arm: Implement M-profile VPR register
f8ee07a target/arm: Fix return values in fp_sysreg_checks()
59208c5 target/arm: Add MVE check to VMOV_reg_sp and VMOV_reg_dp
1e7c698 target/arm: Move fpsp/fpdp isar check into callers of do_vfp_2op_sp/dp
b5dc2b5 target/arm: Update feature checks for insns which are "MVE or FP"
37edfe9 target/arm: Add isar feature check functions for MVE
=== OUTPUT BEGIN ===
1/45 Checking commit 37edfe9232f2 (target/arm: Add isar feature check functions
for MVE)
2/45 Checking commit b5dc2b5fe840 (target/arm: Update feature checks for insns
which are "MVE or FP")
3/45 Checking commit 1e7c698a0805 (target/arm: Move fpsp/fpdp isar check into
callers of do_vfp_2op_sp/dp)
4/45 Checking commit 59208c511fe3 (target/arm: Add MVE check to VMOV_reg_sp and
VMOV_reg_dp)
ERROR: spaces required around that '*' (ctx:WxV)
#30: FILE: target/arm/translate-vfp.c:2823:
+ arg_##INSN##_##PREC *a) \
^
total: 1 errors, 0 warnings, 21 lines checked
Patch 4/45 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/45 Checking commit f8ee07a061f5 (target/arm: Fix return values in
fp_sysreg_checks())
6/45 Checking commit f8f02ff99c1e (target/arm: Implement M-profile VPR register)
7/45 Checking commit 37b444356968 (target/arm: Make FPSCR.LTPSIZE writable for
MVE)
8/45
Re: [PULL 00/42] ppc-for-6.1 queue 20210603
Patchew URL: https://patchew.org/QEMU/20210603082231.601214-1-da...@gibson.dropbear.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210603082231.601214-1-da...@gibson.dropbear.id.au Subject: [PULL 00/42] ppc-for-6.1 queue 20210603 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 8c345b3..8e6dad2 master -> master - [tag update] patchew/20210526170432.343588-1-phi...@redhat.com -> patchew/20210526170432.343588-1-phi...@redhat.com - [tag update] patchew/20210603001129.1319515-1-js...@redhat.com -> patchew/20210603001129.1319515-1-js...@redhat.com - [tag update] patchew/20210603003719.1321369-1-js...@redhat.com -> patchew/20210603003719.1321369-1-js...@redhat.com * [new tag] patchew/20210603082231.601214-1-da...@gibson.dropbear.id.au -> patchew/20210603082231.601214-1-da...@gibson.dropbear.id.au Switched to a new branch 'test' b095e5a target/ppc: fix single-step exception regression 47c29de target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree e353b8f target/ppc: Move addpcis to decodetree 0bdf1c3 target/ppc: Implement vcfuged instruction 2f32ca8 target/ppc: Implement cfuged instruction 4c6d2ea target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions 34efd90 target/ppc: Implement prefixed integer store instructions a13f791 target/ppc: Move D/DS/X-form integer stores to decodetree 4edc2c8 target/ppc: Implement prefixed integer load instructions 0c7c48d target/ppc: Move D/DS/X-form integer loads to decodetree 9a5b0df target/ppc: Implement PNOP ec1a4a5 target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI 328bcfb target/ppc: Add infrastructure for prefixed insns 5975efe target/ppc: Move page crossing check to ppc_tr_translate_insn 54117f1 target/ppc: Introduce macros to check isa extensions a36fb1f target/ppc: powerpc_excp: Consolidade TLB miss code 13a26b1 target/ppc: powerpc_excp: Remove dump_syscall_vectored 9813aa4 target/ppc: powerpc_excp: Move lpes code to where it is used f9fb77e target/ppc: overhauled and moved logic of storing fpscr 6bb7bba target/ppc: removed all mentions to PPC_DUMP_CPU a33d7b7 target/ppc: removed GEN_OPCODE decision tree a0a6db6 HMP: added info cpustats to removed_features.rst 4593178 hw/core/cpu: removed cpu_dump_statistics function d97d5aa ppc/pef.c: initialize cgs->ready in kvmppc_svm_init() 974dd76 monitor: removed cpustats command fd9ba82 target/ppc: removed mentions to DO_PPC_STATISTICS ad63f9b target/ppc: remove ppc_cpu_dump_statistics 788299e target/ppc: updated meson.build to support disable-tcg 824f724 target/ppc: created tcg-stub.c file 7156e66 target/ppc: added ifdefs around TCG-only code 08f061f target/ppc: used ternary operator when registering MAS d65dccf spapr: Set LPCR to current AIL mode when starting a new CPU a356d68 spapr: Remove stale comment about power-saving LPCR bits 656de9e target/ppc: fold ppc_store_ptcr into it's only caller 7782934 spapr: nvdimm: Fix the persistent-memory root node name in device tree 12e9934 spapr: nvdimm: Forward declare and move the definitions b0e4ac0 spapr: Fix EEH capability issue on KVM guest for PCI passthru 961e31a spapr: Don't hijack current_machine->boot_order 5f6b88e target/ppc: removed unnecessary inclusion of helper-proto.h 036ed6c target/ppc: reduce usage of fpscr_set_rounding_mode 71474f2 target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c 0a97295 target/ppc: cleaned error_report from ppc_store_sdr1 === OUTPUT BEGIN === 1/42 Checking commit 0a9729552899 (target/ppc: cleaned error_report from ppc_store_sdr1) 2/42 Checking commit 71474f2e9d8a (target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c) 3/42 Checking commit 036ed6cb6069 (target/ppc: reduce usage of fpscr_set_rounding_mode) 4/42 Checking commit 5f6b88e406f1 (target/ppc: removed unnecessary inclusion of helper-proto.h) 5/42 Checking commit 961e31a2cfe3 (spapr: Don't hijack current_machine->boot_order) 6/42 Checking commit b0e4ac014a5a (spapr: Fix EEH capability issue on KVM guest for PCI passthru) 7/42 Checking commit 12e9934ade22 (spapr: nvdimm: Forward declare and move the definitions) 8/42 Checking commit 778293405aba (spapr: nvdimm: Fix the persistent-memory root node name in device tree) 9/42 Checking commit 656de9efe247 (target/ppc: fold ppc_store_ptcr into it's only caller) 10/42 Checking commit a356d68a4835 (spapr: Remove stale comment about power-saving LPCR bits) 11/42 Checking commit d65dccfcac29 (spapr: Set LPCR to current AIL mode when starting a new CPU) 12/42 Checking commit 08f061ff723c (target/ppc: used ternary operator when registering MAS) 13/42 Checking commit 7156e661fa89
Re: [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting
Patchew URL: https://patchew.org/QEMU/20210602002210.3144559-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210602002210.3144559-1-...@linux.ibm.com Subject: [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/1622589584-22571-1-git-send-email-tsimp...@quicinc.com -> patchew/1622589584-22571-1-git-send-email-tsimp...@quicinc.com * [new tag] patchew/20210602002210.3144559-1-...@linux.ibm.com -> patchew/20210602002210.3144559-1-...@linux.ibm.com Switched to a new branch 'test' 495bc5c tests/tcg/s390x: Test SIGILL and SIGSEGV handling 2e28eb9 target/s390x: Fix SIGILL psw.addr reporting === OUTPUT BEGIN === 1/2 Checking commit 2e28eb9526d2 (target/s390x: Fix SIGILL psw.addr reporting) 2/2 Checking commit 495bc5cfd59a (tests/tcg/s390x: Test SIGILL and SIGSEGV handling) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: externs should be avoided in .c files #44: FILE: tests/tcg/s390x/signal.c:14: +void illegal_op(void); ERROR: externs should be avoided in .c files #45: FILE: tests/tcg/s390x/signal.c:15: +void after_illegal_op(void); ERROR: externs should be avoided in .c files #51: FILE: tests/tcg/s390x/signal.c:21: +void stg(void *dst, unsigned long src); ERROR: externs should be avoided in .c files #56: FILE: tests/tcg/s390x/signal.c:26: +void mvc_8(void *dst, void *src); total: 4 errors, 1 warnings, 167 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210602002210.3144559-1-...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v7 00/27] TCI fixes and cleanups
Patchew URL:
https://patchew.org/QEMU/20210601150106.12761-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210601150106.12761-1-richard.hender...@linaro.org
Subject: [PATCH v7 00/27] TCI fixes and cleanups
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210601143749.1669-1-anaidu.go...@samsung.com ->
patchew/20210601143749.1669-1-anaidu.go...@samsung.com
* [new tag]
patchew/20210601150106.12761-1-richard.hender...@linaro.org ->
patchew/20210601150106.12761-1-richard.hender...@linaro.org
Switched to a new branch 'test'
ff73f2a tests/tcg: Increase timeout for TCI
f786057 tcg/tci: Use {set,clear}_helper_retaddr
190ad1f tcg/tci: Remove the qemu_ld/st_type macros
1e2156a Revert "tcg/tci: Use exec/cpu_ldst.h interfaces"
5500fe7 tcg/tci: Split out tci_qemu_ld, tci_qemu_st
cc70f98 tcg/tci: Implement add2, sub2
fe9d5c6 tcg/tci: Implement mulu2, muls2
2da224a tcg/tci: Implement clz, ctz, ctpop
e4cd4f1 tcg/tci: Implement extract, sextract
e637074 tcg/tci: Implement andc, orc, eqv, nand, nor
fe78aa9 tcg/tci: Implement movcond
4244f97 tcg/tci: Implement goto_ptr
d5129d0 tcg/tci: Change encoding to uint32_t units
b9936ff tcg/tci: Remove tci_write_reg
55ddc15 tcg/tci: Emit setcond before brcond
7d88fcd tcg/tci: Reserve r13 for a temporary
e4d9785 tcg/tci: Use ffi for calls
7c53811 tcg/tci: Move call-return regs to end of tcg_target_reg_alloc_order
df9f663 tcg/tci: Improve tcg_target_call_clobber_regs
7b199c1 tcg: Build ffi data structures for helpers
4cdaf7c tcg: Add tcg_call_func
b5d0c45 tcg: Store the TCGHelperInfo in the TCGOp for call
998791a accel/tcg: Add tcg call flags to plugins helpers
31812d5 plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb
b12d667 accel/tcg/plugin-gen: Drop inline markers
857f3d7 tcg: Add tcg_call_flags
7507c52 tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode
=== OUTPUT BEGIN ===
1/27 Checking commit 7507c521494e (tcg: Combine dh_is_64bit and dh_is_signed to
dh_typecode)
2/27 Checking commit 857f3d7ba371 (tcg: Add tcg_call_flags)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 106 lines checked
Patch 2/27 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/27 Checking commit b12d66702acb (accel/tcg/plugin-gen: Drop inline markers)
4/27 Checking commit 31812d57a48c (plugins: Drop tcg_flags from struct
qemu_plugin_dyn_cb)
5/27 Checking commit 998791ad868e (accel/tcg: Add tcg call flags to plugins
helpers)
WARNING: line over 80 characters
#27: FILE: accel/tcg/plugin-helpers.h:3:
+DEF_HELPER_FLAGS_4(plugin_vcpu_mem_cb, TCG_CALL_NO_RWG, void, i32, i32, i64,
ptr)
total: 0 errors, 1 warnings, 6 lines checked
Patch 5/27 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/27 Checking commit b5d0c45e0f8b (tcg: Store the TCGHelperInfo in the TCGOp
for call)
7/27 Checking commit 4cdaf7c2074a (tcg: Add tcg_call_func)
8/27 Checking commit 7b199c1dd9c5 (tcg: Build ffi data structures for helpers)
9/27 Checking commit df9f6637a168 (tcg/tci: Improve
tcg_target_call_clobber_regs)
10/27 Checking commit 7c538119a809 (tcg/tci: Move call-return regs to end of
tcg_target_reg_alloc_order)
11/27 Checking commit e4d97852d0bf (tcg/tci: Use ffi for calls)
ERROR: suspect code indent for conditional statements (8, 11)
#74: FILE: tcg/tcg.c:2148:
if (TCG_TARGET_REG_BITS < 64 && is_64bit) {
+ /*
total: 1 errors, 0 warnings, 392 lines checked
Patch 11/27 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/27 Checking commit 7d88fcde0f51 (tcg/tci: Reserve r13 for a temporary)
13/27 Checking commit 55ddc15b0444 (tcg/tci: Emit setcond before brcond)
14/27 Checking commit b9936ff729dd (tcg/tci: Remove tci_write_reg)
15/27 Checking commit d5129d03bd95 (tcg/tci: Change encoding to uint32_t units)
16/27 Checking commit 4244f975b69a (tcg/tci: Implement goto_ptr)
17/27 Checking commit fe78aa960301 (tcg/tci: Implement movcond)
18/27 Checking commit e6370741791a (tcg/tci: Implement andc, orc, eqv, nand,
nor)
19/27 Checking commit e4cd4f1ec298 (tcg/tci: Implement extract, sextract)
20/27 Checking commit 2da224ab55ce (tcg/tci: Implement clz, ctz, ctpop)
21/27 Checking commit fe9d5c60a7de (tcg/tci: Implement mulu2, muls2)
22/27 Checking commit cc70f986db4d (tcg/tci: Implement add2,
Re: [PATCH v2 00/11] linux-user changes to run docker
Patchew URL: https://patchew.org/QEMU/20210531055019.10149-1-yamam...@midokura.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210531055019.10149-1-yamam...@midokura.com Subject: [PATCH v2 00/11] linux-user changes to run docker === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9266033 linux-user: always assume preserve_argv0 for now [!MERGE] c47e5f7 linux-user: a crude hack for libcontainer (CLONE_PARENT) [!MERGE] 3918e1b linux-user: Make the qemu detection for /proc/$pid/exe a bit conservative c085fdc linux-user: Implement exec of /proc/$pid/exe of qemu process 1183bf9 linux-user: simplify is_proc_myself 3d2e26d linux-user: add get_exe_path 4468f68 linux-user: Implement pivot_root 42242cc linux-user: make exec_path realpath 057e7e4 linux-user: dup the execfd on start up 187d6d2 linux-user: Fix the execfd case of /proc/self/exe open 02ef5e5 linux-user: handle /proc/self/exe for execve === OUTPUT BEGIN === 1/11 Checking commit 02ef5e5d9e50 (linux-user: handle /proc/self/exe for execve) 2/11 Checking commit 187d6d29d488 (linux-user: Fix the execfd case of /proc/self/exe open) 3/11 Checking commit 057e7e49d4fe (linux-user: dup the execfd on start up) 4/11 Checking commit 42242cc0513b (linux-user: make exec_path realpath) 5/11 Checking commit 4468f68480f3 (linux-user: Implement pivot_root) WARNING: architecture specific defines should be avoided #23: FILE: linux-user/syscall.c:8257: +#if defined(TARGET_NR_pivot_root) && defined(__NR_pivot_root) total: 0 errors, 1 warnings, 33 lines checked Patch 5/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/11 Checking commit 3d2e26daa82e (linux-user: add get_exe_path) 7/11 Checking commit 1183bf9702cb (linux-user: simplify is_proc_myself) 8/11 Checking commit c085fdc89c7c (linux-user: Implement exec of /proc/$pid/exe of qemu process) 9/11 Checking commit 3918e1b7eee5 (linux-user: Make the qemu detection for /proc/$pid/exe a bit conservative) 10/11 Checking commit c47e5f77ef07 (linux-user: a crude hack for libcontainer (CLONE_PARENT) [!MERGE]) 11/11 Checking commit 9266033e47cb (linux-user: always assume preserve_argv0 for now [!MERGE]) ERROR: if this code is redundant consider removing it #26: FILE: linux-user/main.c:729: +#if 0 total: 1 errors, 0 warnings, 38 lines checked Patch 11/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210531055019.10149-1-yamam...@midokura.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/11] Unified peripheral emulation for Renesas chips
Patchew URL:
https://patchew.org/QEMU/20210527052122.97103-1-ys...@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210527052122.97103-1-ys...@users.sourceforge.jp
Subject: [PATCH 00/11] Unified peripheral emulation for Renesas chips
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210527052122.97103-1-ys...@users.sourceforge.jp
-> patchew/20210527052122.97103-1-ys...@users.sourceforge.jp
Switched to a new branch 'test'
0d61629 hw/rx: rx-gdbsim Add bootstrup for linux
5595fd4 hw/sh4: sh7750 use new hw modules.
f85d3d2 hw/sh4: sh7750 Add CPG.
9422b37 hw/rx: rx62n use new hw modules.
88d7ca2 hw/timer: Renesas 8bit timer.
afe51ff hw/rx: Add RX62N Clock generator
87c0b3e hw/timer: Remove renesas_cmt.
e0a4816 hw/timer: Remove sh_timer.
0f983ff hw/timer: Renesas TMU/CMT module.
a5ba8bb hw/char: remove sh_serial.
872e5de hw/char: Renesas SCI module.
=== OUTPUT BEGIN ===
1/11 Checking commit 872e5de1daf1 (hw/char: Renesas SCI module.)
2/11 Checking commit a5ba8bb0a18d (hw/char: remove sh_serial.)
3/11 Checking commit 0f983ff94436 (hw/timer: Renesas TMU/CMT module.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
total: 0 errors, 1 warnings, 752 lines checked
Patch 3/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit e0a48164d14f (hw/timer: Remove sh_timer.)
5/11 Checking commit 87c0b3e06524 (hw/timer: Remove renesas_cmt.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
deleted file mode 100644
total: 0 errors, 1 warnings, 7 lines checked
Patch 5/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit afe51ff3750d (hw/rx: Add RX62N Clock generator)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31:
new file mode 100644
total: 0 errors, 1 warnings, 561 lines checked
Patch 6/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/11 Checking commit 88d7ca270dfb (hw/timer: Renesas 8bit timer.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
deleted file mode 100644
total: 0 errors, 1 warnings, 626 lines checked
Patch 7/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/11 Checking commit 9422b37a5c14 (hw/rx: rx62n use new hw modules.)
9/11 Checking commit f85d3d235566 (hw/sh4: sh7750 Add CPG.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#98:
new file mode 100644
total: 0 errors, 1 warnings, 616 lines checked
Patch 9/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 5595fd490cbc (hw/sh4: sh7750 use new hw modules.)
ERROR: space required before the open parenthesis '('
#88: FILE: hw/sh4/sh7750.c:819:
+switch(feat) {
ERROR: braces {} are necessary for all arms of this statement
#105: FILE: hw/sh4/sh7750.c:836:
+if (tei_source)
[...]
ERROR: braces {} are necessary for all arms of this statement
#107: FILE: hw/sh4/sh7750.c:838:
+if (bri_source)
[...]
ERROR: code indent should never use tabs
#142: FILE: hw/sh4/sh7750.c:916:
+^I^Is->intc.irqs[TMU2_TICPI], cpg);$
ERROR: code indent should never use tabs
#157: FILE: hw/sh4/sh7750.c:937:
+^I^INULL, NULL, cpg);$
total: 5 errors, 0 warnings, 153 lines checked
Patch 10/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/11 Checking commit 0d616299f2f2 (hw/rx: rx-gdbsim Add bootstrup for linux)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210527052122.97103-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v2 00/28] Convert floatx80 and float128 to FloatParts
Patchew URL:
https://patchew.org/QEMU/20210525150706.294968-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210525150706.294968-1-richard.hender...@linaro.org
Subject: [PATCH v2 00/28] Convert floatx80 and float128 to FloatParts
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
0dab1d3..92f8c6f master -> master
- [tag update] patchew/20210525134458.6675-1-peter.mayd...@linaro.org ->
patchew/20210525134458.6675-1-peter.mayd...@linaro.org
* [new tag]
patchew/20210525150706.294968-1-richard.hender...@linaro.org ->
patchew/20210525150706.294968-1-richard.hender...@linaro.org
Switched to a new branch 'test'
0f077a6 softfloat: Use hard-float for {u}int64_to_float{32, 64}
abdc56a tests/fp: Enable more tests
90ebc91 softfloat: Convert modrem operations to FloatParts
5e7da03 softfloat: Move floatN_log2 to softfloat-parts.c.inc
618addc softfloat: Convert float32_exp2 to FloatParts
14dd687 softfloat: Convert floatx80 compare to FloatParts
6bce5a6 softfloat: Convert floatx80_scalbn to FloatParts
d97aad0 softfloat: Convert floatx80 to integer to FloatParts
2c98bf7 softfloat: Convert floatx80 float conversions to FloatParts
0aa9a19 softfloat: Convert integer to floatx80 to FloatParts
004e7d5 softfloat: Convert floatx80_round_to_int to FloatParts
8eb0f0f softfloat: Convert floatx80_round to FloatParts
4a12947 softfloat: Convert floatx80_sqrt to FloatParts
04b9728 softfloat: Convert floatx80_div to FloatParts
00a81f5 softfloat: Convert floatx80_mul to FloatParts
290458a softfloat: Convert floatx80_add/sub to FloatParts
b29bb0d tests/fp/fp-test: Reverse order of floatx80 precision tests
6799791 softfloat: Adjust parts_uncanon_normal for floatx80
788d0fa softfloat: Introduce Floatx80RoundPrec
ea9f90a softfloat: Reduce FloatFmt
8b7c749 softfloat: Split out parts_uncanon_normal
6e46f7a softfloat: Move sqrt_float to softfloat-parts.c.inc
53563e4 softfloat: Move scalbn_decomposed to softfloat-parts.c.inc
e5ea67c softfloat: Move compare_floats to softfloat-parts.c.inc
d03d501 softfloat: Move minmax_flags to softfloat-parts.c.inc
1db2bf4 softfloat: Move uint_to_float to softfloat-parts.c.inc
b37889b softfloat: Move int_to_float to softfloat-parts.c.inc
52b5170 softfloat: Move round_to_uint_and_pack to softfloat-parts.c.inc
=== OUTPUT BEGIN ===
1/28 Checking commit 52b5170f8ce8 (softfloat: Move round_to_uint_and_pack to
softfloat-parts.c.inc)
2/28 Checking commit b37889badd97 (softfloat: Move int_to_float to
softfloat-parts.c.inc)
3/28 Checking commit 1db2bf401a92 (softfloat: Move uint_to_float to
softfloat-parts.c.inc)
4/28 Checking commit d03d501737a1 (softfloat: Move minmax_flags to
softfloat-parts.c.inc)
5/28 Checking commit e5ea67cc47c6 (softfloat: Move compare_floats to
softfloat-parts.c.inc)
6/28 Checking commit 53563e40e3d9 (softfloat: Move scalbn_decomposed to
softfloat-parts.c.inc)
7/28 Checking commit 6e46f7a30760 (softfloat: Move sqrt_float to
softfloat-parts.c.inc)
8/28 Checking commit 8b7c7497d507 (softfloat: Split out parts_uncanon_normal)
9/28 Checking commit ea9f90a27773 (softfloat: Reduce FloatFmt)
10/28 Checking commit 788d0fa8f439 (softfloat: Introduce Floatx80RoundPrec)
11/28 Checking commit 6799791547b9 (softfloat: Adjust parts_uncanon_normal for
floatx80)
12/28 Checking commit b29bb0d96d17 (tests/fp/fp-test: Reverse order of floatx80
precision tests)
13/28 Checking commit 290458a828d1 (softfloat: Convert floatx80_add/sub to
FloatParts)
14/28 Checking commit 00a81f53fca8 (softfloat: Convert floatx80_mul to
FloatParts)
15/28 Checking commit 04b9728b5777 (softfloat: Convert floatx80_div to
FloatParts)
16/28 Checking commit 4a12947235c9 (softfloat: Convert floatx80_sqrt to
FloatParts)
17/28 Checking commit 8eb0f0fc3e41 (softfloat: Convert floatx80_round to
FloatParts)
18/28 Checking commit 004e7d54510c (softfloat: Convert floatx80_round_to_int to
FloatParts)
19/28 Checking commit 0aa9a1995443 (softfloat: Convert integer to floatx80 to
FloatParts)
20/28 Checking commit 2c98bf75821a (softfloat: Convert floatx80 float
conversions to FloatParts)
21/28 Checking commit d97aad065132 (softfloat: Convert floatx80 to integer to
FloatParts)
22/28 Checking commit 6bce5a65cf2e (softfloat: Convert floatx80_scalbn to
FloatParts)
23/28 Checking commit 14dd6876c863 (softfloat: Convert floatx80 compare to
FloatParts)
24/28 Checking commit 618addc4c22e (softfloat: Convert float32_exp2 to
FloatParts)
25/28 Checking commit 5e7da037f221 (softfloat: Move floatN_log2 to
softfloat-parts.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
Re: [PATCH 0/3] testing block device blocksizes
Patchew URL:
https://patchew.org/QEMU/20210525124753.528516-1-kit.westn...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210525124753.528516-1-kit.westn...@gmail.com
Subject: [PATCH 0/3] testing block device blocksizes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210525124753.528516-1-kit.westn...@gmail.com ->
patchew/20210525124753.528516-1-kit.westn...@gmail.com
Switched to a new branch 'test'
8319440 block/blkdebug: add log-blocksize and phys-blocksize parameters
e09eac6 tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test
0442070 block/blkdebug: add blocksize parameter
=== OUTPUT BEGIN ===
1/3 Checking commit 0442070571e5 (block/blkdebug: add blocksize parameter)
WARNING: line over 80 characters
#44: FILE: block/blkdebug.c:572:
+if (s->blocksize && (s->blocksize >= INT_MAX ||
!is_power_of_2(s->blocksize))) {
ERROR: braces {} are necessary for all arms of this statement
#61: FILE: block/blkdebug.c:1004:
+if (!s->blocksize)
[...]
total: 1 errors, 1 warnings, 63 lines checked
Patch 1/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit e09eac6b4197 (tests/qtest/virtio-scsi-test: add unmap large
LBA with 4k blocks test)
ERROR: do not use C99 // comments
#33: FILE: tests/qtest/virtio-scsi-test.c:213:
+// default null-co device size is 2**30
ERROR: do not use C99 // comments
#34: FILE: tests/qtest/virtio-scsi-test.c:214:
+// LBA 0x7fff is ~ 1/8 into device, with 4k blocks
ERROR: do not use C99 // comments
#35: FILE: tests/qtest/virtio-scsi-test.c:215:
+// if check_lba_range incorrectly using 512 bytes, will trigger sense error
ERROR: do not use C99 // comments
#37: FILE: tests/qtest/virtio-scsi-test.c:217:
+0x00, 0x16, // unmap data length
ERROR: do not use C99 // comments
#38: FILE: tests/qtest/virtio-scsi-test.c:218:
+0x00, 0x10, // unmap block descriptor data length
ERROR: do not use C99 // comments
#39: FILE: tests/qtest/virtio-scsi-test.c:219:
+0x00, 0x00, 0x00, 0x00, // reserved
ERROR: do not use C99 // comments
#40: FILE: tests/qtest/virtio-scsi-test.c:220:
+0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x7f, 0xff, // LBA
ERROR: do not use C99 // comments
#41: FILE: tests/qtest/virtio-scsi-test.c:221:
+0x00, 0x00, 0x03, 0xff, // sector count
ERROR: do not use C99 // comments
#42: FILE: tests/qtest/virtio-scsi-test.c:222:
+0x00, 0x00, 0x00, 0x00, //reserved
total: 9 errors, 0 warnings, 66 lines checked
Patch 2/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit 8319440a28b2 (block/blkdebug: add log-blocksize and
phys-blocksize parameters)
ERROR: line over 90 characters
#53: FILE: block/blkdebug.c:591:
+if (s->phys_blocksize && (s->phys_blocksize >= INT_MAX ||
!is_power_of_2(s->phys_blocksize))) {
ERROR: line over 90 characters
#60: FILE: block/blkdebug.c:598:
+if (s->log_blocksize && (s->log_blocksize >= INT_MAX ||
!is_power_of_2(s->log_blocksize))) {
total: 2 errors, 0 warnings, 67 lines checked
Patch 3/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210525124753.528516-1-kit.westn...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v7 00/92] target/arm: Implement SVE2
Patchew URL:
https://patchew.org/QEMU/20210525010358.152808-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210525010358.152808-1-richard.hender...@linaro.org
Subject: [PATCH v7 00/92] target/arm: Implement SVE2
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20210525010358.152808-1-richard.hender...@linaro.org ->
patchew/20210525010358.152808-1-richard.hender...@linaro.org
Switched to a new branch 'test'
c92f000 target/arm: Enable SVE2 and related extensions
69c800e linux-user/aarch64: Enable hwcap bits for sve2 and related extensions
01eda80 target/arm: Implement integer matrix multiply accumulate
14cc122 target/arm: Implement aarch32 VSUDOT, VUSDOT
0a65323 target/arm: Split decode of VSDOT and VUDOT
1941b29 target/arm: Split out do_neon_ddda
f7218e0 target/arm: Fix decode for VDOT (indexed)
9529cc6 target/arm: Remove unused fpst from VDOT_scalar
3ce0386 target/arm: Split out do_neon_ddda_fpst
1d7de85 target/arm: Implement aarch64 SUDOT, USDOT
dd1f6e8 target/arm: Implement SVE2 fp multiply-add long
5989493 target/arm: Move endian adjustment macros to vec_internal.h
d2a394e target/arm: Implement SVE2 bitwise shift immediate
d4e451b target/arm: Implement 128-bit ZIP, UZP, TRN
cf8b092 target/arm: Implement SVE2 LD1RO
d214a19 target/arm: Tidy do_ldrq
67ea69f target/arm: Share table of sve load functions
8c5f448 target/arm: Implement SVE2 FLOGB
816872f target/arm: Implement SVE2 FCVTXNT, FCVTX
48f2b22 target/arm: Implement SVE2 FCVTLT
e69a6dd target/arm: Implement SVE2 FCVTNT
4def475 target/arm: Implement SVE2 TBL, TBX
d506b3a target/arm: Implement SVE2 crypto constructive binary operations
1c998ce target/arm: Implement SVE2 crypto destructive binary operations
1970950 target/arm: Implement SVE2 crypto unary operations
9206764 target/arm: Implement SVE mixed sign dot product
5ea763f target/arm: Implement SVE mixed sign dot product (indexed)
2f5803a target/arm: Macroize helper_gvec_{s,u}dot_idx_{b,h}
83112aa target/arm: Macroize helper_gvec_{s,u}dot_{b,h}
159b350 target/arm: Implement SVE2 complex integer dot product
21c9d3b target/arm: Implement SVE2 complex integer multiply-add (indexed)
322bb04 target/arm: Implement SVE2 integer multiply long (indexed)
58ce7f2 target/arm: Implement SVE2 multiply-add long (indexed)
80fafdc target/arm: Implement SVE2 saturating multiply high (indexed)
e64d679 target/arm: Implement SVE2 signed saturating doubling multiply high
cf18b22 target/arm: Implement SVE2 saturating multiply (indexed)
19eb26e target/arm: Implement SVE2 saturating multiply-add (indexed)
1c9f4f1 target/arm: Implement SVE2 saturating multiply-add high (indexed)
3f2a3c3 target/arm: Implement SVE2 integer multiply-add (indexed)
bfca929 target/arm: Implement SVE2 integer multiply (indexed)
c4b5063 target/arm: Split out formats for 3 vectors + 1 index
194b523 target/arm: Split out formats for 2 vectors + 1 index
e0372f8 target/arm: Pass separate addend to FCMLA helpers
599a38f target/arm: Pass separate addend to {U, S}DOT helpers
f385927 target/arm: Use correct output type for gvec_sdot_*_b
22df8b0 target/arm: Implement SVE2 SPLICE, EXT
952e3b9 target/arm: Implement SVE2 FMMLA
5a516f9 target/arm: Implement SVE2 gather load insns
bb92adf target/arm: Implement SVE2 scatter store insns
e673ae8 target/arm: Implement SVE2 XAR
96aaa72 target/arm: Implement SVE2 HISTCNT, HISTSEG
90898ea target/arm: Implement SVE2 RSUBHNB, RSUBHNT
d8b4007 target/arm: Implement SVE2 SUBHNB, SUBHNT
db298a0 target/arm: Implement SVE2 RADDHNB, RADDHNT
72940b4 target/arm: Implement SVE2 ADDHNB, ADDHNT
a34cfbf target/arm: Implement SVE2 complex integer multiply-add
b4dae6e target/arm: Implement SVE2 integer multiply-add long
43a2c90 target/arm: Implement SVE2 saturating multiply-add high
6e27f44 target/arm: Implement SVE2 saturating multiply-add long
9705463 target/arm: Implement SVE2 MATCH, NMATCH
fcbbefe target/arm: Implement SVE2 bitwise ternary operations
ae3df35 target/arm: Implement SVE2 WHILERW, WHILEWR
3fae73d target/arm: Implement SVE2 WHILEGT, WHILEGE, WHILEHI, WHILEHS
0547622 target/arm: Implement SVE2 SQSHRN, SQRSHRN
0dfa93e target/arm: Implement SVE2 UQSHRN, UQRSHRN
4cab3a7 target/arm: Implement SVE2 SQSHRUN, SQRSHRUN
468c3f7 target/arm: Implement SVE2 SHRN, RSHRN
fb19eea target/arm: Implement SVE2 floating-point pairwise
5b09dd6 target/arm: Implement SVE2 saturating extract narrow
48576f9 target/arm: Implement SVE2 integer absolute difference and accumulate
a696626 target/arm: Implement SVE2 bitwise shift and insert
fc08d8a target/arm: Implement SVE2 bitwise shift right and
Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled
Patchew URL:
https://patchew.org/QEMU/20210524225608.3191809-1-swethajoshi...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210524225608.3191809-1-swethajoshi...@gmail.com
Subject: [PATCH] Adding ifdefs to call the respective routines only when their
configs are enabled
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210524225608.3191809-1-swethajoshi...@gmail.com
-> patchew/20210524225608.3191809-1-swethajoshi...@gmail.com
Switched to a new branch 'test'
18cab39 Adding ifdefs to call the respective routines only when their configs
are enabled
=== OUTPUT BEGIN ===
ERROR: suspect code indent for conditional statements (16, 18)
#38: FILE: target/arm/kvm64.c:1433:
+if (acpi_ghes_record_errors(ACPI_HEST_SRC_ID_SEA, paddr)) {
+ error_report("failed to record the error");
total: 1 errors, 0 warnings, 28 lines checked
Commit 18cab39bcd46 (Adding ifdefs to call the respective routines only when
their configs are enabled) has style problems, please review. If any of these
errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210524225608.3191809-1-swethajoshi...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/28] Misc patches for 2021-05-24
Patchew URL: https://patchew.org/QEMU/20210524164131.383778-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210524164131.383778-1-pbonz...@redhat.com Subject: [PULL 00/28] Misc patches for 2021-05-24 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210520152840.24453-1-peter.mayd...@linaro.org -> patchew/20210520152840.24453-1-peter.mayd...@linaro.org * [new tag] patchew/20210524164131.383778-1-pbonz...@redhat.com -> patchew/20210524164131.383778-1-pbonz...@redhat.com Switched to a new branch 'test' 0fa080f gitlab-ci: use --meson=git for CFI jobs bbddd33 hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio 3905339 configure: Avoid error messages about missing *-config-*.h files de92a99 doc: Add notes about -mon option mode=control argument. 42b8d6b qemu-config: load modules when instantiating option groups 5219b76 vl: allow not specifying size in -m when using -M memory-backend 72e9baf replication: move include out of root directory ce41cf6 remove qemu-options* from root directory ce87fc2 meson: Set implicit_include_directories to false 9832b50 tests/qtest/fuzz: Fix build failure c0901ba KVM: Dirty ring support 11082db KVM: Disable manual dirty log when dirty ring enabled b01a662 KVM: Add dirty-ring-size property 95a5168 KVM: Cache kvm slot dirty bitmap size e62cfb6 KVM: Simplify dirty log sync in kvm_set_phys_mem c9334d4 KVM: Provide helper to sync dirty bitmap from slot to ramblock 57bbb8d KVM: Provide helper to get kvm dirty log b4bad4a KVM: Create the KVMSlot dirty bitmap on flag changes f3264ce KVM: Use a big lock to replace per-kml slots_lock 2d1e6d4 memory: Introduce log_sync_global() to memory listener 4252ee3 KVM: do not allow setting properties at runtime 373bf6f qtest: add a QOM object for qtest 5d462c5 object: add more commands to preconfig mode d850681 i386/cpu: Expose AVX_VNNI instruction to guest 3827fa7 hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' 0d602e0 configure: simplify assignment to GIT_SUBMODULES 8e551f5 configure: check for submodules if --with-git-submodules=ignore 173e6ca configure: Only clone softfloat-3 repositories if TCG is enabled === OUTPUT BEGIN === 1/28 Checking commit 173e6cae6713 (configure: Only clone softfloat-3 repositories if TCG is enabled) 2/28 Checking commit 8e551f518944 (configure: check for submodules if --with-git-submodules=ignore) 3/28 Checking commit 0d602e0162d6 (configure: simplify assignment to GIT_SUBMODULES) 4/28 Checking commit 3827fa74f840 (hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on') 5/28 Checking commit d850681c4caf (i386/cpu: Expose AVX_VNNI instruction to guest) 6/28 Checking commit 5d462c51f715 (object: add more commands to preconfig mode) 7/28 Checking commit 373bf6f3d4ee (qtest: add a QOM object for qtest) 8/28 Checking commit 4252ee36526c (KVM: do not allow setting properties at runtime) ERROR: line over 90 characters #33: FILE: accel/kvm/kvm-all.c:3115: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); ERROR: line over 90 characters #45: FILE: accel/kvm/kvm-all.c:3134: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 2 errors, 0 warnings, 37 lines checked Patch 8/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/28 Checking commit 2d1e6d4364d0 (memory: Introduce log_sync_global() to memory listener) 10/28 Checking commit f3264ce3e7d1 (KVM: Use a big lock to replace per-kml slots_lock) 11/28 Checking commit b4bad4a990b0 (KVM: Create the KVMSlot dirty bitmap on flag changes) 12/28 Checking commit 57bbb8d7afa0 (KVM: Provide helper to get kvm dirty log) 13/28 Checking commit c9334d40deca (KVM: Provide helper to sync dirty bitmap from slot to ramblock) 14/28 Checking commit e62cfb673d6a (KVM: Simplify dirty log sync in kvm_set_phys_mem) 15/28 Checking commit 95a5168a97dc (KVM: Cache kvm slot dirty bitmap size) 16/28 Checking commit b01a66229a2b (KVM: Add dirty-ring-size property) ERROR: line over 90 characters #59: FILE: accel/kvm/kvm-all.c:3206: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 1 errors, 0 warnings, 94 lines checked Patch 16/28 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/28 Checking commit 11082db128f9 (KVM: Disable manual dirty log when dirty ring enabled) 18/28 Checking
Re: [RFC PATCH] linux-user: glib-ify is_proc_myself
Patchew URL:
https://patchew.org/QEMU/20210524112323.2310-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210524112323.2310-1-alex.ben...@linaro.org
Subject: [RFC PATCH] linux-user: glib-ify is_proc_myself
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210524112323.2310-1-alex.ben...@linaro.org ->
patchew/20210524112323.2310-1-alex.ben...@linaro.org
Switched to a new branch 'test'
4e0076f linux-user: glib-ify is_proc_myself
=== OUTPUT BEGIN ===
ERROR: "foo * bar" should be "foo *bar"
#43: FILE: linux-user/syscall.c:7996:
+g_autofree char * myself = g_strdup_printf("%d/", getpid());
total: 1 errors, 0 warnings, 52 lines checked
Commit 4e0076fad27e (linux-user: glib-ify is_proc_myself) has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210524112323.2310-1-alex.ben...@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/11] Ui 20210521 patches
Patchew URL: https://patchew.org/QEMU/20210521125119.3173309-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210521125119.3173309-1-kra...@redhat.com Subject: [PULL 00/11] Ui 20210521 patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210521125119.3173309-1-kra...@redhat.com -> patchew/20210521125119.3173309-1-kra...@redhat.com Switched to a new branch 'test' 6620e56 ui/gtk: add clipboard support e49030e ui/gtk: move struct GtkDisplayState to ui/gtk.h 8b242b6 ui/vnc: clipboard support 6bb54b4 ui/vdagent: add clipboard support 29ac93c ui/vdagent: add mouse support 1f34d34 ui/vdagent: core infrastructure fde97a6 ui: add clipboard documentation 4af3865 ui: add clipboard infrastructure ddbe639 build: add separate spice-protocol config option 2d9b49f ui/spice-display: check NULL pointer in interface_release_resource() 9b35ed2 vnc: spelling fix (enable->enabled) === OUTPUT BEGIN === 1/11 Checking commit 9b35ed2d6285 (vnc: spelling fix (enable->enabled)) 2/11 Checking commit 2d9b49ff5b85 (ui/spice-display: check NULL pointer in interface_release_resource()) 3/11 Checking commit ddbe639f67c9 (build: add separate spice-protocol config option) 4/11 Checking commit 4af38659ec52 (ui: add clipboard infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 161 lines checked Patch 4/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/11 Checking commit fde97a69a5b3 (ui: add clipboard documentation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 WARNING: line over 80 characters #92: FILE: include/ui/clipboard.h:43: + * @QEMU_CLIPBOARD_SELECTION_PRIMARY: primary selection (select + middle mouse button). total: 0 errors, 2 warnings, 194 lines checked Patch 5/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/11 Checking commit 1f34d34394a4 (ui/vdagent: core infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #105: new file mode 100644 ERROR: if this code is redundant consider removing it #163: FILE: ui/vdagent.c:54: +#if 0 WARNING: line over 80 characters #165: FILE: ui/vdagent.c:56: +[VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] = "clipboard-no-release-on-regrab", ERROR: if this code is redundant consider removing it #186: FILE: ui/vdagent.c:77: +#if 0 WARNING: line over 80 characters #247: FILE: ui/vdagent.c:138: + sizeof(VDAgentAnnounceCapabilities) + total: 2 errors, 3 warnings, 412 lines checked Patch 6/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/11 Checking commit 29ac93cf036e (ui/vdagent: add mouse support) 8/11 Checking commit 6bb54b44dd36 (ui/vdagent: add clipboard support) ERROR: if this code is redundant consider removing it #124: FILE: ui/vdagent.c:120: +#if 0 WARNING: line over 80 characters #444: FILE: ui/vdagent.c:759: +cfg->clipboard = qemu_opt_get_bool(opts, "clipboard", VDAGENT_CLIPBOARD_DEFAULT); total: 1 errors, 1 warnings, 394 lines checked Patch 8/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/11 Checking commit 8b242b60adb3 (ui/vnc: clipboard support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 WARNING: line over 80 characters #283: FILE: ui/vnc-clipboard.c:243: +void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data) WARNING: line over 80 characters #292: FILE: ui/vnc-clipboard.c:252: +qemu_clipboard_info_new(>cbpeer, QEMU_CLIPBOARD_SELECTION_CLIPBOARD); WARNING: line over 80 characters #336: FILE: ui/vnc-clipboard.c:296: +qemu_clipboard_info_new(>cbpeer, QEMU_CLIPBOARD_SELECTION_CLIPBOARD); WARNING: line over 80 characters #503: FILE: ui/vnc.h:643: +void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data); total: 0 errors, 5 warnings, 451 lines checked Patch 9/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/11 Checking commit e49030e96e91 (ui/gtk: move struct GtkDisplayState
Re: [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting
Patchew URL: https://patchew.org/QEMU/2021052908.2843735-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 2021052908.2843735-1-...@linux.ibm.com Subject: [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 0b5acf8..da9076f master -> master * [new tag] patchew/2021052908.2843735-1-...@linux.ibm.com -> patchew/2021052908.2843735-1-...@linux.ibm.com Switched to a new branch 'test' 195f303 tests/tcg/s390x: Test SIGILL handling 37f7389 target/s390x: Fix SIGILL psw.addr reporting === OUTPUT BEGIN === 1/2 Checking commit 37f73891cb22 (target/s390x: Fix SIGILL psw.addr reporting) 2/2 Checking commit 195f303f366e (tests/tcg/s390x: Test SIGILL handling) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: externs should be avoided in .c files #43: FILE: tests/tcg/s390x/sigill.c:13: +void expected_si_addr(void); ERROR: externs should be avoided in .c files #44: FILE: tests/tcg/s390x/sigill.c:14: +void expected_psw_addr(void); total: 2 errors, 1 warnings, 56 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/2021052908.2843735-1-...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/2] Fix SIGILL psw.addr reporting
Patchew URL: https://patchew.org/QEMU/20210521030146.2831663-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210521030146.2831663-1-...@linux.ibm.com Subject: [PATCH 0/2] Fix SIGILL psw.addr reporting === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210521030146.2831663-1-...@linux.ibm.com -> patchew/20210521030146.2831663-1-...@linux.ibm.com Switched to a new branch 'test' 069d02b tests/tcg/s390x: Test SIGILL handling a869643 target/s390x: Fix SIGILL psw.addr reporting === OUTPUT BEGIN === 1/2 Checking commit a86964364d4d (target/s390x: Fix SIGILL psw.addr reporting) 2/2 Checking commit 069d02b0edf2 (tests/tcg/s390x: Test SIGILL handling) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: externs should be avoided in .c files #37: FILE: tests/tcg/s390x/sigill.c:7: +extern char expected_si_addr[]; ERROR: externs should be avoided in .c files #38: FILE: tests/tcg/s390x/sigill.c:8: +extern char expected_psw_addr[]; total: 2 errors, 1 warnings, 45 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210521030146.2831663-1-...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/9] target/arm: MVE preliminaries
Patchew URL: https://patchew.org/QEMU/20210520152840.24453-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210520152840.24453-1-peter.mayd...@linaro.org Subject: [PATCH 0/9] target/arm: MVE preliminaries === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210520152840.24453-1-peter.mayd...@linaro.org -> patchew/20210520152840.24453-1-peter.mayd...@linaro.org * [new tag] patchew/20210520153831.11873-1-alex.ben...@linaro.org -> patchew/20210520153831.11873-1-alex.ben...@linaro.org Switched to a new branch 'test' 5714b29 target/arm: Allow board models to specify initial NS VTOR 0a91c4d target/arm: Enable FPSCR.QC bit for MVE d47da78 target/arm: Make FPSCR.LTPSIZE writable for MVE 6c7229a target/arm: Implement M-profile VPR register 47dbed2 target/arm: Fix return values in fp_sysreg_checks() 4b36a72 target/arm: Add MVE check to VMOV_reg_sp and VMOV_reg_dp dbefafd target/arm: Move fpsp/fpdp isar check into callers of do_vfp_2op_sp/dp 493a859 target/arm: Update feature checks for insns which are "MVE or FP" 633fa0c target/arm: Add isar feature check functions for MVE === OUTPUT BEGIN === 1/9 Checking commit 633fa0c8de0b (target/arm: Add isar feature check functions for MVE) 2/9 Checking commit 493a859c1d72 (target/arm: Update feature checks for insns which are "MVE or FP") 3/9 Checking commit dbefafdfeff3 (target/arm: Move fpsp/fpdp isar check into callers of do_vfp_2op_sp/dp) 4/9 Checking commit 4b36a72b4fd7 (target/arm: Add MVE check to VMOV_reg_sp and VMOV_reg_dp) ERROR: spaces required around that '*' (ctx:WxV) #28: FILE: target/arm/translate-vfp.c:2823: + arg_##INSN##_##PREC *a) \ ^ total: 1 errors, 0 warnings, 21 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 47dbed22cf5a (target/arm: Fix return values in fp_sysreg_checks()) 6/9 Checking commit 6c7229aab445 (target/arm: Implement M-profile VPR register) 7/9 Checking commit d47da78456e0 (target/arm: Make FPSCR.LTPSIZE writable for MVE) 8/9 Checking commit 0a91c4deb285 (target/arm: Enable FPSCR.QC bit for MVE) 9/9 Checking commit 5714b29a3b6e (target/arm: Allow board models to specify initial NS VTOR) WARNING: line over 80 characters #55: FILE: include/hw/arm/armv7m.h:49: + * + Property "init-nsvtor": non-secure VTOR reset value (forwarded to CPU object) total: 0 errors, 1 warnings, 63 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210520152840.24453-1-peter.mayd...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [RFC PATCH 0/7] Support protection keys in an AMD EPYC-Milan VM
Patchew URL: https://patchew.org/QEMU/20210520145647.3483809-1-david.edmond...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210520145647.3483809-1-david.edmond...@oracle.com Subject: [RFC PATCH 0/7] Support protection keys in an AMD EPYC-Milan VM === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210520145647.3483809-1-david.edmond...@oracle.com -> patchew/20210520145647.3483809-1-david.edmond...@oracle.com Switched to a new branch 'test' 9761ad4 target/i386: Manipulate only AMD XSAVE state on AMD fcba7d5 target/i386: Adjust AMD XSAVE PKRU area offset in CPUID leaf 0xd 0493da2 target/i386: Introduce AMD X86XSaveArea sub-union e8d400c target/i386: Prepare for per-vendor X86XSaveArea layout 5a78b06 target/i386: Clarify the padding requirements of X86XSaveArea ba3c3af target/i386: Use constants for XSAVE offsets 844afa9 target/i386: Declare constants for XSAVE offsets === OUTPUT BEGIN === 1/7 Checking commit 844afa9929e3 (target/i386: Declare constants for XSAVE offsets) WARNING: line over 80 characters #60: FILE: target/i386/cpu.h:1352: +QEMU_BUILD_BUG_ON(offsetof(X86XSaveArea, zmm_hi256_state) != XSAVE_ZMM_HI256_OFFSET); WARNING: line over 80 characters #63: FILE: target/i386/cpu.h:1354: +QEMU_BUILD_BUG_ON(offsetof(X86XSaveArea, hi16_zmm_state) != XSAVE_HI16_ZMM_OFFSET); total: 0 errors, 2 warnings, 48 lines checked Patch 1/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/7 Checking commit ba3c3afe9795 (target/i386: Use constants for XSAVE offsets) 3/7 Checking commit 5a78b069f6d4 (target/i386: Clarify the padding requirements of X86XSaveArea) 4/7 Checking commit e8d400c3e40e (target/i386: Prepare for per-vendor X86XSaveArea layout) 5/7 Checking commit 0493da29bcd9 (target/i386: Introduce AMD X86XSaveArea sub-union) 6/7 Checking commit fcba7d58090d (target/i386: Adjust AMD XSAVE PKRU area offset in CPUID leaf 0xd) 7/7 Checking commit 9761ad41cd68 (target/i386: Manipulate only AMD XSAVE state on AMD) ERROR: spaces required around that '+' (ctx:VxV) #90: FILE: target/i386/xsave_helper.c:53: +stq_p(zmmh+8, env->xmm_regs[i].ZMM_Q(5)); ^ ERROR: spaces required around that '+' (ctx:VxV) #91: FILE: target/i386/xsave_helper.c:54: +stq_p(zmmh+16, env->xmm_regs[i].ZMM_Q(6)); ^ ERROR: spaces required around that '+' (ctx:VxV) #92: FILE: target/i386/xsave_helper.c:55: +stq_p(zmmh+24, env->xmm_regs[i].ZMM_Q(7)); ^ ERROR: spaces required around that '+' (ctx:VxV) #150: FILE: target/i386/xsave_helper.c:114: +env->xmm_regs[i].ZMM_Q(5) = ldq_p(zmmh+8); ^ ERROR: spaces required around that '+' (ctx:VxV) #151: FILE: target/i386/xsave_helper.c:115: +env->xmm_regs[i].ZMM_Q(6) = ldq_p(zmmh+16); ^ ERROR: spaces required around that '+' (ctx:VxV) #152: FILE: target/i386/xsave_helper.c:116: +env->xmm_regs[i].ZMM_Q(7) = ldq_p(zmmh+24); ^ total: 6 errors, 0 warnings, 140 lines checked Patch 7/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210520145647.3483809-1-david.edmond...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/26] Misc patches for 2021-05-20
Patchew URL: https://patchew.org/QEMU/20210520082257.187061-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210520082257.187061-1-pbonz...@redhat.com Subject: [PULL 00/26] Misc patches for 2021-05-20 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210519163448.2154339-1-phi...@redhat.com -> patchew/20210519163448.2154339-1-phi...@redhat.com * [new tag] patchew/20210520082257.187061-1-pbonz...@redhat.com -> patchew/20210520082257.187061-1-pbonz...@redhat.com Switched to a new branch 'test' fd40ea5 scsi-generic: pass max_segments via max_iov field in BlockLimits 37a6979 qemu-config: load modules when instantiating option groups 32b94da vl: allow not specifying size in -m when using -M memory-backend 675997a replication: move include out of root directory 2e3973b remove qemu-options* from root directory 5d724e9 meson: Set implicit_include_directories to false ecc742f tests/qtest/fuzz: Fix build failure 3e04412 KVM: Dirty ring support a954451 KVM: Disable manual dirty log when dirty ring enabled 24a98e2 KVM: Add dirty-ring-size property 589af7b KVM: Cache kvm slot dirty bitmap size 73442ac KVM: Simplify dirty log sync in kvm_set_phys_mem 53278ea KVM: Provide helper to sync dirty bitmap from slot to ramblock ea3b6f9 KVM: Provide helper to get kvm dirty log 51d5550 KVM: Create the KVMSlot dirty bitmap on flag changes c834893 KVM: Use a big lock to replace per-kml slots_lock 1f2cf76 memory: Introduce log_sync_global() to memory listener d92fe4b KVM: do not allow setting properties at runtime 75d0f51 qtest: add a QOM object for qtest 50a63a3 object: add more commands to preconfig mode 5681fd8 meson: bump submodule to 0.57.2 3838574 i386/cpu: Expose AVX_VNNI instruction to guest a531870 hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' 8431b7a configure: simplify assignment to GIT_SUBMODULES f35bc5c configure: check for submodules if --with-git-submodules=ignore dad7063 configure: Only clone softfloat-3 repositories if TCG is enabled === OUTPUT BEGIN === 1/26 Checking commit dad70637e0bc (configure: Only clone softfloat-3 repositories if TCG is enabled) 2/26 Checking commit f35bc5c7fde4 (configure: check for submodules if --with-git-submodules=ignore) 3/26 Checking commit 8431b7a87054 (configure: simplify assignment to GIT_SUBMODULES) 4/26 Checking commit a531870aa3c8 (hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on') 5/26 Checking commit 3838574cd38d (i386/cpu: Expose AVX_VNNI instruction to guest) 6/26 Checking commit 5681fd804f8f (meson: bump submodule to 0.57.2) 7/26 Checking commit 50a63a3492af (object: add more commands to preconfig mode) 8/26 Checking commit 75d0f5167f5b (qtest: add a QOM object for qtest) 9/26 Checking commit d92fe4b72972 (KVM: do not allow setting properties at runtime) ERROR: line over 90 characters #33: FILE: accel/kvm/kvm-all.c:3115: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); ERROR: line over 90 characters #45: FILE: accel/kvm/kvm-all.c:3134: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 2 errors, 0 warnings, 37 lines checked Patch 9/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/26 Checking commit 1f2cf76b0ea0 (memory: Introduce log_sync_global() to memory listener) 11/26 Checking commit c8348939ca12 (KVM: Use a big lock to replace per-kml slots_lock) 12/26 Checking commit 51d55505d416 (KVM: Create the KVMSlot dirty bitmap on flag changes) 13/26 Checking commit ea3b6f9db553 (KVM: Provide helper to get kvm dirty log) 14/26 Checking commit 53278ea4368f (KVM: Provide helper to sync dirty bitmap from slot to ramblock) 15/26 Checking commit 73442acd2e96 (KVM: Simplify dirty log sync in kvm_set_phys_mem) 16/26 Checking commit 589af7b254d2 (KVM: Cache kvm slot dirty bitmap size) 17/26 Checking commit 24a98e28b284 (KVM: Add dirty-ring-size property) ERROR: line over 90 characters #59: FILE: accel/kvm/kvm-all.c:3206: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 1 errors, 0 warnings, 94 lines checked Patch 17/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/26 Checking commit a954451955ef (KVM: Disable manual dirty log when dirty ring enabled) 19/26 Checking commit 3e04412f7670 (KVM: Dirty ring support) WARNING: line over 80 characters #451:
Re: [PATCH v8 00/19] hvf: Implement Apple Silicon Support
Patchew URL: https://patchew.org/QEMU/20210519202253.76782-1-ag...@csgraf.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210519202253.76782-1-ag...@csgraf.de
Subject: [PATCH v8 00/19] hvf: Implement Apple Silicon Support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210519165002.1195745-1-tit...@google.com ->
patchew/20210519165002.1195745-1-tit...@google.com
* [new tag] patchew/20210519202253.76782-1-ag...@csgraf.de ->
patchew/20210519202253.76782-1-ag...@csgraf.de
Switched to a new branch 'test'
a91491a hvf: arm: Handle Windows 10 SMC call
3dc7553 arm: Enable Windows 10 trusted SMCCC boot call
65e8115 arm: Add Hypervisor.framework build target
1cfa1d0 hvf: arm: Implement PSCI handling
63e0f6f hvf: arm: Implement -cpu host
3cf833e arm/hvf: Add a WFI handler
ca30893 hvf: Add Apple Silicon support
8a591bd hvf: Simplify post reset/init/loadvm hooks
0cd15e4 hvf: Introduce hvf vcpu struct
086f42d hvf: Remove hvf-accel-ops.h
63ca75b hvf: Make synchronize functions static
6a10390 hvf: Use cpu_synchronize_state()
b06558a hvf: Split out common code on vcpu init and destroy
de8ace6 hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t
f4b7940 hvf: Make hvf_set_phys_mem() static
83983fc hvf: Move hvf internal definitions into common header
e011dbb hvf: Move cpu functions into common directory
ac7d522 hvf: Move vcpu thread functions into common directory
72aa7ae hvf: Move assert_hvf_ok() into common directory
=== OUTPUT BEGIN ===
1/19 Checking commit 72aa7aeb05e7 (hvf: Move assert_hvf_ok() into common
directory)
2/19 Checking commit ac7d522e0cae (hvf: Move vcpu thread functions into common
directory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
{target/i386 => accel}/hvf/hvf-accel-ops.c | 0
total: 0 errors, 1 warnings, 21 lines checked
Patch 2/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/19 Checking commit e011dbb4cc58 (hvf: Move cpu functions into common
directory)
4/19 Checking commit 83983fc96e4f (hvf: Move hvf internal definitions into
common header)
5/19 Checking commit f4b79405bcc5 (hvf: Make hvf_set_phys_mem() static)
6/19 Checking commit de8ace6033f1 (hvf: Remove use of hv_uvaddr_t and
hv_gpaddr_t)
7/19 Checking commit b06558a826a4 (hvf: Split out common code on vcpu init and
destroy)
8/19 Checking commit 6a103903f401 (hvf: Use cpu_synchronize_state())
9/19 Checking commit 63ca75b7c904 (hvf: Make synchronize functions static)
10/19 Checking commit 086f42de24b5 (hvf: Remove hvf-accel-ops.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
deleted file mode 100644
total: 0 errors, 1 warnings, 23 lines checked
Patch 10/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/19 Checking commit 0cd15e48075a (hvf: Introduce hvf vcpu struct)
WARNING: line over 80 characters
#154: FILE: target/i386/hvf/hvf.c:263:
+wvmcs(cpu->hvf->fd, VMCS_ENTRY_CTLS,
cap2ctrl(hvf_state->hvf_caps->vmx_cap_entry,
ERROR: "(foo*)" should be "(foo *)"
#767: FILE: target/i386/hvf/x86hvf.c:83:
+if (hv_vcpu_write_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) {
ERROR: "(foo*)" should be "(foo *)"
#848: FILE: target/i386/hvf/x86hvf.c:165:
+if (hv_vcpu_read_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) {
total: 2 errors, 1 warnings, 1001 lines checked
Patch 11/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/19 Checking commit 8a591bd4b86b (hvf: Simplify post reset/init/loadvm hooks)
13/19 Checking commit ca3089321cb9 (hvf: Add Apple Silicon support)
WARNING: architecture specific defines should be avoided
#56: FILE: accel/hvf/hvf-accel-ops.c:63:
+#ifdef __aarch64__
WARNING: architecture specific defines should be avoided
#67: FILE: accel/hvf/hvf-accel-ops.c:382:
+#ifdef __aarch64__
WARNING: architecture specific defines should be avoided
#101: FILE: include/sysemu/hvf_int.h:14:
+#ifdef __aarch64__
total: 0 errors, 3 warnings, 796 lines checked
Patch 13/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/19 Checking commit 3cf833ede182 (arm/hvf: Add a WFI handler)
15/19 Checking commit 63e0f6fb8c65 (hvf: arm: Implement -cpu host)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#179:
new file mode 100644
Re: [PULL 00/50] target/i386 translate cleanups
Patchew URL:
https://patchew.org/QEMU/20210519183050.875453-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210519183050.875453-1-richard.hender...@linaro.org
Subject: [PULL 00/50] target/i386 translate cleanups
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20210519183050.875453-1-richard.hender...@linaro.org ->
patchew/20210519183050.875453-1-richard.hender...@linaro.org
Switched to a new branch 'test'
abf6334 target/i386: Remove user-only i/o stubs
9045c95 target/i386: Move helper_check_io to sysemu
578c29d target/i386: Create helper_check_io
ed19bea target/i386: Pass in port to gen_check_io
3a9e000 target/i386: Tidy gen_check_io
f36dd73 target/i386: Exit tb after wrmsr
626dfc0 target/i386: Eliminate user stubs for read/write_crN, rd/wrmsr
ae6c1c9 target/i386: Inline user cpu_svm_check_intercept_param
ca65732 target/i386: Unify invlpg, invlpga
e2afd3e target/i386: Move invlpg, hlt, monitor, mwait to sysemu
c4e49d3 target/i386: Pass env to do_pause and do_hlt
8f74495 target/i386: Cleanup read_crN, write_crN, lmsw
c8c44f0 target/i386: Remove user stub for cpu_vmexit
11953a3 target/i386: Remove pc_start argument to gen_svm_check_intercept
bbc7a14 target/i386: Tidy svm_check_intercept from tcg
af21629 target/i386: Simplify gen_debug usage
160f12f target/i386: Mark some helpers as noreturn
f7bab6d target/i386: Eliminate SVM helpers for user-only
d39bd9a target/i386: Implement skinit in translate.c
1745634 target/i386: Assert !GUEST for user-only
c03c32a target/i386: Assert !SVME for user-only
95a1f38 target/i386: Add stub generator for helper_set_dr
8b1e45d target/i386: Reorder DisasContext members
1c9f72d target/i386: Fix the comment for repz_opt
abbf72b target/i386: Reduce DisasContext jmp_opt, repz_opt to bool
1910135 target/i386: Leave TF in DisasContext.flags
1065bb3 target/i386: Reduce DisasContext popl_esp_hack and rip_offset to uint8_t
87dca6f target/i386: Reduce DisasContext.vex_[lv] to uint8_t
5493abc target/i386: Reduce DisasContext.prefix to uint8_t
55de5ed target/i386: Reduce DisasContext.override to int8_t
4bbf71d target/i386: Reduce DisasContext.flags to uint32_t
4ef214d target/i386: Remove DisasContext.f_st as unused
f5601c2 target/i386: Move rex_w into DisasContext
36c8ee7 target/i386: Move rex_r into DisasContext
7ae1ad1 target/i386: Tidy REX_B, REX_X definition
a4685a0 target/i386: Introduce REX_PREFIX
0c41c1a target/i386: Assert !ADDSEG for x86_64 user-only
3a881f9 target/i386: Assert LMA for x86_64 user-only
e3c8501 target/i386: Assert CODE64 for x86_64 user-only
26aade5 target/i386: Assert SS32 for x86_64 user-only
eab31ff target/i386: Assert CODE32 for x86_64 user-only
b0830d2 target/i386: Assert !VM86 for x86_64 user-only
80074f9 target/i386: Assert IOPL is 0 for user-only
b947f60 target/i386: Assert CPL is 3 for user-only
ed63707 target/i386: Assert PE is set for user-only
11ab4fe target/i386: Split out check_iopl
64fee2f target/i386: Split out check_vm86_iopl
cdf45b3 target/i386: Unify code paths for IRET
5214245 target/i386: Split out check_cpl0
73ea276 target/i386: Split out gen_exception_gpf
=== OUTPUT BEGIN ===
1/50 Checking commit 73ea27618b04 (target/i386: Split out gen_exception_gpf)
2/50 Checking commit 521424569b57 (target/i386: Split out check_cpl0)
3/50 Checking commit cdf45b3a47d4 (target/i386: Unify code paths for IRET)
4/50 Checking commit 64fee2f669f4 (target/i386: Split out check_vm86_iopl)
5/50 Checking commit 11ab4fe1f9d7 (target/i386: Split out check_iopl)
6/50 Checking commit ed63707b4a2a (target/i386: Assert PE is set for user-only)
ERROR: braces {} are necessary for all arms of this statement
#130: FILE: target/i386/tcg/translate.c:7310:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#148: FILE: target/i386/tcg/translate.c:7329:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#166: FILE: target/i386/tcg/translate.c:7349:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#238: FILE: target/i386/tcg/translate.c:7720:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#247: FILE: target/i386/tcg/translate.c:7768:
+if (!PE(s) || s->vm86)
[...]
total: 5 errors, 0 warnings, 244 lines checked
Patch 6/50 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/50 Checking commit b947f600e4de
Re: [PATCH] qemu-binfmt-conf.sh: fix -F option
Patchew URL: https://patchew.org/QEMU/20210519152541.30625-1-mwi...@suse.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210519152541.30625-1-mwi...@suse.com Subject: [PATCH] qemu-binfmt-conf.sh: fix -F option === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210519152541.30625-1-mwi...@suse.com -> patchew/20210519152541.30625-1-mwi...@suse.com Switched to a new branch 'test' d41a07b qemu-binfmt-conf.sh: fix -F option === OUTPUT BEGIN === ERROR: line over 90 characters #25: FILE: scripts/qemu-binfmt-conf.sh:343: +options=$(getopt -o ds:Q:S:e:hc:p:g:F: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,preserve-argv0: -- "$@") total: 1 errors, 0 warnings, 8 lines checked Commit d41a07b4a4df (qemu-binfmt-conf.sh: fix -F option) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210519152541.30625-1-mwi...@suse.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 0/3] vl: add -object support back into -readconfig
Patchew URL: https://patchew.org/QEMU/20210518154014.2999326-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210518154014.2999326-1-pbonz...@redhat.com Subject: [PATCH 0/3] vl: add -object support back into -readconfig === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210518154014.2999326-1-pbonz...@redhat.com -> patchew/20210518154014.2999326-1-pbonz...@redhat.com - [tag update] patchew/20210519104433.16870-1-jcmvb...@gmail.com -> patchew/20210519104433.16870-1-jcmvb...@gmail.com - [tag update] patchew/20210519113528.12474-1-davoronets...@gmail.com -> patchew/20210519113528.12474-1-davoronets...@gmail.com Switched to a new branch 'test' 0124ce7 vl: plug -object back into -readconfig e0cb857 vl: plumb keyval-based options into -readconfig 2b01956 qemu-config: parse configuration files to a QDict === OUTPUT BEGIN === 1/3 Checking commit 2b0195631f20 (qemu-config: parse configuration files to a QDict) WARNING: line over 80 characters #35: FILE: include/qemu/config-file.h:4: +typedef void QEMUConfigCB(const char *group, QDict *qdict, void *opaque, Error **errp); WARNING: line over 80 characters #46: FILE: include/qemu/config-file.h:20: +void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error **errp); WARNING: line over 80 characters #70: FILE: softmmu/vl.c:3389: +qemu_read_config_file(optarg, qemu_config_do_parse, _fatal); WARNING: line over 80 characters #178: FILE: util/qemu-config.c:428: +void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error **errp) WARNING: line over 80 characters #200: FILE: util/qemu-config.c:450: +int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname, Error **errp) total: 0 errors, 5 warnings, 171 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit e0cb8571d7a2 (vl: plumb keyval-based options into -readconfig) ERROR: line over 90 characters #73: FILE: softmmu/vl.c:2127: +static void qemu_record_config_group(const char *group, QDict *dict, bool from_json, Error **errp) WARNING: line over 80 characters #97: FILE: softmmu/vl.c:2151: +error_setg(errp, "Lists cannot be at top level of a configuration section"); WARNING: line over 80 characters #182: FILE: softmmu/vl.c:3423: +qemu_read_config_file(optarg, qemu_parse_config_group, _fatal); total: 1 errors, 2 warnings, 143 lines checked Patch 2/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/3 Checking commit 0124ce72a634 (vl: plug -object back into -readconfig) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210518154014.2999326-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] doc: Add notes about -mon option mode=control argument.
Patchew URL: https://patchew.org/QEMU/0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alis...@routerhosting.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alis...@routerhosting.com Subject: [PATCH] doc: Add notes about -mon option mode=control argument. === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 7733e41 doc: Add notes about -mon option mode=control argument. === OUTPUT BEGIN === ERROR: Author email address is mangled by the mailing list #2: Author: Ali Shirvani via ERROR: trailing whitespace #25: FILE: qemu-options.hx:3790: +Setup monitor on chardev name. ``mode=control`` configures $ ERROR: trailing whitespace #28: FILE: qemu-options.hx:3793: +``pretty`` is only valid when ``mode=control``, $ total: 3 errors, 0 warnings, 13 lines checked Commit 7733e412ab28 (doc: Add notes about -mon option mode=control argument.) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alis...@routerhosting.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 00/48] ppc-for-6.1 queue 20210519
Patchew URL:
https://patchew.org/QEMU/20210519125148.27720-1-da...@gibson.dropbear.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210519125148.27720-1-da...@gibson.dropbear.id.au
Subject: [PULL 00/48] ppc-for-6.1 queue 20210519
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alis...@routerhosting.com
->
patchew/0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alis...@routerhosting.com
- [tag update] patchew/20210519053940.1888907-1-kra...@redhat.com ->
patchew/20210519053940.1888907-1-kra...@redhat.com
- [tag update] patchew/20210519113840.298174-1-th...@redhat.com ->
patchew/20210519113840.298174-1-th...@redhat.com
* [new tag] patchew/20210519125148.27720-1-da...@gibson.dropbear.id.au
-> patchew/20210519125148.27720-1-da...@gibson.dropbear.id.au
Switched to a new branch 'test'
3c00fdf target/ppc: Remove type argument for mmubooke206_get_physical_address
60016bb target/ppc: Remove type argument from mmubooke206_check_tlb
7c11f08 target/ppc: Remove type argument from mmubooke_get_physical_address
5b6598c target/ppc: Remove type argument from mmubooke_check_tlb
a5d9124 target/ppc: Remove type argument from mmu40x_get_physical_address
6303499 target/ppc: Remove type argument from get_bat_6xx_tlb
1909f07 target/ppc: Remove type argument from ppc6xx_tlb_check
9c7354d target/ppc: Remove type argument from ppc6xx_tlb_pte_check
6554abd target/ppc: Remove type argument from check_prot
67377cb target/ppc: Use MMUAccessType in mmu_helper.c
38dbc23 target/ppc: Rename access_type to type in mmu_helper.c
8455e55 target/ppc: Use MMUAccessType in mmu-hash32.c
5d0dd44 target/ppc: Use MMUAccessType in mmu-hash64.c
30623d8 target/ppc: Use MMUAccessType in mmu-radix64.c
6f28cd1 target/ppc: Introduce prot_for_access_type
68af5d8 target/ppc: Fix load endianness for lxvwsx/lxvdsx
8cd5c2d target/ppc: Use translator_loop_temp_check
7dec420 target/ppc: Mark helper_raise_exception* as noreturn
23e15df target/ppc: Tidy exception vs exit_tb
4793076 target/ppc: Move single-step check to ppc_tr_tb_stop
22f5784 target/ppc: Remove DisasContext.exception
95de7c0 target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN
f23b326 target/ppc: Replace POWERPC_EXCP_STOP with DISAS_EXIT_UPDATE
1fc4915 target/ppc: Introduce gen_icount_io_start
0e86c00 target/ppc: Remove unnecessary gen_io_end calls
b2ca732 target/ppc: Replace POWERPC_EXCP_SYNC with DISAS_EXIT
70875f5 target/ppc: Introduce DISAS_{EXIT,CHAIN}{,_UPDATE}
4915e7b target/ppc: Simplify gen_debug_exception
a398d05 target/ppc: Remove special case for POWERPC_EXCP_TRAP
f986c3a target/ppc: Remove special case for POWERPC_SYSCALL
4a93c7b target/ppc: Move DISAS_NORETURN setting into gen_exception*
c9f2edc target/ppc: Split out decode_legacy
e224276 target/ppc: Add cia field to DisasContext
5253f5d target/ppc: moved ppc_cpu_dump_state to cpu_init.c
121b6dd target/ppc: moved ppc_store_sdr1 to cpu.c
b091081 target/ppc: updated vscr manipulation in machine.c
6fea522 target/ppc: created ppc_{store, get}_vscr for generic vscr usage
98d7adb target/ppc: isolated cpu init from translation logic
b69a5c9 target/ppc: turned SPR R/W callbacks not static
a57c158 hw/ppc: moved has_spr to cpu.h
2648581 target/ppc: moved ppc_store_lpcr to misc_helper.c
c9e6564 target/ppc: moved function out of mmu-hash64
94817f2 hw/ppc: moved hcalls that depend on softmmu
fb0f4cf target/ppc: move SPR R/W callbacks to translate.c
386aa35 target/ppc: renamed SPR registration functions
b0e64f0 target/ppc: Fold gen_*_xer into their callers
508bb8b hw/ppc/spapr.c: Make sure the host supports the selected MMU mode
2cddc9b hw/ppc/spapr.c: Extract MMU mode error reporting into a function
=== OUTPUT BEGIN ===
1/48 Checking commit 2cddc9bc2c66 (hw/ppc/spapr.c: Extract MMU mode error
reporting into a function)
2/48 Checking commit 508bb8b7cc99 (hw/ppc/spapr.c: Make sure the host supports
the selected MMU mode)
3/48 Checking commit b0e64f06d98a (target/ppc: Fold gen_*_xer into their
callers)
4/48 Checking commit 386aa355b0f6 (target/ppc: renamed SPR registration
functions)
5/48 Checking commit fb0f4cf4a3b8 (target/ppc: move SPR R/W callbacks to
translate.c)
ERROR: if this code is redundant consider removing it
#35: FILE: target/ppc/translate.c:377:
+#if 0
total: 1 errors, 0 warnings, 2122 lines checked
Patch 5/48 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/48 Checking commit 94817f265d3b (hw/ppc: moved hcalls that
Re: [PATCH v6 0/9] ui: add vdagent implementation and clipboard support.
Patchew URL: https://patchew.org/QEMU/20210519053940.1888907-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210519053940.1888907-1-kra...@redhat.com Subject: [PATCH v6 0/9] ui: add vdagent implementation and clipboard support. === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210518131542.2941207-1-pbonz...@redhat.com -> patchew/20210518131542.2941207-1-pbonz...@redhat.com * [new tag] patchew/20210519053940.1888907-1-kra...@redhat.com -> patchew/20210519053940.1888907-1-kra...@redhat.com Switched to a new branch 'test' f38e1b9 ui/gtk: add clipboard support b5112a9 ui/gtk: move struct GtkDisplayState to ui/gtk.h 8feb571 ui/vnc: clipboard support 97c5587 ui/vdagent: add clipboard support 76b41e6 ui/vdagent: add mouse support 64a57ad ui/vdagent: core infrastructure 5b03384 ui: add clipboard documentation a482369 ui: add clipboard infrastructure fa3c141 build: add separate spice-protocol config option === OUTPUT BEGIN === 1/9 Checking commit fa3c14163bf1 (build: add separate spice-protocol config option) 2/9 Checking commit a48236937e4a (ui: add clipboard infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 total: 0 errors, 1 warnings, 161 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit 5b03384c273a (ui: add clipboard documentation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 WARNING: line over 80 characters #90: FILE: include/ui/clipboard.h:43: + * @QEMU_CLIPBOARD_SELECTION_PRIMARY: primary selection (select + middle mouse button). total: 0 errors, 2 warnings, 194 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 64a57ad8e2a2 (ui/vdagent: core infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #102: new file mode 100644 ERROR: if this code is redundant consider removing it #160: FILE: ui/vdagent.c:54: +#if 0 WARNING: line over 80 characters #162: FILE: ui/vdagent.c:56: +[VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] = "clipboard-no-release-on-regrab", ERROR: if this code is redundant consider removing it #183: FILE: ui/vdagent.c:77: +#if 0 WARNING: line over 80 characters #244: FILE: ui/vdagent.c:138: + sizeof(VDAgentAnnounceCapabilities) + total: 2 errors, 3 warnings, 412 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 76b41e6999f0 (ui/vdagent: add mouse support) 6/9 Checking commit 97c5587b9065 (ui/vdagent: add clipboard support) ERROR: if this code is redundant consider removing it #121: FILE: ui/vdagent.c:120: +#if 0 WARNING: line over 80 characters #441: FILE: ui/vdagent.c:759: +cfg->clipboard = qemu_opt_get_bool(opts, "clipboard", VDAGENT_CLIPBOARD_DEFAULT); total: 1 errors, 1 warnings, 394 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 8feb57182d5c (ui/vnc: clipboard support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: line over 80 characters #281: FILE: ui/vnc-clipboard.c:243: +void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data) WARNING: line over 80 characters #290: FILE: ui/vnc-clipboard.c:252: +qemu_clipboard_info_new(>cbpeer, QEMU_CLIPBOARD_SELECTION_CLIPBOARD); WARNING: line over 80 characters #334: FILE: ui/vnc-clipboard.c:296: +qemu_clipboard_info_new(>cbpeer, QEMU_CLIPBOARD_SELECTION_CLIPBOARD); WARNING: line over 80 characters #501: FILE: ui/vnc.h:643: +void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data); total: 0 errors, 5 warnings, 451 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit b5112a9b2973 (ui/gtk: move struct GtkDisplayState to ui/gtk.h) 9/9 Checking commit f38e1b93466f (ui/gtk: add clipboard support) WARNING: added, moved or deleted file(s), does MAINTAINERS need
Re: [PATCH v5 00/13] virtio-gpu: Add support for Blob resources feature (v5)
Patchew URL: https://patchew.org/QEMU/20210519001414.786439-1-vivek.kasire...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210519001414.786439-1-vivek.kasire...@intel.com Subject: [PATCH v5 00/13] virtio-gpu: Add support for Blob resources feature (v5) === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210519001414.786439-1-vivek.kasire...@intel.com -> patchew/20210519001414.786439-1-vivek.kasire...@intel.com Switched to a new branch 'test' 128a9d2 virtio-gpu: Update cursor data using blob 05f9981 virtio-gpu: Add virtio_gpu_set_scanout_blob e3c9314 virtio-gpu: Factor out update scanout dbc67f1 virtio-gpu: Add helpers to create and destroy dmabuf objects 9570991 ui/pixman: Add qemu_pixman_to_drm_format() 45da29f virtio-gpu: Add virtio_gpu_resource_create_blob 2f7f18a virtio-gpu: Add initial definitions for blob resources 7e99cae virtio-gpu: Refactor virtio_gpu_create_mapping_iov 321ce3a virtio-gpu: Refactor virtio_gpu_set_scanout 442ec4a virtio-gpu: Add virtio_gpu_find_check_resource 0d66622 virtio-gpu: Add udmabuf helpers ae69eca headers: Add udmabuf.h 4d7d9e1 ui: Get the fd associated with udmabuf driver === OUTPUT BEGIN === 1/13 Checking commit 4d7d9e1eb3e4 (ui: Get the fd associated with udmabuf driver) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #45: new file mode 100644 total: 0 errors, 1 warnings, 54 lines checked Patch 1/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/13 Checking commit ae69eca3ab23 (headers: Add udmabuf.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 53 lines checked Patch 2/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/13 Checking commit 0d66622c5482 (virtio-gpu: Add udmabuf helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 total: 0 errors, 1 warnings, 212 lines checked Patch 3/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/13 Checking commit 442ec4a6a78d (virtio-gpu: Add virtio_gpu_find_check_resource) 5/13 Checking commit 321ce3a6fd5a (virtio-gpu: Refactor virtio_gpu_set_scanout) 6/13 Checking commit 7e99cae8610f (virtio-gpu: Refactor virtio_gpu_create_mapping_iov) 7/13 Checking commit 2f7f18ac97ad (virtio-gpu: Add initial definitions for blob resources) 8/13 Checking commit 45da29ff2830 (virtio-gpu: Add virtio_gpu_resource_create_blob) 9/13 Checking commit 957099133aa4 (ui/pixman: Add qemu_pixman_to_drm_format()) 10/13 Checking commit dbc67f12bb53 (virtio-gpu: Add helpers to create and destroy dmabuf objects) ERROR: code indent should never use tabs #80: FILE: hw/display/virtio-gpu-udmabuf.c:216: +^I^I^Inew_primary->buf.width,$ total: 1 errors, 0 warnings, 117 lines checked Patch 10/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/13 Checking commit e3c9314bc71a (virtio-gpu: Factor out update scanout) 12/13 Checking commit 05f9981acd94 (virtio-gpu: Add virtio_gpu_set_scanout_blob) 13/13 Checking commit 128a9d200bdc (virtio-gpu: Update cursor data using blob) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210519001414.786439-1-vivek.kasire...@intel.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers
Patchew URL: https://patchew.org/QEMU/20210518183655.1711377-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210518183655.1711377-1-phi...@redhat.com Subject: [RFC PATCH 00/25] exec: Add load/store API for aligned pointers === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210518183655.1711377-1-phi...@redhat.com -> patchew/20210518183655.1711377-1-phi...@redhat.com Switched to a new branch 'test' b51497a hw/virtio: Optimize accesses on vring aligned pointers f7d21cb hw/virtio: Add methods for aligned pointer access 3ad61c3 hw/virtio: Use LDST_CONVERT macro to emit 64-bit load/store functions c03a99d hw/virtio: Use LDST_CONVERT macro to emit 32-bit load/store functions 5f7cb6e hw/virtio: Use ST_CONVERT() macro to emit 16-bit load/store functions d95d346 hw/virtio: Introduce VIRTIO_ST_CONVERT() macro fed8880 hw/virtio: Use LD_CONVERT macro to emit 16-bit unsigned load/store code cfffb55 hw/virtio: Introduce VIRTIO_LD_CONVERT() macro 0c89b29 hw/virtio: Use correct type sizes 66d8c15 exec/memory: Add methods for aligned pointer access (physical memory) 9a169b5 exec/memory: Add methods for aligned pointer access (address space) 493016c qemu/bswap: Introduce load/store for aligned pointer 5cfe6c7 qemu/bswap: Use LDST_CONVERT macro to emit 64-bit load/store functions 4256f3f qemu/bswap: Use LDST_CONVERT macro to emit 32-bit load/store functions 5e69992 qemu/bswap: Use LD_CONVERT macro to emit 16-bit unsigned load/store code 0fa8f4d qemu/bswap: Use LD_CONVERT macro to emit 16-bit signed load/store code 2a6c3d1 qemu/bswap: Introduce LD_CONVERT() macro e7b6792 qemu/bswap: Use ST_CONVERT() macro to emit 16-bit load/store functions 0d0c3e4 qemu/bswap: Introduce ST_CONVERT() macro 1ca0493 exec/memory: Use correct type size 3010882 exec/memory_ldst_cached: Use correct type size 0beaa26 exec/memory_ldst_phys: Use correct type sizes 88d6831 exec/memory_ldst: Use correct type sizes 057db27 exec/memory_ldst_phys: Sort declarations 3a92956 exec/memory_ldst_cached: Sort declarations === OUTPUT BEGIN === 1/25 Checking commit 3a9295699cb2 (exec/memory_ldst_cached: Sort declarations) 2/25 Checking commit 057db27b4129 (exec/memory_ldst_phys: Sort declarations) 3/25 Checking commit 88d6831d2688 (exec/memory_ldst: Use correct type sizes) 4/25 Checking commit 0beaa26979fa (exec/memory_ldst_phys: Use correct type sizes) 5/25 Checking commit 3010882b5604 (exec/memory_ldst_cached: Use correct type size) 6/25 Checking commit 1ca0493ecfd1 (exec/memory: Use correct type size) 7/25 Checking commit 0d0c3e4e5c2d (qemu/bswap: Introduce ST_CONVERT() macro) 8/25 Checking commit e7b679286247 (qemu/bswap: Use ST_CONVERT() macro to emit 16-bit load/store functions) 9/25 Checking commit 2a6c3d1c4aad (qemu/bswap: Introduce LD_CONVERT() macro) 10/25 Checking commit 0fa8f4d7d229 (qemu/bswap: Use LD_CONVERT macro to emit 16-bit signed load/store code) 11/25 Checking commit 5e69992e047b (qemu/bswap: Use LD_CONVERT macro to emit 16-bit unsigned load/store code) 12/25 Checking commit 4256f3f7f36a (qemu/bswap: Use LDST_CONVERT macro to emit 32-bit load/store functions) 13/25 Checking commit 5cfe6c7a8fd6 (qemu/bswap: Use LDST_CONVERT macro to emit 64-bit load/store functions) 14/25 Checking commit 493016c0c84e (qemu/bswap: Introduce load/store for aligned pointer) ERROR: space required after that close brace '}' #119: FILE: include/qemu/bswap.h:369: +}\ ERROR: space required after that close brace '}' #129: FILE: include/qemu/bswap.h:379: +}\ total: 2 errors, 0 warnings, 107 lines checked Patch 14/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/25 Checking commit 9a169b58ddf3 (exec/memory: Add methods for aligned pointer access (address space)) 16/25 Checking commit 66d8c1562136 (exec/memory: Add methods for aligned pointer access (physical memory)) 17/25 Checking commit 0c89b296d850 (hw/virtio: Use correct type sizes) 18/25 Checking commit cfffb555f1ca (hw/virtio: Introduce VIRTIO_LD_CONVERT() macro) ERROR: space required after that close brace '}' #31: FILE: include/hw/virtio/virtio-access.h:49: +}\ ERROR: space required after that close brace '}' #33: FILE: include/hw/virtio/virtio-access.h:51: +}\ ERROR: space required after that close brace '}' #41: FILE: include/hw/virtio/virtio-access.h:59: +}\ ERROR: space required after that close brace '}' #42: FILE: include/hw/virtio/virtio-access.h:60: +}\ ERROR: space required after that close brace '}' #49: FILE:
Re: [PATCH] qemu-config: load modules when instantiating option groups
Patchew URL: https://patchew.org/QEMU/20210518131542.2941207-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210518131542.2941207-1-pbonz...@redhat.com Subject: [PATCH] qemu-config: load modules when instantiating option groups === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 8e22b27..15e147b master -> master - [tag update] patchew/20210517064428.16223-1-vsement...@virtuozzo.com -> patchew/20210517064428.16223-1-vsement...@virtuozzo.com * [new tag] patchew/20210518131542.2941207-1-pbonz...@redhat.com -> patchew/20210518131542.2941207-1-pbonz...@redhat.com Switched to a new branch 'test' caeb56b qemu-config: load modules when instantiating option groups === OUTPUT BEGIN === ERROR: do not initialise statics to 0 or NULL #51: FILE: softmmu/vl.c:2620: +static bool spice_tried = false; ERROR: do not initialise statics to 0 or NULL #57: FILE: softmmu/vl.c:2626: +static bool iscsi_tried = false; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #92: new file mode 100644 total: 2 errors, 1 warnings, 61 lines checked Commit caeb56b0e05f (qemu-config: load modules when instantiating option groups) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210518131542.2941207-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL v2 00/29] testing and plugin updates
Patchew URL:
https://patchew.org/QEMU/20210518090720.21915-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210518090720.21915-1-alex.ben...@linaro.org
Subject: [PULL v2 00/29] testing and plugin updates
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update]
patchew/20210514151342.384376-1-richard.hender...@linaro.org ->
patchew/20210514151342.384376-1-richard.hender...@linaro.org
- [tag update] patchew/20210517084055.24792-1-davoronets...@gmail.com ->
patchew/20210517084055.24792-1-davoronets...@gmail.com
- [tag update] patchew/20210517121908.2624991-1-pbonz...@redhat.com ->
patchew/20210517121908.2624991-1-pbonz...@redhat.com
- [tag update] patchew/20210517183954.1223193-1-phi...@redhat.com ->
patchew/20210517183954.1223193-1-phi...@redhat.com
* [new tag] patchew/20210518090720.21915-1-alex.ben...@linaro.org ->
patchew/20210518090720.21915-1-alex.ben...@linaro.org
* [new tag] patchew/20210518092352.43610-1-thatle...@gmail.com ->
patchew/20210518092352.43610-1-thatle...@gmail.com
Switched to a new branch 'test'
53fa360 configure: use cc, not host_cc to set cross_cc for build arch
8d18fbc tests/tcg: don't allow clang as a cross compiler
9ecaa15 tests/tcg: fix missing return
d09604a tests/tcg/ppc64le: tests for brh/brw/brd
86d8dfa tests/docker: gcc-10 based images for ppc64{, le} tests
07c7406 tests/tcg/tricore: Add muls test
b8effdc tests/tcg/tricore: Add msub test
bd850be tests/tcg/tricore: Add madd test
10c3549 tests/tcg/tricore: Add ftoi test
7554856 tests/tcg/tricore: Add fmul test
f7daca6 tests/tcg/tricore: Add fadd test
4531665 tests/tcg/tricore: Add dvstep test
e83079f tests/tcg/tricore: Add clz test
bb6e9e6 tests/tcg/tricore: Add bmerge test
5325639 tests/tcg/tricore: Add macros to create tests and first test 'abs'
b8c8ff4 configure: Emit HOST_CC to config-host.mak
7cc91e7 tests/tcg/tricore: Add build infrastructure
3a44a14 hw/tricore: Add testdevice for tests in tests/tcg/
380656c tests/tcg: Run timeout cmds using --foreground
8e9da44 tests/tcg: Add docker_as and docker_ld cmds
b24d795 tests/docker: Added libbpf library to the docker files.
52f2bd2 tests/tcg: don't iterate through other arch compilers
576f7f1 gitlab: add build-user-hexagon test
375951d tests/tcg: Use Hexagon Docker image
d79c5c5 docker: Add Hexagon image
d8b71a8 tests/docker: add "fetch" sub-command
e09459e tests/docker: allow "update" to add the current user
e8ffae1 tests/docker: make executable an optional argument to "update"
e8f6d5f tests/docker: fix copying of executable in "update"
=== OUTPUT BEGIN ===
1/29 Checking commit e8f6d5fd8833 (tests/docker: fix copying of executable in
"update")
2/29 Checking commit e8ffae13f86d (tests/docker: make executable an optional
argument to "update")
3/29 Checking commit e09459e20f63 (tests/docker: allow "update" to add the
current user)
4/29 Checking commit d8b71a8970c4 (tests/docker: add "fetch" sub-command)
5/29 Checking commit d79c5c54c9cf (docker: Add Hexagon image)
WARNING: line over 80 characters
#208: FILE:
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63:
+-DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic
--target=hexagon-unknown-linux-musl " \
ERROR: line over 90 characters
#235: FILE:
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90:
+CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math
--target=hexagon-unknown-linux-musl" \
ERROR: line over 90 characters
#272: FILE:
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127:
+CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math
--target=hexagon-unknown-linux-musl" \
total: 2 errors, 1 warnings, 222 lines checked
Patch 5/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/29 Checking commit 375951decf4b (tests/tcg: Use Hexagon Docker image)
7/29 Checking commit 576f7f1e2010 (gitlab: add build-user-hexagon test)
8/29 Checking commit 52f2bd253948 (tests/tcg: don't iterate through other arch
compilers)
9/29 Checking commit b24d79558115 (tests/docker: Added libbpf library to the
docker files.)
10/29 Checking commit 8e9da4484f54 (tests/tcg: Add docker_as and docker_ld cmds)
11/29 Checking commit 380656c57796 (tests/tcg: Run timeout cmds using
--foreground)
12/29 Checking commit 3a44a149ecb9 (hw/tricore: Add testdevice for tests in
tests/tcg/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
new file mode 100644
total: 0 errors, 1
Re: [PULL 00/59] Linux user for 6.1 patches
Patchew URL: https://patchew.org/QEMU/20210517181424.8093-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517181424.8093-1-laur...@vivier.eu Subject: [PULL 00/59] Linux user for 6.1 patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 32de74a..367196c master -> master - [tag update] patchew/20210517174947.1199649-1-phi...@redhat.com -> patchew/20210517174947.1199649-1-phi...@redhat.com * [new tag] patchew/20210517181424.8093-1-laur...@vivier.eu -> patchew/20210517181424.8093-1-laur...@vivier.eu Switched to a new branch 'test' 7db920b linux-user/elfload: add s390x core dumping support 5b6f11c linux-user/elfload: fix filling psinfo->pr_psargs 2b8cc26 linux-user: Tidy TARGET_NR_rt_sigaction e1e89de linux-user/alpha: Share code for TARGET_NR_sigaction 9872e82 linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER 49f59b4 linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall e63cb74 linux-user: Pass ka_restorer to do_sigaction ce80cea linux-user/alpha: Rename the sigaction restorer field 59a7fe5 linux-user/alpha: Fix rt sigframe return ede5d61 linux-user: use GDateTime for formatting timestamp for core file d9c71e6 linux-user: Fix erroneous conversion in copy_file_range 00d88c8 linux-user: Add copy_file_range to strace.list b563b62 linux-user/s390x: Handle vector regs in signal stack 75cbffb linux-user/s390x: Clean up signal.c 9c32aac linux-user/s390x: Add build asserts for sigset sizes 0bec884 linux-user/s390x: Fix frame_addr corruption in setup_frame b197ab9 linux-user/s390x: Add stub sigframe argument for last_break bd5b9e8 linux-user/s390x: Set psw.mask properly for the signal handler fe8d7a1 linux-user/s390x: Clean up single-use gotos in signal.c c694fba linux-user/s390x: Tidy save_sigregs 81015fb linux-user/s390x: Use tswap_sigset in setup_rt_frame 2afaee9 linux-user/s390x: Fix sigcontext sregs value c335465 linux-user/s390x: Fix trace in restore_regs e488167 linux-user/s390x: Remove restore_sigregs return value ffa5802 linux-user/s390x: Remove PSW_ADDR_AMODE f835fe4 linux-user/s390x: Use uint16_t for signal retcode 32267a1 linux-user/s390x: Fix sigframe types 2fd8343 tests/tcg/sparc64: Re-enable linux-test 47a7850 linux-user/sparc: Implement sparc64 rt signals eb9b8de linux-user/sparc: Implement sparc32 rt signals 6a02eb6 linux-user/sparc: Add 64-bit support to fpu save/restore 7acfaa8 linux-user/sparc: Minor corrections to do_sigreturn 37c8475 linux-user/sparc: Clean up setup_frame b62d96d linux-user/sparc: Add rwin_save to signal frame b27662c linux-user/sparc: Save and restore fpu in signal frame a4a46f6 linux-user/sparc: Clean up get_sigframe eac9897 linux-user/sparc: Split out save_reg_win c75a3e5 linux-user/sparc: Use target_pt_regs 104931a linux-user/sparc: Fix the stackframe structure b6f9c25 linux-user/sparc: Remove target_rt_signal_frame as unused ed9e640 linux-user/sparc: Remove target_sigcontext as unused fb62578 linux-user/sparc: Merge sparc64/ into sparc/ ee45b6d linux-user/sparc: Merge sparc64 termbits.h 5d9706c linux-user/sparc: Merge sparc64 target_structs.h fbdd320 linux-user/sparc: Merge sparc64 target_elf.h c73cc71 linux-user/sparc: Merge sparc64 target_syscall.h 05a3287 linux-user/sparc: Clean up init_thread d9551e1 linux-user/sparc: Include TARGET_STACK_BIAS in get_sp_from_cpustate be699c8 linux-user: Pass CPUArchState to target_restore_altstack 8ad510f linux-user: Pass CPUArchState to do_sigaltstack 5482bec linux-user: Use target_restore_altstack in all sigreturn ad4e4e2 linux-user: Split out target_restore_altstack 7ab6de0 linux-user: Add strace support for printing arguments of llseek 0ece12d linux-user/arm: Simplify accumulating and raising fpa11 exceptions 5dd2463 linux-user/arm: Do not fill in si_code for fpa11 exceptions fa4ab02 linux-user/arm: Do not emulate fpa11 in thumb mode c61b3a7 linux-user/arm: Split out emulate_arm_fpa11 4e217fb linux-user: strace now handles unshare syscall args correctly cfc582d linux-user: Remove dead code === OUTPUT BEGIN === 1/59 Checking commit cfc582dd467e (linux-user: Remove dead code) 2/59 Checking commit 4e217fb6e89d (linux-user: strace now handles unshare syscall args correctly) 3/59 Checking commit c61b3a7d7c99 (linux-user/arm: Split out emulate_arm_fpa11) 4/59 Checking commit fa4ab02afc4d (linux-user/arm: Do not emulate fpa11 in thumb mode) 5/59 Checking commit 5dd2463d299b (linux-user/arm: Do not fill in si_code for fpa11 exceptions) 6/59 Checking commit 0ece12d2d24a (linux-user/arm: Simplify accumulating and raising fpa11 exceptions) 7/59 Checking commit 7ab6de0b0489 (linux-user: Add
Re: [PULL 00/29] testing and plugin updates
Patchew URL: https://patchew.org/QEMU/20210517161022.13984-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517161022.13984-1-alex.ben...@linaro.org Subject: [PULL 00/29] testing and plugin updates === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 6005ee0..32de74a master -> master - [tag update] patchew/20210512171550.476130-1-th...@redhat.com -> patchew/20210512171550.476130-1-th...@redhat.com - [tag update] patchew/20210517064428.16223-1-vsement...@virtuozzo.com -> patchew/20210517064428.16223-1-vsement...@virtuozzo.com - [tag update] patchew/20210517151702.109066-1-sgarz...@redhat.com -> patchew/20210517151702.109066-1-sgarz...@redhat.com * [new tag] patchew/20210517161022.13984-1-alex.ben...@linaro.org -> patchew/20210517161022.13984-1-alex.ben...@linaro.org Switched to a new branch 'test' 5bbea9e plugins/hotpages: Properly freed the hash table values f6787e3 plugins/hotblocks: Properly freed the hash table values d9de308 plugins: Move all typedef and type declaration to the front of the qemu-plugin.h 25de4e5 plugins: Update qemu-plugins.symbols to match qemu-plugins.h 4620d1d configure: use cc, not host_cc to set cross_cc for build arch 7a853fe tests/tcg: don't allow clang as a cross compiler 74edf7c tests/tcg: fix missing return c58c3f3 tests/tcg/ppc64le: tests for brh/brw/brd fa99f89 tests/tcg/tricore: Add muls test 2dca1b2 tests/tcg/tricore: Add msub test 48ca02e tests/tcg/tricore: Add madd test d72dd15 tests/tcg/tricore: Add ftoi test 11e0994 tests/tcg/tricore: Add fmul test 942377c tests/tcg/tricore: Add fadd test 146eaaf tests/tcg/tricore: Add dvstep test c83ac5e tests/tcg/tricore: Add clz test e906f5e tests/tcg/tricore: Add bmerge test 8b084e7 tests/tcg/tricore: Add macros to create tests and first test 'abs' 5cb7078 configure: Emit HOST_CC to config-host.mak 01dc32f tests/tcg/tricore: Add build infrastructure 0969546 hw/tricore: Add testdevice for tests in tests/tcg/ 320b75d tests/tcg: Run timeout cmds using --foreground 383cdb7 tests/docker: Added libbpf library to the docker files. 1b533b2 tests/tcg: Use Hexagon Docker image 87f4321 docker: Add Hexagon image 674981a tests/docker: add "fetch" sub-command 4b15453 tests/docker: allow "update" to add the current user b08a0a3 tests/docker: make executable an optional argument to "update" 45691a9 tests/docker: fix copying of executable in "update" === OUTPUT BEGIN === 1/29 Checking commit 45691a9f1a3c (tests/docker: fix copying of executable in "update") 2/29 Checking commit b08a0a3952e8 (tests/docker: make executable an optional argument to "update") 3/29 Checking commit 4b154532b5ec (tests/docker: allow "update" to add the current user) 4/29 Checking commit 674981a2a08e (tests/docker: add "fetch" sub-command) 5/29 Checking commit 87f4321d401b (docker: Add Hexagon image) WARNING: line over 80 characters #207: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63: +-DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #234: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90: +CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #271: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127: +CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 1 warnings, 222 lines checked Patch 5/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/29 Checking commit 1b533b2ebadf (tests/tcg: Use Hexagon Docker image) 7/29 Checking commit 383cdb76706a (tests/docker: Added libbpf library to the docker files.) 8/29 Checking commit 320b75d22d97 (tests/tcg: Run timeout cmds using --foreground) 9/29 Checking commit 09695469a9b9 (hw/tricore: Add testdevice for tests in tests/tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 152 lines checked Patch 9/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/29 Checking commit 01dc32ff4753 (tests/tcg/tricore: Add build infrastructure) 11/29 Checking commit 5cb7078ea4eb (configure: Emit HOST_CC to config-host.mak) 12/29 Checking commit 8b084e7f9c2f (tests/tcg/tricore: Add macros to create tests
Re: [PULL 00/20] Misc patches for 2020-05-17
Patchew URL: https://patchew.org/QEMU/20210517112001.2564006-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517112001.2564006-1-pbonz...@redhat.com Subject: [PULL 00/20] Misc patches for 2020-05-17 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210517112001.2564006-1-pbonz...@redhat.com -> patchew/20210517112001.2564006-1-pbonz...@redhat.com Switched to a new branch 'test' 77eb22a KVM: Dirty ring support 520cdc9 KVM: Disable manual dirty log when dirty ring enabled d672dde KVM: Add dirty-ring-size property f325098 KVM: Cache kvm slot dirty bitmap size 568e8ff KVM: Simplify dirty log sync in kvm_set_phys_mem 7d5d872 KVM: Provide helper to sync dirty bitmap from slot to ramblock 7b2937f KVM: Provide helper to get kvm dirty log 8160151 KVM: Create the KVMSlot dirty bitmap on flag changes a013508 KVM: Use a big lock to replace per-kml slots_lock 3549fdf memory: Introduce log_sync_global() to memory listener 415d0d0 KVM: do not allow setting properties at runtime d44087e qtest: add a QOM object for qtest b21d58b object: add more commands to preconfig mode 80d034a2 meson: bump submodule to 0.57.2 91a9f7f i386/cpu: Expose AVX_VNNI instruction to guest 4ed41f8 backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD 525090e hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' 5451f01 configure: simplify assignment to GIT_SUBMODULES fd5bbbe configure: check for submodules if --with-git-submodules=ignore 4a71809 configure: Only clone softfloat-3 repositories if TCG is enabled === OUTPUT BEGIN === 1/20 Checking commit 4a7180969269 (configure: Only clone softfloat-3 repositories if TCG is enabled) ERROR: Doubly-encoded UTF-8 #7: Signed-off-by: Philippe Mathieu-Daudé total: 1 errors, 0 warnings, 19 lines checked Patch 1/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/20 Checking commit fd5bbbe5111e (configure: check for submodules if --with-git-submodules=ignore) 3/20 Checking commit 5451f0196365 (configure: simplify assignment to GIT_SUBMODULES) 4/20 Checking commit 525090e9e978 (hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on') ERROR: Doubly-encoded UTF-8 #16: Signed-off-by: Philippe Mathieu-Daudé total: 1 errors, 0 warnings, 30 lines checked Patch 4/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/20 Checking commit 4ed41f88b595 (backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD) 6/20 Checking commit 91a9f7fa5700 (i386/cpu: Expose AVX_VNNI instruction to guest) 7/20 Checking commit 80d034a230fb (meson: bump submodule to 0.57.2) 8/20 Checking commit b21d58bf2249 (object: add more commands to preconfig mode) 9/20 Checking commit d44087e84505 (qtest: add a QOM object for qtest) 10/20 Checking commit 415d0d0f4894 (KVM: do not allow setting properties at runtime) ERROR: line over 90 characters #33: FILE: accel/kvm/kvm-all.c:3115: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); ERROR: line over 90 characters #45: FILE: accel/kvm/kvm-all.c:3134: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 2 errors, 0 warnings, 37 lines checked Patch 10/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/20 Checking commit 3549fdff41f9 (memory: Introduce log_sync_global() to memory listener) 12/20 Checking commit a01350856d61 (KVM: Use a big lock to replace per-kml slots_lock) 13/20 Checking commit 8160151d18d7 (KVM: Create the KVMSlot dirty bitmap on flag changes) 14/20 Checking commit 7b2937fa36c2 (KVM: Provide helper to get kvm dirty log) 15/20 Checking commit 7d5d87209ba9 (KVM: Provide helper to sync dirty bitmap from slot to ramblock) 16/20 Checking commit 568e8ffbabee (KVM: Simplify dirty log sync in kvm_set_phys_mem) 17/20 Checking commit f32509862618 (KVM: Cache kvm slot dirty bitmap size) 18/20 Checking commit d672dde943f7 (KVM: Add dirty-ring-size property) ERROR: line over 90 characters #59: FILE: accel/kvm/kvm-all.c:3206: +error_setg(errp, "Cannot set properties after the accelerator has been initialized"); total: 1 errors, 0 warnings, 94 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Re: [PATCH] remove qemu-options* from root directory
Patchew URL: https://patchew.org/QEMU/20210517121908.2624991-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517121908.2624991-1-pbonz...@redhat.com Subject: [PATCH] remove qemu-options* from root directory === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210517070851.857841-1-f4...@amsat.org -> patchew/20210517070851.857841-1-f4...@amsat.org * [new tag] patchew/20210517121908.2624991-1-pbonz...@redhat.com -> patchew/20210517121908.2624991-1-pbonz...@redhat.com Switched to a new branch 'test' fa84df5 remove qemu-options* from root directory === OUTPUT BEGIN === WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: rename from qemu-options.h ERROR: Macros with complex values should be enclosed in parenthesis #37: FILE: include/qemu/qemu-options.h:33: +#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask) \ +opt_enum, total: 1 errors, 1 warnings, 79 lines checked Commit fa84df5703e0 (remove qemu-options* from root directory) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210517121908.2624991-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH v7 00/19] hvf: Implement Apple Silicon Support
Patchew URL: https://patchew.org/QEMU/20210516195855.28869-1-ag...@csgraf.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210516195855.28869-1-ag...@csgraf.de
Subject: [PATCH v7 00/19] hvf: Implement Apple Silicon Support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
9b1e81d..6005ee0 master -> master
* [new tag] patchew/20210516195855.28869-1-ag...@csgraf.de ->
patchew/20210516195855.28869-1-ag...@csgraf.de
Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
Switched to a new branch 'test'
51b6048 hvf: arm: Handle Windows 10 SMC call
f23720b arm: Enable Windows 10 trusted SMCCC boot call
06e2184 arm: Add Hypervisor.framework build target
e5c9561 hvf: arm: Implement PSCI handling
d61ad07 hvf: arm: Implement -cpu host
22268ee arm/hvf: Add a WFI handler
d4bfd38 hvf: Add Apple Silicon support
2a57549 hvf: Simplify post reset/init/loadvm hooks
2169cd5 hvf: Introduce hvf vcpu struct
fb67de4 hvf: Remove hvf-accel-ops.h
a6dc95d hvf: Make synchronize functions static
26045be hvf: Use cpu_synchronize_state()
d888737 hvf: Split out common code on vcpu init and destroy
6742b0a hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t
bad87f2 hvf: Make hvf_set_phys_mem() static
37ba42a hvf: Move hvf internal definitions into common header
db1c2eb hvf: Move cpu functions into common directory
5e5ba4e hvf: Move vcpu thread functions into common directory
1501777 hvf: Move assert_hvf_ok() into common directory
=== OUTPUT BEGIN ===
1/19 Checking commit 1501777fce49 (hvf: Move assert_hvf_ok() into common
directory)
2/19 Checking commit 5e5ba4e4171b (hvf: Move vcpu thread functions into common
directory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
{target/i386 => accel}/hvf/hvf-accel-ops.c | 0
total: 0 errors, 1 warnings, 21 lines checked
Patch 2/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/19 Checking commit db1c2ebca7b9 (hvf: Move cpu functions into common
directory)
4/19 Checking commit 37ba42a9217d (hvf: Move hvf internal definitions into
common header)
5/19 Checking commit bad87f2351a2 (hvf: Make hvf_set_phys_mem() static)
6/19 Checking commit 6742b0a0e9a0 (hvf: Remove use of hv_uvaddr_t and
hv_gpaddr_t)
7/19 Checking commit d8887370f041 (hvf: Split out common code on vcpu init and
destroy)
8/19 Checking commit 26045bee3b8a (hvf: Use cpu_synchronize_state())
9/19 Checking commit a6dc95d38d0b (hvf: Make synchronize functions static)
10/19 Checking commit fb67de47006a (hvf: Remove hvf-accel-ops.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
deleted file mode 100644
total: 0 errors, 1 warnings, 23 lines checked
Patch 10/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/19 Checking commit 2169cd5bfabb (hvf: Introduce hvf vcpu struct)
WARNING: line over 80 characters
#154: FILE: target/i386/hvf/hvf.c:263:
+wvmcs(cpu->hvf->fd, VMCS_ENTRY_CTLS,
cap2ctrl(hvf_state->hvf_caps->vmx_cap_entry,
ERROR: "(foo*)" should be "(foo *)"
#767: FILE: target/i386/hvf/x86hvf.c:83:
+if (hv_vcpu_write_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) {
ERROR: "(foo*)" should be "(foo *)"
#848: FILE: target/i386/hvf/x86hvf.c:165:
+if (hv_vcpu_read_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) {
total: 2 errors, 1 warnings, 1001 lines checked
Patch 11/19 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/19 Checking commit 2a575495eee5 (hvf: Simplify post reset/init/loadvm hooks)
13/19 Checking commit d4bfd3851069 (hvf: Add Apple Silicon support)
WARNING: architecture specific defines should be avoided
#56: FILE: accel/hvf/hvf-accel-ops.c:63:
+#ifdef __aarch64__
WARNING: architecture specific defines should be avoided
#67: FILE: accel/hvf/hvf-accel-ops.c:382:
+#ifdef __aarch64__
WARNING: architecture specific defines should be avoided
#101: FILE: include/sysemu/hvf_int.h:14:
+#ifdef __aarch64__
WARNING: line over 80 characters
#475: FILE: target/arm/hvf/hvf.c:331:
+ret = hv_vcpu_set_simd_fp_reg(cpu->hvf->fd, hvf_fpreg_match[i].reg,
fpval);
WARNING: line over 80 characters
#606: FILE: target/arm/hvf/hvf.c:462:
+static void hvf_raise_exception(CPUARMState *env, uint32_t excp, uint32_t
syndrome)
ERROR: superfluous trailing semicolon
#609: FILE: target/arm/hvf/hvf.c:465:
+
Re: [PULL 00/46] softfloat: Convert float128 to FloatParts (part 1)
Patchew URL: https://patchew.org/QEMU/20210516123431.718318-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210516123431.718318-1-richard.hender...@linaro.org Subject: [PULL 00/46] softfloat: Convert float128 to FloatParts (part 1) === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210516123431.718318-1-richard.hender...@linaro.org -> patchew/20210516123431.718318-1-richard.hender...@linaro.org Switched to a new branch 'test' 79b3657 softfloat: Move round_to_int_and_pack to softfloat-parts.c.inc 18be64c softfloat: Move round_to_int to softfloat-parts.c.inc d819a18 softfloat: Convert float-to-float conversions with float128 6af91f7 softfloat: Split float_to_float 1f5260c softfloat: Move div_floats to softfloat-parts.c.inc f4eca57 softfloat: Introduce sh[lr]_double primitives 4d88a4d softfloat: Tidy mul128By64To192 885f3ae softfloat: Use add192 in mul128To256 5d10ba5 softfloat: Use mulu64 for mul64To128 c66 softfloat: Move muladd_floats to softfloat-parts.c.inc 13c5b80 softfloat: Move mul_floats to softfloat-parts.c.inc 5bc8e89 softfloat: Implement float128_add/sub via parts 5ab3959 softfloat: Move addsub_floats to softfloat-parts.c.inc 460d30c softfloat: Use uadd64_carry, usub64_borrow in softfloat-macros.h 99f3265 softfloat: Move round_canonical to softfloat-parts.c.inc c0d23dc softfloat: Move sf_canonicalize to softfloat-parts.c.inc 21a70b0 softfloat: Move pick_nan_muladd to softfloat-parts.c.inc 2f42141 softfloat: Move pick_nan to softfloat-parts.c.inc fc6b980 softfloat: Move return_nan to softfloat-parts.c.inc 7ae2da4 softfloat: Convert float128_default_nan to parts 930550f softfloat: Convert float128_silence_nan to parts d5c84b6 softfloat: Rearrange FloatParts64 166bea0 softfloat: Use pointers with parts_silence_nan 70472ce softfloat: Use pointers with ftype_round_pack_canonical fa88f30 softfloat: Use pointers with ftype_unpack_canonical b3f4218 softfloat: Use pointers with ftype_pack_raw 6efd675 softfloat: Use pointers with pack_raw f550064 softfloat: Use pointers with ftype_unpack_raw c91d07c softfloat: Use pointers with unpack_raw abeae2e softfloat: Use pointers with parts_default_nan 1ebb32c softfloat: Move type-specific pack/unpack routines 5988d22 softfloat: Rename FloatParts to FloatParts64 4929b37 softfloat: Do not produce a default_nan from parts_silence_nan 1cc195f target/mips: Set set_default_nan_mode with set_snan_bit_is_one 5c7f249 softfloat: fix return_nan vs default_nan_mode ecf52bd softfloat: Use return_nan in float_to_float db50e0a softfloat: Add float_cmask and constants c8a1ed9 softfloat: Tidy a * b + inf return 4e15ceb softfloat: Use float_raise in more places 4c3af8c softfloat: Inline float_raise 0c1fefd softfloat: Move the binary point to the msb b48d53f tests/fp: add quad support to the benchmark utility 6dcc2d6 accel/tcg: Use add/sub overflow routines in tcg-runtime-gvec.c e22fa0d qemu/host-utils: Add wrappers for carry builtins f7e908a qemu/host-utils: Add wrappers for overflow builtins e2a38a2 qemu/host-utils: Use __builtin_bitreverseN === OUTPUT BEGIN === 1/46 Checking commit e2a38a2b2f12 (qemu/host-utils: Use __builtin_bitreverseN) WARNING: architecture specific defines should be avoided #26: FILE: include/qemu/host-utils.h:275: +#if __has_builtin(__builtin_bitreverse8) WARNING: architecture specific defines should be avoided #44: FILE: include/qemu/host-utils.h:296: +#if __has_builtin(__builtin_bitreverse16) WARNING: architecture specific defines should be avoided #62: FILE: include/qemu/host-utils.h:319: +#if __has_builtin(__builtin_bitreverse32) WARNING: architecture specific defines should be avoided #80: FILE: include/qemu/host-utils.h:342: +#if __has_builtin(__builtin_bitreverse64) total: 0 errors, 4 warnings, 64 lines checked Patch 1/46 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/46 Checking commit f7e908a5a70f (qemu/host-utils: Add wrappers for overflow builtins) WARNING: architecture specific defines should be avoided #35: FILE: include/qemu/host-utils.h:369: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #53: FILE: include/qemu/host-utils.h:387: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #71: FILE: include/qemu/host-utils.h:405: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #89: FILE:
Re: [PATCH v2 00/50] target/i386 translate cleanups
Patchew URL:
https://patchew.org/QEMU/20210514151342.384376-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210514151342.384376-1-richard.hender...@linaro.org
Subject: [PATCH v2 00/50] target/i386 translate cleanups
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
2d3fc4e..9666299 master -> master
- [tag update] patchew/20210325153529.75831-1-and...@daynix.com ->
patchew/20210325153529.75831-1-and...@daynix.com
- [tag update] patchew/20210512040250.203953-1-...@linux.ibm.com ->
patchew/20210512040250.203953-1-...@linux.ibm.com
- [tag update] patchew/20210512214642.2803189-1-js...@redhat.com ->
patchew/20210512214642.2803189-1-js...@redhat.com
* [new tag]
patchew/20210514151342.384376-1-richard.hender...@linaro.org ->
patchew/20210514151342.384376-1-richard.hender...@linaro.org
Switched to a new branch 'test'
e202c8c target/i386: Remove user-only i/o stubs
1d820c0 target/i386: Move helper_check_io to sysemu
50e4fb4 target/i386: Create helper_check_io
6814811 target/i386: Pass in port to gen_check_io
8f6e5bb target/i386: Tidy gen_check_io
4282091 target/i386: Exit tb after wrmsr
941 target/i386: Eliminate user stubs for read/write_crN, rd/wrmsr
0010e63 target/i386: Inline user cpu_svm_check_intercept_param
946b94c target/i386: Unify invlpg, invlpga
46e15b6 target/i386: Move invlpg, hlt, monitor, mwait to sysemu
fc622c8 target/i386: Pass env to do_pause and do_hlt
eff322a target/i386: Cleanup read_crN, write_crN, lmsw
f975359 target/i386: Remove user stub for cpu_vmexit
01ec488 target/i386: Remove pc_start argument to gen_svm_check_intercept
e533b1a target/i386: Tidy svm_check_intercept from tcg
07bc5bb target/i386: Simplify gen_debug usage
33b7b33 target/i386: Mark some helpers as noreturn
9e4eefd target/i386: Eliminate SVM helpers for user-only
a4b7e86 target/i386: Implement skinit in translate.c
11f0dd5 target/i386: Assert !GUEST for user-only
0b9152d target/i386: Assert !SVME for user-only
1619090 target/i386: Add stub generator for helper_set_dr
6b31254 target/i386: Reorder DisasContext members
a196b94 target/i386: Fix the comment for repz_opt
05d9ac8 target/i386: Reduce DisasContext jmp_opt, repz_opt to bool
2248cea target/i386: Leave TF in DisasContext.flags
3e5c314 target/i386: Reduce DisasContext popl_esp_hack and rip_offset to uint8_t
d2ff6f0 target/i386: Reduce DisasContext.vex_[lv] to uint8_t
1045677 target/i386: Reduce DisasContext.prefix to uint8_t
b052ed9 target/i386: Reduce DisasContext.override to int8_t
04bd526 target/i386: Reduce DisasContext.flags to uint32_t
25a9164 target/i386: Remove DisasContext.f_st as unused
9c8cd54 target/i386: Move rex_w into DisasContext
be9c7a6 target/i386: Move rex_r into DisasContext
8f59d5d target/i386: Tidy REX_B, REX_X definition
86d68fb target/i386: Introduce REX_PREFIX
df0e9ba target/i386: Assert !ADDSEG for x86_64 user-only
afbeac9 target/i386: Assert LMA for x86_64 user-only
ef457bd target/i386: Assert CODE64 for x86_64 user-only
bb9e685 target/i386: Assert SS32 for x86_64 user-only
926c3fc target/i386: Assert CODE32 for x86_64 user-only
47c6cc1 target/i386: Assert !VM86 for x86_64 user-only
4b8ee2f target/i386: Assert IOPL is 0 for user-only
46331b6 target/i386: Assert CPL is 3 for user-only
e5377a8 target/i386: Assert PE is set for user-only
f3dcdd9 target/i386: Split out check_iopl
f6f133e target/i386: Split out check_vm86_iopl
5497a8a target/i386: Unify code paths for IRET
7f7ed03 target/i386: Split out check_cpl0
9eee238 target/i386: Split out gen_exception_gpf
=== OUTPUT BEGIN ===
1/50 Checking commit 9eee2384d266 (target/i386: Split out gen_exception_gpf)
2/50 Checking commit 7f7ed0354a5f (target/i386: Split out check_cpl0)
3/50 Checking commit 5497a8ae5aba (target/i386: Unify code paths for IRET)
4/50 Checking commit f6f133e635f0 (target/i386: Split out check_vm86_iopl)
5/50 Checking commit f3dcdd958c30 (target/i386: Split out check_iopl)
6/50 Checking commit e5377a824c04 (target/i386: Assert PE is set for user-only)
ERROR: braces {} are necessary for all arms of this statement
#128: FILE: target/i386/tcg/translate.c:7310:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#146: FILE: target/i386/tcg/translate.c:7329:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#164: FILE: target/i386/tcg/translate.c:7349:
+if (!PE(s) || s->vm86)
[...]
ERROR: braces {} are necessary for all arms of this statement
#236: FILE: target/i386/tcg/translate.c:7720:
+if
Re: [PATCH v8 0/7] eBPF RSS support for virtio-net.
Patchew URL: https://patchew.org/QEMU/20210514114835.267316-1-and...@daynix.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210514114835.267316-1-and...@daynix.com
Subject: [PATCH v8 0/7] eBPF RSS support for virtio-net.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210514114835.267316-1-and...@daynix.com ->
patchew/20210514114835.267316-1-and...@daynix.com
Switched to a new branch 'test'
1619e1f MAINTAINERS: Added eBPF maintainers information.
aba59a3 docs: Added eBPF documentation.
14a875c virtio-net: Added eBPF RSS to virtio-net.
cd612cb ebpf: Added eBPF RSS loader.
b5ded54 ebpf: Added eBPF RSS program.
cedb364 net: Added SetSteeringEBPF method for NetClientState.
d3b32d3 net/tap: Added TUNSETSTEERINGEBPF code.
=== OUTPUT BEGIN ===
1/7 Checking commit d3b32d3868ff (net/tap: Added TUNSETSTEERINGEBPF code.)
2/7 Checking commit cedb3648f753 (net: Added SetSteeringEBPF method for
NetClientState.)
3/7 Checking commit b5ded54bcb50 (ebpf: Added eBPF RSS program.)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100755
total: 0 errors, 1 warnings, 593 lines checked
Patch 3/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit cd612cb859b2 (ebpf: Added eBPF RSS loader.)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: architecture specific defines should be avoided
#353: FILE: ebpf/rss.bpf.skeleton.h:4:
+#ifndef __RSS_BPF_SKEL_H__
ERROR: code indent should never use tabs
#360: FILE: ebpf/rss.bpf.skeleton.h:11:
+^Istruct bpf_object_skeleton *skeleton;$
ERROR: code indent should never use tabs
#361: FILE: ebpf/rss.bpf.skeleton.h:12:
+^Istruct bpf_object *obj;$
ERROR: code indent should never use tabs
#362: FILE: ebpf/rss.bpf.skeleton.h:13:
+^Istruct {$
ERROR: code indent should never use tabs
#363: FILE: ebpf/rss.bpf.skeleton.h:14:
+^I^Istruct bpf_map *tap_rss_map_configurations;$
ERROR: code indent should never use tabs
#364: FILE: ebpf/rss.bpf.skeleton.h:15:
+^I^Istruct bpf_map *tap_rss_map_indirection_table;$
ERROR: code indent should never use tabs
#365: FILE: ebpf/rss.bpf.skeleton.h:16:
+^I^Istruct bpf_map *tap_rss_map_toeplitz_key;$
ERROR: code indent should never use tabs
#366: FILE: ebpf/rss.bpf.skeleton.h:17:
+^I} maps;$
ERROR: code indent should never use tabs
#367: FILE: ebpf/rss.bpf.skeleton.h:18:
+^Istruct {$
ERROR: code indent should never use tabs
#368: FILE: ebpf/rss.bpf.skeleton.h:19:
+^I^Istruct bpf_program *tun_rss_steering_prog;$
ERROR: code indent should never use tabs
#369: FILE: ebpf/rss.bpf.skeleton.h:20:
+^I} progs;$
ERROR: code indent should never use tabs
#370: FILE: ebpf/rss.bpf.skeleton.h:21:
+^Istruct {$
ERROR: code indent should never use tabs
#371: FILE: ebpf/rss.bpf.skeleton.h:22:
+^I^Istruct bpf_link *tun_rss_steering_prog;$
ERROR: code indent should never use tabs
#372: FILE: ebpf/rss.bpf.skeleton.h:23:
+^I} links;$
ERROR: code indent should never use tabs
#378: FILE: ebpf/rss.bpf.skeleton.h:29:
+^Iif (!obj)$
ERROR: braces {} are necessary for all arms of this statement
#378: FILE: ebpf/rss.bpf.skeleton.h:29:
+ if (!obj)
[...]
ERROR: code indent should never use tabs
#379: FILE: ebpf/rss.bpf.skeleton.h:30:
+^I^Ireturn;$
ERROR: code indent should never use tabs
#380: FILE: ebpf/rss.bpf.skeleton.h:31:
+^Iif (obj->skeleton)$
ERROR: braces {} are necessary for all arms of this statement
#380: FILE: ebpf/rss.bpf.skeleton.h:31:
+ if (obj->skeleton)
[...]
ERROR: code indent should never use tabs
#381: FILE: ebpf/rss.bpf.skeleton.h:32:
+^I^Ibpf_object__destroy_skeleton(obj->skeleton);$
ERROR: code indent should never use tabs
#382: FILE: ebpf/rss.bpf.skeleton.h:33:
+^Ifree(obj);$
ERROR: code indent should never use tabs
#391: FILE: ebpf/rss.bpf.skeleton.h:42:
+^Istruct rss_bpf *obj;$
ERROR: code indent should never use tabs
#393: FILE: ebpf/rss.bpf.skeleton.h:44:
+^Iobj = (struct rss_bpf *)calloc(1, sizeof(*obj));$
ERROR: code indent should never use tabs
#394: FILE: ebpf/rss.bpf.skeleton.h:45:
+^Iif (!obj)$
ERROR: braces {} are necessary for all arms of this statement
#394: FILE: ebpf/rss.bpf.skeleton.h:45:
+ if (!obj)
[...]
ERROR: code indent should never use tabs
#395: FILE: ebpf/rss.bpf.skeleton.h:46:
Re: [PATCH 00/14] vl: compound properties for machines and accelerators
Patchew URL:
https://patchew.org/QEMU/20210513162901.1310239-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210513162901.1310239-1-pbonz...@redhat.com
Subject: [PATCH 00/14] vl: compound properties for machines and accelerators
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210513162901.1310239-1-pbonz...@redhat.com ->
patchew/20210513162901.1310239-1-pbonz...@redhat.com
Switched to a new branch 'test'
f11df8b machine: add smp compound property
056a1f3 machine: reject -smp dies!=1 for non-PC machines
f9a9ed1 machine: pass QAPI struct to mc->smp_parse
ccdb728 machine: add error propagation to mc->smp_parse
36dc3c3 machine: move common smp_parse code to caller
c547aa6 machine: move dies from X86MachineState to CpuTopology
4fa41d4 vl: switch -accel parsing to keyval
51375fd qemu-option: remove now-dead code
a91c274 vl: switch -M parsing to keyval
3bafa79 keyval: introduce keyval_parse_into
237070b qom: export more functions for use with non-UserCreatable objects
06ecbc4 vl: plumb keyval-based options into -set and -readconfig
105227f qemu-config: parse configuration files to a QDict
0e653b3 remove -writeconfig
=== OUTPUT BEGIN ===
1/14 Checking commit 0e653b38c051 (remove -writeconfig)
2/14 Checking commit 105227fb9596 (qemu-config: parse configuration files to a
QDict)
WARNING: line over 80 characters
#31: FILE: include/qemu/config-file.h:4:
+typedef void QEMUConfigCB(const char *group, QDict *qdict, void *opaque, Error
**errp);
WARNING: line over 80 characters
#41: FILE: include/qemu/config-file.h:18:
+void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error
**errp);
WARNING: line over 80 characters
#65: FILE: softmmu/vl.c:3372:
+qemu_read_config_file(optarg, qemu_config_do_parse,
_fatal);
WARNING: line over 80 characters
#173: FILE: util/qemu-config.c:385:
+void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error
**errp)
WARNING: line over 80 characters
#195: FILE: util/qemu-config.c:407:
+int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname, Error
**errp)
total: 0 errors, 5 warnings, 170 lines checked
Patch 2/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/14 Checking commit 06ecbc4ad0ba (vl: plumb keyval-based options into -set and
-readconfig)
WARNING: line over 80 characters
#117: FILE: softmmu/vl.c:2148:
+static KeyvalConfigEntry *qemu_find_config(KeyvalConfigGroup *head, const char
*id)
ERROR: line over 90 characters
#129: FILE: softmmu/vl.c:2160:
+static void qemu_record_config_group(const char *group, QDict *dict, bool
from_json, Error **errp)
WARNING: line over 80 characters
#144: FILE: softmmu/vl.c:2175:
+static void qemu_set_qdict_option(QDict *dict, const char *key, const char
*value,
WARNING: line over 80 characters
#174: FILE: softmmu/vl.c:2205:
+error_setg(errp, "Lists cannot be at top level of a configuration
section");
WARNING: line over 80 characters
#223: FILE: softmmu/vl.c:2247:
+error_setg(errp, "cannot use -set with %s \"%s\" passed as JSON",
group, id);
WARNING: line over 80 characters
#272: FILE: softmmu/vl.c:3476:
+qemu_read_config_file(optarg, qemu_parse_config_group,
_fatal);
ERROR: line over 90 characters
#290: FILE: tests/unit/test-keyval.c:756:
+QDict *combined =
keyval_parse("opt1=ABC,opt2.sub1=def,opt2.sub2=GHI,opt2.sub3=JKL,opt3=xyz",
WARNING: line over 80 characters
#359: FILE: util/keyval.c:314:
+static void keyval_do_merge(QDict *old, const QDict *new, GString *str, Error
**errp)
ERROR: line over 90 characters
#369: FILE: util/keyval.c:324:
+error_setg(errp, "Parameter '%s%s' used inconsistently",
str->str, ent->key);
total: 3 errors, 6 warnings, 344 lines checked
Patch 3/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/14 Checking commit 237070ba2b31 (qom: export more functions for use with
non-UserCreatable objects)
5/14 Checking commit 3bafa79a7738 (keyval: introduce keyval_parse_into)
WARNING: line over 80 characters
#26: FILE: include/qemu/option.h:150:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
WARNING: line over 80 characters
#48: FILE: util/keyval.c:486:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char
*implied_key,
total: 0 errors, 2 warnings, 78 lines checked
Patch 5/14 has style problems,
Re: [PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles
Patchew URL: https://patchew.org/QEMU/20210513095519.1213675-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210513095519.1213675-1-berra...@redhat.com Subject: [PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210508014802.892561-1-richard.hender...@linaro.org -> patchew/20210508014802.892561-1-richard.hender...@linaro.org * [new tag] patchew/20210513095519.1213675-1-berra...@redhat.com -> patchew/20210513095519.1213675-1-berra...@redhat.com Switched to a new branch 'test' 73a0045 tests/docker: remove ubuntu container d6b42f9 tests/docker: auto-generate opensuse-leap with lcitool 8a2b437 tests/docker: auto-generate ubuntu2004 with lcitool dd19e03 tests/docker: auto-generate ubuntu1804 with lcitool 931d434 tests/docker: auto-generate fedora with lcitool 8402c0d tests/docker: auto-generate centos8 with lcitool f581c7c tests/docker: add script for automating container refresh 95ad785 tests/docker: expand opensuse-leap package list 790f77d tests/docker: expand ubuntu2004 package list 0c357e1 tests/docker: expand ubuntu1804 package list a29a532 tests/docker: expand fedora package list f1df3d0 tests/docker: expand centos8 package list a7c131e tests/docker: remove mingw packages from Fedora 37ce608 tests/docker: fix mistakes in ubuntu package lists 977b03d tests/docker: fix mistakes in fedora package list b3580ed tests/docker: fix mistakes in centos package lists 5757744 tests/docker: fix sorting in package lists 826c380 tests/docker: remove FEATURES env var from templates fad3849 tests/docker: use explicit docker.io registry 5098f17 tests/docker: use project specific container registries 2dc7c73 tests/docker: don't use BUILDKIT in GitLab either f10a2d6 hw/usb/ccid: remove references to NSS === OUTPUT BEGIN === 1/22 Checking commit f10a2d6c78d1 (hw/usb/ccid: remove references to NSS) 2/22 Checking commit 2dc7c735b228 (tests/docker: don't use BUILDKIT in GitLab either) 3/22 Checking commit 5098f173e564 (tests/docker: use project specific container registries) 4/22 Checking commit fad3849eb138 (tests/docker: use explicit docker.io registry) 5/22 Checking commit 826c380cbbc9 (tests/docker: remove FEATURES env var from templates) 6/22 Checking commit 57577442850f (tests/docker: fix sorting in package lists) 7/22 Checking commit b3580edfbd81 (tests/docker: fix mistakes in centos package lists) 8/22 Checking commit 977b03d43f95 (tests/docker: fix mistakes in fedora package list) 9/22 Checking commit 37ce60848186 (tests/docker: fix mistakes in ubuntu package lists) 10/22 Checking commit a7c131edc9b6 (tests/docker: remove mingw packages from Fedora) 11/22 Checking commit f1df3d0229f6 (tests/docker: expand centos8 package list) 12/22 Checking commit a29a53287642 (tests/docker: expand fedora package list) 13/22 Checking commit 0c357e188a91 (tests/docker: expand ubuntu1804 package list) 14/22 Checking commit 790f77db86dc (tests/docker: expand ubuntu2004 package list) 15/22 Checking commit 95ad7854e308 (tests/docker: expand opensuse-leap package list) 16/22 Checking commit f581c7c94392 (tests/docker: add script for automating container refresh) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #106: new file mode 100755 total: 0 errors, 1 warnings, 109 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 8402c0d0f253 (tests/docker: auto-generate centos8 with lcitool) 18/22 Checking commit 931d434d8aef (tests/docker: auto-generate fedora with lcitool) 19/22 Checking commit dd19e0388006 (tests/docker: auto-generate ubuntu1804 with lcitool) 20/22 Checking commit 8a2b437a4498 (tests/docker: auto-generate ubuntu2004 with lcitool) ERROR: line over 90 characters #28: FILE: tests/docker/dockerfiles-refresh.py:65: + "RUN sed -i 's/^const/static const/g' /usr/lib/llvm-10/lib/clang/10.0.0/include/sanitizer/tsan_interface.h\n"] total: 1 errors, 0 warnings, 266 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit d6b42f932077 (tests/docker: auto-generate opensuse-leap with lcitool) 22/22 Checking commit 73a00450ba05 (tests/docker: remove ubuntu container) Use of uninitialized
Re: [RFC PATCH v1 0/7] migration/snapshot: External snapshot utility
Patchew URL:
https://patchew.org/QEMU/20210512192619.537268-1-andrey.gruz...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210512192619.537268-1-andrey.gruz...@virtuozzo.com
Subject: [RFC PATCH v1 0/7] migration/snapshot: External snapshot utility
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
3158964..3e9f48b master -> master
- [tag update] patchew/20210511163151.45167-1-kw...@redhat.com ->
patchew/20210511163151.45167-1-kw...@redhat.com
* [new tag]
patchew/20210512192619.537268-1-andrey.gruz...@virtuozzo.com ->
patchew/20210512192619.537268-1-andrey.gruz...@virtuozzo.com
Switched to a new branch 'test'
87d9eb7 migration/snapshot: Implementation of qemu-snapshot load path in
postcopy mode
dece241 migration/snapshot: Implementation of qemu-snapshot load path
cbaa5b9 migration/snapshot: Implementation of qemu-snapshot save path
f9dd5c5 migration/snapshot: Block layer AIO support in qemu-snapshot
ed9b73d migration/snapshot: Move RAM_SAVE_FLAG_xxx defines to migration/ram.h
92f9263 migration/snapshot: Introduce qemu_ftell2() routine
32c347a migration/snapshot: Introduce qemu-snapshot tool
=== OUTPUT BEGIN ===
1/7 Checking commit 32c347a19ef4 (migration/snapshot: Introduce qemu-snapshot
tool)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
WARNING: line over 80 characters
#227: FILE: qemu-snapshot.c:63:
+int postcopy_percent; /* Start postcopy after % of normal pages
loaded */
WARNING: line over 80 characters
#274: FILE: qemu-snapshot.c:110:
+static BlockBackend *image_open_opts(const char *optstr, QDict *options, int
flags)
ERROR: switch and case should be at the same indent
#414: FILE: qemu-snapshot.c:250:
+switch (c) {
+case '?':
[...]
+case 'h':
[...]
+case 'V':
[...]
+case 'T':
[...]
+case 'r':
[...]
+case OPTION_POSTCOPY:
[...]
+case OPTION_PAGE_SIZE:
[...]
+case OPTION_URI:
[...]
+default:
ERROR: trailing whitespace
#436: FILE: qemu-snapshot.c:272:
+$
ERROR: consider using qemu_strtol in preference to strtol
#449: FILE: qemu-snapshot.c:285:
+postcopy_percent = strtol(optarg, , 10);
WARNING: line over 80 characters
#450: FILE: qemu-snapshot.c:286:
+if (*r != '\0' || postcopy_percent < 0 || postcopy_percent >
100) {
ERROR: consider using qemu_strtol in preference to strtol
#468: FILE: qemu-snapshot.c:304:
+target_page_size = strtol(optarg, , 0);
WARNING: line over 80 characters
#469: FILE: qemu-snapshot.c:305:
+if (*r != '\0' || (target_page_size & (target_page_size - 1))
!= 0 ||
ERROR: space required after that ',' (ctx:VxV)
#494: FILE: qemu-snapshot.c:330:
+fd = strtol(p, ,10);
^
ERROR: consider using qemu_strtol in preference to strtol
#494: FILE: qemu-snapshot.c:330:
+fd = strtol(p, ,10);
total: 6 errors, 5 warnings, 563 lines checked
Patch 1/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/7 Checking commit 92f92637b84c (migration/snapshot: Introduce qemu_ftell2()
routine)
3/7 Checking commit ed9b73da773a (migration/snapshot: Move RAM_SAVE_FLAG_xxx
defines to migration/ram.h)
WARNING: Block comments use a leading /* on a separate line
#51: FILE: migration/ram.h:36:
+/* RAM_SAVE_FLAG_ZERO used to be named RAM_SAVE_FLAG_COMPRESS, it
total: 0 errors, 1 warnings, 44 lines checked
Patch 3/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit f9dd5c542600 (migration/snapshot: Block layer AIO support
in qemu-snapshot)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#81:
new file mode 100644
total: 0 errors, 1 warnings, 314 lines checked
Patch 4/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/7 Checking commit cbaa5b9bd2a6 (migration/snapshot: Implementation of
qemu-snapshot save path)
WARNING: line over 80 characters
#554: FILE: qemu-snapshot-vm.c:507:
+error_report("RAM page with unknown
Re: [PULL 00/20] bsd-user style tweaks and start cleanup
Patchew URL: https://patchew.org/QEMU/20210512171720.46744-1-...@bsdimp.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210512171720.46744-1-...@bsdimp.com
Subject: [PULL 00/20] bsd-user style tweaks and start cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210512171720.46744-1-...@bsdimp.com ->
patchew/20210512171720.46744-1-...@bsdimp.com
Switched to a new branch 'test'
2aa0f06 bsd-user: rename linux_binprm to bsd_binprm
e744264 bsd-user: Stop building the sparc targets
4fb5ace bsd-user: remove target_signal.h, it's unused
9950891 bsd-user: style tweak: keyword space (
91acd46 bsd-user: style tweak: Remove #if 0'd code
5e136ea bsd-user: style tweak: keyword space (
0f3d103 bsd-user: style tweak: keyword space (
dc9303a bsd-user: whitespace changes
0a03bb9 bsd-user: use qemu_strtoul in preference to strtol
6ee8628 bsd-user: style tweak: use {} consistently in for / if / else statements
0144028 bsd-user: style tweak: use {} for all if statements, format else
correctly
3d59f14 bsd-user: style tweak: don't assign in if statements
97c0b3e bsd-user: style tweak: Use preferred block comments
584c4ff bsd-user: style tweak: remove spacing after '*' and add after }
8239005 bsd-user: style tweak: move extern to header file
7e7f935 bsd-user: Remove commented out code
764c1fd bsd-user: style tweak: Use preferred block comments
5c28edb bsd-user: style tweak: Remove #if 0'd code
eb26490 bsd-user: style tweak: use C not C++ comments
fbb73a2 bsd-user: whitespace changes
=== OUTPUT BEGIN ===
1/20 Checking commit fbb73a2dcc67 (bsd-user: whitespace changes)
ERROR: consider using qemu_strtol in preference to strtol
#102: FILE: bsd-user/main.c:834:
+guest_base = strtol(argv[optind++], NULL, 0);
ERROR: braces {} are necessary for all arms of this statement
#143: FILE: bsd-user/main.c:1125:
+for (i = 0; i < 8; i++)
[...]
ERROR: braces {} are necessary for all arms of this statement
#146: FILE: bsd-user/main.c:1127:
+for (i = 0; i < 8; i++)
[...]
total: 3 errors, 0 warnings, 119 lines checked
Patch 1/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/20 Checking commit eb264903b567 (bsd-user: style tweak: use C not C++
comments)
3/20 Checking commit 5c28edb911a7 (bsd-user: style tweak: Remove #if 0'd code)
4/20 Checking commit 764c1fd2354d (bsd-user: style tweak: Use preferred block
comments)
5/20 Checking commit 7e7f9355aca9 (bsd-user: Remove commented out code)
6/20 Checking commit 8239005bb526 (bsd-user: style tweak: move extern to header
file)
7/20 Checking commit 584c4ffaa229 (bsd-user: style tweak: remove spacing after
'*' and add after })
8/20 Checking commit 97c0b3ee8dcb (bsd-user: style tweak: Use preferred block
comments)
9/20 Checking commit 3d59f140da1b (bsd-user: style tweak: don't assign in if
statements)
10/20 Checking commit 0144028ea197 (bsd-user: style tweak: use {} for all if
statements, format else correctly)
11/20 Checking commit 6ee8628e22e5 (bsd-user: style tweak: use {} consistently
in for / if / else statements)
12/20 Checking commit 0a03bb93ea8c (bsd-user: use qemu_strtoul in preference to
strtol)
13/20 Checking commit dc9303a0a28d (bsd-user: whitespace changes)
WARNING: line over 80 characters
#149: FILE: bsd-user/elfload.c:541:
+#define TARGET_ELF_PAGESTART(_v) ((_v) & ~(unsigned
long)(TARGET_ELF_EXEC_PAGESIZE - 1))
ERROR: braces {} are necessary for all arms of this statement
#331: FILE: bsd-user/elfload.c:867:
+if (sizeof(struct elf_phdr) * interp_elf_ex->e_phnum > TARGET_PAGE_SIZE)
[...]
ERROR: braces {} are necessary for all arms of this statement
#341: FILE: bsd-user/elfload.c:873:
+if (!elf_phdata)
[...]
ERROR: space prohibited between function name and open parenthesis '('
#382: FILE: bsd-user/elfload.c:894:
+free (elf_phdata);
ERROR: spaces required around that '<' (ctx:VxV)
#391: FILE: bsd-user/elfload.c:899:
+for (i = 0; ie_phnum; i++, eppnt++) {
^
WARNING: Block comments use a leading /* on a separate line
#409: FILE: bsd-user/elfload.c:905:
+/* in order to avoid hardcoding the interpreter load
WARNING: Block comments use * on subsequent lines
#410: FILE: bsd-user/elfload.c:906:
+/* in order to avoid hardcoding the interpreter load
+ address in qemu, we allocate a big enough memory zone */
WARNING: Block comments use a trailing */ on a separate line
#410: FILE: bsd-user/elfload.c:906:
+ address in qemu, we allocate a big enough memory zone */
