Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts I applied patch 1-5 on my tree, thanks everyone. Markus Armbruster (7): smbios: Normalize smbios_entry_add()'s error handling to exit(1) smbios: Convert to QemuOpts smbios: Improve diagnostics for conflicting entries smbios: Make multiple -smbios type= accumulate sanely smbios: Factor out smbios_maybe_add_str() vl: Set current_machine early smbios: Set system manufacturer, product version by default arch_init.c| 9 +- hw/i386/pc.c | 6 +- hw/i386/pc_piix.c | 5 + hw/i386/pc_q35.c | 3 + hw/i386/smbios.c | 349 - include/hw/i386/pc.h | 1 + include/hw/i386/smbios.h | 7 +- include/sysemu/arch_init.h | 2 +- include/sysemu/sysemu.h| 1 + vl.c | 8 +- 10 files changed, 276 insertions(+), 115 deletions(-) -- 1.8.1.4
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
On Wed, Sep 18, 2013 at 01:42:28PM +0200, Markus Armbruster wrote: [Note cc: Andreas] Michael S. Tsirkin m...@redhat.com writes: On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts OK my thinking at this point is: patches 1-6 are ready Any objections? patch 7 - I would prefer some way to explicitly set default smbios manufacturer/version in machine type and set these from machine type, instead of the smbios_type1_defaults boolean. Are you asking for a new QEMUMachine member holding manufacturer (either Bochs, QEMU or null), and new members holding product and version (either null or same value as existing members desc and version, at least now)? Yes, I think we can live with this one. Though I would really prefer a property of some device. Or just for moving smbios_type1_defaults from init function into QEMUMachine? Would you like - me to apply 1-6 and keep working on 7? - wait for you to repost v3? - look for another maintainer to take patchset as is (if someone cares to, I won't object)? Waiting for another maintainer after waiting 2 months for *any* maintainer doesn't strike me as a good idea %-} I'm totally fine with you taking just PATCH 1-5. PATCH 6, however, should not be applied without PATCH 7. Andreas doesn't like PATCH 6, and overruling his dislike without an actual use for it (which comes only in PATCH 7) isn't nice. I missed this fact, thanks for pointing it out. So please arrive at consensus with Andreas re PATCH 6.
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
[Note cc: Andreas] Michael S. Tsirkin m...@redhat.com writes: On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts OK my thinking at this point is: patches 1-6 are ready Any objections? patch 7 - I would prefer some way to explicitly set default smbios manufacturer/version in machine type and set these from machine type, instead of the smbios_type1_defaults boolean. Are you asking for a new QEMUMachine member holding manufacturer (either Bochs, QEMU or null), and new members holding product and version (either null or same value as existing members desc and version, at least now)? Or just for moving smbios_type1_defaults from init function into QEMUMachine? Would you like - me to apply 1-6 and keep working on 7? - wait for you to repost v3? - look for another maintainer to take patchset as is (if someone cares to, I won't object)? Waiting for another maintainer after waiting 2 months for *any* maintainer doesn't strike me as a good idea %-} I'm totally fine with you taking just PATCH 1-5. PATCH 6, however, should not be applied without PATCH 7. Andreas doesn't like PATCH 6, and overruling his dislike without an actual use for it (which comes only in PATCH 7) isn't nice.
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts OK my thinking at this point is: patches 1-6 are ready Any objections? patch 7 - I would prefer some way to explicitly set default smbios manufacturer/version in machine type and set these from machine type, instead of the smbios_type1_defaults boolean. Would you like - me to apply 1-6 and keep working on 7? - wait for you to repost v3? - look for another maintainer to take patchset as is (if someone cares to, I won't object)? Markus Armbruster (7): smbios: Normalize smbios_entry_add()'s error handling to exit(1) smbios: Convert to QemuOpts smbios: Improve diagnostics for conflicting entries smbios: Make multiple -smbios type= accumulate sanely smbios: Factor out smbios_maybe_add_str() vl: Set current_machine early smbios: Set system manufacturer, product version by default arch_init.c| 9 +- hw/i386/pc.c | 6 +- hw/i386/pc_piix.c | 5 + hw/i386/pc_q35.c | 3 + hw/i386/smbios.c | 349 - include/hw/i386/pc.h | 1 + include/hw/i386/smbios.h | 7 +- include/sysemu/arch_init.h | 2 +- include/sysemu/sysemu.h| 1 + vl.c | 8 +- 10 files changed, 276 insertions(+), 115 deletions(-) -- 1.8.1.4
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
Eric, On 08/16/13 15:18, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts can you please re-ack this? You acked v2: http://thread.gmane.org/gmane.comp.emulators.qemu/222747 (And I don't have the slightest clue why it hasn't been merged after your Reviewed-by; it was posted, and reviewed, and pinged, before the hard freeze for 1.6) If you don't have the time, I can review it from scratch. Sometime. Hopefully. Thanks, Laszlo
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
On 08/17/2013 06:08 AM, Laszlo Ersek wrote: Eric, On 08/16/13 15:18, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts can you please re-ack this? You acked v2: http://thread.gmane.org/gmane.comp.emulators.qemu/222747 My prior review still stands. The series looks good to me. (And I don't have the slightest clue why it hasn't been merged after your Reviewed-by; it was posted, and reviewed, and pinged, before the hard freeze for 1.6) I have no idea what happened either. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1
From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. v2: Rebase, only last patch had conflicts Markus Armbruster (7): smbios: Normalize smbios_entry_add()'s error handling to exit(1) smbios: Convert to QemuOpts smbios: Improve diagnostics for conflicting entries smbios: Make multiple -smbios type= accumulate sanely smbios: Factor out smbios_maybe_add_str() vl: Set current_machine early smbios: Set system manufacturer, product version by default arch_init.c| 9 +- hw/i386/pc.c | 6 +- hw/i386/pc_piix.c | 5 + hw/i386/pc_q35.c | 3 + hw/i386/smbios.c | 349 - include/hw/i386/pc.h | 1 + include/hw/i386/smbios.h | 7 +- include/sysemu/arch_init.h | 2 +- include/sysemu/sysemu.h| 1 + vl.c | 8 +- 10 files changed, 276 insertions(+), 115 deletions(-) -- 1.8.1.4
