Re: [Qt-creator] QtCreator plugin contribution

[Mateusz Loskot]

On 13 April 2015 at 13:55, André Hartmann  wrote:
>
>>> I hope it's acceptable workflow, as two other developers that joined
>>> my efforts are based on GitHub, and GitHub simlifies our collaboration a 
>>> lot.
>>
>> Every author needs to agree to the Contribution Licensee Agreement, so
>> make sure that everyone that joins you understands and signs that CLA.
>
> Maybe a wip (work in progress) branch on Qt Gerrit is the better choise?
>
> Pros:
> - All contributors sign the CLA, so there's no licence problems later
> - You get the Qt Sanity Bot (and human reviewers) checking the coding
>   style
> - The code is under broader review, maybe more contributions come in
> - You make it easy for others to check out that branch and test it
> - When the work is finished, the branch could easily be merged
> - Further work after the initial release has to be done on Gerrit anyway
>
> Cons:
> - You and your contributors need to setup and learn Gerrit,
>   but you will need to anyway, and I think the other two already did :)

André, thank you very much for outlining the pros & cons.
We've been 'converted' :) and we've decided to go for the recommended
Gerrit way.

Best regards,
-- 
Mateusz  Loskot, http://mateusz.loskot.net
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[André Hartmann]

Just two more cents from my side,

 >> I hope it's acceptable workflow, as two other developers that joined
>> my efforts are based on GitHub, and GitHub simlifies our collaboration a
>> lot.
>
> Every author needs to agree to the Contribution Licensee Agreement, so make
> sure that everyone that joins you understands and signs that CLA.

Maybe a wip (work in progress) branch on Qt Gerrit is the better choise?

Pros:
- All contributors sign the CLA, so there's no licence problems later
- You get the Qt Sanity Bot (and human reviewers) checking the coding
   style
- The code is under broader review, maybe more contributions come in
- You make it easy for others to check out that branch and test it
- When the work is finished, the branch could easily be merged
- Further work after the initial release has to be done on Gerrit anyway

Cons:
- You and your contributors need to setup and learn Gerrit,
   but you will need to anyway, and I think the other two already did :)

Personally I don't see much advantage for external developing on GitHub.

But that's just my personal opinion.

Best regards,
André
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Daniel Teske]

On Monday 13 Apr 2015 10:04:05 Mateusz Loskot wrote:
> On 13 April 2015 at 09:36, Mateusz Loskot  wrote:
> > On 13 April 2015 at 08:18, André Hartmann  
wrote:
> >>> https://wiki.qt.io/Branch_Guidelines
> >>> The latter explains recommendations and caveats of possible
> >>> development workflows.
> >> 
> >> But that's only true for Qt itself.
> > 
> > The /Branches article says
> > "Qt Creator uses the same branching policy as Qt itself"
> > 
> >> So just push your new plugins to master.
> > 
> > I've been looking for answer on which branch to branch off, thanks.
> 
> I should have clarified, I'm going to work prepare for contribution this
> way: - fork Qt Creator on GitHub
> - create branch boostbuild-plugin branched off of the master
> - import source of my plugin
> - work on the plugin integration, apply necessary changes, etc.
> - once the integration is completed, submit the plugin through Gerrit
> 
> I hope it's acceptable workflow, as two other developers that joined
> my efforts are based on GitHub, and GitHub simlifies our collaboration a
> lot.

Every author needs to agree to the Contribution Licensee Agreement, so make 
sure that everyone that joins you understands and signs that CLA.

daniel
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Oswald Buddenhagen]

On Mon, Apr 13, 2015 at 08:32:51AM +, Ziller Eike wrote:
> On Apr 13, 2015, at 9:36 AM, Mateusz Loskot  wrote:
> > The /Branches article says
> > "Qt Creator uses the same branching policy as Qt itself”
> 
> That information was never correct then.
> 
i don't see how that is true in any way. you are just fragmenting the
wiki, causing more confusion for newcomers.
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Ziller Eike]

> On Apr 13, 2015, at 9:36 AM, Mateusz Loskot  wrote:
> 
> On 13 April 2015 at 08:18, André Hartmann  wrote:
>> Hi,
>> 
>>> BTW, there are more Wiki pages that you need to crunch:
>>> https://wiki.qt.io/Branch
> 
> Should read https://wiki.qt.io/Branches
> 
>>> https://wiki.qt.io/Branch_Guidelines
>>> The latter explains recommendations and caveats of possible
>>> development workflows.
>> 
>> 
>> But that's only true for Qt itself.
> 
> The /Branches article says
> "Qt Creator uses the same branching policy as Qt itself”

That information was never correct then. I’ve fixed the Qt Creator parts on 
that page now (including the link to the submit policies).

Br, Eike

> 
>> So just push your new plugins to master.
> 
> I've been looking for answer on which branch to branch off, thanks.
> 
> Best regards,
> -- 
> Mateusz  Loskot, http://mateusz.loskot.net
> ___
> Qt-creator mailing list
> Qt-creator@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator

-- 
Eike Ziller, Senior Software Engineer - The Qt Company GmbH
 
The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Tuula Haataja
Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 
144331 B

___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Mateusz Loskot]

On 13 April 2015 at 09:36, Mateusz Loskot  wrote:
> On 13 April 2015 at 08:18, André Hartmann  wrote:
>>>
>>> https://wiki.qt.io/Branch_Guidelines
>>> The latter explains recommendations and caveats of possible
>>> development workflows.
>>
>>
>> But that's only true for Qt itself.
>
> The /Branches article says
> "Qt Creator uses the same branching policy as Qt itself"
>
>> So just push your new plugins to master.
>
> I've been looking for answer on which branch to branch off, thanks.

I should have clarified, I'm going to work prepare for contribution this way:
- fork Qt Creator on GitHub
- create branch boostbuild-plugin branched off of the master
- import source of my plugin
- work on the plugin integration, apply necessary changes, etc.
- once the integration is completed, submit the plugin through Gerrit

I hope it's acceptable workflow, as two other developers that joined
my efforts are based on GitHub, and GitHub simlifies our collaboration a lot.

That is base on "Feature development outside of Gerrit"
https://wiki.qt.io/Branch_Guidelines

Best regards,
-- 
Mateusz  Loskot, http://mateusz.loskot.net
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Mateusz Loskot]

On 13 April 2015 at 08:18, André Hartmann  wrote:
> Hi,
>
>> BTW, there are more Wiki pages that you need to crunch:
>> https://wiki.qt.io/Branch

Should read https://wiki.qt.io/Branches

>> https://wiki.qt.io/Branch_Guidelines
>> The latter explains recommendations and caveats of possible
>> development workflows.
>
>
> But that's only true for Qt itself.

The /Branches article says
"Qt Creator uses the same branching policy as Qt itself"

> So just push your new plugins to master.

I've been looking for answer on which branch to branch off, thanks.

Best regards,
-- 
Mateusz  Loskot, http://mateusz.loskot.net
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[André Hartmann]

Thanks Orgad for clarifying this :)

 > André meant pushing to refs/for/master, not directly to master.

Yes, that was exactly what I meant. Maybe I shouldn't write to the list 
before my first coffee...

 > And do this one needs the necessary karma :-)

Push rights would be enough :-P

But, jokes aside, I think the following two pages might also interesting 
(as I now noticed the weren't mentioned before):

https://wiki.qt.io/Gerrit_Introduction
https://wiki.qt.io/Setting_up_Gerrit

This seems a lot of work at first glance, but if you take it step by 
step it's not that complicated.

If you have any questions, feel free to ask here.

Best regards,
André

Am 13.04.2015 um 08:57 schrieb Orgad Shaneh:
> On Mon, Apr 13, 2015 at 9:30 AM, Jürgen Hunold  > wrote:
>
> Hi André,
>
> Am Montag, 13. April 2015, 08:18:29 schrieb André Hartmann:
>  > Hi,
> > But that's only true for Qt itself.
> >
> > Creator has a much simpler workflow:
>
> So why does
>
> 
> https://codereview.qt-project.org/#/q/status:open+project:qt-creator/qt-creator,n,z
>
> show a lot of activity?
>
>
> He referred to the branching scheme, not to the gerrit workflow itself.
>
> > * new features go to master
> > * Bug fixes go to the latest stable branch or to master,
> >depending on the importancy and technical risk
> >
> > So just push your new plugins to master.
>
> And do this one needs the necessary karma :-)
>
> I think we better have the new code reviewed and approved first.
>
>
> You don't really have a choice ;-).
>
> André meant pushing to refs/for/master, not directly to master.
>
> - Orgad
>
>
> ___
> Qt-creator mailing list
> Qt-creator@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator
>


-- 
Best regards / Mit freundlichen Grüßen
André Hartmann, Dipl.-Ing. (FH)
Software Project Manager

iseg Spezialelektronik GmbH |  phone: ++49 (0)351 26996-43
Bautzner Landstr. 23|  fax:   ++49 (0)351 26996-21
D-01454 Radeberg / Rossendorf   |  web:   www.iseg-hv.com

Geschäftsführer / Managing director: Dr. F. Gleisberg, Dr. J. Pöthig
Amtsgericht / Lower district court: Dresden HRB 16250
Ust.-Id.-Nr. / VAT-ID: DE812508942

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte
sofort den Absender und vernichten Sie diese Mail.
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser
Mail ist nicht gestattet.

This e-mail may contain confidential and/or privileged information.
If you are not the intended recipient (or have received this e-mail
in error) please notify the sender immediately and delete this e-mail.
Any unauthorized copying, disclosure or distribution of the material
in this e-mail is strictly forbidden.
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Orgad Shaneh]

On Mon, Apr 13, 2015 at 9:30 AM, Jürgen Hunold  wrote:

> Hi André,
>
> Am Montag, 13. April 2015, 08:18:29 schrieb André Hartmann:
> > Hi,
> > But that's only true for Qt itself.
> >
> > Creator has a much simpler workflow:
>
> So why does
>
>
> https://codereview.qt-project.org/#/q/status:open+project:qt-creator/qt-creator,n,z
>
> show a lot of activity?
>

He referred to the branching scheme, not to the gerrit workflow itself.

> * new features go to master
> > * Bug fixes go to the latest stable branch or to master,
> >depending on the importancy and technical risk
> >
> > So just push your new plugins to master.
>
> And do this one needs the necessary karma :-)
>
> I think we better have the new code reviewed and approved first.
>

You don't really have a choice ;-).

André meant pushing to refs/for/master, not directly to master.

- Orgad
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Jürgen Hunold]

Hi André,

Am Montag, 13. April 2015, 08:18:29 schrieb André Hartmann:
> Hi,
> But that's only true for Qt itself.
>
> Creator has a much simpler workflow:

So why does 

https://codereview.qt-project.org/#/q/status:open+project:qt-creator/qt-creator,n,z

show a lot of activity?

> * new features go to master
> * Bug fixes go to the latest stable branch or to master,
>depending on the importancy and technical risk
> 
> So just push your new plugins to master.

And do this one needs the necessary karma :-)

I think we better have the new code reviewed and approved first.

Yours,

Jürgen
-- 
* Dipl.-Math. Jürgen Hunold  ! 
* voice: ++49 4257 300   ! Fährstraße 1
* fax  : ++49 4257 300   ! 31609 Balge/Sebbenhausen
* jhun...@gmx.eu ! Germany
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[André Hartmann]

Hi,

> BTW, there are more Wiki pages that you need to crunch:
> https://wiki.qt.io/Branch
> https://wiki.qt.io/Branch_Guidelines
> The latter explains recommendations and caveats of possible
> development workflows.

But that's only true for Qt itself.

Creator has a much simpler workflow:

* new features go to master
* Bug fixes go to the latest stable branch or to master,
   depending on the importancy and technical risk

So just push your new plugins to master.

Best regards,
André


___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] QtCreator plugin contribution

[Mateusz Loskot]

On 10 April 2015 at 21:16, Mateusz Loskot  wrote:
> On 10 April 2015 at 20:56, Сергей Левин  wrote:
>>
>> I'm developed a little plugin and I want to contribute it to Qt
>> Creator. I have read this article
>> https://wiki.qt.io/Qt_Creator_Plug-in_Contribution_Guide, but it stays
>> unclear for me where to start to contribute plugin.
>
> All Qt Creator code submissions need go through gerrit, see
> codereview.qt-project.org).
>
> I'm in similar position and preparing to contribute my plugin, see my thread:
> http://lists.qt-project.org/pipermail/qt-creator/2015-February/004436.html
> and linked GitHub issue
> https://github.com/mloskot/qt-creator-plugin-boostbuild/issues/13
> for more details.

BTW, there are more Wiki pages that you need to crunch:
https://wiki.qt.io/Branch
https://wiki.qt.io/Branch_Guidelines
The latter explains recommendations and caveats of possible
development workflows.

Best regards,
-- 
Mateusz  Loskot, http://mateusz.loskot.net
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator