Re: Problem setting up RB on Ubunto/lighttpd ....
Hi Sassan ! After You create ReviewBoard instance using rb-site search in conf directory "lighttpd.conf". Copy it to /etc/lighttpd/conf-available as 11-reviewboard.conf and then symlink it to /etc/lighttpd/conf-enabled ln -s /etc/lighttpd/conf-available/11-reviewboard.conf /etc/lighttpd/ conf-enabled/11-reviewboard.conf After that restart lighttpd and all should work. P.S. Which version of Ubuntu You use? In newest Ubuntu there is Python 2.6. I'am not sure is ReviewBoard work on 2.6 (but I don't check). I was installed ReviewBoard on Python2.5. If 2.6 fail I can write how to do it :] Greetings from Poland -- Jan Koprowski On Feb 4, 2:08 am, Sassan wrote: > Hi everyone, > > I have pretty much successfully followed the instruction to install RB > on my virtual Ubunto machine with lighttpd as described in : > > http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ > > and created an RB site apprently with no errors using the instructions > (and values) set out in: > > http://www.reviewboard.org/docs/manual/dev/admin/sites/creating-sites... > > But before setting up my git repositories I wanted to see if Review > Board was up. > > I was expecting to see the Review Board initial login page. > > But pointing my browser tohttp://localhost/all I get is the original > lighttpd placeholder page. > > The one stating that no sites have been set up by the owner yet and to > come back later. > > I am not sure what I have been missing here? > > Is there anyone out there who has successfully started Review Board on > an Ubunto/lighttpd ? > > I'll appreciate your help, > > Thanks, > > Sassan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem setting up RB on Ubunto/lighttpd ....
Ok :) Here it solution. In Your ReviewBoard's conf directory You find lighttpd.conf Copy this file to /etc/lighttpd/conf-available (i change name to 11- reviewboard.conf) and symlink it to On Feb 4, 2:08 am, Sassan wrote: > Hi everyone, > > I have pretty much successfully followed the instruction to install RB > on my virtual Ubunto machine with lighttpd as described in : > > http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ > > and created an RB site apprently with no errors using the instructions > (and values) set out in: > > http://www.reviewboard.org/docs/manual/dev/admin/sites/creating-sites... > > But before setting up my git repositories I wanted to see if Review > Board was up. > > I was expecting to see the Review Board initial login page. > > But pointing my browser tohttp://localhost/all I get is the original > lighttpd placeholder page. > > The one stating that no sites have been set up by the owner yet and to > come back later. > > I am not sure what I have been missing here? > > Is there anyone out there who has successfully started Review Board on > an Ubunto/lighttpd ? > > I'll appreciate your help, > > Thanks, > > Sassan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB review Process Automation
Hi Kunjal, Perforce has the "p4 trigger"( http://www.perforce.com/perforce/doc.current/manuals/cmdref/triggers.html) mechanism which can be used to run a script post-submission. So if you want to close the review automatically you could run a script, which would do the HTTP POST to /api/json/reviewrequests//close/submitted/ as suggested by Christian. Also if you use "change-commit" or "change-submit" triggers you would get the original changelist numbers itself, before they are changed by Perforce during submission. We currently use the "change-submit" trigger to check the whether the changelist was "shipped" before it can be submitted into Perforce. Roshan Pius On Thu, Feb 4, 2010 at 2:40 AM, Christian Hammond wrote: > It is available today. You can do an HTTP POST to > /api/json/reviewrequests//close/submitted/ > > So Kunjal, basically you can write a post-commit hook that automatically > closes the review request. It will require that there's some indication as > to which review request the change is associated with. In Perforce, the > change numbers will themselves change upon submit, but if you knew the > previous change number that was posted to Review Board, you could use the > /api/json/reviewrequests/repository//changenum// > call to get the info for the review request, pull the ID out of there, and > then use that to call the /close/submitted/ call above. > > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark wrote: > >> Kunjal wrote: >> >>> Once the Review is done, user has to make Review as Close->Submitted >>> eles reviewers dashboard will still have the review. >>> >>> We enforce this process on developers and developers are saying that >>> this is one extra step. >>> >>> I was thinking whether it is possible to close the review >>> automatically? >>> >>> For example, for given Review, if the shipit_count is more then zero >>> then review is approved and we can close it. >>> >>> Is there any way to do it programatically? >>> >>> >> >> IMHO having shiptit mark as submitted would not be useful. Where we have >> RB reployed "Submitted" means the code was submitted into source code >> control (which is a semi-manual process). What we'd find useful would be a >> json call (possibly called from postreview) to mark the review as submitted >> (if this is already present please let me know). >> >> Chris >> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
About Installation of Reviewboard
Hi, all. The reviewboard installation process is to run 'rb-site install ' , Then we will specify some parameters like 'Domain Name' 'DataBase Type' 'Cache Type' 'Webserver' ... . I want to konw, If I had finished the RB install and had used it for some time, Can I change those settings? and How? For example, Our installation did not install memcache, So we specify the 'Cache Type' as file type. But when We had used it for some time, We want speed up accession, So we used memcache, We want to change this settings then. Other settings, If we want change webserver, change database , and so on. How to do this, Do we need to reinstall the rb-site? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Restricting access to "Ship It" checkbox
In general we've avoided adding this sort of permissions and policy, since it adds a lot of UI complexity for what is essentially a sociology problem. We have a bug open requesting some sort of general policy set-up (while we try to figure out what that means), but I'd recommend that this is better enforced through training and management. If people are submitting code without the proper authorizations, then a check-box isn't going to stop them. -David On Wed, Feb 3, 2010 at 5:00 PM, Jennifer wrote: > > Is there a way to restrict access to the ship it checkbox? We want > everyone to be able to post reviews, but only allow authorized people > to check "ship it". I tried making an auth group, but could find no > permission for the "ship it" checkbox. > > We have a list of projects and which team leaders are allowed to > approve code changes for that project. The problem is that even > though we tell team members not to check the box, they do anyways, > then the submitter will check in his code. I know reviewboard does > not stop checkins, but we would like to stop unauthorized people from > checking the "ship it" checkbox. > > thanks, > > Jen > > PS thanks to everyone who is working on reviewboard. It has helped > our codebase immensely. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Restricting access to "Ship It" checkbox
Is there a way to restrict access to the ship it checkbox? We want everyone to be able to post reviews, but only allow authorized people to check "ship it". I tried making an auth group, but could find no permission for the "ship it" checkbox. We have a list of projects and which team leaders are allowed to approve code changes for that project. The problem is that even though we tell team members not to check the box, they do anyways, then the submitter will check in his code. I know reviewboard does not stop checkins, but we would like to stop unauthorized people from checking the "ship it" checkbox. thanks, Jen PS thanks to everyone who is working on reviewboard. It has helped our codebase immensely. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Problem setting up RB on Ubunto/lighttpd ....
Hi everyone, I have pretty much successfully followed the instruction to install RB on my virtual Ubunto machine with lighttpd as described in : http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ and created an RB site apprently with no errors using the instructions (and values) set out in: http://www.reviewboard.org/docs/manual/dev/admin/sites/creating-sites/#creatingsites But before setting up my git repositories I wanted to see if Review Board was up. I was expecting to see the Review Board initial login page. But pointing my browser to http://localhost/ all I get is the original lighttpd placeholder page. The one stating that no sites have been set up by the owner yet and to come back later. I am not sure what I have been missing here? Is there anyone out there who has successfully started Review Board on an Ubunto/lighttpd ? I'll appreciate your help, Thanks, Sassan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Git patchsets
Reviewboard is a great tool, but it's lacking in a couple places regarding Git. Right now, ReviewBoard only supports submitting a single patch generated from the head of a particular branch. In post-review, this means that it performs a 'git diff HEAD origin/master' and transmits the output to the server as a single patch. Unfortunately, this is not how git is used in many cases. Many developers (myself included) prefer to work in patchsets, where individual steps can be developed and tested separately. These patches will build on each other, and should be individually reviewable, but may not have any value separate from each other. What I am proposing is that is should be possible for a single review request to contain multiple, ordered patches. When performing a review, it should be possible to select any of these patches individually and review them. Behind the scenes, I envision reviewboard creating a Review-specific branch onto which it applies each of the patches in the set, so context information will be correctly available during the review. With this functionality in place, it would then be possible to modify the JSON API (and the post-review tool) to enable submitting a branch, complete with commit attribution and comments. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py to get to this point.
If I don't do that I get different set of errors.
Thanks for your help.
Kunjal
On Feb 2, 3:56 pm, Christian Hammond wrote:
> Hmm okay, well at least it's talking to the server now. If you check your
> server log file, you should be able to see some exception information that
> says what's generated that 500 error. If not, then temporarily setting DEBUG
> = True in your site's conf/settings_local.py will display that exception
> information in place of the 500 error. Either way, that should help to
> figure out where it's failing and hopefully what's going wrong.
>
> One thing that could be causing it, though, is your Review Board repository
> entry for your Git repository. Do you have it just referencing your remote
> git:// URL, or is Path actually pointing to a local Git checkout? There's no
> concept of grabbing individual files from a remote Git repository, so you
> need either a local clone accessible by Review Board, or if you're using the
> 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> raw file from a Git web front-end such as cgit or gitweb.
>
> Unless the Git guys someday extend the protocol to fetch an individual file
> by revision from an upstream repository without a local checkout, this is
> the best we can do.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Feb 2, 2010 at 3:20 PM, Kunjal wrote:
> > If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
> > It looks like the URL is correct now. But I am still getting error.
> > mob-rb-test{kaparikh}22: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index donut
> > >>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
> > /home/kaparikh/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> Attempting to create review request for None
> > _make_url: path = api/json/reviewrequests/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
> > {'repository_path': 'git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
> > >>> Review request created
> > >>> Uploading diff, size: 867
> > _make_url: path = api/json/reviewrequests/30/diff/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/:
> > {}
> > >>> > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
>
> > http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
> >
> > 500 - Internal Server Error | Review Board
> >
> >
> > Something broke! (Error 500)
> >
> > It appears something broke when you tried to go to here. This is
> > either
> > a bug in Review Board or a server configuration error. Please
> > report
> > this to your administrator.
> >
> >
> >
>
> > Unable to access
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/.
> > The host path may be invalid
> > HTTP Error 500: Internal Server Error
>
> > ####
>
> > Also, I get up to above error by replacing master branch to donut in
> > the post-review.py script.
> > If I do not change this, I get different error which is like:
>
> > [[
>
> > mob-rb-test{kaparikh}30: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index master
> > Failed to execute command: ['git', 'diff', '--no-color', '--full-
> > index', 'master']
> > fatal: ambiguous argument 'master': unknown revision or path not in
> > the working tree.
> > Use '--' to separate paths from revisions
>
> >
Re: ReviewBoard Error while posting review for GIT
Thanks..
I read few post and many people are seeing similar error like mine but
they are talking about installting pysvn.
Does that apply to me as well for GIT?
-Kunjal
On Feb 2, 3:56 pm, Christian Hammond wrote:
> Hmm okay, well at least it's talking to the server now. If you check your
> server log file, you should be able to see some exception information that
> says what's generated that 500 error. If not, then temporarily setting DEBUG
> = True in your site's conf/settings_local.py will display that exception
> information in place of the 500 error. Either way, that should help to
> figure out where it's failing and hopefully what's going wrong.
>
> One thing that could be causing it, though, is your Review Board repository
> entry for your Git repository. Do you have it just referencing your remote
> git:// URL, or is Path actually pointing to a local Git checkout? There's no
> concept of grabbing individual files from a remote Git repository, so you
> need either a local clone accessible by Review Board, or if you're using the
> 1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
> raw file from a Git web front-end such as cgit or gitweb.
>
> Unless the Git guys someday extend the protocol to fetch an individual file
> by revision from an upstream repository without a local checkout, this is
> the best we can do.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Feb 2, 2010 at 3:20 PM, Kunjal wrote:
> > If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
> > It looks like the URL is correct now. But I am still getting error.
> > mob-rb-test{kaparikh}22: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index donut
> > >>> Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
> > /home/kaparikh/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> Attempting to create review request for None
> > _make_url: path = api/json/reviewrequests/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
> > {'repository_path': 'git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
> > >>> Review request created
> > >>> Uploading diff, size: 867
> > _make_url: path = api/json/reviewrequests/30/diff/new/
> > _make_url:app = /
> > _make_url: joined URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > _make_url: Resulting URL =
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
> > >>> HTTP POSTing to
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/:
> > {}
> > >>> > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
>
> > http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
> >
> > 500 - Internal Server Error | Review Board
> >
> >
> > Something broke! (Error 500)
> >
> > It appears something broke when you tried to go to here. This is
> > either
> > a bug in Review Board or a server configuration error. Please
> > report
> > this to your administrator.
> >
> >
> >
>
> > Unable to access
> >http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/.
> > The host path may be invalid
> > HTTP Error 500: Internal Server Error
>
> > ####
>
> > Also, I get up to above error by replacing master branch to donut in
> > the post-review.py script.
> > If I do not change this, I get different error which is like:
>
> > [[
>
> > mob-rb-test{kaparikh}30: postreview.py -d
> > >>> svn info
> > >>> git rev-parse --git-dir
> > >>> git svn info
> > >>> git svn --version
> > >>> git config --get svn-remote.svn.url
> > >>> git remote show origin
> > >>> repository info: Path: git://
> > mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
> > Supports changesets: False
> > >>> git config --get reviewboard.url
> > >>> git diff --no-color --full-index master
> > Failed to execute command: ['git', 'diff', '--no-color', '--full-
> > index', 'master']
> > fatal: ambiguous argument 'master': unknown revision or path not in
> > the working tree.
> > Use '--' to separate paths from revisions
>
> > ]]
>
> > On Jan 28, 3:05 pm, Christian Hammond wrote:
> > > You shouldn't need to set REVIEWBOARD_URL in post
Re: Unable to find a Review Board server for this source code tree
Not sure if you solved this yet, but basically, you want a .reviewboardrc file that points to the server. There's some information on setting this up here: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#reviewboardrc Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 4:58 AM, Stodge wrote: > I read a few posts with this error but none seem to help. > > My Mercurial repository is at http://localhost/hg/indigo. I know that > works 100%. > > My ReviewBoard install is at http://localhost:9900/reviews and I know > that works 100%. > > My Mercurial repository is located on disk in /var/www/sites/indigo, > again I know that works. > > If I do: > > cd /var/www/sites/indigo > post-review -d > >>> svn info > >>> git rev-parse --git-dir > >>> hg root > >>> hg svn info > >>> repository info: Path: /home/mike/repositories/hg/indigo, Base path: , > Supports changesets: False > Unable to find a Review Board server for this source code tree. > > If I do: > > post-review --repository-url=http://localhost/hg/indigo --revision- > range=1 --username=mike -d > >>> svn info http://localhost/hg/indigo > >>> git rev-parse --git-dir > >>> hg root > >>> hg svn info > >>> repository info: Path: /home/mike/repositories/hg/indigo, Base path: , > Supports changesets: False > Unable to find a Review Board server for this source code tree. > > There is a valid Mercurial repository in /home/mike/repositories/hg/ > indigo, but it's not the one I'm interested in and I've no idea why > it's getting picked up. > > Any ideas what I'm doing wrong? Thanks > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: code 206 with Mercurial
The repository path that Mercurial reports must be exactly what is
configured on the Review Board server, character-by-character, in either
Path or Mirror Path. We don't (yet) have any fuzzy matching for this.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Feb 3, 2010 at 5:16 AM, Stodge wrote:
> I'm trying to get Review Board working with a local Mercurial
> repository. My hg repository is:
>
> http://localhost/hg/indigo
>
> and it's on disk at /var/www/sites/indigo
>
> So I do:
>
> cd /var/www/sites/indigo
>
> post-review --repository-url=http://localhost/hg/indigo --revision-
> range=1:2 --username=admin -d
> >>> svn info http://localhost/hg/indigo
> >>> git rev-parse --git-dir
> >>> hg root
> >>> hg svn info
> >>> repository info: Path: /home/mike/repositories/hg/indigo, Base path: ,
> Supports changesets: False
> >>> hg diff -r 1 -r 2
> >>> Looking for 'localhost /reviews/' cookie in
> /home/mike/.post-review-cookies.txt
> >>> Cookie file loaded, but no cookie for this server
> ==> Review Board Login Required
> Enter username and password for Review Board at
> http://localhost:9900/reviews/
> Password:
> >>> Logging in with username "admin"
> >>> HTTP POSTing to http://localhost:9900/reviews/api/json/accounts/login/:
> {'username': 'admin', 'password': '**'}
> >>> Logged in.
> >>> Attempting to create review request for None
> >>> HTTP POSTing to
> http://localhost:9900/reviews/api/json/reviewrequests/new/:
> {'repository_path': '/home/mike/repositories/hg/indigo'}
> Error creating review request: The repository path specified is not in
> the list of known repositories (code 206)
>
>
>
> For some reason it's picked up another repository in /home/mike/
> repositories/hg/indigo, but this isn't the one I want. Any ideas?
> Thanks
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RB review Process Automation
It is available today. You can do an HTTP POST to /api/json/reviewrequests//close/submitted/ So Kunjal, basically you can write a post-commit hook that automatically closes the review request. It will require that there's some indication as to which review request the change is associated with. In Perforce, the change numbers will themselves change upon submit, but if you knew the previous change number that was posted to Review Board, you could use the /api/json/reviewrequests/repository//changenum// call to get the info for the review request, pull the ID out of there, and then use that to call the /close/submitted/ call above. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark wrote: > Kunjal wrote: > >> Once the Review is done, user has to make Review as Close->Submitted >> eles reviewers dashboard will still have the review. >> >> We enforce this process on developers and developers are saying that >> this is one extra step. >> >> I was thinking whether it is possible to close the review >> automatically? >> >> For example, for given Review, if the shipit_count is more then zero >> then review is approved and we can close it. >> >> Is there any way to do it programatically? >> >> > > IMHO having shiptit mark as submitted would not be useful. Where we have RB > reployed "Submitted" means the code was submitted into source code control > (which is a semi-manual process). What we'd find useful would be a json call > (possibly called from postreview) to mark the review as submitted (if this > is already present please let me know). > > Chris > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Django auth backend vs. ReviewBoard custom auth
Hi Stephen, Review Board can use custom Django auth backends by specifying the full module path in the Custom Authentication section in General Settings in the administration UI. Review Board will use that auth backend as the primary and fall back on the built-in authentication for existing accounts (so that your administration account will still work if your auth backend is broken). You shouldn't need to modify any code to make this work. See http://www.reviewboard.org/docs/manual/dev/admin/admin-ui/authentication-settings/#custom-authentication-settings Note that in 1.0.x, these are in General Settings, but in the upcoming 1.5 release, they're in their own settings page. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 11:32 AM, Stephen Gallagher wrote: > I'm trying to adapt a Django authentication backend to work with > ReviewBoard (specifically > https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html) > > Is there a guide anywhere on how to convert a Django auth backend to a > ReviewBoard backend? Or a guide on how to properly use a Django auth > backend with ReviewBoard? > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Django auth backend vs. ReviewBoard custom auth
I'm trying to adapt a Django authentication backend to work with ReviewBoard (specifically https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html) Is there a guide anywhere on how to convert a Django auth backend to a ReviewBoard backend? Or a guide on how to properly use a Django auth backend with ReviewBoard? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB review Process Automation
Kunjal wrote: Once the Review is done, user has to make Review as Close->Submitted eles reviewers dashboard will still have the review. We enforce this process on developers and developers are saying that this is one extra step. I was thinking whether it is possible to close the review automatically? For example, for given Review, if the shipit_count is more then zero then review is approved and we can close it. Is there any way to do it programatically? IMHO having shiptit mark as submitted would not be useful. Where we have RB reployed "Submitted" means the code was submitted into source code control (which is a semi-manual process). What we'd find useful would be a json call (possibly called from postreview) to mark the review as submitted (if this is already present please let me know). Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: global name 'ClientError' is not defined
Looks like I may have forgotten to restart Apache.
On Feb 3, 9:47 am, Stodge wrote:
> I'm getting a ClientError when creating a review request for a remote
> SVN repository. I have the following versions:
>
> pysvn v1.6.1.0
> Python 2.5.2
>
> Is my version of pysvn too old? Or am I missing something else? Thanks
>
> post-review --repository-url=http://IP_ADDRESS/repos/support--
> revision-range=2:3 --username=admin -d>>> svn
> infohttp://IP_ADDRESS/repos/support
> >>> repository info: Path:http://IP_ADDRESS/repos/support, Base path: /,
> >>> Supports changesets: False
> >>> svn diff
> >>> --diff-cmd=diffhttp://IP_ADDRESS/repos/support/@2http://IP_ADDRESS/repos/support/@3
> >>> Looking for 'localhost /reviews/' cookie in
> >>> /home/mike/.post-review-cookies.txt
> >>> Cookie file loaded, but no cookie for this server
>
> ==> Review Board Login Required
> Enter username and password for Review Board athttp://localhost:9900/reviews/
> Password:>>> Logging in with username "admin"
> >>> HTTP POSTing
> >>> tohttp://localhost:9900/reviews/api/json/accounts/login/:{'username':
> >>> 'admin', 'password': '**'}
> >>> Logged in.
> >>> Attempting to create review request for None
> >>> HTTP GETting /api/json/repositories/
> >>> HTTP GETting /api/json/repositories/3/info/
> >>> repository info: Path:http://IP_ADDRESS/repos/support, Base path: /,
> >>> Supports changesets: False
> >>> HTTP POSTing
> >>> tohttp://localhost:9900/reviews/api/json/reviewrequests/new/:{'repository_path':
> >>> 'http://IP_ADDRESS/repos/support'}
> >>> Review request created
> >>> Uploading diff, size: 1401
> >>> HTTP POSTing
> >>> tohttp://localhost:9900/reviews/api/json/reviewrequests/8/diff/new/:{'basedir':
> >>> '/'}
>
> Error uploading diff: One or more fields had errors (105)>>> {'fields':
> {'path': ["global name 'ClientError' is not defined"]}, 'stat': 'fail',
> 'err': {'msg': 'One or more fields had errors', 'code': 105}}
>
> Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
RB review Process Automation
Chris, Once the Review is done, user has to make Review as Close->Submitted eles reviewers dashboard will still have the review. We enforce this process on developers and developers are saying that this is one extra step. I was thinking whether it is possible to close the review automatically? For example, for given Review, if the shipit_count is more then zero then review is approved and we can close it. Is there any way to do it programatically? Thanks Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Active Directory form is disabled
Hi ! How I can edit my ActiveDirectory settings? When I enter to this section i just get gray, disabled form. What modules needed? Greetings from Poland! -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
global name 'ClientError' is not defined
I'm getting a ClientError when creating a review request for a remote
SVN repository. I have the following versions:
pysvn v1.6.1.0
Python 2.5.2
Is my version of pysvn too old? Or am I missing something else? Thanks
post-review --repository-url=http://IP_ADDRESS/repos/support --
revision-range=2:3 --username=admin -d
>>> svn info http://IP_ADDRESS/repos/support
>>> repository info: Path: http://IP_ADDRESS/repos/support, Base path: /,
>>> Supports changesets: False
>>> svn diff --diff-cmd=diff http://IP_ADDRESS/repos/support/@2
>>> http://IP_ADDRESS/repos/support/@3
>>> Looking for 'localhost /reviews/' cookie in
>>> /home/mike/.post-review-cookies.txt
>>> Cookie file loaded, but no cookie for this server
==> Review Board Login Required
Enter username and password for Review Board at http://localhost:9900/reviews/
Password:
>>> Logging in with username "admin"
>>> HTTP POSTing to http://localhost:9900/reviews/api/json/accounts/login/:
>>> {'username': 'admin', 'password': '**'}
>>> Logged in.
>>> Attempting to create review request for None
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/3/info/
>>> repository info: Path: http://IP_ADDRESS/repos/support, Base path: /,
>>> Supports changesets: False
>>> HTTP POSTing to http://localhost:9900/reviews/api/json/reviewrequests/new/:
>>> {'repository_path': 'http://IP_ADDRESS/repos/support'}
>>> Review request created
>>> Uploading diff, size: 1401
>>> HTTP POSTing to
>>> http://localhost:9900/reviews/api/json/reviewrequests/8/diff/new/:
>>> {'basedir': '/'}
Error uploading diff: One or more fields had errors (105)
>>> {'fields': {'path': ["global name 'ClientError' is not defined"]}, 'stat':
>>> 'fail', 'err': {'msg': 'One or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
code 206 with Mercurial
I'm trying to get Review Board working with a local Mercurial
repository. My hg repository is:
http://localhost/hg/indigo
and it's on disk at /var/www/sites/indigo
So I do:
cd /var/www/sites/indigo
post-review --repository-url=http://localhost/hg/indigo --revision-
range=1:2 --username=admin -d
>>> svn info http://localhost/hg/indigo
>>> git rev-parse --git-dir
>>> hg root
>>> hg svn info
>>> repository info: Path: /home/mike/repositories/hg/indigo, Base path: ,
>>> Supports changesets: False
>>> hg diff -r 1 -r 2
>>> Looking for 'localhost /reviews/' cookie in
>>> /home/mike/.post-review-cookies.txt
>>> Cookie file loaded, but no cookie for this server
==> Review Board Login Required
Enter username and password for Review Board at http://localhost:9900/reviews/
Password:
>>> Logging in with username "admin"
>>> HTTP POSTing to http://localhost:9900/reviews/api/json/accounts/login/:
>>> {'username': 'admin', 'password': '**'}
>>> Logged in.
>>> Attempting to create review request for None
>>> HTTP POSTing to http://localhost:9900/reviews/api/json/reviewrequests/new/:
>>> {'repository_path': '/home/mike/repositories/hg/indigo'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
For some reason it's picked up another repository in /home/mike/
repositories/hg/indigo, but this isn't the one I want. Any ideas?
Thanks
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Unable to find a Review Board server for this source code tree
I read a few posts with this error but none seem to help. My Mercurial repository is at http://localhost/hg/indigo. I know that works 100%. My ReviewBoard install is at http://localhost:9900/reviews and I know that works 100%. My Mercurial repository is located on disk in /var/www/sites/indigo, again I know that works. If I do: cd /var/www/sites/indigo post-review -d >>> svn info >>> git rev-parse --git-dir >>> hg root >>> hg svn info >>> repository info: Path: /home/mike/repositories/hg/indigo, Base path: , >>> Supports changesets: False Unable to find a Review Board server for this source code tree. If I do: post-review --repository-url=http://localhost/hg/indigo --revision- range=1 --username=mike -d >>> svn info http://localhost/hg/indigo >>> git rev-parse --git-dir >>> hg root >>> hg svn info >>> repository info: Path: /home/mike/repositories/hg/indigo, Base path: , >>> Supports changesets: False Unable to find a Review Board server for this source code tree. There is a valid Mercurial repository in /home/mike/repositories/hg/ indigo, but it's not the one I'm interested in and I've no idea why it's getting picked up. Any ideas what I'm doing wrong? Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: CSS and media not loaded when run using rb-site manage / runserver?
Thanks - much appreciated! On Feb 3, 6:07 am, Christian Hammond wrote: > Hi Stodge, > > runserver is meant for development, and the development server doesn't by > default support any static media, such as CSS or images. Normally, it's best > for a real web server to handle this, as it'll be faster at it. > > To enable this, you'll need to modify your site's conf/settings_local.py and > set DEBUG = True. That will enable the code paths for serving static media > for development use. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Tue, Feb 2, 2010 at 7:12 AM, Stodge wrote: > > Ok dunce question of the day. I installed ReviewBoard onto my Fedora > > laptop. I just want to play around with it without configuring Apache > > for now so I'm just using: > > > rb-site manage /var/www/sites/reviews runserver 0.0.0.0:9900 > > > to start RB. However, none of the media or CSS are loaded. Now I'm > > still new to Django but I do understand the basics but I'm completely > > stumped as to why it's not loading the media or CSS. What am I missing > > here? Thanks > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: CSS and media not loaded when run using rb-site manage / runserver?
Hi Stodge, runserver is meant for development, and the development server doesn't by default support any static media, such as CSS or images. Normally, it's best for a real web server to handle this, as it'll be faster at it. To enable this, you'll need to modify your site's conf/settings_local.py and set DEBUG = True. That will enable the code paths for serving static media for development use. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Feb 2, 2010 at 7:12 AM, Stodge wrote: > Ok dunce question of the day. I installed ReviewBoard onto my Fedora > laptop. I just want to play around with it without configuring Apache > for now so I'm just using: > > rb-site manage /var/www/sites/reviews runserver 0.0.0.0:9900 > > to start RB. However, none of the media or CSS are loaded. Now I'm > still new to Django but I do understand the basics but I'm completely > stumped as to why it's not loading the media or CSS. What am I missing > here? Thanks > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
CSS and media not loaded when run using rb-site manage / runserver?
Ok dunce question of the day. I installed ReviewBoard onto my Fedora laptop. I just want to play around with it without configuring Apache for now so I'm just using: rb-site manage /var/www/sites/reviews runserver 0.0.0.0:9900 to start RB. However, none of the media or CSS are loaded. Now I'm still new to Django but I do understand the basics but I'm completely stumped as to why it's not loading the media or CSS. What am I missing here? Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: VHDL Syntax highlighting
Which version of python-pygments are you using? How did you find out that it supports VHDL syntax highlighting? The one I have on my machine (1.0.3) does not support VHDL. Onkar -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
