Re: RB, SVN, and AD

[Cathy Mullican]

I'll note that it would be helpful if there were any documentation about 
setting RB up with sqlite, beyond "Typically on development setups, SQLite 
is used for the database, as this allows for quick and easy database 
creation, backups, multiple versions, and deletions."

Running  ./contrib/internal/devserver.py informs me I need a settings file 
and points me at the template, which tells me I have to give an absolute 
path if I'm using SQLite...but nothing about how I'm supposed to set up 
that file, or whether it will be created automatically, or what. 

On Wednesday, July 6, 2016 at 6:04:44 PM UTC-7, Christian Hammond wrote:
>
> Hi Cathy,
>
> This is against the main MySQL database? If so, it might be because of the 
> mixed installs (production servers are meant to run off of a Review Board 
> site directory, which must be consistent in settings across all servers 
> using the DB, and installed packages rather than development trees).
>
> For Review Board development, you really do want to use SQLite and the 
> built-in development server. I know you're trying to keep things the same 
> as the production server, but it's not designed to be run against two very 
> different sorts of installs.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Wed, Jul 6, 2016 at 5:21 PM, Cathy Mullican  > wrote:
>
>> Well, I got through the first few errors (updated some symlinks and 
>> permissions), but it's still giving me a 500 when I try to load the site. 
>> Nothing in the RB log file except " - INFO -  - Reloading logging 
>> settings"; nothing in the apache error or access logs, either., Not sure 
>> where to go from here.
>>
>>
>> On Wed, Jul 6, 2016 at 2:22 PM, Cathy Mullican > > wrote:
>>
>>> Woot; that got me fun new errors in the RB error log that I may actually 
>>> be able to do something about, but probably not until late today or 
>>> tomorrow (meetings). But the install and upgrade processes succeeded 
>>> this time. Progress!
>>>
>>> On Wed, Jul 6, 2016 at 1:42 PM, Christian Hammond <
>>> chri...@beanbaginc.com > wrote:
>>>
 For the mysql_config issue, what you'll need is the development package 
 for MySQL.

 Try:

 apt-get build-dep python-mysqldb

 This will install all dependencies needed to build that package: Python 
 development headers, MySQL development headers, etc.

 Then the pip install should work.

 Christian

 -- 
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

 On Wed, Jul 6, 2016 at 10:18 AM, Cathy Mullican  wrote:

> As I said, I followed the directions to set up a virtual environment:
>
> pip install virtualenv
> virtualenv ~/envs/rb_krb
> source ~/envs/rb_krb/bin/activate
> install any missing dependencies (just gettext, IIRC, but it's been a 
> few days now, and I don't see it in my command history)
> git clone git://github.com/djblets/djblets.git
> cd djblets
> python setup.py develop
> pip install -r dev-requirements.txt
> git clone git://github.com/reviewboard/reviewboard.git
> cd reviewboard
> python setup.py develop
> python ./contrib/internal/prepare-dev.py
> git clone git://github.com/reviewboard/rbtools.git
> python setup.py develop
> python setup.py install
>
> After making the change I'm trying to test, I tried to upgrade RB from 
> within the rb_krb environment with
> easy_install -U ReviewBoard 
> which did not give an error, then tried to upgrade the existing site 
> with
>  /root/envs/rb_krb/bin/rb-site upgrade /var/www/rb.revshare.int
> and saw the error for the first time.  I then, after googling, ran 
> pip install mysql-python
> within the virtual environment
> but it fails with
>  EnvironmentError: mysql_config not found
> There does not, in fact, seem to be a mysql_config file anywhere on 
> the system, but the site is working with mysql just fine before I started 
> trying to dive into the code. :)
> I also tried 
> apt-get install python-mysqldb
> which tells me python-mysqldb is already the newest version.
>
> While I would like this to be a production system, unless I can get 
> the repo added, it's useless, so it's functionally a test / dev system 
> for 
> now.
>
> On Tue, Jul 5, 2016 at 8:28 PM, Christian Hammond <
> chri...@beanbaginc.com > wrote:
>
>> Hi Cathy,
>>
>> Can you show me how you tried installing the package, and how the dev 
>> environment is set up?
>>
>> As for the site and DB, Review Board expects to know where on the 
>> file system its associated site lives (in order to access 

Re: RB, SVN, and AD

[Cathy Mullican]

I'll try it, but there's only one site and one database, on one server, so 
I don't really see how consistency is an issue here.  This was supposed to 
be a nice simple tool to introduce code reviews for the team, and instead, 
it's become something of a nightmare.  The only thing is, I don't see any 
other tools that look like they'd work better, so I'm continuing to try to 
make this work; I really would like to add a more formal review step to the 
process.

On Wednesday, July 6, 2016 at 6:04:44 PM UTC-7, Christian Hammond wrote:
>
> Hi Cathy,
>
> This is against the main MySQL database? If so, it might be because of the 
> mixed installs (production servers are meant to run off of a Review Board 
> site directory, which must be consistent in settings across all servers 
> using the DB, and installed packages rather than development trees).
>
> For Review Board development, you really do want to use SQLite and the 
> built-in development server. I know you're trying to keep things the same 
> as the production server, but it's not designed to be run against two very 
> different sorts of installs.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Wed, Jul 6, 2016 at 5:21 PM, Cathy Mullican  > wrote:
>
>> Well, I got through the first few errors (updated some symlinks and 
>> permissions), but it's still giving me a 500 when I try to load the site. 
>> Nothing in the RB log file except " - INFO -  - Reloading logging 
>> settings"; nothing in the apache error or access logs, either., Not sure 
>> where to go from here.
>>
>>
>> On Wed, Jul 6, 2016 at 2:22 PM, Cathy Mullican > > wrote:
>>
>>> Woot; that got me fun new errors in the RB error log that I may actually 
>>> be able to do something about, but probably not until late today or 
>>> tomorrow (meetings). But the install and upgrade processes succeeded 
>>> this time. Progress!
>>>
>>> On Wed, Jul 6, 2016 at 1:42 PM, Christian Hammond <
>>> chri...@beanbaginc.com > wrote:
>>>
 For the mysql_config issue, what you'll need is the development package 
 for MySQL.

 Try:

 apt-get build-dep python-mysqldb

 This will install all dependencies needed to build that package: Python 
 development headers, MySQL development headers, etc.

 Then the pip install should work.

 Christian

 -- 
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

 On Wed, Jul 6, 2016 at 10:18 AM, Cathy Mullican  wrote:

> As I said, I followed the directions to set up a virtual environment:
>
> pip install virtualenv
> virtualenv ~/envs/rb_krb
> source ~/envs/rb_krb/bin/activate
> install any missing dependencies (just gettext, IIRC, but it's been a 
> few days now, and I don't see it in my command history)
> git clone git://github.com/djblets/djblets.git
> cd djblets
> python setup.py develop
> pip install -r dev-requirements.txt
> git clone git://github.com/reviewboard/reviewboard.git
> cd reviewboard
> python setup.py develop
> python ./contrib/internal/prepare-dev.py
> git clone git://github.com/reviewboard/rbtools.git
> python setup.py develop
> python setup.py install
>
> After making the change I'm trying to test, I tried to upgrade RB from 
> within the rb_krb environment with
> easy_install -U ReviewBoard 
> which did not give an error, then tried to upgrade the existing site 
> with
>  /root/envs/rb_krb/bin/rb-site upgrade /var/www/rb.revshare.int
> and saw the error for the first time.  I then, after googling, ran 
> pip install mysql-python
> within the virtual environment
> but it fails with
>  EnvironmentError: mysql_config not found
> There does not, in fact, seem to be a mysql_config file anywhere on 
> the system, but the site is working with mysql just fine before I started 
> trying to dive into the code. :)
> I also tried 
> apt-get install python-mysqldb
> which tells me python-mysqldb is already the newest version.
>
> While I would like this to be a production system, unless I can get 
> the repo added, it's useless, so it's functionally a test / dev system 
> for 
> now.
>
> On Tue, Jul 5, 2016 at 8:28 PM, Christian Hammond <
> chri...@beanbaginc.com > wrote:
>
>> Hi Cathy,
>>
>> Can you show me how you tried installing the package, and how the dev 
>> environment is set up?
>>
>> As for the site and DB, Review Board expects to know where on the 
>> file system its associated site lives (in order to access local data, 
>> media 
>> files, logs, configuration, etc.), and if you set up a second site in 

Re: API to integrate with other source code repositories?

[lams lam]

Hi Chris,

Thanks for the detailed information, we will give it a try. 

Our system is solely for in-house usage and won't be available for use 
externally. Thanks.

On Thursday, June 30, 2016 at 1:37:45 PM UTC-7, Christian Hammond wrote:
>
> Hi,
>
> We don't have a full guide up anywhere, but you can get started by looking 
> at the source code for our existing repository integrations. We call these 
> SCMTools.
>
>
> https://github.com/reviewboard/reviewboard/tree/release-2.5.x/reviewboard/scmtools
>
> In there you'll see git.py, cvs.py, etc. Each will define a class that 
> implements a handful of functions (see core.py for the base class).
>
> At a minimum, you'll need to implement:
>
> * get_file()
> * file_exists()
> * parse_diff_revision()
> * get_fields()
>
> You'll need to package this as a Python package with an Entrypoint (a 
> mechanism for registration for hooks into code) to register this SCMTool. 
> See the "reviewboard.scmtools" part in 
> https://github.com/reviewboard/reviewboard/blob/release-2.5.x/setup.py
>
> Most source code management services don't provide diffs that contain 
> enough information to properly identify a file. There is *no* standard for 
> this in diffs. You will more than likely need to write a subclass of 
> DiffParser to fetch whatever information may be in those diffs, assuming 
> the native diffs contain sufficient information (a file path and a 
> revision). If they don't, you'll also need to write a generator for diff 
> files. You can write this as a plugin to RBTools.
>
> If your system is custom-built in-house, there are some things we can 
> suggest for the diffs. I'd also be interested in hearing more about it (is 
> this a product you're developing, or intended solely for in-house work?).
>
> The reviewboard-dev list would be a good place for further discussion on 
> this, as there are other developers who pay attention to that list who can 
> also provide assistance.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Wed, Jun 29, 2016 at 10:52 AM, lams lam  > wrote:
>
>> Hi All,
>>
>> Is there an API/documenation to integrate review board with additional 
>> source code repositories? We have an in-house built version control system 
>> and would like to use review board with it. Appreciate any information on 
>> this.
>>
>>
>> Thanks.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Using gitlab integration with self-signed SSL certificate

[udam . dewaraja]

This is a temporary hack but I'm disabling all SSL cert validation by doing:

ssl._create_default_https_context = ssl._create_unverified_context

inside the gitlab.py (doesn't really matter where we do this i guess).

I'm on the latest RB 2.5.6.1 version using Python 2.7.10.

Thanks!

On Wednesday, July 6, 2016 at 11:37:31 PM UTC-7, Christian Hammond wrote:
>
> Hi,
>
> Can you show me the code you've used to skip over it, and let me know the 
> version of Python you're using?
>
> Also, what version of Review Board?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Wed, Jul 6, 2016 at 11:06 PM,  
> wrote:
>
>> Hello,
>>
>> I switched to using the gitlab integration on ReviewBoard. Previously, I 
>> was using a custom git repository setup on the local machine where I was 
>> running a crontab to peridically update the local repos.
>>
>> ReviewBoard/Python was not happy with the self-signed cert. For now, I've 
>> added some code in the reviewboard source to skip the ssl verification. 
>> Wondering if there's a better way to configure this in ReviewBoard so that 
>> when I upgrade RB, I won't have to keep disabling the SSL verification.
>>
>> Thanks!
>>  
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

ReviewBot: Multiple Tools Enabled Issue and ReviewBot 0.3alpha?

[Jerry Kotas]

I am running ReviewBoard 2.5.6.1 from the BitNami Package 2.0.15. I 
installed ReviewBot 0.2alpha. The bot runs perfectly fine when I only have 
one tool enabled. When I run 2 tools, however, the second tools just keeps 
posting on the request. I found the issue to be with the celery queue. Here 
is a snippet of the log file from celery.

[2016-07-06 10:54:30,076: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Tool execution completed successfully
[2016-07-06 10:54:30,076: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Publishing review
[2016-07-06 10:54:33,525: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Review completed successfully
[2016-07-06 10:54:33,539: INFO/MainProcess] Received task: 
reviewbot.tasks.ProcessReviewRequest[22c1e163-ef75-445c-9623-a33be90da746]
[2016-07-06 10:54:33,539: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Request to execute review tool 'cppcheck' for 
http://loggerhead4:8080/reviewboard/
[2016-07-06 10:54:33,539: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Initializing RB API
[2016-07-06 10:54:33,539: INFO/MainProcess] Task 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72] 
succeeded in 205.29952s: True
[2016-07-06 10:54:33,572: CRITICAL/MainProcess] Couldn't ack 1, 
reason:error(10054, 'An existing connection was forcibly closed by the 
remote host')
Traceback (most recent call last):
  File 
"C:\BitNami\reviewboard-2.0.15-0\python\lib\site-packages\kombu-3.0.35-py2.7.egg\kombu\message.py",
 
line 93, in ack_log_error
self.ack()
  File 
"C:\BitNami\reviewboard-2.0.15-0\python\lib\site-packages\kombu-3.0.35-py2.7.egg\kombu\message.py",
 
line 88, in ack
self.channel.basic_ack(self.delivery_tag)
  File 
"C:\BitNami\reviewboard-2.0.15-0\python\lib\site-packages\amqp-1.4.9-py2.7.egg\amqp\channel.py",
 
line 1584, in basic_ack
self._send_method((60, 80), args)
  File 
"C:\BitNami\reviewboard-2.0.15-0\python\lib\site-packages\amqp-1.4.9-py2.7.egg\amqp\abstract_channel.py",
 
line 56, in _send_method
self.channel_id, method_sig, args, content,
  File 
"C:\BitNami\reviewboard-2.0.15-0\python\lib\site-packages\amqp-1.4.9-py2.7.egg\amqp\method_framing.py",
 
line 221, in write_method
write_frame(1, channel, payload)
  File 
"C:\BitNami\reviewboard-2.0.15-0\python\lib\site-packages\amqp-1.4.9-py2.7.egg\amqp\transport.py",
 
line 182, in write_frame
frame_type, channel, size, payload, 0xce,
  File "C:\BitNami\reviewboard-2.0.15-0\python\lib\socket.py", line 224, in 
meth
return getattr(self._sock,name)(*args)
error: [Errno 10054] An existing connection was forcibly closed by the 
remote host
[2016-07-06 10:54:34,601: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Loading requested tool 'cppcheck'
[2016-07-06 10:54:34,601: INFO/Worker-1] 
reviewbot.tasks.ProcessReviewRequest[ef22f626-a315-4b8f-8502-547b06b71c72]: 
Initializing review

The tool execution that finished in the first line was cpp check. This is 
the second tool. The first tool completed with out a problem. Celery then 
load cpp check again and this loop continues for what looks like a random 
amount of iterations.

I fixed by modifying the reviewbot source code. In the 
file ReviewBot\bot\reviewbot\celery.py, I added the two lines shown below.

from __future__ import absolute_import

import logging
import pkg_resources

from celery import Celery
from kombu import Exchange, Queue


celery = Celery('reviewbot.celery', include=['reviewbot.tasks'])

celery.conf.CELERY_ACKS_LATE = True# Added this
celery.conf.CELERYD_PREFETCH_MULTIPLIER = 1# and this

default_exchange = Exchange('celery', type='direct')
celery.conf.CELERY_QUEUES = [
Queue('celery', default_exchange, routing_key='celery'),
]
...

The reason I'm writing this is to ask how ReviewBoard has they're ReviewBot 
setup. When I have two tools enabled, I get two posts by ReviewBot but 
ReviewBoard has one post with both of their tools. Example 
https://reviews.reviewboard.org/r/8262/. I tried making a custom ReviewBot 
Tool that executes both tools that I want. Is that how it's done here or 
are they using 0.3alpha. I also tried to get this working but the tool 
specific settings aren't showing up. Can I get some help with this or 
should I stick with 0.2 because it looks like 0.3 is no longer being 
developed?

Thanks,
Jerry

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from 

Review Board Ticket #4440: Interdiff is incorrect for an updated unpublished draft

[Sergey Barinov]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4440/
--

New ticket #4440 by sbarinov
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * 1.png
   

 * 2.png
   

 * 3.png
   

 * 4.png
   

 * 5.png
   

 * 6.png
   



--
Interdiff is incorrect for an updated unpublished draft
==

# What version are you running?
2.0.20

# What's the URL of the page containing the problem?
/diff/(n)-(n+1)/

# What steps will reproduce the problem?
1. Publish a new code review request
2. Add a new line of code and update the review, do not publish the new version 
- [1.png]
3. Add another new line of code and update the review again - [2.png]
4. Check the 1-2 interdiff: there last added line is not shown in the draft 
(not ok) - [2.png]
5. Check the orig-2 diff: there are all changes in the draft (ok) - [3.png]
6. Publish the draft - [4.png]
7. Check the 1-2 interdiff: there last added line is still not shown in the 
published review (not ok) - [4.png]
8. Check the orig-2 diff: there are all changes in the published review (ok) - 
[5.png]


# What is the expected output? What do you see instead?
1-2 interdiff should show me "int b = 2;" and "int c = 3;" during the draft and 
after I publish it.
Now I can see "int c = 3;" only in orig-2 interdiff.

# What operating system are you using? What browser?
Microsoft Windows 8.1 Enterprise
Google Chrome Version 51.0.2704.103 m

# Please provide any additional information below.
I use P4 with RBTools 0.5.2 in order to post (post-review changelistId) and 
update (post-review -r reviewId changelistId) review requests.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Using gitlab integration with self-signed SSL certificate

[Christian Hammond]

Hi,

Can you show me the code you've used to skip over it, and let me know the
version of Python you're using?

Also, what version of Review Board?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Jul 6, 2016 at 11:06 PM,  wrote:

> Hello,
>
> I switched to using the gitlab integration on ReviewBoard. Previously, I
> was using a custom git repository setup on the local machine where I was
> running a crontab to peridically update the local repos.
>
> ReviewBoard/Python was not happy with the self-signed cert. For now, I've
> added some code in the reviewboard source to skip the ssl verification.
> Wondering if there's a better way to configure this in ReviewBoard so that
> when I upgrade RB, I won't have to keep disabling the SSL verification.
>
> Thanks!
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: diff content information in ReviewBoard Database

[Christian Hammond]

We don't support database access outside of using the API or through our
Python modules in Review Board (as part of our extensions). It's doable,
but it's not something we want to encourage.

If you absolutely need to, it's stored as serialized JSON data in the
diffviewer_filediff table. You'll need to tie that in with the
diffviewer_diffset table, which is associated with a
diffviewer_diffsethistory, which is associated with a
reviews_reviewrequest. We don't guarantee any form of stability for the
data in these.

The API is your best choice for this. It'll be more straight-forward and
more future-proof.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Jul 6, 2016 at 11:25 PM, john levin  wrote:

> Hi Chris,
>
> Thanks ! So far i'm not using the API's (i'm not Familiar with it) and
> communicating directly to the Database. Hence can you please let me know
> where these SHA"s stored in Database (In which Table).
>
> ~John
>
> On Thu, Jul 7, 2016 at 2:42 AM, Christian Hammond <
> christ...@beanbaginc.com> wrote:
>
>> Hi John,
>>
>> Easiest way, if it works for you, might be to just fetch the uploaded
>> diff and compare. If you look at the URL for Download Diff on a review
>> request, you'll see the kind of URL you'd need to compose. Generate a diff
>> locally and compare that to the diff going in.
>>
>> Alternatively, you can compare the SHAs of the files. To do this, you
>> need to loop over all files in the diff on the review request using the
>> API. You can see this resource for info:
>>
>>
>> https://www.reviewboard.org/docs/manual/2.5/webapi/2.0/resources/file-diff-list/
>>
>> Note in the example payloads the "extra_data.patched_sha1" key. This is
>> the SHA1 of the patched file, the one going into the commit. If you want to
>> compare file contents and not the diff, you can get all these for the
>> latest diff revision on the review request, and compare those. Something to
>> note is that the file contents may be altered at some point in ways that
>> would affect the checksum (newlines normalized, file encodings being
>> applied on our end or the repository end to get contents to match up). So
>> depending on your setup, that may come into play.
>>
>> Hope that helps!
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Wed, Jul 6, 2016 at 9:44 AM, john levin  wrote:
>>
>>> Hi Chris,
>>>
>>> Thanks for your reply !
>>>
>>> We are validating the list of files in a review id and the files trying
>>> to commit in SVN (using precommit hook). But it is not a proper way.problem
>>> here is People can use the same review id and can make changes and commit
>>> to svn without updating the review. So we are trying to validate with diff
>>> or (some sort of CRC for that particular review id).
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 

Error displaying diff

[Supraja Kumaravel]

"There was an error displaying this diff. The patch to 'pom.xml' didn't 
apply cleanly. The temporary files have been left in 
'/tmp/reviewboard.5kc5pw' for debugging purposes. `patch` returned: This 
may be a bug in the software, a temporary outage, or an issue with the form"

   I will give you details of how I had set up the repository.
I cloned it from the main url: git clone 
Sunced from another branch: git checkout 
git pull
Created a local branch: git checkout -b 
Then edited some of the exixting files and added new files.
For the first time without staging the newly added files I committed the 
edited ones and posted a review.
Then again adding the newly added files I commited and got a new commit id 
and posted the review for that.
Then there was corrections to be made to those files.So I edited those 
files and committed. But now when I post review using commands, post-review 
 or post-review  -r  there 
was an error in displaying the diff.
So now I get this error only when i edit those existing files and if I add 
a new file it is diaplyed correctly.
Can any one please provide me a solution for this?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.